Differential D12703

avoid scanning a file again if it has not been modified
ClosedPublic
Actions

Authored by mgallien on May 4 2018, 9:36 PM.

Details

Reviewers

astippich

Group Reviewers

Elisa

Maniphest Tasks

T7603: When scanning local files, keep their last modified time and do not scan them again if they have not changed

Commits

R255:cfbd322ec059: avoid scanning a file again if it has not been modified
R255:d5a4d2b8f77f: avoid scanning a file again if it has not been modified

Summary

avoid scanning a file again if it has not been modified

ensure we get correct behavior on application start with existing tracks

clean up of obsolete way to track removed tracks between application starts

do not yet remove tracks that have been removed when the application was not
running. This is a regression that I will fix later.

BUG: 391892

Test Plan

mostly works but subsequent starts are much faster

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.May 4 2018, 9:36 PM

mgallien created this revision.

Please test and provide feedback. The work is not finished but it mostly should starts much faster while still updating modified tracks at start.

mgallien added a task: T7603: When scanning local files, keep their last modified time and do not scan them again if they have not changed.May 4 2018, 9:40 PM

mgallien retitled this revision from avoid scanning a file again if it has not been modified to [WIP] avoid scanning a file again if it has not been modified.May 5 2018, 9:25 AM

mgallien edited the summary of this revision. (Show Details)

I did a quick test without changing files between runs, the first startup took a few seconds to finish importing but subsequent startups were instantaneous. This is looking really good.

check old files that have been removed when restoring existing tracks

mgallien retitled this revision from [WIP] avoid scanning a file again if it has not been modified to avoid scanning a file again if it has not been modified.May 7 2018, 5:30 AM

mgallien edited the summary of this revision. (Show Details)May 7 2018, 5:35 AM

mgallien added a dependent revision: D12785: [WIP] introduce GenericDataModel and ModelDataCache to have a generic model.May 9 2018, 5:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 9 2018, 5:09 PM

Closed by commit R255:cfbd322ec059: avoid scanning a file again if it has not been modified (authored by mgallien). · Explain Why

This revision was automatically updated to reflect the committed changes.

It has been closed when pushing a feature branch with it. Sorry for the noise.

haven't noticed any issues

This revision is now accepted and ready to land.May 9 2018, 6:21 PM

Closed by commit R255:d5a4d2b8f77f: avoid scanning a file again if it has not been modified (authored by mgallien). · Explain WhyMay 9 2018, 7:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/databaseinterfacetest.cpp (236 lines)
M			autotests/localfilelistingtest.cpp (86 lines)
M			src/abstractfile/abstractfilelistener.h (14 lines)
M			src/abstractfile/abstractfilelistener.cpp (25 lines)
M			src/abstractfile/abstractfilelisting.h (23 lines)
M			src/abstractfile/abstractfilelisting.cpp (68 lines)
M			src/baloo/localbaloofilelisting.h (2 lines)
M			src/baloo/localbaloofilelisting.cpp (24 lines)
M			src/databaseinterface.h (15 lines)
M			src/databaseinterface.cpp (344 lines)
M			src/elisaqmlplugin.cpp (1 line)
M			src/elisautils.cpp (2 lines)
M			src/file/localfilelisting.h (2 lines)
M			src/file/localfilelisting.cpp (7 lines)
M			src/musicaudiotrack.cpp (2 lines)
M			src/musiclistenersmanager.h (8 lines)
M			src/musiclistenersmanager.cpp (57 lines)
M			src/qml/TrackImportNotification.qml (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33662	78444c2		May 4 2018, 9:36 PM	★	★
Diff 2	33741	78444c2	- check old files that have been removed when restoring existing tracks	May 7 2018, 5:30 AM	★	★
Diff 3	33898	1d9aa89	R255:cfbd322ec059b53271dea9aefcbf5d69b136b13b	May 8 2018, 8:39 PM	★	★
Diff 4	33906	937c8aa	R255:d5a4d2b8f77f26cbba44579c3659d4afec12501b	May 9 2018, 7:28 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
02ae628e6c09	16f991ecf960	2549a71b84f0	Matthieu Gallien	check old files that have been removed when restoring existing tracks	May 7 2018, 5:29 AM
2549a71b84f0	c5a05db51136	05ecbafb7ece	Matthieu Gallien	avoid scanning a file again if it has not been modified (Show More…)	May 4 2018, 9:16 PM
05ecbafb7ece	bbcc038f0186	1dd9416ad1dc	Matthieu Gallien	ensure we get correct behavior on application start with existing tracks	May 4 2018, 3:59 PM
1dd9416ad1dc	93abefcf1679	78444c2ba695	Matthieu Gallien	avoid scanning a file again if it has not been modified	May 3 2018, 8:49 PM

	Status	Author	Revision
	Abandoned	mgallien	D12785 [WIP] introduce GenericDataModel and ModelDataCache to have a generic model
	Closed	mgallien	D12703 avoid scanning a file again if it has not been modified

avoid scanning a file again if it has not been modifiedClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 33906

autotests/databaseinterfacetest.cpp

autotests/localfilelistingtest.cpp

src/abstractfile/abstractfilelistener.h

src/abstractfile/abstractfilelistener.cpp

src/abstractfile/abstractfilelisting.h

src/abstractfile/abstractfilelisting.cpp

src/baloo/localbaloofilelisting.h

src/baloo/localbaloofilelisting.cpp

src/databaseinterface.h

src/databaseinterface.cpp

src/elisaqmlplugin.cpp

src/elisautils.cpp

src/file/localfilelisting.h

src/file/localfilelisting.cpp

src/musicaudiotrack.cpp

src/musiclistenersmanager.h

src/musiclistenersmanager.cpp

src/qml/TrackImportNotification.qml

avoid scanning a file again if it has not been modified
ClosedPublic
Actions

Revision Contents
Changeset List