In D25361#566193, @ngraham wrote:

I share you concern about this KCM becoming a dumping ground. But I don't see a better place for this setting right now. And I think it does make some sense for it to hold general behavioral settings that affect both apps and Plasma.

What about something like most Goal: Consistency contributions from new contributors?

Plus in the screenshot it looks like it's still not quite the same height.

In T10568#208729, @michaeltunnell wrote:

I think it should totally be a upstream Plasma thing 🗡

Also, I think the search should look through all components/categories instead of you having to manually find the correct component/category.

Ping :-)

In D25351#563677, @ngraham wrote:

I think the only way to satisfactorily do that is to remove the GTK KCM entirely, and then the remaining KCM can keep its current name ("Application Style"). I'm in favor of that, but we're not there yet.

I thought we wanted to merge the GTK Application Style with this KCM, and have the GTK theme comboxes accessible with a button in the KCM (like for the toolbar style)? I wouldn't rename the KCM until we are sure that we don't want to merge the two KCMs. Especially since the GTK KCM will soon only have two comboboxes and a checkbox, and a separate KCM would be a bit too much.

@hein If you really still think we shouldn't do this then I can change this patch to only affect the "Show Only Minimized" option and close the bug as INTENTIONAL.

In D24798#562431, @guoyunhe wrote:

Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides.

In T10201#207994, @pedrogomes1698 wrote:

Having the line separated from the titlebar separator would make it a bit better, if we were to stick to this overall look.

Ok, then we should keep it in the GTK KCM until we have the option for Qt applications in the Application Style KCM.

In D25149#559684, @tcanabrava wrote:

We need a better icon. it's the icon for the Plasmoid template.

In D25123#560491, @ndavis wrote:

I think I prefer C the most now that I've seen it next to other icons. It has a similar level of detail to other Breeze icons.

Remove unneeded properties

Move into AudioStream

Ping.

I wonder, can that be added to mouse actions instead of a page with only one option?

+1

"Close" -> "Finish Customizing Layout"

Ping.

In the Desktop Effects KCM the info label is top-left aligned.

In D24265#551189, @mart wrote:

• don't dismiss applet edit mode when overing the handle

Avoid negating entire boolean statements

In D24162#551673, @ngraham wrote:

Oh, so that would need to be done in D24839 then?

In D24162#551671, @ngraham wrote:

The Edit Panel menu item probably shouldn't be visible while that panel is currently being edited:

Rebase

Rebase

Don't hide lock action here

Ping.

Ping.

In D24265#549640, @mart wrote:

i would prefer not to, but can be tried with eventually in the future

Why not? Currently you have to open the context menu for the panel or desktop, so it's inconsistent and confusing if you want to move a widget and then don't get the option to in the menu (without click+hold).

I'd also add the "Customize Layout..." menu item to the widget context menu, that way you can discover it much more easily.

An "Add Panel..." button in the toolbox would be very useful too :-)

Only one last issue: the widget resizing handles disappear if the cursor is on a blank area of the widget handle (the bar to the left/right).

In D24744#549486, @gikari wrote:

In D24744#549450, @GB_2 wrote

Well, it'll be gone completely soon and the GTK theme comboboxes will be in the Application Style KCM.

Where would gtk theme installation buttons go?

In D24744#549444, @filipf wrote:

So much nicer, awesome work. +1 for the visuals of the rehauled kcm.

Can we also set the root folder icon?

Wow, it's so empty now! Great job!

Can we align the header with the search field/content here?

Can you clean the SVGs a bit?

Love the test plan and branch 😂

In D24533#544784, @filipf wrote:

This sort of a style, the line is right next to the title.

In D24318#542048, @ndavis wrote:

Yeah, that was a feature of the original icon that I didn't remove. I wasn't so sure about it either.