YakuakeProject
ActivePublic

Recent Activity

Fri, May 29

ngraham added a comment to D29669: Fix computing screen geometry on multiple HiDPI monitors.

Thanks! You can close this now.

Fri, May 29, 4:31 PM · Yakuake

Wed, May 27

printesoi added a comment to D29669: Fix computing screen geometry on multiple HiDPI monitors.

@ngraham Done, thank you!

Wed, May 27, 8:00 AM · Yakuake

Tue, May 26

ngraham added a comment to D29669: Fix computing screen geometry on multiple HiDPI monitors.

Thanks! This might get a bit more attention if you re-submit it as a merge request at https://invent.kde.org/utilities/yakuake/-/merge_requests, now that KDE has moved patch review to GitLab. Here's some documentation if you're unfamiliar with the workflow: https://community.kde.org/Infrastructure/GitLab

Tue, May 26, 10:37 PM · Yakuake

Thu, May 14

printesoi updated the diff for D29669: Fix computing screen geometry on multiple HiDPI monitors.

Fix crash when unplugging monitor on which Yakuake is set to open

Thu, May 14, 3:34 PM · Yakuake

Wed, May 13

ngraham added a reviewer for D29669: Fix computing screen geometry on multiple HiDPI monitors: KDE Applications.
Wed, May 13, 7:08 PM · Yakuake

Tue, May 12

printesoi updated the diff for D29669: Fix computing screen geometry on multiple HiDPI monitors.

Fixed a problem in MainWindow::getScreen() due to the fact the list of screens is 0 based while Yakuake stores the screen number starting from 1.

Tue, May 12, 11:15 AM · Yakuake

Mon, May 11

mweepigeon resigned from D29669: Fix computing screen geometry on multiple HiDPI monitors.

Afraid I don't have HiDPI displays to test with. Glad the issue is finally seeing work though!

Mon, May 11, 10:00 PM · Yakuake
printesoi added reviewers for D29669: Fix computing screen geometry on multiple HiDPI monitors: hein, ngraham, mweepigeon.
Mon, May 11, 9:45 PM · Yakuake
printesoi requested review of D29669: Fix computing screen geometry on multiple HiDPI monitors.
Mon, May 11, 9:44 PM · Yakuake

Apr 10 2020

jdb314 added a watcher for Yakuake: jdb314.
Apr 10 2020, 10:25 AM

Mar 10 2020

muesli added inline comments to D22227: Add support for resizing by dragging the title bar.
Mar 10 2020, 5:46 PM · Yakuake
muesli added inline comments to D22227: Add support for resizing by dragging the title bar.
Mar 10 2020, 5:44 PM · Yakuake
ngraham closed D22227: Add support for resizing by dragging the title bar.
Mar 10 2020, 4:08 PM · Yakuake
ngraham updated the summary of D22227: Add support for resizing by dragging the title bar.
Mar 10 2020, 4:08 PM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Fixed copyright statements.

Mar 10 2020, 2:48 AM · Yakuake
ngraham added inline comments to D22227: Add support for resizing by dragging the title bar.
Mar 10 2020, 2:04 AM · Yakuake
ryanmccoskrie added a comment to D22227: Add support for resizing by dragging the title bar.

On a related note, I uploaded another patch that reformats the rest of Yakuake's if statements to match the ones here.

Mar 10 2020, 1:33 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Added copyright statement

Mar 10 2020, 1:30 AM · Yakuake

Mar 8 2020

ngraham added a comment to D22227: Add support for resizing by dragging the title bar.

@ryanmccoskrie can you provide an email address so we can land this patch with correct attribution? Thanks again for the lovely contribution!

Mar 8 2020, 4:22 PM · Yakuake
mweepigeon accepted D22227: Add support for resizing by dragging the title bar.

Awesome!

Mar 8 2020, 4:10 PM · Yakuake
ngraham accepted D22227: Add support for resizing by dragging the title bar.

LGTM. @mweepigeon? Since you requested changed, you'll nedd to re-review and change your status to Accepted if you're happy with it now.

Mar 8 2020, 4:07 PM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Fixed formatting and added comments

Mar 8 2020, 2:59 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.
  • Merge branch 'master' into 154686-Resize_on_title_drag
  • * Now conforms to KDE style guidelines
  • * C++ dynamic cast instead of C cast
  • * renamed parent to window in TitleBar::mouseMoveEvent()
  • Merge branch 'master' into 154686-Resize_on_title_drag
  • Merge branch 'master' into 154686-Resize_on_title_drag
  • TitleBar now uses the vertical-resize cursor
  • Fixed titlebar buttons using vertical-size cursor
Mar 8 2020, 2:46 AM · Yakuake
mweepigeon added a comment to D22227: Add support for resizing by dragging the title bar.

Dragging and icon seem to be working for me! I think it should be good once you take care of the style change requests

Mar 8 2020, 1:47 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Fixed menu buttons using vertical-size cursor.

Mar 8 2020, 1:37 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

The Title Bar now indicates it is resizeable with a vertical size cursor.

Mar 8 2020, 1:03 AM · Yakuake
ryanmccoskrie added a comment to D22227: Add support for resizing by dragging the title bar.

@ryanmccoskrie sorry this got lost. Would you be interested in finishing it up so we can get it landed?

Mar 8 2020, 12:22 AM · Yakuake

Mar 1 2020

ngraham added a comment to D22227: Add support for resizing by dragging the title bar.

@ryanmccoskrie sorry this got lost. Would you be interested in finishing it up so we can get it landed?

Mar 1 2020, 2:41 AM · Yakuake

Feb 29 2020

mweepigeon requested changes to D22227: Add support for resizing by dragging the title bar.

Resizing the window works great, and the 'flickering' effect is relatively minor. However, the cursor should change when it is over the titlebar to indicate to the user that they are able to drag to resize it - ideally the vertical double arrow cursor icon

Feb 29 2020, 5:58 PM · Yakuake
mweepigeon added a watcher for Yakuake: mweepigeon.
Feb 29 2020, 4:10 PM
ngraham closed D25123: New yakuake logo/icon.
Feb 29 2020, 3:30 PM · Yakuake, Frameworks
ngraham added a task to D25123: New yakuake logo/icon: T10243: Some KDE applications could use better icons.
Feb 29 2020, 3:28 PM · Yakuake, Frameworks
ngraham updated the summary of D25123: New yakuake logo/icon.
Feb 29 2020, 3:27 PM · Yakuake, Frameworks
mweepigeon accepted D25123: New yakuake logo/icon.

Looks great to me!

Feb 29 2020, 3:24 PM · Yakuake, Frameworks
ngraham added a comment to D25123: New yakuake logo/icon.

@mglb ping

Feb 29 2020, 3:02 PM · Yakuake, Frameworks

Feb 11 2020

ngraham added a comment to D25123: New yakuake logo/icon.

If you land this please update the summary before. No need to have all the variants in the commit message it should be about the actual change. Thanks :)

Feb 11 2020, 2:56 PM · Yakuake, Frameworks
ndavis accepted D25123: New yakuake logo/icon.
Feb 11 2020, 11:53 AM · Yakuake, Frameworks

Feb 7 2020

davidre added a comment to D25123: New yakuake logo/icon.

If you land this please update the summary before. No need to have all the variants in the commit message it should be about the actual change. Thanks :)

Feb 7 2020, 7:55 AM · Yakuake, Frameworks
mglb retitled D25123: New yakuake logo/icon from [WIP] New yakuake logo/icon to New yakuake logo/icon.
Feb 7 2020, 12:34 AM · Yakuake, Frameworks
mglb updated the diff for D25123: New yakuake logo/icon.

Huh, I was waiting for @hein :) oh well, here it is - C icon with cleaned up source

Feb 7 2020, 12:34 AM · Yakuake, Frameworks

Feb 4 2020

ngraham added a comment to D25123: New yakuake logo/icon.

@mglb ping! I feel like we're really close for this.

Feb 4 2020, 12:12 AM · Yakuake, Frameworks

Dec 5 2019

numerodix added a watcher for Yakuake: numerodix.
Dec 5 2019, 6:53 AM

Nov 10 2019

ngraham added a comment to D25123: New yakuake logo/icon.

Agreed, C for me too.

Nov 10 2019, 5:36 AM · Yakuake, Frameworks

Nov 9 2019

GB_2 added a comment to D25123: New yakuake logo/icon.

I think I prefer C the most now that I've seen it next to other icons. It has a similar level of detail to other Breeze icons.

Nov 9 2019, 9:01 PM · Yakuake, Frameworks
ndavis added a comment to D25123: New yakuake logo/icon.

I think I prefer C the most now that I've seen it next to other icons. It has a similar level of detail to other Breeze icons.

Nov 9 2019, 9:00 PM · Yakuake, Frameworks
mglb updated the diff for D25123: New yakuake logo/icon.

switching to that system means we would need to change many icons.

Nov 9 2019, 8:00 PM · Yakuake, Frameworks

Nov 4 2019

ndavis added a comment to D25123: New yakuake logo/icon.
In D25123#558353, @mglb wrote:

Breaking nice-looking proportions just to fill vertical space is not good IMO. Making the bar a bit higher might make it look more reasonably. Your second proposition (icon C) looks nice though.

Nov 4 2019, 4:01 AM · Yakuake, Frameworks
mglb added a comment to D25123: New yakuake logo/icon.

I tried seeing how it would look extended down to the bottom margin:

Nov 4 2019, 3:18 AM · Yakuake, Frameworks

Nov 3 2019

ngraham added a comment to D25123: New yakuake logo/icon.

VDG, Should we allow some types of icons to be vertically off center? If not that, should we allow some icons to not reach all the way to the top and bottom margins? There are already some icons like that, but that doesn't necessarily mean we should want that.

Nov 3 2019, 7:44 PM · Yakuake, Frameworks
ndavis added a comment to D25123: New yakuake logo/icon.

A or C for me.

Nov 3 2019, 6:55 PM · Yakuake, Frameworks