YakuakeProject
ActivePublic

Recent Activity

Aug 14 2019

ryanmccoskrie added a comment to D22227: Add support for resizing by dragging the title bar.
In D22227#495177, @hein wrote:

The resize should happen in the same steps as the config allows (and reads/writes), otherwise the UI will end up being confused, in particular the menu.

Aug 14 2019, 10:24 PM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Switched from C style cast to dynamic cast.

Aug 14 2019, 10:21 PM · Yakuake

Jul 14 2019

hein added a comment to D22227: Add support for resizing by dragging the title bar.

The resize should happen in the same steps as the config allows (and reads/writes), otherwise the UI will end up being confused, in particular the menu.

Jul 14 2019, 8:21 AM · Yakuake

Jul 9 2019

ngraham added a comment to D21867: [Yakuake] add blur effect support.

Thanks Owen, very nice first patch! May it be just the first of many. :)

Jul 9 2019, 7:08 PM · Yakuake
ngraham closed D21867: [Yakuake] add blur effect support.
Jul 9 2019, 7:00 PM · Yakuake

Jul 8 2019

owenchia added a comment to D21867: [Yakuake] add blur effect support.

@owenchia, can you provide your email address so we can land this patch with correct authorship information? Thanks!

Jul 8 2019, 4:47 PM · Yakuake

Jul 7 2019

ryanmccoskrie added inline comments to D22227: Add support for resizing by dragging the title bar.
Jul 7 2019, 3:55 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Adjusted formatting to fit KDE style guidelines.

Jul 7 2019, 3:51 AM · Yakuake

Jul 5 2019

ngraham added inline comments to D22227: Add support for resizing by dragging the title bar.
Jul 5 2019, 12:52 PM · Yakuake
ngraham added a reviewer for D22227: Add support for resizing by dragging the title bar: hein.
Jul 5 2019, 12:36 PM · Yakuake
ngraham updated the summary of D22227: Add support for resizing by dragging the title bar.
Jul 5 2019, 12:35 PM · Yakuake

Jul 4 2019

ngraham added a comment to D21867: [Yakuake] add blur effect support.

@owenchia, can you provide your email address so we can land this patch with correct authorship information? Thanks!

Jul 4 2019, 6:19 PM · Yakuake

Jul 3 2019

ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Got the whole change into request, not just a one-line touch up.

Jul 3 2019, 2:58 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.
Jul 3 2019, 2:55 AM · Yakuake

Jul 2 2019

hein accepted D21867: [Yakuake] add blur effect support.

I've resisted patches like this for years now hoping someone would implement this properly in the Konsole KPart as part of the profile system where translucency is regulated, but no one did, so let's go with this.

Jul 2 2019, 1:45 AM · Yakuake

Jul 1 2019

GB_2 added a comment to D21867: [Yakuake] add blur effect support.

Ping

Jul 1 2019, 2:03 PM · Yakuake

Jun 30 2019

vmarinescu added a watcher for Yakuake: vmarinescu.
Jun 30 2019, 5:58 PM

Jun 25 2019

ryanmccoskrie added a member for Yakuake: ryanmccoskrie.
Jun 25 2019, 11:08 PM
ryanmccoskrie added a watcher for Yakuake: ryanmccoskrie.
Jun 25 2019, 11:08 PM

Jun 17 2019

owenchia added a comment to D21867: [Yakuake] add blur effect support.

Maybe, but that's a design change, not just the addition of a new feature, so now the title/commit message is not accurate; you're not just adding support for blur, you're turning it on by default.

You need to either change the commit message to reflect the actual changes, or (preferably) only add support in this patch, and turn it on by default in another patch.

Jun 17 2019, 2:14 PM · Yakuake
owenchia updated the diff for D21867: [Yakuake] add blur effect support.

change Blur option's default value to false.

Jun 17 2019, 1:59 PM · Yakuake
ngraham added a comment to D21867: [Yakuake] add blur effect support.

Thanks very much for the patch!

Is having this on the best default? This is not actually a sarcastic rhetorical question; I'm genuinely asking since I don't actually use Yakuake.

I'm not a expert, but i think it's the best to having this blur effect on default.

Jun 17 2019, 1:43 PM · Yakuake
owenchia added a comment to D21867: [Yakuake] add blur effect support.

Thanks very much for the patch!

Is having this on the best default? This is not actually a sarcastic rhetorical question; I'm genuinely asking since I don't actually use Yakuake.

Jun 17 2019, 6:38 AM · Yakuake
ngraham added a reviewer for D21867: [Yakuake] add blur effect support: hein.
Jun 17 2019, 4:52 AM · Yakuake
ngraham added a comment to D21867: [Yakuake] add blur effect support.

Thanks very much for the patch!

Jun 17 2019, 4:52 AM · Yakuake
owenchia updated the summary of D21867: [Yakuake] add blur effect support.
Jun 17 2019, 2:01 AM · Yakuake
owenchia requested review of D21867: [Yakuake] add blur effect support.
Jun 17 2019, 2:00 AM · Yakuake

May 23 2019

hein added a comment to D21358: Prevent the Yakuake Task from Showing up in the Task Bar.

It's not that easy I'm afraid.

May 23 2019, 6:12 AM · Yakuake
ngraham added a reviewer for D21358: Prevent the Yakuake Task from Showing up in the Task Bar: hein.
May 23 2019, 4:47 AM · Yakuake
fstpierre requested review of D21358: Prevent the Yakuake Task from Showing up in the Task Bar.
May 23 2019, 3:53 AM · Yakuake

Mar 24 2019

ngraham closed D19835: [Yakuake] Improve customization.
Mar 24 2019, 6:18 PM · Yakuake

Mar 22 2019

chauvin updated the diff for D19835: [Yakuake] Improve customization.
Mar 22 2019, 11:35 PM · Yakuake
chauvin updated the diff for D19835: [Yakuake] Improve customization.
Mar 22 2019, 10:59 PM · Yakuake
chauvin added a comment to D19835: [Yakuake] Improve customization.

ok I make some cleanup

Mar 22 2019, 10:51 PM · Yakuake
hein accepted D19835: [Yakuake] Improve customization.
Mar 22 2019, 10:29 PM · Yakuake
chauvin updated the diff for D19835: [Yakuake] Improve customization.
Mar 22 2019, 10:18 PM · Yakuake

Mar 18 2019

ngraham added a comment to D19833: Remove double scrollbar in appearance settings.

Thanks for all these nice Yakuake patches, Lionel!

Mar 18 2019, 11:14 PM · Yakuake
ngraham closed D19833: Remove double scrollbar in appearance settings.
Mar 18 2019, 11:13 PM · Yakuake
ngraham retitled D19833: Remove double scrollbar in appearance settings from [Yakuake] Remove double scrollbar in appearance settings to Remove double scrollbar in appearance settings.
Mar 18 2019, 11:13 PM · Yakuake
hein accepted D19833: Remove double scrollbar in appearance settings.
Mar 18 2019, 8:27 PM · Yakuake
chauvin added a reviewer for D19833: Remove double scrollbar in appearance settings: Yakuake.
Mar 18 2019, 7:07 PM · Yakuake
chauvin added a reviewer for D19835: [Yakuake] Improve customization: Yakuake.
Mar 18 2019, 7:05 PM · Yakuake

Mar 17 2019

chauvin requested review of D19835: [Yakuake] Improve customization.
Mar 17 2019, 4:59 PM · Yakuake
chauvin requested review of D19833: Remove double scrollbar in appearance settings.
Mar 17 2019, 4:40 PM · Yakuake

Mar 10 2019

hein added a comment to D13335: Fix Skin validation when installed from KNS.

Boom! Landed it for you. Sorry this took so long!

Mar 10 2019, 7:31 AM · Yakuake
hein closed D13335: Fix Skin validation when installed from KNS.
Mar 10 2019, 7:31 AM · Yakuake

Mar 7 2019

chauvin added a comment to D13335: Fix Skin validation when installed from KNS.

I don't think I have dev access.
I don't know how to commit from phabricator.

Mar 7 2019, 7:31 PM · Yakuake
hein accepted D13335: Fix Skin validation when installed from KNS.

Looks good now!

Mar 7 2019, 6:03 PM · Yakuake

Mar 5 2019

chauvin updated the summary of D13335: Fix Skin validation when installed from KNS.
Mar 5 2019, 7:54 PM · Yakuake
chauvin added a comment to D13335: Fix Skin validation when installed from KNS.

Can someone take a look to this patch ?
Thanks.

Mar 5 2019, 7:53 PM · Yakuake