Differential D25049

Conditionally show navigation buttons in the header for multi-page KCMs
ClosedPublic
Actions

Authored by ngraham on Oct 29 2019, 5:36 PM.

Details

Reviewers
mart
Group Reviewers
VDG
Plasma
Commits
R295:47f23c0f6ad1: Conditionally show navigation buttons in the header for multi-page KCMs
Summary

This makes the navigeability of multi-page KCMs completely obvious. The buttons only show
up in multi-page KCMs where you've navigated into a sub-page, so there is no visual
regression for anyone else.

Test Plan

Diff Detail

Repository
R295 KCMUtils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 29 2019, 5:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 29 2019, 5:36 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 29 2019, 5:36 PM
ngraham added a comment.Oct 31 2019, 8:30 PM

No regressions found and seems low-risk. Landing now to get it into 5.64 ahead of tagging on Nov 2nd.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 31 2019, 8:35 PM
Closed by commit R295:47f23c0f6ad1: Conditionally show navigation buttons in the header for multi-page KCMs (authored by ngraham). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcmoduleqml.cpp (2 lines)

Diff 69138

View Options

src/kcmoduleqml.cpp

Loading...