needed for the context menu entry
ngraham davidedmundson GB_2
- Group Reviewers
- Maniphest Tasks
- T10402: Find a way to remove the Desktop Toolbox in its current form (i.e. a hamburger menu button in the corner of the screen)
T11094: Improve discoverability of widget configuration
T10190: (Re)define modes when editing panels and widgets
- R242:acbb200ac2cc: edit mode action
with the p-w- portion the action shows in the context menu
This isn't just editing editing widgets; maybe "Enter Edit Mode" ? That would make the name better correspond with the text of the opposite state too.
i think in the end
Customize Layout/Finish Customizing Layout
i prefer not to name the term "mode" at all if i can, both because is kinda a nerdy term and because modes are an ux cardinal sin, so at least not being too proud of it ;)
GB_2's comment needs fixing, two strings are out of sync.
Other than that, ship it.
Given how easy it is to get these out of sync, can I suggest removing all the code to update editAction's text from Corona::setEditMode and put it in a connect here. It'll keep the editAction logic altogether.