[KCMs/Night Color] Explain Night Color feature inline
ClosedPublic

Authored by ngraham on Thu, Oct 24, 12:56 AM.

Details

Summary

All the other platforms that have implemented this feature offer a little inline
explanation of what it is and what it does, but we do not. I think it makes sense to add
our own, since it's not a totally intuitive thing.

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Thu, Oct 24, 12:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Oct 24, 12:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Thu, Oct 24, 12:56 AM
ndavis accepted this revision.Thu, Oct 24, 6:49 AM
ndavis added a subscriber: ndavis.

I was going to suggest that we use the module subtitle for this, but it looks like we don't use those anymore.

This revision is now accepted and ready to land.Thu, Oct 24, 6:49 AM
zzag accepted this revision.Thu, Oct 24, 8:57 AM
zzag added a comment.Thu, Oct 24, 8:59 AM

[KCMs/Night Color]

Plasma folks don't use such scopes. They prefer, correct me if I'm wrong, something like "[Night Color KCM]".

This comment was removed by davidedmundson.

They prefer, correct me if I'm wrong, something like "[Night Color KCM]".

Plasma folks don't really have a good style sorted. You can find examples of 3 different styles.

It is a good point that we miss a consistency :/
but it also means no individual commit is wrong right now.

Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means?

ngraham updated this revision to Diff 68704.Thu, Oct 24, 4:41 PM

Tweak wording and set a maximum width for the label

Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means?

I would hope so; warm vs cool colors is a grade-school-level-art-class concept . :) We also use "warm" and "Cool" for the slider's explanatory labels.

This revision was automatically updated to reflect the committed changes.
GB_2 added a subscriber: GB_2.EditedThu, Oct 24, 4:42 PM

In the Desktop Effects KCM the info label is top-left aligned.

The desktop effects KCM doesn't have a centered form layout like this one does. I tried a left-aligned label but it looked quite odd.