special ui changes if root directory is selected
Old:
New:
ngraham | |
GB_2 |
VDG | |
Frameworks |
special ui changes if root directory is selected
Old:
New:
No Linters Available |
No Unit Test Coverage |
Buildable 17877 | |
Build 17895: arc lint + arc unit |
src/widgets/kpropertiesdialog.cpp | ||
---|---|---|
1177 | Probably not so obvious for new Linux users; especially those coming from windows where things are represented as C:\, D:\ ... etc. |
src/widgets/kpropertiesdialog.cpp | ||
---|---|---|
1177 | I think new linux users don't even know what mounting means :) |
I would suggest keeping "Location" and "Mounted on" fields to actually display '/' to the user.
Especially for newbies users who might not know what "Root Directory" means.
But for more advanced user it would make sense too as / is currently visible only in the icon, it would feel amiss.
/ is not such a special case as other mount points, and consistency matter, even if redundant on this edge case.
To me the size, the name and icon change are sufficient here.
src/widgets/kpropertiesdialog.cpp | ||
---|---|---|
1113 | Replace with Unkwown |
To me users should know that / is the root folder and has the highest level in the directory structure. And that the location of '/' is '/' is quite confusing.
In principle I like the idea of customizing the display to be more appropriate. However I feel like the best way to do this might be to go in a different direction: instead of adding overrides for /, maybe we should take advantage of the fact that / is always a mounted volume and instead make the properties dialog reflect the name and icon of the disk in question. Otherwise when you look at the properties for that disk, the dialog that appears shows a different name and icon from the thing that was clicked on.
If we improve the properties dialog for disks in general, that will also improve the display for other kinds of disks and mounted volumes.
What do you think?
I like this idea. However this is exceeds my skill set :)
But I think that my change is an improvement and maybe we can use your idea for another commit