[containments/desktop] Delete the "Tweaks" page and its options
ClosedPublic

Authored by ngraham on Oct 29 2019, 6:42 PM.

Details

Summary

With the new global edit mode, both of the options on the Tweaks page become unnecessary:

  • The option to hide the toolbox becomes dangerous because it breaks global edit mode
  • The option to toggle press-and-hold is unnecessary with the far superior global edit mode
Test Plan
  • Right-click desktop > Configure Desktop > No "Tweaks" page at the bottom of the list:
  • Widget moving, resizing, and editing behaviors in side and out of edit mode are unchanged
  • You can no longer turn off the toolbox and break edit mode
  • You can no longer toggle the press-and-hold checkbox to show widget handles by hovering over widgets for a few seconds

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 29 2019, 6:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 29 2019, 6:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 29 2019, 6:42 PM

It occurs to me that we'll need a kconf update script to turn the desktop toolbox back on for all the legions of people who turned off via this setting that I'm removing here, or else the new global edit mode won't work for them.

+1

containments/desktop/package/contents/ui/main.qml
268

A conf update isn't needed as it's this code hiding the toolbox when disabled, so without it it will just always show

ngraham marked an inline comment as done.Oct 30 2019, 2:58 PM
ngraham added inline comments.
containments/desktop/package/contents/ui/main.qml
268

Ah of course!

mart added a comment.Oct 30 2019, 3:06 PM

I would prefer keeping the press to move stuff

ngraham marked an inline comment as done.Oct 30 2019, 3:06 PM
In D25055#556751, @mart wrote:

I would prefer keeping the press to move stuff

As far as I could tell, the option on this page doesn't actually change anything anymore. What am I missing?

GB_2 added a comment.Oct 30 2019, 3:07 PM
This comment was removed by GB_2.
mart added a comment.Oct 30 2019, 3:07 PM
In D25055#556751, @mart wrote:

I would prefer keeping the press to move stuff

As far as I could tell, the option on this page doesn't actually change anything anymore. What am I missing?

it makes the handles appear on mouse over, like they did in kde4, i spent a lot of time to make that work in the new layout

GB_2 added a comment.Oct 30 2019, 3:09 PM

I wonder, can that be added to mouse actions instead of a page with only one option?

mart added a comment.Oct 30 2019, 3:10 PM
In D25055#556756, @GB_2 wrote:

I wonder, can that be added to mouse actions instead of a page with only one option?

makes sense

In D25055#556755, @mart wrote:
In D25055#556751, @mart wrote:

I would prefer keeping the press to move stuff

As far as I could tell, the option on this page doesn't actually change anything anymore. What am I missing?

it makes the handles appear on mouse over, like they did in kde4, i spent a lot of time to make that work in the new layout

Can you be specific about how the behavior gets invoked? For me, when not in edit mode, the handles now always appear on hover, while outside of edit mode, the handles now only appear on press-and-hold. None of this changes regardless of whether or not the press-and-hold setting in Tweaks is checked.

mart added a comment.Oct 31 2019, 10:16 AM
In D25055#556755, @mart wrote:
In D25055#556751, @mart wrote:

I would prefer keeping the press to move stuff

As far as I could tell, the option on this page doesn't actually change anything anymore. What am I missing?

it makes the handles appear on mouse over, like they did in kde4, i spent a lot of time to make that work in the new layout

Can you be specific about how the behavior gets invoked? For me, when not in edit mode, the handles now always appear on hover, while outside of edit mode, the handles now only appear on press-and-hold. None of this changes regardless of whether or not the press-and-hold setting in Tweaks is checked.

here they do appear on hover and delay

Ahh, I wasn't hovering for long enough. I see it now.

After finally understanding and using this feature, I really think we should discard it. Actually explaining it in the UI in a way that would make it comprehensible would require an incredibly wordy checkbox like

[] Show widget handles when hovering over widgets for a few seconds while outside of edit mode

Also, what does it really gain us? "Long hover" is no faster than "long press" and less intuitive. I don't really see the gain.

hein added a comment.Oct 31 2019, 2:00 PM

If we want to keep the handles-on-hover outside of Edit Mode, is there a reason it can't be always on and needs to be gated behind a checkbox?

I have to admit though I have a hard time seeing users like/rely on this behavior. Hovering and just waiting, even once you've learned it's possible, is always going to be an unsatisfying user experience - you're literally waiting around until the system deigns to approve your intent (long-press, in contrast is still active to some extent). I'd be worried that some users might learn "long hover" as "this is how it's supposed to be done" and then be forever annoyed that widgets are so cumbersome to handle. I'd propose removing it and fully leading users towards Edit Mode instead?

In D25055#557216, @hein wrote:

I have to admit though I have a hard time seeing users like/rely on this behavior. Hovering and just waiting, even once you've learned it's possible, is always going to be an unsatisfying user experience - you're literally waiting around until the system deigns to approve your intent (long-press, in contrast is still active to some extent). I'd be worried that some users might learn "long hover" as "this is how it's supposed to be done" and then be forever annoyed that widgets are so cumbersome to handle. I'd propose removing it and fully leading users towards Edit Mode instead?

Exactly my thoughts.

ngraham edited the summary of this revision. (Show Details)Oct 31 2019, 2:03 PM
ngraham edited the test plan for this revision. (Show Details)
fabianr added a subscriber: fabianr.EditedOct 31 2019, 2:06 PM
In D25055#557216, @hein wrote:

If we want to keep the handles-on-hover outside of Edit Mode, is there a reason it can't be always on and needs to be gated behind a checkbox?

I have to admit though I have a hard time seeing users like/rely on this behavior. Hovering and just waiting, even once you've learned it's possible, is always going to be an unsatisfying user experience - you're literally waiting around until the system deigns to approve your intent (long-press, in contrast is still active to some extent). I'd be worried that some users might learn "long hover" as "this is how it's supposed to be done" and then be forever annoyed that widgets are so cumbersome to handle. I'd propose removing it and fully leading users towards Edit Mode instead?

+1
And long hover is not something that would work with touch devices or is common in plasma or other environments, so I don't see a point in introducing a new usage pattern, that looks to me quiet cumbersome and problematic.

mart accepted this revision.Oct 31 2019, 3:00 PM
This revision is now accepted and ready to land.Oct 31 2019, 3:00 PM

Thanks for your flexibility, @mart. :)

This revision was automatically updated to reflect the committed changes.