RFC: Consider adding more padding to the desktop theme
Needs ReviewPublic

Authored by filipf on Jun 14 2019, 11:44 PM.

Details

Reviewers
ngraham
broulik
Group Reviewers
Plasma
VDG
Summary

Instead of tweaking every plasmoid, add a bit more padding to the desktop theme.

This would be an alternative solution to D21134.

Another postive aspect of this approach is we wouldn't be tweaking paddings solely for our desktop theme.

NOTE: The patch is just a copy-paste of Arc-color's background.svg so don't judge it based on the different corners or landability. It's meant to encourage discussion.
Test Plan

Before:

After:

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
more-padding-to-desktop-theme (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12841
Build 12859: arc lint + arc unit
filipf created this revision.Jun 14 2019, 11:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 14 2019, 11:44 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
filipf requested review of this revision.Jun 14 2019, 11:44 PM
filipf edited the test plan for this revision. (Show Details)Jun 14 2019, 11:45 PM
filipf added reviewers: Plasma, VDG, ngraham, broulik.
filipf edited the test plan for this revision. (Show Details)Jun 14 2019, 11:56 PM
ndavis added a subscriber: ndavis.Jun 15 2019, 12:09 AM

Besides the notifications, where does this add padding?

I like the rounder corners! :)

I like the rounder corners! :)

I don't, but those aren't meant to be discussed in this RFC anyway.

Besides the notifications, where does this add padding?

OSDs as far as I can tell, which are also actually not that roomy:

Before:

After:

Hmm. I don't think we should increase the padding on the desktop theme. That kind of approach seems like it would work best once we know the contents of notifications and OSDs are aligned how we want them to be in the code.

abetts added a subscriber: abetts.Jun 17 2019, 9:38 AM

+1 on visuals!

I think Plasma needs a whole lot more padding all over the place, not just in the notifications, but I guess there must be some kind of compromise with all the people who like more cramped UIs.

I think Plasma needs a whole lot more padding all over the place, not just in the notifications, but I guess there must be some kind of compromise with all the people who like more cramped UIs.

And in this case it would be easier if we implemented the changes in the desktop theme rather than in code because those wanting more cramped UIs could just use a different desktop theme (fork an old version e.g.).

I think Plasma needs a whole lot more padding all over the place, not just in the notifications, but I guess there must be some kind of compromise with all the people who like more cramped UIs.

And in this case it would be easier if we implemented the changes in the desktop theme rather than in code because those wanting more cramped UIs could just use a different desktop theme (fork an old version e.g.).

...and store it in the new vdg-playground repo (or whatever it's called) and make it available on store.kde.org.

friendly ping

@ndavis would you be willing to give it a go at making a proper patch for this (i.e. editing the Breeze svg)?

GB_2 awarded a token.Oct 17 2019, 8:28 AM