This was done for the following reasons:
- Match the GNOME/GTK Application Style KCM
- Give it a more accurate name
- Prevent it from being confused with the Application Style
I thought we wanted to merge the GTK Application Style with this KCM, and have the GTK theme comboxes accessible with a button in the KCM (like for the toolbar style)? I wouldn't rename the KCM until we are sure that we don't want to merge the two KCMs. Especially since the GTK KCM will soon only have two comboboxes and a checkbox, and a separate KCM would be a bit too much.
Why KDE/Qt Application style? Every Qt Application will have that style and not only KDE Applications. I also fear that somehow this will strengthen the false idea of some users that Applications and Plasma are intertwined. ("Because there is a settings category for 'KDE Applications' inside system settings")
Fair point, I was just making it match the naming scheme of the GNOME/GTK Application Style KCM. Would you prefer if it was just Qt and just GTK?
I understand where you're coming from, but they will be if they try to use custom themes (the point of this KCM), no matter what. We can't force GTK to use Qt themes and we can't guarantee that there will always be a GTK theme that matches the selected Qt theme or vice versa.
We are already surfacing this distinction by having a KCM called "GNOME/GTK Application style," begging the question of what the more general "Application Style" KCM controls, since its title is not as specific. This patch remedies that issue.
I agree that we should avoid exposing these kinds of technical details as much as possible. I think the only way to satisfactorily do that is to remove the GTK KCM entirely, and then the remaining KCM can keep its current name ("Application Style"). I'm in favor of that, but we're not there yet.