Fix date parameter passing

Fix documentation, CMakeLists.txt, a couple of code fix

You asked for it :-)

In D22144#514633, @ivan wrote:

Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?

Add date and date range filtering after D22775

I'v added @dfaure as reviewer.

In D22144#514633, @ivan wrote:

Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?

Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?

Nice. you even differentiated the names that show up in the toolbar configuratin window! Looks great from my perspective. Let's wait for @elvisangelaccio now.

In D23232#514449, @ndavis wrote:

I also think that using toggle for search makes more sense. It would be nice to have a general pattern of using toggle buttons in the toolbar for things that can be opened and closed, especially when they're activated via the toolbar in the first place.

Nice job. May it be the first of many! :)

Thanks,

Thank you very much!

If the question starts with "Are you sure you want to..." that's probably a good sign it should be a warning since the wording implies that if you go through with it, something undesirable might happen.

I also think that using toggle for search makes more sense. It would be nice to have a general pattern of using toggle buttons in the toolbar for things that can be opened and closed, especially when they're activated via the toolbar in the first place.

• Set toggle_search as default toolbar action

• Set toggle_search as default toolbar action (on top of D23075)

I think a warning is appropriate as opening a gazillion applications could lead to an unresponsive system.

In D22727#513842, @dfaure wrote:

The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.

In D23232#514204, @ngraham wrote:

Looks like you incorporated changes in D23075 rather than rebasing on top of it.

Thanks for the comments, @feverfew. Your assistance is definitely appreciated given that you wrote a lot of the code I'm mangling here.

Looks like you incorporated changes in D23075 rather than rebasing on top of it.

• Update dolphinui.rc to use toggle_search instead of edit_find

In D11382#513245, @ngraham wrote:

This is ready for re-review, with one specific thing I could use help debugging: when you enable the new option, launching Dolphin and opening new windows becomes interminably slow, probably due to some extra DBus overhead that's still a bit beyond my comprehension. See the FIXME in the code.

Hmm, now that I give it more thought, you might be right. All right, let's give it a try. @iasensio we'll need for dolphinrc.ui to have the new toggle_search action on the default toolbar, rather than the old edit_find one. And don't forget to bump the version number at the top of that file. :)

I think it is fine having two actions that both open the Search/Findbar. The new 'toggle-search' would replace 'open-search' in the Toolbar and 'open-search' would still be associated with Ctrl+F.
This is similar to having two actions for typing a new location:

The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.

In D22727#510698, @brute4s99 wrote:

In D22727#505540, @dfaure wrote:

But, wait, this code is mixing "int permissions" (*) with the QFileDevice enum, that doesn't make any sense to me.

(*) this comes from KIO::put, which takes unix permissions on unix, not sure what it takes on Windows...

This doesn't match: unix permissions are octal (e.g. group read is 040 in octal), QFileDevice enum is hex (0x040).

Okay. I'm still unable to understand where/ how sftp::put() is called, or I would change everywhere it is called, to Qt way of permission extraction.

Giving choice to the user isn't really the best solution here IMO. The fact that these toolbars are customizable at all is not widely known, and allowing people to choose between multiple actions that both do the same thing except for one slightly different close/focus behavior is likely to be super confusing to everyone who's not a Dolphin developer. :) Adding VDG for more opinions and comments.

@ivan?

• Add an independent toggle_search action

• Update search action on view changes

Wow, I did a little search through the bug tracker but I didn't find that it had been already addresed.
Those other two patches seem more detailed, as I haven't dealt with the filter bar, only the search bar. I have already seen some inconsistencies in mine when using tabs or split view.

Thanks for the patch! In fact, this comes up a lot. I'm aware of at least two other patches that have attempted to fix it: D10246 & D12094. Both of their submitters have effectively abandoned them, so I think we can move forward with this.

This is ready for re-review, with one specific thing I could use help debugging: when you enable the new option, launching Dolphin and opening new windows becomes interminably slow, probably due to some extra DBus overhead that's still a bit beyond my comprehension. See the FIXME in the code.

Adjust settings UI again, this time to be perfectly clear about what applies when

Refactor DBus call to find existing Dolphin instances into a re-usable function so we can use it to find out of there are any instances running when the user opens more windows

Unnecessary min version upgraded

Adjust startup settings UI to only have two major sections

Adjust Settings window presentation to make sense with this new setting

Rebase

Done: D23201

In D19989#512941, @davidedmundson wrote:

Also, currently Solid does not depend on any KF5 libraries, this would be the first, is that ok?

Probably ok.

Keeping solid clean of process miscellaneous utils.

It's not really cleaner if it just puts it somewhere else.
If you're dealing with lsof you're probably doing something with a drive, at which point you're doing something with a drive (and using solid) anyway?

My point was also that KCoreAddons has already KProcessInfo ands KFileSystemType to find files fs types.
So a utility in the same area such as queryBlockingApps might make sense there. It would keep solid from getting a dependency.

Also, currently Solid does not depend on any KF5 libraries, this would be the first, is that ok?

In D19989#467619, @hallas wrote:

@davidedmundson - Hi David! I am (finally) starting to look at implementing the lsof functionality in Solid, but I am unsure of where exactly to place it in Solid? Also, currently Solid does not depend on any KF5 libraries, this would be the first, is that ok?

Now we need the file dialog patch.

run uncrustify-kf5

Edit dolphinui.rc Add <Action name="split_stash" /> Before <Action name="split_view" />

Untested: have you tried to make dolphinprivate a PUBLIC dependency of kdeinit_dolphin?

When your information panel disappears with git master, usually that means your baloo-widgets is out of date. It really should be integrated into Dolphin's own repo IMO since Dolphin is the only user.

In D23075#512110, @elvisangelaccio wrote:

Wow, this is quite a radical change :)

I'm not against changing the default layout, but we should be 100% sure to get it right. It would be very annoying if we have to change it again in six months because people didn't like it.

My comments after a quick try:

1. I don't think we should add the "Go Up" button because you can already achieve the same action by using the url navigator buttons.

There's several unrealated changes I'd discourage but the patch looks good overall. +1

I'll be AFK for a week for vacation. Will do a proper review once I'm back ;)

Wow, this is quite a radical change :)

OK, it's ready again now. :)

Clean up remaining whitespace issues

Rebase

Undo unnecessary CMake changes

Use a more typical approach

In D22149#506093, @elvisangelaccio wrote:

There seems to be another issue: if I run dolphin <some folder> from cmd line I always get Add 'file' to place, no matter what the folder is.

Remove unused variable

I hate you arc

Rebase

In D22183#511449, @elvisangelaccio wrote:

Btw I think I spotted a regression:

1. Start playback
2. Right-click on info panel -> uncheck "Preview"
3. Right-click again -> check "Preview"
   
   The phonon widget does not show up again.

• for video previews, hide player completely when playback has finished or is stopped- better enforce video size- display the play arrow only for video files

Can you try to build another kdeinit app (i.e. `khelpcenter`) to check if you get the same error?