Change warning dialog box to a question dialog box
Needs ReviewPublic

Authored by shubham on Aug 19 2019, 6:06 AM.

Details

Summary

Selecting multiple items (>5) and trying to open them resulted in a Warning dialog box being shown, which said "Are you sure you want to open x items?".
IMO this is a question, and definitely not a warning which user should be warned of.

Test Plan

Select more than 5 items and try opening them, warning dialog box is now replaced by a question dialog box.

Diff Detail

Repository
R318 Dolphin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15281
Build 15299: arc lint + arc unit
shubham created this revision.Aug 19 2019, 6:06 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptAug 19 2019, 6:06 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
shubham requested review of this revision.Aug 19 2019, 6:06 AM
shubham edited the summary of this revision. (Show Details)

I think a warning is appropriate as opening a gazillion applications could lead to an unresponsive system.

If the question starts with "Are you sure you want to..." that's probably a good sign it should be a warning since the wording implies that if you go through with it, something undesirable might happen.

shubham added a comment.EditedSat, Aug 24, 2:58 PM

Shouldn't the message change then to be more informational?

I think a warning is appropriate as opening a gazillion applications could lead to an unresponsive system.

And that's exactly why this message was introduced. I don't see what we gain by changing it to a question.