nazark (Nazar Kalinowski)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 18 2019, 7:25 PM (27 w, 3 d)
Availability
Available

Recent Activity

Jan 8 2020

nazark added a comment to D26479: Fix warning on launch from QCommandLineParser.

I am not sure that this is how one closes a patch ^ , but that's the closest option I found..

Jan 8 2020, 6:52 PM · Konsole
nazark abandoned D26479: Fix warning on launch from QCommandLineParser.
Jan 8 2020, 6:51 PM · Konsole

Jan 6 2020

nazark requested review of D26480: Fix warning on launch from QCommandLineParser.
Jan 6 2020, 9:35 PM · Kdenlive
nazark requested review of D26479: Fix warning on launch from QCommandLineParser.
Jan 6 2020, 9:22 PM · Konsole
nazark added a comment to D26460: Fix warning on launch from QCommandLineParser.

And now about the other apps, I found out that actually there are quite a lot of apps that have this issue, not only the kcalc and the konsole.
So, there is no better option than just making one patch per app and submitting it on the phabricator, right?

Jan 6 2020, 7:50 PM
nazark added a comment to D26460: Fix warning on launch from QCommandLineParser.

Yep, I tested it before submitting a patch, and the warning is gone when I launch my compiled version of kcalc..
https://i.imgur.com/qSATbjg.png

Jan 6 2020, 7:18 PM
nazark added a comment to D26460: Fix warning on launch from QCommandLineParser.

I'm afraid that I'll need a bit of help in order to do that, sorry :-(
Git tells me that my copy is up-to-date, so I think that my patch is applied on top of most recent commit.
What exactly should I do to rebase it?

Jan 6 2020, 3:40 PM
nazark added a comment to D26460: Fix warning on launch from QCommandLineParser.

If this fix is correct, the same things should be probably done in some other apps, so far I found konsole to produce the same warning.

Jan 6 2020, 11:43 AM
nazark requested review of D26460: Fix warning on launch from QCommandLineParser.
Jan 6 2020, 11:42 AM

Sep 15 2019

nazark updated the diff for D23706: Fix wrong window titles.
Sep 15 2019, 3:55 PM · Dolphin

Sep 14 2019

nazark updated the diff for D23706: Fix wrong window titles.
Sep 14 2019, 5:47 PM · Dolphin
nazark added a comment to D23706: Fix wrong window titles.

What about something like this?

Sep 14 2019, 5:43 PM · Dolphin
nazark added a comment to D23706: Fix wrong window titles.

Oh, and you are right again.
The previous solution seems to fix it without a regression, but obviously the code itself feels at the very least "not good".

Sep 14 2019, 5:24 PM · Dolphin
nazark added a comment to D23706: Fix wrong window titles.

Updated!
I didn't think about this solution, thanks, clearly it's way better than mine.

Sep 14 2019, 4:48 PM · Dolphin
nazark updated the diff for D23706: Fix wrong window titles.
Sep 14 2019, 4:46 PM · Dolphin

Sep 10 2019

nazark added a comment to D23706: Fix wrong window titles.

Ping

Sep 10 2019, 1:42 PM · Dolphin

Sep 3 2019

nazark added a reviewer for D23706: Fix wrong window titles: Dolphin.
Sep 3 2019, 7:54 PM · Dolphin
nazark added a comment to D23706: Fix wrong window titles.

Yep, that's exactly what I did to fix that the first time I tried to write a patch!
The problem is, it doesn't solve it.
It will show the name of a folder wrong, if its url in places contains trailing slash (and it's easy to do, the patch that you linked still allows users to manually create/edit such urls in "places").
(The version which just always strips the trailing slash: https://i.imgur.com/QR0GGnx.png)

Sep 3 2019, 3:47 PM · Dolphin
nazark added a comment to D23706: Fix wrong window titles.

As far as I understand, nope, that commit just changes the url which is going to be added to "places".
Firstly, it doesn't fix the bug, and secondly, a user still can add/modify a url in places so that it contains a trailing slash, and current version of dolphin will show it's name wrong (if opened manually, as on the screenshots in "Test Plan").

Sep 3 2019, 3:41 PM · Dolphin
nazark updated the summary of D23706: Fix wrong window titles.
Sep 3 2019, 3:23 PM · Dolphin
nazark requested review of D23706: Fix wrong window titles.
Sep 3 2019, 3:21 PM · Dolphin

Aug 27 2019

nazark updated the summary of D23482: Make non-empty textual columns come first in sorting.
Aug 27 2019, 3:56 PM · Dolphin
nazark added a comment to D23482: Make non-empty textual columns come first in sorting.

Done

Aug 27 2019, 3:55 PM · Dolphin
nazark updated the test plan for D23482: Make non-empty textual columns come first in sorting.
Aug 27 2019, 3:54 PM · Dolphin
nazark added a comment to D23482: Make non-empty textual columns come first in sorting.

If this is not a desired default behavior, I'll need some hints on how to make a setting for it.

Aug 27 2019, 6:43 AM · Dolphin
nazark requested review of D23482: Make non-empty textual columns come first in sorting.
Aug 27 2019, 6:43 AM · Dolphin

Aug 19 2019

nazark added a comment to D23264: Fix a typo.

Thanks,

Aug 19 2019, 3:01 PM · Dolphin
nazark requested review of D23264: Fix a typo.
Aug 19 2019, 2:24 PM · Dolphin