sredman (Simon Redman)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 6:47 AM (130 w, 6 d)
Availability
Available

Recent Activity

Tue, Nov 12

sredman added inline comments to D25228: Bump version of KPeople.
Tue, Nov 12, 6:42 AM
sredman added a comment to D25228: Bump version of KPeople.
In D25228#561319, @apol wrote:

Okay, makes sense to me

Tue, Nov 12, 6:42 AM

Sat, Nov 9

sredman committed R225:4a0c53610f5b: Fix reading SMS/MMS on devices with no `sub_id` (authored by kdziembala).
Fix reading SMS/MMS on devices with no `sub_id`
Sat, Nov 9, 7:28 PM
sredman updated the test plan for D25228: Bump version of KPeople.
Sat, Nov 9, 5:53 PM
sredman added a comment to D25228: Bump version of KPeople.

Is it really necessary to split KF5 dependencies in two parts here? I don't see this being done anywhere else, KF5_MIN_VERSION is always global.

Sat, Nov 9, 5:52 PM
sredman added a reviewer for D25228: Bump version of KPeople: apol.
Sat, Nov 9, 5:42 AM
sredman updated the diff for D25228: Bump version of KPeople.

Change version to 5.62 since that is the version bump after Aleix's changes to add editable contacts

Sat, Nov 9, 5:38 AM
sredman requested review of D25228: Bump version of KPeople.
Sat, Nov 9, 5:21 AM

Sun, Oct 27

sredman committed R225:6f81c676324e: Refactor contacts-getting code to be either "everything" or "one" (authored by sredman).
Refactor contacts-getting code to be either "everything" or "one"
Sun, Oct 27, 9:24 PM

Wed, Oct 23

sredman committed R224:8a908e5c696c: Correct error interpreting vcard timestamp size (authored by sredman).
Correct error interpreting vcard timestamp size
Wed, Oct 23, 1:10 AM

Sat, Oct 19

sredman committed R225:b1c6df405c29: Delete broken getVCardsFast (authored by sredman).
Delete broken getVCardsFast
Sat, Oct 19, 4:01 PM

Oct 10 2019

sredman updated the task description for T11852: Fix Navigation Bar Colour on Dark Theme.
Oct 10 2019, 2:33 AM · KDE Connect
sredman triaged T11852: Fix Navigation Bar Colour on Dark Theme as Low priority.
Oct 10 2019, 2:29 AM · KDE Connect

Oct 9 2019

sredman committed R225:a2ccafbdf8f3: Add information for bug reporting to README (authored by sredman).
Add information for bug reporting to README
Oct 9 2019, 3:39 AM

Sep 21 2019

sredman added a comment to D24118: Fix KDE Connect package on macOS.

Does kdeconnect.app have to be renamed to kdeconnect-app.app? Can it just stay with the old name?
( I guess I don't know what that part does. If it's not user-visible then I don't think it matters)

Sep 21 2019, 1:20 AM

Aug 29 2019

sredman committed R225:86258a51a381: Ignore case when checking manufacturer for Samsung mode (authored by sredman).
Ignore case when checking manufacturer for Samsung mode
Aug 29 2019, 6:52 AM
sredman committed R225:6a6b41db49df: Correct error for tagging multi-target messages (authored by sredman).
Correct error for tagging multi-target messages
Aug 29 2019, 6:52 AM

Aug 24 2019

sredman committed R224:9c91042441d7: Add loading indicator while loading conversations (authored by sredman).
Add loading indicator while loading conversations
Aug 24 2019, 5:39 PM

Aug 19 2019

sredman added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.

Aug 19 2019, 3:08 AM · Frameworks, Dolphin

Aug 18 2019

sredman accepted D23196: have 1024x1024 app icon as fallback icon in Snore.

Since KNotifications on Windows is so far only used by you anyway, I say it's fine to merge. @broulik, any objections?

Aug 18 2019, 3:57 AM · Frameworks
sredman added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

But, wait, this code is mixing "int permissions" (*) with the QFileDevice enum, that doesn't make any sense to me.

(*) this comes from KIO::put, which takes unix permissions on unix, not sure what it takes on Windows...

This doesn't match: unix permissions are octal (e.g. group read is 040 in octal), QFileDevice enum is hex (0x040).

Okay. I'm still unable to understand where/ how sftp::put() is called, or I would change everywhere it is called, to Qt way of permission extraction.

Aug 18 2019, 3:47 AM · Frameworks, Dolphin

Aug 17 2019

sredman closed T9676: [Junior Job] Synchonize clipboard on device connection as Resolved.

This task was completed by 779997337179e035a13b277784d40e67d4fe765e and 5dc65ee9094d12d06cbf2f96b68b4d71bebd9142

Aug 17 2019, 2:41 PM · Junior Jobs, KDE Connect
sredman added a comment to T9676: [Junior Job] Synchonize clipboard on device connection.

Hi. I'd like to work on this one as well. But I'm new to KDE and also am a relative beginner in programming. I had a question - how should I start to dive into the code from on cgit. Thank you.

Aug 17 2019, 2:40 PM · Junior Jobs, KDE Connect

Aug 11 2019

sredman accepted D21661: add snoretoast backend for KNotifications on Windows.

I noticed a couple of places where the cmake file could be simplified so make those changes and then let's land this monster

Aug 11 2019, 2:43 PM · Frameworks

Aug 4 2019

sredman added a comment to D17790: Port away from QCA.

Is this good to ship?

Since there is a dylib duplicated link error caused by qca-qt5 on macOS(when we use Craft to pack KDE Connect with qml files), this will be helpful for all qml apps we have up to now :)

Aug 4 2019, 1:56 PM · KDE Connect

Jul 31 2019

sredman committed R224:f56a24d51962: Add Q_UNUSED to squelch warning (authored by sredman).
Add Q_UNUSED to squelch warning
Jul 31 2019, 8:36 PM

Jul 30 2019

sredman committed R224:f270a2701818: Add description for presentation remote (authored by sredman).
Add description for presentation remote
Jul 30 2019, 4:37 PM
sredman committed R224:fcd473d325b6: Remove Phabricator link from CONTRIBUTING.md (authored by sredman).
Remove Phabricator link from CONTRIBUTING.md
Jul 30 2019, 2:24 PM

Jul 29 2019

sredman committed R224:3c783c4505de: Remove reference to non-existant cmake variable (authored by sredman).
Remove reference to non-existant cmake variable
Jul 29 2019, 8:44 PM
sredman committed R224:2e04adf99ce6: Fix never-ending loading by adding a new signal indicating the SMS plugin has… (authored by sredman).
Fix never-ending loading by adding a new signal indicating the SMS plugin has…
Jul 29 2019, 8:14 PM
sredman committed R224:5b73348635f6: Add Commenting (authored by sredman).
Add Commenting
Jul 29 2019, 7:52 PM

Jul 27 2019

sredman committed R224:91765a354db1: Update ConversationMessage.qml to latest version used in Kaidan (authored by sredman).
Update ConversationMessage.qml to latest version used in Kaidan
Jul 27 2019, 10:06 AM

Jul 25 2019

sredman abandoned D15338: WIP: Advertise over mDNS.
Jul 25 2019, 8:33 AM · KDE Connect
sredman commandeered D15338: WIP: Advertise over mDNS.

We have done a little bit more on mDNS on our Gitlab. Feel free to check it out! Android C++

Jul 25 2019, 8:33 AM · KDE Connect
sredman abandoned D15334: WIP: Add support for mDNS advertisements.
Jul 25 2019, 8:32 AM · KDE Connect
sredman commandeered D15334: WIP: Add support for mDNS advertisements.

We have done a little bit more on mDNS on our Gitlab. Feel free to check it out! Android C++

Jul 25 2019, 8:32 AM · KDE Connect

Jul 24 2019

sredman committed R954:2aae04b9f405: Add my blog (sredman) (authored by sredman).
Add my blog (sredman)
Jul 24 2019, 9:42 AM

Jul 23 2019

sredman committed R224:88e0ffa01a76: Always show sender's name (authored by sredman).
Always show sender's name
Jul 23 2019, 11:44 AM

Jul 22 2019

sredman committed R224:ecbe1acabe39: Change license string in About (authored by sredman).
Change license string in About
Jul 22 2019, 5:42 PM
sredman added a comment to D22635: add new dependencies for KDE Connect.

The SMS app has a runtime dependency on kpeoplevcard as well

Jul 22 2019, 8:06 AM
sredman closed T10183: SMS App should display some loading indicator while loading as Resolved.

Mostly resolved. The actual conversation shows a nice spinner when waiting for messages. The conversation list still doesn't show anything, but also I have trouble reproducing a case where it loads slowly so I think it will be okay

Jul 22 2019, 7:05 AM · KDE Connect
sredman closed T10183: SMS App should display some loading indicator while loading, a subtask of T8337: SMS App Initial Release, as Resolved.
Jul 22 2019, 7:05 AM · KDE Connect

Jul 21 2019

sredman added inline comments to D22585: Clipboard sync on new connections.
Jul 21 2019, 6:14 PM · KDE Connect
sredman committed R224:8d939e130f6f: ## Summary: Add a spinning loading indicator while waiting to get messages from… (authored by sredman).
## Summary: Add a spinning loading indicator while waiting to get messages from…
Jul 21 2019, 5:27 PM
sredman committed R224:c08c2545557a: Update KAboutData (authored by sredman).
Update KAboutData
Jul 21 2019, 3:45 PM
sredman committed R224:bc468f1e07dd: Use proper theme setting for text colour (authored by sredman).
Use proper theme setting for text colour
Jul 21 2019, 2:42 PM
sredman closed T10187: SMS App Should Request Enough Messages to Fill the Initial Window, a subtask of T8337: SMS App Initial Release, as Resolved.
Jul 21 2019, 11:34 AM · KDE Connect
sredman closed T10187: SMS App Should Request Enough Messages to Fill the Initial Window as Resolved.

Now we request a bunch, then check if there are enough and request more until there is

Jul 21 2019, 11:34 AM · KDE Connect
sredman closed T10186: SMS App Should Instantly Show the Most-Recent Message when Conversation is Opened as Resolved.
Jul 21 2019, 11:33 AM · KDE Connect
sredman closed T10186: SMS App Should Instantly Show the Most-Recent Message when Conversation is Opened, a subtask of T8337: SMS App Initial Release, as Resolved.
Jul 21 2019, 11:33 AM · KDE Connect
sredman closed T11120: [SMS App] Add menu bar, a subtask of T8337: SMS App Initial Release, as Resolved.
Jul 21 2019, 11:33 AM · KDE Connect
sredman closed T11120: [SMS App] Add menu bar as Resolved.

@vikasd We have done this one at the KDE Connect sprint. Check it out!

Jul 21 2019, 11:33 AM · KDE Connect
sredman committed R224:19025fb287df: Make the sms app load the proper number of messages to fill the initial screen… (authored by sredman).
Make the sms app load the proper number of messages to fill the initial screen…
Jul 21 2019, 11:18 AM

Jul 20 2019

sredman committed R224:1f3dfc9a9e23: Update packet documentation (authored by sredman).
Update packet documentation
Jul 20 2019, 8:36 PM
sredman added a reviewer for D22585: Clipboard sync on new connections: KDE Connect.
Jul 20 2019, 8:20 PM · KDE Connect
sredman added a reviewer for D22584: Clipboard sync on new connection: KDE Connect.
Jul 20 2019, 6:24 PM · KDE Connect
sredman added inline comments to D22584: Clipboard sync on new connection.
Jul 20 2019, 6:23 PM · KDE Connect
sredman committed R224:9f4716c3c527: Build SMS app by default (authored by sredman).
Build SMS app by default
Jul 20 2019, 1:47 PM
sredman committed R224:2df3b6eb16cc: Update Phabricator link to Gitlab (authored by sredman).
Update Phabricator link to Gitlab
Jul 20 2019, 1:43 PM
sredman requested changes to D15399: Always build Kirigami app.

It needs the dependency on qt5-quickcontrols2

Jul 20 2019, 9:12 AM · KDE Connect
sredman abandoned D17214: GCI [KDE Connect] Start New Conversation in Messaging App.
Jul 20 2019, 9:09 AM · KDE Connect
sredman commandeered D17214: GCI [KDE Connect] Start New Conversation in Messaging App.

This can be re-opened when we want to look at this feature again, but I'm closing for now

Jul 20 2019, 9:08 AM · KDE Connect
sredman added a comment to D13505: T8539 - Create a new flow to manage trusted networks.

@jdvr Are you still interested in working on this? We would need some flow to request the permission on newer Android versions. With the runtime permissions, it seems like it would make the most sense to ask for this as soon as the user brings up the settings panel for configuring trusted networks.

Jul 20 2019, 9:06 AM · KDE Connect

Jul 19 2019

sredman committed R225:abcb6cbf332b: [SMS App] Export all addresses of multitarget messages (authored by sredman).
[SMS App] Export all addresses of multitarget messages
Jul 19 2019, 5:47 PM
sredman committed R224:edee0e0e9d10: [SMS App] Handle addresses for multitarget messages (authored by sredman).
[SMS App] Handle addresses for multitarget messages
Jul 19 2019, 5:33 PM
sredman committed R224:ee9547ed89b5: [SMS App] Basic plain-text MMS support (authored by sredman).
[SMS App] Basic plain-text MMS support
Jul 19 2019, 3:29 PM
sredman committed R225:1db43273702b: Fix build (authored by sredman).
Fix build
Jul 19 2019, 2:01 PM

Jul 15 2019

sredman committed R225:70cf9e1bac97: Update in-repository documentation (authored by sredman).
Update in-repository documentation
Jul 15 2019, 3:33 PM

Jul 12 2019

sredman abandoned D22427: Updated german translation.
Jul 12 2019, 9:05 PM · KDE Connect
sredman commandeered D22427: Updated german translation.

Hi sredman.

Thanks for the information. I did not know that there is a dedicated localization team, but I will contact them as soon as possible. Then, I guess you can close this review request.

Jul 12 2019, 9:04 PM · KDE Connect
sredman added a comment to D22427: Updated german translation.

Hi skumblex. Thank you very much for taking the time to do this!

Jul 12 2019, 8:51 PM · KDE Connect

Jul 11 2019

sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Actually, there is a bit of a problem... The version of the file currently on master is bugged :(

See: https://phabricator.kde.org/D17908#492404

Any progress with the MS tool?

Jul 11 2019, 9:21 PM · KDevelop

Jul 9 2019

sredman committed R225:ffbceb9b8e2e: Reorder the Samsung special case to take effect before the case handling all… (authored by sredman).
Reorder the Samsung special case to take effect before the case handling all…
Jul 9 2019, 9:16 AM

Jul 8 2019

sredman added a comment to D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..

Actually, a pleasant surprise for today is that this whole mess of registry keys and environment variables is mostly unnecessary as of VS 2017, since Microsoft provides a tool which does all the locating work for us: https://github.com/microsoft/vswhere

Jul 8 2019, 4:13 PM · KDevelop
sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Actually, there is a bit of a problem... The version of the file currently on master is bugged :(

Jul 8 2019, 3:56 PM · KDevelop
sredman added a comment to D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..

Unfortunately, I have a problem with using the batch file from this diff on my system.

Jul 8 2019, 3:42 PM · KDevelop
sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Ping? Please keep hammering the iron while hot :)

Jul 8 2019, 1:20 PM · KDevelop

Jun 26 2019

sredman added a comment to D21602: Add NSIS Script for KDE Connect.

Has this been landed yet? Is there any reason to keep it open?

Jun 26 2019, 9:50 PM · Craft, KDE Connect

Jun 22 2019

sredman committed R225:418e1a813e8a: Potentially fix SMS/MMS access on Samsung devices (authored by sredman).
Potentially fix SMS/MMS access on Samsung devices
Jun 22 2019, 12:50 AM
sredman committed R225:50f395bdefd4: Potentially fix SMS/MMS access on Samsung devices (authored by sredman).
Potentially fix SMS/MMS access on Samsung devices
Jun 22 2019, 12:50 AM

Jun 19 2019

sredman created T11120: [SMS App] Add menu bar.
Jun 19 2019, 5:57 PM · KDE Connect

Jun 16 2019

sredman committed R230:d7bd9dae5b09: Add myself (sredman) to relicensecheck.pl (authored by sredman).
Add myself (sredman) to relicensecheck.pl
Jun 16 2019, 4:30 PM

Jun 10 2019

sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

brauch is referring to this

for /f "usebackq tokens=3*" %%a in (`reg query "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7" /s`) do (
     set vs15_path=%%a %%b
     if exist "!vs15_path!Common7\Tools\VsDevCmd.bat" (
	set "VS150COMNTOOLS=!vs15_path!Common7\Tools\"
	goto :end
     )
   )
)
:end

Oops. What happened here is I was hacking on the release version which looks more like the patch I posted. I'll see if I can make sense of the master branch version and make it more like that!

Jun 10 2019, 6:50 PM · KDevelop
sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Why did you replace the registry query by a fixed path?

Jun 10 2019, 6:29 PM · KDevelop
sredman committed R225:51e957d82290: [SMSApp] Support plain-text MMS (authored by sredman).
[SMSApp] Support plain-text MMS
Jun 10 2019, 5:51 AM

Jun 9 2019

sredman added a comment to D21661: add snoretoast backend for KNotifications on Windows.
In D21661#476571, @pino wrote:
In D21661#476156, @pino wrote:

how is snoretoast actually used here? you are requiring the library for building and linking, but then:

  • snoretoastactions.h, which is part of the headers of snoretoast, is copied here
  • the snoretoast library is never used, as the utilities of it are invoked instead If the library does all the work already, then I'd prefer to use it directly instead of spawning executables all the time...

Piyush, what about this? It seems the snoretoast library provides a SnoreToasts class to do this instead of spawning an helper tool, what about using it instead?

Jun 9 2019, 5:26 AM · Frameworks

Jun 8 2019

sredman accepted D21602: Add NSIS Script for KDE Connect.
Jun 8 2019, 2:59 AM · Craft, KDE Connect
sredman added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Jun 8 2019, 2:21 AM · Frameworks

Jun 7 2019

sredman committed R224:3c346b94096e: Block matching empty phone numbers (authored by sredman).
Block matching empty phone numbers
Jun 7 2019, 10:44 PM

Jun 6 2019

sredman committed R225:49295c0de98d: Make lint suppression less aggressive for SMSHelper (authored by sredman).
Make lint suppression less aggressive for SMSHelper
Jun 6 2019, 4:22 AM

Jun 5 2019

sredman added a comment to D21602: Add NSIS Script for KDE Connect.

The only thing I immediately see as a problem is the uninstaller doesn't have the proper branding (generic icons), and it didn't uninstall the desktop shortcut

Jun 5 2019, 4:14 PM · Craft, KDE Connect
sredman committed R224:c7579eb17017: Fix LanLinkProviderTest on Windows (authored by sredman).
Fix LanLinkProviderTest on Windows
Jun 5 2019, 3:16 PM
sredman committed R224:9453e640b302: Refactor testdevice (authored by sredman).
Refactor testdevice
Jun 5 2019, 2:42 AM
sredman committed R224:673c3ced69da: Make testsslsocketlistener properly timeout (authored by sredman).
Make testsslsocketlistener properly timeout
Jun 5 2019, 2:40 AM

Jun 4 2019

sredman added a reviewer for D21589: Duplicate Visual Studio 2017 hack for VS 2019: KDevelop.
Jun 4 2019, 9:27 PM · KDevelop
sredman requested review of D21589: Duplicate Visual Studio 2017 hack for VS 2019.
Jun 4 2019, 9:26 PM · KDevelop
sredman committed R224:0b797fc29d2d: Add eclipse settings files to .gitignore (authored by sredman).
Add eclipse settings files to .gitignore
Jun 4 2019, 6:03 PM

Jun 3 2019

sredman committed R224:4c75626919b2: Fix build (authored by sredman).
Fix build
Jun 3 2019, 4:25 AM
sredman committed R224:637285378d29: Add error logging to LanLinkProvider when binding the listener socket (authored by sredman).
Add error logging to LanLinkProvider when binding the listener socket
Jun 3 2019, 4:14 AM

Jun 2 2019

sredman committed R224:b4da91f86be3: Really actually fix Windows SMS app build (authored by sredman).
Really actually fix Windows SMS app build
Jun 2 2019, 9:47 PM