sredman (Simon Redman)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 6:47 AM (82 w, 6 d)
Availability
Available

Recent Activity

Yesterday

sredman accepted D17250: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input.
Fri, Dec 14, 10:09 PM · KDE Connect
sredman committed R224:900943995660: Handle case where more messages were requested but there were no more available… (authored by sredman).
Handle case where more messages were requested but there were no more available…
Fri, Dec 14, 5:03 PM

Thu, Dec 13

sredman added a comment to T10187: SMS App Should Request Enough Messages to Fill the Initial Window.

Maybe we could just increase the hardcoded number as a first workaround? I think 20 should be enough for most cases

Thu, Dec 13, 11:03 PM · KDE Connect
sredman raised the priority of T10184: SMS App Should Gracefully Handle Phone Disconnection from Normal to High.
Thu, Dec 13, 9:34 PM · KDE Connect
sredman renamed T10185: SMS App Should Gracefully Handle Phone Re-Connection from Messaging App Should Gracefully Handle Phone Re-Connection to SMS App Should Gracefully Handle Phone Re-Connection.
Thu, Dec 13, 9:33 PM · KDE Connect
sredman renamed T10184: SMS App Should Gracefully Handle Phone Disconnection from Messaging App Should Gracefully Handle Phone Disconnection to SMS App Should Gracefully Handle Phone Disconnection.
Thu, Dec 13, 9:33 PM · KDE Connect
sredman renamed T8337: SMS App Initial Release from SMS App to SMS App Initial Release.
Thu, Dec 13, 9:32 PM · KDE Connect
sredman triaged T10187: SMS App Should Request Enough Messages to Fill the Initial Window as Normal priority.
Thu, Dec 13, 9:31 PM · KDE Connect
sredman triaged T10186: SMS App Should Show the Most-Recent Message when Conversation is Opened as High priority.
Thu, Dec 13, 9:28 PM · KDE Connect
sredman added a comment to T10184: SMS App Should Gracefully Handle Phone Disconnection.

This is essentially a re-statement of bug 401587

Thu, Dec 13, 9:12 PM · KDE Connect
sredman created T10185: SMS App Should Gracefully Handle Phone Re-Connection.
Thu, Dec 13, 9:11 PM · KDE Connect
sredman triaged T10184: SMS App Should Gracefully Handle Phone Disconnection as Normal priority.
Thu, Dec 13, 9:06 PM · KDE Connect
sredman triaged T10183: SMS App should display some loading indicator while loading as Normal priority.
Thu, Dec 13, 9:01 PM · KDE Connect
sredman closed T9556: Should be able to view older messages by scrolling up as Resolved.

Resolved by D15979

Thu, Dec 13, 8:56 PM · KDE Connect
sredman closed T9556: Should be able to view older messages by scrolling up, a subtask of T8337: SMS App Initial Release, as Resolved.
Thu, Dec 13, 8:56 PM · KDE Connect
sredman updated subscribers of D17572: Add dependency on kirigami to SMS app.
Thu, Dec 13, 8:53 PM · KDE Connect
sredman updated the summary of D17572: Add dependency on kirigami to SMS app.
Thu, Dec 13, 8:51 PM · KDE Connect
sredman requested review of D17572: Add dependency on kirigami to SMS app.
Thu, Dec 13, 8:50 PM · KDE Connect
sredman requested review of D17553: Use typedef threadID_t qint64 instead of hard-coding.
Thu, Dec 13, 6:37 AM · KDE Connect
sredman committed R224:2c35c1af518d: [SMS App] Allow scrolling up to load and display older messages (authored by sredman).
[SMS App] Allow scrolling up to load and display older messages
Thu, Dec 13, 5:50 AM
sredman closed D15979: [SMS App] Allow scrolling up to load and display older messages.
Thu, Dec 13, 5:50 AM · KDE Connect
sredman committed R224:7025fd67959a: Un-break build. Apparently I didn't test as I thought I had. (authored by sredman).
Un-break build. Apparently I didn't test as I thought I had.
Thu, Dec 13, 5:49 AM
sredman updated the diff for D15979: [SMS App] Allow scrolling up to load and display older messages.
  • Re-Re-Rebase onto Master including D16475
Thu, Dec 13, 5:45 AM · KDE Connect
sredman closed D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching.
Thu, Dec 13, 5:43 AM · KDE Connect
sredman committed R224:019e8d6a1c0e: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching (authored by sredman).
[SMS App] Make requestMoreMessages asynchronous, blocking, and caching
Thu, Dec 13, 5:43 AM
sredman updated the diff for D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching.
  • Clean inequalities
Thu, Dec 13, 5:40 AM · KDE Connect
sredman committed R225:5eb368c630cf: Add incremental notifications plugin settings database upgrade (authored by sredman).
Add incremental notifications plugin settings database upgrade
Thu, Dec 13, 2:12 AM
sredman closed D17521: Add incremental notifications plugin settings database upgrade.
Thu, Dec 13, 2:12 AM · KDE Connect
sredman committed R225:6ba6842fc75e: Privacy Options for Notifications Forwarded to Desktop (authored by alexkovrigin).
Privacy Options for Notifications Forwarded to Desktop
Thu, Dec 13, 2:11 AM
sredman closed D17126: Privacy Options for Notifications Forwarded to Desktop.
Thu, Dec 13, 2:11 AM · KDE Connect

Wed, Dec 12

sredman added a dependency for D17521: Add incremental notifications plugin settings database upgrade: D17126: Privacy Options for Notifications Forwarded to Desktop.
Wed, Dec 12, 4:30 AM · KDE Connect
sredman added a dependent revision for D17126: Privacy Options for Notifications Forwarded to Desktop: D17521: Add incremental notifications plugin settings database upgrade.
Wed, Dec 12, 4:30 AM · KDE Connect
sredman accepted D17126: Privacy Options for Notifications Forwarded to Desktop.

Sorry this took so long

Wed, Dec 12, 4:30 AM · KDE Connect
sredman requested review of D17521: Add incremental notifications plugin settings database upgrade.
Wed, Dec 12, 4:28 AM · KDE Connect
sredman added a comment to D17250: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input.

Sorry, this is going to feel like a tease. This is really good, and I'm sorry I'm so picky :)

Wed, Dec 12, 1:21 AM · KDE Connect
sredman updated the diff for D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching.
  • Rebase on master (again)
Wed, Dec 12, 1:10 AM · KDE Connect
sredman committed R225:dda6a5104cf7: [Android] Change ThreadID to long (authored by sredman).
[Android] Change ThreadID to long
Wed, Dec 12, 1:05 AM
sredman committed R224:5cdfb9b087e1: [Desktop] Change ThreadID to long (authored by sredman).
[Desktop] Change ThreadID to long
Wed, Dec 12, 1:03 AM
sredman closed D17516: [Desktop] Change ThreadID to long.
Wed, Dec 12, 1:03 AM · KDE Connect
sredman closed D17517: [Android] Change ThreadID to long.
Wed, Dec 12, 1:03 AM · KDE Connect
sredman updated the diff for D15979: [SMS App] Allow scrolling up to load and display older messages.

Rebase on master via D16475

Wed, Dec 12, 12:57 AM · KDE Connect
sredman updated the diff for D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching.

Rebase onto master

Wed, Dec 12, 12:46 AM · KDE Connect
sredman updated the test plan for D17516: [Desktop] Change ThreadID to long.
Wed, Dec 12, 12:37 AM · KDE Connect
sredman updated the test plan for D17517: [Android] Change ThreadID to long.
Wed, Dec 12, 12:37 AM · KDE Connect
sredman requested review of D17517: [Android] Change ThreadID to long.
Wed, Dec 12, 12:32 AM · KDE Connect
sredman requested review of D17516: [Desktop] Change ThreadID to long.
Wed, Dec 12, 12:32 AM · KDE Connect

Mon, Dec 10

sredman added a comment to D17250: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input.

Since I've changed the identifier for the strings in every translation, it will not give any errors. I can post some Screenshots with other languages if you'd like!

Mon, Dec 10, 7:15 PM · KDE Connect
sredman added a comment to D17250: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input.

Updated the diff to reflect just the relevant changes for this commit.

Mon, Dec 10, 6:35 PM · KDE Connect

Thu, Dec 6

sredman added a comment to D17292: [SMS App] Allow passing a message via args.

I like the idea! It is very slick

  • It works for me
  • I think the operation should be cancel-able, maybe with an 'X' button on the InlineMessage banner to the right of "Choose recipient"
  • I think it would be better to not auto-send the message, but just populate the text box and leaving the user to push "Send" as a kind of confirmation. I click wrong buttons all the time, I would like a chance to double-check, especially in this case where there is no undo and potentially real-money cost.
Thu, Dec 6, 9:11 PM · KDE Connect
sredman accepted D17383: Don't use kcmshell5 for opening the KCM.

It works for me. I like this a lot better than before because I could never remember how to launch the settings panel! If you like, I can test it on my Ubuntu 18.04 Gnome VM before you merge.

Thu, Dec 6, 8:39 PM · KDE Connect

Mon, Dec 3

sredman added a comment to D17179: Potentially fix an issue with some Qt versions.
In D17179#370680, @apol wrote:

So if you change the import it works okay?

Mon, Dec 3, 3:43 PM · KDE Connect

Sun, Dec 2

sredman added a comment to D17179: Potentially fix an issue with some Qt versions.

Unfortunately, this doesn't work for me

Sun, Dec 2, 6:51 PM · KDE Connect
sredman added reviewers for D17179: Potentially fix an issue with some Qt versions: KDE Connect, sredman.
Sun, Dec 2, 6:34 PM · KDE Connect

Fri, Nov 30

sredman added a comment to D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching.

I get some compile errors, apparently you need to explicitly covert int to QString

Fri, Nov 30, 4:30 PM · KDE Connect
sredman requested changes to D17250: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input.
Fri, Nov 30, 3:45 PM · KDE Connect

Wed, Nov 28

sredman added a comment to D17214: GCI [KDE Connect] Start New Conversation in Messaging App.

Oh, I believe they are unique, but they are *also* unique to phone number. So there will never be a address with more than one thread_id; any messages received from or sent to that address will always appear in the same thread_id.

So what I mean is, when starting a "new" conversation, you can watch for new messages from the target address and catch the thread_id (probably even from your "sent confirmation" packet).

Wed, Nov 28, 9:48 PM · KDE Connect
sredman added a comment to D17214: GCI [KDE Connect] Start New Conversation in Messaging App.

There is also an error when you type the phone number for a contact with whom there is already a conversation

Something that might help when considering address vs thread_id, is to notice that if you receive an SMS on Android from any contact (ie. Mom/Dad) who share a phone number, Google/Android will just pick one and the messages will go there.

In other words, it may no even be possible to have two different thread_id's for the same address, so the thread_id is really only necessary for fetching messages. In the GSConnect UI, new incoming messages (whether for a new or existing conversation) are "routed" by address, not by thread_id, and I haven't found a situation where that breaks yet.

Wed, Nov 28, 9:38 PM · KDE Connect
sredman accepted D17224: Make the message TextField expanding, wrapping and scrollable.

This looks great! Thanks very much! Just fix the one small issue blocking message sending before merging, please :)

Wed, Nov 28, 9:34 PM · KDE Connect
sredman updated subscribers of D17214: GCI [KDE Connect] Start New Conversation in Messaging App.

This is good so far. Thank you!

Wed, Nov 28, 9:21 PM · KDE Connect
sredman added a comment to D17214: GCI [KDE Connect] Start New Conversation in Messaging App.

Let us know if you have any trouble with the rebase. If you did your work on the master branch, you should be able to just do git pull --rebase. If you did your work on a different branch, first change to master, then do git pull, then go back to your branch and do git rebase master

Wed, Nov 28, 3:53 PM · KDE Connect

Tue, Nov 27

sredman added a comment to D17126: Privacy Options for Notifications Forwarded to Desktop.

This is looking really good! I noticed that there seems to be a problem with the privacy options not being per-connection. I hid the contents for Gmail on my computer at home, but now Gmail contents are blocked on my work computer as well! Do you have some way to test with two desktop devices? I can look in to this as well, but I will not have time for at least a week, probably longer

Tue, Nov 27, 3:51 PM · KDE Connect

Sun, Nov 25

sredman added inline comments to D17126: Privacy Options for Notifications Forwarded to Desktop.
Sun, Nov 25, 7:37 PM · KDE Connect
sredman added a comment to D17126: Privacy Options for Notifications Forwarded to Desktop.

Go ahead and use my version. There are a few small things I noticed which I will point out after uploading (because the other form doesn't accept comments!)

Sun, Nov 25, 7:31 PM · KDE Connect
sredman added a comment to D17126: Privacy Options for Notifications Forwarded to Desktop.

I haven't completely figured out the problem yet, but one thing I have noticed is that the enable/disable checkbox for an app is no longer saved. This suggests to me that something about the way the database is set up is causing it to either not be read-able or not be write-able. You could check the return value from ourDatabase.insert. If it is -1, it means there was an error.

Sun, Nov 25, 6:29 PM · KDE Connect
sredman added a comment to D17126: Privacy Options for Notifications Forwarded to Desktop.

I haven't completely figured out the problem yet, but one thing I have noticed is that the enable/disable checkbox for an app is no longer saved. This suggests to me that something about the way the database is set up is causing it to either not be read-able or not be write-able. You could check the return value from ourDatabase.insert. If it is -1, it means there was an error.

Sun, Nov 25, 5:05 PM · KDE Connect

Sat, Nov 24

sredman added a comment to D17036: Updated README.md.

I'm happy. I'll leave it for Albert to click the final approval :)

Sat, Nov 24, 6:55 PM · KDE Connect
sredman added a comment to D17125: Title (/Header) in Run Command, Remote Input and Multimedia control was "Remote control". This patch fixes the said Title (/Header) to their respective plugin titles..

Are there strings (like "@string/remote_control") which are no longer in use? If so, those should probably be removed from res/values/strings/strings.xml

Sat, Nov 24, 1:02 AM · KDE Connect

Tue, Nov 20

sredman added a comment to D17036: Updated README.md.

This is good. Thank you!
I have added a few comments for making the English sound a little more natural, as well as some little fixes

Tue, Nov 20, 4:16 PM · KDE Connect

Mon, Nov 19

sredman closed T9841: Refactor duplicated code in KDE Connect Android-side SMS Helper as Resolved.

Resolved by @alexkovrigin in D17002

Mon, Nov 19, 5:26 PM · KDE Connect
sredman committed R225:9be46002ad87: Refactor Duplicated Code in KDE Connect Android-side SMS Helper (authored by alexkovrigin).
Refactor Duplicated Code in KDE Connect Android-side SMS Helper
Mon, Nov 19, 5:25 PM
sredman closed D17002: Refactor Duplicated Code in KDE Connect Android-side SMS Helper.
Mon, Nov 19, 5:21 PM · KDE Connect
sredman accepted D17002: Refactor Duplicated Code in KDE Connect Android-side SMS Helper.

This is great. Thank you very much!

Mon, Nov 19, 5:18 PM · KDE Connect
sredman added a comment to D17002: Refactor Duplicated Code in KDE Connect Android-side SMS Helper.

This is good work! Thank you. Were you able to get the app with this patch working for your own phone? If not, could you share the full stack trace (paste.kde.org) so I can have a look?
Don't forget to mark the GCi task as completed so I can approve it once we get this merged.

Mon, Nov 19, 4:04 PM · KDE Connect

Fri, Nov 16

sredman committed R224:c1e36895b56e: [Desktop] Make message syncronization interface capable of handling future… (authored by sredman).
[Desktop] Make message syncronization interface capable of handling future…
Fri, Nov 16, 12:06 AM
sredman closed D16599: [Desktop] Make message syncronization interface capable of handling future changes.
Fri, Nov 16, 12:04 AM · KDE Connect
sredman committed R225:da629f9756ac: [Android] Make message syncronization interface capable of handling future… (authored by sredman).
[Android] Make message syncronization interface capable of handling future…
Fri, Nov 16, 12:03 AM

Thu, Nov 15

sredman closed D16600: [Android] Make message syncronization interface capable of handling future changes.
Thu, Nov 15, 11:56 PM · KDE Connect

Nov 14 2018

sredman added a comment to D16881: Revert "A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon".

Indeed, I just read the commit message in kcrash:

The right fix is to create a QCoreApplication in all kioslaves

So other than the wrong subject there's nothing against this commit anymore.

Sorry for the noise.

Nov 14 2018, 6:36 PM · KDE Connect
sredman added a comment to D16881: Revert "A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon".

Is there some disadvantage to keeping things the way they are? From my understanding of the situation, having plugins instantiate a QApplication object is the way KIO wants things to be done (even though the particular commit which caused older plugins to break was a mistake that they have fixed). The .protocol file instead of the .json definitely seems to be the new way as well.

Nov 14 2018, 6:17 PM · KDE Connect

Nov 12 2018

sredman added a comment to D16553: Cache and delete old ConversationsDbusInterfaces to avoid memory leak.
In D16553#358421, @apol wrote:

This sounds weird, who caches the data? I don't think Qt does any caching, and if it's kde connect, nuking the dbus interface sounds like we're barking up the wrong tree.

Nov 12 2018, 5:22 PM · KDE Connect
sredman added a comment to D16599: [Desktop] Make message syncronization interface capable of handling future changes.
In D16599#358423, @apol wrote:

Other than that, let's get this in.

Nov 12 2018, 5:08 PM · KDE Connect
sredman updated the diff for D16599: [Desktop] Make message syncronization interface capable of handling future changes.
  • Rename containsPureText to containsTextBody
Nov 12 2018, 5:07 PM · KDE Connect
sredman added a comment to D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching.
In D16475#358422, @apol wrote:

I would be okay with accepting this patch. I wonder why it's better than the previous code though. It seems to be just doing the same but from another thread?

Nov 12 2018, 4:58 PM · KDE Connect
sredman updated the diff for D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching.
  • Move messy details of handling RequestConversationWorker into constructor
Nov 12 2018, 3:08 AM · KDE Connect

Nov 10 2018

sredman added a comment to D16769: [SMS App] Don't set font size, which causes warnings to be printed.

Tested successfully on Manjaro and Neon, so presumably good

Nov 10 2018, 4:45 PM · KDE Connect
sredman closed D16769: [SMS App] Don't set font size, which causes warnings to be printed.
Nov 10 2018, 4:44 PM · KDE Connect
sredman committed R224:73191d8565b7: [SMS App] Don't set font size, which causes warnings to be printed (authored by sredman).
[SMS App] Don't set font size, which causes warnings to be printed
Nov 10 2018, 4:44 PM

Nov 9 2018

sredman added a comment to D16782: Use plasma TextArea for sharing text in plasmoid.

Do we need both PlasmaComponents 2 and PlasmaComponents 3? (Does it make a difference?)

Nov 9 2018, 7:04 PM · KDE Connect
sredman added a reviewer for D16782: Use plasma TextArea for sharing text in plasmoid: KDE Connect.
Nov 9 2018, 6:26 PM · KDE Connect
sredman updated subscribers of D16782: Use plasma TextArea for sharing text in plasmoid.

This works on my computer. I have attached a screenshot. The borders, etc. look good with one line as well as many lines

Nov 9 2018, 6:26 PM · KDE Connect
sredman triaged T10015: Make messaging app text entry field multi-line, scrollable, and wrapping as Low priority.
Nov 9 2018, 4:58 PM · KDE Connect
sredman requested review of D16769: [SMS App] Don't set font size, which causes warnings to be printed.
Nov 9 2018, 12:45 AM · KDE Connect
sredman added a comment to D16553: Cache and delete old ConversationsDbusInterfaces to avoid memory leak.

I have been running this patch for about a week and it seems to be working safely (zero crashes) but I'm still concerned about the initial reasoning for not deleting the interface!

Nov 9 2018, 12:23 AM · KDE Connect

Nov 8 2018

sredman added a comment to D14607: Find my phone runner.

It looks like this patch has a dependency on another one. In my version of the repository, I don't have runners/CMakeLists.txt so this patch doesn't apply, and there is no reference to add_subdirectory(runners) in the top-level CMakeLists

Nov 8 2018, 11:50 PM · KDE Connect

Nov 7 2018

sredman committed R224:b0e9cb3c7c14: Add dependency for Qt Quick Controls 2 (authored by sredman).
Add dependency for Qt Quick Controls 2
Nov 7 2018, 4:59 PM
sredman closed D16718: Add dependency for Qt Quick Controls 2.
Nov 7 2018, 4:59 PM · KDE Connect
sredman updated the diff for D16718: Add dependency for Qt Quick Controls 2.
  • Change Kirigami URL
Nov 7 2018, 4:59 PM · KDE Connect
sredman accepted D16626: Fix deprecation warning.

I see now that this was a compile-time deprecation warning. Looks good to me!

Nov 7 2018, 3:57 AM · KDE Connect
sredman abandoned D16470: [WIP] Make incoming packet handling multi-threaded.

There is no reason to do this. If in the future there is some reason, we may come back to this

Nov 7 2018, 3:50 AM · KDE Connect
sredman planned changes to D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching.

With some time to think about this, I think I can combine some of Aleix's last comment. Rather than having the worker inherit from QThread, and rather than implicitly expecting the caller to know a QThread is required, the worker could have a QThread which it is in charge of creating, using, and destroying. I think this would make things much nicer.

Nov 7 2018, 3:49 AM · KDE Connect