sredman (Simon Redman)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 6:47 AM (113 w, 6 d)
Availability
Available

Recent Activity

Mon, Jul 15

sredman committed R225:70cf9e1bac97: Update in-repository documentation (authored by sredman).
Update in-repository documentation
Mon, Jul 15, 3:33 PM

Fri, Jul 12

sredman abandoned D22427: Updated german translation.
Fri, Jul 12, 9:05 PM · KDE Connect
sredman commandeered D22427: Updated german translation.

Hi sredman.

Thanks for the information. I did not know that there is a dedicated localization team, but I will contact them as soon as possible. Then, I guess you can close this review request.

Fri, Jul 12, 9:04 PM · KDE Connect
sredman added a comment to D22427: Updated german translation.

Hi skumblex. Thank you very much for taking the time to do this!

Fri, Jul 12, 8:51 PM · KDE Connect

Thu, Jul 11

sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Actually, there is a bit of a problem... The version of the file currently on master is bugged :(

See: https://phabricator.kde.org/D17908#492404

Any progress with the MS tool?

Thu, Jul 11, 9:21 PM · KDevelop

Tue, Jul 9

sredman committed R225:ffbceb9b8e2e: Reorder the Samsung special case to take effect before the case handling all… (authored by sredman).
Reorder the Samsung special case to take effect before the case handling all…
Tue, Jul 9, 9:16 AM

Mon, Jul 8

sredman added a comment to D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..

Actually, a pleasant surprise for today is that this whole mess of registry keys and environment variables is mostly unnecessary as of VS 2017, since Microsoft provides a tool which does all the locating work for us: https://github.com/microsoft/vswhere

Mon, Jul 8, 4:13 PM · KDevelop
sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Actually, there is a bit of a problem... The version of the file currently on master is bugged :(

Mon, Jul 8, 3:56 PM · KDevelop
sredman added a comment to D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..

Unfortunately, I have a problem with using the batch file from this diff on my system.

Mon, Jul 8, 3:42 PM · KDevelop
sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Ping? Please keep hammering the iron while hot :)

Mon, Jul 8, 1:20 PM · KDevelop

Wed, Jun 26

sredman added a comment to D21602: Add NSIS Script for KDE Connect.

Has this been landed yet? Is there any reason to keep it open?

Wed, Jun 26, 9:50 PM · Craft, KDE Connect

Sat, Jun 22

sredman committed R225:418e1a813e8a: Potentially fix SMS/MMS access on Samsung devices (authored by sredman).
Potentially fix SMS/MMS access on Samsung devices
Sat, Jun 22, 12:50 AM
sredman committed R225:50f395bdefd4: Potentially fix SMS/MMS access on Samsung devices (authored by sredman).
Potentially fix SMS/MMS access on Samsung devices
Sat, Jun 22, 12:50 AM

Wed, Jun 19

sredman created T11120: [SMS App] Add menu bar.
Wed, Jun 19, 5:57 PM · KDE Connect

Jun 16 2019

sredman committed R230:d7bd9dae5b09: Add myself (sredman) to relicensecheck.pl (authored by sredman).
Add myself (sredman) to relicensecheck.pl
Jun 16 2019, 4:30 PM

Jun 10 2019

sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

brauch is referring to this

for /f "usebackq tokens=3*" %%a in (`reg query "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7" /s`) do (
     set vs15_path=%%a %%b
     if exist "!vs15_path!Common7\Tools\VsDevCmd.bat" (
	set "VS150COMNTOOLS=!vs15_path!Common7\Tools\"
	goto :end
     )
   )
)
:end

Oops. What happened here is I was hacking on the release version which looks more like the patch I posted. I'll see if I can make sense of the master branch version and make it more like that!

Jun 10 2019, 6:50 PM · KDevelop
sredman added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Why did you replace the registry query by a fixed path?

Jun 10 2019, 6:29 PM · KDevelop
sredman committed R225:51e957d82290: [SMSApp] Support plain-text MMS (authored by sredman).
[SMSApp] Support plain-text MMS
Jun 10 2019, 5:51 AM

Jun 9 2019

sredman added a comment to D21661: add snoretoast backend for KNotifications on Windows.
In D21661#476571, @pino wrote:
In D21661#476156, @pino wrote:

how is snoretoast actually used here? you are requiring the library for building and linking, but then:

  • snoretoastactions.h, which is part of the headers of snoretoast, is copied here
  • the snoretoast library is never used, as the utilities of it are invoked instead If the library does all the work already, then I'd prefer to use it directly instead of spawning executables all the time...

Piyush, what about this? It seems the snoretoast library provides a SnoreToasts class to do this instead of spawning an helper tool, what about using it instead?

Jun 9 2019, 5:26 AM · Frameworks

Jun 8 2019

sredman accepted D21602: Add NSIS Script for KDE Connect.
Jun 8 2019, 2:59 AM · Craft, KDE Connect
sredman added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Jun 8 2019, 2:21 AM · Frameworks

Jun 7 2019

sredman committed R224:3c346b94096e: Block matching empty phone numbers (authored by sredman).
Block matching empty phone numbers
Jun 7 2019, 10:44 PM

Jun 6 2019

sredman committed R225:49295c0de98d: Make lint suppression less aggressive for SMSHelper (authored by sredman).
Make lint suppression less aggressive for SMSHelper
Jun 6 2019, 4:22 AM

Jun 5 2019

sredman added a comment to D21602: Add NSIS Script for KDE Connect.

The only thing I immediately see as a problem is the uninstaller doesn't have the proper branding (generic icons), and it didn't uninstall the desktop shortcut

Jun 5 2019, 4:14 PM · Craft, KDE Connect
sredman committed R224:c7579eb17017: Fix LanLinkProviderTest on Windows (authored by sredman).
Fix LanLinkProviderTest on Windows
Jun 5 2019, 3:16 PM
sredman committed R224:9453e640b302: Refactor testdevice (authored by sredman).
Refactor testdevice
Jun 5 2019, 2:42 AM
sredman committed R224:673c3ced69da: Make testsslsocketlistener properly timeout (authored by sredman).
Make testsslsocketlistener properly timeout
Jun 5 2019, 2:40 AM

Jun 4 2019

sredman added a reviewer for D21589: Duplicate Visual Studio 2017 hack for VS 2019: KDevelop.
Jun 4 2019, 9:27 PM · KDevelop
sredman requested review of D21589: Duplicate Visual Studio 2017 hack for VS 2019.
Jun 4 2019, 9:26 PM · KDevelop
sredman committed R224:0b797fc29d2d: Add eclipse settings files to .gitignore (authored by sredman).
Add eclipse settings files to .gitignore
Jun 4 2019, 6:03 PM

Jun 3 2019

sredman committed R224:4c75626919b2: Fix build (authored by sredman).
Fix build
Jun 3 2019, 4:25 AM
sredman committed R224:637285378d29: Add error logging to LanLinkProvider when binding the listener socket (authored by sredman).
Add error logging to LanLinkProvider when binding the listener socket
Jun 3 2019, 4:14 AM

Jun 2 2019

sredman committed R224:b4da91f86be3: Really actually fix Windows SMS app build (authored by sredman).
Really actually fix Windows SMS app build
Jun 2 2019, 9:47 PM
sredman committed R224:79325254b75e: Fix Windows SMS app build (authored by sredman).
Fix Windows SMS app build
Jun 2 2019, 9:28 PM
sredman committed R224:24ab6d15cfc2: ## Summary pluginloadtest and sendfiletest are crashing. This patch fixes that… (authored by sredman).
## Summary pluginloadtest and sendfiletest are crashing. This patch fixes that…
Jun 2 2019, 9:26 PM

Jun 1 2019

sredman closed T10185: SMS App Should Gracefully Handle Phone Re-Connection as Resolved.

Appears to be fixed by commit 9447d7e5def9f3a2d2bcaab10e7b646faaf041a3

Jun 1 2019, 4:55 PM · KDE Connect
sredman closed T10185: SMS App Should Gracefully Handle Phone Re-Connection, a subtask of T8337: SMS App Initial Release, as Resolved.
Jun 1 2019, 4:55 PM · KDE Connect
sredman committed R224:9447d7e5def9: Rearrange ConversationListModel to not set deviceID when it has been determined… (authored by sredman).
Rearrange ConversationListModel to not set deviceID when it has been determined…
Jun 1 2019, 4:46 PM

May 31 2019

sredman committed R224:05826cc65061: Allow all-zero phone number (authored by sredman).
Allow all-zero phone number
May 31 2019, 12:48 AM
sredman planned changes to D21374: WIP: Add support for KContacts::PhoneNumber-related custom data fields.

On hold until ~July 19

May 31 2019, 12:31 AM

May 30 2019

sredman committed R224:a5a0c16b61b7: Match contacts with many phone numbers (authored by sredman).
Match contacts with many phone numbers
May 30 2019, 7:18 PM

May 24 2019

sredman added a comment to D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects.
In D21369#469389, @apol wrote:

Seems like a clear layer break to spill KContacts over KPeople :P.
Let's discuss it at the sprint? Or earlier. Let's discuss it? ^^'

May 24 2019, 9:34 PM · Frameworks

May 23 2019

sredman updated the summary of D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects.
May 23 2019, 10:19 PM · Frameworks
sredman updated the diff for D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects.
  • Hack on QMetaType support
May 23 2019, 10:17 PM · Frameworks
sredman added a reviewer for D21374: WIP: Add support for KContacts::PhoneNumber-related custom data fields: apol.
May 23 2019, 10:17 PM
sredman requested review of D21374: WIP: Add support for KContacts::PhoneNumber-related custom data fields.
May 23 2019, 10:16 PM
sredman added a dependent revision for D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects: D21374: WIP: Add support for KContacts::PhoneNumber-related custom data fields.
May 23 2019, 10:16 PM · Frameworks
sredman updated the diff for D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects.
  • Add link_library target to backends as well
May 23 2019, 9:46 PM · Frameworks
sredman added a reviewer for D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects: apol.
May 23 2019, 8:46 PM · Frameworks
sredman updated the diff for D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects.
  • Move KF5::Contacts to PUBLIC library
May 23 2019, 8:44 PM · Frameworks
sredman requested review of D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects.
May 23 2019, 7:42 PM · Frameworks

May 22 2019

sredman committed R732:cdc69693d7b7: Make format of return value of AllPhoneNumbersProperty the same as… (authored by sredman).
Make format of return value of AllPhoneNumbersProperty the same as…
May 22 2019, 11:01 PM
sredman closed D21353: Make format of return value of AllPhoneNumbersProperty the same as PhoneNumberProperty but as a list.
May 22 2019, 11:01 PM
sredman added a comment to D21353: Make format of return value of AllPhoneNumbersProperty the same as PhoneNumberProperty but as a list.
In D21353#468804, @apol wrote:

How would you pass more information? in a QVariantMap?

May 22 2019, 10:58 PM
sredman added a comment to D21353: Make format of return value of AllPhoneNumbersProperty the same as PhoneNumberProperty but as a list.

Also, it looks like KContact::PhoneNumber is set up such that it could be used as a QVariant. From my point of view, the additional information in the PhoneNumber object would be useful so I could display something like "Simon Redman (Mobile)" or "Simon Redman (Home)" in case of multiple matches.

May 22 2019, 8:18 PM
sredman added a reviewer for D21353: Make format of return value of AllPhoneNumbersProperty the same as PhoneNumberProperty but as a list: apol.
May 22 2019, 8:04 PM
sredman requested review of D21353: Make format of return value of AllPhoneNumbersProperty the same as PhoneNumberProperty but as a list.
May 22 2019, 7:59 PM
sredman committed R994:844b51ee7b12: Add simple README (authored by sredman).
Add simple README
May 22 2019, 6:08 PM
sredman closed D21348: Add simple README.
May 22 2019, 6:08 PM · Plasma
sredman updated the diff for D21348: Add simple README.

Remove line about KDE Framework

May 22 2019, 6:06 PM · Plasma
Restricted Application added a project to D21348: Add simple README: Plasma.
May 22 2019, 6:01 PM · Plasma
sredman requested review of D21348: Add simple README.
May 22 2019, 6:01 PM · Plasma

May 15 2019

sredman added a comment to T8484: Making settting up a development environment quick and easy.

Apologies if this is already covered. I haven't looked deeply at the source materials in the very early links.

May 15 2019, 7:51 PM

May 9 2019

sredman committed R224:eb0e3fce0399: [Contacts Plugin] Fix brace placement and mild cleanup (authored by sredman).
[Contacts Plugin] Fix brace placement and mild cleanup
May 9 2019, 12:10 AM
sredman committed R224:320c070c9942: Move contacts synchronization to connected method (authored by sredman).
Move contacts synchronization to connected method
May 9 2019, 12:03 AM

May 5 2019

sredman committed R224:db611fae67b8: Revert "Remove unneeded src" (authored by sredman).
Revert "Remove unneeded src"
May 5 2019, 4:32 PM
sredman added a reverting change for R224:4c8c2b3d8fdc: Remove unneeded src: R224:db611fae67b8: Revert "Remove unneeded src".
May 5 2019, 4:32 PM

Apr 30 2019

sredman committed R224:459a1992e5ba: Check empty string using .isEmpty() instead of == "" (authored by sredman).
Check empty string using .isEmpty() instead of == ""
Apr 30 2019, 4:12 PM

Apr 19 2019

sredman added a reverting change for R225:aa776739b7fe: Try-with-resources on inputstreams: R225:dc5f10c07340: Revert "Try-with-resources on inputstreams".
Apr 19 2019, 5:10 AM
sredman committed R225:dc5f10c07340: Revert "Try-with-resources on inputstreams" (authored by sredman).
Revert "Try-with-resources on inputstreams"
Apr 19 2019, 5:10 AM

Apr 13 2019

sredman committed R225:b9f3c8c7b1ef: Add merge request templates (copy from kdeconnect-kde) (authored by sredman).
Add merge request templates (copy from kdeconnect-kde)
Apr 13 2019, 10:45 PM

Apr 12 2019

sredman assigned T10185: SMS App Should Gracefully Handle Phone Re-Connection to brute4s99.
Apr 12 2019, 9:15 PM · KDE Connect
sredman claimed T10183: SMS App should display some loading indicator while loading.
Apr 12 2019, 9:15 PM · KDE Connect
sredman added a comment to T10791: SMS app's message entry box should only grow to some bounded height.

It would be good to commit the above changes back to Kaidan when we have it working nicely, since the message composition box originally came from them.

Apr 12 2019, 6:08 PM · KDE Connect
sredman created T10791: SMS app's message entry box should only grow to some bounded height.
Apr 12 2019, 6:06 PM · KDE Connect
sredman renamed T10208: SMS App messages should be interact-able from SMS App should have click-able URLs to SMS App messages should be interact-able.
Apr 12 2019, 6:04 PM · KDE Connect

Apr 8 2019

sredman committed R225:7ce2130d12b0: Resize buttons on presentation remote (authored by xyphan).
Resize buttons on presentation remote
Apr 8 2019, 4:02 PM

Apr 7 2019

sredman committed R225:95f866ac9830: Properly check for size existence before reading (authored by sredman).
Properly check for size existence before reading
Apr 7 2019, 8:05 PM
sredman committed R225:27a2c030d6a7: Replaced getString(..) != null with isNull(..) (authored by sredman).
Replaced getString(..) != null with isNull(..)
Apr 7 2019, 8:05 PM
sredman committed R225:177c18e0f4f4: Clean up uriToNetworkPacket (authored by sredman).
Clean up uriToNetworkPacket
Apr 7 2019, 8:05 PM

Mar 22 2019

sredman accepted D12294: Send notification actions.

It works for me. Finally I am able to use my university's 2FA without actually touching my phone! :D

Mar 22 2019, 4:22 AM · KDE Connect
sredman committed R225:b725e81c3779: Re-add READ_SMS permission to SMS plugin (authored by sredman).
Re-add READ_SMS permission to SMS plugin
Mar 22 2019, 3:11 AM

Mar 21 2019

sredman committed R225:12fb67a7aa7f: Change hard-coded string to use library-provided constant (authored by sredman).
Change hard-coded string to use library-provided constant
Mar 21 2019, 5:13 PM

Mar 20 2019

sredman triaged T10650: Android<->Desktop SMS interface needs to account for deleted messages as Normal priority.
Mar 20 2019, 8:30 PM · KDE Connect

Mar 18 2019

sredman committed R224:a922ca570d31: Use Shift+Enter instead of Ctrl+Enter to add newline to in-progress SMS message (authored by sredman).
Use Shift+Enter instead of Ctrl+Enter to add newline to in-progress SMS message
Mar 18 2019, 10:14 PM
sredman closed D17616: [SMS App] Improve "No devices available" warning.
Mar 18 2019, 10:00 PM · KDE Connect
sredman committed R224:037543e42b2b: [SMS App] Improve "No devices available" warning (authored by sredman).
[SMS App] Improve "No devices available" warning
Mar 18 2019, 10:00 PM
sredman committed R224:5cac3992738d: Fix bug causing smsapp's '--message' argument to not pass data through (authored by sredman).
Fix bug causing smsapp's '--message' argument to not pass data through
Mar 18 2019, 9:58 PM
sredman updated the diff for D17616: [SMS App] Improve "No devices available" warning.
  • Rebase on master
  • Specify tooltip timeout
    • The documentation says -1 is the default, but apparently that wasn't working. With -1 expicitally specified, the no devices warning tooltip does not time out
Mar 18 2019, 9:57 PM · KDE Connect

Mar 10 2019

sredman committed R224:0bf02481a61c: Properly disable new message-entry area when device is disconnected (authored by sredman).
Properly disable new message-entry area when device is disconnected
Mar 10 2019, 12:27 AM

Mar 8 2019

sredman committed R224:8742dc579786: Fix doubly-nested ConversationDisplay which was causing messages to not be send… (authored by sredman).
Fix doubly-nested ConversationDisplay which was causing messages to not be send…
Mar 8 2019, 10:09 PM

Mar 7 2019

sredman added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

This has been stuck for super long, I'm really sorry... testing now.

I don't get any relevant place to pick from as a "storage location" on OnePlus 6 (only "Downloads"):

Why?

Mar 7 2019, 7:06 PM · KDE Connect
sredman accepted D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).
Mar 7 2019, 7:03 PM · KDE Connect
sredman added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

This has been stuck for super long, I'm really sorry... testing now.

I don't get any relevant place to pick from as a "storage location" on OnePlus 6 (only "Downloads"):

Why?

Mar 7 2019, 7:02 PM · KDE Connect

Mar 5 2019

sredman closed T10015: Make messaging app text entry field multi-line, scrollable, and wrapping as Resolved.

Hi everyone, I'm new here.

Mar 5 2019, 4:42 PM · KDE Connect

Feb 27 2019

sredman updated the diff for D17616: [SMS App] Improve "No devices available" warning.

Un-upload practically the entire repository.

Feb 27 2019, 6:18 AM · KDE Connect
sredman updated the diff for D17616: [SMS App] Improve "No devices available" warning.

Rebase on master

Feb 27 2019, 6:17 AM · KDE Connect
sredman committed R224:1ec20886a8ac: [SMS App] Add highlighting to ConversationList view (authored by sredman).
[SMS App] Add highlighting to ConversationList view
Feb 27 2019, 5:58 AM
sredman closed D17612: [SMS App] Add highlighting to ConversationList view.
Feb 27 2019, 5:46 AM · KDE Connect
sredman updated the diff for D17612: [SMS App] Add highlighting to ConversationList view.
  • Remove redundant highlighting configuration
Feb 27 2019, 5:45 AM · KDE Connect