sredman (Simon Redman)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 6:47 AM (105 w, 3 d)
Availability
Available

Recent Activity

Wed, May 15

sredman added a comment to T8484: Making settting up a development environment quick and easy.

Apologies if this is already covered. I haven't looked deeply at the source materials in the very early links.

Wed, May 15, 7:51 PM

Thu, May 9

sredman committed R224:eb0e3fce0399: [Contacts Plugin] Fix brace placement and mild cleanup (authored by sredman).
[Contacts Plugin] Fix brace placement and mild cleanup
Thu, May 9, 12:10 AM
sredman committed R224:320c070c9942: Move contacts synchronization to connected method (authored by sredman).
Move contacts synchronization to connected method
Thu, May 9, 12:03 AM

Sun, May 5

sredman committed R224:db611fae67b8: Revert "Remove unneeded src" (authored by sredman).
Revert "Remove unneeded src"
Sun, May 5, 4:32 PM
sredman added a reverting change for R224:4c8c2b3d8fdc: Remove unneeded src: R224:db611fae67b8: Revert "Remove unneeded src".
Sun, May 5, 4:32 PM

Tue, Apr 30

sredman committed R224:459a1992e5ba: Check empty string using .isEmpty() instead of == "" (authored by sredman).
Check empty string using .isEmpty() instead of == ""
Tue, Apr 30, 4:12 PM

Apr 19 2019

sredman added a reverting change for R225:aa776739b7fe: Try-with-resources on inputstreams: R225:dc5f10c07340: Revert "Try-with-resources on inputstreams".
Apr 19 2019, 5:10 AM
sredman committed R225:dc5f10c07340: Revert "Try-with-resources on inputstreams" (authored by sredman).
Revert "Try-with-resources on inputstreams"
Apr 19 2019, 5:10 AM

Apr 13 2019

sredman committed R225:b9f3c8c7b1ef: Add merge request templates (copy from kdeconnect-kde) (authored by sredman).
Add merge request templates (copy from kdeconnect-kde)
Apr 13 2019, 10:45 PM

Apr 12 2019

sredman assigned T10185: SMS App Should Gracefully Handle Phone Re-Connection to brute4s99.
Apr 12 2019, 9:15 PM · KDE Connect
sredman claimed T10183: SMS App should display some loading indicator while loading.
Apr 12 2019, 9:15 PM · KDE Connect
sredman added a comment to T10791: SMS app's message entry box should only grow to some bounded height.

It would be good to commit the above changes back to Kaidan when we have it working nicely, since the message composition box originally came from them.

Apr 12 2019, 6:08 PM · KDE Connect
sredman created T10791: SMS app's message entry box should only grow to some bounded height.
Apr 12 2019, 6:06 PM · KDE Connect
sredman renamed T10208: SMS App messages should be interact-able from SMS App should have click-able URLs to SMS App messages should be interact-able.
Apr 12 2019, 6:04 PM · KDE Connect

Apr 8 2019

sredman committed R225:7ce2130d12b0: Resize buttons on presentation remote (authored by xyphan).
Resize buttons on presentation remote
Apr 8 2019, 4:02 PM

Apr 7 2019

sredman committed R225:95f866ac9830: Properly check for size existence before reading (authored by sredman).
Properly check for size existence before reading
Apr 7 2019, 8:05 PM
sredman committed R225:27a2c030d6a7: Replaced getString(..) != null with isNull(..) (authored by sredman).
Replaced getString(..) != null with isNull(..)
Apr 7 2019, 8:05 PM
sredman committed R225:177c18e0f4f4: Clean up uriToNetworkPacket (authored by sredman).
Clean up uriToNetworkPacket
Apr 7 2019, 8:05 PM

Mar 22 2019

sredman accepted D12294: Send notification actions.

It works for me. Finally I am able to use my university's 2FA without actually touching my phone! :D

Mar 22 2019, 4:22 AM · KDE Connect
sredman committed R225:b725e81c3779: Re-add READ_SMS permission to SMS plugin (authored by sredman).
Re-add READ_SMS permission to SMS plugin
Mar 22 2019, 3:11 AM

Mar 21 2019

sredman committed R225:12fb67a7aa7f: Change hard-coded string to use library-provided constant (authored by sredman).
Change hard-coded string to use library-provided constant
Mar 21 2019, 5:13 PM

Mar 20 2019

sredman triaged T10650: Android<->Desktop SMS interface needs to account for deleted messages as Normal priority.
Mar 20 2019, 8:30 PM · KDE Connect

Mar 18 2019

sredman committed R224:a922ca570d31: Use Shift+Enter instead of Ctrl+Enter to add newline to in-progress SMS message (authored by sredman).
Use Shift+Enter instead of Ctrl+Enter to add newline to in-progress SMS message
Mar 18 2019, 10:14 PM
sredman closed D17616: [SMS App] Improve "No devices available" warning.
Mar 18 2019, 10:00 PM · KDE Connect
sredman committed R224:037543e42b2b: [SMS App] Improve "No devices available" warning (authored by sredman).
[SMS App] Improve "No devices available" warning
Mar 18 2019, 10:00 PM
sredman committed R224:5cac3992738d: Fix bug causing smsapp's '--message' argument to not pass data through (authored by sredman).
Fix bug causing smsapp's '--message' argument to not pass data through
Mar 18 2019, 9:58 PM
sredman updated the diff for D17616: [SMS App] Improve "No devices available" warning.
  • Rebase on master
  • Specify tooltip timeout
    • The documentation says -1 is the default, but apparently that wasn't working. With -1 expicitally specified, the no devices warning tooltip does not time out
Mar 18 2019, 9:57 PM · KDE Connect

Mar 10 2019

sredman committed R224:0bf02481a61c: Properly disable new message-entry area when device is disconnected (authored by sredman).
Properly disable new message-entry area when device is disconnected
Mar 10 2019, 12:27 AM

Mar 8 2019

sredman committed R224:8742dc579786: Fix doubly-nested ConversationDisplay which was causing messages to not be send… (authored by sredman).
Fix doubly-nested ConversationDisplay which was causing messages to not be send…
Mar 8 2019, 10:09 PM

Mar 7 2019

sredman added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

This has been stuck for super long, I'm really sorry... testing now.

I don't get any relevant place to pick from as a "storage location" on OnePlus 6 (only "Downloads"):

Why?

Mar 7 2019, 7:06 PM · KDE Connect
sredman accepted D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).
Mar 7 2019, 7:03 PM · KDE Connect
sredman added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

This has been stuck for super long, I'm really sorry... testing now.

I don't get any relevant place to pick from as a "storage location" on OnePlus 6 (only "Downloads"):

Why?

Mar 7 2019, 7:02 PM · KDE Connect

Mar 5 2019

sredman closed T10015: Make messaging app text entry field multi-line, scrollable, and wrapping as Resolved.

Hi everyone, I'm new here.

Mar 5 2019, 4:42 PM · KDE Connect

Feb 27 2019

sredman updated the diff for D17616: [SMS App] Improve "No devices available" warning.

Un-upload practically the entire repository.

Feb 27 2019, 6:18 AM · KDE Connect
sredman updated the diff for D17616: [SMS App] Improve "No devices available" warning.

Rebase on master

Feb 27 2019, 6:17 AM · KDE Connect
sredman committed R224:1ec20886a8ac: [SMS App] Add highlighting to ConversationList view (authored by sredman).
[SMS App] Add highlighting to ConversationList view
Feb 27 2019, 5:58 AM
sredman closed D17612: [SMS App] Add highlighting to ConversationList view.
Feb 27 2019, 5:46 AM · KDE Connect
sredman updated the diff for D17612: [SMS App] Add highlighting to ConversationList view.
  • Remove redundant highlighting configuration
Feb 27 2019, 5:45 AM · KDE Connect

Feb 20 2019

sredman added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Cool! I like the warning popup!

Feb 20 2019, 11:21 PM · KDE Connect

Feb 9 2019

sredman accepted D17292: [SMS App] Allow passing a message via args.

Reminder that there is a spelling error on line 37 of ConversationList.qml

Feb 9 2019, 4:27 PM · KDE Connect

Jan 24 2019

sredman added a comment to D16071: Use input field from Kaidan.

I don't have a problem with this. Like you say, if the future gives us what we need, we can change then. Of course, this patch will take a little bit of effort to rebase since lots of things around the text field have changed :/

Jan 24 2019, 5:47 PM · KDE Connect
sredman committed R224:3b92b0de1d57: Add dependency on kirigami to SMS app (authored by sredman).
Add dependency on kirigami to SMS app
Jan 24 2019, 5:41 PM
sredman closed D17572: Add dependency on kirigami to SMS app.
Jan 24 2019, 5:40 PM · KDE Connect

Jan 23 2019

sredman committed R224:a14b39d54116: [SMS App] Make sms app not crash when conversation is selected with no devices… (authored by sredman).
[SMS App] Make sms app not crash when conversation is selected with no devices…
Jan 23 2019, 1:58 AM
sredman closed T10184: SMS App Should Gracefully Handle Phone Disconnection, a subtask of T8337: SMS App Initial Release, as Resolved.
Jan 23 2019, 1:58 AM · KDE Connect
sredman closed D17634: [SMS App] Make sms app not crash when conversation is selected with no devices connected.
Jan 23 2019, 1:58 AM · KDE Connect
sredman closed T10184: SMS App Should Gracefully Handle Phone Disconnection as Resolved by committing R224:a14b39d54116: [SMS App] Make sms app not crash when conversation is selected with no devices….
Jan 23 2019, 1:58 AM · KDE Connect
sredman planned changes to D17616: [SMS App] Improve "No devices available" warning.

I just noticed today that the tooltip disappears after a few seconds. I will have to find a solution to this problem.

Jan 23 2019, 1:28 AM · KDE Connect

Jan 21 2019

sredman committed R224:74ba660cad19: Cache and delete old ConversationsDbusInterfaces to avoid memory leak (authored by sredman).
Cache and delete old ConversationsDbusInterfaces to avoid memory leak
Jan 21 2019, 7:07 PM
sredman closed D16553: Cache and delete old ConversationsDbusInterfaces to avoid memory leak.
Jan 21 2019, 7:01 PM · KDE Connect
sredman added a comment to D18140: Add plugin for taking photos on remote device.
In D18140#392884, @apol wrote:

Can you elaborate a bit on the use-case?

I also find the use case a bit obscure.

Unless you are a spy and want to take photos from your phone without anyone noticing, I see no use of this plugin.

Jan 21 2019, 5:56 PM · KDE Connect

Jan 18 2019

sredman added a comment to D17634: [SMS App] Make sms app not crash when conversation is selected with no devices connected.

I can confirm that it doesn't crash when I unpair my device, but now there's the "No device" warning and the conversation list visible simultaneously

Jan 18 2019, 5:51 PM · KDE Connect

Jan 14 2019

sredman updated the diff for D16553: Cache and delete old ConversationsDbusInterfaces to avoid memory leak.
  • Clairify pointer-saving comment
Jan 14 2019, 8:42 PM · KDE Connect

Jan 13 2019

sredman added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

The downside of this patch is it changes the default: I was very confused that I couldn't immediately see my USB drive and internal storage from Dolphin. Our per-plugin settings are very non-obvious :/. Is it possible to either display a dummy "you need to configure settings" file, or to show everything by default (as things currently are) and leave the settings so advanced users can hide filesystems if they like?

Jan 13 2019, 4:26 PM · KDE Connect
sredman added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

USB OTG Testing looks good:

  • Before this patch, I was able to read/write USB OTG storage already
  • With this patch, I was able to add USB OTG as an exposed filesystem
  • After adding as an exposed filesystem, I was able to read/write the USB OTG drive
Jan 13 2019, 4:24 PM · KDE Connect

Jan 2 2019

sredman closed T8288: Drag n Drop Filetransfer on the plasmoid, a subtask of T8293: Improve file sharing, as Resolved.
Jan 2 2019, 5:28 PM · Junior Jobs, KDE Connect
sredman closed T8288: Drag n Drop Filetransfer on the plasmoid as Resolved.
Jan 2 2019, 5:28 PM · Junior Jobs, KDE Connect
sredman committed R224:bafbc344b931: Implement Drag n Drop file transfer on the plasmoid (authored by sredman).
Implement Drag n Drop file transfer on the plasmoid
Jan 2 2019, 5:26 PM
sredman added a commit to T8288: Drag n Drop Filetransfer on the plasmoid: R224:bafbc344b931: Implement Drag n Drop file transfer on the plasmoid.
Jan 2 2019, 5:26 PM · Junior Jobs, KDE Connect
sredman closed D17611: Implement Drag n Drop file transfer on the plasmoid.
Jan 2 2019, 5:26 PM · KDE Connect

Dec 26 2018

sredman added a comment to D17790: Port away from QCA.

Using the command line tool means this is a runtime dependency only. You could run kdeconnect without having openssl installed and it would fail mysteriously.

We can either check that it exists and output a specific error, or change to a compile-time dependency (libopenssl? Not sure if it exists).

Dec 26 2018, 9:48 PM · KDE Connect

Dec 23 2018

sredman accepted D17611: Implement Drag n Drop file transfer on the plasmoid.

Hello,

I have tested a few things but could not manage to get the tooltip to show everywhere without causing issues with the rest of the widgets. Putting the tooltip on top (with the property z greater than 0) prevents underlying widgets from receiving mouse movements, thus making them look weird. I do not have any improvement for now before merging.

Dec 23 2018, 11:49 PM · KDE Connect

Dec 21 2018

sredman renamed T10208: SMS App messages should be interact-able from Make URLs click-able to SMS App should have click-able URLs.
Dec 21 2018, 3:38 PM · KDE Connect
sredman created T10208: SMS App messages should be interact-able.
Dec 21 2018, 3:29 PM · KDE Connect

Dec 18 2018

sredman added a comment to D17292: [SMS App] Allow passing a message via args.
  • Only fill in message field and make it cancellable
Dec 18 2018, 6:49 AM · KDE Connect
sredman renamed T10186: SMS App Should Instantly Show the Most-Recent Message when Conversation is Opened from SMS App Should Show the Most-Recent Message when Conversation is Opened to SMS App Should Instantly Show the Most-Recent Message when Conversation is Opened.
Dec 18 2018, 6:27 AM · KDE Connect
sredman updated the diff for D17616: [SMS App] Improve "No devices available" warning.
  • Change button for MouseArea
Dec 18 2018, 6:11 AM · KDE Connect
sredman added a comment to D17611: Implement Drag n Drop file transfer on the plasmoid.

Very cool! I can now drop onto the desktop plasmoid and have it share without the weird popup, and I can expand the toolbar plasmoid by hovering over it while dragging. Nice!

Dec 18 2018, 5:35 AM · KDE Connect
sredman planned changes to D17553: Use typedef threadID_t qint64 instead of hard-coding.

This revision cannot currently land: It needs either updated Qt Tools support (https://bugreports.qt.io/browse/QTBUG-72522) or we need to somehow upgrade our build system to allow custom types to be defined in the dbus XML

Dec 18 2018, 2:03 AM · KDE Connect

Dec 17 2018

sredman updated the diff for D17612: [SMS App] Add highlighting to ConversationList view.

Only do patch since D17634

Dec 17 2018, 7:25 PM · KDE Connect
sredman added a dependency for D17612: [SMS App] Add highlighting to ConversationList view: D17634: [SMS App] Make sms app not crash when conversation is selected with no devices connected.
Dec 17 2018, 7:24 PM · KDE Connect
sredman added a dependent revision for D17634: [SMS App] Make sms app not crash when conversation is selected with no devices connected: D17612: [SMS App] Add highlighting to ConversationList view.
Dec 17 2018, 7:24 PM · KDE Connect
sredman updated the summary of D17612: [SMS App] Add highlighting to ConversationList view.
Dec 17 2018, 7:24 PM · KDE Connect
sredman updated the diff for D17612: [SMS App] Add highlighting to ConversationList view.
  • Keep currently-open chat highlighted even when the list loses focus
Dec 17 2018, 7:23 PM · KDE Connect
sredman committed R224:5b213e614498: [SMS App] Improve filter (authored by sredman).
[SMS App] Improve filter
Dec 17 2018, 4:28 PM
sredman closed T8341: Contacts search box does not work, a subtask of T8337: SMS App Initial Release, as Resolved.
Dec 17 2018, 4:28 PM · KDE Connect
sredman closed T8341: Contacts search box does not work as Resolved by committing R224:5b213e614498: [SMS App] Improve filter.
Dec 17 2018, 4:28 PM · KDE Connect
sredman closed D17614: [SMS App] Improve filter.
Dec 17 2018, 4:26 PM · KDE Connect

Dec 16 2018

sredman removed a revision from T10183: SMS App should display some loading indicator while loading: D17634: [SMS App] Make sms app not crash when conversation is selected with no devices connected.
Dec 16 2018, 11:40 PM · KDE Connect
sredman removed a task from D17634: [SMS App] Make sms app not crash when conversation is selected with no devices connected: T10183: SMS App should display some loading indicator while loading.
Dec 16 2018, 11:40 PM · KDE Connect
sredman added a task to D17634: [SMS App] Make sms app not crash when conversation is selected with no devices connected: T10184: SMS App Should Gracefully Handle Phone Disconnection.
Dec 16 2018, 11:39 PM · KDE Connect
sredman added a revision to T10184: SMS App Should Gracefully Handle Phone Disconnection: D17634: [SMS App] Make sms app not crash when conversation is selected with no devices connected.
Dec 16 2018, 11:39 PM · KDE Connect
sredman requested review of D17634: [SMS App] Make sms app not crash when conversation is selected with no devices connected.
Dec 16 2018, 8:22 PM · KDE Connect
sredman added a revision to T10183: SMS App should display some loading indicator while loading: D17634: [SMS App] Make sms app not crash when conversation is selected with no devices connected.
Dec 16 2018, 8:22 PM · KDE Connect
sredman updated the diff for D16553: Cache and delete old ConversationsDbusInterfaces to avoid memory leak.

Rebase onto master to avoid merge conflict

Dec 16 2018, 5:05 AM · KDE Connect
sredman updated the summary of D17616: [SMS App] Improve "No devices available" warning.
Dec 16 2018, 2:01 AM · KDE Connect
sredman requested review of D17616: [SMS App] Improve "No devices available" warning.
Dec 16 2018, 2:00 AM · KDE Connect
sredman committed R224:657dede4bf28: Add contributors to smsapp QML files (authored by sredman).
Add contributors to smsapp QML files
Dec 16 2018, 12:26 AM
sredman added a comment to D17611: Implement Drag n Drop file transfer on the plasmoid.

This is cool! But kind of finicky:

Dec 16 2018, 12:23 AM · KDE Connect
sredman requested review of D17614: [SMS App] Improve filter.
Dec 16 2018, 12:10 AM · KDE Connect
sredman added a revision to T8341: Contacts search box does not work: D17614: [SMS App] Improve filter.
Dec 16 2018, 12:10 AM · KDE Connect

Dec 15 2018

sredman requested review of D17612: [SMS App] Add highlighting to ConversationList view.
Dec 15 2018, 11:55 PM · KDE Connect

Dec 14 2018

sredman accepted D17250: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input.
Dec 14 2018, 10:09 PM · KDE Connect
sredman committed R224:900943995660: Handle case where more messages were requested but there were no more available… (authored by sredman).
Handle case where more messages were requested but there were no more available…
Dec 14 2018, 5:03 PM

Dec 13 2018

sredman added a comment to T10187: SMS App Should Request Enough Messages to Fill the Initial Window.

Maybe we could just increase the hardcoded number as a first workaround? I think 20 should be enough for most cases

Dec 13 2018, 11:03 PM · KDE Connect
sredman raised the priority of T10184: SMS App Should Gracefully Handle Phone Disconnection from Normal to High.
Dec 13 2018, 9:34 PM · KDE Connect
sredman renamed T10185: SMS App Should Gracefully Handle Phone Re-Connection from Messaging App Should Gracefully Handle Phone Re-Connection to SMS App Should Gracefully Handle Phone Re-Connection.
Dec 13 2018, 9:33 PM · KDE Connect
sredman renamed T10184: SMS App Should Gracefully Handle Phone Disconnection from Messaging App Should Gracefully Handle Phone Disconnection to SMS App Should Gracefully Handle Phone Disconnection.
Dec 13 2018, 9:33 PM · KDE Connect
sredman renamed T8337: SMS App Initial Release from SMS App to SMS App Initial Release.
Dec 13 2018, 9:32 PM · KDE Connect
sredman triaged T10187: SMS App Should Request Enough Messages to Fill the Initial Window as Normal priority.
Dec 13 2018, 9:31 PM · KDE Connect