- Group Reviewers
- R318:7165ea7afdf1: Add Reset Zoom Level action inside View menu
Cool, it works and the code is looking pretty good. Now I think the new action needs to be added to the View menu too, between the zoom in and zoom out menu items. The place where you've added it in dolphinui.rc doesn't actually do that.
Sorry, I steered you wrong. The text needs to Use Title Case:
"Reset zoom level"
Ah, looks like Dolphin conditionally adds the zoom actions to the main menu in dolphinmainwindow.cpp (lines 984-988). That's where you should add the new action. Then I guess you don't need to touch the rc files.
Still not fixed ;)
Please remove the spaces before/after QStringLiteral
Unrelated change, should go to its own commit. (feel free to push it without review...)
Sorry but I don't like this solution (i.e. creating a settings tab widget inside the action handler). Please try the following instead: