FEATURE: 409591
FIXED-IN: 19.12.0
Details
- Reviewers
elvisangelaccio shubham - Group Reviewers
Dolphin - Commits
- R318:7165ea7afdf1: Add Reset Zoom Level action inside View menu
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/views/dolphinviewactionhandler.cpp | ||
---|---|---|
467 | There is nothing like "default". zoomlevelinfo.cpp also have only min and max values for levels. I have choosen 5px as it looks perfect. |
src/views/dolphinviewactionhandler.cpp | ||
---|---|---|
483 | This is troubling me for some time now. It gives undefined reference linker error. I have already included the corresponding header file. |
Cool, it works and the code is looking pretty good. Now I think the new action needs to be added to the View menu too, between the zoom in and zoom out menu items. The place where you've added it in dolphinui.rc doesn't actually do that.
src/views/dolphinviewactionhandler.cpp | ||
---|---|---|
192 | Sorry, I steered you wrong. The text needs to Use Title Case: "Reset zoom level" |
Please use a descriptive commit message: https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages
Ah, looks like Dolphin conditionally adds the zoom actions to the main menu in dolphinmainwindow.cpp (lines 984-988). That's where you should add the new action. Then I guess you don't need to touch the rc files.
The HIG is silent on the matter, but Okular and Konsole put the reset action in the middle, so I think it makes sense to do the same here.
Oops, I had a perception that you have to press - twice to zoom out. Maybe it came to me from Windows.
Still not fixed ;)
src/views/dolphinviewactionhandler.cpp | ||
---|---|---|
191 | Please remove the spaces before/after QStringLiteral | |
203 | Unrelated change, should go to its own commit. (feel free to push it without review...) | |
467–485 | Sorry but I don't like this solution (i.e. creating a settings tab widget inside the action handler). Please try the following instead:
|
That's strange, it worked before (see the screenshot), but now I don't see it there either. :/ Will investigate and fix.