brute4s99 (Piyush Aggarwal)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 18 2018, 7:19 PM (48 w, 1 d)
Availability
Available

Recent Activity

Today

brute4s99 abandoned D23313: improve code in Snore backend.

in that case I should rather leave this diff. I agree this would be messy for the history.

Thu, Aug 22, 2:44 AM · Frameworks
brute4s99 committed R224:f65737da2132: add basic SFTP Plugin for Windows (authored by brute4s99).
add basic SFTP Plugin for Windows
Thu, Aug 22, 2:21 AM

Yesterday

brute4s99 updated the task description for T11430: Attend External Events 2019: PyCon India 2019.
Wed, Aug 21, 9:50 PM
brute4s99 updated the task description for T11430: Attend External Events 2019: PyCon India 2019.
Wed, Aug 21, 9:44 PM
brute4s99 updated the task description for T11430: Attend External Events 2019: PyCon India 2019.
Wed, Aug 21, 9:43 PM
brute4s99 updated the task description for T11430: Attend External Events 2019: PyCon India 2019.
Wed, Aug 21, 9:39 PM
brute4s99 updated the task description for T11430: Attend External Events 2019: PyCon India 2019.
Wed, Aug 21, 9:37 PM
brute4s99 updated the task description for T11430: Attend External Events 2019: PyCon India 2019.
Wed, Aug 21, 9:37 PM
brute4s99 claimed T11430: Attend External Events 2019: PyCon India 2019.
Wed, Aug 21, 9:31 PM
brute4s99 updated the task description for T11430: Attend External Events 2019: PyCon India 2019.
Wed, Aug 21, 9:30 PM
brute4s99 updated the task description for T11430: Attend External Events 2019: PyCon India 2019.
Wed, Aug 21, 9:29 PM
brute4s99 created T11430: Attend External Events 2019: PyCon India 2019.
Wed, Aug 21, 9:28 PM
brute4s99 committed R224:c22c670feef5: pause music plugin for Win32 (authored by brute4s99).
pause music plugin for Win32
Wed, Aug 21, 2:39 AM
brute4s99 requested review of D23313: improve code in Snore backend.
Wed, Aug 21, 12:57 AM · Frameworks

Tue, Aug 20

brute4s99 committed R877:7bea2d190df9: add sms app and URL-handler to packages (authored by brute4s99).
add sms app and URL-handler to packages
Tue, Aug 20, 7:29 PM
brute4s99 closed D23304: add sms app and URL-handler to packages.
Tue, Aug 20, 7:29 PM
brute4s99 updated the diff for D23304: add sms app and URL-handler to packages.
Tue, Aug 20, 7:29 PM
brute4s99 requested review of D23304: add sms app and URL-handler to packages.
Tue, Aug 20, 7:26 PM
brute4s99 added a comment to D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.

landed it!

a duckling

Tue, Aug 20, 1:48 PM · Frameworks
brute4s99 committed R289:a9b61d5b0cb8: avoid duplicate notifications from showing up on Windows and remove whitespaces (authored by brute4s99).
avoid duplicate notifications from showing up on Windows and remove whitespaces
Tue, Aug 20, 1:47 PM
brute4s99 closed D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.
Tue, Aug 20, 1:47 PM · Frameworks
brute4s99 updated subscribers of D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.

Just on Windows, or does this fix the problem on Linux too?

Tue, Aug 20, 1:45 PM · Frameworks
brute4s99 committed R289:e96bf17d8cac: have 1024x1024 app icon as fallback icon in Snore (authored by brute4s99).
have 1024x1024 app icon as fallback icon in Snore
Tue, Aug 20, 1:19 PM
brute4s99 closed D23196: have 1024x1024 app icon as fallback icon in Snore.
Tue, Aug 20, 1:19 PM · Frameworks
brute4s99 updated the diff for D23196: have 1024x1024 app icon as fallback icon in Snore.

changed line endings to Unix style

Tue, Aug 20, 1:18 PM · Frameworks
brute4s99 abandoned D23291: have application's icon as fallback icon in Snore.
Tue, Aug 20, 1:17 PM · Frameworks
brute4s99 updated the diff for D23291: have application's icon as fallback icon in Snore.
Tue, Aug 20, 1:17 PM · Frameworks
brute4s99 requested review of D23291: have application's icon as fallback icon in Snore.
Tue, Aug 20, 1:15 PM · Frameworks
brute4s99 added a comment to D23196: have 1024x1024 app icon as fallback icon in Snore.

landing it!

a duckling

Tue, Aug 20, 1:13 PM · Frameworks
brute4s99 updated the diff for D23196: have 1024x1024 app icon as fallback icon in Snore.

removed actualSize in favour of always passing an icon of size 1024x1024 to SnoreToast

Tue, Aug 20, 1:12 PM · Frameworks
brute4s99 updated the diff for D23196: have 1024x1024 app icon as fallback icon in Snore.
Tue, Aug 20, 12:59 PM · Frameworks
brute4s99 updated the diff for D23196: have 1024x1024 app icon as fallback icon in Snore.

rebased

Tue, Aug 20, 12:56 PM · Frameworks
brute4s99 added a comment to D23196: have 1024x1024 app icon as fallback icon in Snore.

landing it!

a duckling

Tue, Aug 20, 12:54 PM · Frameworks
brute4s99 committed R289:ee5c3d12f965: add `-pid` parameter to Snore backend calls (authored by brute4s99).
add `-pid` parameter to Snore backend calls
Tue, Aug 20, 12:46 PM
brute4s99 closed D23282: add `-pid` parameter to Snore backend calls.
Tue, Aug 20, 12:46 PM · Frameworks
brute4s99 updated the diff for D23282: add `-pid` parameter to Snore backend calls.
Tue, Aug 20, 12:46 PM · Frameworks
brute4s99 added a comment to D23282: add `-pid` parameter to Snore backend calls.

had some non-unix line endings, so updated the diff.

Tue, Aug 20, 12:45 PM · Frameworks
brute4s99 updated the diff for D23282: add `-pid` parameter to Snore backend calls.
Tue, Aug 20, 12:44 PM · Frameworks
brute4s99 added a comment to D23282: add `-pid` parameter to Snore backend calls.

landing it!

a duckling

Tue, Aug 20, 12:41 PM · Frameworks

Mon, Aug 19

brute4s99 added a comment to T11398: Publish KDE Connect to the Windows Store.

the builds are successfully being built on the CI now. We just need to iron out the kinks so it actually works like it should, on all systems.

Mon, Aug 19, 11:13 PM · KDE Connect
brute4s99 added a comment to T11398: Publish KDE Connect to the Windows Store.

reference patch : https://phabricator.kde.org/D23209 (merged already)

Mon, Aug 19, 11:11 PM · KDE Connect
brute4s99 updated the task description for T11398: Publish KDE Connect to the Windows Store.
Mon, Aug 19, 11:10 PM · KDE Connect
brute4s99 added a comment to D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.

can I merge this one? 👀

Mon, Aug 19, 10:52 PM · Frameworks
brute4s99 added a dependency for D23282: add `-pid` parameter to Snore backend calls: D23273: Allow to pass pid in addition to appID try to deduce appID from pid.
Mon, Aug 19, 10:42 PM · Frameworks
brute4s99 added a dependent revision for D23273: Allow to pass pid in addition to appID try to deduce appID from pid: D23282: add `-pid` parameter to Snore backend calls.
Mon, Aug 19, 10:42 PM
brute4s99 requested review of D23282: add `-pid` parameter to Snore backend calls.
Mon, Aug 19, 10:41 PM · Frameworks
brute4s99 added a comment to D23196: have 1024x1024 app icon as fallback icon in Snore.

may I land this now? 👀

Mon, Aug 19, 8:50 PM · Frameworks
brute4s99 committed R877:477cbe230ff1: add images to KDE Connect .Appx build (authored by brute4s99).
add images to KDE Connect .Appx build
Mon, Aug 19, 8:28 PM
brute4s99 closed D23209: add images to KDE Connect .Appx build.
Mon, Aug 19, 8:28 PM · Craft, KDE Connect
brute4s99 added a comment to D23209: add images to KDE Connect .Appx build.

landing it!

a duckling

Mon, Aug 19, 8:28 PM · Craft, KDE Connect
brute4s99 updated the diff for D23209: add images to KDE Connect .Appx build.
Mon, Aug 19, 8:09 PM · Craft, KDE Connect
brute4s99 committed R224:607d643d8c1e: add `windowIcon` to daemon for better support on Windows (authored by brute4s99).
add `windowIcon` to daemon for better support on Windows
Mon, Aug 19, 6:59 PM

Sun, Aug 18

brute4s99 committed R224:5b13f28912a9: re-add support for keyboard in Windows build (authored by brute4s99).
re-add support for keyboard in Windows build
Sun, Aug 18, 7:58 PM
brute4s99 updated the diff for D23196: have 1024x1024 app icon as fallback icon in Snore.
Sun, Aug 18, 7:14 PM · Frameworks
brute4s99 updated the diff for D23196: have 1024x1024 app icon as fallback icon in Snore.
Sun, Aug 18, 7:06 PM · Frameworks

Sat, Aug 17

brute4s99 committed R224:80608893656a: Fix presenter plugin for Win32 (authored by brute4s99).
Fix presenter plugin for Win32
Sat, Aug 17, 11:42 PM
brute4s99 committed R224:d35b845c0fa1: use Qt in place of Unix-only symbols in kio/kdeconnect (authored by brute4s99).
use Qt in place of Unix-only symbols in kio/kdeconnect
Sat, Aug 17, 10:12 PM

Fri, Aug 16

brute4s99 updated subscribers of T11398: Publish KDE Connect to the Windows Store.
Fri, Aug 16, 10:47 PM · KDE Connect
brute4s99 updated the task description for T11398: Publish KDE Connect to the Windows Store.
Fri, Aug 16, 10:47 PM · KDE Connect
brute4s99 updated subscribers of T11398: Publish KDE Connect to the Windows Store.

so we have Jenkins ready to build .Appx packages for us now, thanks to @bcooksley : https://invent.kde.org/sysadmin/binary-factory-tooling/commit/aeddc47b0ca4dcdef64044226b99d9b78a0156a7

Fri, Aug 16, 10:46 PM · KDE Connect
brute4s99 added a reviewer for D23196: have 1024x1024 app icon as fallback icon in Snore: broulik.
Fri, Aug 16, 10:05 PM · Frameworks
brute4s99 updated the diff for D23196: have 1024x1024 app icon as fallback icon in Snore.

updated

Fri, Aug 16, 10:04 PM · Frameworks
brute4s99 added inline comments to D23196: have 1024x1024 app icon as fallback icon in Snore.
Fri, Aug 16, 10:03 PM · Frameworks
brute4s99 requested review of D23209: add images to KDE Connect .Appx build.
Fri, Aug 16, 9:42 PM · Craft, KDE Connect
brute4s99 requested review of D23196: have 1024x1024 app icon as fallback icon in Snore.
Fri, Aug 16, 2:43 AM · Frameworks
brute4s99 updated the diff for D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.

took inspiration from NotifyByAndroid. Now I can see all types of notifications perfectly well!

Fri, Aug 16, 2:35 AM · Frameworks

Wed, Aug 14

brute4s99 added a comment to D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.

the duplicate notification always has id= -1, so I think it's more an issue of KNotifications, I think

Wed, Aug 14, 8:09 AM · Frameworks

Tue, Aug 13

brute4s99 requested review of D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.
Tue, Aug 13, 6:47 PM · Frameworks
brute4s99 triaged T11398: Publish KDE Connect to the Windows Store as Normal priority.
Tue, Aug 13, 5:25 PM · KDE Connect
brute4s99 added a comment to D21661: add snoretoast backend for KNotifications on Windows.

It looks like this made D-Bus and Phonon hard required dependencies on Android again!?

Tue, Aug 13, 10:18 AM · Frameworks
brute4s99 committed R289:a56a379097d5: really fix Android build (authored by brute4s99).
really fix Android build
Tue, Aug 13, 10:07 AM

Mon, Aug 12

brute4s99 added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

The Qt documentation says "Warning: Because of differences in the platforms supported by Qt, the semantics of ReadUser, WriteUser and ExeUser are platform-dependent: On Unix, the rights of the owner of the file are returned and on Windows the rights of the current user are returned. "

Mon, Aug 12, 9:35 AM · Frameworks, Dolphin

Sun, Aug 11

brute4s99 committed R289:c38411bd8fc7: fix android build (authored by brute4s99).
fix android build
Sun, Aug 11, 8:37 PM
brute4s99 committed R289:a5e79e704763: fix build (authored by brute4s99).
fix build
Sun, Aug 11, 8:27 PM
brute4s99 closed D21661: add snoretoast backend for KNotifications on Windows.
Sun, Aug 11, 7:30 PM · Frameworks
brute4s99 committed R289:d00612351778: add snoretoast backend for KNotifications on Windows (authored by brute4s99).
add snoretoast backend for KNotifications on Windows
Sun, Aug 11, 7:30 PM
brute4s99 updated the diff for D21661: add snoretoast backend for KNotifications on Windows.

removed duplication

Sun, Aug 11, 5:56 PM · Frameworks
brute4s99 updated the diff for D21661: add snoretoast backend for KNotifications on Windows.

rebased.

Sun, Aug 11, 3:28 PM · Frameworks
brute4s99 updated the diff for D21661: add snoretoast backend for KNotifications on Windows.

landing this one. 🎉

Sun, Aug 11, 3:14 PM · Frameworks
brute4s99 added a comment to D21661: add snoretoast backend for KNotifications on Windows.

done.

Sun, Aug 11, 3:14 PM · Frameworks
brute4s99 added a comment to D21661: add snoretoast backend for KNotifications on Windows.

waiting for some green light(s) for now...

Sun, Aug 11, 1:26 PM · Frameworks
brute4s99 updated the diff for D21661: add snoretoast backend for KNotifications on Windows.
  • removed the duplicate remover.
Sun, Aug 11, 1:23 PM · Frameworks
brute4s99 added a comment to D21661: add snoretoast backend for KNotifications on Windows.

landing it...

Sun, Aug 11, 1:20 PM · Frameworks

Thu, Aug 1

brute4s99 committed R224:ccc8bb8a0e60: Split config issue fix for Win32 build (authored by brute4s99).
Split config issue fix for Win32 build
Thu, Aug 1, 2:02 PM

Sat, Jul 27

brute4s99 committed R224:ccb9c1fd48f3: put win check within sfos (authored by brute4s99).
put win check within sfos
Sat, Jul 27, 9:06 PM
brute4s99 added inline comments to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.
Sat, Jul 27, 8:03 PM · Frameworks, Dolphin
brute4s99 added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sat, Jul 27, 9:41 AM · Frameworks

Fri, Jul 26

brute4s99 added a comment to D21661: add snoretoast backend for KNotifications on Windows.

Please do a last minute review, I believe this patch is ready to merge now. 🎉

Fri, Jul 26, 6:16 PM · Frameworks

Wed, Jul 24

brute4s99 added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

Looks good.
Why not the first time 😊

Wed, Jul 24, 9:50 PM · Frameworks, Dolphin
brute4s99 requested review of D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.
Wed, Jul 24, 9:27 PM · Frameworks, Dolphin

Tue, Jul 23

brute4s99 closed D22686: add kpeoplevcard to kdeconnect-kde.
Tue, Jul 23, 4:15 PM
brute4s99 committed R877:367549ebbda1: add kpeoplevcard to kdeconnect-kde (authored by brute4s99).
add kpeoplevcard to kdeconnect-kde
Tue, Jul 23, 4:15 PM

Jul 23 2019

brute4s99 requested review of D22686: add kpeoplevcard to kdeconnect-kde.
Jul 23 2019, 2:36 PM
brute4s99 updated the diff for D22554: Finer No-Dbus on Windows.

let's put a pin in this for a while until I get a better solution for DBus on Windows

Jul 23 2019, 9:49 AM · Frameworks
brute4s99 added a comment to R289:be466180db21: remove dbus for windows build and change audio dep logic.

got it 😥🔫

Jul 23 2019, 9:43 AM
brute4s99 added a comment to T11275: Compilation errors on Windows CI related to KStatusNotifierItem.

nvm, I'll try to find a better solution instead.

Jul 23 2019, 9:42 AM · Sysadmin
brute4s99 added a comment to D21660: remove dbus for windows build and change audio dep logic.

sorry about that. I'll find a better solution that doesn't break builds 🙈

Jul 23 2019, 9:41 AM · Frameworks
brute4s99 added a comment to T11275: Compilation errors on Windows CI related to KStatusNotifierItem.

For KStatusNotifierItem, KDE Connect uses QSystemTrayIcon on windows. See https://github.com/KDE/kdeconnect-kde/blob/master/indicator/main.cpp#L169

Jul 23 2019, 9:34 AM · Sysadmin
brute4s99 added a comment to R289:be466180db21: remove dbus for windows build and change audio dep logic.

?

Jul 23 2019, 9:29 AM
brute4s99 committed R289:c3fabfaef786: move find_package calls to root and add win32_defaults.notifyrc (authored by brute4s99).
move find_package calls to root and add win32_defaults.notifyrc
Jul 23 2019, 9:12 AM