Will be good see how it looks in dark theme, especially dark pictures.

That's for right click action menu, i notice that after upgrading to 19.04, since i'm not using Baloo tags action does nothing, patch looks good it should work.

In D19947#438052, @apol wrote:

In D19947#438003, @davidedmundson wrote:

It's subtle but I quite like it.

\o/

It feels a bit inconsistent given it affects plasmoids on keyshortcut, but not on click.

Agreed, but here the bug is that on click it doesn't happen I'd say, and we'll have to go over all plasmoids I'm afraid, because they all implement a MouseArea to deal with triggering.
I was looking into introducing context menu on pressAndHold and there's a similar problem.

Ping this looks sane, anyone ?

What happen to this? Put it to 19.04 for testing.

Video or screenshot will be helpful.

Test now, i can't reproduce behavior mentioned above.

It's good to +1

Ok, so @trmdi you can apply exactly David suggest and discard D18804, i've test it and it works. Push it in 5.15 not 5.16 that's bug fix not feature. 5.12 can be also interested path as LTS version.

@davidedmundson it works. I really don't know that sharing model between contexts cause a such behavior. It's caused by some ref counting ? Did you know why, it's internal Qt issue that we can fix or it's expected ?

I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in.

Did you understand why it happen?

I notice it, because i use SQLite backend, LGTM to me +1

In D18466#402362, @niccolove wrote:

This solution is Qt <5.12 friendly

Let's make public slot approach.

VersionControlObserver is exported class changing its constructor type parameter can brake ABI, but does it user of ? In other hand addition of public slot is ABI comfortable, so another approach can be better solution.

+1

So just don't call slotFilePrint connect loadCompleted to slotFilePrint. When openDocumentInternal downloads the document it fires signal of finish, just connect to slot of opened it.

I investigate on testing this patch, it does not fix systray issue, to discard it?

In D18466#399471, @danders wrote:

Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead.
And to be safe, we also need to handle loadCanceled().

@alexeymin, can you try this patch as well, it's pretty annoying to have 5+ versioned tabs, error in one to be shown in others.

In D18289#397527, @alexeymin wrote:

branches is a QStringList, so, we could also check that currentBranchIndex < branches.size() in condition, if it is all about bounds checking.

+1

ping, issue is real and annoying.

ping

+1 it looks good to me.

In D17640#393688, @elvisangelaccio wrote:

Sorry but I can't reproduce the bug you put in the commit message.

I tried to do a git checkout on a dirty repo, but the error message only shows up in the versioned tab (not in all tabs).

Searchbar propagates events even it's not visible, you can add check for visibility in focusin event.

Now in multi-thread environment will have problems especially on actualTheme(), no?

If you mean in 4.9 - no, i just not realize that.

Apparently it has a problem, if 2 or more versioned tabs are open (in distinct git directories) switching between does not update status/actions. It looks like in dolphin-plugin is used static object as well. So after all we don't want error in one tab to be multiplied to all opened, i've seen it often, since i'm using plugin daily, so easy fix is to update directory on tab activated, since observer has only private slots i'm using old syntax did you have better idea?

I want to have this in 18.12.1, i really not prefer to have custom changes against upstream.

The problem is too specific, it happen when dpms is activated after dimm display is setted screen to 0, if dimm option is not checked it works correct to me.

Video can't handle it. (i've think about screencast but can be recorded by a phone)

Does someone test it, @thsurrel ?

Ping, we can remove parent but i don't see advantage of this.

Ping, now on Alt+1 or right click ->project -> lookup does not show correct tab