- User Since
- May 17 2018, 2:09 PM (40 w, 17 h)
Fri, Feb 1
Fri, Jan 25
Remove the timer
Focus on load
Improvements as per #hein comments
Keep resizing if the task being closed with the middle button is
the last one in the task manager. That matches Firefox behavior.
I would vote against dimming. A common use case for having splitviews in a console is to monitor several terminals at the same time. You wouldn't want dimming to reduce the visibility in the other not-focused terminals in such a case.
Thu, Jan 24
Let's be as smart as Firefox!
Thanks for the review
Jan 21 2019
Jan 17 2019
Jan 16 2019
Display the unmountAll button only when there are some MOUNTED devices.
There is a regression, I did not notice at first. By storing the connectedRemovables and not the mountedRemovables, the unmountAll button will appear even if nothing is mounted. That's not good.
I have to update a list in the onMountedChanged slot as I was doing before, or do you see a better way ?
Trying to improve based on broulik comments.
Thank you very much for the review!
A last minute review in case this can get into 5.15 ? Please :)
Jan 11 2019
Agreed, the code around the lastUsedView has changed quite a bit in the terminatorStyleTabs branch, let's not duplicate the work. Except if terminatorStyleTabs is not ready for 19.04 ...
What about merging this with the lastUsedView feature ?
Pressing Ctrl-Tab would open show the switcher ordered according to tabHistory. The tabs would be switched "live" while iterating through the list. The switcher would close when releasing the Ctrl key.
What do you think ?
Jan 9 2019
This patch has to be reworked to implement Nate's idea, I am not totally sure how that will work though. I will need to modify KIO for that as well.
Jan 8 2019
Thanks for this one too !
I forgot to mention this third patch: D16170 :)
Yes, I will have at least one other commit to push after this one. So I will wait.
In the meantime, I have updated the diff in phabricator the wrong way, and your work does not appear anymore. Can you revert what I did ? Sorry again.
Ok, not with arc diff --update, apparently. I am really sorry, can someone with better knowlege fix the mess I am making ?
Fix default focused terminalDisplay when switching tab
I made a correction that got commited in D18094.
How do you use arc so that it updates here instead ?
I'm on strike until my device notifier patches are reviewed ;)
This patch fixes a regression that appeared in this cycle, that would be good if someone could review it so that we don't ship it with 5.15.
Jan 3 2019
One consequence of this work (which is great, all my thumbs up - that's about 2) is that the recently added feature allowing to switch between tabs in chronological order (with Ctrl-Tab) seems a bit outdated already.
What do you think of changing its behavior from being a 'tab history' to being a 'terminal history', hitting Ctrl-Tab would switch between terminals whether they are in different tabs or in different split views within the same tab ?
Jan 2 2019
Sorry I did not have any time to test this, but I am really interested to see the result. I am back from my holidays now, I should be able to test tomorrow.
Dec 30 2018
Fix requested by hindenburg
Thank you very much for the review
Dec 13 2018
Use this function instead of comparing the url scheme with tar, zip, ...
Two other things:
- there is already a shortcut to open a new tab (Ctrl-Shift-t), but nothing to change the profile of the current terminal. With this patch you can do everything from the keyboard.
- as suggested in FEATURE: 319926, some users (me included) would like to be able to quickly switch temporarily to another profile and back.
Dec 12 2018
Dec 10 2018
Neither helped... The problem may not be in plasma.
Dec 8 2018
Dec 7 2018
No more magic :(
I made another patch that fixes the alignment D17420
You need to configure the plasmoid and select to show "All devices". It's showing removable devices only by default (which sounds pretty sane!).
Can you develop why ? Is it because of the added code ?
From a usability point of view, does it not make sense to disable something that is not possible ?
Thanks for the tip, I will try to use gammaray.
This bug is bothering me too and I haven't found a fix either.
I use an external screen connected to my laptop and I turn my laptop screen off by setting its brightness to 0. Then whenever I go away for a moment and the screen is turned off because energy saving kicks in, when I get back to work the laptop screen brightness gets to 100%. Particularly not nice when it's night time ...
Dec 6 2018
Improvements as per Nate's comments
Fix button width
Dec 5 2018
I don't really know how to test this in the embedded terminal in Kate for example. Could someone provide some guidance ?
Works great! Well done on fixing some existing bugs along the way!
Dec 3 2018
Small glitch: when we move one tab from one side of a split view to the other, the tab content is not re-drawn correctly.
Dec 1 2018
I like the goal, good luck!
I am much less knowledgeable in konsole than you, so I'd recommend to wait for someone else's approval too.
Nov 30 2018
Fix deleted empty line.
Well done on fixing the crash !
I like the feature but it crashes when I do the following:
- open left/right split view
- close the right side with Ctrl-D
That would also fix https://bugs.kde.org/show_bug.cgi?id=225202 I suppose ?
That happens only with size sorting because we modify the "size" of folders by setting the number of items in them. That triggers a re-sort once this is done, that in turns call itemsMoved and triggers the bug.
See the special case in KFileItemModelRolesUpdater::applySortRole for details.
Nov 29 2018
I use it differently then ! :)
Yes, indeed. But it is just a proposal.
This patch mimics what is done for desktops: you can move a window to a desktop or to all of them. You lose the ability to add a window to an activity, but do we have a strong use case for that ? I personally always want to _move_ a window to another activity when I use this menu.