thsurrel (Thomas Surrel)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 17 2018, 2:09 PM (29 w, 5 d)
Availability
Available

Recent Activity

Yesterday

thsurrel added a reviewer for D17471: Fix condition to redraw search result line: Konsole.
Mon, Dec 10, 9:56 AM · Konsole
thsurrel requested review of D17471: Fix condition to redraw search result line.
Mon, Dec 10, 9:54 AM · Konsole
thsurrel added a comment to D16918: [dimdisplay] Do not change screen brightness on invalid values.

Neither helped... The problem may not be in plasma.

Mon, Dec 10, 8:47 AM · Plasma

Sat, Dec 8

thsurrel committed R120:2c541ac87c4d: [Device Notifier] Fix action button vertical alignment (authored by thsurrel).
[Device Notifier] Fix action button vertical alignment
Sat, Dec 8, 8:46 AM
thsurrel closed D17420: [Device Notifier] Fix action button vertical alignment.
Sat, Dec 8, 8:46 AM · Plasma

Fri, Dec 7

thsurrel updated the diff for D17420: [Device Notifier] Fix action button vertical alignment.

No more magic :(

Fri, Dec 7, 10:42 PM · Plasma
thsurrel added a comment to D17402: [Device Notifier] Disable the possibility to unmount the root partition.

I made another patch that fixes the alignment D17420

Fri, Dec 7, 10:39 PM · Plasma
thsurrel updated the test plan for D17420: [Device Notifier] Fix action button vertical alignment.
Fri, Dec 7, 10:38 PM · Plasma
thsurrel requested review of D17420: [Device Notifier] Fix action button vertical alignment.
Fri, Dec 7, 10:36 PM · Plasma
thsurrel committed R119:66e05cb9c097: [Device Automounter KCM] Improve the tree view header spacing (authored by thsurrel).
[Device Automounter KCM] Improve the tree view header spacing
Fri, Dec 7, 2:53 PM
thsurrel closed D17401: [Device Automounter KCM] Improve the tree view header spacing.
Fri, Dec 7, 2:53 PM · Plasma
thsurrel added a comment to D17402: [Device Notifier] Disable the possibility to unmount the root partition.

You need to configure the plasmoid and select to show "All devices". It's showing removable devices only by default (which sounds pretty sane!).

Fri, Dec 7, 2:51 PM · Plasma
thsurrel added a comment to D17402: [Device Notifier] Disable the possibility to unmount the root partition.

Can you develop why ? Is because of the added code ?
From a usability point of view, does it not make sense to disable something that is not possible ?

Fri, Dec 7, 1:14 PM · Plasma
thsurrel added a comment to D16913: Add the possibility to give focus to the KPluginSelector search field.

Thanks for the tip, I will try to use gammaray.

Fri, Dec 7, 1:06 PM · Frameworks
thsurrel updated the test plan for D17402: [Device Notifier] Disable the possibility to unmount the root partition.
Fri, Dec 7, 12:37 PM · Plasma
thsurrel requested review of D17402: [Device Notifier] Disable the possibility to unmount the root partition.
Fri, Dec 7, 12:36 PM · Plasma
thsurrel committed R120:ab47422c1b41: [Device Notifier] Fix transition animation (authored by thsurrel).
[Device Notifier] Fix transition animation
Fri, Dec 7, 12:21 PM
thsurrel closed D17394: [Device Notifier] Fix transition animation.
Fri, Dec 7, 12:21 PM · Plasma
thsurrel added a comment to D17394: [Device Notifier] Fix transition animation.

Is this Bug 379759?

Fri, Dec 7, 12:17 PM · Plasma
thsurrel added inline comments to D17394: [Device Notifier] Fix transition animation.
Fri, Dec 7, 11:38 AM · Plasma
thsurrel updated the test plan for D17401: [Device Automounter KCM] Improve the tree view header spacing.
Fri, Dec 7, 11:22 AM · Plasma
thsurrel requested review of D17401: [Device Automounter KCM] Improve the tree view header spacing.
Fri, Dec 7, 11:22 AM · Plasma
thsurrel added a comment to D16918: [dimdisplay] Do not change screen brightness on invalid values.

This bug is bothering me too and I haven't found a fix either.
I use an external screen connected to my laptop and I turn my laptop screen off by setting its brightness to 0. Then whenever I go away for a moment and the screen is turned off because energy saving kicks in, when I get back to work the laptop screen brightness gets to 100%. Particularly not nice when it's night time ...

Fri, Dec 7, 9:16 AM · Plasma

Thu, Dec 6

thsurrel updated the test plan for D17394: [Device Notifier] Fix transition animation.
Thu, Dec 6, 9:51 PM · Plasma
thsurrel requested review of D17394: [Device Notifier] Fix transition animation.
Thu, Dec 6, 9:50 PM · Plasma
thsurrel added inline comments to D16212: [Device Notifier] Add a button to unmount all devices.
Thu, Dec 6, 8:38 PM · Plasma
thsurrel added inline comments to D16212: [Device Notifier] Add a button to unmount all devices.
Thu, Dec 6, 8:15 PM · Plasma
thsurrel updated the diff for D16212: [Device Notifier] Add a button to unmount all devices.

Improvements as per Nate's comments

Thu, Dec 6, 8:14 PM · Plasma
thsurrel added a watcher for Konsole: thsurrel.
Thu, Dec 6, 8:45 AM
thsurrel updated the diff for D16212: [Device Notifier] Add a button to unmount all devices.

Fix button width

Thu, Dec 6, 8:39 AM · Plasma

Wed, Dec 5

thsurrel added a comment to D17374: Profile shortcuts switch profile instead of opening new tab.

I don't really know how to test this in the embedded terminal in Kate for example. Could someone provide some guidance ?

Wed, Dec 5, 10:09 PM · Konsole
thsurrel requested review of D17374: Profile shortcuts switch profile instead of opening new tab.
Wed, Dec 5, 10:08 PM · Konsole
thsurrel accepted D17267: Don't duplicate the tabs when Spliting the View.

Works great! Well done on fixing some existing bugs along the way!

Wed, Dec 5, 8:21 AM · Konsole

Mon, Dec 3

thsurrel added inline comments to D17270: [KUrlNavigator] List subdirs of a parent folder of an archive.
Mon, Dec 3, 12:53 PM · Frameworks
thsurrel added a comment to D17267: Don't duplicate the tabs when Spliting the View.

Small glitch: when we move one tab from one side of a split view to the other, the tab content is not re-drawn correctly.

Mon, Dec 3, 12:21 PM · Konsole
thsurrel added inline comments to D17267: Don't duplicate the tabs when Spliting the View.
Mon, Dec 3, 9:11 AM · Konsole

Sat, Dec 1

thsurrel accepted D17267: Don't duplicate the tabs when Spliting the View.

I like the goal, good luck!
I am much less knowledgeable in konsole than you, so I'd recommend to wait for someone else's approval too.

Sat, Dec 1, 8:29 PM · Konsole
thsurrel committed R318:e62ae08d3052: Merge remote-tracking branch 'origin/Applications/18.12' (authored by thsurrel).
Merge remote-tracking branch 'origin/Applications/18.12'
Sat, Dec 1, 8:20 PM
thsurrel committed R318:6100f66ae2ba: Fix selection when navigating back, with size sorting. (authored by thsurrel).
Fix selection when navigating back, with size sorting.
Sat, Dec 1, 8:19 PM
thsurrel closed D17042: Fix selection when navigating back, with size sorting..
Sat, Dec 1, 8:19 PM · Dolphin
thsurrel closed D17111: Do not sort twice when changing role and order at the same time.
Sat, Dec 1, 8:07 PM · Dolphin
thsurrel committed R318:b714604a6795: Do not sort twice when changing role and order at the same time (authored by thsurrel).
Do not sort twice when changing role and order at the same time
Sat, Dec 1, 8:07 PM
thsurrel committed R241:84ff71997b30: [KUrlNavigator] Fix firstChildUrl when going back from archive (authored by thsurrel).
[KUrlNavigator] Fix firstChildUrl when going back from archive
Sat, Dec 1, 8:05 PM
thsurrel closed D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive.
Sat, Dec 1, 8:05 PM · Frameworks

Fri, Nov 30

thsurrel updated the diff for D17270: [KUrlNavigator] List subdirs of a parent folder of an archive.

Fix deleted empty line.

Fri, Nov 30, 10:24 PM · Frameworks
thsurrel requested review of D17270: [KUrlNavigator] List subdirs of a parent folder of an archive.
Fri, Nov 30, 10:23 PM · Frameworks
thsurrel added a comment to D17267: Don't duplicate the tabs when Spliting the View.

Well done on fixing the crash !

Fri, Nov 30, 8:46 PM · Konsole
thsurrel added a comment to D17261: Don't duplicate the tabs when Spliting the View.

I like the feature but it crashes when I do the following:

  • open left/right split view
  • close the right side with Ctrl-D
Fri, Nov 30, 3:41 PM · Konsole
thsurrel added a comment to D17261: Don't duplicate the tabs when Spliting the View.

That would also fix https://bugs.kde.org/show_bug.cgi?id=225202 I suppose ?

Fri, Nov 30, 3:35 PM · Konsole
thsurrel added a comment to D17042: Fix selection when navigating back, with size sorting..

That happens only with size sorting because we modify the "size" of folders by setting the number of items in them. That triggers a re-sort once this is done, that it turns call itemsMoved and triggers the bug.
See the special case in KFileItemModelRolesUpdater::applySortRole for details.

Fri, Nov 30, 3:10 PM · Dolphin
thsurrel requested review of D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive.
Fri, Nov 30, 12:16 PM · Frameworks

Thu, Nov 29

thsurrel abandoned D17203: [Task Manager] Move apps to activities from the context menu.

I use it differently then ! :)

Thu, Nov 29, 4:12 PM · Plasma
thsurrel added a comment to D17203: [Task Manager] Move apps to activities from the context menu.

Yes, indeed. But it is just a proposal.
This patch mimics what is done for desktops: you can move a window to a desktop or to all of them. You lose the ability to add a window to an activity, but do we have a strong use case for that ? I personally always want to _move_ a window to another activity when I use this menu.

Thu, Nov 29, 4:01 PM · Plasma

Tue, Nov 27

thsurrel requested review of D17203: [Task Manager] Move apps to activities from the context menu.
Tue, Nov 27, 10:53 PM · Plasma

Mon, Nov 26

thsurrel updated the diff for D17111: Do not sort twice when changing role and order at the same time.

Fix docx

Mon, Nov 26, 8:36 PM · Dolphin
thsurrel updated the diff for D17111: Do not sort twice when changing role and order at the same time.

Fixes as per elvisangelaccio comments
Thanks for the review!

Mon, Nov 26, 4:46 PM · Dolphin
thsurrel added a comment to D17127: [Device Notifier] Keep the device label & icon after unmounting.

Hi @filipf, thanks for trying that out.
I realized that the problem is only present when working with master, the problem appeared with a recent commit. I updated the summary accordingly.

Mon, Nov 26, 9:01 AM · Plasma
thsurrel updated the test plan for D17127: [Device Notifier] Keep the device label & icon after unmounting.
Mon, Nov 26, 8:59 AM · Plasma

Sun, Nov 25

thsurrel added a comment to D16413: Add a keyboard shortcut to create file.

This patch (together with D16412) links the shortcut to the first entry in the Create New list, and that list can be modified by adding entries: https://j605.tk/blog/post/shorts/new-templates-in-dolphin/
It is a feature not easy to discover but it exists :) There are some bugs open to improve the situation: https://bugs.kde.org/show_bug.cgi?id=400263.

Sun, Nov 25, 9:52 PM · Dolphin
thsurrel updated the diff for D16413: Add a keyboard shortcut to create file.

Rebase

Sun, Nov 25, 2:31 PM · Dolphin
thsurrel committed R241:8100e99e1465: Add the possibility to have a keyboard shortcut to create a file (authored by thsurrel).
Add the possibility to have a keyboard shortcut to create a file
Sun, Nov 25, 2:28 PM
thsurrel closed D16412: Add the possibility to have a keyboard shortcut to create a file.
Sun, Nov 25, 2:28 PM · Frameworks
thsurrel abandoned D17063: Fix middle click on breadcrumbs, in split view.
Sun, Nov 25, 11:01 AM · Dolphin

Sat, Nov 24

thsurrel updated the diff for D17127: [Device Notifier] Keep the device label & icon after unmounting.

Fix

Sat, Nov 24, 8:43 PM · Plasma
thsurrel committed R241:fc5a98db98a8: [KUrlNavigator] Re-activate on mouse middle button click (authored by thsurrel).
[KUrlNavigator] Re-activate on mouse middle button click
Sat, Nov 24, 7:40 PM
thsurrel closed D17114: [KUrlNavigator] Re-activate on mouse middle button click.
Sat, Nov 24, 7:40 PM · Frameworks
thsurrel added a comment to D17114: [KUrlNavigator] Re-activate on mouse middle button click.

I tried that too, but it was not working for Dolphin. It did reactivate correctly the disabled split view, but the tab was not opened, I guess we were missing an event.

Sat, Nov 24, 7:38 PM · Frameworks

Fri, Nov 23

thsurrel requested review of D17127: [Device Notifier] Keep the device label & icon after unmounting.
Fri, Nov 23, 10:02 PM · Plasma
thsurrel updated the diff for D16170: [Device Notifier] Restore busy indicator.

Update the storage size every 5 seconds
Thank you for catching this one @mart !

Fri, Nov 23, 9:53 PM · Plasma
thsurrel committed R114:d6ee79f20adb: [KonsoleProfiles applet] Fix initial focus (authored by thsurrel).
[KonsoleProfiles applet] Fix initial focus
Fri, Nov 23, 8:18 PM
thsurrel closed D15963: [KonsoleProfiles applet] Fix initial focus.
Fri, Nov 23, 8:18 PM · Plasma
thsurrel committed R119:8ff87951cff8: [Window List]Fix initial focus (authored by thsurrel).
[Window List]Fix initial focus
Fri, Nov 23, 8:16 PM
thsurrel closed D16053: [Window List]Fix initial focus.
Fri, Nov 23, 8:16 PM · Plasma

Thu, Nov 22

thsurrel updated the diff for D17114: [KUrlNavigator] Re-activate on mouse middle button click.

Fix

Thu, Nov 22, 10:52 PM · Frameworks
thsurrel added a comment to D17063: Fix middle click on breadcrumbs, in split view.

I tried a different approach for this in D17114

Thu, Nov 22, 10:50 PM · Dolphin
thsurrel added reviewers for D17114: [KUrlNavigator] Re-activate on mouse middle button click: Frameworks, elvisangelaccio.
Thu, Nov 22, 10:49 PM · Frameworks
thsurrel requested review of D17114: [KUrlNavigator] Re-activate on mouse middle button click.
Thu, Nov 22, 10:46 PM · Frameworks
thsurrel requested review of D17111: Do not sort twice when changing role and order at the same time.
Thu, Nov 22, 9:30 PM · Dolphin

Tue, Nov 20

thsurrel added a comment to D17063: Fix middle click on breadcrumbs, in split view.

That sounds better. I will give that a try as soon as I have some time.

Tue, Nov 20, 10:29 PM · Dolphin
thsurrel requested review of D17063: Fix middle click on breadcrumbs, in split view.
Tue, Nov 20, 9:30 PM · Dolphin
thsurrel updated the diff for D17042: Fix selection when navigating back, with size sorting..

Fix removed empty line

Tue, Nov 20, 11:15 AM · Dolphin
thsurrel requested review of D17042: Fix selection when navigating back, with size sorting..
Tue, Nov 20, 11:14 AM · Dolphin

Mon, Nov 19

thsurrel committed R318:1340e9854875: Show the Delete context menu entry even when disabled (authored by thsurrel).
Show the Delete context menu entry even when disabled
Mon, Nov 19, 3:12 PM
thsurrel closed D17012: Show the Delete context menu entry even when disabled.
Mon, Nov 19, 3:12 PM · Dolphin
thsurrel updated the test plan for D17012: Show the Delete context menu entry even when disabled.
Mon, Nov 19, 2:57 PM · Dolphin
thsurrel updated the diff for D17012: Show the Delete context menu entry even when disabled.

Show Delete entry instead of hiding Rename

Mon, Nov 19, 2:55 PM · Dolphin
thsurrel added a comment to D17012: Show the Delete context menu entry even when disabled.

'Delete' and 'Rename' entries are in the same section, but one gets disabled when the other one is hidden. I think they should behave the same way.
But should we disable (but show) 'Delete' or hide 'Rename', I can fix the patch to go one way or the other.

Mon, Nov 19, 1:37 PM · Dolphin
thsurrel updated the diff for D17012: Show the Delete context menu entry even when disabled.

Fix

Mon, Nov 19, 1:14 PM · Dolphin
thsurrel requested review of D17012: Show the Delete context menu entry even when disabled.
Mon, Nov 19, 1:14 PM · Dolphin
thsurrel added a comment to D16170: [Device Notifier] Restore busy indicator.

Ping !
Anyone could have a look at this patch ?

Mon, Nov 19, 10:10 AM · Plasma
thsurrel added a comment to D16913: Add the possibility to give focus to the KPluginSelector search field.

Simply calling setFocus() was not working (I used this in D16914). My understanding is that the widget containing this has to be completely built before trying to set the focus, adding the timer ensures that. Correct me if this is wrong.

Mon, Nov 19, 10:05 AM · Frameworks

Sat, Nov 17

thsurrel committed R318:1f162f181c9f: Merge remote-tracking branch 'origin/Applications/18.12' (authored by thsurrel).
Merge remote-tracking branch 'origin/Applications/18.12'
Sat, Nov 17, 1:44 PM
thsurrel committed R318:e710a6431160: Do not disconnect all StorageAccess signals when unmounting (authored by thsurrel).
Do not disconnect all StorageAccess signals when unmounting
Sat, Nov 17, 1:43 PM
thsurrel closed D16857: Do not disconnect all StorageAccess signals when unmounting.
Sat, Nov 17, 1:43 PM · Dolphin

Thu, Nov 15

thsurrel requested review of D16914: [Runners KCM] Focus the search field by default.
Thu, Nov 15, 9:34 PM · Plasma
thsurrel added a dependent revision for D16913: Add the possibility to give focus to the KPluginSelector search field: D16914: [Runners KCM] Focus the search field by default.
Thu, Nov 15, 9:34 PM · Frameworks
thsurrel requested review of D16913: Add the possibility to give focus to the KPluginSelector search field.
Thu, Nov 15, 9:30 PM · Frameworks

Wed, Nov 14

thsurrel requested review of D16884: Add Ctrl-Tab to switch tabs in chronological order.
Wed, Nov 14, 9:54 PM · Konsole
thsurrel abandoned D16082: Notify headphone being plugged in on some hardware.
Wed, Nov 14, 9:46 PM · Plasma
thsurrel added a comment to D16082: Notify headphone being plugged in on some hardware.

Should I do anything special about this Diff ? Do we just keep it as it is for reference ?

Wed, Nov 14, 8:56 PM · Plasma