thsurrel (Thomas Surrel)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 17 2018, 2:09 PM (40 w, 17 h)
Availability
Available

Recent Activity

Fri, Feb 1

thsurrel added inline comments to D18438: [Task Manager] When closing apps, resize only when mouse is out..
Fri, Feb 1, 8:17 PM · Plasma

Fri, Jan 25

thsurrel updated the diff for D16913: Add the possibility to give focus to the KPluginSelector search field.

Remove the timer

Fri, Jan 25, 9:18 PM · Frameworks
thsurrel updated the diff for D16914: [Runners KCM] Focus the search field by default.

Focus on load

Fri, Jan 25, 9:18 PM · Plasma
thsurrel updated the diff for D18438: [Task Manager] When closing apps, resize only when mouse is out..

Improvements as per #hein comments
Keep resizing if the task being closed with the middle button is
the last one in the task manager. That matches Firefox behavior.

Fri, Jan 25, 9:05 PM · Plasma
thsurrel added a comment to D17643: Multiple Splits per Tab.

I dimmed just a bit to reduce brightness, text is still really readable.
Can you test to see if you like? If not I’m open for suggestions.

Fri, Jan 25, 4:22 PM · Konsole
thsurrel added a comment to D17643: Multiple Splits per Tab.

I would vote against dimming. A common use case for having splitviews in a console is to monitor several terminals at the same time. You wouldn't want dimming to reduce the visibility in the other not-focused terminals in such a case.

Fri, Jan 25, 4:08 PM · Konsole

Thu, Jan 24

thsurrel updated the diff for D18438: [Task Manager] When closing apps, resize only when mouse is out..

Let's be as smart as Firefox!
Thanks for the review

Thu, Jan 24, 3:51 PM · Plasma

Jan 21 2019

thsurrel updated the summary of D18438: [Task Manager] When closing apps, resize only when mouse is out..
Jan 21 2019, 9:28 PM · Plasma
thsurrel requested review of D18438: [Task Manager] When closing apps, resize only when mouse is out..
Jan 21 2019, 9:17 PM · Plasma

Jan 17 2019

thsurrel committed R120:81db74434cd5: [Device Notifier] Add a button to unmount all devices (authored by thsurrel).
[Device Notifier] Add a button to unmount all devices
Jan 17 2019, 12:21 PM
thsurrel closed D16212: [Device Notifier] Add a button to unmount all devices.
Jan 17 2019, 12:21 PM · Plasma

Jan 16 2019

thsurrel updated the diff for D16212: [Device Notifier] Add a button to unmount all devices.

Display the unmountAll button only when there are some MOUNTED devices.

Jan 16 2019, 3:16 PM · Plasma
thsurrel added a comment to D16212: [Device Notifier] Add a button to unmount all devices.

There is a regression, I did not notice at first. By storing the connectedRemovables and not the mountedRemovables, the unmountAll button will appear even if nothing is mounted. That's not good.
I have to update a list in the onMountedChanged slot as I was doing before, or do you see a better way ?

Jan 16 2019, 3:04 PM · Plasma
thsurrel added inline comments to D16212: [Device Notifier] Add a button to unmount all devices.
Jan 16 2019, 2:52 PM · Plasma
thsurrel added inline comments to D16212: [Device Notifier] Add a button to unmount all devices.
Jan 16 2019, 2:39 PM · Plasma
thsurrel added inline comments to D16212: [Device Notifier] Add a button to unmount all devices.
Jan 16 2019, 2:38 PM · Plasma
thsurrel updated the diff for D16212: [Device Notifier] Add a button to unmount all devices.

Trying to improve based on broulik comments.
Thank you very much for the review!

Jan 16 2019, 2:35 PM · Plasma
thsurrel added a comment to D16212: [Device Notifier] Add a button to unmount all devices.

A last minute review in case this can get into 5.15 ? Please :)

Jan 16 2019, 9:59 AM · Plasma

Jan 11 2019

thsurrel added a comment to D18154: Add a "Session Switcher" via Ctrl + Tab.

Agreed, the code around the lastUsedView has changed quite a bit in the terminatorStyleTabs branch, let's not duplicate the work. Except if terminatorStyleTabs is not ready for 19.04 ...

Jan 11 2019, 11:44 AM · Konsole
thsurrel added a comment to D18154: Add a "Session Switcher" via Ctrl + Tab.

What about merging this with the lastUsedView feature ?
Pressing Ctrl-Tab would open show the switcher ordered according to tabHistory. The tabs would be switched "live" while iterating through the list. The switcher would close when releasing the Ctrl key.
What do you think ?

Jan 11 2019, 9:34 AM · Konsole

Jan 9 2019

thsurrel added a comment to D16413: Add a keyboard shortcut to create file.

This patch has to be reworked to implement Nate's idea, I am not totally sure how that will work though. I will need to modify KIO for that as well.

Jan 9 2019, 8:30 AM · Dolphin
thsurrel committed R120:a7b2ecdb12b8: [Device Notifier] Restore busy indicator (authored by thsurrel).
[Device Notifier] Restore busy indicator
Jan 9 2019, 8:22 AM
thsurrel closed D16170: [Device Notifier] Restore busy indicator.
Jan 9 2019, 8:22 AM · Plasma

Jan 8 2019

thsurrel committed R120:d1a5507bd57a: [Device Notifier] Disable the possibility to unmount the root partition (authored by thsurrel).
[Device Notifier] Disable the possibility to unmount the root partition
Jan 8 2019, 9:41 PM
thsurrel closed D17402: [Device Notifier] Disable the possibility to unmount the root partition.
Jan 8 2019, 9:41 PM · Plasma
thsurrel committed R319:d56af026b08f: Turn tabHistory into a terminalDisplayHistory (authored by thsurrel).
Turn tabHistory into a terminalDisplayHistory
Jan 8 2019, 9:39 PM
thsurrel committed R319:7602ebc51ba5: Fix default focused terminalDisplay when switching tab (authored by thsurrel).
Fix default focused terminalDisplay when switching tab
Jan 8 2019, 9:04 PM
thsurrel added a comment to D17402: [Device Notifier] Disable the possibility to unmount the root partition.

Thanks for this one too !
I forgot to mention this third patch: D16170 :)

Jan 8 2019, 8:20 PM · Plasma
thsurrel committed R120:cb3237987b26: [Device Notifier] Keep the device label & icon after unmounting (authored by thsurrel).
[Device Notifier] Keep the device label & icon after unmounting
Jan 8 2019, 8:06 PM
thsurrel closed D17127: [Device Notifier] Keep the device label & icon after unmounting.
Jan 8 2019, 8:06 PM · Plasma
thsurrel added a comment to D17127: [Device Notifier] Keep the device label & icon after unmounting.

Thank you very much for taking a look. If you have a bit of time, I have two other patches about the device notifier that have been waiting for a while: D17402 and D16212.

Jan 8 2019, 7:08 PM · Plasma
thsurrel updated the summary of D16212: [Device Notifier] Add a button to unmount all devices.
Jan 8 2019, 7:07 PM · Plasma
thsurrel abandoned D18094: Fix default focused terminalDisplay when switching tab.
Jan 8 2019, 7:05 PM · Konsole
thsurrel added a comment to D17643: Multiple Splits per Tab.

Yes, I will have at least one other commit to push after this one. So I will wait.
In the meantime, I have updated the diff in phabricator the wrong way, and your work does not appear anymore. Can you revert what I did ? Sorry again.

Jan 8 2019, 12:47 PM · Konsole
thsurrel added a comment to D17643: Multiple Splits per Tab.

Ok, not with arc diff --update, apparently. I am really sorry, can someone with better knowlege fix the mess I am making ?

Jan 8 2019, 12:38 PM · Konsole
thsurrel updated the diff for D17643: Multiple Splits per Tab.

Fix default focused terminalDisplay when switching tab

Jan 8 2019, 12:37 PM · Konsole
thsurrel added a comment to D17643: Multiple Splits per Tab.

I made a correction that got commited in D18094.
How do you use arc so that it updates here instead ?

Jan 8 2019, 12:25 PM · Konsole
thsurrel requested review of D18094: Fix default focused terminalDisplay when switching tab.
Jan 8 2019, 12:22 PM · Konsole
thsurrel added a comment to D16913: Add the possibility to give focus to the KPluginSelector search field.

I'm on strike until my device notifier patches are reviewed ;)

Jan 8 2019, 9:23 AM · Frameworks
thsurrel added a comment to D17127: [Device Notifier] Keep the device label & icon after unmounting.

This patch fixes a regression that appeared in this cycle, that would be good if someone could review it so that we don't ship it with 5.15.

Jan 8 2019, 9:21 AM · Plasma

Jan 3 2019

thsurrel added a comment to D17643: Multiple Splits per Tab.

One consequence of this work (which is great, all my thumbs up - that's about 2) is that the recently added feature allowing to switch between tabs in chronological order (with Ctrl-Tab) seems a bit outdated already.
What do you think of changing its behavior from being a 'tab history' to being a 'terminal history', hitting Ctrl-Tab would switch between terminals whether they are in different tabs or in different split views within the same tab ?

Jan 3 2019, 3:25 PM · Konsole

Jan 2 2019

thsurrel added a comment to D17874: [dimdisplay] Effectively waits display to wake-up.

Sorry I did not have any time to test this, but I am really interested to see the result. I am back from my holidays now, I should be able to test tomorrow.

Jan 2 2019, 10:11 PM · Plasma

Dec 30 2018

thsurrel updated the diff for D17374: Profile shortcuts switch profile instead of opening new tab.

Fix requested by hindenburg
Thank you very much for the review

Dec 30 2018, 9:24 PM · Konsole

Dec 13 2018

thsurrel updated the diff for D17270: [KUrlNavigator] List subdirs of a parent folder of an archive.

Create KUrlNavigator::isInsideCompressedPath
Use this function instead of comparing the url scheme with tar, zip, ...

Dec 13 2018, 9:26 PM · Frameworks
thsurrel added a comment to D17374: Profile shortcuts switch profile instead of opening new tab.

Two other things:

  • there is already a shortcut to open a new tab (Ctrl-Shift-t), but nothing to change the profile of the current terminal. With this patch you can do everything from the keyboard.
  • as suggested in FEATURE: 319926, some users (me included) would like to be able to quickly switch temporarily to another profile and back.
Dec 13 2018, 12:54 PM · Konsole

Dec 12 2018

thsurrel updated the diff for D17374: Profile shortcuts switch profile instead of opening new tab.

Rebase

Dec 12 2018, 9:33 AM · Konsole

Dec 10 2018

thsurrel added a reviewer for D17471: Fix condition to redraw search result line: Konsole.
Dec 10 2018, 9:56 AM · Konsole
thsurrel requested review of D17471: Fix condition to redraw search result line.
Dec 10 2018, 9:54 AM · Konsole
thsurrel added a comment to D16918: [dimdisplay] Do not change screen brightness on invalid values.

Neither helped... The problem may not be in plasma.

Dec 10 2018, 8:47 AM · Plasma

Dec 8 2018

thsurrel committed R120:2c541ac87c4d: [Device Notifier] Fix action button vertical alignment (authored by thsurrel).
[Device Notifier] Fix action button vertical alignment
Dec 8 2018, 8:46 AM
thsurrel closed D17420: [Device Notifier] Fix action button vertical alignment.
Dec 8 2018, 8:46 AM · Plasma

Dec 7 2018

thsurrel updated the diff for D17420: [Device Notifier] Fix action button vertical alignment.

No more magic :(

Dec 7 2018, 10:42 PM · Plasma
thsurrel added a comment to D17402: [Device Notifier] Disable the possibility to unmount the root partition.

I made another patch that fixes the alignment D17420

Dec 7 2018, 10:39 PM · Plasma
thsurrel updated the test plan for D17420: [Device Notifier] Fix action button vertical alignment.
Dec 7 2018, 10:38 PM · Plasma
thsurrel requested review of D17420: [Device Notifier] Fix action button vertical alignment.
Dec 7 2018, 10:36 PM · Plasma
thsurrel committed R119:66e05cb9c097: [Device Automounter KCM] Improve the tree view header spacing (authored by thsurrel).
[Device Automounter KCM] Improve the tree view header spacing
Dec 7 2018, 2:53 PM
thsurrel closed D17401: [Device Automounter KCM] Improve the tree view header spacing.
Dec 7 2018, 2:53 PM · Plasma
thsurrel added a comment to D17402: [Device Notifier] Disable the possibility to unmount the root partition.

You need to configure the plasmoid and select to show "All devices". It's showing removable devices only by default (which sounds pretty sane!).

Dec 7 2018, 2:51 PM · Plasma
thsurrel added a comment to D17402: [Device Notifier] Disable the possibility to unmount the root partition.

Can you develop why ? Is it because of the added code ?
From a usability point of view, does it not make sense to disable something that is not possible ?

Dec 7 2018, 1:14 PM · Plasma
thsurrel added a comment to D16913: Add the possibility to give focus to the KPluginSelector search field.

Thanks for the tip, I will try to use gammaray.

Dec 7 2018, 1:06 PM · Frameworks
thsurrel updated the test plan for D17402: [Device Notifier] Disable the possibility to unmount the root partition.
Dec 7 2018, 12:37 PM · Plasma
thsurrel requested review of D17402: [Device Notifier] Disable the possibility to unmount the root partition.
Dec 7 2018, 12:36 PM · Plasma
thsurrel committed R120:ab47422c1b41: [Device Notifier] Fix transition animation (authored by thsurrel).
[Device Notifier] Fix transition animation
Dec 7 2018, 12:21 PM
thsurrel closed D17394: [Device Notifier] Fix transition animation.
Dec 7 2018, 12:21 PM · Plasma
thsurrel added a comment to D17394: [Device Notifier] Fix transition animation.

Is this Bug 379759?

Dec 7 2018, 12:17 PM · Plasma
thsurrel added inline comments to D17394: [Device Notifier] Fix transition animation.
Dec 7 2018, 11:38 AM · Plasma
thsurrel updated the test plan for D17401: [Device Automounter KCM] Improve the tree view header spacing.
Dec 7 2018, 11:22 AM · Plasma
thsurrel requested review of D17401: [Device Automounter KCM] Improve the tree view header spacing.
Dec 7 2018, 11:22 AM · Plasma
thsurrel added a comment to D16918: [dimdisplay] Do not change screen brightness on invalid values.

This bug is bothering me too and I haven't found a fix either.
I use an external screen connected to my laptop and I turn my laptop screen off by setting its brightness to 0. Then whenever I go away for a moment and the screen is turned off because energy saving kicks in, when I get back to work the laptop screen brightness gets to 100%. Particularly not nice when it's night time ...

Dec 7 2018, 9:16 AM · Plasma

Dec 6 2018

thsurrel updated the test plan for D17394: [Device Notifier] Fix transition animation.
Dec 6 2018, 9:51 PM · Plasma
thsurrel requested review of D17394: [Device Notifier] Fix transition animation.
Dec 6 2018, 9:50 PM · Plasma
thsurrel added inline comments to D16212: [Device Notifier] Add a button to unmount all devices.
Dec 6 2018, 8:38 PM · Plasma
thsurrel added inline comments to D16212: [Device Notifier] Add a button to unmount all devices.
Dec 6 2018, 8:15 PM · Plasma
thsurrel updated the diff for D16212: [Device Notifier] Add a button to unmount all devices.

Improvements as per Nate's comments

Dec 6 2018, 8:14 PM · Plasma
thsurrel added a watcher for Konsole: thsurrel.
Dec 6 2018, 8:45 AM
thsurrel updated the diff for D16212: [Device Notifier] Add a button to unmount all devices.

Fix button width

Dec 6 2018, 8:39 AM · Plasma

Dec 5 2018

thsurrel added a comment to D17374: Profile shortcuts switch profile instead of opening new tab.

I don't really know how to test this in the embedded terminal in Kate for example. Could someone provide some guidance ?

Dec 5 2018, 10:09 PM · Konsole
thsurrel requested review of D17374: Profile shortcuts switch profile instead of opening new tab.
Dec 5 2018, 10:08 PM · Konsole
thsurrel accepted D17267: Don't duplicate the tabs when Spliting the View.

Works great! Well done on fixing some existing bugs along the way!

Dec 5 2018, 8:21 AM · Konsole

Dec 3 2018

thsurrel added inline comments to D17270: [KUrlNavigator] List subdirs of a parent folder of an archive.
Dec 3 2018, 12:53 PM · Frameworks
thsurrel added a comment to D17267: Don't duplicate the tabs when Spliting the View.

Small glitch: when we move one tab from one side of a split view to the other, the tab content is not re-drawn correctly.

Dec 3 2018, 12:21 PM · Konsole
thsurrel added inline comments to D17267: Don't duplicate the tabs when Spliting the View.
Dec 3 2018, 9:11 AM · Konsole

Dec 1 2018

thsurrel accepted D17267: Don't duplicate the tabs when Spliting the View.

I like the goal, good luck!
I am much less knowledgeable in konsole than you, so I'd recommend to wait for someone else's approval too.

Dec 1 2018, 8:29 PM · Konsole
thsurrel committed R318:e62ae08d3052: Merge remote-tracking branch 'origin/Applications/18.12' (authored by thsurrel).
Merge remote-tracking branch 'origin/Applications/18.12'
Dec 1 2018, 8:20 PM
thsurrel committed R318:6100f66ae2ba: Fix selection when navigating back, with size sorting. (authored by thsurrel).
Fix selection when navigating back, with size sorting.
Dec 1 2018, 8:19 PM
thsurrel closed D17042: Fix selection when navigating back, with size sorting..
Dec 1 2018, 8:19 PM · Dolphin
thsurrel closed D17111: Do not sort twice when changing role and order at the same time.
Dec 1 2018, 8:07 PM · Dolphin
thsurrel committed R318:b714604a6795: Do not sort twice when changing role and order at the same time (authored by thsurrel).
Do not sort twice when changing role and order at the same time
Dec 1 2018, 8:07 PM
thsurrel committed R241:84ff71997b30: [KUrlNavigator] Fix firstChildUrl when going back from archive (authored by thsurrel).
[KUrlNavigator] Fix firstChildUrl when going back from archive
Dec 1 2018, 8:05 PM
thsurrel closed D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive.
Dec 1 2018, 8:05 PM · Frameworks

Nov 30 2018

thsurrel updated the diff for D17270: [KUrlNavigator] List subdirs of a parent folder of an archive.

Fix deleted empty line.

Nov 30 2018, 10:24 PM · Frameworks
thsurrel requested review of D17270: [KUrlNavigator] List subdirs of a parent folder of an archive.
Nov 30 2018, 10:23 PM · Frameworks
thsurrel added a comment to D17267: Don't duplicate the tabs when Spliting the View.

Well done on fixing the crash !

Nov 30 2018, 8:46 PM · Konsole
thsurrel added a comment to D17261: Don't duplicate the tabs when Spliting the View.

I like the feature but it crashes when I do the following:

  • open left/right split view
  • close the right side with Ctrl-D
Nov 30 2018, 3:41 PM · Konsole
thsurrel added a comment to D17261: Don't duplicate the tabs when Spliting the View.

That would also fix https://bugs.kde.org/show_bug.cgi?id=225202 I suppose ?

Nov 30 2018, 3:35 PM · Konsole
thsurrel added a comment to D17042: Fix selection when navigating back, with size sorting..

That happens only with size sorting because we modify the "size" of folders by setting the number of items in them. That triggers a re-sort once this is done, that in turns call itemsMoved and triggers the bug.
See the special case in KFileItemModelRolesUpdater::applySortRole for details.

Nov 30 2018, 3:10 PM · Dolphin
thsurrel requested review of D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive.
Nov 30 2018, 12:16 PM · Frameworks

Nov 29 2018

thsurrel abandoned D17203: [Task Manager] Move apps to activities from the context menu.

I use it differently then ! :)

Nov 29 2018, 4:12 PM · Plasma
thsurrel added a comment to D17203: [Task Manager] Move apps to activities from the context menu.

Yes, indeed. But it is just a proposal.
This patch mimics what is done for desktops: you can move a window to a desktop or to all of them. You lose the ability to add a window to an activity, but do we have a strong use case for that ? I personally always want to _move_ a window to another activity when I use this menu.

Nov 29 2018, 4:01 PM · Plasma

Nov 27 2018

thsurrel requested review of D17203: [Task Manager] Move apps to activities from the context menu.
Nov 27 2018, 10:53 PM · Plasma