I test to push in repo that i don't have permissions, it crash before showing dialog. Now it show it.
- Group Reviewers
- R449:9f8f6c152116: [gitpushdialog] Check GitWrapper::branches index validity
branches is a QStringList, so, we could also check that currentBranchIndex < branches.size() in condition, if it is all about bounds checking.
Anyway, the diff compiles and overall looks harmless. I'd say +1, I did not try to reproduce the crash though