[KUrlNavigatorPlacesSelector] Properly identify teardown action
Changes PlannedPublic

Authored by broulik on Jan 21 2019, 9:48 AM.


Group Reviewers

Rather than relying on the model count (which broke when we added places categories), just identify the action by the data it is given.

BUG: 403454

Test Plan
  • Hid Places panel in Dolphin and navigated around some mounts: Only one Unmount entry that came and went as it should
  • Unmount still works

Diff Detail

R241 KIO
Lint Skipped
Unit Tests Skipped
broulik created this revision.Jan 21 2019, 9:48 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 21 2019, 9:48 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jan 21 2019, 9:48 AM
broulik planned changes to this revision.Jan 21 2019, 11:56 AM

There seems to be one issue that when you open a mounted drive directly, you get an "Unmount" entry at the top.
Likely because the places are populated after the entry was created.
Perhaps the remove codepath needs to iterate all actions and check rather than assuming it's always the last place.