- User Since
- Mar 26 2017, 7:19 PM (112 w, 2 d)
Sat, May 18
Hm, looks ideologically similar to how it was done in SDL2...
I could take over this revision and update the diff as required (even without adding braces around if statements), but I guess we will need to know @bgray 's email to be able to preserve authorship.
- Wrap checkX11Capabilities() in QX11Info::isPlatformX11() check
This patch does not apply on master now, needs some changes like that:
diff --git a/krfb/mainwindow.cpp b/krfb/mainwindow.cpp index 8de7822..ad2b04c 100644 --- a/krfb/mainwindow.cpp +++ b/krfb/mainwindow.cpp @@ -34,6 +34,7 @@ #include <QVector> #include <QSet> #include <QNetworkInterface> +#include <QHostInfo>
Maybe we should land this? 😉
@pino thanks for looking at this! Fixed your comments.
- Check only for platformName and rephrase the error message.
Fri, May 17
Wed, May 1
I could test with hidpi screens, but I need to understand what was the problem and how is it fixed.
Apr 5 2019
Mar 13 2019
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Using frame buffer device: "/dev/fb0" Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Failed to open frame buffer device: "/dev/fb0" through logind, trying without Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bits Per Pixel: 24 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Buffer Length: 6266880 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bytes Per Line: 3264 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Length: 0 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Length: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Length: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Length: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Offset: 0 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Offset: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Offset: 16 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Offset: 0 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Framebuffer Format is RGB888 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_core: Compositing forced to QPainter mode by environment variable
Mar 1 2019
Feb 21 2019
Feb 11 2019
Feb 9 2019
I tested, compiles and works, does not open any new windows for me, just focuses address input (I don't have any connections configured). Looks harmless overall, +1
$ arc patch D17327 INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D17327. Checking patch a/mainwindow.cpp => b/mainwindow.cpp... error: a/mainwindow.cpp: does not exist in index
Is it because process.h exists somewhere else?
Feb 2 2019
Jan 30 2019
Jan 28 2019
I can reproduce an issue. Without patch, VCS error generated in one tab is displayed in all versioned tabs (but not in normal unversioned tabs). Also strangely error is multiplied only on the first occurence, if after first appearance of error I close all error messages in all tabs, and trigger error again, it only appears in current tab, and not in any other.
Jan 21 2019
branches is a QStringList, so, we could also check that currentBranchIndex < branches.size() in condition, if it is all about bounds checking.
Anyway, the diff compiles and overall looks harmless. I'd say +1, I did not try to reproduce the crash though
Jan 16 2019
Jan 15 2019
To be precise, passwords are not stored as plain text, scrambled using KStringHandler::obscure(). But this is totally insecure anyway, is a wording like this OK?
- Add a warning about insecure storage in config
Jan 11 2019
Jan 7 2019
Dec 21 2018
I tested this, it indeed fixes 390225
Withoug this patch, generated pkgconfig file was:
Dec 18 2018
Probably because it is constructed globally before QCoreApplication / before translations were set up, or something like that
Dec 17 2018
Works here with 2 monitors like this, tested all modes, seems OK.
Dec 16 2018
I tested on current master it and it compiles and works; in several capture modes, but only on a single monitor (3840x2160). I can test later (on monday) with dual monitor setup.
Dec 2 2018
same, Xiaomi Redmi Note 4X (Snapdragon) [mido] , Adreno 506, MSM8953 Snapdragon 625
Nov 7 2018
- Fix typo "in" -> "on"
Oct 19 2018
- What if in the future another, horizontal spacer component will become needed? Will you add a HorizontalSpacer.qml then? 😆 Maybe have just a Spacer with horizontal property?
- Why Rectangle, it could be just Item, it does not cause rendering (Rectangle does)
Fine, @utecht do you have a developer account to land this?
Tested, works fine otherwise.
@pino 👌 , so what would be the preferred way to fix those small but eventually-needed changes?
Spectacle code is far from perfect, I'm suspect there are many other places to add const or fix Q_FOREACH ...
Compiles, works as described, no questions to those 3-6 lines of code modified 😉
Oct 18 2018
I'll test tomorrow, going to sleep >_<
Resolve confilcts between <<<<<<< and >>>>>>> in several places?
Pretty sure this won't compile 😆
Oct 13 2018
D10099 Use single number as filename for screenshot with empty filename template
What happens if user deletes filename template in Spectacle settings? Does new token help?
Oct 12 2018
Original source. I also slightly changed formatting and added const keyword where found possible.
Oct 11 2018
We (me) could take over this patch, if original author is no longer available 😕
Oct 9 2018
Probably this commit could remove dependency on QtXml (I'm not sure, QtDbus probably depends on QtXml and QtDbus was removed)
If it fixes build error .../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory then fine...
Oct 3 2018
Sep 22 2018
How can I reproduce broken build? Any test plan?
Maybe add it to .pro file too then?
Sep 20 2018
Why isn't repository for this review set? Which repo should it be?
Aug 25 2018
Looks harmless and correct
Aug 2 2018
From all of my installed build tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1 it selects _default_sdk as 19.1.0, is it fine? 😄
I mean, which one should be used ideally?
Jul 27 2018
But Currently, libcanberra is tested on Linux only. 😢 Plasma-pa and plasma-whatever can use anything and be Linux-centric, KNotifications is a framework, isn't it?
++vote for QtMultimedia option...
Jul 16 2018
Don't know how much offtopic will be what I'm going to say, but I recently ran into an issue while packaging QQC2 application in flatpak with org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system, but under flatpak it failed to start with the following message: QWidget: Cannot create a QWidget without QApplication. Of course, I had only QGuiApplication. But I wasn't using widgets! The only class from QtWidgets was QSystemTrayIcon for a nice integration with desktop. My guess was that was caused by platform style used in flatpak's KDE runtime may use widgets. But this was unexpected, without flatpak all was working. In the end I was forced to use QApplication, and visually saw the style used was ogr.kde.desktop.
Jul 6 2018
This is probably for BUG: 396214 ?
BUG: 396214 or better BUG: 364746 ?
Jun 6 2018
May 31 2018
May 30 2018
How exactly I can test if something works? And what are the requirements? PipeWire? Something else?
Or is this only for code review for now?
http://doc.qt.io/qt-5/deployment-android.html at the bottom of the page there is an example of usage scenario for qmake project:
Compiles, works. Tested over network from another PC, IPv4. Which VNC client supports IPv6..?