- User Since
- Mar 26 2017, 7:19 PM (137 w, 3 d)
Thu, Oct 24
Oct 4 2019
Oct 2 2019
Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our main documentation page https://api.kde.org/frameworks/index.html . If it is really Tier 3, then maybe it does not even make sense to make IconThemes and ConfigWidgets optional?
- Bring back missing KF5_DEP_VERSION
Phabricator, you're drunk, it is not pushed to master
Second error is revealed after the first one is fixed:
Scanning dependencies of target qqc2desktopstyleplugin [ 40%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin_autogen/mocs_compilation.cpp.o [ 60%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin.cpp.o [ 80%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/kquickstyleitem.cpp.o /home/minnehanov/dev/kde/fw/qqc2-desktop-style/plugin/kquickstyleitem.cpp:54:10: fatal error: ksharedconfig.h: No such file or directory #include <ksharedconfig.h> ^~~~~~~~~~~~~~~~~ compilation terminated.
plugin/kquickstyleitem.cpp includes ksharedconfig.h but KConfig was not specified as a link dependency for this target. Previously it was found transitively via KF5ConfigWidgets I guess? Now without those optional dependencies it cannot be built. So KConfig should explicitly be specified as another required KF5 dependency, along with Kirigami.
First of all, if you try to build qqc2-desktop-style on a system with only Qt5 and other Tier 1 frameworks installed, you will get the following cmake configure log (https://paste.ubuntu.com/p/YRjSRWm9g6/):
OS Kubuntu 18.04 LTS Custom-built Qt 5.14 in ~/prefix514 Other Tier 1 Frameworks also built and installed in ~/prefix514
Oct 1 2019
Sep 30 2019
I think this diff might be the reason for hwc backend failing to build:
In file included from /home/pmos/build/src/kwin-5.16.90/plugins/platforms/hwcomposer/hwcomposer_backend.cpp:21: /home/pmos/build/src/kwin-5.16.90/plugins/platforms/hwcomposer/hwcomposer_backend.h:58:11: error: 'QSize KWin::HwcomposerOutput::pixelSize() const' marked 'override', but does not override 58 | QSize pixelSize() const override; | ^~~~~~~~~ /home/pmos/build/src/kwin-5.16.90/plugins/platforms/hwcomposer/hwcomposer_backend.h:135:10: warning: 'virtual void KWin::HwcomposerWindow::present(HWComposerNativeWindowBuffer*)' can be marked override [-Wsuggest-override]
Sep 19 2019
Sep 15 2019
All the time I was thinking that "Smart" meaning was "place windows randomly on the screen" because I couldn't guess the logic behind. Thanks to this diff I finally know what it is really doing!
Sep 13 2019
Sep 3 2019
Indeed, I could reproduce the crash again with kquitapp5 plasmashell.
Aug 28 2019
As usual, do you need help testing this on amdgpu? 😜
Aug 27 2019
Does hwcomposer platform also need similar change?
Aug 22 2019
I can confirm the issue that tray icons are tooooo small on 4k display
Aug 21 2019
Aug 17 2019
/home/lexx/dev/kde/kwin/plugins/platforms/x11/standalone/glxbackend.cpp: In member function ‘void KWin::GlxBackend::setVsync(bool)’: /home/lexx/dev/kde/kwin/plugins/platforms/x11/standalone/glxbackend.cpp:252:32: warning: unused parameter ‘enable’ [-Wunused-parameter] void GlxBackend::setVsync(bool enable) ~~~~~^~~~~~
Aug 12 2019
I haven't yet tested it on AMD
I could test how it works on amdgpu (RX560), if you need help with that, when it's ready to test
Aug 9 2019
I haven't tried to build this with Qt 5.13, but if you say so
Jul 24 2019
Jul 19 2019
Maybe something from these can be used to inspire:
Jul 16 2019
Jul 12 2019
Jul 11 2019
Will formatter ruin beautiful multi-line formatting into single line?
Jul 7 2019
Jun 28 2019
Jun 25 2019
Why someone would disagree :) +1 ofc
Jun 23 2019
typo in title :)
Jun 22 2019
Jun 20 2019
I have no questions to code, but.. This is a behavioral change and I think we need a mantainer's opinion here. Or at least somebody else's opinion.
Jun 19 2019
Reduce memory allocations
Jun 17 2019
Now I see, local window is scaled, remote contents are not, is that the intention of this patch?
The patch compiles and works.
I've built master branch and with this patch, and run both with QT_SCALE_FACTOR=2. During connection I chose maximum quality option (local network). The results look identical to me:
master on the left, patched D20790 on the right
This adds new warnings:
../vnc/vncclientthread.h: In constructor ‘VncClientThread::VncClientThread(QObject*)’: ../vnc/vncclientthread.h:191:19: warning: ‘VncClientThread::m_stopped’ will be initialized after [-Wreorder] volatile bool m_stopped; ^~~~~~~~~ ../vnc/vncclientthread.h:184:11: warning: ‘qreal VncClientThread::m_devicePixelRatio’ [-Wreorder] qreal m_devicePixelRatio; ^~~~~~~~~~~~~~~~~~ ../vnc/vncclientthread.cpp:323:1: warning: when initialized here [-Wreorder] VncClientThread::VncClientThread(QObject *parent)
member declaration order in .h-file is mismatches initialization order in constructor.
Jun 16 2019
Simplify code a bit
How about more complex logic then? Display hostname only if it is not empty string.
$ arc patch D20790 [INFO] Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D20790.
Jun 14 2019
Qt build that includes commit 0c1831178540462da31fd7a4b6d2e446bc84498b
Jun 13 2019
Jun 5 2019
This should work.
I mean, msvc detection part...
May 18 2019
Hm, looks ideologically similar to how it was done in SDL2...
I could take over this revision and update the diff as required (even without adding braces around if statements), but I guess we will need to know @bgray 's email to be able to preserve authorship.
- Wrap checkX11Capabilities() in QX11Info::isPlatformX11() check
This patch does not apply on master now, needs some changes like that:
diff --git a/krfb/mainwindow.cpp b/krfb/mainwindow.cpp index 8de7822..ad2b04c 100644 --- a/krfb/mainwindow.cpp +++ b/krfb/mainwindow.cpp @@ -34,6 +34,7 @@ #include <QVector> #include <QSet> #include <QNetworkInterface> +#include <QHostInfo>
Maybe we should land this? 😉
@pino thanks for looking at this! Fixed your comments.
- Check only for platformName and rephrase the error message.
May 17 2019
May 1 2019
I could test with hidpi screens, but I need to understand what was the problem and how is it fixed.
Apr 5 2019
Mar 13 2019
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Using frame buffer device: "/dev/fb0" Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Failed to open frame buffer device: "/dev/fb0" through logind, trying without Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bits Per Pixel: 24 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Buffer Length: 6266880 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bytes Per Line: 3264 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Length: 0 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Length: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Length: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Length: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Offset: 0 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Offset: 8 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Offset: 16 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Offset: 0 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Framebuffer Format is RGB888 Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_core: Compositing forced to QPainter mode by environment variable