alexeymin (Alexey Min)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 26 2017, 7:19 PM (137 w, 3 d)
Availability
Available

Recent Activity

Thu, Oct 24

alexeymin committed R51:d05d0b19e9d6: Fix build with Qt 5.14 (authored by alexeymin).
Fix build with Qt 5.14
Thu, Oct 24, 1:18 PM
alexeymin closed D24914: Fix build with Qt 5.14.
Thu, Oct 24, 1:18 PM · KDevelop
alexeymin requested review of D24914: Fix build with Qt 5.14.
Thu, Oct 24, 11:38 AM · KDevelop

Oct 4 2019

alexeymin closed D24363: Fix several build system errors.
Oct 4 2019, 10:53 AM · Plasma
alexeymin committed R858:731b85008c21: Fix several build system errors (authored by alexeymin).
Fix several build system errors
Oct 4 2019, 10:53 AM

Oct 2 2019

alexeymin added a comment to D24363: Fix several build system errors.

Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our main documentation page https://api.kde.org/frameworks/index.html . If it is really Tier 3, then maybe it does not even make sense to make IconThemes and ConfigWidgets optional?

Oct 2 2019, 11:31 PM · Plasma
alexeymin updated the diff for D24363: Fix several build system errors.
  • Bring back missing KF5_DEP_VERSION
Oct 2 2019, 11:27 PM · Plasma
alexeymin reopened D24363: Fix several build system errors.

Phabricator, you're drunk, it is not pushed to master

Oct 2 2019, 5:25 PM · Plasma
alexeymin committed R858:3969c28b7290: qqc2-desktop-style: Fix several builsystem errors (authored by alexeymin).
qqc2-desktop-style: Fix several builsystem errors
Oct 2 2019, 5:24 PM
alexeymin retitled D24363: Fix several build system errors from Fix several builsystem errors to Fix several build system errors.
Oct 2 2019, 1:59 PM · Plasma
alexeymin updated the summary of D24363: Fix several build system errors.
Oct 2 2019, 1:58 PM · Plasma
alexeymin added reviewers for D24363: Fix several build system errors: mart, Plasma, dfaure.
Oct 2 2019, 1:54 PM · Plasma
alexeymin added a comment to D24363: Fix several build system errors.

Second error is revealed after the first one is fixed:

Scanning dependencies of target qqc2desktopstyleplugin
[ 40%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin_autogen/mocs_compilation.cpp.o
[ 60%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin.cpp.o
[ 80%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/kquickstyleitem.cpp.o
/home/minnehanov/dev/kde/fw/qqc2-desktop-style/plugin/kquickstyleitem.cpp:54:10: fatal error: ksharedconfig.h: No such file or directory
 #include <ksharedconfig.h>
          ^~~~~~~~~~~~~~~~~
compilation terminated.

plugin/kquickstyleitem.cpp includes ksharedconfig.h but KConfig was not specified as a link dependency for this target. Previously it was found transitively via KF5ConfigWidgets I guess? Now without those optional dependencies it cannot be built. So KConfig should explicitly be specified as another required KF5 dependency, along with Kirigami.

Oct 2 2019, 1:53 PM · Plasma
alexeymin added a comment to D24363: Fix several build system errors.

First of all, if you try to build qqc2-desktop-style on a system with only Qt5 and other Tier 1 frameworks installed, you will get the following cmake configure log (https://paste.ubuntu.com/p/YRjSRWm9g6/):

OS Kubuntu 18.04 LTS
Custom-built Qt 5.14 in ~/prefix514
Other Tier 1 Frameworks also built and installed in ~/prefix514
Oct 2 2019, 1:49 PM · Plasma
alexeymin updated the summary of D24363: Fix several build system errors.
Oct 2 2019, 1:44 PM · Plasma
alexeymin requested review of D24363: Fix several build system errors.
Oct 2 2019, 1:33 PM · Plasma

Oct 1 2019

alexeymin committed R108:493bbdc24af4: Merge branch 'Plasma/5.17' (authored by alexeymin).
Merge branch 'Plasma/5.17'
Oct 1 2019, 12:35 PM
alexeymin committed R108:6ee6cc029338: [platforms/hwcomposer] Fix build failure after D23495 (authored by alexeymin).
[platforms/hwcomposer] Fix build failure after D23495
Oct 1 2019, 11:38 AM

Sep 30 2019

alexeymin added a comment to D23495: Get output pixel size from output device.

I think this diff might be the reason for hwc backend failing to build:

In file included from /home/pmos/build/src/kwin-5.16.90/plugins/platforms/hwcomposer/hwcomposer_backend.cpp:21:
/home/pmos/build/src/kwin-5.16.90/plugins/platforms/hwcomposer/hwcomposer_backend.h:58:11: error: 'QSize KWin::HwcomposerOutput::pixelSize() const' marked 'override', but does not override
   58 |     QSize pixelSize() const override;
      |           ^~~~~~~~~
/home/pmos/build/src/kwin-5.16.90/plugins/platforms/hwcomposer/hwcomposer_backend.h:135:10: warning: 'virtual void KWin::HwcomposerWindow::present(HWComposerNativeWindowBuffer*)' can be marked override [-Wsuggest-override]
Sep 30 2019, 10:55 PM · KWin

Sep 19 2019

alexeymin added a watcher for Plasma: alexeymin.
Sep 19 2019, 9:24 AM

Sep 15 2019

alexeymin added a comment to D23415: Improve comprehensibility and consistency of window placement mode names.

All the time I was thinking that "Smart" meaning was "place windows randomly on the screen" because I couldn't guess the logic behind. Thanks to this diff I finally know what it is really doing!

Sep 15 2019, 9:02 AM · Documentation, KWin

Sep 13 2019

alexeymin added inline comments to D23918: RFC: Drop Outputs class.
Sep 13 2019, 6:27 AM · KWin

Sep 3 2019

alexeymin accepted D23707: Fix crash on teardown with Applet's ConfigLoader.

Indeed, I could reproduce the crash again with kquitapp5 plasmashell.

Sep 3 2019, 6:17 PM · Frameworks

Aug 28 2019

alexeymin added a comment to D23514: [platforms/x11] Never block on retrace, always present after paint.

Sure. :) Can you check X and Wayland sessions?

Aug 28 2019, 7:18 PM · KWin
alexeymin added a comment to D23514: [platforms/x11] Never block on retrace, always present after paint.

As usual, do you need help testing this on amdgpu? 😜

Aug 28 2019, 11:48 AM · KWin

Aug 27 2019

alexeymin added a comment to T11459: AbstractWaylandOutput and output device consolidation.

Does hwcomposer platform also need similar change?

Aug 27 2019, 6:19 AM · KWin

Aug 22 2019

alexeymin added a comment to D23350: Chaning default iconSize in systemtray.

I can confirm the issue that tray icons are tooooo small on 4k display

Aug 22 2019, 3:59 PM · Plasma

Aug 21 2019

alexeymin added a comment to D23105: WIP: [platforms/x11] Cleanup GLX backend, revise compositing.

@alexeymin Can you test again with the update? I just accidentally had the fallback timer disabled before. Now works fine for me without swap event.

Aug 21 2019, 7:10 PM · KWin

Aug 17 2019

alexeymin added a comment to D23105: WIP: [platforms/x11] Cleanup GLX backend, revise compositing.
/home/lexx/dev/kde/kwin/plugins/platforms/x11/standalone/glxbackend.cpp: In member function ‘void KWin::GlxBackend::setVsync(bool)’:
/home/lexx/dev/kde/kwin/plugins/platforms/x11/standalone/glxbackend.cpp:252:32: warning: unused parameter ‘enable’ [-Wunused-parameter]
 void GlxBackend::setVsync(bool enable)
                           ~~~~~^~~~~~
Aug 17 2019, 4:50 PM · KWin

Aug 12 2019

alexeymin added a comment to D23105: WIP: [platforms/x11] Cleanup GLX backend, revise compositing.

I haven't yet tested it on AMD

I could test how it works on amdgpu (RX560), if you need help with that, when it's ready to test

Aug 12 2019, 10:50 AM · KWin

Aug 9 2019

alexeymin accepted D23059: Add missing QHash.

I haven't tried to build this with Qt 5.13, but if you say so

Aug 9 2019, 10:58 PM

Jul 24 2019

alexeymin awarded D22720: Apply busy indicator duration change of D22646 to the QQC2 style a Like token.
Jul 24 2019, 7:10 PM · Frameworks

Jul 19 2019

alexeymin added a comment to T11081: Finalize the transition to Wayland and embrace the future of desktop.

Maybe something from these can be used to inspire:

Jul 19 2019, 6:17 PM · Goal Setting 2019
alexeymin updated the task description for T11146: Provide Software Solutions for Consumer Devices.
Jul 19 2019, 1:37 PM · Goal Setting 2019
alexeymin updated the task description for T11057: Improve Plasma on touchscreen devices.
Jul 19 2019, 10:12 AM · Goal Setting 2019

Jul 16 2019

alexeymin retitled D22418: WIP [wayland] make automatic backend selection truly automatic from wayland: make automatic backend selection truly automatic to WIP [wayland] make automatic backend selection truly automatic.
Jul 16 2019, 8:18 PM · KWin
alexeymin added inline comments to D22498: Introduce a simple frame rendered statistic.
Jul 16 2019, 8:17 PM · KWin

Jul 12 2019

alexeymin updated the test plan for D22418: WIP [wayland] make automatic backend selection truly automatic.
Jul 12 2019, 12:57 PM · KWin
alexeymin requested review of D22418: WIP [wayland] make automatic backend selection truly automatic.
Jul 12 2019, 12:39 PM · KWin
alexeymin committed R108:d8c45b46f12a: Fix selection logic and compile error (authored by alexeymin).
Fix selection logic and compile error
Jul 12 2019, 12:22 PM
alexeymin committed R108:621006e54e20: Also output chosen plugin name (authored by alexeymin).
Also output chosen plugin name
Jul 12 2019, 10:45 AM
alexeymin committed R108:659ca117f864: wayland: make automatic backend selection truly automatic (authored by alexeymin).
wayland: make automatic backend selection truly automatic
Jul 12 2019, 9:56 AM

Jul 11 2019

alexeymin committed R108:3bd58c43c6fb: wayland: make automatic backend selection truly automatic (authored by alexeymin).
wayland: make automatic backend selection truly automatic
Jul 11 2019, 9:17 PM
alexeymin awarded M152: Plasma Mobile menu redesign a Like token.
Jul 11 2019, 4:10 PM · Plasma: Mobile
alexeymin added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

Will formatter ruin beautiful multi-line formatting into single line?

Jul 11 2019, 3:58 PM

Jul 7 2019

alexeymin committed R437:982814360954: New dep: KWindowSystem and support running in Wayland (authored by alexeymin).
New dep: KWindowSystem and support running in Wayland
Jul 7 2019, 11:29 AM
alexeymin committed R437:0cc47b9a065d: Remove unneeded moc include (authored by alexeymin).
Remove unneeded moc include
Jul 7 2019, 11:11 AM
alexeymin committed R437:656c90916ca1: Fix unused variable warning (authored by alexeymin).
Fix unused variable warning
Jul 7 2019, 11:06 AM

Jun 28 2019

alexeymin added inline comments to D22150: [plugins/qpa] Implement native offscreen surface.
Jun 28 2019, 10:28 PM · KWin

Jun 25 2019

alexeymin accepted D22036: Follow KDE_APPLICATIONS_VERSION.

Why someone would disagree :) +1 ofc

Jun 25 2019, 10:43 PM

Jun 23 2019

alexeymin added a comment to D22014: Add a copy of FindKXB from kwin.

typo in title :)

Jun 23 2019, 7:29 AM · Plasma

Jun 22 2019

alexeymin added inline comments to D20193: Expose locked keystates on KModifierKeyInfo when on wayland.
Jun 22 2019, 10:49 PM · Frameworks

Jun 20 2019

alexeymin committed R437:e15c5d634d88: Fix clazy: unused non-trivial variable (authored by alexeymin).
Fix clazy: unused non-trivial variable
Jun 20 2019, 8:28 PM
alexeymin committed R437:22b017e0b0dd: Fix clazy: calling QByteArray::data() on temporary (authored by alexeymin).
Fix clazy: calling QByteArray::data() on temporary
Jun 20 2019, 8:20 PM
alexeymin committed R437:05b96c0bd09d: clazy: Don't call QList::first() on temporary (authored by alexeymin).
clazy: Don't call QList::first() on temporary
Jun 20 2019, 8:11 PM
alexeymin committed R437:fa7c32fbb9d3: Fix clazy warning about lambda context object (authored by alexeymin).
Fix clazy warning about lambda context object
Jun 20 2019, 8:03 PM
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

I have no questions to code, but.. This is a behavioral change and I think we need a mantainer's opinion here. Or at least somebody else's opinion.

Jun 20 2019, 10:02 AM

Jun 19 2019

alexeymin committed R437:acf4f7393ea9: bzero() function is obsoleted by memset() (authored by alexeymin).
bzero() function is obsoleted by memset()
Jun 19 2019, 10:03 PM
alexeymin committed R437:43aeee4c3e00: Fix clang-tidy warn: call to virtual function during destruction (authored by alexeymin).
Fix clang-tidy warn: call to virtual function during destruction
Jun 19 2019, 9:55 PM
alexeymin committed R437:aab28698834d: Fix potential use of pointer after checking for nullptr (authored by alexeymin).
Fix potential use of pointer after checking for nullptr
Jun 19 2019, 9:25 PM
alexeymin committed R437:306a09454046: Fix unused parameter warning (authored by alexeymin).
Fix unused parameter warning
Jun 19 2019, 9:08 PM
alexeymin committed R437:a774e678bbb0: Remove unneeded .moc includes (authored by alexeymin).
Remove unneeded .moc includes
Jun 19 2019, 8:51 PM
alexeymin committed R437:718b0ac000ea: Show hostname in krfb connection info (authored by alexeymin).
Show hostname in krfb connection info
Jun 19 2019, 8:09 PM
alexeymin closed D14527: Show hostname in krfb connection info.
Jun 19 2019, 8:09 PM · KDE Applications
alexeymin updated the diff for D14527: Show hostname in krfb connection info.

Reduce memory allocations

Jun 19 2019, 8:08 PM · KDE Applications

Jun 17 2019

alexeymin updated the task description for T11081: Finalize the transition to Wayland and embrace the future of desktop.
Jun 17 2019, 8:33 PM · Goal Setting 2019
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

Now I see, local window is scaled, remote contents are not, is that the intention of this patch?

Jun 17 2019, 3:58 PM
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

Have you installed libkrdc_vncplugin.so into the system?
KRDC doesn't search for plugins in the build tree.

Jun 17 2019, 3:40 PM
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

The patch compiles and works.
I've built master branch and with this patch, and run both with QT_SCALE_FACTOR=2. During connection I chose maximum quality option (local network). The results look identical to me:
master on the left, patched D20790 on the right

Jun 17 2019, 3:11 PM
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

This adds new warnings:

../vnc/vncclientthread.h: In constructor ‘VncClientThread::VncClientThread(QObject*)’:
../vnc/vncclientthread.h:191:19: warning: ‘VncClientThread::m_stopped’ will be initialized after [-Wreorder]
     volatile bool m_stopped;
                   ^~~~~~~~~
../vnc/vncclientthread.h:184:11: warning:   ‘qreal VncClientThread::m_devicePixelRatio’ [-Wreorder]
     qreal m_devicePixelRatio;
           ^~~~~~~~~~~~~~~~~~
../vnc/vncclientthread.cpp:323:1: warning:   when initialized here [-Wreorder]
 VncClientThread::VncClientThread(QObject *parent)

member declaration order in .h-file is mismatches initialization order in constructor.

Jun 17 2019, 2:59 PM

Jun 16 2019

alexeymin updated the diff for D14527: Show hostname in krfb connection info.

Simplify code a bit

Jun 16 2019, 11:26 PM · KDE Applications
alexeymin updated the diff for D14527: Show hostname in krfb connection info.

How about more complex logic then? Display hostname only if it is not empty string.

Jun 16 2019, 11:12 PM · KDE Applications
alexeymin added a project to D14527: Show hostname in krfb connection info: KDE Applications.
Jun 16 2019, 11:10 PM · KDE Applications
alexeymin commandeered D14527: Show hostname in krfb connection info.
Jun 16 2019, 11:09 PM · KDE Applications
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.
$ arc patch D20790
[INFO] Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20790.
Jun 16 2019, 10:09 PM

Jun 14 2019

alexeymin added a comment to D21808: [platforms/X11] Disable VSync for QtQuick Windows.

Qt build that includes commit 0c1831178540462da31fd7a4b6d2e446bc84498b

Jun 14 2019, 9:54 PM · KWin

Jun 13 2019

alexeymin set the repository for D20790: Add highdpi support for RDP and VNC to R436 KRDC.
Jun 13 2019, 10:48 AM

Jun 5 2019

alexeymin added inline comments to D21604: Fix building with Qt 5.13.
Jun 5 2019, 3:08 PM · Baloo, Frameworks
alexeymin accepted D21599: Disable valgrind detection when compiling with MSVC.

This should work.
I mean, msvc detection part...

Jun 5 2019, 12:54 PM · Baloo, Frameworks

May 18 2019

alexeymin committed R437:7624aee8e219: Do not crash on wayland, gracefully exit with error instead (authored by alexeymin).
Do not crash on wayland, gracefully exit with error instead
May 18 2019, 3:07 PM
alexeymin closed D21267: Do not crash on wayland, gracefully exit with error instead.
May 18 2019, 3:07 PM · KDE Applications
alexeymin added a comment to D21273: Add support for newer linux kernel power_supply API.

Hm, looks ideologically similar to how it was done in SDL2...
https://hg.libsdl.org/SDL/file/792c26401463/src/power/linux/SDL_syspower.c

May 18 2019, 2:45 PM · Plasma
alexeymin added a comment to D14527: Show hostname in krfb connection info.

I could take over this revision and update the diff as required (even without adding braces around if statements), but I guess we will need to know @bgray 's email to be able to preserve authorship.

May 18 2019, 11:39 AM · KDE Applications
alexeymin added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.
In D21267#466653, @pino wrote:

LGTM now, thanks.
Works in X11; I assume you tested it under wayland, right?

May 18 2019, 11:30 AM · KDE Applications
alexeymin added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.
In D21267#466632, @pino wrote:

Another idea is to borrow a small bit from D20402, in particular the change in main() that wraps checkX11Capabilities() within a X11 check: as "else" case for that if, you add the error message added here.
This way, after this is done, D20402 will need to add a no-op check for wayland.

May 18 2019, 10:51 AM · KDE Applications
alexeymin updated the diff for D21267: Do not crash on wayland, gracefully exit with error instead.
  • Wrap checkX11Capabilities() in QX11Info::isPlatformX11() check
May 18 2019, 10:50 AM · KDE Applications
alexeymin added a reviewer for D14527: Show hostname in krfb connection info: KDE Applications.
May 18 2019, 10:38 AM · KDE Applications
alexeymin added a comment to D14527: Show hostname in krfb connection info.

This patch does not apply on master now, needs some changes like that:

diff --git a/krfb/mainwindow.cpp b/krfb/mainwindow.cpp
index 8de7822..ad2b04c 100644
--- a/krfb/mainwindow.cpp
+++ b/krfb/mainwindow.cpp
@@ -34,6 +34,7 @@
 #include <QVector>
 #include <QSet>
 #include <QNetworkInterface>
+#include <QHostInfo>
May 18 2019, 10:20 AM · KDE Applications
alexeymin added a comment to D14527: Show hostname in krfb connection info.

Maybe we should land this? 😉

May 18 2019, 9:35 AM · KDE Applications
alexeymin added reviewers for D21267: Do not crash on wayland, gracefully exit with error instead: pino, ngraham.
May 18 2019, 9:34 AM · KDE Applications
alexeymin added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.

@pino thanks for looking at this! Fixed your comments.

May 18 2019, 9:32 AM · KDE Applications
alexeymin added inline comments to D21267: Do not crash on wayland, gracefully exit with error instead.
May 18 2019, 9:19 AM · KDE Applications
alexeymin updated the diff for D21267: Do not crash on wayland, gracefully exit with error instead.
  • Check only for platformName and rephrase the error message.
May 18 2019, 9:18 AM · KDE Applications
alexeymin committed R437:6ecb4248b8a3: Fix warning when compiling with Qt >= 5.10 (authored by alexeymin).
Fix warning when compiling with Qt >= 5.10
May 18 2019, 12:38 AM

May 17 2019

alexeymin updated the test plan for D21267: Do not crash on wayland, gracefully exit with error instead.
May 17 2019, 11:40 PM · KDE Applications
alexeymin added a project to D21267: Do not crash on wayland, gracefully exit with error instead: KDE Applications.
May 17 2019, 11:16 PM · KDE Applications
alexeymin requested review of D21267: Do not crash on wayland, gracefully exit with error instead.
May 17 2019, 11:14 PM · KDE Applications

May 1 2019

alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

I could test with hidpi screens, but I need to understand what was the problem and how is it fixed.

May 1 2019, 9:44 AM

Apr 5 2019

alexeymin awarded D20266: Add new notification plasmoid a Like token.
Apr 5 2019, 2:21 PM · Plasma

Mar 13 2019

alexeymin added a comment to D19663: [platforms/fbdev] Use a better way to correct activating framebuffer devices.
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Using frame buffer device: "/dev/fb0"
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Failed to open frame buffer device: "/dev/fb0" through logind, trying without
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bits Per Pixel:  24
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Buffer Length:  6266880
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bytes Per Line:  3264
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Length:  0
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Length:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Length:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Length:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Offset:  0
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Offset:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Offset:  16
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Offset:  0
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Framebuffer Format is RGB888
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_core: Compositing forced to QPainter mode by environment variable

Mar 13 2019, 10:21 PM · KWin