alexeymin (Alexey Min)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 26 2017, 7:19 PM (112 w, 2 d)
Availability
Available

Recent Activity

Sat, May 18

alexeymin committed R437:7624aee8e219: Do not crash on wayland, gracefully exit with error instead (authored by alexeymin).
Do not crash on wayland, gracefully exit with error instead
Sat, May 18, 3:07 PM
alexeymin closed D21267: Do not crash on wayland, gracefully exit with error instead.
Sat, May 18, 3:07 PM · KDE Applications
alexeymin added a comment to D21273: Add support for newer linux kernel power_supply API.

Hm, looks ideologically similar to how it was done in SDL2...
https://hg.libsdl.org/SDL/file/792c26401463/src/power/linux/SDL_syspower.c

Sat, May 18, 2:45 PM · Plasma
alexeymin added a comment to D14527: Show hostname in krfb connection info.

I could take over this revision and update the diff as required (even without adding braces around if statements), but I guess we will need to know @bgray 's email to be able to preserve authorship.

Sat, May 18, 11:39 AM
alexeymin added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.
In D21267#466653, @pino wrote:

LGTM now, thanks.
Works in X11; I assume you tested it under wayland, right?

Sat, May 18, 11:30 AM · KDE Applications
alexeymin added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.
In D21267#466632, @pino wrote:

Another idea is to borrow a small bit from D20402, in particular the change in main() that wraps checkX11Capabilities() within a X11 check: as "else" case for that if, you add the error message added here.
This way, after this is done, D20402 will need to add a no-op check for wayland.

Sat, May 18, 10:51 AM · KDE Applications
alexeymin updated the diff for D21267: Do not crash on wayland, gracefully exit with error instead.
  • Wrap checkX11Capabilities() in QX11Info::isPlatformX11() check
Sat, May 18, 10:50 AM · KDE Applications
alexeymin added a reviewer for D14527: Show hostname in krfb connection info: KDE Applications.
Sat, May 18, 10:38 AM
alexeymin added a comment to D14527: Show hostname in krfb connection info.

This patch does not apply on master now, needs some changes like that:

diff --git a/krfb/mainwindow.cpp b/krfb/mainwindow.cpp
index 8de7822..ad2b04c 100644
--- a/krfb/mainwindow.cpp
+++ b/krfb/mainwindow.cpp
@@ -34,6 +34,7 @@
 #include <QVector>
 #include <QSet>
 #include <QNetworkInterface>
+#include <QHostInfo>
Sat, May 18, 10:20 AM
alexeymin added a comment to D14527: Show hostname in krfb connection info.

Maybe we should land this? 😉

Sat, May 18, 9:35 AM
alexeymin added reviewers for D21267: Do not crash on wayland, gracefully exit with error instead: pino, ngraham.
Sat, May 18, 9:34 AM · KDE Applications
alexeymin added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.

@pino thanks for looking at this! Fixed your comments.

Sat, May 18, 9:32 AM · KDE Applications
alexeymin added inline comments to D21267: Do not crash on wayland, gracefully exit with error instead.
Sat, May 18, 9:19 AM · KDE Applications
alexeymin updated the diff for D21267: Do not crash on wayland, gracefully exit with error instead.
  • Check only for platformName and rephrase the error message.
Sat, May 18, 9:18 AM · KDE Applications
alexeymin committed R437:6ecb4248b8a3: Fix warning when compiling with Qt >= 5.10 (authored by alexeymin).
Fix warning when compiling with Qt >= 5.10
Sat, May 18, 12:38 AM

Fri, May 17

alexeymin updated the test plan for D21267: Do not crash on wayland, gracefully exit with error instead.
Fri, May 17, 11:40 PM · KDE Applications
alexeymin added a project to D21267: Do not crash on wayland, gracefully exit with error instead: KDE Applications.
Fri, May 17, 11:16 PM · KDE Applications
alexeymin requested review of D21267: Do not crash on wayland, gracefully exit with error instead.
Fri, May 17, 11:14 PM · KDE Applications

Wed, May 1

alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

I could test with hidpi screens, but I need to understand what was the problem and how is it fixed.

Wed, May 1, 9:44 AM

Apr 5 2019

alexeymin awarded D20266: Add new notification plasmoid a Like token.
Apr 5 2019, 2:21 PM · Plasma

Mar 13 2019

alexeymin added a comment to D19663: [platforms/fbdev] Use a better way to correct activating framebuffer devices.
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Using frame buffer device: "/dev/fb0"
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Failed to open frame buffer device: "/dev/fb0" through logind, trying without
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bits Per Pixel:  24
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Buffer Length:  6266880
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bytes Per Line:  3264
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Length:  0
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Length:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Length:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Length:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Offset:  0
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Offset:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Offset:  16
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Offset:  0
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Framebuffer Format is RGB888
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_core: Compositing forced to QPainter mode by environment variable

Mar 13 2019, 10:21 PM · KWin

Mar 1 2019

alexeymin accepted D19449: [logviewer] Fix visual space between the MessageView and navigation views.
Mar 1 2019, 6:03 PM
alexeymin added a watcher for KDE Telepathy: alexeymin.
Mar 1 2019, 5:44 PM

Feb 21 2019

alexeymin created P329 kdevelop (clang) crash in the S1 KDE Community space.
Feb 21 2019, 1:39 PM · KDevelop
alexeymin archived P312 kdevelop crash.
Feb 21 2019, 1:35 PM · KDevelop

Feb 11 2019

alexeymin edited P312 kdevelop crash.
Feb 11 2019, 9:49 AM · KDevelop
alexeymin created P312 kdevelop crash in the S1 KDE Community space.
Feb 11 2019, 7:50 AM · KDevelop
alexeymin added a watcher for KDevelop: alexeymin.
Feb 11 2019, 7:08 AM

Feb 9 2019

alexeymin accepted D17327: KRDC: add default shortcut to open new connection.

I tested, compiles and works, does not open any new windows for me, just focuses address input (I don't have any connections configured). Looks harmless overall, +1

Feb 9 2019, 2:45 PM
alexeymin added a comment to D17327: KRDC: add default shortcut to open new connection.
$ arc patch D17327
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D17327.
Checking patch a/mainwindow.cpp => b/mainwindow.cpp...
error: a/mainwindow.cpp: does not exist in index
Feb 9 2019, 9:46 AM
alexeymin added a comment to D18802: Fix pragma once problem with process class.

Is it because process.h exists somewhere else?

Feb 9 2019, 9:41 AM · Plasma

Feb 2 2019

alexeymin added a comment to D18651: [Task Manager] Sort manually by default.

+1 first thing I change on a fresh setup

Feb 2 2019, 2:49 AM · Plasma

Jan 30 2019

alexeymin added a comment to D18621: Add again a button to manually scan for wireless networks.

In my opinion, this sort of thing is a "help the user feel in control" issue.

Jan 30 2019, 9:59 PM · Plasma

Jan 28 2019

alexeymin added a watcher for KWin: alexeymin.
Jan 28 2019, 3:06 PM
alexeymin added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

I can reproduce an issue. Without patch, VCS error generated in one tab is displayed in all versioned tabs (but not in normal unversioned tabs). Also strangely error is multiplied only on the first occurence, if after first appearance of error I close all error messages in all tabs, and trigger error again, it only appears in current tab, and not in any other.

Jan 28 2019, 1:31 PM · Dolphin

Jan 21 2019

alexeymin accepted D18289: [gitpushgialog] Check index validity.

branches is a QStringList, so, we could also check that currentBranchIndex < branches.size() in condition, if it is all about bounds checking.
Anyway, the diff compiles and overall looks harmless. I'd say +1, I did not try to reproduce the crash though

Jan 21 2019, 4:54 PM

Jan 16 2019

alexeymin committed R437:554f2994ccfe: Reverse the condition to display warning (authored by alexeymin).
Reverse the condition to display warning
Jan 16 2019, 8:04 AM

Jan 15 2019

alexeymin committed R437:313b4bbc6710: Expose option to disable KWallet passwords storage (authored by alexeymin).
Expose option to disable KWallet passwords storage
Jan 15 2019, 9:15 PM
alexeymin closed D18075: Expose option to disable KWallet passwords storage.
Jan 15 2019, 9:15 PM
alexeymin updated the test plan for D18075: Expose option to disable KWallet passwords storage.
Jan 15 2019, 8:39 PM
alexeymin added a comment to D18075: Expose option to disable KWallet passwords storage.

To be precise, passwords are not stored as plain text, scrambled using KStringHandler::obscure(). But this is totally insecure anyway, is a wording like this OK?

Jan 15 2019, 8:34 PM
alexeymin updated the diff for D18075: Expose option to disable KWallet passwords storage.
  • Add a warning about insecure storage in config
Jan 15 2019, 8:33 PM

Jan 11 2019

alexeymin added a reviewer for D18075: Expose option to disable KWallet passwords storage: aacid.
Jan 11 2019, 7:04 PM

Jan 7 2019

alexeymin added a watcher for Flatpak: alexeymin.
Jan 7 2019, 9:43 PM
alexeymin added a reviewer for D18075: Expose option to disable KWallet passwords storage: KDE Applications.
Jan 7 2019, 9:38 PM
alexeymin requested review of D18075: Expose option to disable KWallet passwords storage.
Jan 7 2019, 9:33 PM

Dec 21 2018

alexeymin accepted D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file..

I tested this, it indeed fixes 390225
Withoug this patch, generated pkgconfig file was:

Dec 21 2018, 9:50 AM · Frameworks

Dec 18 2018

alexeymin added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Probably because it is constructed globally before QCoreApplication / before translations were set up, or something like that

Dec 18 2018, 8:20 AM · Spectacle

Dec 17 2018

alexeymin accepted D12626: Port QML Rectangle cropper to QWidget + QPainter.

Works here with 2 monitors like this, tested all modes, seems OK.

Dec 17 2018, 10:40 AM · Spectacle

Dec 16 2018

alexeymin added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

I tested on current master it and it compiles and works; in several capture modes, but only on a single monitor (3840x2160). I can test later (on monday) with dual monitor setup.

Dec 16 2018, 12:13 PM · Spectacle

Dec 2 2018

alexeymin added a comment to T9011: On some devices the Plasma Mobile applications don't render correectly.

same, Xiaomi Redmi Note 4X (Snapdragon) [mido] , Adreno 506, MSM8953 Snapdragon 625
https://github.com/Halium/projectmanagement/issues/71#issuecomment-443450191

Dec 2 2018, 4:32 PM · Plasma: Mobile

Nov 7 2018

alexeymin committed R244:eb916c305a5c: Fix crash if XDG_CACHE_HOME directory is too small or out of space (authored by alexeymin).
Fix crash if XDG_CACHE_HOME directory is too small or out of space
Nov 7 2018, 11:33 PM
alexeymin closed D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 11:33 PM · Frameworks
alexeymin added a comment to D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.

Would a switch be more readable?

Nov 7 2018, 9:36 PM · Frameworks
alexeymin updated the diff for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
  • Fix typo "in" -> "on"
Nov 7 2018, 9:29 PM · Frameworks
alexeymin updated the test plan for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 9:23 PM · Frameworks
alexeymin added a reviewer for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space: Frameworks.
Nov 7 2018, 9:18 PM · Frameworks
alexeymin updated the summary of D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 9:17 PM · Frameworks
alexeymin updated the test plan for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 9:16 PM · Frameworks
alexeymin added a reviewer for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space: dfaure.
Nov 7 2018, 9:14 PM · Frameworks
alexeymin requested review of D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 9:12 PM · Frameworks

Oct 19 2018

alexeymin added a comment to D16330: Add a spacer item.
  1. What if in the future another, horizontal spacer component will become needed? Will you add a HorizontalSpacer.qml then? 😆 Maybe have just a Spacer with horizontal property?
  2. Why Rectangle, it could be just Item, it does not cause rendering (Rectangle does)
Oct 19 2018, 11:30 PM · Kirigami
alexeymin accepted D16304: Add default file name token for (padded) sequential file numbering.

Fine, @utecht do you have a developer account to land this?

Oct 19 2018, 3:59 PM · Spectacle
alexeymin added a comment to D16304: Add default file name token for (padded) sequential file numbering.

Tested, works fine otherwise.

Oct 19 2018, 3:19 PM · Spectacle
alexeymin accepted D16191: Don't save to a temp file if exporting to another app.

Well, ok

Oct 19 2018, 1:20 PM · Spectacle
alexeymin added a comment to D16191: Don't save to a temp file if exporting to another app.

@pino 👌 , so what would be the preferred way to fix those small but eventually-needed changes?

Oct 19 2018, 8:31 AM · Spectacle
alexeymin added a comment to D16191: Don't save to a temp file if exporting to another app.

Spectacle code is far from perfect, I'm suspect there are many other places to add const or fix Q_FOREACH ...

Oct 19 2018, 8:12 AM · Spectacle
alexeymin accepted D16190: Respect user-specified filetype for Save As... operations.

Compiles, works as described, no questions to those 3-6 lines of code modified 😉

Oct 19 2018, 7:55 AM · Spectacle
alexeymin requested changes to D16304: Add default file name token for (padded) sequential file numbering.
Oct 19 2018, 7:49 AM · Spectacle

Oct 18 2018

alexeymin added a comment to D16304: Add default file name token for (padded) sequential file numbering.

I'll test tomorrow, going to sleep >_<

Oct 18 2018, 11:46 PM · Spectacle
alexeymin added inline comments to D16304: Add default file name token for (padded) sequential file numbering.
Oct 18 2018, 6:40 PM · Spectacle
alexeymin requested changes to D16304: Add default file name token for (padded) sequential file numbering.

Resolve confilcts between <<<<<<< and >>>>>>> in several places?
Pretty sure this won't compile 😆

Oct 18 2018, 6:29 PM · Spectacle

Oct 13 2018

alexeymin abandoned D10099: Use single number as filename for screenshot with empty filename template.
Oct 13 2018, 9:32 PM · Spectacle
alexeymin added a comment to D10099: Use single number as filename for screenshot with empty filename template.

Hmm, why would the user do that? If there is no template, the behavior is unclear and undefined.

Oct 13 2018, 9:11 PM · Spectacle
alexeymin added a comment to D10099: Use single number as filename for screenshot with empty filename template.

D10099 Use single number as filename for screenshot with empty filename template

Oct 13 2018, 7:31 PM · Spectacle
alexeymin added a comment to D10099: Use single number as filename for screenshot with empty filename template.

What happens if user deletes filename template in Spectacle settings? Does new token help?

Oct 13 2018, 6:38 PM · Spectacle

Oct 12 2018

alexeymin updated the diff for D10099: Use single number as filename for screenshot with empty filename template.

Original source. I also slightly changed formatting and added const keyword where found possible.

Oct 12 2018, 10:46 AM · Spectacle
alexeymin commandeered D10099: Use single number as filename for screenshot with empty filename template.
Oct 12 2018, 10:16 AM · Spectacle

Oct 11 2018

alexeymin added a comment to D10099: Use single number as filename for screenshot with empty filename template.

We (me) could take over this patch, if original author is no longer available 😕

Oct 11 2018, 3:26 PM · Spectacle

Oct 9 2018

alexeymin accepted D16073: openconnect: add missing dependency Qt5Xml.

https://cgit.kde.org/plasma-nm.git/diff/vpn/openconnect/CMakeLists.txt?id=a44b7f38c548d756b6cb822c047ef71cf67645f5
Probably this commit could remove dependency on QtXml (I'm not sure, QtDbus probably depends on QtXml and QtDbus was removed)
If it fixes build error .../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory then fine...

Oct 9 2018, 4:29 PM · Plasma

Oct 3 2018

alexeymin added a member for Plasma: Mobile: alexeymin.
Oct 3 2018, 2:24 PM

Sep 22 2018

alexeymin added a comment to D15696: Fix qmake build.

How can I reproduce broken build? Any test plan?

Sep 22 2018, 7:33 PM · Kirigami
alexeymin added a comment to D15696: Fix qmake build.

Maybe add it to .pro file too then?

Sep 22 2018, 6:13 PM · Kirigami

Sep 20 2018

alexeymin set the repository for D15233: Add a tooltip for the appentry in the kicker to R119 Plasma Desktop.
Sep 20 2018, 8:27 AM · Plasma
alexeymin added a comment to D15233: Add a tooltip for the appentry in the kicker.

Why isn't repository for this review set? Which repo should it be?

Sep 20 2018, 8:22 AM · Plasma

Aug 25 2018

alexeymin accepted D15084: Change documentation to reflect the real toolchain CMake name.

Looks harmless and correct

Aug 25 2018, 6:45 PM · Build System, Frameworks

Aug 2 2018

alexeymin added a comment to D14544: Android: Don't hardcode a random version of the Android SDK.

From all of my installed build tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1 it selects _default_sdk as 19.1.0, is it fine? 😄
I mean, which one should be used ideally?

Aug 2 2018, 6:47 AM · Build System, Frameworks

Jul 27 2018

alexeymin added a comment to D14397: Support libcanberra for audio notification.

But Currently, libcanberra is tested on Linux only. 😢 Plasma-pa and plasma-whatever can use anything and be Linux-centric, KNotifications is a framework, isn't it?
++vote for QtMultimedia option...

Jul 27 2018, 11:02 AM · Frameworks

Jul 16 2018

alexeymin added a comment to D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps.

Don't know how much offtopic will be what I'm going to say, but I recently ran into an issue while packaging QQC2 application in flatpak with org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system, but under flatpak it failed to start with the following message: QWidget: Cannot create a QWidget without QApplication. Of course, I had only QGuiApplication. But I wasn't using widgets! The only class from QtWidgets was QSystemTrayIcon for a nice integration with desktop. My guess was that was caused by platform style used in flatpak's KDE runtime may use widgets. But this was unexpected, without flatpak all was working. In the end I was forced to use QApplication, and visually saw the style used was ogr.kde.desktop.

Jul 16 2018, 3:58 PM · Plasma

Jul 6 2018

alexeymin added a comment to D13919: [Fonts KCM] Generate font rendering previews only on X.

This is probably for BUG: 396214 ?

Jul 6 2018, 10:08 AM · Plasma
alexeymin added a comment to D13920: [Font Management KCM] Only show on xcb platform.

BUG: 396214 or better BUG: 364746 ?

Jul 6 2018, 10:06 AM · Plasma

Jun 6 2018

alexeymin added a watcher for Plasma: Mobile: alexeymin.
Jun 6 2018, 10:45 AM
alexeymin added a watcher for Plasma: Mobile (PM 1.0): alexeymin.
Jun 6 2018, 10:43 AM

May 31 2018

alexeymin committed R240:0dc051905ae9: Android toolchain: allow to specify extra libs manually (authored by Alexey Minnekhanov <a.minnekhanov@omprussia.ru>).
Android toolchain: allow to specify extra libs manually
May 31 2018, 8:10 AM
alexeymin closed D13198: Android toolchain: allow to specify extra libs manually.
May 31 2018, 8:10 AM · Build System, Frameworks

May 30 2018

alexeymin added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

How exactly I can test if something works? And what are the requirements? PipeWire? Something else?
Or is this only for code review for now?

May 30 2018, 6:32 PM · Plasma on Wayland
alexeymin added a comment to D13198: Android toolchain: allow to specify extra libs manually.

http://doc.qt.io/qt-5/deployment-android.html at the bottom of the page there is an example of usage scenario for qmake project:

May 30 2018, 3:21 PM · Build System, Frameworks
alexeymin accepted D13209: Fix IPv6 connectivity.

Compiles, works. Tested over network from another PC, IPv4. Which VNC client supports IPv6..?

May 30 2018, 7:59 AM

May 29 2018

alexeymin requested review of D13198: Android toolchain: allow to specify extra libs manually.
May 29 2018, 3:36 PM · Build System, Frameworks

May 25 2018

alexeymin removed a watcher for VDG: alexeymin.
May 25 2018, 10:41 PM