- User Since
- Mar 26 2017, 7:19 PM (94 w, 6 d)
Wed, Jan 16
Tue, Jan 15
To be precise, passwords are not stored as plain text, scrambled using KStringHandler::obscure(). But this is totally insecure anyway, is a wording like this OK?
- Add a warning about insecure storage in config
Fri, Jan 11
Mon, Jan 7
Fri, Dec 21
I tested this, it indeed fixes 390225
Withoug this patch, generated pkgconfig file was:
Dec 18 2018
Probably because it is constructed globally before QCoreApplication / before translations were set up, or something like that
Dec 17 2018
Works here with 2 monitors like this, tested all modes, seems OK.
Dec 16 2018
I tested on current master it and it compiles and works; in several capture modes, but only on a single monitor (3840x2160). I can test later (on monday) with dual monitor setup.
Dec 2 2018
same, Xiaomi Redmi Note 4X (Snapdragon) [mido] , Adreno 506, MSM8953 Snapdragon 625
Nov 7 2018
- Fix typo "in" -> "on"
Oct 19 2018
- What if in the future another, horizontal spacer component will become needed? Will you add a HorizontalSpacer.qml then? 😆 Maybe have just a Spacer with horizontal property?
- Why Rectangle, it could be just Item, it does not cause rendering (Rectangle does)
Fine, @utecht do you have a developer account to land this?
Tested, works fine otherwise.
@pino 👌 , so what would be the preferred way to fix those small but eventually-needed changes?
Spectacle code is far from perfect, I'm suspect there are many other places to add const or fix Q_FOREACH ...
Compiles, works as described, no questions to those 3-6 lines of code modified 😉
Oct 18 2018
I'll test tomorrow, going to sleep >_<
Resolve confilcts between <<<<<<< and >>>>>>> in several places?
Pretty sure this won't compile 😆
Oct 13 2018
D10099 Use single number as filename for screenshot with empty filename template
What happens if user deletes filename template in Spectacle settings? Does new token help?
Oct 12 2018
Original source. I also slightly changed formatting and added const keyword where found possible.
Oct 11 2018
We (me) could take over this patch, if original author is no longer available 😕
Oct 9 2018
Probably this commit could remove dependency on QtXml (I'm not sure, QtDbus probably depends on QtXml and QtDbus was removed)
If it fixes build error .../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory then fine...
Oct 3 2018
Sep 22 2018
How can I reproduce broken build? Any test plan?
Maybe add it to .pro file too then?
Sep 20 2018
Why isn't repository for this review set? Which repo should it be?
Aug 25 2018
Looks harmless and correct
Aug 2 2018
From all of my installed build tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1 it selects _default_sdk as 19.1.0, is it fine? 😄
I mean, which one should be used ideally?
Jul 27 2018
But Currently, libcanberra is tested on Linux only. 😢 Plasma-pa and plasma-whatever can use anything and be Linux-centric, KNotifications is a framework, isn't it?
++vote for QtMultimedia option...
Jul 16 2018
Don't know how much offtopic will be what I'm going to say, but I recently ran into an issue while packaging QQC2 application in flatpak with org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system, but under flatpak it failed to start with the following message: QWidget: Cannot create a QWidget without QApplication. Of course, I had only QGuiApplication. But I wasn't using widgets! The only class from QtWidgets was QSystemTrayIcon for a nice integration with desktop. My guess was that was caused by platform style used in flatpak's KDE runtime may use widgets. But this was unexpected, without flatpak all was working. In the end I was forced to use QApplication, and visually saw the style used was ogr.kde.desktop.
Jul 6 2018
This is probably for BUG: 396214 ?
BUG: 396214 or better BUG: 364746 ?
Jun 6 2018
May 31 2018
May 30 2018
How exactly I can test if something works? And what are the requirements? PipeWire? Something else?
Or is this only for code review for now?
http://doc.qt.io/qt-5/deployment-android.html at the bottom of the page there is an example of usage scenario for qmake project:
Compiles, works. Tested over network from another PC, IPv4. Which VNC client supports IPv6..?
May 29 2018
May 25 2018
May 8 2018
May 5 2018
Yeah, after reading about wayland more, I think so, it always uses DRM to render.
May 3 2018
I'm not completely sure that IsDirect should be manually set to true in wayland code path (it looks like a hack just to test).
What happens if IsDirect is set to true, but software rendering is active? Will get_dri_device() fail gracefully or something horrible will happen? :)
Should this notifier provide some tip for user on how to go back to hardware rendering? Or is it not relevant here?
Apr 24 2018
I've tested this and it seems to work!
Apr 21 2018
Stupid question, what happens if dolphin is not installed?
Apr 16 2018
I tested this, and it looks cool and works fine!
Apr 12 2018
Just curious, why is this needed? To avoid dynamic memory allocations?
New version looks much better, no doubt. The only thing you may be asked about here is magical number 120, what is it? Some minimum width for item?
+1, looks better
Apr 9 2018
Apr 7 2018
On wayland, without this patch with OpenGL 3.2 version requested, it fails with error:
and outputs in terminal:
Could not get requested OpenGL profile, requested QSurfaceFormat::OpenGLContextProfile(CoreProfile) got QSurfaceFormat::OpenGLContextProfile(NoProfile) Could not get requested OpenGL profile, requested QSurfaceFormat::OpenGLContextProfile(CompatibilityProfile) got QSurfaceFormat::OpenGLContextProfile(NoProfile)
Apr 6 2018
Apr 5 2018
Apr 4 2018
- Move extra debug output under isDebugEnabled() block
Code looks fine, but I did not test if it actually works. ;)
Apr 3 2018
I looked into Qt sources (QtWayland specifically), and found out that Qt uses similar approach - it loops over received configs and chooses the one that matches user's requested bit depths, if they were specified.
bool QEglConfigChooser::filterConfig(EGLConfig config) const
which is used from QWaylandGLContext class during context creation.
Mar 30 2018
- Use camelCase; merge two "if" statements.
Mar 28 2018
And now I'm reading news about mesa-18 new 10-bit color feature and realizing that maybe mesa-18 was my initial problem :)