alexeymin (Alexey Min)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 26 2017, 7:19 PM (120 w, 1 d)
Availability
Available

Recent Activity

Fri, Jul 12

alexeymin updated the test plan for D22418: wayland: make automatic backend selection truly automatic.
Fri, Jul 12, 12:57 PM · KWin
alexeymin requested review of D22418: wayland: make automatic backend selection truly automatic.
Fri, Jul 12, 12:39 PM · KWin
alexeymin committed R108:d8c45b46f12a: Fix selection logic and compile error (authored by alexeymin).
Fix selection logic and compile error
Fri, Jul 12, 12:22 PM
alexeymin committed R108:621006e54e20: Also output chosen plugin name (authored by alexeymin).
Also output chosen plugin name
Fri, Jul 12, 10:45 AM
alexeymin committed R108:659ca117f864: wayland: make automatic backend selection truly automatic (authored by alexeymin).
wayland: make automatic backend selection truly automatic
Fri, Jul 12, 9:56 AM

Thu, Jul 11

alexeymin committed R108:3bd58c43c6fb: wayland: make automatic backend selection truly automatic (authored by alexeymin).
wayland: make automatic backend selection truly automatic
Thu, Jul 11, 9:17 PM
alexeymin awarded M152: Plasma Mobile menu redesign a Like token.
Thu, Jul 11, 4:10 PM · Plasma: Mobile
alexeymin added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

Will formatter ruin beautiful multi-line formatting into single line?

Thu, Jul 11, 3:58 PM

Sun, Jul 7

alexeymin committed R437:982814360954: New dep: KWindowSystem and support running in Wayland (authored by alexeymin).
New dep: KWindowSystem and support running in Wayland
Sun, Jul 7, 11:29 AM
alexeymin committed R437:0cc47b9a065d: Remove unneeded moc include (authored by alexeymin).
Remove unneeded moc include
Sun, Jul 7, 11:11 AM
alexeymin committed R437:656c90916ca1: Fix unused variable warning (authored by alexeymin).
Fix unused variable warning
Sun, Jul 7, 11:06 AM

Fri, Jun 28

alexeymin added inline comments to D22150: [plugins/qpa] Implement native offscreen surface.
Fri, Jun 28, 10:28 PM · KWin

Tue, Jun 25

alexeymin accepted D22036: Follow KDE_APPLICATIONS_VERSION.

Why someone would disagree :) +1 ofc

Tue, Jun 25, 10:43 PM

Sun, Jun 23

alexeymin added a comment to D22014: Add a copy of FindKXB from kwin.

typo in title :)

Sun, Jun 23, 7:29 AM · Plasma

Sat, Jun 22

alexeymin added inline comments to D20193: Expose locked keystates on KModifierKeyInfo when on wayland.
Sat, Jun 22, 10:49 PM · Frameworks

Thu, Jun 20

alexeymin committed R437:e15c5d634d88: Fix clazy: unused non-trivial variable (authored by alexeymin).
Fix clazy: unused non-trivial variable
Thu, Jun 20, 8:28 PM
alexeymin committed R437:22b017e0b0dd: Fix clazy: calling QByteArray::data() on temporary (authored by alexeymin).
Fix clazy: calling QByteArray::data() on temporary
Thu, Jun 20, 8:20 PM
alexeymin committed R437:05b96c0bd09d: clazy: Don't call QList::first() on temporary (authored by alexeymin).
clazy: Don't call QList::first() on temporary
Thu, Jun 20, 8:11 PM
alexeymin committed R437:fa7c32fbb9d3: Fix clazy warning about lambda context object (authored by alexeymin).
Fix clazy warning about lambda context object
Thu, Jun 20, 8:03 PM
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

I have no questions to code, but.. This is a behavioral change and I think we need a mantainer's opinion here. Or at least somebody else's opinion.

Thu, Jun 20, 10:02 AM

Wed, Jun 19

alexeymin committed R437:acf4f7393ea9: bzero() function is obsoleted by memset() (authored by alexeymin).
bzero() function is obsoleted by memset()
Wed, Jun 19, 10:03 PM
alexeymin committed R437:43aeee4c3e00: Fix clang-tidy warn: call to virtual function during destruction (authored by alexeymin).
Fix clang-tidy warn: call to virtual function during destruction
Wed, Jun 19, 9:55 PM
alexeymin committed R437:aab28698834d: Fix potential use of pointer after checking for nullptr (authored by alexeymin).
Fix potential use of pointer after checking for nullptr
Wed, Jun 19, 9:25 PM
alexeymin committed R437:306a09454046: Fix unused parameter warning (authored by alexeymin).
Fix unused parameter warning
Wed, Jun 19, 9:08 PM
alexeymin committed R437:a774e678bbb0: Remove unneeded .moc includes (authored by alexeymin).
Remove unneeded .moc includes
Wed, Jun 19, 8:51 PM
alexeymin committed R437:718b0ac000ea: Show hostname in krfb connection info (authored by alexeymin).
Show hostname in krfb connection info
Wed, Jun 19, 8:09 PM
alexeymin closed D14527: Show hostname in krfb connection info.
Wed, Jun 19, 8:09 PM · KDE Applications
alexeymin updated the diff for D14527: Show hostname in krfb connection info.

Reduce memory allocations

Wed, Jun 19, 8:08 PM · KDE Applications

Mon, Jun 17

alexeymin updated the task description for T11081: Wayland by Default.
Mon, Jun 17, 8:33 PM · Goal Setting 2019
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

Now I see, local window is scaled, remote contents are not, is that the intention of this patch?

Mon, Jun 17, 3:58 PM
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

Have you installed libkrdc_vncplugin.so into the system?
KRDC doesn't search for plugins in the build tree.

Mon, Jun 17, 3:40 PM
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

The patch compiles and works.
I've built master branch and with this patch, and run both with QT_SCALE_FACTOR=2. During connection I chose maximum quality option (local network). The results look identical to me:
master on the left, patched D20790 on the right

Mon, Jun 17, 3:11 PM
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

This adds new warnings:

../vnc/vncclientthread.h: In constructor ‘VncClientThread::VncClientThread(QObject*)’:
../vnc/vncclientthread.h:191:19: warning: ‘VncClientThread::m_stopped’ will be initialized after [-Wreorder]
     volatile bool m_stopped;
                   ^~~~~~~~~
../vnc/vncclientthread.h:184:11: warning:   ‘qreal VncClientThread::m_devicePixelRatio’ [-Wreorder]
     qreal m_devicePixelRatio;
           ^~~~~~~~~~~~~~~~~~
../vnc/vncclientthread.cpp:323:1: warning:   when initialized here [-Wreorder]
 VncClientThread::VncClientThread(QObject *parent)

member declaration order in .h-file is mismatches initialization order in constructor.

Mon, Jun 17, 2:59 PM

Sun, Jun 16

alexeymin updated the diff for D14527: Show hostname in krfb connection info.

Simplify code a bit

Sun, Jun 16, 11:26 PM · KDE Applications
alexeymin updated the diff for D14527: Show hostname in krfb connection info.

How about more complex logic then? Display hostname only if it is not empty string.

Sun, Jun 16, 11:12 PM · KDE Applications
alexeymin added a project to D14527: Show hostname in krfb connection info: KDE Applications.
Sun, Jun 16, 11:10 PM · KDE Applications
alexeymin commandeered D14527: Show hostname in krfb connection info.
Sun, Jun 16, 11:09 PM · KDE Applications
alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.
$ arc patch D20790
[INFO] Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20790.
Sun, Jun 16, 10:09 PM

Jun 14 2019

alexeymin added a comment to D21808: [platforms/X11] Disable VSync for QtQuick Windows.

Qt build that includes commit 0c1831178540462da31fd7a4b6d2e446bc84498b

Jun 14 2019, 9:54 PM · KWin

Jun 13 2019

alexeymin set the repository for D20790: Add highdpi support for RDP and VNC to R436 KRDC.
Jun 13 2019, 10:48 AM

Jun 5 2019

alexeymin added inline comments to D21604: Fix building with Qt 5.13.
Jun 5 2019, 3:08 PM · Baloo, Frameworks
alexeymin accepted D21599: Disable valgrind detection when compiling with MSVC.

This should work.
I mean, msvc detection part...

Jun 5 2019, 12:54 PM · Baloo, Frameworks

May 18 2019

alexeymin committed R437:7624aee8e219: Do not crash on wayland, gracefully exit with error instead (authored by alexeymin).
Do not crash on wayland, gracefully exit with error instead
May 18 2019, 3:07 PM
alexeymin closed D21267: Do not crash on wayland, gracefully exit with error instead.
May 18 2019, 3:07 PM · KDE Applications
alexeymin added a comment to D21273: Add support for newer linux kernel power_supply API.

Hm, looks ideologically similar to how it was done in SDL2...
https://hg.libsdl.org/SDL/file/792c26401463/src/power/linux/SDL_syspower.c

May 18 2019, 2:45 PM · Plasma
alexeymin added a comment to D14527: Show hostname in krfb connection info.

I could take over this revision and update the diff as required (even without adding braces around if statements), but I guess we will need to know @bgray 's email to be able to preserve authorship.

May 18 2019, 11:39 AM · KDE Applications
alexeymin added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.
In D21267#466653, @pino wrote:

LGTM now, thanks.
Works in X11; I assume you tested it under wayland, right?

May 18 2019, 11:30 AM · KDE Applications
alexeymin added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.
In D21267#466632, @pino wrote:

Another idea is to borrow a small bit from D20402, in particular the change in main() that wraps checkX11Capabilities() within a X11 check: as "else" case for that if, you add the error message added here.
This way, after this is done, D20402 will need to add a no-op check for wayland.

May 18 2019, 10:51 AM · KDE Applications
alexeymin updated the diff for D21267: Do not crash on wayland, gracefully exit with error instead.
  • Wrap checkX11Capabilities() in QX11Info::isPlatformX11() check
May 18 2019, 10:50 AM · KDE Applications
alexeymin added a reviewer for D14527: Show hostname in krfb connection info: KDE Applications.
May 18 2019, 10:38 AM · KDE Applications
alexeymin added a comment to D14527: Show hostname in krfb connection info.

This patch does not apply on master now, needs some changes like that:

diff --git a/krfb/mainwindow.cpp b/krfb/mainwindow.cpp
index 8de7822..ad2b04c 100644
--- a/krfb/mainwindow.cpp
+++ b/krfb/mainwindow.cpp
@@ -34,6 +34,7 @@
 #include <QVector>
 #include <QSet>
 #include <QNetworkInterface>
+#include <QHostInfo>
May 18 2019, 10:20 AM · KDE Applications
alexeymin added a comment to D14527: Show hostname in krfb connection info.

Maybe we should land this? 😉

May 18 2019, 9:35 AM · KDE Applications
alexeymin added reviewers for D21267: Do not crash on wayland, gracefully exit with error instead: pino, ngraham.
May 18 2019, 9:34 AM · KDE Applications
alexeymin added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.

@pino thanks for looking at this! Fixed your comments.

May 18 2019, 9:32 AM · KDE Applications
alexeymin added inline comments to D21267: Do not crash on wayland, gracefully exit with error instead.
May 18 2019, 9:19 AM · KDE Applications
alexeymin updated the diff for D21267: Do not crash on wayland, gracefully exit with error instead.
  • Check only for platformName and rephrase the error message.
May 18 2019, 9:18 AM · KDE Applications
alexeymin committed R437:6ecb4248b8a3: Fix warning when compiling with Qt >= 5.10 (authored by alexeymin).
Fix warning when compiling with Qt >= 5.10
May 18 2019, 12:38 AM

May 17 2019

alexeymin updated the test plan for D21267: Do not crash on wayland, gracefully exit with error instead.
May 17 2019, 11:40 PM · KDE Applications
alexeymin added a project to D21267: Do not crash on wayland, gracefully exit with error instead: KDE Applications.
May 17 2019, 11:16 PM · KDE Applications
alexeymin requested review of D21267: Do not crash on wayland, gracefully exit with error instead.
May 17 2019, 11:14 PM · KDE Applications

May 1 2019

alexeymin added a comment to D20790: Add highdpi support for RDP and VNC.

I could test with hidpi screens, but I need to understand what was the problem and how is it fixed.

May 1 2019, 9:44 AM

Apr 5 2019

alexeymin awarded D20266: Add new notification plasmoid a Like token.
Apr 5 2019, 2:21 PM · Plasma

Mar 13 2019

alexeymin added a comment to D19663: [platforms/fbdev] Use a better way to correct activating framebuffer devices.
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Using frame buffer device: "/dev/fb0"
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Failed to open frame buffer device: "/dev/fb0" through logind, trying without
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bits Per Pixel:  24
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Buffer Length:  6266880
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Bytes Per Line:  3264
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Length:  0
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Length:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Length:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Length:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Blue Offset:  0
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Green Offset:  8
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Red Offset:  16
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Alpha Offset:  0
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_wayland_framebuffer: Framebuffer Format is RGB888
Mar 10 11:01:34 klte user.notice user:plasma-mobile: kwin_core: Compositing forced to QPainter mode by environment variable

Mar 13 2019, 10:21 PM · KWin

Mar 1 2019

alexeymin accepted D19449: [logviewer] Fix visual space between the MessageView and navigation views.
Mar 1 2019, 6:03 PM
alexeymin added a watcher for KDE Telepathy: alexeymin.
Mar 1 2019, 5:44 PM

Feb 21 2019

alexeymin created P329 kdevelop (clang) crash in the S1 KDE Community space.
Feb 21 2019, 1:39 PM · KDevelop
alexeymin archived P312 kdevelop crash.
Feb 21 2019, 1:35 PM · KDevelop

Feb 11 2019

alexeymin edited P312 kdevelop crash.
Feb 11 2019, 9:49 AM · KDevelop
alexeymin created P312 kdevelop crash in the S1 KDE Community space.
Feb 11 2019, 7:50 AM · KDevelop
alexeymin added a watcher for KDevelop: alexeymin.
Feb 11 2019, 7:08 AM

Feb 9 2019

alexeymin accepted D17327: KRDC: add default shortcut to open new connection.

I tested, compiles and works, does not open any new windows for me, just focuses address input (I don't have any connections configured). Looks harmless overall, +1

Feb 9 2019, 2:45 PM
alexeymin added a comment to D17327: KRDC: add default shortcut to open new connection.
$ arc patch D17327
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D17327.
Checking patch a/mainwindow.cpp => b/mainwindow.cpp...
error: a/mainwindow.cpp: does not exist in index
Feb 9 2019, 9:46 AM
alexeymin added a comment to D18802: Fix pragma once problem with process class.

Is it because process.h exists somewhere else?

Feb 9 2019, 9:41 AM · Plasma

Feb 2 2019

alexeymin added a comment to D18651: [Task Manager] Sort manually by default.

+1 first thing I change on a fresh setup

Feb 2 2019, 2:49 AM · Plasma

Jan 30 2019

alexeymin added a comment to D18621: Add again a button to manually scan for wireless networks.

In my opinion, this sort of thing is a "help the user feel in control" issue.

Jan 30 2019, 9:59 PM · Plasma

Jan 28 2019

alexeymin added a watcher for KWin: alexeymin.
Jan 28 2019, 3:06 PM
alexeymin added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

I can reproduce an issue. Without patch, VCS error generated in one tab is displayed in all versioned tabs (but not in normal unversioned tabs). Also strangely error is multiplied only on the first occurence, if after first appearance of error I close all error messages in all tabs, and trigger error again, it only appears in current tab, and not in any other.

Jan 28 2019, 1:31 PM · Dolphin

Jan 21 2019

alexeymin accepted D18289: [gitpushgialog] Check index validity.

branches is a QStringList, so, we could also check that currentBranchIndex < branches.size() in condition, if it is all about bounds checking.
Anyway, the diff compiles and overall looks harmless. I'd say +1, I did not try to reproduce the crash though

Jan 21 2019, 4:54 PM

Jan 16 2019

alexeymin committed R437:554f2994ccfe: Reverse the condition to display warning (authored by alexeymin).
Reverse the condition to display warning
Jan 16 2019, 8:04 AM

Jan 15 2019

alexeymin committed R437:313b4bbc6710: Expose option to disable KWallet passwords storage (authored by alexeymin).
Expose option to disable KWallet passwords storage
Jan 15 2019, 9:15 PM
alexeymin closed D18075: Expose option to disable KWallet passwords storage.
Jan 15 2019, 9:15 PM
alexeymin updated the test plan for D18075: Expose option to disable KWallet passwords storage.
Jan 15 2019, 8:39 PM
alexeymin added a comment to D18075: Expose option to disable KWallet passwords storage.

To be precise, passwords are not stored as plain text, scrambled using KStringHandler::obscure(). But this is totally insecure anyway, is a wording like this OK?

Jan 15 2019, 8:34 PM
alexeymin updated the diff for D18075: Expose option to disable KWallet passwords storage.
  • Add a warning about insecure storage in config
Jan 15 2019, 8:33 PM

Jan 11 2019

alexeymin added a reviewer for D18075: Expose option to disable KWallet passwords storage: aacid.
Jan 11 2019, 7:04 PM

Jan 7 2019

alexeymin added a watcher for Flatpak: alexeymin.
Jan 7 2019, 9:43 PM
alexeymin added a reviewer for D18075: Expose option to disable KWallet passwords storage: KDE Applications.
Jan 7 2019, 9:38 PM
alexeymin requested review of D18075: Expose option to disable KWallet passwords storage.
Jan 7 2019, 9:33 PM

Dec 21 2018

alexeymin accepted D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file..

I tested this, it indeed fixes 390225
Withoug this patch, generated pkgconfig file was:

Dec 21 2018, 9:50 AM · Frameworks

Dec 18 2018

alexeymin added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Probably because it is constructed globally before QCoreApplication / before translations were set up, or something like that

Dec 18 2018, 8:20 AM · Spectacle

Dec 17 2018

alexeymin accepted D12626: Port QML Rectangle cropper to QWidget + QPainter.

Works here with 2 monitors like this, tested all modes, seems OK.

Dec 17 2018, 10:40 AM · Spectacle

Dec 16 2018

alexeymin added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

I tested on current master it and it compiles and works; in several capture modes, but only on a single monitor (3840x2160). I can test later (on monday) with dual monitor setup.

Dec 16 2018, 12:13 PM · Spectacle

Dec 2 2018

alexeymin added a comment to T9011: On some devices the Plasma Mobile applications don't render correectly.

same, Xiaomi Redmi Note 4X (Snapdragon) [mido] , Adreno 506, MSM8953 Snapdragon 625
https://github.com/Halium/projectmanagement/issues/71#issuecomment-443450191

Dec 2 2018, 4:32 PM · Plasma: Mobile

Nov 7 2018

alexeymin committed R244:eb916c305a5c: Fix crash if XDG_CACHE_HOME directory is too small or out of space (authored by alexeymin).
Fix crash if XDG_CACHE_HOME directory is too small or out of space
Nov 7 2018, 11:33 PM
alexeymin closed D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 11:33 PM · Frameworks
alexeymin added a comment to D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.

Would a switch be more readable?

Nov 7 2018, 9:36 PM · Frameworks
alexeymin updated the diff for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
  • Fix typo "in" -> "on"
Nov 7 2018, 9:29 PM · Frameworks
alexeymin updated the test plan for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 9:23 PM · Frameworks
alexeymin added a reviewer for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space: Frameworks.
Nov 7 2018, 9:18 PM · Frameworks
alexeymin updated the summary of D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 9:17 PM · Frameworks