alexeymin (Alexey Min)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 26 2017, 7:19 PM (94 w, 6 d)
Availability
Available

Recent Activity

Wed, Jan 16

alexeymin committed R437:554f2994ccfe: Reverse the condition to display warning (authored by alexeymin).
Reverse the condition to display warning
Wed, Jan 16, 8:04 AM

Tue, Jan 15

alexeymin committed R437:313b4bbc6710: Expose option to disable KWallet passwords storage (authored by alexeymin).
Expose option to disable KWallet passwords storage
Tue, Jan 15, 9:15 PM
alexeymin closed D18075: Expose option to disable KWallet passwords storage.
Tue, Jan 15, 9:15 PM
alexeymin updated the test plan for D18075: Expose option to disable KWallet passwords storage.
Tue, Jan 15, 8:39 PM
alexeymin added a comment to D18075: Expose option to disable KWallet passwords storage.

To be precise, passwords are not stored as plain text, scrambled using KStringHandler::obscure(). But this is totally insecure anyway, is a wording like this OK?

Tue, Jan 15, 8:34 PM
alexeymin updated the diff for D18075: Expose option to disable KWallet passwords storage.
  • Add a warning about insecure storage in config
Tue, Jan 15, 8:33 PM

Fri, Jan 11

alexeymin added a reviewer for D18075: Expose option to disable KWallet passwords storage: aacid.
Fri, Jan 11, 7:04 PM

Mon, Jan 7

alexeymin added a watcher for Flatpak: alexeymin.
Mon, Jan 7, 9:43 PM
alexeymin added a reviewer for D18075: Expose option to disable KWallet passwords storage: KDE Applications.
Mon, Jan 7, 9:38 PM
alexeymin requested review of D18075: Expose option to disable KWallet passwords storage.
Mon, Jan 7, 9:33 PM

Fri, Dec 21

alexeymin accepted D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file..

I tested this, it indeed fixes 390225
Withoug this patch, generated pkgconfig file was:

Fri, Dec 21, 9:50 AM · Frameworks

Dec 18 2018

alexeymin added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Probably because it is constructed globally before QCoreApplication / before translations were set up, or something like that

Dec 18 2018, 8:20 AM · Spectacle

Dec 17 2018

alexeymin accepted D12626: Port QML Rectangle cropper to QWidget + QPainter.

Works here with 2 monitors like this, tested all modes, seems OK.

Dec 17 2018, 10:40 AM · Spectacle

Dec 16 2018

alexeymin added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

I tested on current master it and it compiles and works; in several capture modes, but only on a single monitor (3840x2160). I can test later (on monday) with dual monitor setup.

Dec 16 2018, 12:13 PM · Spectacle

Dec 2 2018

alexeymin added a comment to T9011: On some devices the Plasma Mobile applications don't render correectly.

same, Xiaomi Redmi Note 4X (Snapdragon) [mido] , Adreno 506, MSM8953 Snapdragon 625
https://github.com/Halium/projectmanagement/issues/71#issuecomment-443450191

Dec 2 2018, 4:32 PM · Plasma: Mobile

Nov 7 2018

alexeymin committed R244:eb916c305a5c: Fix crash if XDG_CACHE_HOME directory is too small or out of space (authored by alexeymin).
Fix crash if XDG_CACHE_HOME directory is too small or out of space
Nov 7 2018, 11:33 PM
alexeymin closed D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 11:33 PM · Frameworks
alexeymin added a comment to D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.

Would a switch be more readable?

Nov 7 2018, 9:36 PM · Frameworks
alexeymin updated the diff for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
  • Fix typo "in" -> "on"
Nov 7 2018, 9:29 PM · Frameworks
alexeymin updated the test plan for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 9:23 PM · Frameworks
alexeymin added a reviewer for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space: Frameworks.
Nov 7 2018, 9:18 PM · Frameworks
alexeymin updated the summary of D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 9:17 PM · Frameworks
alexeymin updated the test plan for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 9:16 PM · Frameworks
alexeymin added a reviewer for D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space: dfaure.
Nov 7 2018, 9:14 PM · Frameworks
alexeymin requested review of D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.
Nov 7 2018, 9:12 PM · Frameworks

Oct 19 2018

alexeymin added a comment to D16330: Add a spacer item.
  1. What if in the future another, horizontal spacer component will become needed? Will you add a HorizontalSpacer.qml then? 😆 Maybe have just a Spacer with horizontal property?
  2. Why Rectangle, it could be just Item, it does not cause rendering (Rectangle does)
Oct 19 2018, 11:30 PM · Kirigami
alexeymin accepted D16304: Add default file name token for (padded) sequential file numbering.

Fine, @utecht do you have a developer account to land this?

Oct 19 2018, 3:59 PM · Spectacle
alexeymin added a comment to D16304: Add default file name token for (padded) sequential file numbering.

Tested, works fine otherwise.

Oct 19 2018, 3:19 PM · Spectacle
alexeymin accepted D16191: Don't save to a temp file if exporting to another app.

Well, ok

Oct 19 2018, 1:20 PM · Spectacle
alexeymin added a comment to D16191: Don't save to a temp file if exporting to another app.

@pino 👌 , so what would be the preferred way to fix those small but eventually-needed changes?

Oct 19 2018, 8:31 AM · Spectacle
alexeymin added a comment to D16191: Don't save to a temp file if exporting to another app.

Spectacle code is far from perfect, I'm suspect there are many other places to add const or fix Q_FOREACH ...

Oct 19 2018, 8:12 AM · Spectacle
alexeymin accepted D16190: Respect user-specified filetype for Save As... operations.

Compiles, works as described, no questions to those 3-6 lines of code modified 😉

Oct 19 2018, 7:55 AM · Spectacle
alexeymin requested changes to D16304: Add default file name token for (padded) sequential file numbering.
Oct 19 2018, 7:49 AM · Spectacle

Oct 18 2018

alexeymin added a comment to D16304: Add default file name token for (padded) sequential file numbering.

I'll test tomorrow, going to sleep >_<

Oct 18 2018, 11:46 PM · Spectacle
alexeymin added inline comments to D16304: Add default file name token for (padded) sequential file numbering.
Oct 18 2018, 6:40 PM · Spectacle
alexeymin requested changes to D16304: Add default file name token for (padded) sequential file numbering.

Resolve confilcts between <<<<<<< and >>>>>>> in several places?
Pretty sure this won't compile 😆

Oct 18 2018, 6:29 PM · Spectacle

Oct 13 2018

alexeymin abandoned D10099: Use single number as filename for screenshot with empty filename template.
Oct 13 2018, 9:32 PM · Spectacle
alexeymin added a comment to D10099: Use single number as filename for screenshot with empty filename template.

Hmm, why would the user do that? If there is no template, the behavior is unclear and undefined.

Oct 13 2018, 9:11 PM · Spectacle
alexeymin added a comment to D10099: Use single number as filename for screenshot with empty filename template.

D10099 Use single number as filename for screenshot with empty filename template

Oct 13 2018, 7:31 PM · Spectacle
alexeymin added a comment to D10099: Use single number as filename for screenshot with empty filename template.

What happens if user deletes filename template in Spectacle settings? Does new token help?

Oct 13 2018, 6:38 PM · Spectacle

Oct 12 2018

alexeymin updated the diff for D10099: Use single number as filename for screenshot with empty filename template.

Original source. I also slightly changed formatting and added const keyword where found possible.

Oct 12 2018, 10:46 AM · Spectacle
alexeymin commandeered D10099: Use single number as filename for screenshot with empty filename template.
Oct 12 2018, 10:16 AM · Spectacle

Oct 11 2018

alexeymin added a comment to D10099: Use single number as filename for screenshot with empty filename template.

We (me) could take over this patch, if original author is no longer available 😕

Oct 11 2018, 3:26 PM · Spectacle

Oct 9 2018

alexeymin accepted D16073: openconnect: add missing dependency Qt5Xml.

https://cgit.kde.org/plasma-nm.git/diff/vpn/openconnect/CMakeLists.txt?id=a44b7f38c548d756b6cb822c047ef71cf67645f5
Probably this commit could remove dependency on QtXml (I'm not sure, QtDbus probably depends on QtXml and QtDbus was removed)
If it fixes build error .../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory then fine...

Oct 9 2018, 4:29 PM · Plasma

Oct 3 2018

alexeymin added a member for Plasma: Mobile: alexeymin.
Oct 3 2018, 2:24 PM

Sep 22 2018

alexeymin added a comment to D15696: Fix qmake build.

How can I reproduce broken build? Any test plan?

Sep 22 2018, 7:33 PM · Kirigami
alexeymin added a comment to D15696: Fix qmake build.

Maybe add it to .pro file too then?

Sep 22 2018, 6:13 PM · Kirigami

Sep 20 2018

alexeymin set the repository for D15233: Add a tooltip for the appentry in the kicker to R119 Plasma Desktop.
Sep 20 2018, 8:27 AM · Plasma
alexeymin added a comment to D15233: Add a tooltip for the appentry in the kicker.

Why isn't repository for this review set? Which repo should it be?

Sep 20 2018, 8:22 AM · Plasma

Aug 25 2018

alexeymin accepted D15084: Change documentation to reflect the real toolchain CMake name.

Looks harmless and correct

Aug 25 2018, 6:45 PM · Build System, Frameworks

Aug 2 2018

alexeymin added a comment to D14544: Android: Don't hardcode a random version of the Android SDK.

From all of my installed build tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1 it selects _default_sdk as 19.1.0, is it fine? 😄
I mean, which one should be used ideally?

Aug 2 2018, 6:47 AM · Build System, Frameworks

Jul 27 2018

alexeymin added a comment to D14397: Support libcanberra for audio notification.

But Currently, libcanberra is tested on Linux only. 😢 Plasma-pa and plasma-whatever can use anything and be Linux-centric, KNotifications is a framework, isn't it?
++vote for QtMultimedia option...

Jul 27 2018, 11:02 AM · Frameworks

Jul 16 2018

alexeymin added a comment to D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps.

Don't know how much offtopic will be what I'm going to say, but I recently ran into an issue while packaging QQC2 application in flatpak with org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system, but under flatpak it failed to start with the following message: QWidget: Cannot create a QWidget without QApplication. Of course, I had only QGuiApplication. But I wasn't using widgets! The only class from QtWidgets was QSystemTrayIcon for a nice integration with desktop. My guess was that was caused by platform style used in flatpak's KDE runtime may use widgets. But this was unexpected, without flatpak all was working. In the end I was forced to use QApplication, and visually saw the style used was ogr.kde.desktop.

Jul 16 2018, 3:58 PM · Plasma

Jul 6 2018

alexeymin added a comment to D13919: [Fonts KCM] Generate font rendering previews only on X.

This is probably for BUG: 396214 ?

Jul 6 2018, 10:08 AM · Plasma
alexeymin added a comment to D13920: [Font Management KCM] Only show on xcb platform.

BUG: 396214 or better BUG: 364746 ?

Jul 6 2018, 10:06 AM · Plasma

Jun 6 2018

alexeymin added a watcher for Plasma: Mobile: alexeymin.
Jun 6 2018, 10:45 AM
alexeymin added a watcher for Plasma: Mobile (PM 1.0): alexeymin.
Jun 6 2018, 10:43 AM

May 31 2018

alexeymin committed R240:0dc051905ae9: Android toolchain: allow to specify extra libs manually (authored by Alexey Minnekhanov <a.minnekhanov@omprussia.ru>).
Android toolchain: allow to specify extra libs manually
May 31 2018, 8:10 AM
alexeymin closed D13198: Android toolchain: allow to specify extra libs manually.
May 31 2018, 8:10 AM · Build System, Frameworks

May 30 2018

alexeymin added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

How exactly I can test if something works? And what are the requirements? PipeWire? Something else?
Or is this only for code review for now?

May 30 2018, 6:32 PM · Plasma on Wayland
alexeymin added a comment to D13198: Android toolchain: allow to specify extra libs manually.

http://doc.qt.io/qt-5/deployment-android.html at the bottom of the page there is an example of usage scenario for qmake project:

May 30 2018, 3:21 PM · Build System, Frameworks
alexeymin accepted D13209: Fix IPv6 connectivity.

Compiles, works. Tested over network from another PC, IPv4. Which VNC client supports IPv6..?

May 30 2018, 7:59 AM

May 29 2018

alexeymin requested review of D13198: Android toolchain: allow to specify extra libs manually.
May 29 2018, 3:36 PM · Build System, Frameworks

May 25 2018

alexeymin removed a watcher for VDG: alexeymin.
May 25 2018, 10:41 PM

May 8 2018

alexeymin added a comment to D12698: Show SNI to install browser-side extension.
In D12698#259554, @zzag wrote:

Also, there is Firefox Nightly, which has its own icon too.

May 8 2018, 2:50 PM · Plasma

May 5 2018

alexeymin accepted D12476: kcm_opengl: Fix retrieval of DRI information.

It will fail gracefully, it checks for the presence of these /proc or /sys files and only acts if they exist. This code is only called if an EGL context is successfully created in any case, and in fact on Wayland rendering _is_ always direct.

Yeah, after reading about wayland more, I think so, it always uses DRM to render.

May 5 2018, 11:39 AM · Plasma

May 3 2018

alexeymin added a comment to D12476: kcm_opengl: Fix retrieval of DRI information.

I'm not completely sure that IsDirect should be manually set to true in wayland code path (it looks like a hack just to test).
What happens if IsDirect is set to true, but software rendering is active? Will get_dri_device() fail gracefully or something horrible will happen? :)

May 3 2018, 8:34 PM · Plasma
alexeymin added a comment to D12679: Show SNI when software renderer is in use.

I give them a KCM where they can easily toggle it back. That's only really useful after they've fixed their real problem, but I don't think we can really help with that.

May 3 2018, 2:36 PM · Plasma
alexeymin added a comment to D12679: Show SNI when software renderer is in use.

Should this notifier provide some tip for user on how to go back to hardware rendering? Or is it not relevant here?

May 3 2018, 2:16 PM · Plasma

Apr 24 2018

alexeymin added a comment to D12476: kcm_opengl: Fix retrieval of DRI information.

I've tested this and it seems to work!

Apr 24 2018, 7:33 PM · Plasma

Apr 21 2018

alexeymin added a comment to D12389: Filepicker reads thumbs preview from Dolphin settings.

Stupid question, what happens if dolphin is not installed?

Apr 21 2018, 1:53 PM · Frameworks

Apr 16 2018

alexeymin accepted D11599: Add magnifier for rectangle mode.
Apr 16 2018, 6:20 PM
alexeymin added inline comments to D11599: Add magnifier for rectangle mode.
Apr 16 2018, 2:24 PM
alexeymin added inline comments to D11599: Add magnifier for rectangle mode.
Apr 16 2018, 1:31 PM
alexeymin added a comment to D11599: Add magnifier for rectangle mode.

I tested this, and it looks cool and works fine!

Apr 16 2018, 10:28 AM
alexeymin removed a watcher for Baloo: alexeymin.
Apr 16 2018, 12:01 AM

Apr 12 2018

alexeymin added a comment to D12145: autotests: Do not use QScopedPointer for plugins.

Just curious, why is this needed? To avoid dynamic memory allocations?

Apr 12 2018, 3:54 PM · Baloo, Frameworks
alexeymin added a comment to D12149: Improve grid spacing in icons-on-top mode for open/save dialogs.

New version looks much better, no doubt. The only thing you may be asked about here is magical number 120, what is it? Some minimum width for item?

Apr 12 2018, 3:31 PM · Frameworks
alexeymin accepted D12130: Use the more user-friendly string "File type" in the save dialogs.

+1, looks better

Apr 12 2018, 7:08 AM · Frameworks

Apr 9 2018

alexeymin committed R102:702c7ca86e94: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2 (authored by alexeymin).
Fix displaying OpenGL info on wayland: do not require OpenGL 3.2
Apr 9 2018, 10:22 AM
alexeymin closed D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2.
Apr 9 2018, 10:22 AM · Plasma

Apr 7 2018

alexeymin added reviewers for D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2: Plasma, graesslin, davidedmundson.
Apr 7 2018, 12:00 AM · Plasma
alexeymin added a comment to D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2.

On wayland, without this patch with OpenGL 3.2 version requested, it fails with error:


and outputs in terminal:

Could not get requested OpenGL profile, requested QSurfaceFormat::OpenGLContextProfile(CoreProfile) got QSurfaceFormat::OpenGLContextProfile(NoProfile)
Could not get requested OpenGL profile, requested QSurfaceFormat::OpenGLContextProfile(CompatibilityProfile) got QSurfaceFormat::OpenGLContextProfile(NoProfile)
Apr 7 2018, 12:00 AM · Plasma

Apr 6 2018

alexeymin updated the summary of D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2.
Apr 6 2018, 11:55 PM · Plasma
alexeymin requested review of D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2.
Apr 6 2018, 11:43 PM · Plasma

Apr 5 2018

alexeymin added a comment to D11758: drm backend: choose correct EGL config with mesa-18.

Could you please backport to Plasma/5.12 branch?

Apr 5 2018, 9:26 PM · Plasma on Wayland, KWin
alexeymin committed R108:0ccecbc42757: drm backend: choose correct EGL config with mesa-18 (authored by alexeymin).
drm backend: choose correct EGL config with mesa-18
Apr 5 2018, 9:18 PM

Apr 4 2018

alexeymin added a comment to D11758: drm backend: choose correct EGL config with mesa-18.

Is https://bugs.kde.org/show_bug.cgi?id=392716 related or even fixed with this commit?

Apr 4 2018, 11:14 PM · Plasma on Wayland, KWin
alexeymin committed R108:d318cb3bd43f: drm backend: choose correct EGL config with mesa-18 (authored by alexeymin).
drm backend: choose correct EGL config with mesa-18
Apr 4 2018, 10:29 PM
alexeymin closed D11758: drm backend: choose correct EGL config with mesa-18.
Apr 4 2018, 10:29 PM · Plasma on Wayland, KWin
alexeymin updated the diff for D11758: drm backend: choose correct EGL config with mesa-18.
  • Move extra debug output under isDebugEnabled() block
Apr 4 2018, 10:21 PM · Plasma on Wayland, KWin
alexeymin added a comment to D11882: autotests: Use built executable instead of installed.

Code looks fine, but I did not test if it actually works. ;)

Apr 4 2018, 10:35 AM · Baloo
alexeymin added inline comments to D11882: autotests: Use built executable instead of installed.
Apr 4 2018, 9:41 AM · Baloo

Apr 3 2018

alexeymin added a comment to D11758: drm backend: choose correct EGL config with mesa-18.

I looked into Qt sources (QtWayland specifically), and found out that Qt uses similar approach - it loops over received configs and chooses the one that matches user's requested bit depths, if they were specified.
bool QEglConfigChooser::filterConfig(EGLConfig config) const
which is used from QWaylandGLContext class during context creation.

Apr 3 2018, 10:50 AM · Plasma on Wayland, KWin

Mar 30 2018

alexeymin retitled D11758: drm backend: choose correct EGL config with mesa-18 from drm backend: choose correct EGL config to drm backend: choose correct EGL config with mesa-18.
Mar 30 2018, 8:15 PM · Plasma on Wayland, KWin
alexeymin updated the diff for D11758: drm backend: choose correct EGL config with mesa-18.
  • Use camelCase; merge two "if" statements.
Mar 30 2018, 8:11 PM · Plasma on Wayland, KWin

Mar 28 2018

alexeymin added a comment to D11758: drm backend: choose correct EGL config with mesa-18.

And now I'm reading news about mesa-18 new 10-bit color feature and realizing that maybe mesa-18 was my initial problem :)

Mar 28 2018, 8:52 AM · Plasma on Wayland, KWin
alexeymin added inline comments to D11758: drm backend: choose correct EGL config with mesa-18.
Mar 28 2018, 7:25 AM · Plasma on Wayland, KWin

Mar 27 2018

alexeymin added inline comments to D11758: drm backend: choose correct EGL config with mesa-18.
Mar 27 2018, 9:51 PM · Plasma on Wayland, KWin
alexeymin added a project to D11758: drm backend: choose correct EGL config with mesa-18: Plasma on Wayland.
Mar 27 2018, 9:19 PM · Plasma on Wayland, KWin