[comic] Request current identifier on date changed

Authored by anthonyfieroni on Nov 14 2018, 6:51 AM.



The problem is when date is changed we connect to source ex. dilbert:2018-11-14 but in other hand script (main.es) makes

if (comic.identifier.toString() == date.currentDate().toString()) {

comic.requestPage("http://dilbert.com/", comic.User, infos);

so provider do its job but dataengine does not have a data for us, cause identifier is dilbert: and we are not connected to, so dataUpdated is not called which cause busy indicator to eats cpu power. Another fix can be to have permanently connection to comic_name: to enter dataUpdated in any case.

Diff Detail

R114 Plasma Addons
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
anthonyfieroni created this revision.Nov 14 2018, 6:51 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 14 2018, 6:51 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Nov 14 2018, 6:51 AM
anthonyfieroni added a comment.EditedNov 22 2018, 7:59 AM

@davidedmundson, i have more little fixes over applet did you see something suspicious here, i plan to commit them before 5.14.4 release.

anthonyfieroni added a reviewer: mart.

I will push it in few days, since no activity.

Also fix max comic strips limit

This revision was not accepted when it landed; it landed in state Needs Review.Dec 30 2018, 7:54 AM
This revision was automatically updated to reflect the committed changes.