In D29466#674210, @trmdi wrote:

Can this be moved to krunner? In that case it can be used even when the user doesn't use global menu?

FYI on this patch serie, I am currently focusing on the specification work : https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/35
Then I am thinking about moving my patch serie to gitlab reflecting on the last feedback of course.
Those patchs are getting old and are going to need some degree of rebasing.

I just sent a specification evolution to cover this use case : https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/35

In D29282#676008, @ngraham wrote:

Tried this out and Rectangular Region mode disappeared from the combobox.

I think this is because there is a now check in spectacle that plasma is > 5.20 for the shuttermode.
You can edit the PlatformKWinWayland::supportedShutterModes to work locally.
The patch needs adjustment.

In D23168#675985, @hschaefer wrote:

I added my ssh-key to gitlab, set the upstream urls:

origin git@invent.kde.org:multimedia/ffmpegthumbs.git (fetch)
origin git@invent.kde.org:multimedia/ffmpegthumbs.git (push)

Than I follwed the instructions here: https://docs.gitlab.com/ee/user/project/merge_requests/creating_merge_requests.html#new-merge-request-from-your-local-environment

git push origin diff-D23168

In D23168#675983, @hschaefer wrote:

How do I switch to the right repo?

git remote -v

origin http://anongit.kde.org/ffmpegthumbs (fetch)
origin http://anongit.kde.org/ffmpegthumbs (push)

git remote set-url origin https://invent.kde.org/multimedia/ffmpegthumbs.git

In D23168#675924, @hschaefer wrote:

After struggling with git (as usual since git rebase master did nothing) I came up with that diff.

At moved to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/148

Would be important to land with https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/2

Rebased on master

@hschaefer still around ?

In D29282#675339, @ngraham wrote:

Needs a rebase.

In D29807#675032, @alex wrote:

Friendly Ping :-)

Or should I just move this to gitlab?

@zzag I believe I can land now

ping @cblack and reviewers

In D29847#674811, @usta wrote:

In D29847#674807, @adridg wrote:

https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes

There's already a CMake-time check for <crypt.h>, it's just not used. (HAVE_CRYPT_H)

@adridg having or not having crypt_h I think won't solve this problem because it looks like Linux needs it on the other hand BSD system doesn't have it and use unistd.h
instead of crypt.h so doesn't we still need to check if the system is linux or not ? I have almost 0 knowledge about bsd systems so i think anyone who has knowledge
on this topic might be more suitable for this patch request. ( at first, I have just think about freebsd and now i can see there are other alternatives (net,open,... bsd has similar issue ) )

I am in favor of merging this. @davidedmundson or @zzag any thoughts ?

This should be ready.

Add a KWIN_UTILS logging category

In D28745#675033, @marcingu wrote:

Ok, so, what I want to do now is to create static method findByPath which is going to return Solid::StorageVolume instance (is there a case in which we can expect something different than StorageVolume?).

Needs https://invent.kde.org/graphics/spectacle/-/merge_requests/5 after latest D29408 changes

Check Plasma major version, use splitRef

Use Real DBus interface name as required value in X-KDE-DBUS-Restricted-Interfaces

Make raw DBus call

Add documentation, improve variable naming

Fix emails in copyrights

In D29408#674962, @davidre wrote:

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

I am abandonning https://invent.kde.org/frameworks/kdbusaddons/-/merge_requests/1/diffs.

Check only once the plasma version when needed

Avoid adding the dependency to spectacle

This adds a dependency on https://invent.kde.org/frameworks/kdbusaddons/-/merge_requests/1/diffs

Use KDBusAddon' PlasmaVersion

https://invent.kde.org/graphics/spectacle/-/merge_requests/3 was merged

Removed .arcconfig, rebased

Remove whitespace & rebase

In D28745#674827, @bruns wrote:

In D28745#674711, @meven wrote:

Solid does not provide straight folder => StorageVolume yet, but I think Solid could have such a utility feature added.
Something like Solid::Device::findByPath(), it would need to canonically and recursively resolves the path parent to pay attention to symlinks.
This would also help D26407

No recursion needed, stat provides the device.

Seems fine to me

In D28745#674294, @marcingu wrote:

I tried to research Solid using api.kde.org (https://api.kde.org/frameworks/solid/html/classSolid_1_1Device.html, https://api.kde.org/frameworks/solid/html/classSolid_1_1StorageVolume.html) and looking for usages of both Solid::Device and Solid::StorageVolume in code but I'm not able to get StorageVolume instance for given file/directory.

This is ready to land except I need either to :

• wait after 20.08 is released since this fix is dependent on KWin D29407 that won't be available before Plasma 5.20.
• or add a runtime plasma version check

Clean up delayed shutterMode

In D29774#674668, @zzag wrote:

This added field to Application desktop entries allows to declare an access request to a DBUS interface.

Just to be sure. Does X-KDE-DBUS-Restricted-Interfaces indicate a D-Bus interface or a D-Bus service?

Fix build

The patch has landed :
https://invent.kde.org/plasma/kwayland-server/-/merge_requests/15
https://invent.kde.org/plasma/kwin/-/merge_requests/27

@broulik perhaps a review ?

In D29397#674365, @kossebau wrote:

To not have that block this improvement, you could in parallel for now use a "kde" namespaced directories, say "*@kde2x/", where we/you could just use the for-now-KF-only theme extension. And once there is an agreed specification extension, the code could be switched to just any non-namespace shared hidpi folder matching whatever the specification ended up to be.

In D29487#674322, @ngraham wrote:

Hmm, for me this breaks the option to open a new instance when the PrintScreen key is pressed and an existing instance is already running. It only works if I launch Spectacle manually using the --new-instance flag. The feature should work regardless of how the app is launched.

Well @alex https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 was merged, so if you are still up to do it, now is a good time to rebase your changes.