In D23168#675986, @meven wrote:>

You need to fork the repository in gitlab, before opening the merge request.
Refer to our own instructions https://community.kde.org/Infrastructure/GitLab#Fork_the_project
We also have a tool https://invent.kde.org/sdk/git-lab to simplify the merge request creation/process (it is similar to arc but way easier to install, to use and to contribute to).

I added my ssh-key to gitlab, set the upstream urls:

How do I switch to the right repo?

After struggling with git (as usual since git rebase master did nothing) I came up with that diff.

• removed commented out find_package
• replaced Taglib::Taglib

• copied and replaced FindTaglib.cmake from KDE/extra-cmake-modules/master/find-modules/
• using`toLocal8Bit() + data()` to get C-string of path

In D23168#675464, @meven wrote:

@hschaefer still around ?

I'm breathing and I'm alive.

I just watched into the current git. Is my patch rejected?

Copied https://cgit.kde.org/kio-extras.git/tree/cmake/FindTaglib.cmake and used it to get rid of pkgconfig-depency

• Spaces after if
• removed unused, commented out variable

Since I never used phabricator before, who needs to make the changes to the patch? Me, the submitter of the patch, or the one who finally integrates the patch?