Feed Advanced Search

Yesterday

meven added a comment to D25976: Use a default non-administrator user Type for new users in model.

Thanks Méven! This fixes the case of creating a non-admin user. However while testing it, I found a regression from D25439: when I create an admin user that has a space in the Real Name field, the "Enable administror privileges for this user" checkbox becomes unchecked and it isn't actually created as an admin user. Do you think you could also fix that in this patch?

Sun, Dec 15, 7:47 AM · Plasma
meven updated the diff for D25976: Use a default non-administrator user Type for new users in model.

Code simplification

Sun, Dec 15, 7:46 AM · Plasma
meven updated the diff for D25976: Use a default non-administrator user Type for new users in model.

Set always a default value for role Administrator in m_newUserData

Sun, Dec 15, 7:45 AM · Plasma
meven committed R245:c97f0b2a3076: Ensure mounted nfs filesystems matches their fstab declared counterpart (authored by meven).
Ensure mounted nfs filesystems matches their fstab declared counterpart
Sun, Dec 15, 7:27 AM
meven closed D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.
Sun, Dec 15, 7:27 AM · Frameworks
meven requested changes to D25741: Add case-insensitive sorting for all role-types.

I have tested the patch on tags, it works.
It does not break existing tests.

Sun, Dec 15, 7:11 AM · Dolphin

Sat, Dec 14

meven added a comment to D25741: Add case-insensitive sorting for all role-types.
And tests fail with or without this patch. see bug 413660.
Sat, Dec 14, 9:33 AM · Dolphin
meven requested review of D25976: Use a default non-administrator user Type for new users in model.
Sat, Dec 14, 8:00 AM · Plasma
meven abandoned D25328: Always rehiglhight() after definition was changed.

Fixed in thumnail creator in D25891

Sat, Dec 14, 7:23 AM · Frameworks, Kate
meven abandoned D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found.

In favor of D25891

Sat, Dec 14, 7:22 AM · Frameworks, Dolphin
meven added a comment to D25891: fix preview of plain text files when using dark theme.

For reference I had a similar patch https://phabricator.kde.org/D25323 and a potential fix in KSyntaxHighlighting https://phabricator.kde.org/D25328

Sat, Dec 14, 7:22 AM · Frameworks, Dolphin

Thu, Dec 12

meven added a comment to D25838: [Applets/Kickoff] Show apps by their real names on top by default.

I agree with this.

Thu, Dec 12, 8:29 AM · Plasma

Wed, Dec 11

meven added inline comments to D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule.
Wed, Dec 11, 1:22 PM · KWin
meven updated the diff for D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule.

Remove uneeded setNeedsSave, code style

Wed, Dec 11, 1:21 PM · KWin
meven abandoned D25880: Port from KQuickAddons::ConfigModule to ManagedConfigModule.

Duplicate of D25881

Wed, Dec 11, 12:50 PM · KWin
meven added inline comments to D25871: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings.
Wed, Dec 11, 12:44 PM · KWin
meven requested review of D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule.
Wed, Dec 11, 12:42 PM · KWin
meven requested review of D25880: Port from KQuickAddons::ConfigModule to ManagedConfigModule.
Wed, Dec 11, 12:36 PM · KWin
meven committed R108:930c2d69a714: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings (authored by meven).
[KCM/Desktop] Use KConfig XT to store virtualdesktops related settings
Wed, Dec 11, 10:02 AM
meven closed D25871: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings.
Wed, Dec 11, 10:02 AM · KWin
meven updated the diff for D25871: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings.

Camel case kcfg entries names

Wed, Dec 11, 9:43 AM · KWin
meven updated the summary of D25871: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings.
Wed, Dec 11, 8:23 AM · KWin
meven updated the test plan for D25871: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings.
Wed, Dec 11, 8:20 AM · KWin
meven requested review of D25871: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings.
Wed, Dec 11, 7:54 AM · KWin

Tue, Dec 10

meven added inline comments to D25856: Show IOSlaves that return local files when in local file mode.
Tue, Dec 10, 5:25 PM

Sun, Dec 8

meven added a comment to D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}.

Somewhat depends on D25089 and D25088

Sun, Dec 8, 7:10 PM · Plasma

Wed, Dec 4

meven committed R241:816fc6f9444f: [KFileWidget] Avoid calling slotOk right after the url changed (authored by meven).
[KFileWidget] Avoid calling slotOk right after the url changed
Wed, Dec 4, 10:21 AM
meven closed D25420: [KFileWidget] Avoid calling slotOk right after the url changed.
Wed, Dec 4, 10:21 AM · Frameworks
meven updated the diff for D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

Add return after accepting

Wed, Dec 4, 10:19 AM · Frameworks
meven added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

Is your directory "/home/nate/Documents/Tabletop games/40K" owned by root or another user ?

No:

ls -la "/home/nate/Documents/Tabletop games/40K"
total 19404
drwxrwxr-x  5 nate users     4096 Nov 24 09:07  .
Wed, Dec 4, 8:30 AM · Dolphin
meven updated the diff for D25335: [Details mode] Allow to fill the column size of directories with actual size.

Use a QString as buffer for filenames

Wed, Dec 4, 8:28 AM · Dolphin

Tue, Dec 3

meven updated the diff for D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

Clean up

Tue, Dec 3, 7:05 PM · Frameworks
meven updated the diff for D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

Consumes KeyPressEvent when activated would not needed, clean up

Tue, Dec 3, 7:04 PM · Frameworks
meven updated the summary of D25420: [KFileWidget] Avoid calling slotOk right after the url changed.
Tue, Dec 3, 7:03 PM · Frameworks
meven added a comment to D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

So after a double-click, activated() is emitted, the boolean is set, and much later some Key_Enter event that should have been emitted, gets eaten?

Wouldn't an event filter on the QAbstractItemView solve your problem? Then you can catch the Return key before QAbstractItemView sees it, and call _k_slotActivated yourself, and decide whether to emit returnPressed as well?

I hope this makes sense, if not I can dig further later, I'm in a bit of a rush right now.

I'm actually wondering *when* we want KDirOperator to emit returnPressed at all. When the current index isn't a directory, I assume?

Tue, Dec 3, 6:54 PM · Frameworks
meven updated the diff for D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

Move activated event detection to KDirOperator

Tue, Dec 3, 1:33 PM · Frameworks
meven updated the summary of D25420: [KFileWidget] Avoid calling slotOk right after the url changed.
Tue, Dec 3, 1:33 PM · Frameworks
meven added a comment to D25420: [KFileWidget] Avoid calling slotOk right after the url changed.
Tue, Dec 3, 1:06 PM · Frameworks
meven updated the diff for D25335: [Details mode] Allow to fill the column size of directories with actual size.

s/Deep/deep

Tue, Dec 3, 11:03 AM · Dolphin
meven added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

I'm still not super thrilled by exposing something as nerdy as the maximum depth of calculation/recursion, but before we continue on the UI design discussion, Dolphin has started reproducibly crashing every time I enter Details view with the latest version of this patch. Here's the backtrace:

1#0 __strlen_avx2 () at ../sysdeps/x86_64/multiarch/strlen-avx2.S:96
2#1 0x00007ffff54d293e in __vfprintf_internal (s=s@entry=0x7fffe8e16f70,
3 format=format@entry=0x7ffff7eabefe "%s/%s", ap=ap@entry=0x7fffe8e170b0,
4 mode_flags=mode_flags@entry=0) at vfprintf-internal.c:1688
5#2 0x00007ffff54ddf30 in __vsprintf_internal (
6 string=0x7fffe8e17240 "/home/nate/Documents/Tabletop games/40K/Inspiration",
7 maxlen=maxlen@entry=18446744073709551615,
8 format=format@entry=0x7ffff7eabefe "%s/%s", args=args@entry=0x7fffe8e170b0,
9 mode_flags=mode_flags@entry=0) at iovsprintf.c:96
10#3 0x00007ffff54bd384 in __sprintf (
11 s=s@entry=0x7fffe8e17240 "/home/nate/Documents/Tabletop games/40K/Inspiration",
12 format=format@entry=0x7ffff7eabefe "%s/%s") at sprintf.c:30
13#4 0x00007ffff7e5eab5 in walkDir (
14 dirPath=0x7fff0067706a <error: Cannot access memory at address 0x7fff0067706a>,
15 dirPath@entry=0x7fffe8e17430 "/home/nate/Documents/Tabletop games/40K",
16 countHiddenFiles=countHiddenFiles@entry=false, countDirectoriesOnly=97,
17 countDirectoriesOnly@entry=false, dirEntry=0x7fffe0014f88,
18 allowedRecursiveLevel=1818581280, allowedRecursiveLevel@entry=8)
19 at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:77
20#5 0x00007ffff7e5eaf3 in walkDir (
21 dirPath=dirPath@entry=0x7fffe8e17620 "/home/nate/Documents/Tabletop games",
22 countHiddenFiles=countHiddenFiles@entry=false,
23 countDirectoriesOnly=countDirectoriesOnly@entry=false, dirEntry=0x7fffe000cd40,
24 allowedRecursiveLevel=allowedRecursiveLevel@entry=9)
25 at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:90
26#6 0x00007ffff7e5eaf3 in walkDir (dirPath=0xcc50f8 "/home/nate/Documents",
27 countHiddenFiles=countHiddenFiles@entry=false,
28 countDirectoriesOnly=countDirectoriesOnly@entry=false, dirEntry=0x7fffe0004de0,
29 dirEntry@entry=0x0, allowedRecursiveLevel=allowedRecursiveLevel@entry=10)
30 at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:90
31#7 0x00007ffff7e5ec0e in KDirectoryContentsCounterWorker::subItemsCount (path=...,
32 options=...) at /usr/include/qt5/QtCore/qarraydata.h:208
33#8 0x00007ffff7e5ec77 in KDirectoryContentsCounterWorker::countDirectoryContents (
34 this=0x9ef7f0, path=..., options=...)
35 at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:131
36#9 0x00007ffff5c30eea in QObject::event(QEvent*) () from /usr/lib64/libQt5Core.so.5
37#10 0x00007ffff66dec62 in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
38 from /usr/lib64/libQt5Widgets.so.5
39#11 0x00007ffff66e81e0 in QApplication::notify(QObject*, QEvent*) ()
40 from /usr/lib64/libQt5Widgets.so.5
41#12 0x00007ffff5c05562 in QCoreApplication::notifyInternal2(QObject*, QEvent*) ()
42 from /usr/lib64/libQt5Core.so.5
43#13 0x00007ffff5c081f8 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/lib64/libQt5Core.so.5
44#14 0x00007ffff5c5c333 in ?? () from /usr/lib64/libQt5Core.so.5
45#15 0x00007ffff4055f88 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
46#16 0x00007ffff4056310 in ?? () from /usr/lib64/libglib-2.0.so.0
47#17 0x00007ffff405639f in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
48#18 0x00007ffff5c5b971 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQt5Core.so.5
49#19 0x00007ffff5c040cb in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) ()
50 from /usr/lib64/libQt5Core.so.5
51#20 0x00007ffff5a3c021 in QThread::exec() () from /usr/lib64/libQt5Core.so.5
52#21 0x00007ffff5a3d1a2 in ?? () from /usr/lib64/libQt5Core.so.5
53#22 0x00007ffff50bdf2a in start_thread (arg=<optimized out>) at pthread_create.c:479
54#23 0x00007ffff55654af in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Tue, Dec 3, 11:01 AM · Dolphin

Mon, Dec 2

meven added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

I gave this a try today. The performance is quite good and the feature works great! It will be very nice to have, even without any caching (though that is probably necessary IMO to improve the display and performance and to minimize disk wear for SSDs in particular). I have a few concerns and suggestions for improvement:

  1. The UI to turn this on is entirely too technical. It should be more like this:

    ` Folder size display: (o) Number of items ( ) Size of contents [4] Levels deep `

I mostly followed your nice suggestion.

Mon, Dec 2, 6:06 PM · Dolphin
meven updated the diff for D25335: [Details mode] Allow to fill the column size of directories with actual size.

Apply the setting in UI, better setting UI, remove nb of items when recurse count was selected, take into account folder size

Mon, Dec 2, 5:56 PM · Dolphin
meven added a comment to D25328: Always rehiglhight() after definition was changed.

Hmm, the use case is that it re-highlights if you set an invalid definition?

Here it rehighlight if the definition has changed definition() != def.
But since the current definition m_definition has initially the value Definition(), it is the same as the invalid default definition returned by Repository::definitionForFileName (set in RepositoryPrivate::load line 161) and does not call rehighlight.

Perhaps one should just trigger rehighlight here just for that case, too.

So the fix does not really depend on the definition being valid or invalid.

Perhaps there is a better way to fix this.

Mon, Dec 2, 3:40 PM · Frameworks, Kate
meven added a comment to D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

ping anyone ?

Mon, Dec 2, 3:38 PM · Frameworks
meven updated the diff for D25651: Allow to forget recentlyused resources.

Rebase on master

Mon, Dec 2, 1:56 PM · Dolphin
meven committed R318:8b0c12a59ccb: Refactoring to reduce size of openItemContextMenu and add the ContextType… (authored by meven).
Refactoring to reduce size of openItemContextMenu and add the ContextType…
Mon, Dec 2, 12:26 PM
meven closed D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Mon, Dec 2, 12:25 PM · Dolphin

Sun, Dec 1

meven updated the diff for D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.

Fix: | instead of & to build a QFlags

Sun, Dec 1, 1:38 PM · Frameworks
meven updated the diff for D25651: Allow to forget recentlyused resources.

Rename addRecentlyUsedActions to addForgetRecentlyUsedAction

Sun, Dec 1, 1:28 PM · Dolphin
meven added a dependent revision for D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext: D25651: Allow to forget recentlyused resources.
Sun, Dec 1, 1:25 PM · Dolphin
meven added a dependency for D25651: Allow to forget recentlyused resources: D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Sun, Dec 1, 1:25 PM · Dolphin
meven requested review of D25651: Allow to forget recentlyused resources.
Sun, Dec 1, 1:22 PM · Dolphin
meven added inline comments to D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Sun, Dec 1, 1:09 PM · Dolphin
meven updated the diff for D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.

Split separately timelinecontext and searchcontext

Sun, Dec 1, 1:08 PM · Dolphin
meven added a comment to D25572: [KFileWidget] Allow double quotes in filenames.

This isn't working for me. When I create a file named "foobar".txt, the file dialog is still unable to open it, saying:

That's precisely the unit test included, it works for.
I think the app you tested with did not use your compiled kio because of kdeinit. You can use the included or recompile and use gwenview as it does not use kdeinit, you can also restart kdeinit before launching the app you want to test with :

Sun, Dec 1, 9:06 AM · Frameworks
meven updated the diff for D25572: [KFileWidget] Allow double quotes in filenames.

Remove unrelated change

Sun, Dec 1, 9:03 AM · Frameworks

Fri, Nov 29

meven requested review of D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Fri, Nov 29, 5:00 PM · Dolphin
meven updated the diff for D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.

Do not forget to get UDS_DEVICE_ID UDS_INODE

Fri, Nov 29, 9:17 AM · Frameworks

Thu, Nov 28

meven added inline comments to D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.
Thu, Nov 28, 6:05 PM · Frameworks
meven updated the diff for D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.

Rebasing

Thu, Nov 28, 6:04 PM · Frameworks
meven updated the diff for D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.

Lower the amount of data pulled by directory size job (avoids resolving symlinks notably)

Thu, Nov 28, 6:04 PM · Frameworks
meven added a reviewer for D25572: [KFileWidget] Allow double quotes in filenames: dfaure.
Thu, Nov 28, 5:50 PM · Frameworks
meven updated the diff for D25572: [KFileWidget] Allow double quotes in filenames.

Avoid using unnecessarly QRegularExpression

Thu, Nov 28, 2:02 PM · Frameworks
meven updated the diff for D25572: [KFileWidget] Allow double quotes in filenames.

Add comment

Thu, Nov 28, 12:16 PM · Frameworks
meven updated the diff for D25572: [KFileWidget] Allow double quotes in filenames.

Clean include, update comment

Thu, Nov 28, 12:13 PM · Frameworks
meven added inline comments to D25583: Quit baloo_file_extractor if DB transaction fails.
Thu, Nov 28, 10:32 AM · Baloo, Frameworks
meven added inline comments to D25583: Quit baloo_file_extractor if DB transaction fails.
Thu, Nov 28, 10:25 AM · Baloo, Frameworks
meven created T12283: Make wacomtablet KDEDModule not depend on QApplication.
Thu, Nov 28, 8:48 AM · KF6

Wed, Nov 27

meven requested review of D25572: [KFileWidget] Allow double quotes in filenames.
Wed, Nov 27, 5:38 PM · Frameworks
meven updated the diff for D25117: file ioslave: stop copying as soon as the ioslave is killed.

Let windows code path not being changed, add a todo for windows support

Wed, Nov 27, 9:24 AM · Frameworks

Mon, Nov 25

meven accepted D24691: Add support for WPA3.

Nice, I am properly not the best reviewer here, but it looks ok to me.

Mon, Nov 25, 1:45 PM · Plasma
meven added a reviewer for D25378: Get icon size from QStyle instead of KIconLoader: elvisangelaccio.
Mon, Nov 25, 11:54 AM · Ark
meven added a comment to T12193: Refactor JobUiDelegateExtension to be 4 jobs.

Could we add those jobs in KF5 and mark the old deprecate class JobUiDelegateExtension deprecated, candidate for KF6 cleanup ?

Mon, Nov 25, 11:02 AM · KF6
meven added a reviewer for D25420: [KFileWidget] Avoid calling slotOk right after the url changed: elvisangelaccio.
Mon, Nov 25, 10:59 AM · Frameworks

Sun, Nov 24

meven added a comment to T12180: Review all KDED modules.

Seems redundant with https://phabricator.kde.org/T12191

Sun, Nov 24, 2:02 PM · KF6
meven added a comment to T11640: sddm without X.

There is an experimental branch btw https://github.com/sddm/sddm/pull/616

Sun, Nov 24, 9:05 AM · Plasma on Wayland
meven updated subscribers of D17595: Upstream Dolphin's file rename dialog.

I received the agreements of all contributors including the original code author, to relicense this code and hence upstream it.

Playing the bad guy here: where are these agreements? On a public mailing list, or in your private inbox? If on a public mailing list, you could reference these mails on our mail archives in your commit message.

Sun, Nov 24, 8:01 AM · Frameworks
meven planned changes to D25500: Remove dependency on QtWidgets.

-1 There's UI shown by kded, like network manager prompts and other bits. Also, some bits probably need windowing capabilities.
Certainly something to look into (e.g. use QGuiApplication and turn off platform awareness) but not something we can "just" do in a minor update.

Sun, Nov 24, 7:49 AM · Frameworks
meven added a comment to T12191: KDED: qwidget dependency.

I found the project wacomtablet uses the Kded QGuiApplication internally to detect screens and related events.
It could be replaced by dbus calls instead.

Sun, Nov 24, 7:46 AM · KF6
meven requested review of D25500: Remove dependency on QtWidgets.
Sun, Nov 24, 7:28 AM · Frameworks
meven added a comment to T12191: KDED: qwidget dependency.

Internally in kded it is used to

Sun, Nov 24, 7:00 AM · KF6

Sat, Nov 23

meven updated the diff for D17595: Upstream Dolphin's file rename dialog.

Update copyright/licensing, update @since, add a TODO KF6

Sat, Nov 23, 4:35 PM · Frameworks
meven committed R120:a4e18e2be134: [lockscreen] Clear password field when system suspends (authored by meven).
[lockscreen] Clear password field when system suspends
Sat, Nov 23, 4:28 PM
meven closed D25487: [lockscreen] Clear password field when system suspends.
Sat, Nov 23, 4:28 PM · Plasma
meven added a reviewer for D25487: [lockscreen] Clear password field when system suspends: broulik.
Sat, Nov 23, 1:51 PM · Plasma
meven updated the diff for D25487: [lockscreen] Clear password field when system suspends.

Amend commit message

Sat, Nov 23, 1:51 PM · Plasma
meven updated the test plan for D25487: [lockscreen] Clear password field when system suspends.
Sat, Nov 23, 1:51 PM · Plasma
meven removed a dependency for D25487: [lockscreen] Clear password field when system suspends: D25486: [Greeter] Add a onSuspend() signal to Authenticator.
Sat, Nov 23, 1:51 PM · Plasma
meven removed a dependent revision for D25486: [Greeter] Add a onSuspend() signal to Authenticator: D25487: [lockscreen] Clear password field when system suspends.
Sat, Nov 23, 1:51 PM · Plasma
meven updated the diff for D25487: [lockscreen] Clear password field when system suspends.

Add missing signal transmission resumingFromSuspend for future-proofing

Sat, Nov 23, 1:49 PM · Plasma
meven abandoned D25486: [Greeter] Add a onSuspend() signal to Authenticator.

Have you had a look at the libkworkspace2 stuff? It should have that signal in it and is ready to be made a qml import iirc

Sat, Nov 23, 1:46 PM · Plasma
meven updated the diff for D25487: [lockscreen] Clear password field when system suspends.

Reuse SessionManagement component from libkworkspace org.kde.plasma.private.sessions

Sat, Nov 23, 1:45 PM · Plasma
meven added a comment to D25486: [Greeter] Add a onSuspend() signal to Authenticator.

If this solution is the one expected, I will probably offer a patch to sddm's greeter following the same pattern.

Sat, Nov 23, 12:11 PM · Plasma
meven updated the diff for D25486: [Greeter] Add a onSuspend() signal to Authenticator.

Undo blank line changes

Sat, Nov 23, 12:10 PM · Plasma
meven requested review of D25487: [lockscreen] Clear password field when system suspends.
Sat, Nov 23, 12:04 PM · Plasma
meven added a dependent revision for D25486: [Greeter] Add a onSuspend() signal to Authenticator: D25487: [lockscreen] Clear password field when system suspends.
Sat, Nov 23, 12:04 PM · Plasma
meven requested review of D25486: [Greeter] Add a onSuspend() signal to Authenticator.
Sat, Nov 23, 12:01 PM · Plasma

Fri, Nov 22

meven added inline comments to D25315: KDirModel: implement showing "/" as a root node, optionally.
Fri, Nov 22, 6:57 PM · Frameworks
meven committed R244:8f1952ecb156: Add a descriptive warning when inotify_add_watch returned ENOSPC (authored by meven).
Add a descriptive warning when inotify_add_watch returned ENOSPC
Fri, Nov 22, 6:39 PM
meven closed D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC.
Fri, Nov 22, 6:39 PM · Frameworks