- User Since
- Jan 17 2020, 3:18 PM (4 w, 3 d)
Fri, Feb 14
I have already created a patch for this (and some other improvements) which is currently waiting to be reviewed: https://phabricator.kde.org/D27098
Remove unnecessary include, simplify
Mon, Feb 10
I have found no way to get the currency symbols, other that hard coded.
If you have a look at https://phabricator.kde.org/source/kunitconversion/browse/master/src/currency.cpp$67 you can see that the symbols are concatenated to the string.
Because of this I don't know how to get just the symbols.
- Start implementing requested changes
- Remove unnecessary class declaration
- Implement requested changes
Sun, Feb 9
No problem, thanks for reviewing :-)
Wed, Feb 5
The regex has been implemented and the code is now ~100 lines shorter but provides the same functionality
and the few remaining utility functions have been moved to the runner class.
This should also fix the issues you mentioned :-) .
PS: The regex now includes the of the converter supported currency symbols.
Use Regex for query parsing
Thanks for the quick answer, I will adjust the code/copyright.
While I was refactoring this project I haven't changed the string parsing logic itself.
Sun, Feb 2
Minor formatting improvements
Allow search for profiles without "konsole" prefix
Undo changes that were supposed to be in new diff
Refactoring, improve validation in kcm, optimize
Sat, Feb 1
thanks for the response.
Simplify and optimize
Sorry. I'm removing myself as a reviewer. I barely remember this code base. It has been way too many years.
Fri, Jan 31
Remove unused include
Thats a good point, the issue is that the validation slot gets only triggered if the value gets changed.
If the automatic locking is disabled the value does not change and no signal gets triggered.
Set spinbox disabled by default
if it is a function you don't need to do anything if the function is const (keys()), if not the best practice is to introduce an intermediate const variable
I have a question regarding your changed.
Thu, Jan 30
Yes, I have used an automatic formatter.
I already wondered how this will be handled.
Tue, Jan 28
Remove unnecessary parentheses.
Sat, Jan 25
Implement requested changes
Fri, Jan 24
Tue, Jan 21
Add parentheses for parameter list
Adjust formatting of lambdas
Mon, Jan 20
Jan 18 2020
As requested the update of the HACKING file will be committed separately.