alex (Alexander Lohnau)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 17 2020, 3:18 PM (4 w, 3 d)
Availability
Available

Recent Activity

Fri, Feb 14

alex added a comment to D27365: fix condition in KonsoleProfiles::run.

Hello,
I have already created a patch for this (and some other improvements) which is currently waiting to be reviewed: https://phabricator.kde.org/D27098

Fri, Feb 14, 6:41 PM · Plasma
alex updated the diff for D27098: Bugfix: Konsole does not launch, optimize and simplify runner.

Remove unnecessary include, simplify

Fri, Feb 14, 6:32 PM · Plasma

Mon, Feb 10

alex added a comment to D27166: Refactor converter runner.

Hello,
I have found no way to get the currency symbols, other that hard coded.
If you have a look at https://phabricator.kde.org/source/kunitconversion/browse/master/src/currency.cpp$67 you can see that the symbols are concatenated to the string.
Because of this I don't know how to get just the symbols.

Mon, Feb 10, 1:24 PM · Plasma
alex updated the diff for D27166: Refactor converter runner.
  • Start implementing requested changes
  • Remove unnecessary class declaration
Mon, Feb 10, 1:02 PM · Plasma
alex updated the diff for D27096: Refactoring, improve validation in kcm, optimize.
  • Implement requested changes
Mon, Feb 10, 12:48 PM · Plasma

Sun, Feb 9

alex added a comment to D27109: Fix duplicate results for sessions, simplify and optimize.

No problem, thanks for reviewing :-)

Sun, Feb 9, 11:38 AM · Plasma

Wed, Feb 5

alex added a reviewer for D27166: Refactor converter runner: sitter.

The regex has been implemented and the code is now ~100 lines shorter but provides the same functionality
and the few remaining utility functions have been moved to the runner class.
This should also fix the issues you mentioned :-) .
PS: The regex now includes the of the converter supported currency symbols.

Wed, Feb 5, 6:09 PM · Plasma
alex updated the diff for D27166: Refactor converter runner.

Use Regex for query parsing

Wed, Feb 5, 5:51 PM · Plasma
alex added a comment to D27166: Refactor converter runner.

Thanks for the quick answer, I will adjust the code/copyright.

Wed, Feb 5, 1:40 PM · Plasma
alex added a reviewer for D27166: Refactor converter runner: Plasma.
Wed, Feb 5, 11:16 AM · Plasma
alex added a comment to D27166: Refactor converter runner.

While I was refactoring this project I haven't changed the string parsing logic itself.

Wed, Feb 5, 11:16 AM · Plasma
alex requested review of D27166: Refactor converter runner.
Wed, Feb 5, 10:56 AM · Plasma

Sun, Feb 2

alex added a reviewer for D27109: Fix duplicate results for sessions, simplify and optimize: Plasma.
Sun, Feb 2, 7:46 PM · Plasma
alex added a reviewer for D27098: Bugfix: Konsole does not launch, optimize and simplify runner: Plasma.
Sun, Feb 2, 7:46 PM · Plasma
alex updated the diff for D27109: Fix duplicate results for sessions, simplify and optimize.

Minor formatting improvements

Sun, Feb 2, 7:45 PM · Plasma
alex requested review of D27109: Fix duplicate results for sessions, simplify and optimize.
Sun, Feb 2, 7:37 PM · Plasma
alex updated the diff for D27098: Bugfix: Konsole does not launch, optimize and simplify runner.

Allow search for profiles without "konsole" prefix

Sun, Feb 2, 11:12 AM · Plasma
alex requested review of D27098: Bugfix: Konsole does not launch, optimize and simplify runner.
Sun, Feb 2, 10:56 AM · Plasma
alex requested review of D27096: Refactoring, improve validation in kcm, optimize.
Sun, Feb 2, 7:42 AM · Plasma
alex updated the diff for D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call.

Undo changes that were supposed to be in new diff

Sun, Feb 2, 7:03 AM · Plasma
alex updated the diff for D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call.

Refactoring, improve validation in kcm, optimize

Sun, Feb 2, 6:55 AM · Plasma

Sat, Feb 1

alex added a comment to D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call.

Hello,
thanks for the response.

Sat, Feb 1, 11:24 AM · Plasma
alex updated the diff for D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call.

Simplify and optimize

Sat, Feb 1, 11:05 AM · Plasma
alex added reviewers for D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call: ngraham, broulik.

Sorry. I'm removing myself as a reviewer. I barely remember this code base. It has been way too many years.

Thanks anyway.

Sat, Feb 1, 6:55 AM · Plasma

Fri, Jan 31

alex updated the diff for D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call.

Simplify statement

Fri, Jan 31, 3:16 PM · Plasma
alex updated the diff for D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call.

Remove unused include

Fri, Jan 31, 3:12 PM · Plasma
alex requested review of D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call.
Fri, Jan 31, 3:09 PM · Plasma
alex added a comment to D27063: Fix disabeling of autolock timeout.

Thats a good point, the issue is that the validation slot gets only triggered if the value gets changed.
If the automatic locking is disabled the value does not change and no signal gets triggered.

Fri, Jan 31, 2:57 PM · Plasma
alex updated the diff for D27063: Fix disabeling of autolock timeout.

Set spinbox disabled by default

Fri, Jan 31, 2:53 PM · Plasma
alex requested review of D27063: Fix disabeling of autolock timeout.
Fri, Jan 31, 12:57 PM · Plasma
alex added a comment to D27052: Solid-device-automounter/kcm: Convert some foreach.

if it is a function you don't need to do anything if the function is const (keys()), if not the best practice is to introduce an intermediate const variable

Fri, Jan 31, 11:10 AM · Plasma
alex added a comment to D27052: Solid-device-automounter/kcm: Convert some foreach.

Hello,
I have a question regarding your changed.

Fri, Jan 31, 10:36 AM · Plasma

Thu, Jan 30

alex added a comment to D26912: Use Qt5 signal syntax, format files, optimizations.

Yes, I have used an automatic formatter.

Thu, Jan 30, 3:45 PM · Plasma
alex added a comment to D26912: Use Qt5 signal syntax, format files, optimizations.

I already wondered how this will be handled.

Thu, Jan 30, 9:13 AM · Plasma

Tue, Jan 28

alex updated the diff for D26912: Use Qt5 signal syntax, format files, optimizations.

Remove unnecessary parentheses.

Tue, Jan 28, 7:17 PM · Plasma

Sat, Jan 25

alex updated the diff for D26912: Use Qt5 signal syntax, format files, optimizations.

Implement requested changes

Sat, Jan 25, 11:52 AM · Plasma
alex requested review of D26912: Use Qt5 signal syntax, format files, optimizations.
Sat, Jan 25, 9:15 AM · Plasma

Fri, Jan 24

alex requested review of D26904: Use Qt5 syntax for signal, rename files.
Fri, Jan 24, 8:44 PM · Plasma

Tue, Jan 21

alex added inline comments to D26799: Apply KDE coding style, minor optimizations.
Tue, Jan 21, 2:37 PM · Plasma
This is a test notification, sent at Tue, Jan 21, 8:51 AM.
Tue, Jan 21, 7:51 AM
alex updated the diff for D26799: Apply KDE coding style, minor optimizations.

Add parentheses for parameter list

Tue, Jan 21, 7:09 AM · Plasma
alex updated the diff for D26799: Apply KDE coding style, minor optimizations.

Adjust formatting of lambdas

Tue, Jan 21, 7:05 AM · Plasma

Mon, Jan 20

alex requested review of D26799: Apply KDE coding style, minor optimizations.
Mon, Jan 20, 8:09 PM · Plasma

Jan 18 2020

alex requested review of D26747: Fix typo.
Jan 18 2020, 7:03 AM · Plasma
alex updated the diff for D26738: Fix typo, launch plugin with argument, change signals.

As requested the update of the HACKING file will be committed separately.

Jan 18 2020, 6:47 AM · Plasma

Jan 17 2020

alex requested review of D26738: Fix typo, launch plugin with argument, change signals.
Jan 17 2020, 8:54 PM · Plasma