Wayland: allow to take immediate and delayed screenshots
Changes PlannedPublic

Authored by meven on Mon, May 4, 1:53 PM.

Details

Summary

Add a ShutterMode delayed for the delayed case.

Adds X-KDE-Wayland-Interfaces=org_kde_kwin_effect-screenshot and X-KDE-Original-Executable to desktop file, so that KWin can check spectacle is authorized to take screenshots.

Adds a runtime dependency on D29407 KWin 5.19 in Wayland.

Depends on D29407

BUG: 414532
BUG: 407489

Diff Detail

Repository
R166 Spectacle
Branch
dbus-security
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26325
Build 26343: arc lint + arc unit
meven created this revision.Mon, May 4, 1:53 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptMon, May 4, 1:53 PM
Restricted Application added a subscriber: Spectacle. · View Herald Transcript
meven requested review of this revision.Mon, May 4, 1:53 PM
meven planned changes to this revision.Tue, May 5, 4:21 PM

Spectacle must have its executable in its desktop entry Exec field.
To manage this, spectacle must use KDBusService::Unique instead of Multiple.
This requires some refactoring.

meven edited the summary of this revision. (Show Details)Thu, May 7, 7:28 AM

Why do we introduce the distinction between delayed and immediate? Is there a difference between delayed with 0 seconds and immediate? Also every screenshot triggered by the gui arrives at spectacle core with delay <= 0 because ksmainwindow waits the delay for the taskmanager animation and animating the button.

meven added a comment.Mon, May 11, 9:07 AM

Why do we introduce the distinction between delayed and immediate? Is there a difference between delayed with 0 seconds and immediate? Also every screenshot triggered by the gui arrives at spectacle core with delay <= 0 because ksmainwindow waits the delay for the taskmanager animation and animating the button.

I need to fix this.

The X-KDE-Wayland-Interfaces is no more.

This will be rebased after dependency :
D29487

meven edited the summary of this revision. (Show Details)Tue, May 12, 3:15 PM