usta (Ömer Fadıl Usta)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 16 2016, 3:03 PM (199 w, 5 d)
Availability
Available

Recent Activity

Jun 7 2020

usta added a comment to D29847: Fixes compile problem for freebsd because of missing crypt.h.

https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes

There's already a CMake-time check for <crypt.h>, it's just not used. (HAVE_CRYPT_H)

Jun 7 2020, 9:47 AM · FreeBSD, Plasma
usta added a comment to D29847: Fixes compile problem for freebsd because of missing crypt.h.

or if this is just for linux think we can make it just directly
if defined(Q_OS_LINUX)

Jun 7 2020, 9:12 AM · FreeBSD, Plasma
usta updated the diff for D29847: Fixes compile problem for freebsd because of missing crypt.h.
Jun 7 2020, 9:10 AM · FreeBSD, Plasma
usta added a comment to D29847: Fixes compile problem for freebsd because of missing crypt.h.

Sorry i have written one of them twice , so is this aproach wrong ?
#if !defined(Q_OS_UNIX) && !defined(Q_OS_BSD4) && !defined(Q_OS_FREEBSD) && !defined(Q_OS_NETBSD) && !defined(Q_OS_OPENBSD)

Jun 7 2020, 9:08 AM · FreeBSD, Plasma
usta added inline comments to D29847: Fixes compile problem for freebsd because of missing crypt.h.
Jun 7 2020, 9:06 AM · FreeBSD, Plasma
usta added a reviewer for D29847: Fixes compile problem for freebsd because of missing crypt.h: ngraham.
Jun 7 2020, 4:39 AM · FreeBSD, Plasma
usta requested review of D29847: Fixes compile problem for freebsd because of missing crypt.h.
Jun 7 2020, 4:13 AM · FreeBSD, Plasma

Apr 1 2020

usta accepted D17816: Support for xattrs on kio copy/move.
Apr 1 2020, 2:51 PM · Frameworks
usta added a comment to D17816: Support for xattrs on kio copy/move.

is there a KDE policy about usage of qCWarning( , qCDebug( ?
Because afaik debug one can be ignored by system and some of those might be important to show to user to see
So for example this one looks like a warning instead of a debug info for me ( but not sure what your opinions are) :
qCDebug(KIO_FILE) << "libc failed to extract list of xattr from file";
or this one :
qCDebug(KIO_FILE) << "cant copy Extended attributes";
other than those for me it looks ok

Apr 1 2020, 9:51 AM · Frameworks

Mar 31 2020

usta closed D28453: Add missing include QStandardPaths.
Mar 31 2020, 5:13 AM · KDE PIM
usta committed R94:9b8c55ed1403: Add missing include QStandardPaths (authored by usta).
Add missing include QStandardPaths
Mar 31 2020, 5:13 AM
usta added reviewers for D28453: Add missing include QStandardPaths: ngraham, knauss, mlaurent.
Mar 31 2020, 4:04 AM · KDE PIM
usta requested review of D28453: Add missing include QStandardPaths.
Mar 31 2020, 4:01 AM · KDE PIM
usta closed D28452: Fix baloo compile.

I still need to learn how to use arc land properly

Mar 31 2020, 1:43 AM · Frameworks, Baloo
usta added 1 commit(s) for D28452: Fix baloo compile: R293:ac7f7df21366: Fix compile.
Mar 31 2020, 1:42 AM · Frameworks, Baloo
usta added an edge to R293:ac7f7df21366: Fix compile: D28452: Fix baloo compile.
Mar 31 2020, 1:42 AM
usta committed R293:ac7f7df21366: Fix compile (authored by usta).
Fix compile
Mar 31 2020, 1:40 AM
usta added a reviewer for D28452: Fix baloo compile: ngraham.
Mar 31 2020, 1:31 AM · Frameworks, Baloo
usta updated the summary of D28452: Fix baloo compile.
Mar 31 2020, 1:30 AM · Frameworks, Baloo
usta added a reviewer for D28452: Fix baloo compile: Baloo.
Mar 31 2020, 1:30 AM · Frameworks, Baloo
usta requested review of D28452: Fix baloo compile.
Mar 31 2020, 1:29 AM · Frameworks, Baloo

Mar 29 2020

usta requested changes to D17816: Support for xattrs on kio copy/move.
Mar 29 2020, 6:09 AM · Frameworks
usta requested changes to D17816: Support for xattrs on kio copy/move.
Mar 29 2020, 4:14 AM · Frameworks

Mar 24 2020

usta added a comment to D27503: [KCM Spellchecking] port to KPropertySkeletonItem.

Not just include problem but also got a problem about new Qt version :

Mar 24 2020, 4:37 AM · Plasma

Mar 19 2020

usta closed D28151: Autotest file showing wrong File path.
Mar 19 2020, 11:26 PM · Frameworks
usta added 1 commit(s) for D28151: Autotest file showing wrong File path: R237:67630e49d69c: Autotest file showing wrong File path.
Mar 19 2020, 11:25 PM · Frameworks
usta added an edge to R237:67630e49d69c: Autotest file showing wrong File path: D28151: Autotest file showing wrong File path.
Mar 19 2020, 11:25 PM
usta committed R237:67630e49d69c: Autotest file showing wrong File path (authored by usta).
Autotest file showing wrong File path
Mar 19 2020, 11:00 PM
usta added a reviewer for D28151: Autotest file showing wrong File path: hchain.
Mar 19 2020, 10:39 PM · Frameworks
usta requested review of D28151: Autotest file showing wrong File path.
Mar 19 2020, 10:29 PM · Frameworks

Mar 15 2020

usta requested changes to D17816: Support for xattrs on kio copy/move.
Mar 15 2020, 10:11 PM · Frameworks
usta added inline comments to D17816: Support for xattrs on kio copy/move.
Mar 15 2020, 8:56 PM · Frameworks

Mar 2 2020

usta requested review of D27794: Fix symlink problem because of using relative path instead of full path.
Mar 2 2020, 9:40 PM · Frameworks

Mar 1 2020

usta added a comment to D27736: Fix for not try to check error or try to disconnect if there isn't m_deviceToTearDown exist.

i will try to dig in a little more tonight when i return back to house

Mar 1 2020, 6:35 PM · Dolphin
usta added a comment to D27736: Fix for not try to check error or try to disconnect if there isn't m_deviceToTearDown exist.

btw if needed i can send a screen record about this

Mar 1 2020, 5:46 PM · Dolphin
usta added a comment to D27736: Fix for not try to check error or try to disconnect if there isn't m_deviceToTearDown exist.

On my Arch virtual machine, if I have the terminal open when ejecting an optical disc (working directory in the disc), dolphin doesn't do anything. It probably returned too early or m_deviceToTearDown is falsely set to nullptr for some reason.

Mar 1 2020, 5:45 PM · Dolphin
usta added a comment to D27736: Fix for not try to check error or try to disconnect if there isn't m_deviceToTearDown exist.

Could anyone commit it for me because i didnt make my setup on my box yet. ( planing yo switch to a new laptop thus didnt setup my current git configuration yet ( certificates) )

Mar 1 2020, 3:18 PM · Dolphin

Feb 29 2020

usta added a watcher for KF6: usta.
Feb 29 2020, 10:36 PM
usta requested review of D27736: Fix for not try to check error or try to disconnect if there isn't m_deviceToTearDown exist.
Feb 29 2020, 11:03 AM · Dolphin

Feb 26 2020

usta added a comment to D27557: Auto-generate 24px monochrome icons.

Freebsd side broken again :
00:31:45 ./build/icons-dark/generated/devices/24/network-wired-activated.svg:14: parser error : Opening and ending tag mismatch: g line 8 and svg
00:31:45 </svg>
00:31:45 ^
00:31:45 ./build/icons-dark/generated/devices/24/network-wired-activated.svg:15: parser error : EndTag: '</' not found
00:31:45
00:31:45 ^
00:31:45 gmake[2]: * [CMakeFiles/breeze-validate-svg.dir/build.make:57: CMakeFiles/breeze-validate-svg] Error 1
00:31:45 gmake[1]:
* [CMakeFiles/Makefile2:213: CMakeFiles/breeze-validate-svg.dir/all] Error 2
00:31:45 gmake[1]: *** Waiting for unfinished jobs....

Feb 26 2020, 3:05 AM · Frameworks

Feb 25 2020

usta added inline comments to D27661: wireguard: Trim IP list before submitting to NM.
Feb 25 2020, 8:03 PM · Plasma

Feb 23 2020

usta added a comment to D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint.

2 Question :
1- isnt that method should be const'ified ?
2- also its name will be much better isIgnoreableMountPoint (or something can be more understandable
that it will just return true or false ) becase right now it looks like
"ignore that mount point"

Feb 23 2020, 11:36 PM · Plasma

Feb 14 2020

usta added a comment to D27412: Port away from deprecated API on Qt 5.15.0.

isnt this also needs #include <QLocale>

Feb 14 2020, 7:00 PM · Plasma

Feb 11 2020

usta added inline comments to D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.
Feb 11 2020, 1:54 PM · Plasma

Oct 3 2019

usta added inline comments to D24400: Make hours qint64.
Oct 3 2019, 11:39 PM · Frameworks

Aug 10 2019

usta added a comment to D22976: Fix compilation.

And what are you or ben waiting for? You've both got commit access :)

@aacid:
;) in here we are in sacrifice feast , and i dont have my laptop with me ( sorry about that )

Aug 10 2019, 2:19 PM · Plasma
usta added a comment to D22976: Fix compilation.

ben mentioned that this also needs to be cherrypicked to stable branch too.

Aug 10 2019, 5:01 AM · Plasma

Jul 24 2019

usta updated subscribers of D22545: Add missing include QDate.

Because i was away for a short vacation i coudnt commit this one but
@dfaure committed same thing :) with 0c5430697bdcf41a45046107b28014e40c49a11a
So i think we need to discard this review

Jul 24 2019, 2:40 AM · Calligra: 3.0

Jul 19 2019

usta added a comment to D22545: Add missing include QDate.

i will just commit this to master or do i need to xommit to a branch then merge it to master ? (i have been away from kde about more then 6 years)

Jul 19 2019, 10:10 PM · Calligra: 3.0

Jul 18 2019

usta requested review of D22545: Add missing include QDate.
Jul 18 2019, 11:35 PM · Calligra: 3.0

Jul 10 2019

usta added a comment to D22319: Forgotten bzr for fedora packages.

Change is good to commit. Please let me know if you're not able to commit and I can on your behalf.

Jul 10 2019, 9:08 AM · kdesrc-build

Jul 8 2019

usta updated the diff for D22319: Forgotten bzr for fedora packages.
Jul 8 2019, 9:56 AM · kdesrc-build
usta added a comment to D22319: Forgotten bzr for fedora packages.

libassuan-devel for gpgme

Jul 8 2019, 9:55 AM · kdesrc-build
usta updated the diff for D22319: Forgotten bzr for fedora packages.
Jul 8 2019, 9:33 AM · kdesrc-build
usta added a comment to D22319: Forgotten bzr for fedora packages.

hmm also texinfo is missing for libgpg-error

Jul 8 2019, 9:24 AM · kdesrc-build
usta requested review of D22319: Forgotten bzr for fedora packages.
Jul 8 2019, 8:21 AM · kdesrc-build

Jun 20 2019

usta added a comment to D21919: Change joystick settings icon to game controller.

Maybe we should also consider renaming the KCM to be "Gaming Controller" since I don't know how many people are actually using standalone joysticks anymore. I remember that those were all the rage in the 90s, but probably these days people are just using their XBox controllers or whatever.

Jun 20 2019, 10:32 AM · Frameworks

Nov 2 2017

usta added inline comments to D8332: Added baloo urls into places model.
Nov 2 2017, 1:39 PM · Frameworks

Oct 17 2017

usta added inline comments to D8332: Added baloo urls into places model.
Oct 17 2017, 5:01 PM · Frameworks

Jul 15 2017

usta added inline comments to D6659: [logind] Correct property name to fix logind session.
Jul 15 2017, 6:49 AM · KWin

Oct 16 2016

usta added inline comments to D3046: Pass color scheme hint to Wayland compositor using window property.
Oct 16 2016, 3:34 PM · Plasma
usta added a comment to D3046: Pass color scheme hint to Wayland compositor using window property.

In line 57 QCoreApplication -> QGuiApplication

Oct 16 2016, 3:07 PM · Plasma