adridg (Adriaan de Groot)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2016, 8:39 AM (172 w, 5 d)
Availability
Available

Recent Activity

Sun, Jun 23

adridg added inline comments to D21146: KProcessInfoList -- add proclist backend for FreeBSD.
Sun, Jun 23, 10:01 PM · Frameworks

May 20 2019

adridg abandoned D21305: Add the FreeBSD default-path for os-release..

Thanks for looking at this, Harald. For various downstream packaging reasons, we're going to be stuck with patching, so I'm going to give up on this particular patch.

May 20 2019, 7:32 PM · Frameworks
adridg updated the test plan for D21305: Add the FreeBSD default-path for os-release..
May 20 2019, 1:13 PM · Frameworks
adridg updated the test plan for D21305: Add the FreeBSD default-path for os-release..
May 20 2019, 1:12 PM · Frameworks
adridg requested review of D21305: Add the FreeBSD default-path for os-release..
May 20 2019, 1:11 PM · Frameworks

May 16 2019

adridg accepted D21245: KAr::openArchive: Also check ar_longnamesIndex is not < 0.

ar_longnamesIndex is used as an array-index into ar_longnames, which is new[]ed, so a negative index is UB. This patch voids that case.

May 16 2019, 8:27 PM · Frameworks

May 13 2019

adridg added inline comments to D21146: KProcessInfoList -- add proclist backend for FreeBSD.
May 13 2019, 8:29 PM · Frameworks

Apr 14 2019

adridg requested review of D20562: Use (better) path to libICE when doing check_library_exists..
Apr 14 2019, 10:51 PM · Plasma

Apr 11 2019

adridg added a comment to T10580: Organise Promo Sprint 2019.

I pretty much burned out of promo after QtWS. I have Opinions, but not necessarily the desire or energy to share them. I have a thing june 4/5th, and wasn't planning on going to onboarding,; outside of that I'm generally available, but don't let anything depend on me. (editedchanged date on my existing event)

Apr 11 2019, 6:13 PM · KDE Promo

Apr 5 2019

adridg added a comment to D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code..

I'd start to think about three separate files , unix_impl.cpp, windows_impl.cpp, stub_impl.cpp (although then you get API-syncing issues, probably, when only one of them is updated).

Apr 5 2019, 3:23 PM · Baloo, Frameworks

Apr 3 2019

adridg added a comment to T10755: Unifying Applications' release versions.

So there's subtask extract version information from CMakeLists.txt, which implies a few things:

  • going over the applications to check that they actually do set their version in the top-level CMakeLists, as part of the project() command,
  • check that tooling uses that version consistently,
  • check that the tooling can provide the version information everywhere it's needed.
Apr 3 2019, 8:17 AM

Mar 26 2019

adridg added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

On FreeBSD, /proc is not necessarily mounted (it might be a Linuxism). So while I do have /proc, it's empty because procfs isn't mounted there. If I do mount it, then there's the expected list of processes and a curproc symlink. But /proc/<pid> doesn't contain a stat file .. there's a status, though. Let me mess around a bit with that... yes, changing to status makes all 6 tests pass. So I'd suggest something like

Mar 26 2019, 12:52 PM · Frameworks
adridg added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

Config: Using QtTest library 5.12.1, Qt 5.12.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 6.0.1 (tags/RELEASE_601/final 335540))
PASS : KProcessListTest::initTestCase()

Mar 26 2019, 12:27 PM · Frameworks

Feb 8 2019

adridg created T10458: Olimex Teres Laptop.
Feb 8 2019, 12:29 PM
adridg created T10457: Pinebook.
Feb 8 2019, 12:26 PM
adridg created T10456: Board Bring-Up.
Feb 8 2019, 12:25 PM

Jan 24 2019

adridg added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

With my Calamares maintainer hat on: the decision to live outside of the KDE umbrella was taken before my time, but is basically this: make sure that the installer is seen as a desktop- and sitro-neutral approach, even when it uses KDE technologies. It's an installer for a whole bunch of distro flavors, although it's also enthusiastically used by a bunch of KDE-showcase distro's. I don't want it tied to only the KDE-showcases though.

Jan 24 2019, 10:50 AM · KDE Promo
adridg added a comment to T6351: calamares: wayland.

This has been filed upstream, continues to be unresolved (needs a bunch of kauth work, presumably). It is also an issue with: the webviewmodule, which doesn't run as root because the browser component crashes.

Jan 24 2019, 10:08 AM · Neon
adridg added a comment to T6601: calamares: driver-manager in installer.

Please file this upstream as appropriate. Probably you can get this done via the packages module, but anything more specific should be discussed elsewhere and have a design attached.

Jan 24 2019, 10:07 AM · Neon
adridg added a comment to T9376: calamares by default.

Please file everything upstream as needed.

Jan 24 2019, 10:05 AM · Neon

Jan 18 2019

adridg added a comment to T10372: Attend External Events: List of events to attend.

Similar list as @broulik

Jan 18 2019, 9:23 PM · KDE Promo

Jan 2 2019

adridg updated the diff for D17933: Fix visibility (and build on FreeBSD).

Put export in conventional spot.

Jan 2 2019, 11:06 PM
adridg requested review of D17933: Fix visibility (and build on FreeBSD).
Jan 2 2019, 10:55 PM
adridg requested review of D17931: Fix build on FreeBSD..
Jan 2 2019, 10:19 PM · Kopete

Dec 25 2018

adridg committed R102:39ede9c7e64b: Update logic for disabling the PCI module. (authored by adridg).
Update logic for disabling the PCI module.
Dec 25 2018, 3:08 PM
adridg closed D17785: Update logic for disabling the PCI module..
Dec 25 2018, 3:08 PM · Plasma

Dec 24 2018

adridg requested review of D17785: Update logic for disabling the PCI module..
Dec 24 2018, 9:04 PM · Plasma

Dec 22 2018

adridg committed R466:06d54c931045: Don't delete what was new[]'ed (authored by adridg).
Don't delete what was new[]'ed
Dec 22 2018, 4:14 PM
adridg closed D17736: Don't delete what was new[]'ed.
Dec 22 2018, 4:14 PM
adridg committed R466:c40e3c17d90b: Don't assume someone else pulls in errno.h (authored by adridg).
Don't assume someone else pulls in errno.h
Dec 22 2018, 4:12 PM
adridg closed D17735: Don't assume someone else pulls in errno.h.
Dec 22 2018, 4:12 PM
adridg updated the diff for D17736: Don't delete what was new[]'ed.

See if arc diff HEAD^ does what I wanted.

Dec 22 2018, 3:31 PM
adridg updated the summary of D17736: Don't delete what was new[]'ed.
Dec 22 2018, 3:30 PM
adridg added a reviewer for D17735: Don't assume someone else pulls in errno.h: mauroc.
Dec 22 2018, 3:25 PM
adridg added a reviewer for D17736: Don't delete what was new[]'ed: mauroc.

This one accidentally also contains the changes from D17735

Dec 22 2018, 3:24 PM
adridg requested review of D17736: Don't delete what was new[]'ed.
Dec 22 2018, 3:22 PM
adridg requested review of D17735: Don't assume someone else pulls in errno.h.
Dec 22 2018, 3:18 PM
adridg committed R466:0914fd800654: Add .arcconfig (authored by adridg).
Add .arcconfig
Dec 22 2018, 3:18 PM

Dec 10 2018

adridg added inline comments to D17473: always print status info on vlc finding (even when not found).
Dec 10 2018, 11:32 AM

Nov 27 2018

adridg added a comment to T9953: Attend External Events 2018: Freenode#live.

Public blog posts about the event:

Nov 27 2018, 10:39 AM · KDE Promo

Nov 22 2018

adridg added a comment to D17071: Don't include any directory sizes in DirectorySizeJob.

With UFS, stat(1) tells me

Nov 22 2018, 3:49 PM · Frameworks
adridg added a comment to D17070: Don't double-count size of directories in DirectorySizeJob.

With UFS, stat(1) tells me

Nov 22 2018, 3:14 PM · Frameworks

Oct 30 2018

adridg added a comment to T9952: Attend External Events 2018: Embedded Linux Conference Europe: Post-mortem.

I think you're over-interpreting my comment about the video: it could use an update (can we agree on that? it doesn't show the current state of the phone).

Oct 30 2018, 1:17 PM · Plasma, KDE Promo
adridg added a comment to T9953: Attend External Events 2018: Freenode#live.

@davidedmundson : can you bring a monitor? since you're driving down that ought to fit. Although a different task says "giant monitor a must" I don't think we should do that last-minute here. Besides, the number of expected attendees is much lower than ELCE, so cost is a thing.

Oct 30 2018, 12:38 PM · KDE Promo
adridg triaged T9953: Attend External Events 2018: Freenode#live as Normal priority.
Oct 30 2018, 12:36 PM · KDE Promo
adridg added a comment to T9952: Attend External Events 2018: Embedded Linux Conference Europe: Post-mortem.

Lessons learned: watch the promo-video playing in the background beforehand, so you can talk about it. Check the video, too .. the PlaMo video has a bunch of art photos (naked!) and punk rock songs (naughty words in the title!) on the demo phone, as well as some personal information that is visible (someone's phone number!); not to mention using a cheesy pre-paid phone operator. So it might be updated.

Oct 30 2018, 12:19 PM · Plasma, KDE Promo
adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.

I sent my generally-positive review of the event to the -promo list. Materials have been sent to Dave for the next event.

Oct 30 2018, 11:02 AM · Plasma, KDE Promo

Oct 19 2018

adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.
  • Jon has a box of T-shirts, which we can sell at a pinch and also just wear for consistency (but let's not get stuck on that, and there's something to be said for KDE-in-diversity shirts, e.g. wear what you want)
  • I'll leave my SBCs at home, and just bring the pinebook and slimbook
Oct 19 2018, 11:10 AM · Plasma, KDE Promo
adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.
  • Do we have a dress code in mind for this? Like, KDE India T-shirts or similar? Polo shirts? I can just throw a bunch of KDE-branded clothes (for me) in the suitcase and see what happens, too.
  • None of my SBC's have (touch)screens unless you count the pinebook as one.
Oct 19 2018, 10:33 AM · Plasma, KDE Promo

Oct 15 2018

adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.

Business cards:

  • I'm going to use my (very) old ones, since neither my email nor my phone # has changed in all that time. I'll just scratch off "vice-president, KDE e.V.".
  • If we actually *have* a business card template (PDF? Scribus? Krita?) that can be adapted by others, it should go on community.k.o, right?
Oct 15 2018, 3:20 PM · Plasma, KDE Promo
adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.

Do we need a couple of these: https://www.staples.nl/reclamehouder-a4-schuin/cbs/2411073.html?promoCode=&Effort_Code=WW&Find_Number=2411073&m=0&isSubscription=False to clamp them in? Something to pick up on saturday at a random office-supplies store?

Oct 15 2018, 2:46 PM · Plasma, KDE Promo
adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.

So those table signs, those would be clamped in those perspex-standy things so you can, for instance, set the "Pinebook" sign next to a Pinebook, pre-answering the "what's that?" question.

Oct 15 2018, 2:25 PM · Plasma, KDE Promo
adridg committed R119:fbcbab83b153: Remove author information at their request. (authored by adridg).
Remove author information at their request.
Oct 15 2018, 12:27 PM
adridg committed R492:ea54c3c5681e: Make it compile on FreeBSD (authored by adridg).
Make it compile on FreeBSD
Oct 15 2018, 11:13 AM
adridg committed R492:77d05a70fd5f: Missing includes for FreeBSD (authored by adridg).
Missing includes for FreeBSD
Oct 15 2018, 11:13 AM
adridg committed R492:c5886d81d631: Merge remote-tracking branch 'origin/frameworks' into topic-llvm+freebsd_ipv6 (authored by adridg).
Merge remote-tracking branch 'origin/frameworks' into topic-llvm+freebsd_ipv6
Oct 15 2018, 11:13 AM

Oct 6 2018

adridg committed R921:31b55468a297: Another four months of news (authored by adridg).
Another four months of news
Oct 6 2018, 10:00 PM
adridg committed R921:b18b0d6b61b6: Update some pointers: (authored by adridg).
Update some pointers:
Oct 6 2018, 10:00 PM

Sep 26 2018

adridg committed R357:821eb9ab34a5: Some more 0 -> nullptr changes. Now compiles without nullptr warnings with… (authored by adridg).
Some more 0 -> nullptr changes. Now compiles without nullptr warnings with…
Sep 26 2018, 10:44 AM

Sep 17 2018

adridg added a comment to T9477: Organizing KDE's presence at FOSDEM 2019.

I've put in a booth request now. No devroom, though -- that would take some non-zero coordination with GNOME or other desktops, and I don't think we have the time or energy for that just now.

Sep 17 2018, 4:30 PM · KDE Promo

Sep 4 2018

adridg added inline comments to D15072: [server] Abort drag start on correct conditions and without posting error.
Sep 4 2018, 6:02 PM · Frameworks
adridg added inline comments to D15072: [server] Abort drag start on correct conditions and without posting error.
Sep 4 2018, 1:30 PM · Frameworks
adridg added a comment to T9468: Develop Social Media Access Policy.

For *3B*, that's an attempt to quantify "you must be active in promo". Maybe it quantifies "you must be active in promo and do more than just push the button on social media accounts". I think *10* provides a mechanism to handle inactivity. Where exactly is the unfairness? Someone who takes on only high-effort tasks does more work to qualify for *3B*, but they could also do a low-effort one once, if the high-effort ones are all failing.

Sep 4 2018, 9:43 AM · KDE Promo

Aug 24 2018

adridg added a comment to T9468: Develop Social Media Access Policy.

Tangentially related: kde-promo mailing list administration. That doesn't give any posting power, at best it gives the power to filter out posts by non-members to that list (e.g. you can stop spam, and very very rarely stop actual mail from non-subscribers). Right now Lydia and I do that (small) bit of administration, but it should be added to the "things promo keeps track of".

Aug 24 2018, 10:48 PM · KDE Promo
adridg added a comment to T6352: Calamares: OEM support.

The neon part perhaps belongs here, but as a Calamares ticket it should be elsewhere.

Aug 24 2018, 7:18 PM · Neon
adridg committed R883:1523219: Fix up typo's. Reported by Paul..
Fix up typo's. Reported by Paul.
Aug 24 2018, 12:35 PM
adridg committed R883:1523218: Drop superfluous full stop.
Drop superfluous full stop
Aug 24 2018, 11:21 AM
adridg committed R883:1523217: Update text on the /contact/ page..
Update text on the /contact/ page.
Aug 24 2018, 11:16 AM

Aug 23 2018

adridg committed R883:1523185: Remove press contacts from translations..
Remove press contacts from translations.
Aug 23 2018, 9:52 PM
adridg committed R883:1523184: Drop all the regional representatives..
Drop all the regional representatives.
Aug 23 2018, 9:46 PM
adridg committed R883:1523177: Bogus commit to test if I can adapt www for -promo.
Bogus commit to test if I can adapt www for -promo
Aug 23 2018, 3:32 PM

Aug 21 2018

adridg added a comment to D14927: KConfig: handle directory symlinks correctly..

Sorry, this is getting very confusing:

Aug 21 2018, 10:26 AM · Frameworks

Aug 20 2018

adridg added a comment to D14927: KConfig: handle directory symlinks correctly..

Totals: 44 passed, 2 failed, 0 skipped, 0 blacklisted, 225ms

Aug 20 2018, 9:01 PM · Frameworks
adridg added a comment to D14927: KConfig: handle directory symlinks correctly..

This shows up in the unit tests. Whether it has any effect in real life is unknown. FreeBSD often -- sometimes, maybe, depending on FS setup and layout -- has /home -> /usr/home or /home -> usr/home, and of course there could be weird user setups as well where .cache is symlinked to a different location with more disk space. In any case, this is triggering unit-test failures in the CI, so cleaning it up to consistently compare the same kind of filename is a good thing. I'll give this a test on my home system and give a shout when I have.

Aug 20 2018, 4:35 PM · Frameworks

Aug 3 2018

adridg added a comment to T8122: Attend External Events 2018: Educode 2018.

Stuff we need

Aug 3 2018, 8:23 PM · KDE Edu, KDE Promo
adridg added a comment to T9305: Fwupd-Backend Integration on discover requires fwupd (https://github.com/hughsie/fwupd/).

.. the CMake error is because a55b13c3f3a5ba4ab081dbf5f0493d35a39a743c does not have an endif() added in the new if-clause.

Aug 3 2018, 10:13 AM · Discover Software Store, build.kde.org
adridg added a comment to T9305: Fwupd-Backend Integration on discover requires fwupd (https://github.com/hughsie/fwupd/).

I also spotted some discussion of this on IRC. I think the fwupd is now optional everywhere since a55b13c3f3a5ba4ab081dbf5f0493d35a39a743c . However, current git master gives me:

Aug 3 2018, 10:08 AM · Discover Software Store, build.kde.org

Jul 14 2018

adridg accepted D14070: Info page of torrent now shows Share ratio in format [-]9.9.

Looks sensible to me: when the ratio is small, 5.6E-4 is not very informative for many people, while 0.00056 might be (and with 2 places precision, I'd hope it becomes 0.00).

Jul 14 2018, 11:15 PM

Jul 3 2018

adridg added a comment to D13752: Build solidautoeject only on FreeBSD.
  • Start systemsettings; under *workspace*, *startup and shutdown*, find *background services*.
  • Untick the box for *Drive Ejector*; also check status is *not running*, click *stop* button if it is still running.
  • Insert CD, pick *open in file manager* from the device notifier popup
  • Check that it's mounted, from a konsole
  • Press button on CD drive: no result
  • Choose eject from device notifier: CD is ejected
Jul 3 2018, 9:36 AM · Plasma

Jun 27 2018

adridg added a comment to D13752: Build solidautoeject only on FreeBSD.

It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change; what I've written above is current behavior on FreeBSD 11 with Plasma 5.12.5; HAL is running.

Jun 27 2018, 11:06 AM · Plasma
adridg added a comment to D13752: Build solidautoeject only on FreeBSD.

Since the ticket is rather unclear on what functionality is being tested, or how:

Jun 27 2018, 10:58 AM · Plasma

Jun 22 2018

adridg committed R921:914d43cd8c1a: Catch up 10 months of news (authored by adridg).
Catch up 10 months of news
Jun 22 2018, 12:31 AM
adridg committed R921:d0211274a604: Mention that modern KDE is now in ports (authored by adridg).
Mention that modern KDE is now in ports
Jun 22 2018, 12:31 AM
adridg committed R921:8f003843a2ac: Update the people-list (authored by adridg).
Update the people-list
Jun 22 2018, 12:31 AM

Jun 4 2018

adridg updated the diff for D13328: A backend is required for kdnssd.

Use the right place (sorry Christophe, to use a Dutch phrase:
I must have been looking with my nose).

Jun 4 2018, 1:16 PM · Frameworks
adridg added inline comments to D13328: A backend is required for kdnssd.
Jun 4 2018, 11:48 AM · Frameworks
adridg created T8952: KDNSSD Backend missing on Windows.
Jun 4 2018, 11:19 AM · Windows, build.kde.org
adridg added a comment to D13328: A backend is required for kdnssd.

Something to consider, though, is that it might perhaps be useful to have kdnssd build -- without a backend -- for environments where there is no real dnssd and any service discovery returns "not found". Requiring a backend makes that impossible.

Jun 4 2018, 11:15 AM · Frameworks
adridg updated the test plan for D13328: A backend is required for kdnssd.
Jun 4 2018, 11:14 AM · Frameworks
adridg requested review of D13328: A backend is required for kdnssd.
Jun 4 2018, 11:13 AM · Frameworks
adridg requested review of D13327: Fix conversion error when compiled against MDNSRESPONDER option.
Jun 4 2018, 9:56 AM · Frameworks

Jun 3 2018

adridg added a comment to R286:3415015e3d45: check that ffmpeg is at least version 3.1 that introduce the API we require.

The FindFFmpeg CMake module uses pkg-config modversions to determine the overall version. These don't match the notion of "FFmpeg release 3.1" because the libraries are versioned separately. For instance:

Jun 3 2018, 1:24 PM

May 22 2018

adridg added a comment to D11235: Request change of ptrace scope from KCrash.

Comments directed at licensing and non-Linux cases.

May 22 2018, 9:41 AM · Plasma

Apr 27 2018

adridg added inline comments to D12174: FFMpeg plugin: port away from deprecated data structure.
Apr 27 2018, 7:39 PM
adridg added a comment to D12115: FFMpeg plugin cleanup.

What you could do, is to ask on the distributions@k.o list, to find out who ships what. FreeBSD, for instance, has /usr/local/lib/libavformat.so.57.83.100 so that looks like it would be ok. Debian stable, on the other hand ..

Apr 27 2018, 7:34 PM

Apr 24 2018

adridg committed R473:6d7433d44c7f: QTimer may not be an incomplete type as it is used as a member variable. Add… (authored by adridg).
QTimer may not be an incomplete type as it is used as a member variable. Add…
Apr 24 2018, 5:17 PM

Apr 15 2018

adridg added a comment to D12230: [WIP] Adjust socket buffer sizes on FreeBSD.

The real insight is in https://bugs.kde.org/show_bug.cgi?id=381850 from Alexandre Martins. I'm mostly messing around trying to auto-set the socketbuffer size correctly.

Apr 15 2018, 9:21 PM · KDE PIM
adridg added a comment to D12231: Reduce the number of zombies to a minimum.

Since you're using a global variable to accumulate ${numberOfProcesses} worth of po-files in one go, you should definitely clear out the variable when that bunch has been processed, or you'll grind through each po file more than once (with a growing command-list, too). You might consider the earlier version of the patch, which removes the global variable for a function parameter.

Apr 15 2018, 9:09 PM · Frameworks
adridg requested review of D12230: [WIP] Adjust socket buffer sizes on FreeBSD.
Apr 15 2018, 7:21 PM · KDE PIM

Apr 12 2018

adridg accepted D12136: Avoid hardcoding of filesystems supporting CoW.
Apr 12 2018, 8:25 AM · Baloo, Frameworks