adridg (Adriaan de Groot)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2016, 8:39 AM (145 w, 1 d)
Availability
Available

Recent Activity

Mon, Dec 10

adridg added inline comments to D17473: always print status info on vlc finding (even when not found).
Mon, Dec 10, 11:32 AM

Tue, Nov 27

adridg added a comment to T9953: Attend External Events 2018: Freenode#live.

Public blog posts about the event:

Tue, Nov 27, 10:39 AM · KDE Promo

Thu, Nov 22

adridg added a comment to D17071: Don't include any directory sizes in DirectorySizeJob.

With UFS, stat(1) tells me

Thu, Nov 22, 3:49 PM · Frameworks
adridg added a comment to D17070: Don't double-count size of directories in DirectorySizeJob.

With UFS, stat(1) tells me

Thu, Nov 22, 3:14 PM · Frameworks

Oct 30 2018

adridg added a comment to T9952: Attend External Events 2018: Embedded Linux Conference Europe: Post-mortem.

I think you're over-interpreting my comment about the video: it could use an update (can we agree on that? it doesn't show the current state of the phone).

Oct 30 2018, 1:17 PM · Plasma, KDE Promo
adridg added a comment to T9953: Attend External Events 2018: Freenode#live.

@davidedmundson : can you bring a monitor? since you're driving down that ought to fit. Although a different task says "giant monitor a must" I don't think we should do that last-minute here. Besides, the number of expected attendees is much lower than ELCE, so cost is a thing.

Oct 30 2018, 12:38 PM · KDE Promo
adridg triaged T9953: Attend External Events 2018: Freenode#live as Normal priority.
Oct 30 2018, 12:36 PM · KDE Promo
adridg added a comment to T9952: Attend External Events 2018: Embedded Linux Conference Europe: Post-mortem.

Lessons learned: watch the promo-video playing in the background beforehand, so you can talk about it. Check the video, too .. the PlaMo video has a bunch of art photos (naked!) and punk rock songs (naughty words in the title!) on the demo phone, as well as some personal information that is visible (someone's phone number!); not to mention using a cheesy pre-paid phone operator. So it might be updated.

Oct 30 2018, 12:19 PM · Plasma, KDE Promo
adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.

I sent my generally-positive review of the event to the -promo list. Materials have been sent to Dave for the next event.

Oct 30 2018, 11:02 AM · Plasma, KDE Promo

Oct 19 2018

adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.
  • Jon has a box of T-shirts, which we can sell at a pinch and also just wear for consistency (but let's not get stuck on that, and there's something to be said for KDE-in-diversity shirts, e.g. wear what you want)
  • I'll leave my SBCs at home, and just bring the pinebook and slimbook
Oct 19 2018, 11:10 AM · Plasma, KDE Promo
adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.
  • Do we have a dress code in mind for this? Like, KDE India T-shirts or similar? Polo shirts? I can just throw a bunch of KDE-branded clothes (for me) in the suitcase and see what happens, too.
  • None of my SBC's have (touch)screens unless you count the pinebook as one.
Oct 19 2018, 10:33 AM · Plasma, KDE Promo

Oct 15 2018

adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.

Business cards:

  • I'm going to use my (very) old ones, since neither my email nor my phone # has changed in all that time. I'll just scratch off "vice-president, KDE e.V.".
  • If we actually *have* a business card template (PDF? Scribus? Krita?) that can be adapted by others, it should go on community.k.o, right?
Oct 15 2018, 3:20 PM · Plasma, KDE Promo
adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.

Do we need a couple of these: https://www.staples.nl/reclamehouder-a4-schuin/cbs/2411073.html?promoCode=&Effort_Code=WW&Find_Number=2411073&m=0&isSubscription=False to clamp them in? Something to pick up on saturday at a random office-supplies store?

Oct 15 2018, 2:46 PM · Plasma, KDE Promo
adridg added a comment to T9649: Attend External Events 2018: Embedded Linux Conference Europe: Booth.

So those table signs, those would be clamped in those perspex-standy things so you can, for instance, set the "Pinebook" sign next to a Pinebook, pre-answering the "what's that?" question.

Oct 15 2018, 2:25 PM · Plasma, KDE Promo
adridg committed R119:fbcbab83b153: Remove author information at their request. (authored by adridg).
Remove author information at their request.
Oct 15 2018, 12:27 PM
adridg committed R492:ea54c3c5681e: Make it compile on FreeBSD (authored by adridg).
Make it compile on FreeBSD
Oct 15 2018, 11:13 AM
adridg committed R492:77d05a70fd5f: Missing includes for FreeBSD (authored by adridg).
Missing includes for FreeBSD
Oct 15 2018, 11:13 AM
adridg committed R492:c5886d81d631: Merge remote-tracking branch 'origin/frameworks' into topic-llvm+freebsd_ipv6 (authored by adridg).
Merge remote-tracking branch 'origin/frameworks' into topic-llvm+freebsd_ipv6
Oct 15 2018, 11:13 AM

Oct 6 2018

adridg committed R921:31b55468a297: Another four months of news (authored by adridg).
Another four months of news
Oct 6 2018, 10:00 PM
adridg committed R921:b18b0d6b61b6: Update some pointers: (authored by adridg).
Update some pointers:
Oct 6 2018, 10:00 PM

Sep 26 2018

adridg committed R357:821eb9ab34a5: Some more 0 -> nullptr changes. Now compiles without nullptr warnings with… (authored by adridg).
Some more 0 -> nullptr changes. Now compiles without nullptr warnings with…
Sep 26 2018, 10:44 AM

Sep 17 2018

adridg added a comment to T9477: Organizing KDE's presence at FOSDEM 2019.

I've put in a booth request now. No devroom, though -- that would take some non-zero coordination with GNOME or other desktops, and I don't think we have the time or energy for that just now.

Sep 17 2018, 4:30 PM · KDE Promo

Sep 4 2018

adridg added inline comments to D15072: [server] Abort drag start on correct conditions and without posting error.
Sep 4 2018, 6:02 PM · Frameworks
adridg added inline comments to D15072: [server] Abort drag start on correct conditions and without posting error.
Sep 4 2018, 1:30 PM · Frameworks
adridg added a comment to T9468: Develop Social Media Access Policy.

For *3B*, that's an attempt to quantify "you must be active in promo". Maybe it quantifies "you must be active in promo and do more than just push the button on social media accounts". I think *10* provides a mechanism to handle inactivity. Where exactly is the unfairness? Someone who takes on only high-effort tasks does more work to qualify for *3B*, but they could also do a low-effort one once, if the high-effort ones are all failing.

Sep 4 2018, 9:43 AM · KDE Promo

Aug 24 2018

adridg added a comment to T9468: Develop Social Media Access Policy.

Tangentially related: kde-promo mailing list administration. That doesn't give any posting power, at best it gives the power to filter out posts by non-members to that list (e.g. you can stop spam, and very very rarely stop actual mail from non-subscribers). Right now Lydia and I do that (small) bit of administration, but it should be added to the "things promo keeps track of".

Aug 24 2018, 10:48 PM · KDE Promo
adridg added a comment to T6352: Calamares: OEM support.

The neon part perhaps belongs here, but as a Calamares ticket it should be elsewhere.

Aug 24 2018, 7:18 PM · Neon
adridg committed R883:1523219: Fix up typo's. Reported by Paul..
Fix up typo's. Reported by Paul.
Aug 24 2018, 12:35 PM
adridg committed R883:1523218: Drop superfluous full stop.
Drop superfluous full stop
Aug 24 2018, 11:21 AM
adridg committed R883:1523217: Update text on the /contact/ page..
Update text on the /contact/ page.
Aug 24 2018, 11:16 AM

Aug 23 2018

adridg committed R883:1523185: Remove press contacts from translations..
Remove press contacts from translations.
Aug 23 2018, 9:52 PM
adridg committed R883:1523184: Drop all the regional representatives..
Drop all the regional representatives.
Aug 23 2018, 9:46 PM
adridg committed R883:1523177: Bogus commit to test if I can adapt www for -promo.
Bogus commit to test if I can adapt www for -promo
Aug 23 2018, 3:32 PM

Aug 21 2018

adridg added a comment to D14927: KConfig: handle directory symlinks correctly..

Sorry, this is getting very confusing:

Aug 21 2018, 10:26 AM · Frameworks

Aug 20 2018

adridg added a comment to D14927: KConfig: handle directory symlinks correctly..

Totals: 44 passed, 2 failed, 0 skipped, 0 blacklisted, 225ms

Aug 20 2018, 9:01 PM · Frameworks
adridg added a comment to D14927: KConfig: handle directory symlinks correctly..

This shows up in the unit tests. Whether it has any effect in real life is unknown. FreeBSD often -- sometimes, maybe, depending on FS setup and layout -- has /home -> /usr/home or /home -> usr/home, and of course there could be weird user setups as well where .cache is symlinked to a different location with more disk space. In any case, this is triggering unit-test failures in the CI, so cleaning it up to consistently compare the same kind of filename is a good thing. I'll give this a test on my home system and give a shout when I have.

Aug 20 2018, 4:35 PM · Frameworks

Aug 3 2018

adridg added a comment to T8122: Attend External Events 2018: Educode 2018.

Stuff we need

Aug 3 2018, 8:23 PM · KDE Edu, KDE Promo
adridg added a comment to T9305: Fwupd-Backend Integration on discover requires fwupd (https://github.com/hughsie/fwupd/).

.. the CMake error is because a55b13c3f3a5ba4ab081dbf5f0493d35a39a743c does not have an endif() added in the new if-clause.

Aug 3 2018, 10:13 AM · Discover Software Store, build.kde.org
adridg added a comment to T9305: Fwupd-Backend Integration on discover requires fwupd (https://github.com/hughsie/fwupd/).

I also spotted some discussion of this on IRC. I think the fwupd is now optional everywhere since a55b13c3f3a5ba4ab081dbf5f0493d35a39a743c . However, current git master gives me:

Aug 3 2018, 10:08 AM · Discover Software Store, build.kde.org

Jul 14 2018

adridg accepted D14070: Info page of torrent now shows Share ratio in format [-]9.9.

Looks sensible to me: when the ratio is small, 5.6E-4 is not very informative for many people, while 0.00056 might be (and with 2 places precision, I'd hope it becomes 0.00).

Jul 14 2018, 11:15 PM

Jul 3 2018

adridg added a comment to D13752: Build solidautoeject only on FreeBSD.
  • Start systemsettings; under *workspace*, *startup and shutdown*, find *background services*.
  • Untick the box for *Drive Ejector*; also check status is *not running*, click *stop* button if it is still running.
  • Insert CD, pick *open in file manager* from the device notifier popup
  • Check that it's mounted, from a konsole
  • Press button on CD drive: no result
  • Choose eject from device notifier: CD is ejected
Jul 3 2018, 9:36 AM · Plasma

Jun 27 2018

adridg added a comment to D13752: Build solidautoeject only on FreeBSD.

It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change; what I've written above is current behavior on FreeBSD 11 with Plasma 5.12.5; HAL is running.

Jun 27 2018, 11:06 AM · Plasma
adridg added a comment to D13752: Build solidautoeject only on FreeBSD.

Since the ticket is rather unclear on what functionality is being tested, or how:

Jun 27 2018, 10:58 AM · Plasma

Jun 22 2018

adridg committed R921:914d43cd8c1a: Catch up 10 months of news (authored by adridg).
Catch up 10 months of news
Jun 22 2018, 12:31 AM
adridg committed R921:d0211274a604: Mention that modern KDE is now in ports (authored by adridg).
Mention that modern KDE is now in ports
Jun 22 2018, 12:31 AM
adridg committed R921:8f003843a2ac: Update the people-list (authored by adridg).
Update the people-list
Jun 22 2018, 12:31 AM

Jun 4 2018

adridg updated the diff for D13328: A backend is required for kdnssd.

Use the right place (sorry Christophe, to use a Dutch phrase:
I must have been looking with my nose).

Jun 4 2018, 1:16 PM · Frameworks
adridg added inline comments to D13328: A backend is required for kdnssd.
Jun 4 2018, 11:48 AM · Frameworks
adridg created T8952: KDNSSD Backend missing on Windows.
Jun 4 2018, 11:19 AM · Windows, build.kde.org
adridg added a comment to D13328: A backend is required for kdnssd.

Something to consider, though, is that it might perhaps be useful to have kdnssd build -- without a backend -- for environments where there is no real dnssd and any service discovery returns "not found". Requiring a backend makes that impossible.

Jun 4 2018, 11:15 AM · Frameworks
adridg updated the test plan for D13328: A backend is required for kdnssd.
Jun 4 2018, 11:14 AM · Frameworks
adridg requested review of D13328: A backend is required for kdnssd.
Jun 4 2018, 11:13 AM · Frameworks
adridg requested review of D13327: Fix conversion error when compiled against MDNSRESPONDER option.
Jun 4 2018, 9:56 AM · Frameworks

Jun 3 2018

adridg added a comment to R286:3415015e3d45: check that ffmpeg is at least version 3.1 that introduce the API we require.

The FindFFmpeg CMake module uses pkg-config modversions to determine the overall version. These don't match the notion of "FFmpeg release 3.1" because the libraries are versioned separately. For instance:

Jun 3 2018, 1:24 PM

May 22 2018

adridg added a comment to D11235: [DrKonqi] Request change of ptrace scope from KCrash.

Comments directed at licensing and non-Linux cases.

May 22 2018, 9:41 AM · Plasma

Apr 27 2018

adridg added inline comments to D12174: FFMpeg plugin: port away from deprecated data structure.
Apr 27 2018, 7:39 PM
adridg added a comment to D12115: FFMpeg plugin cleanup.

What you could do, is to ask on the distributions@k.o list, to find out who ships what. FreeBSD, for instance, has /usr/local/lib/libavformat.so.57.83.100 so that looks like it would be ok. Debian stable, on the other hand ..

Apr 27 2018, 7:34 PM

Apr 24 2018

adridg committed R473:6d7433d44c7f: QTimer may not be an incomplete type as it is used as a member variable. Add… (authored by adridg).
QTimer may not be an incomplete type as it is used as a member variable. Add…
Apr 24 2018, 5:17 PM

Apr 15 2018

adridg added a comment to D12230: [WIP] Adjust socket buffer sizes on FreeBSD.

The real insight is in https://bugs.kde.org/show_bug.cgi?id=381850 from Alexandre Martins. I'm mostly messing around trying to auto-set the socketbuffer size correctly.

Apr 15 2018, 9:21 PM · KDE PIM
adridg added a comment to D12231: Reduce the number of zombies to a minimum.

Since you're using a global variable to accumulate ${numberOfProcesses} worth of po-files in one go, you should definitely clear out the variable when that bunch has been processed, or you'll grind through each po file more than once (with a growing command-list, too). You might consider the earlier version of the patch, which removes the global variable for a function parameter.

Apr 15 2018, 9:09 PM · Frameworks
adridg requested review of D12230: [WIP] Adjust socket buffer sizes on FreeBSD.
Apr 15 2018, 7:21 PM · KDE PIM

Apr 12 2018

adridg accepted D12136: Avoid hardcoding of filesystems supporting CoW.
Apr 12 2018, 8:25 AM · Baloo, Frameworks
adridg accepted D12135: Allow disabling of CoW to fail when not supported by filesystem.

Accepted as "doesn't hurt the non-Linux crowd, since they all live in the #ifndef Q_OS_LINUX branch"

Apr 12 2018, 8:24 AM · Baloo, Frameworks
adridg added a comment to D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem()..

Given the other reviews (which just drop this function), this one should be abandoned. tcberner@?

Apr 12 2018, 8:10 AM · Baloo, Frameworks

Apr 9 2018

adridg added a comment to D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem()..

The question is mostly: does the existing (complicated) code do anything that QStorageInfo doesn't? Because switching to QStorageInfo gives us the functionality on FreeBSD for free (even if it's not useful because we'll never have btrfs).

Apr 9 2018, 9:09 PM · Baloo, Frameworks

Apr 3 2018

adridg created T8410: Calamares (pre-install).
Apr 3 2018, 9:53 AM · KDE Neon : bionic

Feb 25 2018

adridg accepted D10823: idutils: Fix typo.

I'm so happy :)

Feb 25 2018, 12:33 PM · Frameworks, Baloo

Feb 23 2018

adridg added a comment to T8054: Change DocumentID.

To assess the problem, you could static_assert that st_dev and st_ino are size 4 or less. That would tell you if any system right now is losing information. (Typo in the comment in statBufToId() btw).

Feb 23 2018, 1:53 PM · Baloo

Feb 21 2018

adridg added inline comments to D10661: indexerconfig: Expose canBeSearched function.
Feb 21 2018, 9:17 AM · Baloo, Frameworks
adridg added inline comments to D10662: indexerconfig: Describe some functions.
Feb 21 2018, 8:57 AM · Baloo, Frameworks

Feb 20 2018

adridg added a comment to D10683: Fix compilation on Qt 5.6.

@rominf was debugging this on IRC. In Qt 5.7, the QAction constructor gained a default value for explicit QAction(QObject *parent = nullptr);. It did not have this in Qt 5.6. This patch adds the argument to the constructor, so that Spectacle compiles with Qt 5.6. An alternative would be to bump the Qt requirement to 5.7, but that leaves LTS distro's in the cold (actually, Spectacle's CMakeLists requires Qt 5.4).

Feb 20 2018, 3:55 PM · Spectacle

Feb 12 2018

adridg added a comment to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

"This (hopefully) fixes the build failure noticed in the FreeBSD (and some linuxes)" - leaves the question: why should it exactly fix it? :)

Feb 12 2018, 8:53 AM · Frameworks
adridg added a comment to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

Associated bug https://bugs.kde.org/show_bug.cgi?id=389982

Feb 12 2018, 8:41 AM · Frameworks

Jan 27 2018

adridg added inline comments to D9713: Add script to unlock a broken session via ConsoleKit..
Jan 27 2018, 5:18 PM · Plasma

Jan 16 2018

adridg closed D7573: The OLD behavior of CMP0002 doesn't seem to be needed..

Already done by @staniek

Jan 16 2018, 3:24 PM · KDb
adridg closed D7574: The OLD behavior of CMP0022 doesn't seem to be needed..

Already done by @staniek

Jan 16 2018, 3:24 PM · KDb
adridg committed R169:8a233471fc54: Update human-readable tier designation in API dox (authored by adridg).
Update human-readable tier designation in API dox
Jan 16 2018, 3:21 PM
adridg closed D7681: Update human-readable tier designation in API dox.
Jan 16 2018, 3:21 PM · Kirigami

Dec 8 2017

adridg added a comment to D9076: Have an application that can cross-check if the promised platforms are correct.

To understand the expected output better: suppose something says "platforms: All", like kcontacts. If there's no actual build configured in CI for that something, for FreeBSD, it will say "FreeBS is a disabled platform". The message can probably be improved, then. And how about checking the reverse, too? CI builds that are not listed in the metainfo? (if that can even happen)

Dec 8 2017, 10:12 AM

Dec 6 2017

adridg accepted D8932: make docbook compilation optional.
Dec 6 2017, 6:30 PM
adridg accepted D8931: derive app version from kde applications release.

Seems sensible from a packaging and release standpoint, so I'll say "LGTM", but I don't really like it from an application-versioning standpoint since releases happen regularly regardless of changes in the application itself.

Dec 6 2017, 6:25 PM

Dec 5 2017

adridg accepted D8941: do not misuse QGroupBox as a layout helper, instead use a layout directly.

LGTM. Better in Breeze (there's a little less padding before the radio buttons), Fusion and Win95 themes.

Dec 5 2017, 5:32 PM

Dec 3 2017

adridg abandoned D9149: Allow running the tool without a display.

Careful use of -platform minimal allows running the tool with no changes to the code or kcm.

Dec 3 2017, 5:20 PM · Plasma
adridg added a reviewer for D9149: Allow running the tool without a display: mart.
Dec 3 2017, 5:03 PM · Plasma
adridg created D9149: Allow running the tool without a display.
Dec 3 2017, 4:59 PM · Plasma

Nov 30 2017

adridg added a comment to T6831: Top-notch usability and productivity for basic software.

We should be cautious in mixing up what Calamares (not a KDE project) does with what the desktop environment might do. For background, Calamares can be used in two ways:

  • as a system installer; you boot a live CD or memory stick, and install some (Linux) system to a hard disk
  • as a system configurator; you boot a newly purchased laptop and it starts into a "newuser" which reconfigures the system with the user preferences (and login name) you give
Nov 30 2017, 4:21 PM · Goal settings 2017

Nov 22 2017

adridg added a comment to M116: Calamares Telemetry Page Design suggestion.

Here's what it looks like in the implementation.

Nov 22 2017, 12:18 PM · Plasma
adridg added a comment to M116: Calamares Telemetry Page Design suggestion.

There's a bit of a background here -- and thanks, Jens, for mocking something up and thanks Andy for thinking along on the actual text. Calamares is used by various distro's. Some want it to phone home at the end of installation. Some, like Debian derivatives, have the Debian machine-tracking stuff which can be enabled/disabled. Some could enable KDE's User Tracking stuff that Volker was working on over the summer. So there are quite some technical differences between the options -- we can hide all that in the descriptions (behind the ? button) I suppose. I use "tracking" because that's the kind of scary word *I* want to see, encouraging me to turn it off -- I can totally understand using a more friendly word on the distro's side, who want people to turn it *on*.

Nov 22 2017, 10:29 AM · Plasma

Nov 7 2017

adridg added inline comments to D8695: Fix ampersand characters not showing in tab titles.
Nov 7 2017, 3:21 PM · Plasma
adridg committed R106:1f8fec738573: Add .arcconfig (authored by adridg).
Add .arcconfig
Nov 7 2017, 3:11 PM
adridg closed D8694: Add .arcconfig.
Nov 7 2017, 3:11 PM · Plasma
adridg created D8694: Add .arcconfig.
Nov 7 2017, 3:10 PM · Plasma

Nov 2 2017

adridg committed R345:35700970e790: Add .arcconfig (authored by adridg).
Add .arcconfig
Nov 2 2017, 10:07 AM
adridg created D8614: Fix up warning when mixer id is empty..
Nov 2 2017, 10:05 AM

Oct 3 2017

adridg committed R16:63b501f41ddc: Tests: simple listing of attached devices (authored by adridg).
Tests: simple listing of attached devices
Oct 3 2017, 9:59 AM
adridg committed R16:98caf8442490: Docs: change parameter name to match intention. (authored by adridg).
Docs: change parameter name to match intention.
Oct 3 2017, 9:59 AM
adridg committed R16:c4ae5d680c0f: Docs: document Device (a description) and CoreBackendDevice (an operational… (authored by adridg).
Docs: document Device (a description) and CoreBackendDevice (an operational…
Oct 3 2017, 9:59 AM

Oct 2 2017

adridg committed R16:12ee62d393d3: Tests: fixup license headers, code style (authored by adridg).
Tests: fixup license headers, code style
Oct 2 2017, 3:17 PM
adridg committed R16:41b835ba4678: Docs: add a README, explain high-level usage (authored by adridg).
Docs: add a README, explain high-level usage
Oct 2 2017, 2:35 PM
adridg committed R16:f1dee860844d: Tests: initial test in initializing lib and loading a backend (authored by adridg).
Tests: initial test in initializing lib and loading a backend
Oct 2 2017, 2:35 PM