adridg (Adriaan de Groot)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2016, 8:39 AM (189 w, 3 d)
Availability
Available

Recent Activity

Today

adridg added a subtask for T8043: Attend External Events: T11835: Organizing KDE's presence at FOSDEM 2020.
Tue, Oct 22, 1:36 PM · KDE Promo
adridg added a parent task for T11835: Organizing KDE's presence at FOSDEM 2020: T8043: Attend External Events.
Tue, Oct 22, 1:36 PM
adridg added a parent task for T11836: Organizing KDE's presence at GNU Health 2019: T8043: Attend External Events.
Tue, Oct 22, 1:36 PM
adridg added a subtask for T8043: Attend External Events: T11836: Organizing KDE's presence at GNU Health 2019.
Tue, Oct 22, 1:36 PM · KDE Promo

Sun, Oct 20

adridg added a comment to D24604: Fix compilation with clang.

(also change is obsolete and should be abandoned)

Sun, Oct 20, 6:33 PM
adridg added a comment to D24604: Fix compilation with clang.

Commit ae4027d640d3297e78d8d0c87389aade128476a5 fixes the problem in a different way, by changing QList<T> parameters to QVector<T>.

Sun, Oct 20, 6:32 PM

Fri, Oct 18

adridg accepted D24750: Fix reading environment variables with newline.

Looked for -0 alternatives, couldn't find any. Dave tells me there's sufficient fallbacks, and otherwise we'll just patch it out in packaging.

Fri, Oct 18, 12:24 PM · Plasma

Thu, Oct 17

adridg accepted D21146: KProcessInfoList -- add proclist backend for FreeBSD.

Let's get this in, and then quibble about how much commentary needs to be written for the _p.h file (since, looking back, it's a bit heavy on the C++ fancyness -- my Opinions have changed a little)

Thu, Oct 17, 2:21 PM · Frameworks

Fri, Oct 11

adridg added inline comments to D24431: Restore cursor thumbnailer.
Fri, Oct 11, 12:32 PM · Frameworks, Dolphin

Tue, Oct 8

ognarb awarded T11836: Organizing KDE's presence at GNU Health 2019 a Love token.
Tue, Oct 8, 5:18 PM
adridg created T11836: Organizing KDE's presence at GNU Health 2019.
Tue, Oct 8, 10:08 AM

Mon, Oct 7

adridg added a comment to T11835: Organizing KDE's presence at FOSDEM 2020.

(Assigned to Ivana because she had the FOSDEM 2019 one, but that shouldn't mean that this is her job)

Mon, Oct 7, 9:58 PM
adridg created T11835: Organizing KDE's presence at FOSDEM 2020.
Mon, Oct 7, 9:57 PM

Tue, Sep 24

adridg added a comment to T11735: 2019/20 focus: Gain clarity on KDE’s role in environmental sustainability.
Tue, Sep 24, 2:34 PM · KDE e.V.
adridg accepted D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid.

LGTM on the FreeBSD side (I've checked, the procctl() code does block debugger access which is all we're asking to do).

Tue, Sep 24, 12:36 PM · Frameworks

Mon, Sep 23

adridg requested review of D24155: On non-Linux, findBlkIdDevice() has unused parameters.
Mon, Sep 23, 8:38 AM

Sep 20 2019

adridg added a comment to T11651: Register new board.
  • sent
Sep 20 2019, 7:43 PM · KDE e.V.
adridg added a comment to T11652: update websites with new board.

Adriaan de Groot
groot@kde.org

Sep 20 2019, 7:29 PM · KDE e.V.

Sep 12 2019

adridg committed R857:22cc1cabe08e: FreeBSD: shuffle documentation (authored by adridg).
FreeBSD: shuffle documentation
Sep 12 2019, 10:08 AM

Aug 25 2019

adridg requested review of D23453: Remove NX support.
Aug 25 2019, 7:46 PM

Aug 22 2019

adridg committed R73:fa1b60e86789: Merge branch 'improved-graph-ide-debugger' into 'master' (authored by adridg).
Merge branch 'improved-graph-ide-debugger' into 'master'
Aug 22 2019, 1:26 PM
adridg committed R244:8e34c0b97393: Q_UNUSED doesn't need a ; after it. (authored by adridg).
Q_UNUSED doesn't need a ; after it.
Aug 22 2019, 10:21 AM
adridg closed D23335: Q_UNUSED doesn't need a ; after it..
Aug 22 2019, 10:21 AM · Frameworks
adridg requested review of D23338: Use baseFactory for K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL.
Aug 22 2019, 10:02 AM · Frameworks
adridg requested review of D23335: Q_UNUSED doesn't need a ; after it..
Aug 22 2019, 8:45 AM · Frameworks

Aug 15 2019

adridg requested review of D23164: Improve testPrintD.
Aug 15 2019, 12:09 AM · Okular

Aug 13 2019

adridg committed R73:4f23481b14e0: Merge branch 'improved-graph-ide-self-edges-removal' into 'master' (authored by adridg).
Merge branch 'improved-graph-ide-self-edges-removal' into 'master'
Aug 13 2019, 2:04 PM
adridg committed R73:1c49dee0614c: Merge branch 'improved-graph-ide-examples' into 'master' (authored by adridg).
Merge branch 'improved-graph-ide-examples' into 'master'
Aug 13 2019, 2:03 PM
adridg committed R73:1bb8ad20d618: Merge branch 'fix-off-canvas' into 'master' (authored by adridg).
Merge branch 'fix-off-canvas' into 'master'
Aug 13 2019, 2:02 PM
adridg committed R73:1d6a9d539f4c: Merge branch 'fix-project-test' into 'master' (authored by adridg).
Merge branch 'fix-project-test' into 'master'
Aug 13 2019, 2:01 PM

Aug 10 2019

adridg requested review of D23076: Fix build with CMake 3.15.
Aug 10 2019, 7:54 PM

Jul 30 2019

adridg committed R264:3cdc020b1b1e: Log bad pathnames (via repr()) instead of crashing entirely (authored by adridg).
Log bad pathnames (via repr()) instead of crashing entirely
Jul 30 2019, 9:26 PM
adridg committed R89:aa4684a6e244: Fix metainfo.yaml (authored by adridg).
Fix metainfo.yaml
Jul 30 2019, 8:50 PM

Jul 29 2019

adridg committed R73:4922b8675de3: CMake: Qt requires C++11, we should make that explicit (authored by adridg).
CMake: Qt requires C++11, we should make that explicit
Jul 29 2019, 8:04 AM
adridg committed R73:99eabbc06dbe: CMake: minimum cmake version should be set first (authored by adridg).
CMake: minimum cmake version should be set first
Jul 29 2019, 8:04 AM

Jul 28 2019

adridg committed R73:1c2b2b3fc388: Fix Project test: change the test itself (authored by adridg).
Fix Project test: change the test itself
Jul 28 2019, 10:15 PM
adridg committed R73:e11b95b56ae0: Fix Project test: double-check code document paths in loadSave test (authored by adridg).
Fix Project test: double-check code document paths in loadSave test
Jul 28 2019, 10:15 PM
adridg committed R73:055eb0528bee: Fix Project test: add logging (authored by adridg).
Fix Project test: add logging
Jul 28 2019, 10:15 PM

Jul 27 2019

adridg committed R73:5901f5917502: Fix rocs1fileformattest: consider all default edge types "known" (authored by adridg).
Fix rocs1fileformattest: consider all default edge types "known"
Jul 27 2019, 8:48 PM
adridg committed R73:8e85e3b79153: Fix rocs1fileformattest: add logging (authored by adridg).
Fix rocs1fileformattest: add logging
Jul 27 2019, 8:48 PM
adridg committed R73:55c13cc13a05: Fix tgfformattest: check the default edge type is unidirectional (authored by adridg).
Fix tgfformattest: check the default edge type is unidirectional
Jul 27 2019, 8:48 PM
adridg committed R73:271fcdfa2cd5: Fix tgffileformat test: add logging (authored by adridg).
Fix tgffileformat test: add logging
Jul 27 2019, 8:48 PM
adridg committed R73:0f436478fbd1: Fix tgffileformat test: make unidirectional the first edge type (authored by adridg).
Fix tgffileformat test: make unidirectional the first edge type
Jul 27 2019, 8:48 PM
adridg committed R73:6cd9ba95c527: Fix generated graphs being off the canvas (2) (authored by adridg).
Fix generated graphs being off the canvas (2)
Jul 27 2019, 12:01 PM
adridg committed R73:883fca57bace: Fix re-layout after generating Random Tree and Random DAG (authored by adridg).
Fix re-layout after generating Random Tree and Random DAG
Jul 27 2019, 12:01 PM
adridg committed R73:84419661dfc4: Don't translate if min* is positive on one axis. (authored by adridg).
Don't translate if min* is positive on one axis.
Jul 27 2019, 12:01 PM
adridg committed R73:12e495a7c1e8: Use qreal for the coordinate minima. (authored by adridg).
Use qreal for the coordinate minima.
Jul 27 2019, 12:01 PM
adridg committed R73:f8319560ea8a: Fix generated graphs being off the canvas. (authored by adridg).
Fix generated graphs being off the canvas.
Jul 27 2019, 12:01 PM
adridg committed R73:0afd405da25d: Merge branch 'reduce-warnings' into 'master' (authored by adridg).
Merge branch 'reduce-warnings' into 'master'
Jul 27 2019, 8:13 AM

Jul 26 2019

adridg committed R296:2d39e2f0ad56: Docs: fix bad example code (authored by adridg).
Docs: fix bad example code
Jul 26 2019, 8:39 PM
adridg closed D22765: Docs: fix bad example code.
Jul 26 2019, 8:39 PM · Frameworks
adridg committed R73:c9122096c1de: Check KDeclarative version to adjust to deprecation warnings. (authored by adridg).
Check KDeclarative version to adjust to deprecation warnings.
Jul 26 2019, 3:28 PM
adridg committed R73:c91c7b4e59f7: Reduce (clang) warnings about unused parameters. (authored by adridg).
Reduce (clang) warnings about unused parameters.
Jul 26 2019, 3:28 PM
adridg committed R73:6ac877ab13d2: Reduce warnings by giving labels different names (authored by adridg).
Reduce warnings by giving labels different names
Jul 26 2019, 3:28 PM
adridg requested review of D22765: Docs: fix bad example code.
Jul 26 2019, 3:15 PM · Frameworks
adridg committed R73:6d420b2d86b2: Fix links in the developer documentation. (authored by adridg).
Fix links in the developer documentation.
Jul 26 2019, 11:29 AM
adridg committed R73:8613ddfb9add: Fix filenames in Licensing information (authored by adridg).
Fix filenames in Licensing information
Jul 26 2019, 11:29 AM
adridg committed R73:58235a41199c: Improve README (authored by adridg).
Improve README
Jul 26 2019, 11:29 AM
adridg committed R73:cd6f92c55eec: Fix links in Mainpage (authored by adridg).
Fix links in Mainpage
Jul 26 2019, 11:29 AM
adridg committed R73:de4967f6165f: Fix git clone URL (it's now on invent.k.o) (authored by adridg).
Fix git clone URL (it's now on invent.k.o)
Jul 26 2019, 11:29 AM

Jul 25 2019

adridg committed R73:cc06ef652124: Merge branch 'improved-graph-ide-tree-dag' into 'master' (authored by adridg).
Merge branch 'improved-graph-ide-tree-dag' into 'master'
Jul 25 2019, 6:23 PM

Jul 7 2019

adridg committed R73:fd62ddc968f4: Improve INSTALL.md with better links (authored by adridg).
Improve INSTALL.md with better links
Jul 7 2019, 12:28 PM

Jul 2 2019

adridg committed R954:2a0bd1458f67: Update feed source, now that I've switched to Jekyll and fixed the hosting (authored by adridg).
Update feed source, now that I've switched to Jekyll and fixed the hosting
Jul 2 2019, 3:21 PM

Jun 23 2019

adridg added inline comments to D21146: KProcessInfoList -- add proclist backend for FreeBSD.
Jun 23 2019, 10:01 PM · Frameworks

May 20 2019

adridg abandoned D21305: Add the FreeBSD default-path for os-release..

Thanks for looking at this, Harald. For various downstream packaging reasons, we're going to be stuck with patching, so I'm going to give up on this particular patch.

May 20 2019, 7:32 PM · Frameworks
adridg updated the test plan for D21305: Add the FreeBSD default-path for os-release..
May 20 2019, 1:13 PM · Frameworks
adridg updated the test plan for D21305: Add the FreeBSD default-path for os-release..
May 20 2019, 1:12 PM · Frameworks
adridg requested review of D21305: Add the FreeBSD default-path for os-release..
May 20 2019, 1:11 PM · Frameworks

May 16 2019

adridg accepted D21245: KAr::openArchive: Also check ar_longnamesIndex is not < 0.

ar_longnamesIndex is used as an array-index into ar_longnames, which is new[]ed, so a negative index is UB. This patch voids that case.

May 16 2019, 8:27 PM · Frameworks

May 13 2019

adridg added inline comments to D21146: KProcessInfoList -- add proclist backend for FreeBSD.
May 13 2019, 8:29 PM · Frameworks

Apr 14 2019

adridg requested review of D20562: Use (better) path to libICE when doing check_library_exists..
Apr 14 2019, 10:51 PM · Plasma

Apr 11 2019

adridg added a comment to T10580: Organise Promo Sprint 2019.

I pretty much burned out of promo after QtWS. I have Opinions, but not necessarily the desire or energy to share them. I have a thing june 4/5th, and wasn't planning on going to onboarding,; outside of that I'm generally available, but don't let anything depend on me. (editedchanged date on my existing event)

Apr 11 2019, 6:13 PM · KDE Promo

Apr 5 2019

adridg added a comment to D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code..

I'd start to think about three separate files , unix_impl.cpp, windows_impl.cpp, stub_impl.cpp (although then you get API-syncing issues, probably, when only one of them is updated).

Apr 5 2019, 3:23 PM · Baloo, Frameworks

Apr 3 2019

adridg added a comment to T10755: Unifying Applications' release versions.

So there's subtask extract version information from CMakeLists.txt, which implies a few things:

  • going over the applications to check that they actually do set their version in the top-level CMakeLists, as part of the project() command,
  • check that tooling uses that version consistently,
  • check that the tooling can provide the version information everywhere it's needed.
Apr 3 2019, 8:17 AM

Mar 26 2019

adridg added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

On FreeBSD, /proc is not necessarily mounted (it might be a Linuxism). So while I do have /proc, it's empty because procfs isn't mounted there. If I do mount it, then there's the expected list of processes and a curproc symlink. But /proc/<pid> doesn't contain a stat file .. there's a status, though. Let me mess around a bit with that... yes, changing to status makes all 6 tests pass. So I'd suggest something like

Mar 26 2019, 12:52 PM · Frameworks
adridg added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

Config: Using QtTest library 5.12.1, Qt 5.12.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 6.0.1 (tags/RELEASE_601/final 335540))
PASS : KProcessListTest::initTestCase()

Mar 26 2019, 12:27 PM · Frameworks

Feb 8 2019

adridg created T10458: Olimex Teres Laptop.
Feb 8 2019, 12:29 PM
adridg created T10457: Pinebook.
Feb 8 2019, 12:26 PM
adridg created T10456: Board Bring-Up.
Feb 8 2019, 12:25 PM

Jan 24 2019

adridg added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

With my Calamares maintainer hat on: the decision to live outside of the KDE umbrella was taken before my time, but is basically this: make sure that the installer is seen as a desktop- and sitro-neutral approach, even when it uses KDE technologies. It's an installer for a whole bunch of distro flavors, although it's also enthusiastically used by a bunch of KDE-showcase distro's. I don't want it tied to only the KDE-showcases though.

Jan 24 2019, 10:50 AM · KDE Promo
adridg added a comment to T6351: calamares: wayland.

This has been filed upstream, continues to be unresolved (needs a bunch of kauth work, presumably). It is also an issue with: the webviewmodule, which doesn't run as root because the browser component crashes.

Jan 24 2019, 10:08 AM · Neon
adridg added a comment to T6601: calamares: driver-manager in installer.

Please file this upstream as appropriate. Probably you can get this done via the packages module, but anything more specific should be discussed elsewhere and have a design attached.

Jan 24 2019, 10:07 AM · Neon
adridg added a comment to T9376: calamares by default.

Please file everything upstream as needed.

Jan 24 2019, 10:05 AM · Neon

Jan 18 2019

adridg added a comment to T10372: Attend External Events: List of events to attend.

Similar list as @broulik

Jan 18 2019, 9:23 PM · KDE Promo

Jan 2 2019

adridg updated the diff for D17933: Fix visibility (and build on FreeBSD).

Put export in conventional spot.

Jan 2 2019, 11:06 PM
adridg requested review of D17933: Fix visibility (and build on FreeBSD).
Jan 2 2019, 10:55 PM
adridg requested review of D17931: Fix build on FreeBSD..
Jan 2 2019, 10:19 PM · Kopete

Dec 25 2018

adridg committed R102:39ede9c7e64b: Update logic for disabling the PCI module. (authored by adridg).
Update logic for disabling the PCI module.
Dec 25 2018, 3:08 PM
adridg closed D17785: Update logic for disabling the PCI module..
Dec 25 2018, 3:08 PM · Plasma

Dec 24 2018

adridg requested review of D17785: Update logic for disabling the PCI module..
Dec 24 2018, 9:04 PM · Plasma

Dec 22 2018

adridg committed R466:06d54c931045: Don't delete what was new[]'ed (authored by adridg).
Don't delete what was new[]'ed
Dec 22 2018, 4:14 PM
adridg closed D17736: Don't delete what was new[]'ed.
Dec 22 2018, 4:14 PM
adridg committed R466:c40e3c17d90b: Don't assume someone else pulls in errno.h (authored by adridg).
Don't assume someone else pulls in errno.h
Dec 22 2018, 4:12 PM
adridg closed D17735: Don't assume someone else pulls in errno.h.
Dec 22 2018, 4:12 PM
adridg updated the diff for D17736: Don't delete what was new[]'ed.

See if arc diff HEAD^ does what I wanted.

Dec 22 2018, 3:31 PM
adridg updated the summary of D17736: Don't delete what was new[]'ed.
Dec 22 2018, 3:30 PM
adridg added a reviewer for D17735: Don't assume someone else pulls in errno.h: mauroc.
Dec 22 2018, 3:25 PM
adridg added a reviewer for D17736: Don't delete what was new[]'ed: mauroc.

This one accidentally also contains the changes from D17735

Dec 22 2018, 3:24 PM
adridg requested review of D17736: Don't delete what was new[]'ed.
Dec 22 2018, 3:22 PM
adridg requested review of D17735: Don't assume someone else pulls in errno.h.
Dec 22 2018, 3:18 PM