adridg (Adriaan de Groot)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2016, 8:39 AM (103 w, 13 h)
Availability
Available

Recent Activity

Yesterday

adridg added a comment to T8054: Change DocumentID.

To assess the problem, you could static_assert that st_dev and st_ino are size 4 or less. That would tell you if any system right now is losing information. (Typo in the comment in statBufToId() btw).

Fri, Feb 23, 1:53 PM · Baloo

Wed, Feb 21

adridg added inline comments to D10661: indexerconfig: Expose canBeSearched function.
Wed, Feb 21, 9:17 AM · Baloo, Frameworks
adridg added inline comments to D10662: indexerconfig: Describe some functions.
Wed, Feb 21, 8:57 AM · Baloo, Frameworks

Tue, Feb 20

adridg added a comment to D10683: Fix compilation on Qt 5.6.

@rominf was debugging this on IRC. In Qt 5.7, the QAction constructor gained a default value for explicit QAction(QObject *parent = nullptr);. It did not have this in Qt 5.6. This patch adds the argument to the constructor, so that Spectacle compiles with Qt 5.6. An alternative would be to bump the Qt requirement to 5.7, but that leaves LTS distro's in the cold (actually, Spectacle's CMakeLists requires Qt 5.4).

Tue, Feb 20, 3:55 PM · Spectacle

Mon, Feb 12

adridg added a comment to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

"This (hopefully) fixes the build failure noticed in the FreeBSD (and some linuxes)" - leaves the question: why should it exactly fix it? :)

Mon, Feb 12, 8:53 AM · Frameworks
adridg added a comment to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

Associated bug https://bugs.kde.org/show_bug.cgi?id=389982

Mon, Feb 12, 8:41 AM · Frameworks

Sat, Jan 27

adridg added inline comments to D9713: Add script to unlock a broken session via ConsoleKit..
Sat, Jan 27, 5:18 PM · Plasma

Jan 16 2018

adridg closed D7573: The OLD behavior of CMP0002 doesn't seem to be needed..

Already done by @staniek

Jan 16 2018, 3:24 PM · KDb
adridg closed D7574: The OLD behavior of CMP0022 doesn't seem to be needed..

Already done by @staniek

Jan 16 2018, 3:24 PM · KDb
adridg committed R169:8a233471fc54: Update human-readable tier designation in API dox (authored by adridg).
Update human-readable tier designation in API dox
Jan 16 2018, 3:21 PM
adridg closed D7681: Update human-readable tier designation in API dox.
Jan 16 2018, 3:21 PM · Kirigami

Dec 8 2017

adridg added a comment to D9076: Have an application that can cross-check if the promised platforms are correct.

To understand the expected output better: suppose something says "platforms: All", like kcontacts. If there's no actual build configured in CI for that something, for FreeBSD, it will say "FreeBS is a disabled platform". The message can probably be improved, then. And how about checking the reverse, too? CI builds that are not listed in the metainfo? (if that can even happen)

Dec 8 2017, 10:12 AM

Dec 6 2017

adridg accepted D8932: make docbook compilation optional.
Dec 6 2017, 6:30 PM
adridg accepted D8931: derive app version from kde applications release.

Seems sensible from a packaging and release standpoint, so I'll say "LGTM", but I don't really like it from an application-versioning standpoint since releases happen regularly regardless of changes in the application itself.

Dec 6 2017, 6:25 PM

Dec 5 2017

adridg accepted D8941: do not misuse QGroupBox as a layout helper, instead use a layout directly.

LGTM. Better in Breeze (there's a little less padding before the radio buttons), Fusion and Win95 themes.

Dec 5 2017, 5:32 PM

Dec 3 2017

adridg abandoned D9149: Allow running the tool without a display.

Careful use of -platform minimal allows running the tool with no changes to the code or kcm.

Dec 3 2017, 5:20 PM · Plasma
adridg added a reviewer for D9149: Allow running the tool without a display: mart.
Dec 3 2017, 5:03 PM · Plasma
adridg created D9149: Allow running the tool without a display.
Dec 3 2017, 4:59 PM · Plasma

Nov 30 2017

adridg added a comment to T6831: Top-notch usability and productivity for basic software.

We should be cautious in mixing up what Calamares (not a KDE project) does with what the desktop environment might do. For background, Calamares can be used in two ways:

  • as a system installer; you boot a live CD or memory stick, and install some (Linux) system to a hard disk
  • as a system configurator; you boot a newly purchased laptop and it starts into a "newuser" which reconfigures the system with the user preferences (and login name) you give
Nov 30 2017, 4:21 PM · Goal settings 2017

Nov 22 2017

adridg added a comment to M116: Calamares Telemetry Page Design suggestion.

Here's what it looks like in the implementation.

Nov 22 2017, 12:18 PM · Plasma
adridg added a comment to M116: Calamares Telemetry Page Design suggestion.

There's a bit of a background here -- and thanks, Jens, for mocking something up and thanks Andy for thinking along on the actual text. Calamares is used by various distro's. Some want it to phone home at the end of installation. Some, like Debian derivatives, have the Debian machine-tracking stuff which can be enabled/disabled. Some could enable KDE's User Tracking stuff that Volker was working on over the summer. So there are quite some technical differences between the options -- we can hide all that in the descriptions (behind the ? button) I suppose. I use "tracking" because that's the kind of scary word *I* want to see, encouraging me to turn it off -- I can totally understand using a more friendly word on the distro's side, who want people to turn it *on*.

Nov 22 2017, 10:29 AM · Plasma

Nov 7 2017

adridg added inline comments to D8695: Fix ampersand characters not showing in tab titles.
Nov 7 2017, 3:21 PM · Plasma
adridg committed R106:1f8fec738573: Add .arcconfig (authored by adridg).
Add .arcconfig
Nov 7 2017, 3:11 PM
adridg closed D8694: Add .arcconfig.
Nov 7 2017, 3:11 PM · Plasma
adridg created D8694: Add .arcconfig.
Nov 7 2017, 3:10 PM · Plasma

Nov 2 2017

adridg committed R345:35700970e790: Add .arcconfig (authored by adridg).
Add .arcconfig
Nov 2 2017, 10:07 AM
adridg created D8614: Fix up warning when mixer id is empty..
Nov 2 2017, 10:05 AM

Oct 3 2017

adridg committed R16:63b501f41ddc: Tests: simple listing of attached devices (authored by adridg).
Tests: simple listing of attached devices
Oct 3 2017, 9:59 AM
adridg committed R16:98caf8442490: Docs: change parameter name to match intention. (authored by adridg).
Docs: change parameter name to match intention.
Oct 3 2017, 9:59 AM
adridg committed R16:c4ae5d680c0f: Docs: document Device (a description) and CoreBackendDevice (an operational… (authored by adridg).
Docs: document Device (a description) and CoreBackendDevice (an operational…
Oct 3 2017, 9:59 AM

Oct 2 2017

adridg committed R16:12ee62d393d3: Tests: fixup license headers, code style (authored by adridg).
Tests: fixup license headers, code style
Oct 2 2017, 3:17 PM
adridg committed R16:41b835ba4678: Docs: add a README, explain high-level usage (authored by adridg).
Docs: add a README, explain high-level usage
Oct 2 2017, 2:35 PM
adridg committed R16:f1dee860844d: Tests: initial test in initializing lib and loading a backend (authored by adridg).
Tests: initial test in initializing lib and loading a backend
Oct 2 2017, 2:35 PM
adridg committed R16:e67b6b6a2b53: Docs: Add documentation about FileSystem::name() (authored by adridg).
Docs: Add documentation about FileSystem::name()
Oct 2 2017, 2:35 PM

Sep 30 2017

adridg added a comment to D8062: cmake: Stop warning if dot is not found when CMake is run..

FindGraphviz.cmake uses DOT as well for finding the version of GraphViz that is installed -- not that the current module or code supports checking hthat version, but it's there.

Sep 30 2017, 10:55 AM

Sep 28 2017

adridg abandoned D8025: Link libgvc (graphviz) with both the library, and linker flags..

Should be done by fixing the contents of ${graphviz_LIBRARIES}{ instead.

Sep 28 2017, 9:13 PM
adridg abandoned D8027: Simplify GraphViz version detection by using CMake-native facilities.

The fix is to make ${graphviz_LIBRARIES} contain the full paths to the libraries (as is common with find_library() calls) instead of naming libs suitable for use with -l. This requires another approach (I';ll still suggest fixing up the version-checking code,though).

Sep 28 2017, 9:13 PM
adridg created D8027: Simplify GraphViz version detection by using CMake-native facilities.
Sep 28 2017, 12:09 PM
adridg created D8025: Link libgvc (graphviz) with both the library, and linker flags..
Sep 28 2017, 11:17 AM

Sep 14 2017

adridg committed R491:81c4c7cffd27: Meant to be assignments (authored by adridg).
Meant to be assignments
Sep 14 2017, 9:11 PM

Sep 3 2017

adridg created D7681: Update human-readable tier designation in API dox.
Sep 3 2017, 6:13 PM · Kirigami

Aug 27 2017

adridg updated the diff for D7572: Fix dependency loop.

Missed 4 other dependency-loop files.

Aug 27 2017, 3:24 PM · KDb
adridg created D7574: The OLD behavior of CMP0022 doesn't seem to be needed..
Aug 27 2017, 3:03 PM · KDb
adridg created D7573: The OLD behavior of CMP0002 doesn't seem to be needed..
Aug 27 2017, 3:01 PM · KDb
adridg created D7572: Fix dependency loop.
Aug 27 2017, 2:58 PM · KDb

Aug 26 2017

adridg committed R264:2e7cd3bc4704: Fix build on CI. (authored by adridg).
Fix build on CI.
Aug 26 2017, 4:15 PM
adridg closed D5716: Fix build on CI. by committing R264:2e7cd3bc4704: Fix build on CI..
Aug 26 2017, 4:15 PM · Documentation, Frameworks
adridg committed R264:04fea3a98326: Add an .arcconfig (authored by adridg).
Add an .arcconfig
Aug 26 2017, 4:15 PM
adridg committed R158:012d1cfeb82b: FreeBSD does not have sys/asm.h -- for what is this include needed on linux? (authored by tcberner).
FreeBSD does not have sys/asm.h -- for what is this include needed on linux?
Aug 26 2017, 1:42 PM
adridg closed D6929: FreeBSD does not have sys/asm.h -- for what is this include needed on linux? by committing R158:012d1cfeb82b: FreeBSD does not have sys/asm.h -- for what is this include needed on linux? (authored by tcberner).
Aug 26 2017, 1:42 PM
adridg abandoned D5716: Fix build on CI..

Closed by 2e7cd3bc4704408358f11ad4d92af17a1b8ce2b5

Aug 26 2017, 1:34 PM · Documentation, Frameworks

Aug 4 2017

adridg accepted D6925: kmix assumes volume range 1:100 for oss mixer instead of 0:100..

I was going to say "can't reproduce the original problem", but that is because this patch has been in production in the FreeBSD (which uses OSS) packages for years. So with Marten's OK in mind, I'll ACK it as well.

Aug 4 2017, 2:00 PM
adridg closed T4993: Fix links in website footer as Resolved.

Looks resolved, and thanks also to @yurchor

Aug 4 2017, 9:30 AM · Krusader

Aug 3 2017

adridg abandoned D6254: At the moment __sanitizer_print_memory_profile is only available for Linux. So extend the check for Q_OS_LINUX..

This was overcome by other changes in src/main.cpp, which were still not valid with older Clang or on FreeBSD. Fixed with other commits.

Aug 3 2017, 8:42 PM
adridg committed R467:a681366f7e0d: Reduce pre-processor warnings. (authored by adridg).
Reduce pre-processor warnings.
Aug 3 2017, 8:39 PM
adridg committed R467:4a7070bfca1e: Fix semantics when compiling with older clang. (authored by adridg).
Fix semantics when compiling with older clang.
Aug 3 2017, 8:39 PM
adridg committed R467:fb6256079b38: Include internal sanitizer headers only for LLVM 5.0svn. (authored by adridg).
Include internal sanitizer headers only for LLVM 5.0svn.
Aug 3 2017, 8:39 PM

Jun 25 2017

adridg committed R266:c6a290a2e154: Do not depend on bash uncessarily, and do not validate icons by default. (authored by tcberner).
Do not depend on bash uncessarily, and do not validate icons by default.
Jun 25 2017, 12:43 PM
adridg closed D6076: Do not depend on bash uncessarily, and do not validate icons by default. by committing R266:c6a290a2e154: Do not depend on bash uncessarily, and do not validate icons by default. (authored by tcberner).
Jun 25 2017, 12:43 PM · Frameworks

Jun 24 2017

adridg added a comment to D6254: At the moment __sanitizer_print_memory_profile is only available for Linux. So extend the check for Q_OS_LINUX..

.. reconsidering. This is internal debugging / memory profiling that is dumped to stdout when some secret(-ish) extra arguments are given to k3b. The interface used was added to clang on march 15th 2017, so it's only available on very-very recent clangs .. I think the right thing to do is just remove this, as "accidentally committed debugging code".

Jun 24 2017, 11:27 PM
adridg updated the diff for D6254: At the moment __sanitizer_print_memory_profile is only available for Linux. So extend the check for Q_OS_LINUX..

update with tcberner's newer patch

Jun 24 2017, 4:02 PM
adridg committed R467:713c86f598dc: Stub .arcconfig (authored by adridg).
Stub .arcconfig
Jun 24 2017, 3:51 PM
adridg commandeered D6254: At the moment __sanitizer_print_memory_profile is only available for Linux. So extend the check for Q_OS_LINUX..

Commandeering this one to upate the patch with tcb's second version.

Jun 24 2017, 3:49 PM
adridg updated the diff for D6076: Do not depend on bash uncessarily, and do not validate icons by default..

Make the diff smaller: only de-bash it, and save make-validation-optional
for a later patch.

Jun 24 2017, 3:01 PM · Frameworks
adridg commandeered D6076: Do not depend on bash uncessarily, and do not validate icons by default..

Taking over to follow up Albert's suggestion -- this could be two patches, one to de-bash it, one to make validation optional.

Jun 24 2017, 2:53 PM · Frameworks
adridg added reviewers for D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().: kfunk, poboiko.

Add reviewers who have commented, or who have committed to baloo recently.

Jun 24 2017, 11:55 AM · Frameworks
adridg added a comment to D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem()..

So this patch looks ready to land to me: it simplifies the code, defers fstype-detection to QStorageInfo (for FreeBSD, we should fix the original issue there), and is otherwise non-intrusive.

Jun 24 2017, 11:53 AM · Frameworks
adridg added reviewers for D6243: Add role for file creation time.: elvisangelaccio, broulik.

Adding potential reviewers who have committed to Dolphin recently.

Jun 24 2017, 11:49 AM

Jun 19 2017

adridg committed R293:401b38989f0d: Use FindInotify.cmake to decide wheter inotify is available. (authored by adridg).
Use FindInotify.cmake to decide wheter inotify is available.
Jun 19 2017, 3:17 PM
adridg closed D6265: Use FindInotify.cmake to decide wheter inotify is available. by committing R293:401b38989f0d: Use FindInotify.cmake to decide wheter inotify is available..
Jun 19 2017, 3:16 PM · Frameworks
adridg added reviewers for D6265: Use FindInotify.cmake to decide wheter inotify is available.: vhanda, tcberner.
Jun 19 2017, 7:14 AM · Frameworks
adridg created D6265: Use FindInotify.cmake to decide wheter inotify is available..
Jun 19 2017, 7:13 AM · Frameworks

Jun 18 2017

adridg added a comment to D6254: At the moment __sanitizer_print_memory_profile is only available for Linux. So extend the check for Q_OS_LINUX..

A better version (which tcberner has prepared) checks for the existence of the header file and for the existence of the symbol.

Jun 18 2017, 1:32 PM
adridg committed R467:b023dc5fe4b0: Fix my name and credit (authored by adridg).
Fix my name and credit
Jun 18 2017, 6:09 AM

Jun 17 2017

adridg abandoned D5715: Fix tier-indicator..

https://phabricator.kde.org/R159:b5e20a709fbef7015874e9536cc06e5aa22aa5c0

Jun 17 2017, 6:56 PM · Frameworks
adridg committed R304:28833ae05d00: Extend unittests to test stable sort. (authored by adridg).
Extend unittests to test stable sort.
Jun 17 2017, 6:47 PM
adridg closed D6049: Extend unittests to test stable sort. by committing R304:28833ae05d00: Extend unittests to test stable sort..
Jun 17 2017, 6:47 PM · Frameworks
adridg added a comment to D6243: Add role for file creation time..

This is partly related to another review, since committed, for actually filling the creation (birth) time of files. On FreeBSD, this information is available for some filesystems. On Linux, this information is not available through the stat() system call, but statx() was recently added to the kernel, so it's possible that KFileItemMetaData (or whatever that class was) gains support for creation time on Linux too, and then this column is filled in automagically.

Jun 17 2017, 6:18 PM

Jun 9 2017

adridg added a comment to D6151: Make compile under Windows/MSVC.

LGoF (Looks Good on FreeBSD)

Jun 9 2017, 8:50 AM

May 31 2017

adridg added reviewers for D6049: Extend unittests to test stable sort.: whiting, Frameworks.

(also, this repo has a .reviewboardrc but no .arcconfig)

May 31 2017, 11:18 AM · Frameworks
adridg created D6049: Extend unittests to test stable sort..
May 31 2017, 11:17 AM · Frameworks
adridg committed R107:38ff660bb81c: Handle differences in PAM headers (authored by adridg).
Handle differences in PAM headers
May 31 2017, 9:44 AM
adridg closed D6000: Handle differences in PAM headers by committing R107:38ff660bb81c: Handle differences in PAM headers.
May 31 2017, 9:44 AM · Plasma

May 28 2017

adridg added a comment to D6000: Handle differences in PAM headers.

See, e.g., https://build-sandbox.kde.org/view/Plasma/job/Plasma kwallet-pam kf5-qt5 FreeBSDQt5.7/1/console

May 28 2017, 11:20 AM · Plasma
adridg added reviewers for D6000: Handle differences in PAM headers: jriddell, Plasma.
May 28 2017, 11:19 AM · Plasma
adridg created D6000: Handle differences in PAM headers.
May 28 2017, 11:18 AM · Plasma

May 24 2017

adridg added a comment to T6200: Spam Reporting.

I guess one possibility would be to leave this task around, but moving it from done / abandoned to in progress, with a comment, when new store spam is spotted.

May 24 2017, 2:45 PM · KDE Store
adridg created T6200: Spam Reporting.
May 24 2017, 2:43 PM · KDE Store
adridg added inline comments to D5825: kcheckpass: Add support in for non-Linux platforms via kevent..
May 24 2017, 8:49 AM · Plasma
adridg added a comment to D5825: kcheckpass: Add support in for non-Linux platforms via kevent..

The recent change that uses signalfd() is a linuxism. Possibly a glibism as well. This patch introduces an alternate path for systems without signalfd(), using kevent() to do the Same Thing (tm) .. but as tcberner says, it's not been tested. Consider it a prototype.

May 24 2017, 8:35 AM · Plasma

May 9 2017

adridg added a comment to D5778: [backlighthelper] Remove unreachable code from backlighthelper.

It's a little more complicated than this:

May 9 2017, 10:34 PM · Plasma

May 5 2017

adridg committed R127:a5d279198fee: Fix autotests on the FreeBSD CI. (authored by adridg).
Fix autotests on the FreeBSD CI.
May 5 2017, 3:27 PM
adridg closed D5717: Fix autotests on the FreeBSD CI. by committing R127:a5d279198fee: Fix autotests on the FreeBSD CI..
May 5 2017, 3:27 PM · Frameworks, Plasma on Wayland
adridg committed R241:def270105286: Fix quoting of preprocessor-definition. (authored by adridg).
Fix quoting of preprocessor-definition.
May 5 2017, 3:27 PM
adridg closed D5713: Fix quoting of preprocessor-definition. by committing R241:def270105286: Fix quoting of preprocessor-definition..
May 5 2017, 3:27 PM · Frameworks
adridg added a comment to D4906: Fix kactivities-stats into tier3.

The default configuration of kactivities has option KACTIVITIES_LIBRARY_ONLY set to OFF, which means src/imports is added as subdirectory, and it uses KIO and other tier-3 libraries. So the default build of kactivities is still tier-3. And as long as kactivities is listed as tier-3, kactivities-stats should be listed as tier-3 as well.

May 5 2017, 3:24 PM · Frameworks
adridg added a comment to D5211: krfb: Implement XCB framebuffer plugin (port from x11).

Very general comment: in the desktop file, does the name now overlap with the existing (non-functional?) x11 plugin?

May 5 2017, 12:41 PM · KDE Applications
adridg accepted D5555: Include xlocale.h rather than locale.h for strtod_l.

LGTM on FreeBSD 10.3, both gcc and clang.

May 5 2017, 12:25 PM
adridg added a reviewer for D5717: Fix autotests on the FreeBSD CI.: graesslin.
May 5 2017, 12:19 PM · Frameworks, Plasma on Wayland
adridg created D5717: Fix autotests on the FreeBSD CI..
May 5 2017, 12:18 PM · Frameworks, Plasma on Wayland