adridg (Adriaan de Groot)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2016, 8:39 AM (238 w, 1 h)
Availability
Available

Recent Activity

Fri, Sep 11

adridg updated subscribers of T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

I've updated the table with myself as contact for Calamares on both sides. @teo is also still around. I've filled in "no" for now. I think I've written this before, but there's these issues:

  • (political) Calamares is a distro- and desktop-independent installer. *Not* being a KDE project has value there, although as KDE grows more umbrella-ish the political side is reduced: also with Calamares established now as an independent installer there's less "oh, that's KDE, can't use it for my xfce distro". So .. not much of an issue anymore.
  • (administrative) It has its own domain (calamares.io) which is owned by Blue Systems; if I understand the manifesto correctly this would have to be transferred to sysadmin: that is only partly my (the maintainer) decision to make. Besides which I gather sysadmin isn't really jumping at the opportunity to host lots of domains. On the other hand, it's a simple GitHub pages (i.e. Jekyll) site, so it's easy enough to host. So .. a bit of an issue, for administrative reasons.
  • (technical) GitHub was, for a while, much nicer than the git hosting provided by KDE. Now with GitLab, I'd say that KDE hosting is nicer. But with the ongoing uncertainty about GL issues versus Bugzilla, that's a reason to stick with GH and one stream of issues. So .. needs clarification, might be blocker.
  • (technical) Who's going to do the work of creating importers-and-migrators? (Er .. come to think of it, GL has GH importers that work just fine) So .. resolved.
  • (i18n) Existing translation workflow is via Transifex, I would either need to keep that translation source or you'd need to convince me that KDE's translation workflow is effective (and supports Esperanto and Interlingue and ..) and can give the kind of turnaround for Calamares's two-week release schedule. So .. needs explanation.
Fri, Sep 11, 10:56 AM · KDE Promo
adridg updated the task description for T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.
Fri, Sep 11, 9:51 AM · KDE Promo

Aug 15 2020

adridg added a comment to T12730: Rework COPYING and COPYING.LIB files.

It might be nice to replace COPYING -- let's not create a new file LICENSE, that's confusing in the face of the REUSE spec -- with a little "This repository uses SPDX identifiers and follows the REUSE specification. You can find the applicable licenses in the LICENSES/ subdirectory. If you have the REUSE tool installed, make show-outbound-licenses and make show-source-licenses will tell you about this respository."

Aug 15 2020, 7:55 AM · KF6

Jun 29 2020

adridg added a comment to T13346: Recommended/required license for generated code.

The classic example of Jon's second paragraph is YACC (and Bison), which generates code and adds a big chunk of template code. Or Boost, which has parts intended for header-only use, and so that gets copied all over the place (think of the header as "generated code from the source 'use boost::pointer'"). The template is copyrighted, but in context is liberally licensed.

Jun 29 2020, 3:12 PM
adridg added a comment to T13345: Recommended/required license for example code.

CC0 is the "long form" of Jon's second suggestion; it is unfortunately long and torturous, but also one of the licenses we might have to deal with anyway for "uncopyrightable". It has a SPDX identifier, CC0-1.0 and is also suggested by REUSE.software.

Jun 29 2020, 3:02 PM
adridg added a comment to T13344: Clarify usage of BSD-3-Clause license with (CMake) code.
  • If we allow BSD-3-Clause, it should be a separate explicit entry in the alternative-licenses list.
  • The official SPDX text has "3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission." where the italics indicate that variants exist; the sample text is pretty generic IMO.
  • CMake upstream specifically instructs "We do not require any formal copyright assignment or contributor license agreement. Any contributions intentionally sent upstream are presumed to be offered under terms of the OSI-approved BSD 3-clause License. See Copyright.txt for details." (here)
Jun 29 2020, 2:56 PM · Build System

Jun 16 2020

adridg moved T11726: 2019 AGM passivation from Doing to Done on the KDE e.V. board.
Jun 16 2020, 9:15 AM · KDE e.V.

Jun 15 2020

adridg added a comment to D29847: Fixes compile problem for freebsd because of missing crypt.h.

This review should be closed: a change landed via invent that makes it unnecessary (<crypt.h> is no longer used in the users kcm).

Jun 15 2020, 11:48 AM · FreeBSD, Plasma

Jun 8 2020

adridg committed R917:4a25551e617e: Wreck the wrok (reported by Aniqa) (authored by adridg).
Wreck the wrok (reported by Aniqa)
Jun 8 2020, 7:29 PM
adridg committed R119:e65c30d3862e: Avoid unused-member warnings in WindowModel::Private (authored by adridg).
Avoid unused-member warnings in WindowModel::Private
Jun 8 2020, 9:50 AM
adridg committed R119:845585d9b429: Avoid deprecated API (authored by adridg).
Avoid deprecated API
Jun 8 2020, 9:50 AM
adridg committed R119:3df00f81c0af: Handle absent <crypt.h> (authored by adridg).
Handle absent <crypt.h>
Jun 8 2020, 9:48 AM
adridg committed R119:26881f7d2efa: Following Nicofe's comment, just use unistd.h for crypt (authored by adridg).
Following Nicofe's comment, just use unistd.h for crypt
Jun 8 2020, 9:27 AM

Jun 7 2020

adridg committed R119:b339b45ed8f0: Handle absent <crypt.h> (authored by adridg).
Handle absent <crypt.h>
Jun 7 2020, 6:32 PM
adridg committed R119:593178653917: Normalize include-quotes (authored by adridg).
Normalize include-quotes
Jun 7 2020, 6:32 PM
adridg committed R119:22ea560b8920: Avoid deprecated API (authored by adridg).
Avoid deprecated API
Jun 7 2020, 6:14 PM
adridg committed R119:963ca2ff125f: Avoid unused-member warnings in WindowModel::Private (authored by adridg).
Avoid unused-member warnings in WindowModel::Private
Jun 7 2020, 6:14 PM
adridg committed R119:bdca8c011b44: Correct salting array: (authored by adridg).
Correct salting array:
Jun 7 2020, 3:20 PM
adridg committed R119:6b8229242e63: Sanitize saltCharacter() (authored by adridg).
Sanitize saltCharacter()
Jun 7 2020, 3:20 PM
adridg added a comment to D29847: Fixes compile problem for freebsd because of missing crypt.h.

There's already a CMake-time check for <crypt.h>, it's just not used. (HAVE_CRYPT_H)

Jun 7 2020, 9:22 AM · FreeBSD, Plasma

Jun 6 2020

adridg committed R491:c08c1a8449a4: Capitalize Graphviz consistently (authored by adridg).
Capitalize Graphviz consistently
Jun 6 2020, 2:57 PM
adridg committed R491:c65339de50fd: Handle Graphviz capitalization changes (authored by adridg).
Handle Graphviz capitalization changes
Jun 6 2020, 2:57 PM
adridg added a comment to D14146: cmake: Simplify and improve FindGraphviz.cmake.

It would be ironic, if the problem was in the find-module, and not in the CMakeLists.txt of kgraphviewer itself, which in some places uses ${graphviz_LIBRARIES} and elsewhere does not. I'll just push a fix to invent.

Jun 6 2020, 2:23 PM

Jun 5 2020

adridg committed R108:fcba2780946c: Handle differences in paths for Linux vs FreeBSD (authored by adridg).
Handle differences in paths for Linux vs FreeBSD
Jun 5 2020, 10:43 AM
adridg committed R108:8826c7ff34f5: Fix virtual_terminal.cpp build on FreeBSD (authored by adridg).
Fix virtual_terminal.cpp build on FreeBSD
Jun 5 2020, 10:43 AM
adridg committed R108:33aff4fcd0ec: Add Findepoll.cmake (authored by Tobias Berner <tcberner@FreeBSD.org>).
Add Findepoll.cmake
Jun 5 2020, 10:43 AM
adridg committed R108:0dce25ba0f6d: Consolidate target_link_libraries() calls (authored by adridg).
Consolidate target_link_libraries() calls
Jun 5 2020, 10:43 AM
adridg committed R119:c27ceed9fd77: Forward-declare LayoutUnit consistently (as class, not struct) (authored by adridg).
Forward-declare LayoutUnit consistently (as class, not struct)
Jun 5 2020, 10:30 AM
adridg committed R119:8670d91a549e: Forward-declare LibinputSettings consistently (authored by adridg).
Forward-declare LibinputSettings consistently
Jun 5 2020, 10:30 AM

Jun 1 2020

adridg added a comment to D10829: [WIP] Use DocumentId class.

This looks abandoned or stalled. @michaelh do you have any plans on this front?

Jun 1 2020, 9:07 PM · Frameworks, Baloo
adridg abandoned D26393: Expand dynamic cast hierarchy..
Jun 1 2020, 3:39 PM · KDE PIM
adridg updated subscribers of D26393: Expand dynamic cast hierarchy..

@aheinecke patch in bug 415168 fixes the issue by doing the single-RTTI-exported that Volker talks about.

Jun 1 2020, 3:35 PM · KDE PIM

May 31 2020

adridg updated subscribers of D24810: Ensure defintion of XDG_DATA_DIRS.

Calling @davidedmundson .. I would migrate this to invent, except in 3c1a34a26dbdf7c123782746881d914cd47b27b6 the similar adjustment for XDG_DATA_DIRS was already removed. We carry this patch, but recent Plasma's no longer set XDG_DATA dir so I think your call on the variable (noone relies on it) is the right one and this can be abandoned.

May 31 2020, 10:20 PM · Plasma
adridg abandoned D18009: Add Findepoll.cmake to find epoll/epoll-shim and add initial FreeBSD support.

Moved to invent !40

May 31 2020, 10:02 PM · KWin
adridg commandeered D18009: Add Findepoll.cmake to find epoll/epoll-shim and add initial FreeBSD support.
May 31 2020, 10:02 PM · KWin
adridg committed R108:9372611e2719: Handle differences in paths for Linux vs FreeBSD (authored by adridg).
Handle differences in paths for Linux vs FreeBSD
May 31 2020, 10:00 PM
adridg committed R108:a748b0a1d6ad: Fix virtual_terminal.cpp build on FreeBSD (authored by adridg).
Fix virtual_terminal.cpp build on FreeBSD
May 31 2020, 10:00 PM
adridg committed R108:fb3f5afb0541: Consolidate target_link_libraries() calls (authored by adridg).
Consolidate target_link_libraries() calls
May 31 2020, 10:00 PM
adridg committed R108:1eefce5a6680: Add Findepoll.cmake (authored by Tobias Berner <tcberner@FreeBSD.org>).
Add Findepoll.cmake
May 31 2020, 10:00 PM
adridg closed D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid.

Migrated to invent, https://invent.kde.org/frameworks/kdesu/-/merge_requests/1

May 31 2020, 6:25 PM · Frameworks
adridg committed R299:7d0d3dd768a9: Migrated from D23692, original review message from Malte Kraus (authored by maltek).
Migrated from D23692, original review message from Malte Kraus
May 31 2020, 6:20 PM
adridg closed D26008: Include the gmock prefix in the search path.
May 31 2020, 4:02 PM · Amarok
adridg closed D14070: Info page of torrent now shows Share ratio in format [-]9.9.

Turns out this was a dup of D13971, which was filed earlier, and landed two weeks after this one.

May 31 2020, 3:58 PM
adridg abandoned D13327: Fix conversion error when compiled against MDNSRESPONDER option.

Pretty much exact same changes were done in D15479

May 31 2020, 3:38 PM · Frameworks
adridg abandoned D5798: Fix up codec_ogg's and codec_flac's CMakeLists.txt for FreeBSD.
May 31 2020, 3:31 PM
adridg commandeered D5798: Fix up codec_ogg's and codec_flac's CMakeLists.txt for FreeBSD.
May 31 2020, 3:31 PM
adridg abandoned D13328: A backend is required for kdnssd.

Yeah, let's not then.

May 31 2020, 3:28 PM · Frameworks
adridg abandoned D8614: Fix up warning when mixer id is empty..

Landed in invent with 9dbcc119

May 31 2020, 3:19 PM
adridg committed R345:9dbcc119437d: Report a useful mixer id, rather than "" (authored by adridg).
Report a useful mixer id, rather than ""
May 31 2020, 3:18 PM
adridg abandoned D17931: Fix build on FreeBSD..

Fixed by @rakuco instead.

May 31 2020, 2:36 PM · Kopete
adridg abandoned D23338: Use baseFactory for K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL.

Re-filed on invent

May 31 2020, 2:34 PM · Frameworks
adridg committed R244:9889685fda69: The existing macro always inherits from KPluginFactory -- making it hard to use… (authored by adridg).
The existing macro always inherits from KPluginFactory -- making it hard to use…
May 31 2020, 2:31 PM
adridg committed R491:1c1a3d6b39ff: cmake: Simplify and improve FindGraphviz.cmake (authored by rakuco).
cmake: Simplify and improve FindGraphviz.cmake
May 31 2020, 11:49 AM
adridg closed D14146: cmake: Simplify and improve FindGraphviz.cmake.
May 31 2020, 11:49 AM

May 30 2020

adridg committed R73:7d1e2b65f1df: gml files: remove commented-out code (authored by adridg).
gml files: remove commented-out code
May 30 2020, 6:39 PM
adridg committed R73:7302ec337f8a: dot files: reduce compiler-warnings (authored by adridg).
dot files: reduce compiler-warnings
May 30 2020, 6:39 PM
adridg committed R73:059122f20062: gml files: reduce compiler warnings (authored by adridg).
gml files: reduce compiler warnings
May 30 2020, 6:39 PM
adridg committed R73:e4bb668a9724: tgf files: reduce compiler warnings (authored by adridg).
tgf files: reduce compiler warnings
May 30 2020, 6:39 PM
adridg abandoned D12230: [WIP] Adjust socket buffer sizes on FreeBSD.

There is supposedly kernel-level mitigation for this now, although I haven't found it to work; the "weird issues" in this patch never went away so I'm abandoning it in favor of just using sysctl and a pkg-message.

May 30 2020, 4:14 PM · KDE PIM
adridg committed R480:66c1781636ac: Populate the mailclient drop down also on FreeBSD. (authored by tcberner).
Populate the mailclient drop down also on FreeBSD.
May 30 2020, 3:59 PM
adridg closed D7133: Populate the mailclient drop down also on FreeBSD..
May 30 2020, 3:59 PM
adridg abandoned D25200: Attempt to use Phab as a snippet-review-tool.

This was entirely the wrong project / community / everything for this to land in.

May 30 2020, 3:55 PM
adridg added a comment to D10825: [WIP] Introduce aliases DocId, DeviceId and Inode.

This looks abandoned with 2 years of no movement. @michaelh do you still feel this is a WIP?

May 30 2020, 3:53 PM · Baloo, Frameworks
adridg added a comment to D10826: [WIP] Introduce DocumentId class.

This looks abandoned with 2 years of no movement. @michaelh do you still feel this is a WIP?

May 30 2020, 3:53 PM · Frameworks, Baloo
adridg added a comment to D10856: [WIP] Make tests compile, except one.

This looks abandoned, no movement in over two years. @michaelh did you still want to introduce docId instead of quint64? This diff was supposed to supplant D10851 but seems to have fallen asleep as well. (In retrospect, perhaps I would have suggested first introducing just using docId = quint64; somewhere, to get the more-expressive-type-name part out of the way before real changes)

May 30 2020, 3:50 PM · Baloo, Frameworks
adridg added a comment to D10851: autotests: Introduce alias DocId.

This looks abandoned, no movement in over two years. @michaelh do you want to explicitly abandon this one, so we have a clean slate for invent? None of the docId type changes seem to have made it to master (see also D10856)

May 30 2020, 3:47 PM · Baloo, Frameworks
adridg committed R73:fa36a4fb27f4: Place the first newly created graph at the center of canvas when using 'Graph… (authored by yurchor).
Place the first newly created graph at the center of canvas when using 'Graph…
May 30 2020, 3:46 PM
adridg committed R73:71f90e5ce0f5: gml files: remove commented-out code (authored by adridg).
gml files: remove commented-out code
May 30 2020, 3:14 PM
adridg committed R73:1bad68621c8e: dot files: reduce compiler-warnings (authored by adridg).
dot files: reduce compiler-warnings
May 30 2020, 3:14 PM
adridg committed R73:42922513b998: gml files: reduce compiler warnings (authored by adridg).
gml files: reduce compiler warnings
May 30 2020, 3:14 PM
adridg committed R73:a347b0683a0e: tgf files: reduce compiler warnings (authored by adridg).
tgf files: reduce compiler warnings
May 30 2020, 3:14 PM
adridg committed R73:e69785c53339: Merge remote-tracking branch 'origin/fix-tests' (authored by adridg).
Merge remote-tracking branch 'origin/fix-tests'
May 30 2020, 2:41 PM
adridg committed R73:a33e26febcd5: Merge remote-tracking branch 'origin/use-c++11' (authored by adridg).
Merge remote-tracking branch 'origin/use-c++11'
May 30 2020, 2:20 PM
adridg abandoned D26748: Fix liboath detection and use include directory..

"Overcome by events" as we say in FreeBSD-land

May 30 2020, 12:31 AM
adridg commandeered D26748: Fix liboath detection and use include directory..
May 30 2020, 12:30 AM
adridg abandoned D11845: Make clang happy..

This was fixed independently in 114b349f09

May 30 2020, 12:20 AM · Kopete
adridg commandeered D11845: Make clang happy..
May 30 2020, 12:19 AM · Kopete

May 28 2020

adridg committed R449:23254509bc13: Needs <errno.h> for errno (this is included implicitly in Linux, needs to be… (authored by adridg).
Needs <errno.h> for errno (this is included implicitly in Linux, needs to be…
May 28 2020, 11:23 PM
adridg committed R318:7df39255a6a0: Non-functional change: consistent indentation (authored by adridg).
Non-functional change: consistent indentation
May 28 2020, 9:43 PM
adridg committed R318:d3963a7765a5: Make ruby, and Gem:test-unit, optional (authored by adridg).
Make ruby, and Gem:test-unit, optional
May 28 2020, 9:43 PM
adridg committed R127:a60fcb706d34: Fix test-building on FreeBSD (authored by adridg).
Fix test-building on FreeBSD
May 28 2020, 8:44 PM
adridg committed R365:938a31758382: Mention cli option in the filtering section as well. (authored by adridg).
Mention cli option in the filtering section as well.
May 28 2020, 1:50 PM
adridg committed R365:996916fd5eb5: Call a spade a spade (authored by adridg).
Call a spade a spade
May 28 2020, 1:06 PM
adridg committed R365:30bc380ebfef: Output generic vendor name rather than 'linux'. (authored by adridg).
Output generic vendor name rather than 'linux'.
May 28 2020, 1:06 PM
adridg committed R365:4f5fb9100f64: Not an error if there's no os-release (authored by adridg).
Not an error if there's no os-release
May 28 2020, 1:06 PM
adridg accepted D27680: Update old content in the e.V. website.

Yes, sorry (I have no idea where Phab notifications go for me, so I missed the ping as well). These changes are good (and still apply).

May 28 2020, 12:12 PM
adridg committed R157:781b304d65f9: Fix build with CMake 3.15 (authored by adridg).
Fix build with CMake 3.15
May 28 2020, 11:26 AM
adridg closed D23076: Fix build with CMake 3.15.
May 28 2020, 11:26 AM
adridg closed D20562: Use (better) path to libICE when doing check_library_exists..

Pushed via invent in 0c4ad7f1

May 28 2020, 11:18 AM · Plasma
adridg committed R436:99f5ff345dd1: Remove NX support (authored by adridg).
Remove NX support
May 28 2020, 11:02 AM
adridg closed D23453: Remove NX support.
May 28 2020, 11:02 AM

May 27 2020

adridg committed R365:5d3e2edfc35c: Add more os-release candidates. (authored by adridg).
Add more os-release candidates.
May 27 2020, 3:06 PM
adridg committed R365:028b0e99921d: Fix (break) os-release detection. (authored by adridg).
Fix (break) os-release detection.
May 27 2020, 3:05 PM
adridg committed R127:980a4d848557: Fix test-building on FreeBSD (by not building one) (authored by adridg).
Fix test-building on FreeBSD (by not building one)
May 27 2020, 11:46 AM

May 26 2020

adridg committed R296:65e765a63f53: Fix #include guards (authored by adridg).
Fix #include guards
May 26 2020, 7:31 PM
adridg committed R119:8be74e645505: Remove spurious Q_EMIT (authored by adridg).
Remove spurious Q_EMIT
May 26 2020, 7:31 PM
adridg committed R120:0c4ad7f1aaf4: Fix finding _IceTransNoListen. (authored by adridg).
Fix finding _IceTransNoListen.
May 26 2020, 9:37 AM

May 19 2020

adridg committed R120:a28c94c5317d: Fix finding _IceTransNoListen. (authored by adridg).
Fix finding _IceTransNoListen.
May 19 2020, 8:27 PM

May 8 2020

adridg committed R16:1d9b1161d489: On non-Linux, findBlkIdDevice() has unused parameters (authored by adridg).
On non-Linux, findBlkIdDevice() has unused parameters
May 8 2020, 2:19 PM
adridg closed D24155: On non-Linux, findBlkIdDevice() has unused parameters.
May 8 2020, 2:19 PM