[applets/appmenu] Add search to global application menu
Needs ReviewPublic

Authored by cblack on Wed, May 6, 2:34 AM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Summary

The global application menu has a search field now

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Branch
cblack/appmenu-search (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26476
Build 26494: arc lint + arc unit
cblack created this revision.Wed, May 6, 2:34 AM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, May 6, 2:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack updated this revision to Diff 82125.Wed, May 6, 5:45 PM

Better search

cblack updated this revision to Diff 82138.Wed, May 6, 6:35 PM

Fix some quirks

gikari added a subscriber: gikari.Wed, May 6, 6:47 PM

Is it possible to integrate the search into the help menu, if it exists already or create an entry for it. Much like macOS does.

cblack added a comment.Wed, May 6, 6:52 PM

Is it possible to integrate the search into the help menu, if it exists already or create an entry for it. Much like macOS does.

There's no reliable way to figure out which menu is the "help" one, and there's not a reliable way of modifying a menu for this kind of functionality besides appending a new entry to the end.

cblack updated this revision to Diff 82141.Wed, May 6, 6:56 PM

Add better non-Wayland guards

cblack updated this revision to Diff 82144.Wed, May 6, 7:17 PM

Clear search text on application change

nicolasfella added inline comments.
applets/appmenu/plugin/appmenumodel.cpp
246

Extract the list into a variable before iterating, else this might blow up

See https://github.com/KDE/clazy/blob/master/docs/checks/README-temporary-iterator.md

nicolasfella added inline comments.Thu, May 7, 11:01 AM
applets/appmenu/plugin/appmenumodel.cpp
193

.isEmpty()

196

const

applets/appmenu/plugin/appmenumodel.h
70

const

73

const