Differential D26114

Places: Use Solid::Device::DisplayName for DisplayRole
ClosedPublic
Actions

Authored by meven on Dec 20 2019, 7:11 AM.

Tags

Subscribers

broulik, kfm-devel

Details

Reviewers

Group Reviewers

Summary

BUG: 415281
FIXED-IN: 20.08
Counter-part of D26113

Test Plan

Before:

After:

Diff Detail

Repository

Branch

arcpatch-D26114

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27078
Build 27096: arc lint + arc unit

meven created this revision.Dec 20 2019, 7:11 AM

Restricted Application added a project: Dolphin. · View Herald TranscriptDec 20 2019, 7:11 AM

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

meven requested review of this revision.Dec 20 2019, 7:11 AM

Harbormaster completed remote builds in B20066: Diff 71862.Dec 20 2019, 7:11 AM

broulik added a subscriber: broulik.Dec 20 2019, 9:58 AM

broulik added inline comments.

src/panels/places/placesitem.cpp
218	What when it isn't mounted?

meven mentioned this in D26113: Places: Use Solid::Device::DisplayName for DisplayRole.Dec 21 2019, 2:51 PM

meven edited the summary of this revision. (Show Details)Apr 4 2020, 10:51 AM

Rebasing

Harbormaster completed remote builds in B24713: Diff 79278.Apr 4 2020, 10:52 AM

meven edited the test plan for this revision. (Show Details)Apr 4 2020, 10:53 AM

meven added inline comments.

src/panels/places/placesitem.cpp
218	`if (m_access) {` takes care of this.

meven mentioned this in D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.Apr 5 2020, 11:59 AM

Blocked by D28590

(once the dependent patch lands)

meven added inline comments.May 25 2020, 4:30 AM

src/panels/places/placesitem.cpp
212	The change will be here `m_device.displayName()`

meven marked an inline comment as done.May 25 2020, 4:30 AM

meven mentioned this in R245:cdbfb3e799c7: Add a QString Solid::Device::displayName, used in Fstab Device for network….May 25 2020, 6:06 AM

meven retitled this revision from Places: For mounted volume display mount points instead of description to Places: Use Solid::Device::DisplayName for DisplayRole.May 25 2020, 6:13 AM

Update patch to new dependency

This revision is now accepted and ready to land.May 27 2020, 5:40 AM

Harbormaster completed remote builds in B27078: Diff 83161.May 27 2020, 5:40 AM

Will land after KF 5.71 release

meven mentioned this in R241:5f43507996e5: Places: Use Solid::Device::DisplayName for DisplayRole.May 30 2020, 10:15 AM

meven closed this revision.Jun 16 2020, 5:37 PM

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/panels/places/placesitem.cpp (2 lines)

Diff 83161

CMakeLists.txt

Loading...

src/panels/places/placesitem.cpp

Loading...