bport (Benjamin Port)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 2 2015, 1:17 PM (235 w, 2 d)
Availability
Available

Recent Activity

Wed, Nov 27

bport updated the diff for D24847: KCM Icons fix theme selected when we hit delete theme.

Fix regression (apply button not activated when eeded) and ervin feedback

Wed, Nov 27, 6:53 PM · Plasma
bport updated the diff for D24846: Port kcm icons to kconfigxt.

Take in consideration feedback

Wed, Nov 27, 6:53 PM · Plasma

Oct 30 2019

bport added a comment to D24847: KCM Icons fix theme selected when we hit delete theme.

Indeed don't know why even if isSaveNeeded return true, button is not updated. I will investigate
Thanks for the catch

Oct 30 2019, 5:32 PM · Plasma
bport accepted D25077: Use compile time checked connect.
Oct 30 2019, 12:47 PM · Frameworks
bport updated the diff for D24847: KCM Icons fix theme selected when we hit delete theme.

Take Nate feedback and do a proper fix

Oct 30 2019, 10:38 AM · Plasma
bport updated the diff for D24846: Port kcm icons to kconfigxt.

Take in consideration feedback (cache kicon call)
Port to ManagedConfigModule

Oct 30 2019, 10:37 AM · Plasma

Oct 23 2019

bport added a comment to D24847: KCM Icons fix theme selected when we hit delete theme.

I will update this patch to allow to delete current selected theme but remove bug
So if we have A B C, A selected

  1. we delete B : B pending deletion A still selected
  2. we delete A : A and B pending deletion C selected
Oct 23 2019, 12:19 PM · Plasma
bport added a comment to D24847: KCM Icons fix theme selected when we hit delete theme.

By the way I can select next theme in case we delete the current instead of disable deletion

Oct 23 2019, 11:52 AM · Plasma
bport added a comment to D24847: KCM Icons fix theme selected when we hit delete theme.

Don't know why but is not the case here.
And even if this is the case, I will need explaination on why we want to change theme selection when I delete another theme
I mean if we have 3 themes A B and C. If A is selected, I delete B why the selected theme will be C...

Oct 23 2019, 11:51 AM · Plasma
bport added a dependent revision for D24846: Port kcm icons to kconfigxt: D24847: KCM Icons fix theme selected when we hit delete theme.
Oct 23 2019, 11:31 AM · Plasma
bport added a dependency for D24847: KCM Icons fix theme selected when we hit delete theme: D24846: Port kcm icons to kconfigxt.
Oct 23 2019, 11:31 AM · Plasma
bport added a comment to D24847: KCM Icons fix theme selected when we hit delete theme.

My bad this patch depends on D24846

Oct 23 2019, 11:29 AM · Plasma
bport committed R119:8e37d1c67343: KCM don't support icons effect anymore, clean-up config file (authored by bport).
KCM don't support icons effect anymore, clean-up config file
Oct 23 2019, 11:28 AM
bport closed D24845: KCM don't support icons effect anymore, clean-up config file.
Oct 23 2019, 11:28 AM · Plasma

Oct 22 2019

bport accepted D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration.
Oct 22 2019, 11:06 AM · Plasma
bport added a reviewer for D24845: KCM don't support icons effect anymore, clean-up config file: crossi.
Oct 22 2019, 9:36 AM · Plasma
bport added a reviewer for D24847: KCM Icons fix theme selected when we hit delete theme: crossi.
Oct 22 2019, 9:35 AM · Plasma
bport added a reviewer for D24846: Port kcm icons to kconfigxt: crossi.
Oct 22 2019, 9:35 AM · Plasma
bport added inline comments to D24846: Port kcm icons to kconfigxt.
Oct 22 2019, 7:13 AM · Plasma
bport added a comment to D24847: KCM Icons fix theme selected when we hit delete theme.

Yes sure, by the way the new behavior is the one implemented on other kcm like desktop theme

Oct 22 2019, 7:03 AM · Plasma
bport added reviewers for D24847: KCM Icons fix theme selected when we hit delete theme: mart, ervin, Plasma.
Oct 22 2019, 7:00 AM · Plasma
bport added reviewers for D24846: Port kcm icons to kconfigxt: ervin, mart, Plasma.
Oct 22 2019, 6:59 AM · Plasma
bport requested review of D24848: fix kcm fonts "typo" on connect.
Oct 22 2019, 6:58 AM · Plasma
bport requested review of D24847: KCM Icons fix theme selected when we hit delete theme.
Oct 22 2019, 6:56 AM · Plasma
bport requested review of D24846: Port kcm icons to kconfigxt.
Oct 22 2019, 6:53 AM · Plasma
bport requested review of D24845: KCM don't support icons effect anymore, clean-up config file.
Oct 22 2019, 6:53 AM · Plasma

Oct 21 2019

bport accepted D24821: Add ManagedConfigModule.

Ok for me, when David remarks are addressed

Oct 21 2019, 10:00 AM · Frameworks
bport accepted D24822: Port the desktoptheme kcm to ManagedConfigModule.
Oct 21 2019, 9:35 AM · Plasma
bport requested changes to D24821: Add ManagedConfigModule.
Oct 21 2019, 9:34 AM · Frameworks
bport requested changes to D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration.
Oct 21 2019, 8:40 AM · Plasma
bport accepted D24729: remove unnecessary ; + add const to getter + typo in Roles declaration..
Oct 21 2019, 7:01 AM · Plasma
bport accepted D24730: Port KCMSplashScreen to KConfigXT.
Oct 21 2019, 7:01 AM · Plasma

Oct 16 2019

bport committed R119:36d8d9e32351: KCM fonts : Rearrange code (authored by bport).
KCM fonts : Rearrange code
Oct 16 2019, 3:17 PM
bport committed R119:a4d23764ea46: Port fonts KCM to KConfigXT (authored by bport).
Port fonts KCM to KConfigXT
Oct 16 2019, 3:17 PM
bport closed D24670: KCM fonts : Rearrange code.
Oct 16 2019, 3:17 PM · Plasma
bport closed D24669: Port fonts KCM to KConfigXT.
Oct 16 2019, 3:17 PM · Plasma
bport committed R119:c72a1d5ce982: Simplify kcms cmake file (authored by bport).
Simplify kcms cmake file
Oct 16 2019, 3:17 PM
bport closed D24668: Simplify kcms cmake file.
Oct 16 2019, 3:17 PM · Plasma
bport accepted D24698: Leverage latest KConfig changes.
Oct 16 2019, 2:58 PM · Plasma
bport accepted D24699: Disable the module if the setting is locked down.
Oct 16 2019, 2:58 PM · Plasma
bport requested changes to D24224: Start of the accessibility KCM.
Oct 16 2019, 8:00 AM · Plasma

Oct 15 2019

bport requested review of D24670: KCM fonts : Rearrange code.
Oct 15 2019, 2:41 PM · Plasma
bport requested review of D24669: Port fonts KCM to KConfigXT.
Oct 15 2019, 2:41 PM · Plasma
bport requested review of D24668: Simplify kcms cmake file.
Oct 15 2019, 2:41 PM · Plasma
bport committed R119:8b2f75f13e0e: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work (authored by bport).
Fix a bug in KCM cursor theme, after applying change, cursor preview don't work
Oct 15 2019, 9:29 AM
bport closed D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work.
Oct 15 2019, 9:29 AM · Plasma
bport closed D24519: Delegate KCM cursor theme config management to KConfigXT.
Oct 15 2019, 9:29 AM · Plasma
bport committed R119:fec538fb02e0: Delegate KCM cursor theme config management to KConfigXT (authored by bport).
Delegate KCM cursor theme config management to KConfigXT
Oct 15 2019, 9:29 AM
bport closed D24518: On KCM cursor theme update attribute name.
Oct 15 2019, 9:29 AM · Plasma
bport committed R119:186ab6e9b75e: On KCM cursor theme update attribute name (authored by bport).
On KCM cursor theme update attribute name
Oct 15 2019, 9:29 AM
bport committed R119:f53d7844fbb5: Port kcm cursor to KConfigXT (authored by bport).
Port kcm cursor to KConfigXT
Oct 15 2019, 9:29 AM
bport closed D24517: Port kcm cursor to KConfigXT.
Oct 15 2019, 9:28 AM · Plasma
bport committed R119:29f8346063a4: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method (authored by bport).
Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method
Oct 15 2019, 9:28 AM
bport closed D24516: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method.
Oct 15 2019, 9:28 AM · Plasma
bport updated the diff for D24519: Delegate KCM cursor theme config management to KConfigXT.

Add notify to setPreferredSize

Oct 15 2019, 9:26 AM · Plasma
bport updated the diff for D24517: Port kcm cursor to KConfigXT.

Move install line to the good section

Oct 15 2019, 9:25 AM · Plasma

Oct 10 2019

bport updated subscribers of D24224: Start of the accessibility KCM.
Oct 10 2019, 6:12 PM · Plasma
bport updated the diff for D24518: On KCM cursor theme update attribute name.

Remove change not related to this commit

Oct 10 2019, 1:51 PM · Plasma
bport updated the diff for D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work.

a cleaner approach to fix the bug

Oct 10 2019, 1:49 PM · Plasma
bport updated the diff for D24519: Delegate KCM cursor theme config management to KConfigXT.

Take in consideration feedbacks

Oct 10 2019, 1:49 PM · Plasma
bport updated the diff for D24517: Port kcm cursor to KConfigXT.
  • Install kcfg file
  • Remove uneeded include from kcfg file
Oct 10 2019, 1:48 PM · Plasma
bport updated the diff for D24516: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method.

Remove commented include

Oct 10 2019, 1:47 PM · Plasma

Oct 9 2019

bport added inline comments to D24519: Delegate KCM cursor theme config management to KConfigXT.
Oct 9 2019, 6:38 PM · Plasma
bport requested review of D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work.
Oct 9 2019, 3:51 PM · Plasma
bport updated the summary of D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work.
Oct 9 2019, 3:50 PM · Plasma
bport added inline comments to D24517: Port kcm cursor to KConfigXT.
Oct 9 2019, 3:00 PM · Plasma
bport requested review of D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work.
Oct 9 2019, 2:37 PM · Plasma
bport requested review of D24519: Delegate KCM cursor theme config management to KConfigXT.
Oct 9 2019, 2:36 PM · Plasma
bport requested review of D24518: On KCM cursor theme update attribute name.
Oct 9 2019, 2:36 PM · Plasma
bport requested review of D24517: Port kcm cursor to KConfigXT.
Oct 9 2019, 2:36 PM · Plasma
bport requested review of D24516: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method.
Oct 9 2019, 2:36 PM · Plasma

Aug 26 2018

bport committed R240:206c5123c37e: Change documentation to reflect the real toolchain CMake name (authored by bport).
Change documentation to reflect the real toolchain CMake name
Aug 26 2018, 10:47 AM
bport closed D15084: Change documentation to reflect the real toolchain CMake name.
Aug 26 2018, 10:47 AM · Build System, Frameworks

Aug 25 2018

This is a test notification, sent at Sat, Aug 25, 8:53 PM.
Aug 25 2018, 6:53 PM
This is a test notification, sent at Sat, Aug 25, 8:53 PM.
Aug 25 2018, 6:53 PM
This is a test notification, sent at Sat, Aug 25, 8:53 PM.
Aug 25 2018, 6:53 PM
This is a test notification, sent at Sat, Aug 25, 8:52 PM.
Aug 25 2018, 6:52 PM
This is a test notification, sent at Sat, Aug 25, 8:52 PM.
Aug 25 2018, 6:52 PM
bport committed R1003:fe52a9edcb32: Extend rentalcar support (authored by bport).
Extend rentalcar support
Aug 25 2018, 6:36 PM
bport closed D15067: Extend rentalcar support.
Aug 25 2018, 6:35 PM · KDE PIM
bport requested review of D15084: Change documentation to reflect the real toolchain CMake name.
Aug 25 2018, 6:33 PM · Build System, Frameworks
bport updated the diff for D15067: Extend rentalcar support.

Remove uneeded qDebug()

Aug 25 2018, 6:19 PM · KDE PIM
bport updated the diff for D15067: Extend rentalcar support.

take in consideration feedback

Aug 25 2018, 6:01 PM · KDE PIM

Aug 24 2018

bport moved T9372: Improve rentalcar json-ld extraction from Actionable to In Progress on the KDE Itinerary board.
Aug 24 2018, 11:42 PM · KDE Itinerary
bport renamed T9372: Improve rentalcar json-ld extraction from Rentalcars.com extractor to Improve rentalcar json-ld extraction.
Aug 24 2018, 11:42 PM · KDE Itinerary
bport requested review of D15067: Extend rentalcar support.
Aug 24 2018, 10:58 PM · KDE PIM

Aug 23 2018

bport committed R81:715d5f5c3f90: Use same case everywhere for pickup / dropoff (authored by bport).
Use same case everywhere for pickup / dropoff
Aug 23 2018, 4:49 PM
bport closed D14997: Use same case everywhere for pickup / dropoff.
Aug 23 2018, 4:49 PM · KDE PIM
bport committed R1003:382bb1c4c851: Fix pickup and dropoff location case (authored by bport).
Fix pickup and dropoff location case
Aug 23 2018, 4:31 PM
bport closed D14995: Fix pickup and dropoff location case.
Aug 23 2018, 4:31 PM · KDE PIM

Aug 22 2018

bport added a comment to D14995: Fix pickup and dropoff location case.

My only concern was about breaking API compatibility, no problem with that?

Aug 22 2018, 12:06 PM · KDE PIM
bport requested review of D14997: Use same case everywhere for pickup / dropoff.
Aug 22 2018, 11:43 AM · KDE PIM
bport added a dependent revision for D14995: Fix pickup and dropoff location case: D14997: Use same case everywhere for pickup / dropoff.
Aug 22 2018, 11:43 AM · KDE PIM
bport added a comment to D14995: Fix pickup and dropoff location case.

Seems to be the same as google (lowercase for off/up)

Aug 22 2018, 11:35 AM · KDE PIM
bport updated the summary of D14995: Fix pickup and dropoff location case.
Aug 22 2018, 11:28 AM · KDE PIM
bport added reviewers for D14995: Fix pickup and dropoff location case: mlaurent, vkrause.
Aug 22 2018, 11:26 AM · KDE PIM
bport requested review of D14995: Fix pickup and dropoff location case.
Aug 22 2018, 11:25 AM · KDE PIM

Aug 16 2018

bport committed R1003:36bd73a12e54: Add booking.com unstrucured data extractor (french) (authored by bport).
Add booking.com unstrucured data extractor (french)
Aug 16 2018, 8:27 AM
bport closed D14841: Add booking.com unstrucured data extractor (french).
Aug 16 2018, 8:27 AM · KDE PIM

Aug 14 2018

bport created T9373: Extractor for sixt.
Aug 14 2018, 9:16 PM · KDE Itinerary