bport (Benjamin Port)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 2 2015, 1:17 PM (246 w, 4 d)
Availability
Available

Recent Activity

Thu, Feb 20

bport added inline comments to D27477: KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT.
Thu, Feb 20, 9:04 AM · KWin
bport added inline comments to D27463: KconfigXT: Add a value attribute to Enum field choices.
Thu, Feb 20, 9:01 AM · Frameworks
bport accepted D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings.
Thu, Feb 20, 8:51 AM · Plasma
bport accepted D27116: KCM/Component email: simplify code.
Thu, Feb 20, 8:45 AM · Plasma
bport accepted D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it.
Thu, Feb 20, 8:43 AM · Plasma

Wed, Feb 19

bport added a dependency for D27503: [KCM Spellchecking] port to KPropertySkeletonItem: D27502: Create ConfigView an unmanaged ConfigWidget.
Wed, Feb 19, 2:04 PM · Plasma
bport added a dependent revision for D27502: Create ConfigView an unmanaged ConfigWidget: D27503: [KCM Spellchecking] port to KPropertySkeletonItem.
Wed, Feb 19, 2:04 PM · Frameworks
bport requested review of D27503: [KCM Spellchecking] port to KPropertySkeletonItem.
Wed, Feb 19, 2:03 PM · Plasma
bport requested review of D27502: Create ConfigView an unmanaged ConfigWidget.
Wed, Feb 19, 2:02 PM · Frameworks
bport added inline comments to D27497: Fix code generation for entries with min/max.
Wed, Feb 19, 12:04 PM · Frameworks
bport added inline comments to D27482: Update kdeglobals config file for Breeze widgetStyle.
Wed, Feb 19, 9:38 AM · Plasma
bport accepted D27395: KCM/ComponentChooser Treat cases when there is no app for a usage.
Wed, Feb 19, 9:07 AM · Plasma
bport committed R119:4dfaffd10c16: Merge branch 'Plasma/5.18' (authored by bport).
Merge branch 'Plasma/5.18'
Wed, Feb 19, 8:07 AM
bport closed D27470: Set good default value for cursor theme and size in KRDB.
Wed, Feb 19, 7:56 AM · Plasma
bport committed R119:ca9f0eeb9b53: Set good default value for cursor theme and size in KRDB (authored by bport).
Set good default value for cursor theme and size in KRDB
Wed, Feb 19, 7:56 AM

Tue, Feb 18

bport accepted D27323: KCM KWinTabBox port to KConfigXT : use generated kcfg settings to load and save config.
Tue, Feb 18, 1:05 PM · KWin
bport added a comment to D27470: Set good default value for cursor theme and size in KRDB.

This is not a KCM, and because of how stuff works with KRDB we can't reuse kcfg easily there (because build by 5 or 6 kcm)
About the 0 as default value, perhaps we can change that but it's totally unrelated to this patch, goal there is only to honor default value as set by kcfg

Tue, Feb 18, 10:01 AM · Plasma
bport requested review of D27470: Set good default value for cursor theme and size in KRDB.
Tue, Feb 18, 9:01 AM · Plasma
bport updated the diff for D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.

fix build. KRDB can't use Kxftconfig directly so we can't avoid stuff in kdeglobals

Tue, Feb 18, 8:58 AM · Plasma

Mon, Feb 17

bport added inline comments to D27127: Solid-device-automounter/kcm: Use KConfigXT in ui.
Mon, Feb 17, 5:34 PM · Plasma
bport updated the diff for D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.

Add missing space

Mon, Feb 17, 4:33 PM · Plasma
bport added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

I just read bug report again and the from seems to came from , not from localization.

Mon, Feb 17, 12:29 PM · Plasma
bport added a comment to D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.

I think a good fix can be to use @davidedmundson solution combined with a check to know if font styleName is not set (if it set it will be not translated.

Mon, Feb 17, 12:09 PM · Plasma
bport updated the diff for D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.

Add kconfupdate script to remove unused keys

Mon, Feb 17, 9:56 AM · Plasma
bport requested review of D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM.
Mon, Feb 17, 9:19 AM · Frameworks

Fri, Feb 14

bport requested changes to D27395: KCM/ComponentChooser Treat cases when there is no app for a usage.
Fri, Feb 14, 11:08 AM · Plasma
bport committed R119:d43007c4317a: Merge branch 'Plasma/5.18' (authored by bport).
Merge branch 'Plasma/5.18'
Fri, Feb 14, 8:38 AM
bport committed R119:0c4da0774e43: [KCM Fonts] force need save to false during load to avoid state to be true too… (authored by bport).
[KCM Fonts] force need save to false during load to avoid state to be true too…
Fri, Feb 14, 8:38 AM
bport closed D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early.
Fri, Feb 14, 8:38 AM · Plasma
bport added a comment to D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early.

I will look at a proper fix in the next days

Fri, Feb 14, 8:36 AM · Plasma
bport added a comment to D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early.

Yes emiting signal from setNeedsSave in all case fix stuff too

Fri, Feb 14, 7:45 AM · Plasma

Thu, Feb 13

bport added a comment to D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early.

@davidedmundson
We have 2 bugs :

  • KCModuleQML apply button will stay disabled forever if at the end of load function need save is true (probably qml connection not yet done or something like that I guess, not yet found why) => We need to investigate on it too, I reproduced the same behavior with KCM icons by changing a setting at the end of load method.
  • In theory at the end of load we don't need to save data. However in some case for the font KCM data are dirty and need save. Came from Qt font comparison, if in your kdeglobals you have a font definition without style name, our algorithm to match a nearest font will add one, and font comparison between referential data and current data will return false because they are different.
Thu, Feb 13, 11:59 PM · Plasma
bport accepted D27381: [sidebar] Resolve changes in module before switching.

Can reproduce bug and fix work as expected

Thu, Feb 13, 9:31 PM · Plasma
bport requested review of D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early.
Thu, Feb 13, 8:17 PM · Plasma

Wed, Feb 12

bport committed R237:059a4feee45b: Add setNotifyFunction to KPropertySkeletonItem (authored by bport).
Add setNotifyFunction to KPropertySkeletonItem
Wed, Feb 12, 10:59 AM
bport closed D27342: Add setNotifyFunction to KPropertySkeletonItem.
Wed, Feb 12, 10:59 AM · Frameworks
bport updated the diff for D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.

Fix reset and default button for Anti Aliasing area (states were ok, but UI values were not updated after clicking them)

Wed, Feb 12, 10:39 AM · Plasma
bport updated the diff for D27342: Add setNotifyFunction to KPropertySkeletonItem.

Fix doc

Wed, Feb 12, 10:26 AM · Frameworks
bport requested review of D27342: Add setNotifyFunction to KPropertySkeletonItem.
Wed, Feb 12, 9:52 AM · Frameworks

Tue, Feb 11

bport added inline comments to D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.
Tue, Feb 11, 2:00 PM · Plasma
bport updated the diff for D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.

fix coding style

Tue, Feb 11, 12:38 PM · Plasma
bport updated the diff for D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.

coding style

Tue, Feb 11, 10:50 AM · Plasma
bport updated the diff for D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.

Fix

Tue, Feb 11, 10:24 AM · Plasma
bport updated the diff for D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.

Take in consideration Cyril's feedbacks

Tue, Feb 11, 9:52 AM · Plasma
bport accepted D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
Tue, Feb 11, 9:01 AM · Plasma

Mon, Feb 10

bport accepted D27155: libnotificationmanager : add app-specific kconfig settings.
Mon, Feb 10, 8:12 AM · Plasma
bport added inline comments to D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
Mon, Feb 10, 8:11 AM · Plasma

Wed, Feb 5

bport accepted D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton..
Wed, Feb 5, 2:13 PM · Frameworks
bport added inline comments to D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton..
Wed, Feb 5, 2:09 PM · Frameworks
bport accepted D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton..
Wed, Feb 5, 2:02 PM · Frameworks

Tue, Feb 4

bport requested review of D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem.
Tue, Feb 4, 4:32 PM · Plasma
bport added a comment to D26842: Fix fonts KCM button state.

Does this mean the default fonts have a style name of "Regular" now? That will break setting bold fonts and such, see https://phabricator.kde.org/D9070.

Tue, Feb 4, 10:11 AM · Plasma
bport committed R296:cacff0a30bc8: Allow to use KPropertySkeletonItem in ManagedConfigModule (authored by bport).
Allow to use KPropertySkeletonItem in ManagedConfigModule
Tue, Feb 4, 8:46 AM
bport closed D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule.
Tue, Feb 4, 8:46 AM · Frameworks
bport committed R119:96e4fed829ff: Merge branch 'origin/Plasma/5.18' (authored by bport).
Merge branch 'origin/Plasma/5.18'
Tue, Feb 4, 8:35 AM
bport committed R119:0a107dcbe9fc: Fix fonts KCM button state (authored by bport).
Fix fonts KCM button state
Tue, Feb 4, 8:31 AM
bport closed D26842: Fix fonts KCM button state.
Tue, Feb 4, 8:31 AM · Plasma
bport updated the diff for D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule.

cleanup

Tue, Feb 4, 8:10 AM · Frameworks
bport updated the diff for D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule.

Don't cast twice if not needed

Tue, Feb 4, 8:06 AM · Frameworks

Mon, Feb 3

bport requested review of D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule.
Mon, Feb 3, 4:25 PM · Frameworks
bport added a comment to D26842: Fix fonts KCM button state.

We are getting duplicates of https://bugs.kde.org/show_bug.cgi?id=416358, so I guess it would be nice if this made it into 5.18.

Mon, Feb 3, 8:20 AM · Plasma
bport added a reviewer for D26842: Fix fonts KCM button state: ngraham.
Mon, Feb 3, 8:19 AM · Plasma

Wed, Jan 29

bport updated the diff for D26842: Fix fonts KCM button state.

fix coding style

Wed, Jan 29, 2:02 PM · Plasma
bport added inline comments to D26842: Fix fonts KCM button state.
Wed, Jan 29, 1:47 PM · Plasma
bport added inline comments to D26842: Fix fonts KCM button state.
Wed, Jan 29, 1:44 PM · Plasma
bport committed R119:69ac53df265e: KCM KDED: Add immutability and fix default, reset, apply buttons (authored by bport).
KCM KDED: Add immutability and fix default, reset, apply buttons
Wed, Jan 29, 1:23 PM
bport closed D26784: KCM KDED: Add immutability and fix default, reset, apply buttons.
Wed, Jan 29, 1:23 PM · Plasma

Jan 22 2020

bport committed R293:71fb41ae9ae8: Migrate config from KConfig to KConfigXt in order to allow KCM to use it (authored by bport).
Migrate config from KConfig to KConfigXt in order to allow KCM to use it
Jan 22 2020, 4:21 PM
bport closed D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it.
Jan 22 2020, 4:21 PM · Baloo, Frameworks
bport committed R119:661b40c9ab0b: KCM Baloo: Migrate to KConfigXT and add immutability (authored by bport).
KCM Baloo: Migrate to KConfigXT and add immutability
Jan 22 2020, 4:18 PM
bport closed D26401: KCM Baloo: Migrate to KConfigXT and add immutability.
Jan 22 2020, 4:18 PM · Plasma
bport updated the diff for D26784: KCM KDED: Add immutability and fix default, reset, apply buttons.

small fixes

Jan 22 2020, 4:17 PM · Plasma
bport updated the diff for D26784: KCM KDED: Add immutability and fix default, reset, apply buttons.

Take in consideration feedback

Jan 22 2020, 4:07 PM · Plasma
bport requested review of D26842: Fix fonts KCM button state.
Jan 22 2020, 3:10 PM · Plasma
bport updated the diff for D26784: KCM KDED: Add immutability and fix default, reset, apply buttons.

fix coding style

Jan 22 2020, 3:06 PM · Plasma

Jan 20 2020

bport added inline comments to D26784: KCM KDED: Add immutability and fix default, reset, apply buttons.
Jan 20 2020, 1:27 PM · Plasma
bport updated the diff for D26784: KCM KDED: Add immutability and fix default, reset, apply buttons.

Fix apply button state after saving a first time

Jan 20 2020, 1:26 PM · Plasma
bport requested review of D26784: KCM KDED: Add immutability and fix default, reset, apply buttons.
Jan 20 2020, 11:37 AM · Plasma

Jan 14 2020

bport committed R295:f52314e6cf19: Show button respecting what is declared by KCModule (authored by bport).
Show button respecting what is declared by KCModule
Jan 14 2020, 9:50 AM
bport closed D26519: Show button respecting what is declared by KCModule.
Jan 14 2020, 9:50 AM · Frameworks
bport closed D26518: ModuleView: Hide button when KCModule don't need them.
Jan 14 2020, 9:46 AM · Plasma
bport committed R124:01cecb1602aa: ModuleView: Hide button when KCModule don't need them (authored by bport).
ModuleView: Hide button when KCModule don't need them
Jan 14 2020, 9:46 AM
bport committed R265:4dc3f18f1443: Fix KCMModule::setButtons documentation, if Apply is activated we also want to… (authored by bport).
Fix KCMModule::setButtons documentation, if Apply is activated we also want to…
Jan 14 2020, 9:45 AM
bport closed D26517: Fix KCMModule::setButtons documentation, if Apply is activated we also want to show a Reset button.
Jan 14 2020, 9:45 AM · Frameworks

Jan 8 2020

bport abandoned D26523: KCM kded, fix immutability and reset/apply/default button state.
Jan 8 2020, 4:32 PM · Plasma
bport added a comment to D26523: KCM kded, fix immutability and reset/apply/default button state.

Wait this code review is merged and will port it to KConfigXT
https://phabricator.kde.org/D26506

Jan 8 2020, 4:32 PM · Plasma
bport requested review of D26523: KCM kded, fix immutability and reset/apply/default button state.
Jan 8 2020, 2:56 PM · Plasma
bport updated the diff for D26519: Show button respecting what is declared by KCModule.

Simplify code

Jan 8 2020, 10:40 AM · Frameworks
bport added inline comments to D26519: Show button respecting what is declared by KCModule.
Jan 8 2020, 10:12 AM · Frameworks
bport updated the diff for D26518: ModuleView: Hide button when KCModule don't need them.

Set visibility for help too

Jan 8 2020, 10:09 AM · Plasma
bport requested review of D26519: Show button respecting what is declared by KCModule.
Jan 8 2020, 9:45 AM · Frameworks
bport requested review of D26518: ModuleView: Hide button when KCModule don't need them.
Jan 8 2020, 9:44 AM · Plasma
bport requested review of D26517: Fix KCMModule::setButtons documentation, if Apply is activated we also want to show a Reset button.
Jan 8 2020, 9:44 AM · Frameworks

Jan 7 2020

bport committed R237:e88f9309e5db: Fix API doc, usrSave is called from save not deprecated writeConfig (authored by bport).
Fix API doc, usrSave is called from save not deprecated writeConfig
Jan 7 2020, 4:08 PM
bport closed D26495: Fix API doc, usrSave is called from save not deprecated writeConfig.
Jan 7 2020, 4:08 PM · Frameworks
bport requested review of D26495: Fix API doc, usrSave is called from save not deprecated writeConfig.
Jan 7 2020, 2:57 PM · Frameworks
bport committed R295:6d6e2427f8e2: Update KPluginSelector to allow KCM to show good state for reset, apply and… (authored by bport).
Update KPluginSelector to allow KCM to show good state for reset, apply and…
Jan 7 2020, 9:25 AM
bport closed D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button.
Jan 7 2020, 9:25 AM · Frameworks
bport committed R119:be1eacc05b1f: KCM runners: fix default button (authored by bport).
KCM runners: fix default button
Jan 7 2020, 9:25 AM
bport committed R119:9d200f06d6cd: KCM runners : fix reset and default behavior (authored by bport).
KCM runners : fix reset and default behavior
Jan 7 2020, 9:25 AM