bport (Benjamin Port)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 2 2015, 1:17 PM (261 w, 2 d)
Availability
Available

Recent Activity

Tue, Jun 2

bport committed R108:0c9e4815776c: Dock with windows go below will be on top of all windows and same layer of… (authored by bport).
Dock with windows go below will be on top of all windows and same layer of…
Tue, Jun 2, 5:42 PM
bport committed R120:24c90cab3b54: Set KRunner to be on top of above windows (authored by bport).
Set KRunner to be on top of above windows
Tue, Jun 2, 5:42 PM

Fri, May 29

bport committed R108:301d3defc54f: Take in consideration keyboard shortcuts inhibit rename to V1 (authored by bport).
Take in consideration keyboard shortcuts inhibit rename to V1
Fri, May 29, 9:34 AM
bport committed R108:4a90f6ab603d: Add support to keyboard shortcuts inhibitor (authored by bport).
Add support to keyboard shortcuts inhibitor
Fri, May 29, 8:50 AM
bport closed D29272: Add support to keyboard shortcuts inhibitor.
Fri, May 29, 8:50 AM · KWin
bport committed R108:98701b6f38e8: Wayland server getters => const (authored by bport).
Wayland server getters => const
Fri, May 29, 8:41 AM

Thu, May 28

bport committed R119:a5f2a5400ca7: Merge branch 'Plasma/5.19' (authored by bport).
Merge branch 'Plasma/5.19'
Thu, May 28, 6:52 PM
bport committed R119:8ef4403ac82d: KCM Notifications: Open app page only after model is loaded (authored by bport).
KCM Notifications: Open app page only after model is loaded
Thu, May 28, 6:52 PM

Tue, May 26

bport updated the diff for D29272: Add support to keyboard shortcuts inhibitor.

Remove unused include

Tue, May 26, 8:04 AM · KWin

Mon, May 18

bport added a comment to T13008: Figure out a good UI for the "show which settings have been changed" feature.

This feature need to be discoverable easily by end user. We spoke about beginners

Mon, May 18, 3:28 PM · Plasma, VDG

Tue, May 12

bport updated the diff for D29272: Add support to keyboard shortcuts inhibitor.

Adapt to method rename on wayland server

Tue, May 12, 1:11 PM · KWin

Mon, May 11

bport updated the diff for D28221: Don't write default value to configuration file when default value came from /etc/* file.

Simplify the patch and adapt unittest

Mon, May 11, 10:47 PM · Frameworks
bport added a comment to D28461: In sidebar mode show if a module is in default state or not.

Default indicator discussion is now on https://phabricator.kde.org/T13008

Mon, May 11, 7:52 PM · Plasma

May 5 2020

bport planned changes to D28221: Don't write default value to configuration file when default value came from /etc/* file.
May 5 2020, 9:56 PM · Frameworks
bport added a comment to D28221: Don't write default value to configuration file when default value came from /etc/* file.

Ah! Now it actually makes sense to me. If we are changing what revertToDefault() does, then it makes sense to change the if() condition for calling it. Basically, now that it does the right thing in both cases (default from C++ and default from system file) it can be called in both cases, while before it was only called if there was no default from a system file. Right?

I'm still wondering about this though: "If we're saving a value equal to the C++ default, then we have to write it out, otherwise upon reading the global-file default will interfer."
Your unittest shows that revertToDefault() will lead to the global-file value being read.
Doesn't this mean that this code is wrong then?

 if (value == "cppdefault") {
    cg.revertToDefault(key);
} else {
    cg.writeEntry(key, value);
}

That's the code you're using everywhere, so that's actually the code that would be good to unittest ;-)
Isn't this buggy when the value actually *is* cppdefault, and there is a system config file with another default value?

Indeed probably need to update configuration too.

Did you mean documentation? I know this is all about configuration ;) but the bit that's missing is to update the documentation, and add a task to get rid of the hasDefault() everywhere before revertToDefault is called. Assuming I'm wrong above about there being a bug left :-)

May 5 2020, 8:39 PM · Frameworks
bport updated the diff for D28221: Don't write default value to configuration file when default value came from /etc/* file.
  • Fix comments
  • Ensure we don't have problem if we set value to "defaultcpp" and a global setting override it
May 5 2020, 8:33 PM · Frameworks
bport accepted D29155: [Fonts KCM] Remove redundant nearestExistingFont().

ok then ship it

May 5 2020, 12:34 PM · Plasma
bport abandoned D29231: Add keyboard_shortcuts_inhibit protocol.

Follow up on gitlab
https://invent.kde.org/kde/kwayland-server/-/merge_requests/1

May 5 2020, 9:46 AM · Frameworks

May 4 2020

bport added a comment to D29155: [Fonts KCM] Remove redundant nearestExistingFont().

I don't think we will have same behavior, we don't only check name but also size, type...
If we are ok to fallback in all case to the same font that can work.

May 4 2020, 3:43 PM · Plasma
bport updated the diff for D29272: Add support to keyboard shortcuts inhibitor.

Inhibit only modifier shortcut too

May 4 2020, 8:29 AM · KWin

Apr 30 2020

bport accepted D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().
Apr 30 2020, 7:51 AM · Plasma

Apr 29 2020

bport accepted D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller.

OK for me, as long as VDG is ok with this behavior

Apr 29 2020, 1:57 PM · Plasma
bport added a comment to D29272: Add support to keyboard shortcuts inhibitor.

I will fix that and allow meta inhibition

Apr 29 2020, 11:17 AM · KWin
bport added a comment to D29272: Add support to keyboard shortcuts inhibitor.
"The Wayland compositor is however under no obligation to disable
 all of its shortcuts, and may keep some special key combo for its own
 use, including but not limited to one allowing the user to forcibly
 restore normal keyboard events routing in the case of an unwilling
 client. The compositor may also use the same key combo to reactivate
 an existing shortcut inhibitor that was previously deactivated on
 user request."

Do we think it's important to have this when this lands or just deal with it if it becomes an issue?

I think it should be relatively easy, just an earlier filter that calls:
waylandServer()->keyboardShortcutsInhibitManager()->getShortcutsInhibitor(surface, seat)->setActive(false);

Apr 29 2020, 10:19 AM · KWin
bport retitled D29231: Add keyboard_shortcuts_inhibit protocol from [WIP] Add keyboard_shortcuts_inhibit protocol to Add keyboard_shortcuts_inhibit protocol.
Apr 29 2020, 9:24 AM · Frameworks
bport requested review of D29272: Add support to keyboard shortcuts inhibitor.
Apr 29 2020, 8:50 AM · KWin
bport updated the diff for D29231: Add keyboard_shortcuts_inhibit protocol.

Simplify code arround QHash and QPair

Apr 29 2020, 8:43 AM · Frameworks
bport accepted D29120: KCM Fonts disable AA items if they are immutable.
Apr 29 2020, 8:39 AM · Plasma

Apr 27 2020

bport updated the diff for D29231: Add keyboard_shortcuts_inhibit protocol.

fix qobject macro indentation

Apr 27 2020, 9:56 PM · Frameworks
bport updated the diff for D29231: Add keyboard_shortcuts_inhibit protocol.

fix test, and take in consideration zzag feedback

Apr 27 2020, 9:54 PM · Frameworks
bport updated the diff for D29231: Add keyboard_shortcuts_inhibit protocol.

Use client not display for KeyboardShortcutsInhibitorInterface

Apr 27 2020, 4:07 PM · Frameworks
bport updated the diff for D29231: Add keyboard_shortcuts_inhibit protocol.

added const to wrong line

Apr 27 2020, 3:43 PM · Frameworks
bport updated the summary of D29231: Add keyboard_shortcuts_inhibit protocol.
Apr 27 2020, 3:40 PM · Frameworks
bport updated the diff for D29231: Add keyboard_shortcuts_inhibit protocol.

Cyril feedback

Apr 27 2020, 3:40 PM · Frameworks
bport closed D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order.
Apr 27 2020, 3:40 PM · Frameworks
bport committed R127:185f40195dc0: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order (authored by bport).
[Wayland] Add to PlasmaWindowManagement protocol windows stacking order
Apr 27 2020, 3:40 PM
bport requested review of D29231: Add keyboard_shortcuts_inhibit protocol.
Apr 27 2020, 3:24 PM · Frameworks
bport added a dependent revision for D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order: D29231: Add keyboard_shortcuts_inhibit protocol.
Apr 27 2020, 3:24 PM · Frameworks
bport committed R120:c46446e65b98: [libtaskmanager] add stacking order data for wayland (authored by bport).
[libtaskmanager] add stacking order data for wayland
Apr 27 2020, 3:23 PM
bport closed D29056: [libtaskmanager] add stacking order data for wayland.
Apr 27 2020, 3:23 PM · Plasma
bport committed R108:750dd068e5e5: [Wayland] Send stacking order event through plasma window management protocol (authored by bport).
[Wayland] Send stacking order event through plasma window management protocol
Apr 27 2020, 3:22 PM
bport closed D29055: [Wayland] Send stacking order event through plasma window management protocol.
Apr 27 2020, 3:22 PM · KWin
bport added a comment to T13008: Figure out a good UI for the "show which settings have been changed" feature.

I feared that the overview isn't easily possible. Would it be feasable to show a list of KCMs that have non-default values? I'm not sure how useful that would be though, if the user would already know the setting they're searching for is in a particular KCM they probably would've found it themselves.

Apr 27 2020, 10:10 AM · Plasma, VDG
bport updated the diff for D29055: [Wayland] Send stacking order event through plasma window management protocol.

add space and rename variable

Apr 27 2020, 7:31 AM · KWin
bport updated the diff for D29055: [Wayland] Send stacking order event through plasma window management protocol.

fix variable name

Apr 27 2020, 7:12 AM · KWin

Apr 24 2020

bport updated the diff for D29055: [Wayland] Send stacking order event through plasma window management protocol.

take in consideration zzag review

Apr 24 2020, 11:08 AM · KWin

Apr 22 2020

bport added inline comments to D29064: Support module commandline paramenter.
Apr 22 2020, 3:47 PM · Plasma
bport updated the diff for D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order.

Add missing const ref and fix coding style

Apr 22 2020, 3:10 PM · Frameworks
bport committed R104:b3b45721ee17: fix(kded): center action OSD on wayland (authored by bport).
fix(kded): center action OSD on wayland
Apr 22 2020, 3:03 PM
bport closed D28916: fix(kded): center action OSD on wayland.
Apr 22 2020, 3:03 PM · Plasma
bport committed R104:b5f15cc250b4: refactor(kcm): remove unused QTimer field (authored by bport).
refactor(kcm): remove unused QTimer field
Apr 22 2020, 3:00 PM
bport added a comment to T13008: Figure out a good UI for the "show which settings have been changed" feature.

I know this is a bit outside the scope of this task but maybe a backup & restore page with a reset button would be good? This page would of course have to have appropriate warnings but it would probably help some users if they could

  • get an overview of all settings they changed, with a list of links to the actual settings pages?
  • backup their configuration
  • restore old configurations
  • reset all settings This would enable users to freely experiment with the settings without the fear of breaking something / toggling some behaviours they'll not find again. Just back up and everything's safe. Backups into a file then that would also easily allow users to synchronize their settings from PC to PC without needing to copy their whole home or .config folder (possibly integrate KDE Connect here?). I definitely agree that a reset button is dangerous but I think if we display appropriate warnings and require the user to put in their password then it should be just fine. After all, how many users have accidentally reset their Android phone?
Apr 22 2020, 2:28 PM · Plasma, VDG
bport updated the diff for D29055: [Wayland] Send stacking order event through plasma window management protocol.

Expose plasma window management interface instead of internal id to avoid another window id exposed

Apr 22 2020, 2:07 PM · KWin
bport updated the diff for D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order.

Increase protocol version and use const ref for QVector parameter

Apr 22 2020, 1:57 PM · Frameworks
bport planned changes to D29055: [Wayland] Send stacking order event through plasma window management protocol.
Apr 22 2020, 6:49 AM · KWin

Apr 21 2020

bport retitled D28460: Add KCModuleData as base class for plugin from Add KCModuleDada as base class for plugin to Add KCModuleData as base class for plugin.
Apr 21 2020, 8:08 PM · Frameworks
bport updated the diff for D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order.
  • Send stack order on bind
  • Check ressource have good protocol version
Apr 21 2020, 4:27 PM · Frameworks
bport added a dependent revision for D29055: [Wayland] Send stacking order event through plasma window management protocol: D29056: [libtaskmanager] add stacking order data for wayland.
Apr 21 2020, 2:56 PM · KWin
bport added a dependent revision for D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order: D29056: [libtaskmanager] add stacking order data for wayland.
Apr 21 2020, 2:56 PM · Frameworks
bport requested review of D29056: [libtaskmanager] add stacking order data for wayland.
Apr 21 2020, 2:56 PM · Plasma
bport requested review of D29055: [Wayland] Send stacking order event through plasma window management protocol.
Apr 21 2020, 2:55 PM · KWin
bport requested review of D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order.
Apr 21 2020, 2:54 PM · Frameworks
bport added a comment to T13008: Figure out a good UI for the "show which settings have been changed" feature.

We don't manage default for volume for example so nobody as idea to put revert to default for volume, those icons need only to be when that make sense.
I guess we can use this task to also discuss https://phabricator.kde.org/D28461 because they are linked.

Apr 21 2020, 5:49 AM · Plasma, VDG

Apr 20 2020

bport added a comment to D28221: Don't write default value to configuration file when default value came from /etc/* file.

Indeed probably need to update documentation too.
Not sure why we didn't allow to track default value from file in the past by the way.

Apr 20 2020, 9:26 AM · Frameworks
bport added a comment to D28740: [Notifications] Don't show do not disturb end date beyond 100 days.

This is for displaying whether do not disturb is on. The "until disabled" option just sets it to one year in the future. But it's odd to show "until 2021", so we don't show the date when it's too far in the future.

Apr 20 2020, 9:15 AM · Plasma
bport added a comment to D28740: [Notifications] Don't show do not disturb end date beyond 100 days.

According to settings.h documentation
When invalid or in the past, do not disturb mode should be considered disabled.

Apr 20 2020, 9:12 AM · Plasma
bport updated the diff for D28221: Don't write default value to configuration file when default value came from /etc/* file.

Add KConfig unittest

Apr 20 2020, 8:57 AM · Frameworks

Apr 18 2020

bport added a comment to D28221: Don't write default value to configuration file when default value came from /etc/* file.

Ok I will add a kconfig test

Apr 18 2020, 7:19 PM · Frameworks

Apr 17 2020

bport added inline comments to D28889: Avoid crash in KWin::DrmOutput::updateCursor.
Apr 17 2020, 4:21 PM · KWin
bport added inline comments to D28889: Avoid crash in KWin::DrmOutput::updateCursor.
Apr 17 2020, 4:14 PM · KWin
bport added inline comments to D28916: fix(kded): center action OSD on wayland.
Apr 17 2020, 2:31 PM · Plasma
bport accepted D27988: KCM/Compositing: Use KConfig XT in UI.
Apr 17 2020, 12:52 PM · KWin
bport committed R108:864f3558705e: Set cursor size default to 24 to align with KCM (authored by bport).
Set cursor size default to 24 to align with KCM
Apr 17 2020, 12:50 PM
bport closed D28654: Set cursor size default to 24 to align with KCM.
Apr 17 2020, 12:50 PM · KWin
bport committed R237:be28e096c533: Add force save behavior to KEntryMap (authored by bport).
Add force save behavior to KEntryMap
Apr 17 2020, 12:49 PM
bport closed D28128: Add force save behavior to KEntryMap.
Apr 17 2020, 12:49 PM · Frameworks
bport committed R120:7d19c5fc0fa7: Set default cursor size as 24 to follow new default on KCM (authored by bport).
Set default cursor size as 24 to follow new default on KCM
Apr 17 2020, 12:46 PM
bport closed D28655: Set default cursor size as 24 to follow new default on KCM.
Apr 17 2020, 12:46 PM · Plasma
bport closed D28653: Set cursor size default to 24 to align with KCM default value.
Apr 17 2020, 12:46 PM · Plasma
bport committed R135:4a7786999d31: Set cursor size default to 24 to align with KCM default value (authored by bport).
Set cursor size default to 24 to align with KCM default value
Apr 17 2020, 12:46 PM
bport committed R119:a68554d39c5c: [Cursors] Remove Resolution Dependant option (authored by bport).
[Cursors] Remove Resolution Dependant option
Apr 17 2020, 12:46 PM
bport closed D28652: [Cursors] Remove Resolution Dependant option.
Apr 17 2020, 12:46 PM · Documentation, Plasma
bport requested review of D28916: fix(kded): center action OSD on wayland.
Apr 17 2020, 12:23 PM · Plasma

Apr 15 2020

bport updated the summary of D28462: [KCM][WIP] Add KCModuleData .
Apr 15 2020, 4:35 PM · Plasma
bport updated the diff for D28462: [KCM][WIP] Add KCModuleData .

fix build

Apr 15 2020, 3:57 PM · Plasma
bport updated the summary of D28460: Add KCModuleData as base class for plugin.
Apr 15 2020, 9:20 AM · Frameworks

Apr 14 2020

bport committed R104:544a7c14946a: fix(kcm): show output ids in reference to currently applied config (authored by bport).
fix(kcm): show output ids in reference to currently applied config
Apr 14 2020, 3:07 PM
bport closed D28818: fix(kcm): show output ids in reference to currently applied config.
Apr 14 2020, 3:07 PM · Plasma
bport committed R104:538116fd1096: fix (kcm): correct output identifier position on wayland (authored by bport).
fix (kcm): correct output identifier position on wayland
Apr 14 2020, 3:07 PM
bport closed D28817: fix (kcm): correct output identifier position on wayland.
Apr 14 2020, 3:07 PM · Plasma
bport updated the diff for D28817: fix (kcm): correct output identifier position on wayland.

Fix import order (remove unused one)
Remove QTimer m_timer (field not used). Let me know if you want this one in a separate commit.

Apr 14 2020, 2:42 PM · Plasma
bport updated the diff for D28817: fix (kcm): correct output identifier position on wayland.

fix leak and style

Apr 14 2020, 2:36 PM · Plasma
bport updated the summary of D28818: fix(kcm): show output ids in reference to currently applied config.
Apr 14 2020, 2:20 PM · Plasma
bport updated the summary of D28817: fix (kcm): correct output identifier position on wayland.
Apr 14 2020, 2:05 PM · Plasma
bport updated the summary of D28818: fix(kcm): show output ids in reference to currently applied config.
Apr 14 2020, 1:41 PM · Plasma
bport added a comment to D28817: fix (kcm): correct output identifier position on wayland.

I don't think we have a leak, on destructor we delete all view
qDeleteAll(m_views);

At that point, when rootObj is nullptr, view is not added to m_views.

Apr 14 2020, 11:56 AM · Plasma
bport updated the diff for D28817: fix (kcm): correct output identifier position on wayland.

Remove border and shadow

Apr 14 2020, 11:45 AM · Plasma
bport added a comment to D28817: fix (kcm): correct output identifier position on wayland.

I don't think we have a leak, on destructor we delete all view
qDeleteAll(m_views);

Apr 14 2020, 11:40 AM · Plasma
bport updated the diff for D28818: fix(kcm): show output ids in reference to currently applied config.

update commit message

Apr 14 2020, 11:20 AM · Plasma
bport updated the diff for D28817: fix (kcm): correct output identifier position on wayland.

update commit message

Apr 14 2020, 11:19 AM · Plasma