User Details
- User Since
- Apr 30 2018, 8:42 AM (308 w, 4 d)
- Availability
- Available
Jun 15 2020
Apr 21 2020
Gets my approval! I assume those symlinks from 'com.fribbledom.telephant.svg' are intentional to match the appstream ID?
Mar 23 2020
While it's not completely consistent yet, it still's an improvement that reverts the recent regression. As such, I'm tempted to say LGTM.
Mar 21 2020
Your patch indeed makes the date behave like in previous releases again! However I noticed it's still not quite consistent in its behavior: when I start plasmashell freshly, the date is a lot wider than after resizing it to roughly the same width. I've added a new attachment, which hopefully explains what I'm trying to say.
Mar 17 2020
Mar 16 2020
Mar 13 2020
Also not opposed to a Kirigami front-end and happy to provide help here. I'm not sure the Go backend is well-suited for the entire KDE infrastructure, though.
Mar 10 2020
@hein is right, splitting panes and using one profile with and one without the blur setting active is problematic. It is in Konsole, too, however.
- Remove superfluous space and add comment regarding TerminalInterfaceV2
@mweepigeon I've addressed the issues you've discovered. Newly opened split-panes now also inherit the current working directory, like they would in Konsole.
- Inherit CWD when opening a new Terminal in a split-view
I'd also like to turn around the order of the Terminal constructor's parameters and keep the parent-widget as the last parameter, as it commonly is for KDE/Qt classes.
Feb 16 2020
Feb 11 2020
Jan 18 2020
Jan 13 2020
Actually I'm mistaken, we can't merge this just yet. We'll still need to wait for the Plasma 5.18 release.
Alright, I think this looks sane again. @ngraham Mind if I land this in its current state?
Hopefully fix phabricator getting out of sync with the changeset.
Jan 12 2020
Oops, I'm not sure what I've did here was what I intended: I rebased master (>800 commits since my original changeset) into my feature branch because I otherwise couldn't build/test my changes anymore, but obviously I didn't touch/change > 600 files.
Is this how phabricator is supposed to look in such a scenario, or how should I have resolved this scenario?
- Remove default key-sequence for "Previous/Next Activity" shortcut
Jan 11 2020
While waiting for that separate discussion and decision, does anyone mind if I land this _without_ default shortcuts set?
@ivan Do you think we can merge this now?
Oct 22 2019
Would love to finish this one up! :)
Any suggestions how to move forward?
Oct 3 2019
Careful: we must _not_ land this before the next Plasma release.
Fix typo in 'nameBasedOrdering'
Jul 12 2019
Jul 11 2019
Move nameBaseOrdering to an anonymous namespace and mark it as inline.
Addressed @ivan's change requests
Use a QVector instead of a QList to store sorted activities.
Keep an alphabetically sorted list of activities