Add support for sshfs to the fstab backend
Needs ReviewPublic

Authored by lbeltrame on Tue, Sep 3, 11:44 AM.

Details

Reviewers
bruns
broulik
fvogt
Group Reviewers
KDE Connect
Summary

This commit introduces support for sshfs as network filesystem.
It's probably used enough to warrant the inclusion.

Test Plan

Started dolphin without the patch, did not see mounts in the device list, added patch and restarted dolphin, saw the mountpoints in the device list.

Diff Detail

Repository
R245 Solid
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16044
Build 16062: arc lint + arc unit
lbeltrame created this revision.Tue, Sep 3, 11:44 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Sep 3, 11:44 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
lbeltrame requested review of this revision.Tue, Sep 3, 11:44 AM
fvogt added a comment.Tue, Sep 3, 11:48 AM

fuse.sshfs is used by kdeconnect as well, does that cause some kind of conflict?

If not, LGTM.

Could be improved by adding other filesystems (curlftpfs?) as well and using something like

QStringList{"nfs", "nfs4", "smbfs", "cifs", "fuse.sshfs"}.contains(fstype); instead.

fuse.sshfs is used by kdeconnect as well, does that cause some kind of conflict?

I can't test this in the current network (no office wifi, broadcast blocked at all levels). I'll have to see for myself when I get home.

This causes KDE connect drive to show up as "/run/user/1000/HASH (fuse.sshfs)" in places panel while being accessed.
I really don't like KDE connect using sshfs, though, so +1 from me :P

ngraham added a subscriber: ngraham.Tue, Sep 3, 1:26 PM

+1 for doing this and also fixing KDE Connect to not expose its mount as an implementation detail.

If it's a problem for kdeconnect mounts to appear there, how can we hide it? It's an sshfs mountpoint like any other, only that it is mounted programmatically.