Create Task
Maniphest T8144

Fix failing timestamp tests
Closed, ResolvedPublic
Actions

Description

Something changed in Qt 5.11:

FAIL!  : Cli7zTest::testList(normal-file-9381) Compared values are not the same
   Actual   (entry->property("timestamp").toString()): "2015-05-17T19:41:48.000"
   Expected (expectedTimestamp)                      : "2015-05-17T19:41:48"

Related Objects

elvisangelaccio created this task.Mar 3 2018, 10:53 PM
elvisangelaccio triaged this task as Normal priority.
elvisangelaccio updated the task description. (Show Details)
szamanx added a subscriber: szamanx.Aug 19 2020, 10:08 PM

Hi
The datetime format in qvariant ToString() was changed in 5.11 for QTime and QDateTime

@@ -435,15 +445,15 @@ static bool convert(const QVariant::Private *d, int t, void *result, bool *ok)
         case QVariant::Double:
             *str = QString::number(d->data.d, 'g', QLocale::FloatingPointShortest);
             break;
-#if !defined(QT_NO_DATESTRING)
+#if QT_CONFIG(datestring)
         case QVariant::Date:
             *str = v_cast<QDate>(d)->toString(Qt::ISODate);
             break;
         case QVariant::Time:
-            *str = v_cast<QTime>(d)->toString(Qt::ISODate);
+            *str = v_cast<QTime>(d)->toString(Qt::ISODateWithMs);
             break;
         case QVariant::DateTime:
-            *str = v_cast<QDateTime>(d)->toString(Qt::ISODate);
+            *str = v_cast<QDateTime>(d)->toString(Qt::ISODateWithMs);
             break;
 #endif
         case QVariant::Bool:
szamanx added a comment.Aug 23 2020, 7:30 PM

Hi there
this should fix the tests

testNotWorking.patch13 KBDownload

elvisangelaccio added a comment.Aug 23 2020, 9:01 PM

Hi, can you please submit the patch on gitlab? https://invent.kde.org/utilities/ark

Thanks!