Rename dialog displays also source file information
Needs ReviewPublic

Authored by papoteur on Wed, Feb 5, 10:01 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Ark
Summary

This patch is for solving:
Bug 403146 - Extracting suggests replacement file with info of destination file
I have tested with ark 19.04.0. It allows to have size and date of the source file from the archive, not the destination information.
The modifications are :

  • call overwriteQuery with the entry, not only the entry name.
  • overloading the overwriteQuery to accept the entry.
  • in case of call with query, call renameDialog with the name without formatting it with fromLocalFile, and adding date and size of the source, read from entry.

When QUrl is not a local file in renameDialog, displayed value are from the parameters passed with the call.

BUG: 403146
FIXED-IN: 20.04

Test Plan

Create an archive.
Modify a file which copy is in the archive
Open it with ark, extract the archive at the same location. A dialog opens to replace the file. At left, the information (date, size) should be the information before modification, and at right, from the modified file.
Extract or not.

Diff Detail

Repository
R36 Ark
Lint
Lint Skipped
Unit
Unit Tests Skipped
papoteur created this revision.Wed, Feb 5, 10:01 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptWed, Feb 5, 10:01 PM
papoteur requested review of this revision.Wed, Feb 5, 10:01 PM
meven edited the summary of this revision. (Show Details)Sat, Feb 8, 8:20 AM
meven added a reviewer: elvisangelaccio.
meven edited the summary of this revision. (Show Details)
meven added a subscriber: meven.Sat, Feb 8, 8:27 AM

Nice first patch @papoteur , seems good to me.
Great on you pushing through your patch to phabricator.

Please fix the few formatting issues.
Then we leave the final say to Ark maintainer @elvisangelaccio

kerfuffle/queries.cpp
87

indentation seems wrong here.

95

A space too much

kerfuffle/queries.h
72–73

Please remove this unneeded end space

104–105

Same

papoteur updated this revision to Diff 75255.EditedSat, Feb 8, 2:30 PM

Hello,
This patch has corrections for comments.

meven added a comment.Sat, Feb 8, 4:45 PM

Btw, You can mark the comment you treated as "Done" in phabricator, it it eases the review work.

papoteur marked 4 inline comments as done.EditedSat, Feb 8, 4:55 PM

Btw, You can mark the comment you treated as "Done" in phabricator, it it eases the review work.

This is what I have done, by ticking the checkbox. Is there something else to do? Do you need to update the page?
I'm not comfortable with the interface and the process. I wonder if the patch is integrated in a test build.

What also confuses me is that bugzilla and phabricator each require their own identity.