DolphinProject
ActivePublic

Recent Activity

Today

fvogt requested changes to D28290: Sync terminal with KIOFuse mount when browing remote directories.
Sat, Mar 28, 3:11 PM · Dolphin
trmdi requested review of D28370: Set a better defaultDropAction for dragging.
Sat, Mar 28, 3:36 AM · Dolphin

Yesterday

alnikiforov added a comment to D28337: Fix unmounting during preview generation.

It's also may be possible to repeat unmount request from solid a few times with some delays between requests to try waiting until preview jobs are stopped when unmount is requested from 'mounted devices' widget. I've tried 5 retries with 2 seconds between each one, and it worked for me. But waiting for replies to unmount notifications in solid might be preferable to retries.

Fri, Mar 27, 3:30 PM · Dolphin
alnikiforov requested review of D28337: Fix unmounting during preview generation.
Fri, Mar 27, 12:24 PM · Dolphin

Thu, Mar 26

ahmadsamir added a comment to D28161: [kio-extras] Port some QRegExp usage to QRegularExpression.

Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

That's confusing; but OK, I'll revert that part of the diff.

Yeah, it's not ideal but the library is not API-stable so we need a fixed reference point. Do please make a merge request for it though, Casper is very responsive to MRs.

Thu, Mar 26, 10:03 AM · Frameworks, Dolphin
sitter added a comment to D28161: [kio-extras] Port some QRegExp usage to QRegularExpression.

Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

That's confusing; but OK, I'll revert that part of the diff.

Thu, Mar 26, 10:02 AM · Frameworks, Dolphin
ahmadsamir updated the diff for D28161: [kio-extras] Port some QRegExp usage to QRegularExpression.

Leave out kdsoap-ws-discovery-client, it's maintained somewhere else...

Thu, Mar 26, 10:00 AM · Frameworks, Dolphin
ahmadsamir added a comment to D28161: [kio-extras] Port some QRegExp usage to QRegularExpression.

Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :((

Thu, Mar 26, 9:58 AM · Frameworks, Dolphin
sitter added a comment to D28161: [kio-extras] Port some QRegExp usage to QRegularExpression.

Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :((

Thu, Mar 26, 9:54 AM · Frameworks, Dolphin

Wed, Mar 25

feverfew added a reviewer for D28290: Sync terminal with KIOFuse mount when browing remote directories: Dolphin.

Demo of feature:

Wed, Mar 25, 8:32 PM · Dolphin
feverfew requested review of D28290: Sync terminal with KIOFuse mount when browing remote directories.
Wed, Mar 25, 8:30 PM · Dolphin
ngraham added a comment to D28017: Update dragCursor while dragging.

Done! Nice job.

Wed, Mar 25, 3:35 PM · Dolphin
ngraham closed D28017: Update dragCursor while dragging.
Wed, Mar 25, 3:35 PM · Dolphin
meven added a comment to D26901: Resize previews and icons according to the preview widget size.

It makes me think we should improve PreviewJob to be devicePixelRatio aware, so we can fix the tooltips too.

Wed, Mar 25, 3:27 PM · Dolphin
trmdi added a comment to D28017: Update dragCursor while dragging.

@ngraham
It seems that everyone accepted this, could you help me to land this to whatever branch you want ?

Wed, Mar 25, 2:48 PM · Dolphin
sitter added a comment to D27902: smb: figure out the best host to use for the UDS_URL.

I've actually had a better idea! Well kinda and it may be trickier to do.

Wed, Mar 25, 1:00 PM · Frameworks, Dolphin
sitter closed D27872: sftp: fix partial transfer resuming when copying to local.
Wed, Mar 25, 12:35 PM · Frameworks, Dolphin
sitter closed D27873: sftp: do not show creation time when we do not know it.
Wed, Mar 25, 12:35 PM · Frameworks, Dolphin

Tue, Mar 24

shlomif added a comment to D26362: [Tentative] Move from the searchbox to the results.

Thanks, but you need to update the diff using arc rather than providing a link to a new patch file.

https://community.kde.org/Infrastructure/Phabricator#Step_2:_Update_your_diff_in_response_to_review_comments

Tue, Mar 24, 9:23 PM · Dolphin
nicolasfella added a comment to D25665: Port away from deprecated KBookmarksmenu API.

@elvisangelaccio is it okay to depend on frameworks master or should I wait for the frameworks release before merging this?

Tue, Mar 24, 9:03 PM · Dolphin
ngraham added a comment to D26362: [Tentative] Move from the searchbox to the results.

Thanks, but you need to update the diff using arc rather than providing a link to a new patch file.

Tue, Mar 24, 8:39 PM · Dolphin
bruns accepted D27873: sftp: do not show creation time when we do not know it.
Tue, Mar 24, 5:20 PM · Frameworks, Dolphin
bruns added a comment to D27873: sftp: do not show creation time when we do not know it.

Looks ok now.

Tue, Mar 24, 5:20 PM · Frameworks, Dolphin
shlomif added a comment to D26362: [Tentative] Move from the searchbox to the results.

@ngraham @meven : here is a new patch: https://www.shlomifish.org/Files/files/code/dolphin--shlomif-patch-D26362--modified-v0.2.0.patch but note that it makes no difference and om fedora 32 x64 it seems that pressing enter twice invokes the top item in the results which was already selected. It also can be done as "down arrow; enter" using either of my patches.

Tue, Mar 24, 5:05 PM · Dolphin
shlomif added a comment to D26362: [Tentative] Move from the searchbox to the results.

@ngraham : hi! I am interested in finishing it up, but will be fine with someone else doing that. I'll try to get to it soon.

Tue, Mar 24, 4:08 PM · Dolphin
ngraham updated the diff for D11382: Add an option to show tabs from last time when Dolphin starts.

Massage a string

Tue, Mar 24, 3:43 PM · Dolphin
ngraham added a comment to D26362: [Tentative] Move from the searchbox to the results.

@shlomif are you interested in finishing up this patch?

Tue, Mar 24, 3:05 PM · Dolphin
meven accepted D27873: sftp: do not show creation time when we do not know it.

Ok to me @bruns ?

Tue, Mar 24, 2:20 PM · Frameworks, Dolphin
sitter updated the diff for D27873: sftp: do not show creation time when we do not know it.

.

Tue, Mar 24, 1:16 PM · Frameworks, Dolphin
meven added inline comments to D11382: Add an option to show tabs from last time when Dolphin starts.
Tue, Mar 24, 11:03 AM · Dolphin
nikolaik added a watcher for Dolphin: nikolaik.
Tue, Mar 24, 10:51 AM
meven added a comment to D26362: [Tentative] Move from the searchbox to the results.

One thing I notice is that moving the focus to the view using focusViewRequest() doesn't actually make an item become pre-selected if it wasn't before. Given that the whole point of this feature is to quickly select an item in the view after filtering or searching, maybe it would also make sense to create a new function that will do that which we can call from the filter bar and search field when they request to move focus to the view.

Then again personally I kind of think that focusing the main view should *always* select an item, since otherwise that's just a manual step the user has to do for themselves. In this case, we would have DolphinViewContainer::requestFocus() always automatically select the item with implicit focus, if it's not already selected.

I agree. And this behavior should be also implemented for the Return case which is lacking this at the moment.
A requestFocusAndSelectFirstItem for instance.

Tue, Mar 24, 10:44 AM · Dolphin
meven added a comment to D27873: sftp: do not show creation time when we do not know it.

Please correct the comment in the code - it depends on the server SFTP implementation.

Birth time does not depend on the file system?

Tue, Mar 24, 10:19 AM · Frameworks, Dolphin

Mon, Mar 23

elvisangelaccio added a comment to D28227: Use same logic for "no extension" case with Duplicate feature.

Seems fine to me, adding @pino who could give more insights.

Mon, Mar 23, 10:04 PM · Dolphin
elvisangelaccio added a reviewer for D28227: Use same logic for "no extension" case with Duplicate feature: pino.
Mon, Mar 23, 10:02 PM · Dolphin
ngraham added a comment to D28227: Use same logic for "no extension" case with Duplicate feature.

I thought that it was important to put all the components of a final string together in the i18n() function to prevent string puzzles. If that's not a concern here, I can remove the path from the translated part of the string.

Mon, Mar 23, 8:18 PM · Dolphin
arojas added a comment to D28227: Use same logic for "no extension" case with Duplicate feature.

Is there a reason to include the path in the translated string? Not including it would reduce the risk of translations breaking the feature (as it happens currently with Spanish in the extension case)

Mon, Mar 23, 8:01 PM · Dolphin
ngraham added a comment to D28227: Use same logic for "no extension" case with Duplicate feature.

This involves a string change, but given that it's to fix a bug with the feature not working correctly, I'd like to request a a string change exception from the Localization team.

Mon, Mar 23, 7:53 PM · Dolphin
ngraham requested review of D28227: Use same logic for "no extension" case with Duplicate feature.
Mon, Mar 23, 7:52 PM · Dolphin
meven added a comment to D27902: smb: figure out the best host to use for the UDS_URL.

Seems fine to me

Mon, Mar 23, 4:14 PM · Frameworks, Dolphin
ngraham added a comment to D27504: smb faster copy to local.

Yeah due to the quantity of new code, it feels more like 20.08 material, TBH.

Mon, Mar 23, 2:25 PM · Frameworks, Dolphin
sitter added a comment to D27504: smb faster copy to local.

Any opinions on landing this for 20.04 still? It is technically a bugfix. It is also practically a whole lot of risky code, making me rather uneasy about putting it in past beta.

Mon, Mar 23, 2:23 PM · Frameworks, Dolphin

Sat, Mar 21

The-Feren-OS-Dev added a comment to D27523: Add an option to use a KUrlNavigator on the toolbar instead.

I'm not really sure about the icon on the left of the URL when it's inside the toolbar, but otherwise this looks great visually on first impressions.

Sat, Mar 21, 9:27 PM · Dolphin

Fri, Mar 20

ahmadsamir added a comment to D28161: [kio-extras] Port some QRegExp usage to QRegularExpression.

(Also could some one with more power than me clang-format this whole repo (there's a clang-format.cmake in extra-cmake-modules)? just note that some hand-formatted char* definitions blow up :)).

Fri, Mar 20, 12:55 PM · Frameworks, Dolphin
ahmadsamir requested review of D28161: [kio-extras] Port some QRegExp usage to QRegularExpression.
Fri, Mar 20, 12:52 PM · Frameworks, Dolphin
meven added a comment to D27504: smb faster copy to local.

Looks good to me.

Fri, Mar 20, 10:06 AM · Frameworks, Dolphin
trmdi added inline comments to D28017: Update dragCursor while dragging.
Fri, Mar 20, 1:42 AM · Dolphin

Thu, Mar 19

davidedmundson added inline comments to D28017: Update dragCursor while dragging.
Thu, Mar 19, 10:40 PM · Dolphin
ngraham added a comment to D28017: Update dragCursor while dragging.

Stable branch?

Thu, Mar 19, 10:32 PM · Dolphin
elvisangelaccio accepted D28017: Update dragCursor while dragging.

With Qt 5.15 I get this debug output when i click that "drag" button:

Qt::CopyAction QFlags<Qt::DropAction>(CopyAction|MoveAction)

Thanks, that means that bug is fixed in Qt 5.15.

This patch now try to change the cursor when the user change the modifier key and not move the mouse.
But I don't understand why it doesn't work in Wayland. Maybe another bug in Qt?

Thu, Mar 19, 10:20 PM · Dolphin