Mon, Dec 10
Um, the diff is now different, and it looks like the wrong patch was committed: https://cgit.kde.org/dolphin.git/commit/?id=55db38d5ecc1f13e17fecd7f3a5ea24421080b77
Semantically, this is the correct icon, though the actual imagery isn't super applicable. We can fix that with a better icon though.
Sat, Dec 8
To 18.12 ?
Fri, Dec 7
Thu, Dec 6
This may be part of a broader discussion, namely, how to handle application bundles (ROX AppDirs, Mac bundles, GNUstep bundles, AppImages) and applications that are not installed, but rather can "come and go" dynamically.
Can it be included/installed in KDE neon?
Only return to breadcrumb mode when entire text is selected
Wed, Dec 5
Picking this up ...
Please use firstname.lastname@example.org
Tue, Dec 4
"Prohibiting the use of Dolphin as the actual root user (not using sudo or kdesu) breaks legitimate use cases for using the root user. "
Pushed it, thanks for the review.
Mon, Dec 3
Can you please push it to the stable branch? (Applications/18.12)
related bug-report to GammaRay: https://github.com/KDAB/GammaRay/issues/504
Sun, Dec 2
Finally had the time to look at this diff.
We need to update kfileplacesmodeltest (as well as placesitemmodeltest in dolphin).
Sat, Dec 1
I think we can land this on the stable branch too (Applications/18.12).
Fri, Nov 30
That happens only with size sorting because we modify the "size" of folders by setting the number of items in them. That triggers a re-sort once this is done, that it turns call itemsMoved and triggers the bug.
See the special case in KFileItemModelRolesUpdater::applySortRole for details.
Wed, Nov 28
Note also that Kickoff's "History" with recent files is /yet another/ completely different data source.
Using "Recently Used" as the section header label presents the following problems:
- One of the items is named "Recently Used"
- The other items actually do not display a list of recently used files; they display a list of recently saved files.
I like this change a lot, however I think the Section header should be changed from "Recents" to "Recently Used". I think Recents just sound inelegant and weird
I do wonder if we should support ntirpc too though. At a glance it's largely the same finder s/tirpc/ntirpc/. Admittedly I do not know why there are two libs and both seem to actively get commits.
@asturmlechner can you post that in a new review request? I'll abandon this one.