The stable branch was also affected, I cherry-picked the fix.
Good catch, sorry for breaking it ;)
Yeah, that makes sense. I'll make it only elide left when showing the full path.
Seems to make more sense for when the full path is shown, but my intuition is that right elision is more useful when it's just the folder name being shown.
Thu, Apr 18
Fixed that in D20664.
Thanks for the investigation!
Currently opening an already open path creates a new tab.
I think it's better to just activate the existing tab.
Good catch, thanks
Wed, Apr 17
Unfortunately this caused https://bugs.kde.org/show_bug.cgi?id=405780. Specifically, the change to src/dolphinmainwindow.cpp.
Tue, Apr 16
disable configure action when in configuration mode
Do you plan to make (the requested) changes? If yes, please change the status.
I don't think the navigation is a suitable place, since it's not limited only to going up one folder.
I'm afraid I don't have the answers to those questions. :(
Mon, Apr 15
Friendly ping! :)
Still LGTM. @elvisangelaccio?
I can't follow the remark about the single button, since there are clearly two buttons in firefox? Anyways, the rationale in firefox is IMHO that the user wants to jump to one point in the history, but if that's in the forward or backward history might not be known (in advance). (For a single (or double) forward/back one wouldn't invoke the menu anyways.) If you take this uncertainty into account the unified menu makes much more sense.
activateWindow works if and only if your X startup info is correct.
Any app that registers itself as able to open directories generally can't do anything useful with an empty directory.
bump baloo widgets version
Nice, this works great! I think it's a very useful and unobtrusive feature. I'll hand this show over to @elvisangelaccio now. :)
The Breeze patch looks sane. I'm torn on whether or not adding the new style to KWidgetsAddons makes sense though. Couldn't Dolphin just set the new _kde_toolButton_noMenuArrow on just these buttons?
To be honest, I'm kind of torn on this. On one hand, it seems like a very powerful feature, and that experts could get a lot out of it.
Sun, Apr 14
what does it means? is it done already?
Added support for feature 269987.
About the UI, I noticed that when the panel is in "configure" mode, it's still possible to right-click it and click the "Configure" entry, which will do nothing.
We could fix this by disabling the entry once clicked. Another idea: make the entry checkable instead of using the buttonbox.
Please bump the minimum required version for KF5BalooWidgets to 19.07.70.
@richardl - thanks for the feedback! I tend to agree with @david.fontanals in that it makes most sense to only show the back history in the back button and the forward history in the forward button. This also seems to be the behavior of Chrome (though I don't know how much it matters :) ).
As I see it, showing both forward and backward entries at the same time is a smart idea if your interface requires having a single button for this feature. Otherwise, it doesn't make much sense because one would never click on the backward navigation button to pick a forward entry. Having to see the forward entries first to decide which backward entry to pick is not a common case either. Thus, in most cases you'd just have to deal with the drawback of limiting the amount of forward-only or backward-only entries that can be shown, which in addition is counter-productive if you want to roll back a lot of entries.
+1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is narrow: