DolphinProject
ActivePublic

Recent Activity

Mon, Dec 10

shubham closed D17490: Add an icon for "restore" action.
Mon, Dec 10, 6:27 PM · Dolphin
shubham updated the diff for D17490: Add an icon for "restore" action.
Mon, Dec 10, 6:23 PM · Dolphin
shubham reopened D17490: Add an icon for "restore" action.
Mon, Dec 10, 6:13 PM · Dolphin
ngraham added a comment to D17490: Add an icon for "restore" action.

Um, the diff is now different, and it looks like the wrong patch was committed: https://cgit.kde.org/dolphin.git/commit/?id=55db38d5ecc1f13e17fecd7f3a5ea24421080b77

Mon, Dec 10, 6:03 PM · Dolphin
shubham closed D17490: Add an icon for "restore" action.
Mon, Dec 10, 5:59 PM · Dolphin
ngraham accepted D17490: Add an icon for "restore" action.

Semantically, this is the correct icon, though the actual imagery isn't super applicable. We can fix that with a better icon though.

Mon, Dec 10, 5:54 PM · Dolphin
shubham updated the test plan for D17490: Add an icon for "restore" action.
Mon, Dec 10, 5:14 PM · Dolphin
shubham requested review of D17490: Add an icon for "restore" action.
Mon, Dec 10, 5:07 PM · Dolphin

Sat, Dec 8

anthonyfieroni added a comment to D15763: Set correct image attributes on directory thumbnail.

To 18.12 ?

Sat, Dec 8, 8:39 AM · Frameworks, Dolphin

Fri, Dec 7

sitter closed D16299: fallback to dnssd service discovery if smb listDir failed on root.
Fri, Dec 7, 12:59 PM · Frameworks, Dolphin
broulik accepted D16299: fallback to dnssd service discovery if smb listDir failed on root.
Fri, Dec 7, 12:53 PM · Frameworks, Dolphin
shubham removed a member for Dolphin: shubham.
Fri, Dec 7, 11:19 AM
shubham removed a watcher for Dolphin: shubham.
Fri, Dec 7, 11:19 AM

Thu, Dec 6

ltoscano added a comment to D14998: Add AppImage thumbnailer.

Can it be included/installed in KDE neon?

Thu, Dec 6, 7:29 PM · Frameworks, Dolphin
probono added a comment to T9356: AppImage Awarness in plasma Desktop.

This may be part of a broader discussion, namely, how to handle application bundles (ROX AppDirs, Mac bundles, GNUstep bundles, AppImages) and applications that are not installed, but rather can "come and go" dynamically.

Thu, Dec 6, 6:59 PM · Baloo, VDG, Plasma, Dolphin
Restricted Application added projects to D14998: Add AppImage thumbnailer: Dolphin, Frameworks.

Can it be included/installed in KDE neon?

Thu, Dec 6, 6:51 PM · Frameworks, Dolphin
shubham added a watcher for Dolphin: shubham.
Thu, Dec 6, 8:57 AM
shubham added a member for Dolphin: shubham.
Thu, Dec 6, 8:57 AM
ngraham updated the test plan for D16980: Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed.
Thu, Dec 6, 2:42 AM · Dolphin
ngraham updated the diff for D16980: Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed.

Only return to breadcrumb mode when entire text is selected

Thu, Dec 6, 2:40 AM · Dolphin

Wed, Dec 5

elvisangelaccio closed D15367: [Comic Thumbnailer] fix CBR thumbnail generation.
Wed, Dec 5, 9:12 PM · Frameworks, Dolphin
bruns commandeered D10694: epubextractor: Handle multiple subjects better.

Picking this up ...

Wed, Dec 5, 8:44 PM · Frameworks, Dolphin, Baloo
fleger added a comment to D15367: [Comic Thumbnailer] fix CBR thumbnail generation.

Please use florian.leger6@gmail.com

Wed, Dec 5, 7:55 AM · Frameworks, Dolphin

Tue, Dec 4

astippich updated the task description for T8196: KFileMetadata: String lists. How do clients cope?.
Tue, Dec 4, 7:42 PM · Dolphin, Elisa, Frameworks, Baloo
firef added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).

"Prohibiting the use of Dolphin as the actual root user (not using sudo or kdesu) breaks legitimate use cases for using the root user. "

Tue, Dec 4, 10:49 AM · Dolphin
akreuzkamp closed D17330: KItemListWidget: Use QGraphicsWidget::initStyleOption instead of QStyleOption::initFrom.

Pushed it, thanks for the review.
https://commits.kde.org/dolphin/037d2c9984880065bf8a7e5d189aac1c670e531b

Tue, Dec 4, 8:52 AM · Dolphin

Mon, Dec 3

abalaji added inline comments to D12162: Add support for touch scrolling in Dolphin.
Mon, Dec 3, 9:36 PM · Dolphin
elvisangelaccio accepted D17330: KItemListWidget: Use QGraphicsWidget::initStyleOption instead of QStyleOption::initFrom.

Can you please push it to the stable branch? (Applications/18.12)

Mon, Dec 3, 9:03 PM · Dolphin
elvisangelaccio added inline comments to D12162: Add support for touch scrolling in Dolphin.
Mon, Dec 3, 8:49 PM · Dolphin
abalaji added inline comments to D12162: Add support for touch scrolling in Dolphin.
Mon, Dec 3, 6:32 PM · Dolphin
akreuzkamp added a comment to D17330: KItemListWidget: Use QGraphicsWidget::initStyleOption instead of QStyleOption::initFrom.

related bug-report to GammaRay: https://github.com/KDAB/GammaRay/issues/504

Mon, Dec 3, 2:34 PM · Dolphin
akreuzkamp requested review of D17330: KItemListWidget: Use QGraphicsWidget::initStyleOption instead of QStyleOption::initFrom.
Mon, Dec 3, 2:26 PM · Dolphin

Sun, Dec 2

astippich updated the task description for T8196: KFileMetadata: String lists. How do clients cope?.
Sun, Dec 2, 7:05 PM · Dolphin, Elisa, Frameworks, Baloo
elvisangelaccio requested changes to D12162: Add support for touch scrolling in Dolphin.

Finally had the time to look at this diff.

Sun, Dec 2, 11:20 AM · Dolphin
elvisangelaccio added a comment to D16980: Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed.

Ctrl+L already does multiple things depending on the context:

  1. URL navigator is a breadcrumb bar: Ctrl+L makes it editable, focuses it, and selects everything
  2. URL Navigator is editable but unfocused: Ctrl+L makes it focused and selects everything
  3. URL Navigator is editable and focused, but not everything is selected: Ctrl+L selects everything
  4. URL Navigator is editable and focused and everything is already selected: Ctrl+L does nothing

    This patch currently changes 3 and 4 to be "Ctrl+L turns it back into a breadcrumb bar and returns focus to the main view". Perhaps I could tweak the patch so that this only happens for case #4, for which hitting Ctrl+L currently has no effect. Thoughts?
Sun, Dec 2, 10:17 AM · Dolphin
elvisangelaccio requested changes to D7446: [Places panel] Revamp the Recently Saved section.

We need to update kfileplacesmodeltest (as well as placesitemmodeltest in dolphin).

Sun, Dec 2, 10:08 AM · Frameworks, Dolphin

Sat, Dec 1

thsurrel closed D17042: Fix selection when navigating back, with size sorting..
Sat, Dec 1, 8:19 PM · Dolphin
thsurrel closed D17111: Do not sort twice when changing role and order at the same time.
Sat, Dec 1, 8:07 PM · Dolphin
elvisangelaccio accepted D17111: Do not sort twice when changing role and order at the same time.
Sat, Dec 1, 4:14 PM · Dolphin
elvisangelaccio accepted D17042: Fix selection when navigating back, with size sorting..

I think we can land this on the stable branch too (Applications/18.12).

Sat, Dec 1, 4:13 PM · Dolphin

Fri, Nov 30

thsurrel added a comment to D17042: Fix selection when navigating back, with size sorting..

That happens only with size sorting because we modify the "size" of folders by setting the number of items in them. That triggers a re-sort once this is done, that it turns call itemsMoved and triggers the bug.
See the special case in KFileItemModelRolesUpdater::applySortRole for details.

Fri, Nov 30, 3:10 PM · Dolphin

Wed, Nov 28

davidedmundson added a comment to D7446: [Places panel] Revamp the Recently Saved section.

Note also that Kickoff's "History" with recent files is /yet another/ completely different data source.

Wed, Nov 28, 2:52 PM · Frameworks, Dolphin
ngraham added a comment to D7446: [Places panel] Revamp the Recently Saved section.

Using "Recently Used" as the section header label presents the following problems:

  • One of the items is named "Recently Used"
  • The other items actually do not display a list of recently used files; they display a list of recently saved files.
Wed, Nov 28, 2:50 PM · Frameworks, Dolphin
trickyricky26 added a comment to D7446: [Places panel] Revamp the Recently Saved section.

I like this change a lot, however I think the Section header should be changed from "Recents" to "Recently Used". I think Recents just sound inelegant and weird

Wed, Nov 28, 11:54 AM · Frameworks, Dolphin
sitter added a comment to D17205: Build kio_nfs against standalone libtirpc.

I do wonder if we should support ntirpc too though. At a glance it's largely the same finder s/tirpc/ntirpc/. Admittedly I do not know why there are two libs and both seem to actively get commits.

Wed, Nov 28, 9:17 AM · Frameworks, Dolphin
arojas abandoned D12761: Allow building kio-nfs against standalone libtirpc.
Wed, Nov 28, 7:43 AM · Frameworks, Dolphin
asturmlechner added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

@asturmlechner can you post that in a new review request? I'll abandon this one.

Wed, Nov 28, 7:42 AM · Frameworks, Dolphin
asturmlechner requested review of D17205: Build kio_nfs against standalone libtirpc.
Wed, Nov 28, 7:41 AM · Frameworks, Dolphin
arojas added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

@asturmlechner can you post that in a new review request? I'll abandon this one.

Wed, Nov 28, 7:07 AM · Frameworks, Dolphin

Tue, Nov 27

asturmlechner added inline comments to D12761: Allow building kio-nfs against standalone libtirpc.
Tue, Nov 27, 11:28 PM · Frameworks, Dolphin