I gave this a try today. The performance is quite good and the feature works great! It will be very nice to have, even without any caching (though that is probably necessary IMO to improve the display and performance and to minimize disk wear for SSDs in particular). I have a few concerns and suggestions for improvement:
Ah, I see why: because the bug report is about remote:/, not network:/. I guess network needs this patch too, but it's not fully complete unless remote:/` gets the same fix.
Hmm, somehow this does not work for me. The "Network" place in the places panel still shows "." as the text.
Add translation and Messages.sh to network:/
I think this needs a add_definitions(-DTRANSLATION_DOMAIN and Messages.sh file?
ping @ngraham anything to add ?
Tue, Nov 19
Any more thoughts on this? I wouldn't like to miss this fix for release/19.12 😃
Mon, Nov 18
Looks like those fixes are already in master
Sun, Nov 17
Is there a reason why this was pushed only to master ?
@elvisangelaccio, all good now?
Okay, that makes sense.
Also I am wondering about surfacing to users that the dir size computation is non complete.
I have an idea to perhaps replace the recursiveDirectorySizeLimit : using a timeout
That is, for instance, give 10ms per subdirectory 100 ms for the whole directory, to retrieve the directory size, if timeout is reached return the not-complete results : it will adapt to the IO system load and to drive speed.
This timeout might be configurable.
Was introduced in https://phabricator.kde.org/D19926 but the feature changed quite a lot in the meantime.
Sat, Nov 16
This is a feature I've wanted for ages, so I'm very excited to see a patch that implements it!