Thanks for this patch :) was patching it on my custom build... now regarding "drive-by download" i think it's just an education problem, user who clicks everywhere will get in trouble way before stumbling across such an attack... browser should by default ask before downloading anything but at least this is an available setting on most browser; now regarding cache (because browser tend to start downloading files even before they are saved) those directories are not scanned with baloo... any way at the end of the day all those issue should not be fixed in dolphin but on their side browser/file-indexer/etc.
Perhaps but it's only recently become an issue since kioslaves now support KCrash. Previously such thumbnailer crashes just went unnoticed.
Looks good to me now!
No need for a separate diff, the fix is in D19083
Thanks! Who should I ask for a dependency rebuild? sysadmin?
If you don't mind, please also have a look at D19106, which does the same for baloo-widgets. I'd like to land them at the same time for consistency.
However, you will get a Dr Konqi each time it encounters that file as it will try to generate a thumbnail for it every time you open the folder.
Sun, Feb 17
Created https://github.com/AppImage/libappimage/pull/71 as one approach to get this solved on libappimage side.
Code looks good to me, do you want me to actually test it or are you confident enough that it works?
The Applications 19.04 dependency freeze is on March 14th, while frameworks 5.56 gets released on March 9th. I don't see a problem if you want to push this now (apart from the KDE CI which will probably need a rebuild of the Dependency Build job).
This can of course only be merged when it is deemed okay to rely on KF 5.56
Yep, that works great. Did it in D19103: Middle-elide very long filenames in error strings.
kio_thumbnail is a separate process (like all kioslaves) so a crash doesn't bring down the user-visible application.
- Use KLocalizedString
Please push to the Applications/18.12 branch.
That could also work, yes. @ngraham wanna give it a try?
Sat, Feb 16
I didn't realize you moved the text out of the i18n call.
Add default constructor to AccessibleIdWrapper
Dolphin could simply call KStringHandler::*squeeze(), maybe only on the actual filepath, if squeezing is preferred to wrapping.
Fixes the crash for me, thanks!
Please use FEATURE: instead of BUG: in the commit message.
Looks good to me now, landing it.
@cfeck What if we use a KSqueezedTextLabel in KMessageWidget instead? That would mostly fix also the 'aaaaaaaaaaaa' case without requiring new API in QLabel.
Change TabPlacement enum names.
Simplify the code that calculates the index of the new tab.
- Added warnings
Fri, Feb 15
The code can't be much simpler than this, there's not much places it can go wrong, i guess the only other thing to mention is, poppler will crash with some bad data, so i don't know if this is on it's own process or not, but if it's not it may bring down whatever app uses it, though given the gs issues lately it's probably not worse?
Fix my own error (ironic?)