DolphinProject
ActivePublic

Recent Activity

Tue, Jun 19

ngraham closed D13595: Move General settings to the top.
Tue, Jun 19, 11:08 PM · Documentation, Dolphin
ngraham added a comment to D13595: Move General settings to the top.

Thank you!

Tue, Jun 19, 11:06 PM · Documentation, Dolphin
ltoscano accepted D13595: Move General settings to the top.

Oh, well, the cpp part did not change, so let's consider the previous approval as still valid. Approving the documentation change.

Tue, Jun 19, 11:02 PM · Documentation, Dolphin
ltoscano added a comment to D13595: Move General settings to the top.

Fine by me - @elvisangelaccio ?

Tue, Jun 19, 11:00 PM · Documentation, Dolphin
ngraham added a comment to D13595: Move General settings to the top.

All good now?

Tue, Jun 19, 10:58 PM · Documentation, Dolphin
ngraham updated the diff for D13595: Move General settings to the top.

Also move the General section to the top in the docbook, to match the UI change

Tue, Jun 19, 10:56 PM · Documentation, Dolphin
ngraham planned changes to D13595: Move General settings to the top.

Sure, I'll make the doc change too.

Tue, Jun 19, 9:19 PM · Documentation, Dolphin
ltoscano added a comment to D13595: Move General settings to the top.

Maybe the patch can be applied in this same change, so we don't forget.

Tue, Jun 19, 8:55 PM · Documentation, Dolphin
elvisangelaccio added a comment to D13595: Move General settings to the top.

@ltoscano Yes, seems the docboock lists the page in their actual order within the dialog.

Tue, Jun 19, 8:54 PM · Documentation, Dolphin
ltoscano added a comment to D13595: Move General settings to the top.

Does this require a documentation change too (doc/)?

Tue, Jun 19, 8:51 PM · Documentation, Dolphin
elvisangelaccio accepted D13595: Move General settings to the top.

Indeed, it probably makes sense to be consistent here.

Tue, Jun 19, 8:49 PM · Documentation, Dolphin
ngraham added a comment to D13474: Remove "Use Default Location" button in settings window.

Friendly ping!

Tue, Jun 19, 1:38 PM · Dolphin
ngraham added a comment to D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.

We have a request in https://bugs.kde.org/show_bug.cgi?id=395405 for an additional token: the current directory name. Possibly also one for the full path to the current directory.

Tue, Jun 19, 12:55 PM · Dolphin
ngraham updated the summary of D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.
Tue, Jun 19, 4:24 AM · Dolphin
ngraham updated the test plan for D12571: Modernize Settings window.
Tue, Jun 19, 2:44 AM · Dolphin
ngraham updated the diff for D12571: Modernize Settings window.
  • Improve awkward "Expandable folders: [] Enable" string
  • Replace "General:" with "Miscellaneous:" so we don't have three instances of the word "general" visible at once
  • Use a bit more padding between sections to improve their distinctiveness
Tue, Jun 19, 2:41 AM · Dolphin

Mon, Jun 18

ngraham added a reviewer for D13595: Move General settings to the top: KDE Applications.
Mon, Jun 18, 11:27 PM · Documentation, Dolphin
ngraham requested review of D13595: Move General settings to the top.
Mon, Jun 18, 11:27 PM · Documentation, Dolphin
elvisangelaccio added inline comments to D13124: [RFC] Add Share action to Dolphin context menu.
Mon, Jun 18, 8:55 PM · Frameworks, Dolphin
nicolasfella added inline comments to D13124: [RFC] Add Share action to Dolphin context menu.
Mon, Jun 18, 7:20 PM · Frameworks, Dolphin
fabianr added a dependent revision for D13569: Use collapsible box to configure visible roles: D12961: Updated alignment, keylines, messures to new radio button layout and the new qml formlayout.
Mon, Jun 18, 1:23 PM · Dolphin
ngraham accepted D13569: Use collapsible box to configure visible roles.

A big improvement, usability-wise!

Mon, Jun 18, 1:01 PM · Dolphin

Sun, Jun 17

ngraham updated the test plan for D12571: Modernize Settings window.
Sun, Jun 17, 7:33 PM · Dolphin
ngraham updated the diff for D12571: Modernize Settings window.

Review suggestions

Sun, Jun 17, 7:33 PM · Dolphin
ngraham added a comment to D12571: Modernize Settings window.

Thanks for that Elvis. Nate, are you able to adress Elvis’ feedback and move the patch forward?

Sun, Jun 17, 2:31 PM · Dolphin

Sat, Jun 16

abetts added a comment to D12571: Modernize Settings window.

Don't they control how the view appears on startup?

Only "Split view mode" does. The other ones control things that are outside the view. How about using "On startup:" and rewording the sentences on the checkboxes where necessary?

I was using the term "View" from a user perspective. I think to people who aren't Dolphin developers, these are view settings. The technical distinction between the view, its container, and the main window are not relevant to users, or important to understand.

I disagree, but that's not the point anyway. Using "view" here would be just wrong. Why not using "window" instead?

Other comments on the UI before looking at the code:

  • In the Startup page, what does "Location" refer to? The groupbox made it clear it was the Home folder, now we are hiding this information.

"Home folder" has an established meaning: it's your user's own home folder. Using the label "Home folder" always seemed to imply that you could change your home folder, which was not true. In fact, this setting simply controls what folder dolphin shows on startup. The fact that you're on the "Startup" tab I think does a good job of suggesting that the settings on this page control Dolphin's behavior and appearance when it launches. Maybe I could add a small label at the top of the window explaining that?

Fair enough. How about "Start in:" ?

  • The Confirmation tab now is better but still confusing. I don't see why we need to touch it at all honestly, given that there are only checkboxes in there.

I feel like there's resistance to the visual design conception itself. I'm getting the feeling that you simply don't like the labels-on-the-left paradigm itself. Perhaps we should address that rather than arguing over individual examples of its application.

Guys, this work has been going on for a long time on something rather simple in aligning the settings design to what Plasma is doing. There should not be this much resistance to the change. Can we please move forward with the approval?

Honestly I'm quite disappointed to read this.

I can assure you there is no resistance to the visual design change from me.
Is it true that I don't particularly like it and I'm sad that my feedback was ignored, but if that's what the VDG wants, so be it.

But this patch currently has still issues (in particular, the Confirmations tab) and will be approved only when it's ready.

Sat, Jun 16, 5:17 PM · Dolphin
elvisangelaccio added a comment to D12571: Modernize Settings window.

Don't they control how the view appears on startup?

Only "Split view mode" does. The other ones control things that are outside the view. How about using "On startup:" and rewording the sentences on the checkboxes where necessary?

I was using the term "View" from a user perspective. I think to people who aren't Dolphin developers, these are view settings. The technical distinction between the view, its container, and the main window are not relevant to users, or important to understand.

Sat, Jun 16, 5:01 PM · Dolphin
elvisangelaccio added a comment to D13569: Use collapsible box to configure visible roles.

Some screens:

Sat, Jun 16, 3:43 PM · Dolphin
elvisangelaccio requested review of D13569: Use collapsible box to configure visible roles.
Sat, Jun 16, 3:40 PM · Dolphin

Fri, Jun 15

ngraham added a comment to D12571: Modernize Settings window.

Well, I don't want to force anything down anyone's throat, but it's true that this is the style we're already using all over Plasma...

Fri, Jun 15, 2:08 PM · Dolphin
abetts added a comment to D12571: Modernize Settings window.

Guys, this work has been going on for a long time on something rather simple in aligning the settings design to what the rest of Plasma is doing. There should not be this much resistance to the change. Can we please move forward with the approval?

Fri, Jun 15, 2:03 PM · Dolphin

Thu, Jun 14

abrahams added a member for Dolphin: abrahams.
Thu, Jun 14, 6:16 PM
ngraham added a comment to D12571: Modernize Settings window.

Don't they control how the view appears on startup?

Only "Split view mode" does. The other ones control things that are outside the view. How about using "On startup:" and rewording the sentences on the checkboxes where necessary?

Thu, Jun 14, 1:18 PM · Dolphin
ngraham added a comment to D13474: Remove "Use Default Location" button in settings window.

What's the use case for actually clicking on the {use Default Location} button instead if the reset all button on the bottom. Again, no other control has its own private "reset me to default settings" button, so it stands out.

Thu, Jun 14, 1:15 PM · Dolphin

Wed, Jun 13

elvisangelaccio requested changes to D12571: Modernize Settings window.

Don't they control how the view appears on startup?

Wed, Jun 13, 8:36 PM · Dolphin
markg added a comment to D13474: Remove "Use Default Location" button in settings window.

I'm not 100% convinced. The Defaults button resets all dolphin settings, while this one resets only this particular option.
The problem is we don't know if someone relies on this "feature", and in theory we could break someone else's workflow (unlikely, but still).

Some more reasons why we might want to keep the button around:

  • Nobody filed a bug to remove it, AFAIK.
  • Firefox has the very same button.
  • The after screenshot imho looks worse, since now we have a huge button that stands out.
Wed, Jun 13, 8:20 PM · Dolphin
elvisangelaccio closed D13152: Fix loop of FocusIn events.
Wed, Jun 13, 7:42 PM · Dolphin
elvisangelaccio added a comment to D13474: Remove "Use Default Location" button in settings window.

I'm not 100% convinced. The Defaults button resets all dolphin settings, while this one resets only this particular option.
The problem is we don't know if someone relies on this "feature", and in theory we could break someone else's workflow (unlikely, but still).

Wed, Jun 13, 7:36 PM · Dolphin

Tue, Jun 12

abalaji retitled D12162: Add support for touch scrolling in Dolphin from Support for touch scrolling in Dolphin to Add support for touch scrolling in Dolphin.
Tue, Jun 12, 7:00 PM · Dolphin
abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

Hey @ngraham I'm back in school and flooded with assignments atm, if you're super interested in this, then I can work on this over the weekend. So at the moment, here's what's working on my config at least:

Tue, Jun 12, 6:39 PM · Dolphin
ngraham added a comment to D12162: Add support for touch scrolling in Dolphin.

What's the status here, @abalaji? I and a lot of people would really love to see this in Dolphin! :-)

Tue, Jun 12, 2:21 PM · Dolphin

Sun, Jun 10

ngraham added a comment to D12571: Modernize Settings window.

@elvisangelaccio this is ready for review again. Now all it does is change the layout on pages that have mixed controls (checkboxes, radio buttons, and comboboxes etc) for which the new design has the label on the left. I've moved the Use Default Location button removal change to D13474. I've also abandoned the KMessageWidget change since I couldn't get it work work properly when pressing the OK button; the windows always closes and the message isn't displayed.

Sun, Jun 10, 10:12 PM · Dolphin
ngraham updated the diff for D12571: Modernize Settings window.

Remove unnecessary line

Sun, Jun 10, 10:06 PM · Dolphin
ngraham added a dependency for D13474: Remove "Use Default Location" button in settings window: D12571: Modernize Settings window.
Sun, Jun 10, 9:57 PM · Dolphin
ngraham added a dependent revision for D12571: Modernize Settings window: D13474: Remove "Use Default Location" button in settings window.
Sun, Jun 10, 9:57 PM · Dolphin
Restricted Application added a project to D13474: Remove "Use Default Location" button in settings window: Dolphin.
Sun, Jun 10, 9:57 PM · Dolphin
ngraham updated the test plan for D12571: Modernize Settings window.
Sun, Jun 10, 9:26 PM · Dolphin
ngraham updated the test plan for D12571: Modernize Settings window.
Sun, Jun 10, 9:25 PM · Dolphin
ngraham updated the diff for D12571: Modernize Settings window.

Missed one

Sun, Jun 10, 9:23 PM · Dolphin
ngraham updated the diff for D12571: Modernize Settings window.

Reduced diff for startupsettingspage.cpp and removed KMessageWidget change (will put it in a separate patch)

Sun, Jun 10, 9:19 PM · Dolphin