DolphinProject
ActivePublic

Recent Activity

Today

meven added inline comments to D25435: [Network Ioslave] Add Display name to network:/.
Fri, Nov 22, 9:30 AM · Frameworks, Dolphin
ltoscano added inline comments to D25435: [Network Ioslave] Add Display name to network:/.
Fri, Nov 22, 8:43 AM · Frameworks, Dolphin

Yesterday

ngraham requested changes to D25335: [Details mode] Allow to fill the column size of directories with actual size.

I gave this a try today. The performance is quite good and the feature works great! It will be very nice to have, even without any caching (though that is probably necessary IMO to improve the display and performance and to minimize disk wear for SSDs in particular). I have a few concerns and suggestions for improvement:

Thu, Nov 21, 6:28 PM · Dolphin
meven closed D25435: [Network Ioslave] Add Display name to network:/.
Thu, Nov 21, 2:40 PM · Frameworks, Dolphin
ngraham accepted D25435: [Network Ioslave] Add Display name to network:/.

Ah, perfect.

Thu, Nov 21, 2:16 PM · Frameworks, Dolphin
meven added a comment to D25435: [Network Ioslave] Add Display name to network:/.

Ah, I see why: because the bug report is about remote:/, not network:/. I guess network needs this patch too, but it's not fully complete unless remote:/` gets the same fix.

Thu, Nov 21, 2:11 PM · Frameworks, Dolphin
ngraham added a comment to D25435: [Network Ioslave] Add Display name to network:/.

Ah, I see why: because the bug report is about remote:/, not network:/. I guess network needs this patch too, but it's not fully complete unless remote:/` gets the same fix.

Thu, Nov 21, 2:10 PM · Frameworks, Dolphin
ngraham added a comment to D25435: [Network Ioslave] Add Display name to network:/.

Hmm, somehow this does not work for me. The "Network" place in the places panel still shows "." as the text.

Thu, Nov 21, 2:08 PM · Frameworks, Dolphin
meven added a comment to D25435: [Network Ioslave] Add Display name to network:/.

I think this needs a add_definitions(-DTRANSLATION_DOMAIN and Messages.sh file?

Thu, Nov 21, 10:46 AM · Frameworks, Dolphin
meven updated the diff for D25435: [Network Ioslave] Add Display name to network:/.

Clean

Thu, Nov 21, 10:45 AM · Frameworks, Dolphin
meven updated the diff for D25435: [Network Ioslave] Add Display name to network:/.

fix

Thu, Nov 21, 10:44 AM · Frameworks, Dolphin
meven updated the diff for D25435: [Network Ioslave] Add Display name to network:/.

Add translation and Messages.sh to network:/

Thu, Nov 21, 10:42 AM · Frameworks, Dolphin
broulik added a comment to D25435: [Network Ioslave] Add Display name to network:/.

I think this needs a add_definitions(-DTRANSLATION_DOMAIN and Messages.sh file?

Thu, Nov 21, 10:35 AM · Frameworks, Dolphin
meven added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

ping @ngraham anything to add ?

Thu, Nov 21, 10:27 AM · Dolphin
meven updated the diff for D25435: [Network Ioslave] Add Display name to network:/.

Formatting

Thu, Nov 21, 10:14 AM · Frameworks, Dolphin
meven requested review of D25435: [Network Ioslave] Add Display name to network:/.
Thu, Nov 21, 10:08 AM · Frameworks, Dolphin

Tue, Nov 19

elvisangelaccio accepted D25260: fix(search): Fix baloo searchString parsing.

LGTM.

Tue, Nov 19, 10:36 PM · Dolphin
iasensio added a comment to D25260: fix(search): Fix baloo searchString parsing.

Any more thoughts on this? I wouldn't like to miss this fix for release/19.12 😃

Tue, Nov 19, 10:25 PM · Dolphin
ndavis closed D25391: Change default completion mode to CompletionPopupAuto.
Tue, Nov 19, 9:26 PM · Dolphin
iasensio added a dependency for D25416: fix(search): Correctly parse filename and/or content search: D25260: fix(search): Fix baloo searchString parsing.
Tue, Nov 19, 9:16 PM · Dolphin
iasensio added a dependent revision for D25260: fix(search): Fix baloo searchString parsing: D25416: fix(search): Correctly parse filename and/or content search.
Tue, Nov 19, 9:16 PM · Dolphin
iasensio requested review of D25416: fix(search): Correctly parse filename and/or content search.
Tue, Nov 19, 9:16 PM · Dolphin
elvisangelaccio accepted D25391: Change default completion mode to CompletionPopupAuto.
Tue, Nov 19, 8:43 PM · Dolphin
ngraham accepted D25391: Change default completion mode to CompletionPopupAuto.

LGTM. @elvisangelaccio?

Tue, Nov 19, 3:13 PM · Dolphin
ndavis updated the summary of D25391: Change default completion mode to CompletionPopupAuto.
Tue, Nov 19, 9:56 AM · Dolphin
ndavis requested review of D25391: Change default completion mode to CompletionPopupAuto.
Tue, Nov 19, 9:31 AM · Dolphin

Mon, Nov 18

broulik abandoned D25297: Add guards for m_terminalPanel.

Looks like those fixes are already in master

Mon, Nov 18, 8:49 AM · Dolphin

Sun, Nov 17

elvisangelaccio accepted D25347: Remove dead code.
Sun, Nov 17, 5:28 PM · Dolphin
elvisangelaccio closed D22594: [Dolphin] Open Preferred Search Tool action.
Sun, Nov 17, 5:25 PM · Documentation, Dolphin
elvisangelaccio accepted D22594: [Dolphin] Open Preferred Search Tool action.
Sun, Nov 17, 5:18 PM · Documentation, Dolphin
elvisangelaccio added a comment to D25242: Allow dolphin to format DateTime at later stage than KBalooRolesProvider.

Is there a reason why this was pushed only to master ?

Sun, Nov 17, 5:18 PM · Dolphin
ngraham added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

@elvisangelaccio, all good now?

Sun, Nov 17, 4:11 PM · Documentation, Dolphin
ngraham accepted D22594: [Dolphin] Open Preferred Search Tool action.

Okay, that makes sense.

Sun, Nov 17, 4:11 PM · Documentation, Dolphin
iasensio added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

Also I am wondering about surfacing to users that the dir size computation is non complete.

Sun, Nov 17, 12:03 PM · Dolphin
meven added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

I have an idea to perhaps replace the recursiveDirectorySizeLimit : using a timeout
That is, for instance, give 10ms per subdirectory 100 ms for the whole directory, to retrieve the directory size, if timeout is reached return the not-complete results : it will adapt to the IO system load and to drive speed.
This timeout might be configurable.

Sun, Nov 17, 11:36 AM · Dolphin
meven added a reviewer for D25347: Remove dead code: elvisangelaccio.
Sun, Nov 17, 10:31 AM · Dolphin
meven accepted D25347: Remove dead code.

Was introduced in https://phabricator.kde.org/D19926 but the feature changed quite a lot in the meantime.

Sun, Nov 17, 10:31 AM · Dolphin
pdabrowski added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Sun, Nov 17, 9:27 AM · Documentation, Dolphin
pdabrowski added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Sun, Nov 17, 8:15 AM · Documentation, Dolphin

Sat, Nov 16

nicolasfella requested review of D25347: Remove dead code.
Sat, Nov 16, 10:23 PM · Dolphin
ngraham added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Sat, Nov 16, 9:48 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.
Sat, Nov 16, 7:25 PM · Documentation, Dolphin
meven added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

This is a feature I've wanted for ages, so I'm very excited to see a patch that implements it!

In terms of the UI, this shouldn't only be for Details view; it's possible to view sizes in icon view too, by adding the size metadata item below the filename.

Sat, Nov 16, 3:22 PM · Dolphin
ngraham added a comment to D12162: Add support for touch scrolling in Dolphin.

Ping. :)

Sat, Nov 16, 3:08 PM · Dolphin
ngraham added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

This is a feature I've wanted for ages, so I'm very excited to see a patch that implements it!

Sat, Nov 16, 3:06 PM · Dolphin
meven updated the summary of D25335: [Details mode] Allow to fill the column size of directories with actual size.
Sat, Nov 16, 11:26 AM · Dolphin
meven updated the summary of D25335: [Details mode] Allow to fill the column size of directories with actual size.
Sat, Nov 16, 11:25 AM · Dolphin
meven updated the test plan for D25335: [Details mode] Allow to fill the column size of directories with actual size.
Sat, Nov 16, 11:24 AM · Dolphin
meven requested review of D25335: [Details mode] Allow to fill the column size of directories with actual size.
Sat, Nov 16, 11:22 AM · Dolphin

Fri, Nov 15

iasensio updated the test plan for D25260: fix(search): Fix baloo searchString parsing.
Fri, Nov 15, 11:38 PM · Dolphin