DolphinProject
ActivePublic

Recent Activity

Today

meven closed D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.
Tue, Nov 12, 7:21 AM · Dolphin

Yesterday

bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 10:33 PM · Dolphin
bruns added inline comments to D25258: test(search): Add test case for baloo parsing model.
Mon, Nov 11, 10:24 PM · Dolphin
bruns requested changes to D25258: test(search): Add test case for baloo parsing model.

Please move everything added to a new file, this is independent from the searchbox itself.

Mon, Nov 11, 10:15 PM · Dolphin
elvisangelaccio added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 9:59 PM · Dolphin
bruns added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 9:54 PM · Dolphin
elvisangelaccio requested changes to D25258: test(search): Add test case for baloo parsing model.
Mon, Nov 11, 9:54 PM · Dolphin
elvisangelaccio requested changes to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 9:44 PM · Dolphin
ngraham accepted D25242: Allow dolphin to format DateTime at later stage than KBalooRolesProvider.
Mon, Nov 11, 8:29 PM · Dolphin
iasensio updated the diff for D25260: fix(search): Fix baloo searchString parsing.

Rebase

Mon, Nov 11, 6:36 PM · Dolphin
iasensio updated the test plan for D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 6:29 PM · Dolphin
iasensio updated the summary of D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 6:27 PM · Dolphin
iasensio added inline comments to D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 6:25 PM · Dolphin
iasensio updated the diff for D25257: refactor(search): De-couple baloo URL parsing logic from UI.
  • API style and simplification
Mon, Nov 11, 6:19 PM · Dolphin
ngraham added a comment to D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.

Shipit!

Mon, Nov 11, 5:22 PM · Dolphin
meven updated the diff for D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.

Bump KF5_MIN_VERSION to 5.64

Mon, Nov 11, 5:18 PM · Dolphin
meven updated the diff for D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.

Rebase patch

Mon, Nov 11, 5:15 PM · Dolphin
meven closed D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue.
Mon, Nov 11, 4:23 PM · Frameworks, Dolphin
bruns added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

Please add a comment to the summary that the parser logic is exactly kept as is.

Mon, Nov 11, 2:36 PM · Dolphin
bruns added a comment to D25257: refactor(search): De-couple baloo URL parsing logic from UI.

This definitely goes in the right direction, thanks!

Mon, Nov 11, 2:11 PM · Dolphin
iasensio updated the summary of D25258: test(search): Add test case for baloo parsing model.
Mon, Nov 11, 1:45 PM · Dolphin
iasensio added a dependency for D25257: refactor(search): De-couple baloo URL parsing logic from UI: D25255: fix(search): Allow to set empty type.
Mon, Nov 11, 1:39 PM · Dolphin
iasensio added a dependent revision for D25255: fix(search): Allow to set empty type: D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 1:39 PM · Dolphin
iasensio removed a dependent revision for D25257: refactor(search): De-couple baloo URL parsing logic from UI: D25255: fix(search): Allow to set empty type.
Mon, Nov 11, 1:39 PM · Dolphin
iasensio removed a dependency for D25255: fix(search): Allow to set empty type: D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 1:39 PM · Dolphin
iasensio added a dependency for D25258: test(search): Add test case for baloo parsing model: D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 1:38 PM · Dolphin
iasensio added a dependent revision for D25257: refactor(search): De-couple baloo URL parsing logic from UI: D25258: test(search): Add test case for baloo parsing model.
Mon, Nov 11, 1:38 PM · Dolphin
iasensio removed a dependent revision for D25258: test(search): Add test case for baloo parsing model: D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 1:38 PM · Dolphin
iasensio removed a dependency for D25257: refactor(search): De-couple baloo URL parsing logic from UI: D25258: test(search): Add test case for baloo parsing model.
Mon, Nov 11, 1:38 PM · Dolphin
iasensio added a dependent revision for D25258: test(search): Add test case for baloo parsing model: D25260: fix(search): Fix baloo searchString parsing.
Mon, Nov 11, 1:37 PM · Dolphin
iasensio added a dependency for D25260: fix(search): Fix baloo searchString parsing: D25258: test(search): Add test case for baloo parsing model.
Mon, Nov 11, 1:37 PM · Dolphin
iasensio requested review of D25260: fix(search): Fix baloo searchString parsing.
Mon, Nov 11, 1:35 PM · Dolphin
iasensio added a dependent revision for D25258: test(search): Add test case for baloo parsing model: D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 1:15 PM · Dolphin
iasensio added a dependency for D25257: refactor(search): De-couple baloo URL parsing logic from UI: D25258: test(search): Add test case for baloo parsing model.
Mon, Nov 11, 1:15 PM · Dolphin
iasensio added a dependent revision for D25257: refactor(search): De-couple baloo URL parsing logic from UI: D25255: fix(search): Allow to set empty type.
Mon, Nov 11, 1:14 PM · Dolphin
iasensio added a dependency for D25255: fix(search): Allow to set empty type: D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 1:14 PM · Dolphin
iasensio requested review of D25258: test(search): Add test case for baloo parsing model.
Mon, Nov 11, 1:12 PM · Dolphin
iasensio requested review of D25257: refactor(search): De-couple baloo URL parsing logic from UI.
Mon, Nov 11, 1:01 PM · Dolphin
iasensio requested review of D25255: fix(search): Allow to set empty type.
Mon, Nov 11, 12:36 PM · Dolphin
iasensio added a comment to D24422: [dolphin] Improve parsing of Baloo query searchString.

The problem with the original code is it mixes the model and the view.

Please do the following:

  1. Split the current code to model/view, i.e. move the "rating + filename + remainder" into a separate trivial class
  2. Populate the model class from the existing parser, populate the view from the model
  3. Add the unit test you have written (of course, no longer testing the DolphinSearchBox, but the model) (some tests have to be marked as XFAIL).
  4. Update the parser, update the XFAILs

    Splitting model/view makes it much easier to extend the searchbox later, and to e.g. reuse Baloos parser.

Not sure we have time to do all of that before the 19.12 freeze though (which is next Thursday). So I'd suggest to merge this patch and then open a refactoring task targeting dolphin 20.04. Would you be ok with that?

Mon, Nov 11, 12:23 PM · Dolphin
ngraham updated the summary of D11382: Add an option to show tabs from last time when Dolphin starts.
Mon, Nov 11, 12:39 AM · Dolphin
ngraham added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

19.12 has branched so we can target 20.04 for this and have time for lots and lots of testing. Can I request a review, @elvisangelaccio?

Mon, Nov 11, 12:39 AM · Dolphin

Sun, Nov 10

meven requested review of D25242: Allow dolphin to format DateTime at later stage than KBalooRolesProvider.
Sun, Nov 10, 5:15 PM · Dolphin
elvisangelaccio closed D25230: PlacesItemModel: remove redundant set of properties.
Sun, Nov 10, 9:05 AM · Dolphin
meven accepted D25230: PlacesItemModel: remove redundant set of properties.
Sun, Nov 10, 7:05 AM · Dolphin
meven updated the summary of D25230: PlacesItemModel: remove redundant set of properties.
Sun, Nov 10, 6:51 AM · Dolphin

Sat, Nov 9

elvisangelaccio updated the diff for D25230: PlacesItemModel: remove redundant set of properties.

Remove qDebug line

Sat, Nov 9, 9:57 PM · Dolphin
elvisangelaccio updated the summary of D25230: PlacesItemModel: remove redundant set of properties.
Sat, Nov 9, 9:56 PM · Dolphin
elvisangelaccio requested review of D25230: PlacesItemModel: remove redundant set of properties.
Sat, Nov 9, 9:53 PM · Dolphin
meven closed D25218: [Status Bar] Remove file status Timer, add text update delay.
Sat, Nov 9, 9:07 PM · Dolphin