DolphinProject
ActivePublic

Recent Activity

Yesterday

xyquadrat updated the diff for D8273: Change window title when searching.

Window title is now "Empty search" when the user hasn't input any search term.

Thu, Nov 23, 5:55 PM · Dolphin

Wed, Nov 22

isidorov added a watcher for Dolphin: isidorov.
Wed, Nov 22, 2:02 PM

Sun, Nov 19

elvisangelaccio added a commit to T7443: Rename inline: UI glitch during scrolling with mouse wheel: R318:af27d5735c77: Fix scrolling during inline renaming causes rename of wrong file.
Sun, Nov 19, 10:17 AM · Dolphin
ngraham closed T7443: Rename inline: UI glitch during scrolling with mouse wheel as Resolved by committing R318:5bee1889e168: Fix scrolling during inline renaming causes rename of wrong file.
Sun, Nov 19, 3:37 AM · Dolphin

Thu, Nov 16

akrutzler added a revision to T7443: Rename inline: UI glitch during scrolling with mouse wheel: D8822: Fix scrolling during inline renaming causes rename of wrong file.
Thu, Nov 16, 1:33 PM · Dolphin
ngraham closed D7440: Turn on Dolphin icon previews by default.
Thu, Nov 16, 2:49 AM · Dolphin

Wed, Nov 15

ngraham updated the diff for D7440: Turn on Dolphin icon previews by default.

Actually use the value of Plugins specified in the config, if it's present (this makes saving user plugin selections work again)

Wed, Nov 15, 11:45 PM · Dolphin
elvisangelaccio removed a reviewer for D7440: Turn on Dolphin icon previews by default: KDE Applications.
Wed, Nov 15, 5:29 PM · Dolphin
elvisangelaccio accepted D7440: Turn on Dolphin icon previews by default.
Wed, Nov 15, 5:29 PM · Dolphin
dfaure accepted D7440: Turn on Dolphin icon previews by default.
Wed, Nov 15, 8:34 AM · Dolphin
ngraham updated the diff for D7440: Turn on Dolphin icon previews by default.

Rely on KF 5.40 and simplify the code a ton

Wed, Nov 15, 5:43 AM · Dolphin

Mon, Nov 13

elvisangelaccio added a comment to D7440: Turn on Dolphin icon previews by default.

The Applications/17.12 branch has been created, so on master we could already depend on KIO >= 5.40. How about doing that?

Mon, Nov 13, 3:37 PM · Dolphin
xyquadrat added inline comments to D8273: Change window title when searching.
Mon, Nov 13, 7:02 AM · Dolphin

Sun, Nov 12

ngraham added a comment to D7440: Turn on Dolphin icon previews by default.

I marked myself as a member of the Dolphin project in Pbabricator but I'd really like to get a final yea-or-nay from some of the people listed as reviewers here so I can land this or make changes.

Sun, Nov 12, 11:43 PM · Dolphin
akrutzler added a comment to T7443: Rename inline: UI glitch during scrolling with mouse wheel.

That's just because you click (anywhere, really, not only on the scrollbar), scrolling with the mouse wheel does not trigger renaming as your video shows and unlike Windows.

Yeah you are right.

Sun, Nov 12, 8:54 PM · Dolphin
elvisangelaccio requested changes to D8273: Change window title when searching.
Sun, Nov 12, 8:32 PM · Dolphin
rkflx added a comment to T7443: Rename inline: UI glitch during scrolling with mouse wheel.

To be honest, I also don't know if that is a bug or a feature, but my first thought was, hm there is something broken. :)

Sun, Nov 12, 8:17 PM · Dolphin
akrutzler added a comment to T7443: Rename inline: UI glitch during scrolling with mouse wheel.

Windows Explorer is doing it differently: Renaming is confirmed as soon as scrolling starts. On macOS, Finder allows scrolling and confirms once the file disappears from the viewport.
Finder's implementation doesn't sound too bad, but maybe Dolphin's current behaviour of not moving the rename field is intentional? You'd have to ask the Dolphin folks (IRC, kfm-devel list, tag someone on Phab) about that and what they prefer.

To be honest, I also don't know if that is a bug or a feature, but my first thought was, hm there is something broken. :) Ok, have checked that again and Dolphin also renames it as soon as you scroll with the scroll bar.

Sun, Nov 12, 8:06 PM · Dolphin
ngraham accepted D8273: Change window title when searching.

Good enough for me.

Sun, Nov 12, 7:39 PM · Dolphin
rkflx added a comment to T7443: Rename inline: UI glitch during scrolling with mouse wheel.

Let's just let Andreas decide where he wants to discuss his work :)

Sun, Nov 12, 7:38 PM · Dolphin
ngraham added a comment to T7443: Rename inline: UI glitch during scrolling with mouse wheel.

Oh haha I didn't notice that this was a task and not a patch. Phooey. Yeah, we should close this task because we already have a Bugzilla ticket tracking the issue (as well as other related ones).

Sun, Nov 12, 7:36 PM · Dolphin
rkflx added a comment to T7443: Rename inline: UI glitch during scrolling with mouse wheel.

@ngraham Not sure adding BUG: to a task will work, as the commit hook responsible for closing the bug will be triggered by an actual commit including this with no relation to Phab and its tasks at all.

Sun, Nov 12, 7:35 PM · Dolphin
elvisangelaccio removed a reviewer for D8273: Change window title when searching: KDE Applications.
Sun, Nov 12, 7:30 PM · Dolphin
xyquadrat added inline comments to D8273: Change window title when searching.
Sun, Nov 12, 7:15 PM · Dolphin
ngraham updated the task description for T7443: Rename inline: UI glitch during scrolling with mouse wheel.
Sun, Nov 12, 7:14 PM · Dolphin
xyquadrat updated the diff for D8273: Change window title when searching.

Removed the facetType() and currentFacet() function as proposed by @elvisangelaccio. Merged the search and text variable into searchText, which now uses %1 to add in the current search text for better localization. But I am not entirely sure if the consent is that we remove the facets from the title (which gives more space) or if I should keep it (which gives more information to the user) but adapt to the other comments.

Sun, Nov 12, 7:14 PM · Dolphin
ngraham added a comment to T7443: Rename inline: UI glitch during scrolling with mouse wheel.

This definitely resolves 378786. Not sure whether 331236is a duplicate of it, or whether something else is needed there. @akrutzler, could you confirm?

Sun, Nov 12, 7:14 PM · Dolphin
rkflx added a comment to T7443: Rename inline: UI glitch during scrolling with mouse wheel.

Cancle renaming, such as in scrolling with the scroll bar

Sun, Nov 12, 6:40 PM · Dolphin
elvisangelaccio requested changes to D8273: Change window title when searching.
Sun, Nov 12, 6:09 PM · Dolphin
anthonyfieroni added a comment to D8273: Change window title when searching.

It looks good to me +1

Sun, Nov 12, 5:21 PM · Dolphin
xyquadrat updated the diff for D8273: Change window title when searching.

@elvisangelaccio The basic patch is the same, but the "Places" feature has been added & some code style changes were made.

Sun, Nov 12, 4:41 PM · Dolphin
akrutzler created T7443: Rename inline: UI glitch during scrolling with mouse wheel.
Sun, Nov 12, 4:01 PM · Dolphin
anthonyfieroni added a comment to D8273: Change window title when searching.

Function should looks like:

void DolphinMainWindow::setUrlAsCaption(const QUrl& url)
{
    static KFilePlacesModel s_placesModel;
Sun, Nov 12, 3:02 PM · Dolphin
elvisangelaccio added a comment to D8273: Change window title when searching.

Patch works for me as well now.

Sun, Nov 12, 2:56 PM · Dolphin
xyquadrat added a comment to D8273: Change window title when searching.

Hmm, I tested it multiple times (also with a completely fresh copy & applying the patch) and it always worked for me.

Sun, Nov 12, 2:44 PM · Dolphin
ngraham added a comment to D8273: Change window title when searching.

The good news: the patch now applies cleanly with arc patch!

Sun, Nov 12, 2:19 PM · Dolphin
emateli added a comment to D6281: Prevent folders from drag and dropping onto themselves in dolphin main view.
In D6281#166581, @rkflx wrote:

@emateli With 5 patches contributed successfully over the last months (and more in the pipeline, perhaps? ;), have you considered applying for a developer account?

Sun, Nov 12, 2:08 PM · Dolphin
xyquadrat updated the diff for D8273: Change window title when searching.

I am not very experienced with git and arc , but I think that everything should work now. Sorry for all the trouble with this patch.

Sun, Nov 12, 11:50 AM · Dolphin

Sat, Nov 11

rkflx added a comment to D6281: Prevent folders from drag and dropping onto themselves in dolphin main view.

@emateli With 5 patches contributed successfully over the last months (and more in the pipeline, perhaps? ;), have you considered applying for a developer account?

Sat, Nov 11, 7:36 PM · Dolphin
elvisangelaccio added a comment to D8273: Change window title when searching.

Weird, when I do

arc patch D8273

on the lastest master, the patch applies perfectly fine for me.

Sat, Nov 11, 3:25 PM · Dolphin
xyquadrat added a comment to D8273: Change window title when searching.

Weird, when I do

arc patch D8273

on the lastest master, the patch applies perfectly fine for me.

Sat, Nov 11, 3:09 PM · Dolphin
elvisangelaccio closed D6281: Prevent folders from drag and dropping onto themselves in dolphin main view.
Sat, Nov 11, 2:11 PM · Dolphin
dfaure accepted D6281: Prevent folders from drag and dropping onto themselves in dolphin main view.
Sat, Nov 11, 8:27 AM · Dolphin
ngraham added a comment to D8273: Change window title when searching.

Hmm, the patch doesn't apply for me using arc patch:

Sat, Nov 11, 3:23 AM · Dolphin

Fri, Nov 10

xyquadrat updated the diff for D8273: Change window title when searching.

This revision adds the feature proposed by @ngraham. The search text will now change to "Search for [type] named [input]" or "Search for [type]" if the user did not input a search term.

Fri, Nov 10, 8:42 PM · Dolphin
ngraham closed T7185: Icon for kio-stash action as Resolved by committing R318:0905b13dc49f: Use new folder-stash icon.
Fri, Nov 10, 4:36 PM · Dolphin, VDG
elvisangelaccio accepted D6281: Prevent folders from drag and dropping onto themselves in dolphin main view.

@dfaure Is this ok for you now?

Fri, Nov 10, 4:15 PM · Dolphin

Wed, Nov 8

emateli updated the diff for D6281: Prevent folders from drag and dropping onto themselves in dolphin main view.

method reorder

Wed, Nov 8, 6:52 PM · Dolphin
emateli added inline comments to D6281: Prevent folders from drag and dropping onto themselves in dolphin main view.
Wed, Nov 8, 6:52 PM · Dolphin
rkflx added inline comments to D6281: Prevent folders from drag and dropping onto themselves in dolphin main view.
Wed, Nov 8, 6:48 PM · Dolphin