DolphinProject
ActivePublic

Recent Activity

Today

elvisangelaccio requested changes to D19926: Add Bookmark Handling.
Sat, Apr 20, 2:54 PM · Dolphin
elvisangelaccio accepted D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layout The Baloo::MetaDataWidget is now able to stretch in a meaningful way by itself, remove the wrapper..
Sat, Apr 20, 2:38 PM · Dolphin
elvisangelaccio added inline comments to D20525: [InformationPanel] Use the new inline configuration mode.
Sat, Apr 20, 2:25 PM · Dolphin
elvisangelaccio added a comment to D20660: Fix missing update of file name label in information panel without preview.

The stable branch was also affected, I cherry-picked the fix.

Sat, Apr 20, 11:22 AM · Dolphin
elvisangelaccio added a comment to D20664: Fix adding "Create New..." menu to toolbar.

Good catch, sorry for breaking it ;)

Sat, Apr 20, 10:32 AM · Dolphin

Yesterday

ngraham planned changes to D20689: Elide tab titles left so key information at the end of the string doesn't get cut off.

Yeah, that makes sense. I'll make it only elide left when showing the full path.

Fri, Apr 19, 4:46 PM · Dolphin
filipf added a comment to D20689: Elide tab titles left so key information at the end of the string doesn't get cut off.

Seems to make more sense for when the full path is shown, but my intuition is that right elision is more useful when it's just the folder name being shown.

Fri, Apr 19, 4:40 PM · Dolphin
ngraham requested review of D20689: Elide tab titles left so key information at the end of the string doesn't get cut off.
Fri, Apr 19, 4:29 PM · Dolphin

Thu, Apr 18

ngraham accepted D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layout The Baloo::MetaDataWidget is now able to stretch in a meaningful way by itself, remove the wrapper..
Thu, Apr 18, 7:56 PM · Dolphin
ngraham added a comment to D16005: Add test cases for enabled status of DolphinNewFileMenu.

Fixed that in D20664.

Thu, Apr 18, 7:17 PM · Dolphin
ngraham closed D20664: Fix adding "Create New..." menu to toolbar.
Thu, Apr 18, 7:17 PM · Dolphin
cfeck accepted D20664: Fix adding "Create New..." menu to toolbar.

Thanks for the investigation!

Thu, Apr 18, 7:15 PM · Dolphin
fbg13 added a comment to D16648: Open externally called files/directories in new tabs.

Currently opening an already open path creates a new tab.
I think it's better to just activate the existing tab.

Thu, Apr 18, 7:06 PM · Dolphin
bruns requested review of D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layout The Baloo::MetaDataWidget is now able to stretch in a meaningful way by itself, remove the wrapper..
Thu, Apr 18, 3:00 PM · Dolphin
broulik added a comment to D20664: Fix adding "Create New..." menu to toolbar.

+1

Thu, Apr 18, 2:01 PM · Dolphin
ngraham requested review of D20664: Fix adding "Create New..." menu to toolbar.
Thu, Apr 18, 1:46 PM · Dolphin
bruns closed D20660: Fix missing update of file name label in information panel without preview.
Thu, Apr 18, 1:45 PM · Dolphin
meven accepted D20660: Fix missing update of file name label in information panel without preview.

Good catch, thanks

Thu, Apr 18, 1:25 PM · Dolphin
bruns requested review of D20660: Fix missing update of file name label in information panel without preview.
Thu, Apr 18, 12:41 PM · Dolphin

Wed, Apr 17

msciubidlo updated the diff for D20427: When renaming files, move to next file using tab key..
Wed, Apr 17, 11:13 PM · Dolphin
ngraham added a comment to D16005: Add test cases for enabled status of DolphinNewFileMenu.

Unfortunately this caused https://bugs.kde.org/show_bug.cgi?id=405780. Specifically, the change to src/dolphinmainwindow.cpp.

Wed, Apr 17, 9:12 PM · Dolphin

Tue, Apr 16

bruns updated the diff for D20525: [InformationPanel] Use the new inline configuration mode.

disable configure action when in configuration mode

Tue, Apr 16, 11:08 PM · Dolphin
cfeck added a comment to D20052: Make tabs rename-able.

Do you plan to make (the requested) changes? If yes, please change the status.

Tue, Apr 16, 7:19 PM · Dolphin
fbg13 added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

I don't think the navigation is a suitable place, since it's not limited only to going up one folder.

Tue, Apr 16, 6:16 PM · Dolphin
ngraham added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

I'm afraid I don't have the answers to those questions. :(

Tue, Apr 16, 5:51 PM · Dolphin
fbg13 added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

Since the requested feature from Windows Explorer was itself implemented as an add-on, maybe this should be a plugin too?

Tue, Apr 16, 4:33 PM · Dolphin
bruns added a comment to D20525: [InformationPanel] Use the new inline configuration mode.

+1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is narrow:

I imagine it would be even worse in German or with a Romance language. Maybe in edit mode, you can just show the properties and not their values as well?

This is probably a caused by the minimum width calculation now being off.

I think it is quite useful to have the values, especially for some more "obscure" properties. The user gets an immediate feedback if the property is the one she/he is interested in. Maybe just cutoff or ellide the value, and make sure the label is visible.

Tue, Apr 16, 1:28 PM · Dolphin

Mon, Apr 15

ngraham added a comment to D12162: Add support for touch scrolling in Dolphin.

Friendly ping! :)

Mon, Apr 15, 6:16 PM · Dolphin
ngraham accepted D19770: Use placeholder for search action.

Still LGTM. @elvisangelaccio?

Mon, Apr 15, 2:58 PM · Documentation, Dolphin
richardl added a comment to D19311: Add navigation history to forward/back buttons.

@richardl
As I see it, showing both forward and backward entries at the same time is a smart idea if your interface requires having a single button for this feature. Otherwise, it doesn't make much sense because one would never click on the backward navigation button to pick a forward entry. Having to see the forward entries first to decide which backward entry to pick is not a common case either (and vicecersa). Thus, in most cases you'd just have to deal with the drawback of limiting the amount of forward-only or backward-only entries that can be shown, which in addition is counter-productive if you want to roll back a lot of entries.

I can't follow the remark about the single button, since there are clearly two buttons in firefox? Anyways, the rationale in firefox is IMHO that the user wants to jump to one point in the history, but if that's in the forward or backward history might not be known (in advance). (For a single (or double) forward/back one wouldn't invoke the menu anyways.) If you take this uncertainty into account the unified menu makes much more sense.

Mon, Apr 15, 2:54 PM · Dolphin
ngraham added a comment to D20396: Don't show "Open With" menu items for empty directories.

Any app that registers itself as able to open directories generally can't do anything useful with an empty directory.

If I may offer a counter-example (rather late, I know), one category of applications that an "Open with" on an empty dir is quite useful for are code editors. The way many people start new projects, for example, is by creating a new dir (in Dolphin) and using "Open with" to open it in their editor (like VS Code).

I know this workflow can be re-created with an action (like the one for Konsole), but at least to me, "Open with" seems more intuitive for this.

Mon, Apr 15, 2:06 PM · Dolphin
davidedmundson added a comment to D16648: Open externally called files/directories in new tabs.

activateWindow works if and only if your X startup info is correct.

Mon, Apr 15, 2:02 PM · Dolphin
feverfew added a comment to D16648: Open externally called files/directories in new tabs.

This made me think: what about non-plasma systems?
e.g. GNOME doesn't even have a taskbar, what's gonna happen there?

Mon, Apr 15, 12:07 PM · Dolphin
franga2000 added a comment to D20396: Don't show "Open With" menu items for empty directories.

Any app that registers itself as able to open directories generally can't do anything useful with an empty directory.

Mon, Apr 15, 11:20 AM · Dolphin
bruns added inline comments to D20525: [InformationPanel] Use the new inline configuration mode.
Mon, Apr 15, 10:09 AM · Dolphin
bruns updated the diff for D20525: [InformationPanel] Use the new inline configuration mode.

bump baloo widgets version
cleanup

Mon, Apr 15, 10:09 AM · Dolphin
GB_2 added a comment to D19770: Use placeholder for search action.

Ping @elvisangelaccio

Mon, Apr 15, 7:38 AM · Documentation, Dolphin
ngraham accepted D20427: When renaming files, move to next file using tab key..

Nice, this works great! I think it's a very useful and unobtrusive feature. I'll hand this show over to @elvisangelaccio now. :)

Mon, Apr 15, 3:19 AM · Dolphin
ngraham updated the summary of D20427: When renaming files, move to next file using tab key..
Mon, Apr 15, 3:18 AM · Dolphin
ngraham added a comment to D19311: Add navigation history to forward/back buttons.

The Breeze patch looks sane. I'm torn on whether or not adding the new style to KWidgetsAddons makes sense though. Couldn't Dolphin just set the new _kde_toolButton_noMenuArrow on just these buttons?

Mon, Apr 15, 2:36 AM · Dolphin
ngraham added reviewers for D20532: Proof of Concept: Add double click actions to empty space in the folder view: Dolphin, elvisangelaccio, VDG.

To be honest, I'm kind of torn on this. On one hand, it seems like a very powerful feature, and that experts could get a lot out of it.

Mon, Apr 15, 2:16 AM · Dolphin

Sun, Apr 14

elvisangelaccio added a comment to D20427: When renaming files, move to next file using tab key..

what does it means? is it done already?

@msciubidlo See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

Sun, Apr 14, 9:07 PM · Dolphin
msciubidlo updated the diff for D20427: When renaming files, move to next file using tab key..

Added support for feature 269987.

Sun, Apr 14, 9:04 PM · Dolphin
elvisangelaccio added a comment to D20525: [InformationPanel] Use the new inline configuration mode.

About the UI, I noticed that when the panel is in "configure" mode, it's still possible to right-click it and click the "Configure" entry, which will do nothing.
We could fix this by disabling the entry once clicked. Another idea: make the entry checkable instead of using the buttonbox.

Sun, Apr 14, 8:45 PM · Dolphin
elvisangelaccio requested changes to D20525: [InformationPanel] Use the new inline configuration mode.

Please bump the minimum required version for KF5BalooWidgets to 19.07.70.

Sun, Apr 14, 8:45 PM · Dolphin
hallas added a comment to D19311: Add navigation history to forward/back buttons.
  • Modify/extend the Breeze theme to draw this button (via some special flag or something) without arrows, even though it has a delayed menu (maybe this should be a general change). Personally this would be my choice.

I agree, this is best. For inspiration, you might check out the following abandoned Breeze patch that did something similar and allowed opting out on a widget-by-widget basis: D13064 Maybe all we need to do is implement that opting-out mechanism for existing press-and-hold menu toolbuttons, and then set the hint in these buttons here.

Sun, Apr 14, 5:52 PM · Dolphin
hallas added a comment to D19311: Add navigation history to forward/back buttons.

@richardl - thanks for the feedback! I tend to agree with @david.fontanals in that it makes most sense to only show the back history in the back button and the forward history in the forward button. This also seems to be the behavior of Chrome (though I don't know how much it matters :) ).

Sun, Apr 14, 5:40 PM · Dolphin
david.fontanals added a comment to D19311: Add navigation history to forward/back buttons.

@richardl
As I see it, showing both forward and backward entries at the same time is a smart idea if your interface requires having a single button for this feature. Otherwise, it doesn't make much sense because one would never click on the backward navigation button to pick a forward entry. Having to see the forward entries first to decide which backward entry to pick is not a common case either. Thus, in most cases you'd just have to deal with the drawback of limiting the amount of forward-only or backward-only entries that can be shown, which in addition is counter-productive if you want to roll back a lot of entries.

Sun, Apr 14, 3:44 PM · Dolphin
bruns added a comment to D20525: [InformationPanel] Use the new inline configuration mode.

+1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is narrow:

I imagine it would be even worse in German or with a Romance language. Maybe in edit mode, you can just show the properties and not their values as well?

Sun, Apr 14, 2:20 PM · Dolphin
ngraham added a comment to D20525: [InformationPanel] Use the new inline configuration mode.

+1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is narrow:

Sun, Apr 14, 2:14 PM · Dolphin