DolphinProject
ActivePublic

Recent Activity

Today

rkflx added a comment to D10804: Show "Empty trash" button inside trash directory.

Thanks, having such a button in plain sight is a very sensible idea. Not sure about your custom bar yet, though, so here are two more ideas:

  • Show a KMessageWidget like Okular does for PDFs with forms. This would look a bit like the Nautilus screenshot in the bug. On the other hand it's not really a message.
  • Dynamically add a button to the toolbar. Konqueror used to do this for different KParts, it was a bit annoying when buttons jumped around. However I think it can be done:
    • Align Control button to the right (this would be good to have anyway!).
    • Now even in the default config there should be enough space to add Empty trash right after Split when visiting trash:/, without anything jumping around.
    • Set the button state to "disabled" once the trash has been emptied.
Sun, Feb 25, 8:36 AM · Dolphin
rominf added a comment to D10804: Show "Empty trash" button inside trash directory.

Maybe send an email to kde-devel@kde.org?

Sun, Feb 25, 3:50 AM · Dolphin
ngraham added a comment to D10804: Show "Empty trash" button inside trash directory.

Maybe send an email to kde-devel@kde.org?

Sun, Feb 25, 2:51 AM · Dolphin

Yesterday

rominf added a comment to D10804: Show "Empty trash" button inside trash directory.

Yes, that would be in a separate diff. If you'd like, implement the feature in Dolphin for now, and then we can remove it when your KIO patch lands. Otherwise we'll have to delay this by a few weeks or more, waiting for whatever KDE Frameworks version your KIO patch lands in.

Sat, Feb 24, 11:57 PM · Dolphin
ngraham added a comment to D10804: Show "Empty trash" button inside trash directory.

Yes, that would be in a separate diff. If you'd like, implement the feature in Dolphin for now, and then we can remove it when your KIO patch lands. Otherwise we'll have to delay this by a few weeks or more, waiting for whatever KDE Frameworks version your KIO patch lands in.

Sat, Feb 24, 11:25 PM · Dolphin
rominf added a comment to D10804: Show "Empty trash" button inside trash directory.

I think that checking trash emptiness with KIO can be implemented in separate diff because it concerns another place. I guess I'm done.

Sat, Feb 24, 11:23 PM · Dolphin
ngraham added a comment to D10804: Show "Empty trash" button inside trash directory.

It would be better to show button only if trash is not empty. KIO (https://api.kde.org/frameworks/kio/html/namespaceKIO.html) doesn't have isTrashEmpty function. Now Dolphin uses special code to check it. I propose to add it there. Can you point me at KIO repo?

Sat, Feb 24, 11:12 PM · Dolphin
rominf updated the summary of D10804: Show "Empty trash" button inside trash directory.
Sat, Feb 24, 11:12 PM · Dolphin
rominf added a comment to D10804: Show "Empty trash" button inside trash directory.

It would be better to show button only if trash is not empty. KIO (https://api.kde.org/frameworks/kio/html/namespaceKIO.html) doesn't have isTrashEmpty function. Now Dolphin uses special code to check it. I propose to add it there. Can you point me at KIO repo?

Sat, Feb 24, 11:11 PM · Dolphin
ngraham added a comment to D10804: Show "Empty trash" button inside trash directory.

No need for a space between FEATURE and the :

Sat, Feb 24, 11:10 PM · Dolphin
rominf updated the summary of D10804: Show "Empty trash" button inside trash directory.
Sat, Feb 24, 11:07 PM · Dolphin
rominf added a comment to D10804: Show "Empty trash" button inside trash directory.
  1. This is definitely better than not having it, but it needs some UI polish. How about:
    1. Make the "Empty Trash button smaller, somehow. Do we have a less tall button we can use for this?

Why? In my opinion all buttons should be the same.

Sat, Feb 24, 11:06 PM · Dolphin
rominf updated the diff for D10804: Show "Empty trash" button inside trash directory.

Fixed compilation. Unified empty trash functions.

Sat, Feb 24, 11:01 PM · Dolphin
ngraham added inline comments to D10804: Show "Empty trash" button inside trash directory.
Sat, Feb 24, 10:52 PM · Dolphin
ngraham added a comment to D10804: Show "Empty trash" button inside trash directory.

Make sure it compiles before pushing, please. Now it no longer does for me:

Sat, Feb 24, 10:49 PM · Dolphin
rominf updated the diff for D10804: Show "Empty trash" button inside trash directory.

Add licenses, move "Empty trash" button to the right, remove close button.

Sat, Feb 24, 10:47 PM · Dolphin
ngraham added a comment to D10804: Show "Empty trash" button inside trash directory.

There is 3 places that is responsible for emptying trash. 2 of them use code from trash/dolphintrash.cpp. Third place is https://github.com/KDE/dolphin/blob/master/src/panels/places/placespanel.cpp#L458

The code differs a little bit and I don't understand why. What should we do with that?

Sat, Feb 24, 10:40 PM · Dolphin
rominf added a comment to D10804: Show "Empty trash" button inside trash directory.

There is 3 places that is responsible for emptying trash. 2 of them use code from trash/dolphintrash.cpp. Third place is https://github.com/KDE/dolphin/blob/master/src/panels/places/placespanel.cpp#L458

Sat, Feb 24, 10:38 PM · Dolphin
ngraham requested changes to D10804: Show "Empty trash" button inside trash directory.
Sat, Feb 24, 10:34 PM · Dolphin
ngraham added a comment to D10804: Show "Empty trash" button inside trash directory.

Thanks for the patch! Couple of notes:

Sat, Feb 24, 10:34 PM · Dolphin
rominf updated the summary of D10804: Show "Empty trash" button inside trash directory.
Sat, Feb 24, 10:30 PM · Dolphin
mmustac updated subscribers of D10804: Show "Empty trash" button inside trash directory.

Cool :-D Can you add a screenshot as well?

Sat, Feb 24, 10:17 PM · Dolphin
rominf added a reviewer for D10804: Show "Empty trash" button inside trash directory: KDE Applications.
Sat, Feb 24, 7:24 PM · Dolphin
rominf updated the test plan for D10804: Show "Empty trash" button inside trash directory.
Sat, Feb 24, 7:22 PM · Dolphin
rominf updated the diff for D10804: Show "Empty trash" button inside trash directory.

Add missed files

Sat, Feb 24, 7:19 PM · Dolphin
rominf updated the summary of D10804: Show "Empty trash" button inside trash directory.
Sat, Feb 24, 7:12 PM · Dolphin
rominf added a reviewer for D10804: Show "Empty trash" button inside trash directory: Dolphin.
Sat, Feb 24, 7:03 PM · Dolphin
michaelh added a comment to T5190: [search] Regex patterns should not be the default.

I'm working on the search GUI anyway. Going to add an option for this.
Will take some time, though.

Sat, Feb 24, 9:00 AM · Dolphin
michaelh claimed T5190: [search] Regex patterns should not be the default.
Sat, Feb 24, 8:59 AM · Dolphin
michaelh created T8068: Don't put .directory files in ~/Vaults/*.
Sat, Feb 24, 8:58 AM · Dolphin

Tue, Feb 20

michaelh added a comment to D10694: epubextractor: Handle multiple subjects better.

The only component I could find to be affected by this change is baloo-widgets. I have already adapted it to this change. And yes, it will handle both.
It will take a some time to publish it because some other stuff has to get reviewed first.
I you know of any component or application using the epub-extractor of KFileMetadata apart from baloo-widgets please let me know.

Tue, Feb 20, 10:48 PM · Frameworks, Dolphin, Baloo
mgallien added a comment to D10694: epubextractor: Handle multiple subjects better.

@mgallien Then they won't benefit from this until a file is reindexed.
Users with baloo disabled will benefit, because in that case baloo_filemetadata_temp_extractor will extract the data on-the-fly.
Reindexing just the ebooks can be done with:

find ~/EBooks/ -type f -name "*.epub" | { mapfile -t; balooctl clear "${MAPFILE[@]}";  balooctl index "${MAPFILE[@]}"; }
Tue, Feb 20, 9:00 PM · Frameworks, Dolphin, Baloo
michaelh added a comment to D10694: epubextractor: Handle multiple subjects better.

@mgallien Then they won't benefit from this until a file is reindexed.
Users with baloo disabled will benefit, because in that case baloo_filemetadata_temp_extractor will extract the data on-the-fly.
Reindexing just the ebooks can be done with:

Tue, Feb 20, 7:56 PM · Frameworks, Dolphin, Baloo
mgallien added a comment to D10694: epubextractor: Handle multiple subjects better.

The problem with any changes to the extractors its that the baloo database of users will not be refreshed.

Tue, Feb 20, 7:19 PM · Frameworks, Dolphin, Baloo
michaelh requested review of D10694: epubextractor: Handle multiple subjects better.
Tue, Feb 20, 6:54 PM · Frameworks, Dolphin, Baloo

Sat, Feb 17

funkybomber added a comment to T7094: Oxygen Icon Theme makes the "Rating" metadata to display incorrect values..

The changes have not yet appeared in my KDE Neon Developer installation. Perhaps I need to follow some manual steps in order to get the changes on my system?

Sat, Feb 17, 7:38 AM · Dolphin

Tue, Feb 13

elvisangelaccio closed D10190: Fix resetting "View Modes" preferences to defaults.
Tue, Feb 13, 10:21 PM · Dolphin
elvisangelaccio accepted D10190: Fix resetting "View Modes" preferences to defaults.
Tue, Feb 13, 10:17 PM · Dolphin

Mon, Feb 12

hoffmannrobert updated the diff for D10190: Fix resetting "View Modes" preferences to defaults.
  • Make settings const, request by elvisangelaccio
Mon, Feb 12, 2:17 PM · Dolphin

Sat, Feb 10

elvisangelaccio added inline comments to D10190: Fix resetting "View Modes" preferences to defaults.
Sat, Feb 10, 6:21 PM · Dolphin

Wed, Feb 7

ngraham changed the status of T7094: Oxygen Icon Theme makes the "Rating" metadata to display incorrect values. from Invalid to Resolved.
Wed, Feb 7, 1:36 AM · Dolphin
andreask added a comment to T7094: Oxygen Icon Theme makes the "Rating" metadata to display incorrect values..

fixed in oxygen see bug report

Wed, Feb 7, 1:14 AM · Dolphin

Tue, Feb 6

ngraham added a comment to T7894: Investigate changing Fn-key shortcuts to show/hide panels.

Or maybe we could just change the F11 shortcut to F10 or F12 something. That would be simplest, and make room for a future F11 Full Screen feature in Dolphin

Tue, Feb 6, 5:21 PM · Dolphin
rkflx added a comment to T7894: Investigate changing Fn-key shortcuts to show/hide panels.

One more thing, then I'll leave for real ;) : Looking at Kate and Gwenview, those also toggle UI features with function keys. As long as Dolphin does not provide a Fullscreen mode, F11 is not much of an issue IMO, it's just the way it evolved over the years… If it is ever added, we could move panel hiding to F12 or repurpose the alternative/second shortcut for hidden files (F8).

Tue, Feb 6, 9:39 AM · Dolphin
ngraham added a comment to T7894: Investigate changing Fn-key shortcuts to show/hide panels.

Good points.

Tue, Feb 6, 12:07 AM · Dolphin

Mon, Feb 5

rkflx added a comment to T7894: Investigate changing Fn-key shortcuts to show/hide panels.

I'll not get too involved in this one, but two observations:

  • Having to use two hands to perform a shortcut is annoying. Some keyboards do still provide function keys…
  • In languages other than English the names are different, so there you won't gain much in terms of this nice-to-remember scheme anyway.
Mon, Feb 5, 11:51 PM · Dolphin
ngraham closed T7040: Drop KFilePlacesModel fork as Resolved.

Closing since this is done now!

Mon, Feb 5, 9:47 PM · Frameworks, Dolphin
ngraham updated the task description for T7894: Investigate changing Fn-key shortcuts to show/hide panels.
Mon, Feb 5, 9:45 PM · Dolphin
ngraham created T7894: Investigate changing Fn-key shortcuts to show/hide panels.
Mon, Feb 5, 9:44 PM · Dolphin
hoffmannrobert updated the test plan for D10190: Fix resetting "View Modes" preferences to defaults.
Mon, Feb 5, 11:41 AM · Dolphin