DolphinProject
ActivePublic

Recent Activity

Today

elvisangelaccio accepted D14980: Restore settings label and prevent warning when Baloo is unavailable.

Ops. Thanks for the fix!

Tue, Aug 21, 9:47 PM · Dolphin
rkflx requested review of D14980: Restore settings label and prevent warning when Baloo is unavailable.
Tue, Aug 21, 7:13 PM · Dolphin
rkflx added a comment to D14814: Port away from kdelibs4support.

Would you be ok if we just disable that checkbox?

Tue, Aug 21, 7:12 PM · Dolphin

Yesterday

elvisangelaccio closed T8720: Get rid of kdelibs4support in dolphin as Resolved by committing R318:6674c9c387d0: Port away from kdelibs4support.
Mon, Aug 20, 11:05 PM · Dolphin
elvisangelaccio closed D14814: Port away from kdelibs4support.
Mon, Aug 20, 11:05 PM · Dolphin
ngraham accepted D14814: Port away from kdelibs4support.

Fantastic, thanks! Works great now.

Mon, Aug 20, 7:02 PM · Dolphin
elvisangelaccio updated the diff for D14814: Port away from kdelibs4support.
  • Also hide 'Show tooltips' checkbox from settings dialog
Mon, Aug 20, 5:14 PM · Dolphin
elvisangelaccio added a comment to D14814: Port away from kdelibs4support.

Hmm, every UI element referencing the information panel disappears completely with no Baloo support, so I'd prefer to be consistent if possible, even if it's messier than we might prefer. :/ Is there any refactoring we could do beforehand in another commit that might make that easier?

Mon, Aug 20, 5:08 PM · Dolphin
ngraham added a comment to D14814: Port away from kdelibs4support.

Hmm, every UI element referencing the information panel disappears completely with no Baloo support, so I'd prefer to be consistent if possible, even if it's messier than we might prefer. :/ Is there any refactoring we could do beforehand in another commit that might make that easier?

Mon, Aug 20, 5:04 PM · Dolphin
elvisangelaccio added a comment to D14814: Port away from kdelibs4support.

Well spotted. Would you be ok if we just disable that checkbox? (otherwise if we want to remove it, we'd need a lot more #ifdefs, which I'd like to avoid).

Mon, Aug 20, 5:01 PM · Dolphin
ngraham requested changes to D14814: Port away from kdelibs4support.

+1 conceptually. Everything looks good and works well, and all the tests pass. however I agree with @rkflx and would like to see the Show Tooltips checkbox removed when Baloo support has not been compiled in. No reason to show users features that are unavailable due to distro decisions.

Mon, Aug 20, 12:57 PM · Dolphin
ngraham added a comment to D14442: Unify window and tab title.

I'm pretty much okay with the current approach. @markg, thoughts?

Mon, Aug 20, 12:31 PM · Dolphin
broulik closed D14880: Read UDS entry times directly and pretty-print on-demand.
Mon, Aug 20, 10:12 AM · Dolphin

Sun, Aug 19

rkflx accepted D14814: Port away from kdelibs4support.

I tried your test plan, which works as advertised. Code LGTM too. Let's get rid of kdelibs4support…

Sun, Aug 19, 8:55 PM · Dolphin

Sat, Aug 18

dfaure accepted D14880: Read UDS entry times directly and pretty-print on-demand.
Sat, Aug 18, 11:33 AM · Dolphin

Fri, Aug 17

elvisangelaccio added a comment to D14814: Port away from kdelibs4support.

Ping

Fri, Aug 17, 8:15 AM · Dolphin

Thu, Aug 16

broulik closed D14878: Pretty-print "creationtime" role.
Thu, Aug 16, 2:28 PM · Dolphin
broulik retitled D14880: Read UDS entry times directly and pretty-print on-demand from Read USD entry times directly and pretty-print on-demand to Read UDS entry times directly and pretty-print on-demand.
Thu, Aug 16, 2:22 PM · Dolphin
broulik requested review of D14880: Read UDS entry times directly and pretty-print on-demand.
Thu, Aug 16, 2:22 PM · Dolphin
elvisangelaccio accepted D14878: Pretty-print "creationtime" role.
Thu, Aug 16, 2:19 PM · Dolphin
broulik updated the test plan for D14878: Pretty-print "creationtime" role.
Thu, Aug 16, 2:13 PM · Dolphin
broulik requested review of D14878: Pretty-print "creationtime" role.
Thu, Aug 16, 2:13 PM · Dolphin
bcooksley added a comment to D13813: Make this test work again with new uds implementation.

That would have happened locally, shouldn't be anything to do with our systems - especially given it's a Travis CI name/address being mentioned.

Thu, Aug 16, 12:22 PM · Dolphin
elvisangelaccio added a comment to D13813: Make this test work again with new uds implementation.

Authored by a Bot?

Somehow my name and email address in .gitconfig got changed. How? No idea.
Should revert and push again with the right name?

Thu, Aug 16, 11:44 AM · Dolphin
jtamate added a comment to D13813: Make this test work again with new uds implementation.

Authored by a Bot?

Thu, Aug 16, 11:42 AM · Dolphin
elvisangelaccio updated subscribers of D13813: Make this test work again with new uds implementation.

Authored by a Bot?

Thu, Aug 16, 11:42 AM · Dolphin
cfeck added a comment to D13813: Make this test work again with new uds implementation.

Authored by a Bot?

Thu, Aug 16, 11:10 AM · Dolphin
Diffusion closed D13813: Make this test work again with new uds implementation.
Thu, Aug 16, 11:06 AM · Dolphin
elvisangelaccio accepted D13813: Make this test work again with new uds implementation.

Right. Then let's ship it as is for now, thanks!

Thu, Aug 16, 10:33 AM · Dolphin

Wed, Aug 15

cfeck added inline comments to D13806: Store icons with correct devicePixelRatio.
Wed, Aug 15, 3:19 PM · Dolphin
hallas added a comment to D14442: Unify window and tab title.

A possible fix for you would be to listen for the KCoreDirLister::started signal, but that object alone is hidden quite deeply (It's a member of KFileItemModel) and i don't even know if that would work. You're best of making a small test project to test this out.
Also, if that is not working, it would probably be accepted as a patch to have the rootitem set when started is emitted. That would be a patch to KCoreDirLister.

To answer myself.
Don't bother listening for the KCoreDirLister::started signal and then getting the rootitem. It's not set yet at that point. Just tried that out.

Wed, Aug 15, 12:44 PM · Dolphin
jtamate added a comment to D13813: Make this test work again with new uds implementation.

@jtamate Any updates on this? Can you use the new fastInsert() calls here?

Not until dolphin depends on KIO 5.47, currently its minimum required kio version is 5.43.

Wed, Aug 15, 10:07 AM · Dolphin
elvisangelaccio added a comment to D13813: Make this test work again with new uds implementation.

@jtamate Any updates on this? Can you use the new fastInsert() calls here?

Wed, Aug 15, 8:59 AM · Dolphin

Mon, Aug 13

abetts added a project to T9356: AppImage Awarness in plasma Desktop: VDG.
Mon, Aug 13, 10:29 PM · VDG, Plasma, Dolphin
abetts added a comment to T9356: AppImage Awarness in plasma Desktop.

We can help with the icon!

Mon, Aug 13, 10:29 PM · VDG, Plasma, Dolphin
elvisangelaccio requested review of D14814: Port away from kdelibs4support.
Mon, Aug 13, 10:21 PM · Dolphin
elvisangelaccio added a revision to T8720: Get rid of kdelibs4support in dolphin: D14814: Port away from kdelibs4support.
Mon, Aug 13, 10:21 PM · Dolphin
azubieta added a comment to T9356: AppImage Awarness in plasma Desktop.

We already have this AppImage Thumbnailer for KDE, it may require some review: https://github.com/azubieta/KDE-AppImage-Thumbnailer

Mon, Aug 13, 10:10 AM · VDG, Plasma, Dolphin
azubieta triaged T9356: AppImage Awarness in plasma Desktop as Normal priority.
Mon, Aug 13, 10:08 AM · VDG, Plasma, Dolphin
ngraham added a comment to D14770: Generate file thumbnails before folder thumbnails.

Yes, I used the latest version of the patch. My comments are still:

  • With folders interspersed within the files: big improvement
  • With folders first:
    • Small number of sub-folders: big improvement
    • Medium number of sub-folders: a wash
    • Enough sub-folders so that you need to scroll to see any files: regression since it seems for a moment that nothing's happening
Mon, Aug 13, 8:19 AM · Dolphin
broulik added a comment to D14770: Generate file thumbnails before folder thumbnails.

Did you check the updated version with stable_partition? It makes the folders generate in the correct order as well.

Mon, Aug 13, 8:14 AM · Dolphin
abetts added a comment to D14770: Generate file thumbnails before folder thumbnails.

Just gave this a try on my pictures folder, with "Folders first" turned on (it's the default setting). Observations:

  • In a folder with a small number of sub-folders and a large number of images, it's nicer, since the fime thumbnails show up faster
  • In a folder with a medium number of sub-folders, it's tiny bit odd but mostly fine.
  • In a folder with a large number of sub-folders (more than will fit on the screen at once), it's very odd since it looks like nothing it happening for a few moments.

What would happen if the user selects a view mode that is contrary to the arrangement of Folders > Thumbnails and instead arranged the sorting to be Thumbnails (Images) > Folders ? Would this mean that folders load first still?

This makes folders load last, not first. There is no "thumbnails before folders" mode, but there is a mode to intersperse folders within files (the way macOS finder does by default). In this mode, the change is much less noticeable.

Mon, Aug 13, 8:08 AM · Dolphin
ngraham added a comment to D14770: Generate file thumbnails before folder thumbnails.

Just gave this a try on my pictures folder, with "Folders first" turned on (it's the default setting). Observations:

  • In a folder with a small number of sub-folders and a large number of images, it's nicer, since the fime thumbnails show up faster
  • In a folder with a medium number of sub-folders, it's tiny bit odd but mostly fine.
  • In a folder with a large number of sub-folders (more than will fit on the screen at once), it's very odd since it looks like nothing it happening for a few moments.

What would happen if the user selects a view mode that is contrary to the arrangement of Folders > Thumbnails and instead arranged the sorting to be Thumbnails (Images) > Folders ? Would this mean that folders load first still?

Mon, Aug 13, 8:07 AM · Dolphin
abetts added a comment to D14770: Generate file thumbnails before folder thumbnails.

Just gave this a try on my pictures folder, with "Folders first" turned on (it's the default setting). Observations:

  • In a folder with a small number of sub-folders and a large number of images, it's nicer, since the fime thumbnails show up faster
  • In a folder with a medium number of sub-folders, it's tiny bit odd but mostly fine.
  • In a folder with a large number of sub-folders (more than will fit on the screen at once), it's very odd since it looks like nothing it happening for a few moments.
Mon, Aug 13, 8:05 AM · Dolphin
ngraham added a comment to D14770: Generate file thumbnails before folder thumbnails.

Just gave this a try on my pictures folder, with "Folders first" turned on (it's the default setting). Observations:

  • In a folder with a small number of sub-folders and a large number of images, it's nicer, since the fime thumbnails show up faster
  • In a folder with a medium number of sub-folders, it's tiny bit odd but mostly fine.
  • In a folder with a large number of sub-folders (more than will fit on the screen at once), it's very odd since it looks like nothing it happening for a few moments.
Mon, Aug 13, 8:02 AM · Dolphin
abetts added a comment to D14770: Generate file thumbnails before folder thumbnails.

What would be an example of this? Any graphics to see?

Mon, Aug 13, 8:00 AM · Dolphin
broulik added a comment to D14770: Generate file thumbnails before folder thumbnails.

Is this about generating the thumbnails for the first time or displaying them?

Mon, Aug 13, 7:54 AM · Dolphin
broulik updated the diff for D14770: Generate file thumbnails before folder thumbnails.
  • Use stable_partition so the order of elements is preserved
Mon, Aug 13, 7:53 AM · Dolphin
ngraham added a comment to D14770: Generate file thumbnails before folder thumbnails.

Is this about generating the thumbnails for the first time or displaying them?

Mon, Aug 13, 7:53 AM · Dolphin

Sun, Aug 12

broulik requested review of D14770: Generate file thumbnails before folder thumbnails.
Sun, Aug 12, 2:52 PM · Dolphin