I'll be happy to do all the UI testing if you can do the code review!
I don't have a touch screen for actual testing, but I'll have a look asap anyway.
Sat, Oct 13
Made above requested changes by Elvis.
Fri, Oct 12
Thu, Oct 11
Fixes as per elvisangelaccio comments
We just got a bug report for this: https://bugs.kde.org/show_bug.cgi?id=399659
Wed, Oct 10
I have to say, I would love to see this behavior in Kate as well!
This is a bugfix, it should be pushed to the stable branch (Applications/18.08).
All right, ship it! Let's improve the icon in https://bugs.kde.org/show_bug.cgi?id=399613
- Drop "Folder"
Needs some more thorough investigation
I tried some programs on different operating systems and observed that Strg + W generally closes the window if it's the last tab and even closes the window on some programs that don't support tabs to begin with. Konsole also does this so it wouldn't behave differently than every other KDE app.
I am in favor of the patch. It helps understand that beyond the last tab there is no window to work with. This is sensible and other file managers do it. Seems pretty logical to me. I think we are mincing and dicing stuff that really doesn't happen. We can skip all those hypotheticals and go ahead with the patch.
If we don't want to do this, we should close the bug. If we don't want to do that, we should seriously evaluate whether or not to accept this patch.
Tue, Oct 9
This now looks good to me in terms of both code, functionality, and presentation. Make sure all other reviewers have changed their statuses to "Accepted" before landing.
Thanks! One more thing: let's use "folder" instead of "directory" for the user-facing strings.
Made above requested changes.
@ngraham makes sense to me. Will submit those subsequent patches later.
Now that I think about it, we might want to tackle that in multiple patches: