DolphinProject
ActivePublic

Recent Activity

Today

meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Improve variable naming

Fri, Jul 19, 7:21 AM · Dolphin
pdabrowski updated the diff for D22512: [Dolphin] Hide tooltip instantly on key press.

Uploaded (final?) diff with version using duplicated hideToolTip()/hideToolTipInstantly() slots.

Fri, Jul 19, 1:06 AM · Dolphin
pdabrowski updated the diff for D22512: [Dolphin] Hide tooltip instantly on key press.

Uploaded diff with version using QOverload.

Fri, Jul 19, 1:04 AM · Dolphin

Yesterday

pdabrowski added inline comments to D22512: [Dolphin] Hide tooltip instantly on key press.
Thu, Jul 18, 8:52 PM · Dolphin
pdabrowski added inline comments to D22512: [Dolphin] Hide tooltip instantly on key press.
Thu, Jul 18, 8:46 PM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Use white to black gradient unconditionally

Thu, Jul 18, 7:48 PM · Dolphin
ngraham added a comment to D22183: Add click to play/play feature on previews for audio/video.

With breeze:

+1, and let's use this style unconditionally. The lighting model itself doesn't change with the color scheme (only the colors themselves). So if there's going ot be a gradient like this, the top part of it should always have the lighter color.

Thu, Jul 18, 7:29 PM · Dolphin
abalaji added a comment to D12162: Add support for touch scrolling in Dolphin.

Hey man I'm still working on it, almost done, sorry it's been over a month.
Almost good to go. The plan is to wrap it up this weekend so we can get it
reviewed and merged before the next kde applications release

Thu, Jul 18, 5:11 PM · Dolphin
ngraham added a comment to D12162: Add support for touch scrolling in Dolphin.

Friendly ping! :)

Thu, Jul 18, 3:06 PM · Dolphin
ltoscano closed D9033: man ioslave: asserts trying to display pam(8).
Thu, Jul 18, 2:35 PM · Frameworks, Dolphin, Documentation, Plasma
brute4s99 added inline comments to D22105: WIP : Fix SFTP Plugin of KIO for Windows.
Thu, Jul 18, 11:56 AM · Frameworks, Dolphin
brute4s99 updated the diff for D22105: WIP : Fix SFTP Plugin of KIO for Windows.

updated wrt new comments. @dfaure please take another look! 👀

Thu, Jul 18, 11:56 AM · Frameworks, Dolphin
mkoller requested changes to D7820: man ioslave: spurious numbers included in clang(1) man page.

I think this was solved with bugfix to Bug Nr 335169 with commit 87d8ab4371149c84794f4e93d1f590f7bac5f327

Thu, Jul 18, 11:19 AM · Frameworks, Dolphin, Plasma
mkoller accepted D9033: man ioslave: asserts trying to display pam(8).
Thu, Jul 18, 11:02 AM · Frameworks, Dolphin, Documentation, Plasma
AndreyYashkin added a comment to D22303: Fix name grouping feature for cyrillic names.

I am sorry. I was so happy with this simple solution that forgot about one impornat aspect which is different from from language to language. If in a German dictionary 'O' and 'Ö' would be in the same group, in Russian 'Е' and 'Ё' or 'И' and 'Й' can never be together like new pacth does. Probably, it is applicable to korean, but in doesen't solve problem for all languages.

Thu, Jul 18, 10:55 AM · Dolphin
AndreyYashkin updated the diff for D22303: Fix name grouping feature for cyrillic names.

I used @hein idea to apply normalization which is implemented it unicode. Now it seems to be the final solution without working with particular writing system individually.

Thu, Jul 18, 10:05 AM · Dolphin
meven added a comment to D22183: Add click to play/play feature on previews for audio/video.

With the latest patch, I have reduced the arrow size and used a gradient to fill it to avoid low contrast with the video :

Thu, Jul 18, 9:56 AM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Add a border around the play arrow, tweak colors

Thu, Jul 18, 9:56 AM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Draw a polygone arrow with gradient

Thu, Jul 18, 9:41 AM · Dolphin
broulik added inline comments to D22512: [Dolphin] Hide tooltip instantly on key press.
Thu, Jul 18, 8:29 AM · Dolphin
meven added a comment to D21937: Use destinationDir to save viewproperties when not in global viewproperties setting.

Sorry, I missed this one. I'd say let's postpone to 19.12...

Thu, Jul 18, 6:40 AM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Coding style

Thu, Jul 18, 6:36 AM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Codying style, use constants, try to fix fractionnal scaling hdpi issue

Thu, Jul 18, 6:35 AM · Dolphin
hein added a comment to D22303: Fix name grouping feature for cyrillic names.

FYI: I gave this patch a spin with Korean and the grouping is not quite working the right way.

Thu, Jul 18, 4:06 AM · Dolphin

Wed, Jul 17

elvisangelaccio requested changes to D22512: [Dolphin] Hide tooltip instantly on key press.

Thanks for the patch! The fix looks correct, but I have suggestions for the coding style.

Wed, Jul 17, 8:17 PM · Dolphin
ngraham added a comment to D22303: Fix name grouping feature for cyrillic names.

I found it in the bug report: andreyyashkin@gmail.com

Wed, Jul 17, 8:07 PM · Dolphin
elvisangelaccio added a comment to D21937: Use destinationDir to save viewproperties when not in global viewproperties setting.

Sorry, I missed this one. I'd say let's postpone to 19.12...

Wed, Jul 17, 7:44 PM · Dolphin
elvisangelaccio requested changes to D22183: Add click to play/play feature on previews for audio/video.
Wed, Jul 17, 7:43 PM · Dolphin
elvisangelaccio closed D21590: Fix rubber band not going away after right-click.
Wed, Jul 17, 7:42 PM · Dolphin
elvisangelaccio accepted D21590: Fix rubber band not going away after right-click.
Wed, Jul 17, 7:39 PM · Dolphin
elvisangelaccio accepted D22303: Fix name grouping feature for cyrillic names.

Thanks for the patch!

Given that the correctness of this code depends on the locale, I'm not confident we won't break some corner cases.
Ideally we'd need more unit tests in KFileItemModelTest::testNameRoleGroups(), but I understand that's a lot to ask.

@cfeck in the bug report suggested to add more letters ranges. @AndreyYashkin Did you try that?

As I understand the puprose of vector "lettersAtoZ" is to put words like "Ottava" and german "Österreich" in one latin "O" group. It seems to be some feature of german language that was taken into account by the author of code. I cannot speak for all who use cyrillic script, but in russian we do not expect anything like this. Thatwhy I discarded the idea of one more range. In addition, it may be wrong to apply such behavior for all languages that use extended latin alphabets.

QCollator thinks that cyrillic symbols are less than latin characters, while chinese and others are bigger. For this reason, it is necessary to put them in a new group without searching them in the vector or they will be putted in latin "A" group.

Wed, Jul 17, 7:32 PM · Dolphin
meven added a comment to D22183: Add click to play/play feature on previews for audio/video.

Hmm, the triangle looks kinda janky with a 2x scale factor:

It's worse with a factional scale factor (1.5 here):

Wed, Jul 17, 6:58 PM · Dolphin
ngraham accepted D22144: Add kio recentlyused:/ to access KactivitytStats data.

LGTM!

Wed, Jul 17, 5:56 PM · Frameworks, Dolphin
meven updated the diff for D22144: Add kio recentlyused:/ to access KactivitytStats data.

Fix typos, missing space...

Wed, Jul 17, 5:51 PM · Frameworks, Dolphin
pdabrowski requested review of D22512: [Dolphin] Hide tooltip instantly on key press.
Wed, Jul 17, 3:26 PM · Dolphin
ngraham added a comment to D22183: Add click to play/play feature on previews for audio/video.

Hmm, the triangle looks kinda janky with a 2x scale factor:

Wed, Jul 17, 3:24 PM · Dolphin
ngraham added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.

Indeed, it was a database issue. Looks like that's on kactivitymanagerd, not you!

Wed, Jul 17, 3:13 PM · Frameworks, Dolphin
AndreyYashkin updated the diff for D22303: Fix name grouping feature for cyrillic names.

Fixed brackets and spaces style

Wed, Jul 17, 11:39 AM · Dolphin
meven added a comment to D22183: Add click to play/play feature on previews for audio/video.

I have update the code to reflect an issue with the positioning in Hdpi cases.

Wed, Jul 17, 9:27 AM · Dolphin
meven updated the diff for D22183: Add click to play/play feature on previews for audio/video.

Fix play arrow position when devicePixelRatio > 1

Wed, Jul 17, 9:18 AM · Dolphin
meven added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.

So interestingly enough, accessing recentlyused:/ in Dolphin's URL navigator works great, but doing recentlyused:/?limit=100 causes it to crash on an assert:

$ dolphin
org.kde.kactivities.lib.core: Setting the title:  ""
ASSERT: "!name.isEmpty()" in file /home/nate/kde/src/kio/src/core/kcoredirlister.cpp, line 1209
Aborted (core dumped)

Here's the full backtrace:

(gdb) bt
#0  0x00007ffff7972755 in raise () from /usr/lib/libc.so.6
#1  0x00007ffff795d851 in abort () from /usr/lib/libc.so.6
#2  0x00007ffff4ef08b6 in QMessageLogger::fatal(char const*, ...) const ()
   from /usr/lib/libQt5Core.so.5
#3  0x00007ffff4eefce2 in qt_assert(char const*, char const*, int) ()
   from /usr/lib/libQt5Core.so.5
#4  0x00007ffff70fff73 in KCoreDirListerCache::slotEntries (
    this=0x7ffff71c2c80 <(anonymous namespace)::Q_QGS_kDirListerCache::innerFunction()::holder>, job=0x555555d5f300, entries=...)
    at /home/nate/kde/src/kio/src/core/kcoredirlister.cpp:1209
#5  0x00007ffff711ee53 in QtPrivate::FunctorCall<QtPrivate::IndexesList<0, 1>, QtPrivate::List<KIO::Job*, QList<KIO::UDSEntry> const&>, void, void (KCoreDirListerCache::*)(KIO::Job*, QList<KIO::UDSEntry> const&)>::call (f=
    (void (KCoreDirListerCache::*)(KCoreDirListerCache * const, KIO::Job *, const QList<KIO::UDSEntry> &)) 0x7ffff70ff6cc <KCoreDirListerCache::slotEntries(KIO::Job*, QList<KIO::UDSEntry> const&)>, 
    o=0x7ffff71c2c80 <(anonymous namespace)::Q_QGS_kDirListerCache::innerFunction()::holder>, arg=0x7fffffffcd90) at /usr/include/qt/QtCore/qobjectdefs_impl.h:152
#6  0x00007ffff711d6c7 in QtPrivate::FunctionPointer<void (KCoreDirListerCache::*)(KIO::Job*, QList<KIO::UDSEntry> const&)>::call<QtPrivate::List<KIO::Job*, QList<KIO::UDSEntry> const&>, void> (f=
    (void (KCoreDirListerCache::*)(KCoreDirListerCache * const, KIO::Job *, const QList<KIO::UDSEntry> &)) 0x7ffff70ff6cc <KCoreDirListerCache::slotEntries(KIO::Job*, QList<KIO::UDSEntry> const&)>, 
    o=0x7ffff71c2c80 <(anonymous namespace)::Q_QGS_kDirListerCache::innerFunction()::holder>, arg=0x7fffffffcd90) at /usr/include/qt/QtCore/qobjectdefs_impl.h:185
#7  0x00007ffff711a752 in QtPrivate::QSlotObject<void (KCoreDirListerCache::*)(KIO::Job*, QList<KIO::UDSEntry> const&), QtPrivate::List<KIO::Job*, QList<KIO::UDSEntry> const&>, void>::impl (which=1, this_=0x555555d67c30, 
    r=0x7ffff71c2c80 <(anonymous namespace)::Q_QGS_kDirListerCache::innerFunction()::holder>, a=0x7fffffffcd90, ret=0x0) at /usr/include/qt/QtCore/qobjectdefs_impl.h:414
#8  0x00007ffff5124b70 in QMetaObject::activate(QObject*, int, int, void**) ()
   from /usr/lib/libQt5Core.so.5
#9  0x00007ffff70a6670 in KIO::ListJob::entries (this=0x555555d5f300, 
    _t1=0x555555d5f300, _t2=...)
    at /home/nate/kde/build/kio/src/core/KF5KIOCore_autogen/include/moc_listjob.cpp:237
#10 0x00007ffff70a520d in KIO::ListJobPrivate::slotListEntries (this=0x555555b42750, 
    list=...) at /home/nate/kde/src/kio/src/core/listjob.cpp:154
#11 0x00007ffff70a5d6a in KIO::ListJobPrivate::<lambda(const UDSEntryList&)>::operator()(const KIO::UDSEntryList &) const (__closure=0x555555d6de80, list=...)
    at /home/nate/kde/src/kio/src/core/listjob.cpp:288
#12 0x00007ffff70a72ca in QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<const QList<KIO::UDSEntry>&>, void, KIO::ListJobPrivate::start(KIO::Slave*)::<lambda(const UDSEntryList&)> >::call(KIO::ListJobPrivate::<lambda(const UDSEntryList&)> &, void **)
    (f=..., arg=0x7fffffffd090) at /usr/include/qt/QtCore/qobjectdefs_impl.h:146
#13 0x00007ffff70a714f in QtPrivate::Functor<KIO::ListJobPrivate::start(KIO::Slave*)::<lambda(const UDSEntryList&)>, 1>::call<QtPrivate::List<QList<KIO::UDSEntry> const&>, void>(KIO::ListJobPrivate::<lambda(const UDSEntryList&)> &, void *, void **) (f=..., 
    arg=0x7fffffffd090) at /usr/include/qt/QtCore/qobjectdefs_impl.h:256
Wed, Jul 17, 9:01 AM · Frameworks, Dolphin

Tue, Jul 16

ngraham added a comment to D22444: Add Reset Zoom Level action inside View menu.

Ah, looks like Dolphin conditionally adds the zoom actions to the main menu in dolphinmainwindow.cpp (lines 984-988). That's where you should add the new action. Then I guess you don't need to touch the rc files.

Tue, Jul 16, 5:36 PM · Documentation, Dolphin
ngraham added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.

So interestingly enough, accessing recentlyused:/ in Dolphin's URL navigator works great, but doing recentlyused:/?limit=100 causes it to crash on an assert:

Tue, Jul 16, 3:29 PM · Frameworks, Dolphin
ngraham added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.

Aha, that was the fix that made it work for me! Thanks a bunch. I will conduct a more thorough review soon.

Tue, Jul 16, 3:24 PM · Frameworks, Dolphin
meven added a comment to D22144: Add kio recentlyused:/ to access KactivitytStats data.

@ngraham I just fixed an issue in the recentlyused.json file, this should work much easier.

Tue, Jul 16, 2:15 PM · Frameworks, Dolphin
meven updated the diff for D22144: Add kio recentlyused:/ to access KactivitytStats data.

Fix json file

Tue, Jul 16, 2:13 PM · Frameworks, Dolphin
ngraham accepted D22183: Add click to play/play feature on previews for audio/video.

Thanks!

Tue, Jul 16, 1:04 PM · Dolphin
aspotashev closed D22466: servicemenuinstaller: Run installation scripts with cwd in their parent directories.
Tue, Jul 16, 12:06 PM · Dolphin
aspotashev added a comment to D22466: servicemenuinstaller: Run installation scripts with cwd in their parent directories.

Going to push to Applications/19.08

Tue, Jul 16, 12:04 PM · Dolphin
AndreyYashkin added a comment to D22386: Fix an issue with a new tab focus.

It does not look correct either, the problem is that the focus on location bar is delayed and setActive(false) isn't applied, this is workaround. But we have problems on that before, exactly that part with focusIn on location bar. You should correct there but it can break something other.

Tue, Jul 16, 9:33 AM · Dolphin