Improve variable naming
Uploaded (final?) diff with version using duplicated hideToolTip()/hideToolTipInstantly() slots.
Uploaded diff with version using QOverload.
Use white to black gradient unconditionally
+1, and let's use this style unconditionally. The lighting model itself doesn't change with the color scheme (only the colors themselves). So if there's going ot be a gradient like this, the top part of it should always have the lighter color.
Hey man I'm still working on it, almost done, sorry it's been over a month.
Almost good to go. The plan is to wrap it up this weekend so we can get it
reviewed and merged before the next kde applications release
Friendly ping! :)
updated wrt new comments. @dfaure please take another look! 👀
I think this was solved with bugfix to Bug Nr 335169 with commit 87d8ab4371149c84794f4e93d1f590f7bac5f327
I am sorry. I was so happy with this simple solution that forgot about one impornat aspect which is different from from language to language. If in a German dictionary 'O' and 'Ö' would be in the same group, in Russian 'Е' and 'Ё' or 'И' and 'Й' can never be together like new pacth does. Probably, it is applicable to korean, but in doesen't solve problem for all languages.
I used @hein idea to apply normalization which is implemented it unicode. Now it seems to be the final solution without working with particular writing system individually.
With the latest patch, I have reduced the arrow size and used a gradient to fill it to avoid low contrast with the video :
Add a border around the play arrow, tweak colors
Draw a polygone arrow with gradient
Codying style, use constants, try to fix fractionnal scaling hdpi issue
FYI: I gave this patch a spin with Korean and the grouping is not quite working the right way.
Wed, Jul 17
Thanks for the patch! The fix looks correct, but I have suggestions for the coding style.
I found it in the bug report: firstname.lastname@example.org
Sorry, I missed this one. I'd say let's postpone to 19.12...
Fix typos, missing space...
Hmm, the triangle looks kinda janky with a 2x scale factor:
Indeed, it was a database issue. Looks like that's on kactivitymanagerd, not you!
Fixed brackets and spaces style
I have update the code to reflect an issue with the positioning in Hdpi cases.
Fix play arrow position when devicePixelRatio > 1
Tue, Jul 16
Ah, looks like Dolphin conditionally adds the zoom actions to the main menu in dolphinmainwindow.cpp (lines 984-988). That's where you should add the new action. Then I guess you don't need to touch the rc files.
So interestingly enough, accessing recentlyused:/ in Dolphin's URL navigator works great, but doing recentlyused:/?limit=100 causes it to crash on an assert:
Aha, that was the fix that made it work for me! Thanks a bunch. I will conduct a more thorough review soon.
@ngraham I just fixed an issue in the recentlyused.json file, this should work much easier.
Fix json file
Going to push to Applications/19.08