DolphinProject
ActivePublic

Recent Activity

Today

nicolasfella planned changes to D7700: Show list of tags in PlacesView.
Sun, Sep 24, 10:05 AM · Dolphin

Yesterday

ngraham added a comment to D7700: Show list of tags in PlacesView.

I've submitted a patch to Breeze that resolves the usability issues with having multiple adjacent DockWidget panels: https://phabricator.kde.org/D7957

Sat, Sep 23, 7:20 PM · Dolphin
ngraham added a comment to D7700: Show list of tags in PlacesView.

Seems like a simple solution is to always show the title. That way, it wouldn't scroll away and you would still see it when locked. We would have to remove the redundant title from the Places panel with this, but that's simple enough.

Sat, Sep 23, 4:54 PM · Dolphin
markg added a comment to D7700: Show list of tags in PlacesView.

The title is only visible when the panels are unlocked. But in fact, the problem goes away when panels are unlocked; it's only a problem when locked. I'm working on a patch that improves this when panels are locked. Either way, we should continue that discussion in https://bugs.kde.org/show_bug.cgi?id=384999.

Sat, Sep 23, 4:45 PM · Dolphin
ngraham added a comment to D7700: Show list of tags in PlacesView.

The title is only visible when the panels are unlocked. But in fact, the problem goes away when panels are unlocked; it's only a problem when locked. I'm working on a patch that improves this when panels are locked. Either way, we should continue that discussion in https://bugs.kde.org/show_bug.cgi?id=384999.

Sat, Sep 23, 4:33 PM · Dolphin
cfeck added a comment to D7700: Show list of tags in PlacesView.

Ideally, the title does not scroll away at all.

Sat, Sep 23, 4:33 PM · Dolphin
markg added a comment to D7700: Show list of tags in PlacesView.

If we can make it a separate panel and overcome some of the disadvantages of having multiple panels. I'm fine with it. That means:

  1. Make the Tags panel visible by default
  2. Include a visible separator between panels (https://bugs.kde.org/show_bug.cgi?id=384999)

    I can work on https://bugs.kde.org/show_bug.cgi?id=384999.
Sat, Sep 23, 4:30 PM · Dolphin
markg added a comment to D7700: Show list of tags in PlacesView.

Again, same with recentdocuments, if stuff like this is added by default, it needs to work just fine in the normal usecases, otherwise it will cause bug reports which will in term cause the tags part to be disabled by default. Yes, chicken and egg problem plays here as well.

I'm working on improving the tags ioslave. D7855 was a first step on this.

Sat, Sep 23, 4:27 PM · Dolphin
ngraham added a comment to D7700: Show list of tags in PlacesView.

If we can make it a separate panel and overcome some of the disadvantages of having multiple panels. I'm fine with it. That means:

  1. Make the Tags panel visible by default
  2. Include a visible separator between panels (https://bugs.kde.org/show_bug.cgi?id=384999)
Sat, Sep 23, 3:48 PM · Dolphin
nicolasfella added a comment to D7700: Show list of tags in PlacesView.

I would be fine with moving it to a separate panel. If we do that, the PlacesPanel, the TagsPanel and a (hypothetical, but I saw people voting for it) BookmarksPanel would share a lot of code. Basically it would be the same View and Controller with different Models. I would suggest to get rid of that redundancy by sharing the View and Controller.

Sat, Sep 23, 3:22 PM · Dolphin
markg added a comment to D7700: Show list of tags in PlacesView.

Just curious, i have some files with tags (just added them). Baloo is running, but tags:/ is empty...
System monitor shows a baloo_file running at 100% cpu...

Sat, Sep 23, 3:10 PM · Dolphin
markg added a comment to D7700: Show list of tags in PlacesView.

If we make a new panel, we incur the following disadvantages:

  1. Lots of extra work, increasing the chance that it won't get done. We already have working code to add it to the Places panel.
  2. Assuming we make a new Tags panel, if we don't make it visible by default, almost nobody will ever see it, negating the purpose of adding the feature and keeping the overall Tags feature very un-discoverable.
  3. If we *do* make the new Tags panel visible by default, it will compete for vertical space currently used by the Places and Folders panels, and people will probably close it if it's visible by default, and not open it in the first place if it's not.

    I know that technically Tags aren't places, but the advantage of putting this in Places is that people will actually see it and use it. If we put it somewhere else, especially in a not-visible-by-default panel, I worry that the work will be essentially wasted.
Sat, Sep 23, 2:55 PM · Dolphin
markg added inline comments to D7700: Show list of tags in PlacesView.
Sat, Sep 23, 2:42 PM · Dolphin
ngraham added a comment to D7700: Show list of tags in PlacesView.

If we make a new panel, we incur the following disadvantages:

Sat, Sep 23, 2:40 PM · Dolphin
markg added a comment to D7700: Show list of tags in PlacesView.

Sorry for acting like a "protect the places panel" guy again.. but yeah, again :)
Please make a Panel for tags, not slapping it into the places panel. The macOS finder example was shown, that exact result can be achieved by putting it into the places panel, but also by putting it in it's own panel!
Making it's own panel for it is much cleaner and maintainable.

Sat, Sep 23, 2:30 PM · Dolphin
ngraham accepted D7700: Show list of tags in PlacesView.

FWIW, I've been testing this and it works really well. Nice feature.

Sat, Sep 23, 2:05 PM · Dolphin
markg added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

It seems odd to have all of these special KIO URLs that we don't actually want to use because they're rough and underdeveloped. They're rough and underdeveloped because they're hidden by default, so nobody sees them, and nobody files bugs or submits patches for them. But I do see your point.

That said, the advantage to adding this as a Places item is that it shows up in file open/save dialogs for free, which is where it's most useful. If we make this into a whole new panel, we'll have to do a bunch of otherwise unnecessary special work to get it into open/save dialogs. I don't see the advantage.

If the objection is that the content isn't useful (why does it show URLs?), then I can fix that too, but only if by doing so, folks will be amenable to adding a "Recent Documents" entry by default. It really is useful to have recent documents aggregated somewhere.

Sat, Sep 23, 12:06 PM · Frameworks, Dolphin
gregormi added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

That said, the advantage to adding this as a Places item is that it shows up in file open/save dialogs for free, which is where it's most useful.

Sat, Sep 23, 10:43 AM · Frameworks, Dolphin
ngraham added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

It seems odd to have all of these special KIO URLs that we don't actually want to use because they're rough and underdeveloped. They're rough and underdeveloped because they're hidden by default, so nobody sees them, and nobody files bugs or submits patches for them. But I do see your point.

Sat, Sep 23, 2:33 AM · Frameworks, Dolphin

Fri, Sep 22

markg added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

Yeah I also find weird to see weblinks in there. Maybe if we call it "History" would be a bit better (and it would also match the History tab in Kickoff).

Fri, Sep 22, 9:33 PM · Frameworks, Dolphin
elvisangelaccio added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

Yeah I also find weird to see weblinks in there. Maybe if we call it "History" would be a bit better (and it would also match the History tab in Kickoff).

Fri, Sep 22, 9:28 PM · Frameworks, Dolphin
markg added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

I don't think this is "semi-useful". " A Recent Documents feature in the file manager and open/save dialogs is IMHO really important, especially for lesst-technical users who use features like this on other platforms expensively instead of making extensive use of folder hierarchies. "The user can add it" is a problematic response since 99.9% of users don't know this exists, and therefore don't know that this functionality is available in the first place (and if they did, they would find it challenging to add).

The file managers and open/save dialogs in macOS and GNOME both have some kind of "recent stuff" feature shown by default, and it's really nice. And ad evidenced by the but report and the fact that people have voted for it, this is a desirable feature to some of our users.

Fri, Sep 22, 9:24 PM · Frameworks, Dolphin
ngraham added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

I don't think this is "semi-useful". " A Recent Documents feature in the file manager and open/save dialogs is IMHO really important, especially for lesst-technical users who use features like this on other platforms expensively instead of making extensive use of folder hierarchies. "The user can add it" is a problematic response since 99.9% of users don't know this exists, and therefore don't know that this functionality is available in the first place (and if they did, they would find it challenging to add).

Fri, Sep 22, 9:00 PM · Frameworks, Dolphin
markg added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

You could continue and add about a dozen more "semi-useful" protocol links (ftp, settings, programs, bluetooth, and much more) ;) .
I don't think that's the route for the places panel to go. Not by default that is.
If the user wants it, it can be added just like any shortcut can be added in the places thingy. By default it should stay rather clean. recentdocuments is (in my opinion) not one that should be there by default. Also, for me personally it seems rather weird as recently visited url's are also in the recent documents.... And files I've accessed on the console don't appear in it at all (understandable though).

Fri, Sep 22, 8:54 PM · Frameworks, Dolphin
ngraham added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

Anybody object?

Fri, Sep 22, 6:18 PM · Frameworks, Dolphin
ngraham closed D7763: Add Bitrate to Dolphin's Additional Information.
Fri, Sep 22, 4:56 AM · Dolphin
ngraham updated the diff for D7763: Add Bitrate to Dolphin's Additional Information.

Updating diff to try to get it to apply with arc (will use arc for future revisions)

Fri, Sep 22, 4:53 AM · Dolphin

Thu, Sep 21

ngraham added a comment to D7914: Select and scroll to previous folder when going Up.

Yeah. I don't have a Reviewboard account, and it seems a bit silly to create one seeing as how it's going away soon. Anyone wanna nuke it?

Thu, Sep 21, 9:36 PM · Dolphin
elvisangelaccio added a comment to D7914: Select and scroll to previous folder when going Up.
Thu, Sep 21, 9:28 PM · Dolphin
ngraham added a comment to D7700: Show list of tags in PlacesView.

@emmanuelp Ping! It would be great to get your blessing so we can land this.

Thu, Sep 21, 3:34 PM · Dolphin
ngraham abandoned D7914: Select and scroll to previous folder when going Up.

Fair enough. Thanks for merging the other patch! Abandoning this one.

Thu, Sep 21, 3:05 PM · Dolphin
emmanuelp added a comment to D7914: Select and scroll to previous folder when going Up.

A better fix is https://git.reviewboard.kde.org/r/123253/

Thu, Sep 21, 1:35 PM · Dolphin
ngraham updated the summary of D7914: Select and scroll to previous folder when going Up.
Thu, Sep 21, 1:17 PM · Dolphin
ngraham created D7914: Select and scroll to previous folder when going Up.
Thu, Sep 21, 1:16 PM · Dolphin

Wed, Sep 20

rkflx added a comment to D7763: Add Bitrate to Dolphin's Additional Information.

Diff 19425 and Diff 19660 are identical (save for a whitespace change). Maybe the wrong patch was uploaded?

Wed, Sep 20, 7:14 AM · Dolphin
alexeymin added a comment to D7763: Add Bitrate to Dolphin's Additional Information.

Nnnope, patch fails to apply for me, on current dolphin master. 😆 https://paste.kde.org/ppx1r8xxl

Wed, Sep 20, 5:49 AM · Dolphin
alexeymin added a comment to D7763: Add Bitrate to Dolphin's Additional Information.

I can test this a bit later today to verify.

Wed, Sep 20, 3:14 AM · Dolphin

Tue, Sep 19

aacid accepted D7763: Add Bitrate to Dolphin's Additional Information.
Tue, Sep 19, 10:10 PM · Dolphin
aacid resigned from D7763: Add Bitrate to Dolphin's Additional Information.

I don't have time to test now, but i understand you rebased it so if it's good it's good :)

Tue, Sep 19, 10:09 PM · Dolphin
mwolff added a comment to T7040: Drop KFilePlacesModel fork.

I think the grouping should be moved upstream into the model, too and then be used for file open dialogs to make that visually more similar to what dolphin shows.

Tue, Sep 19, 5:11 PM · Frameworks, Dolphin
elvisangelaccio created T7040: Drop KFilePlacesModel fork.
Tue, Sep 19, 5:05 PM · Frameworks, Dolphin
ngraham updated the diff for D7763: Add Bitrate to Dolphin's Additional Information.

@aacid, does it apply now for you?

Tue, Sep 19, 4:29 AM · Dolphin

Mon, Sep 18

elvisangelaccio added a comment to D6312: Keep renamed file(s) in view.

@elvisangelaccio: So I was thinking of using KIO::FileUndoManager::undoJobFinished but it unfortunately provides no details as to what job was undone.
A possible option would be to keep the last job recorded so we have the name that the undo-ed item will have after reverting, but this is just hacky and doesn't support more than 1 action. I think best would be if job information was passed from KIO::FileUndoManager and then Dolphin could leverage it. I also tried to use selectionManager but to no avail.

Mon, Sep 18, 9:30 PM · Dolphin
emateli added a comment to D6312: Keep renamed file(s) in view.

@elvisangelaccio: So I was thinking of using KIO::FileUndoManager::undoJobFinished but it unfortunately provides no details as to what job was undone.
A possible option would be to keep the last job recorded so we have the name that the undo-ed item will have after reverting, but this is just hacky and doesn't support more than 1 action. I think best would be if job information was passed from KIO::FileUndoManager and then Dolphin could leverage it. I also tried to leverage selectionManager but to no avail.

Mon, Sep 18, 7:42 PM · Dolphin
akrutzler added a watcher for Dolphin: akrutzler.
Mon, Sep 18, 11:36 AM
anthonyfieroni added a comment to D7700: Show list of tags in PlacesView.

@emmanuelp should accept it.

Mon, Sep 18, 4:03 AM · Dolphin

Sun, Sep 17

ngraham added a comment to D7700: Show list of tags in PlacesView.

Looks good to me. @anthonyfieroni?

Sun, Sep 17, 11:14 PM · Dolphin
nicolasfella added a comment to D7700: Show list of tags in PlacesView.

Any further objections/issues/comments?

Sun, Sep 17, 7:52 PM · Dolphin
martonmiklos added a comment to D7847: Fix bug 158264 - Terminal panel (konsole part) blocks the umount of removable media.

I'm not sure I agree with this patch.
A standard behavior in other filemanagers when umounting a device is to redirect to the view from the device URL to the home URL.
So imho this patch is using the wrong approach: instead of the mainwindow telling the terminal panel to go to the home, it should be the mainwindow the one that changes its URL to the home.

This way:

  1. We get an usable DolphinView after unmounting the device (matching the behavior of e.g. Nautilus)
  2. We don't need the goHome() method in TerminalPanel, it would be automatic.
Sun, Sep 17, 6:17 PM · Dolphin
elvisangelaccio added a comment to D7847: Fix bug 158264 - Terminal panel (konsole part) blocks the umount of removable media.

I'm not sure I agree with this patch.
A standard behavior in other filemanagers when umounting a device is to redirect to the view from the device URL to the home URL.
So imho this patch is using the wrong approach: instead of the mainwindow telling the terminal panel to go to the home, it should be the mainwindow the one that changes its URL to the home.

Sun, Sep 17, 5:20 PM · Dolphin