DolphinProject
ActivePublic

Recent Activity

Today

intika added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).

Thanks for this patch :) was patching it on my custom build... now regarding "drive-by download" i think it's just an education problem, user who clicks everywhere will get in trouble way before stumbling across such an attack... browser should by default ask before downloading anything but at least this is an available setting on most browser; now regarding cache (because browser tend to start downloading files even before they are saved) those directories are not scanned with baloo... any way at the end of the day all those issue should not be fixed in dolphin but on their side browser/file-indexer/etc.

Tue, Feb 19, 8:18 AM · Dolphin
broulik added a comment to D18883: Add PDF thumbnailer.

Perhaps but it's only recently become an issue since kioslaves now support KCrash. Previously such thumbnailer crashes just went unnoticed.

Tue, Feb 19, 8:16 AM · Frameworks, Dolphin

Yesterday

ngraham added a comment to D19083: Fix crash during shutdown.

Looks good to me now!

Mon, Feb 18, 7:24 PM · Dolphin
hallas added a comment to D19083: Fix crash during shutdown.

LGTM now.
Please push to the Applications/18.12 branch.

I have cherry-picked this commit to the Applications/18.12 branch here D19112 - I don't know if that is the correct workflow?

No need to create a separate revision. Here's the documentation for landing a patch created against master on a different branch instead: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

Mon, Feb 18, 7:23 PM · Dolphin
hallas abandoned D19112: Fix crash during shutdown.

No need for a separate diff, the fix is in D19083

Mon, Feb 18, 7:22 PM · Dolphin
astippich added a comment to D19105: Use new display string function from KFileMetaData.

Thanks! Who should I ask for a dependency rebuild? sysadmin?
If you don't mind, please also have a look at D19106, which does the same for baloo-widgets. I'd like to land them at the same time for consistency.

Mon, Feb 18, 6:38 PM · Dolphin
bruns added a comment to D18883: Add PDF thumbnailer.

However, you will get a Dr Konqi each time it encounters that file as it will try to generate a thumbnail for it every time you open the folder.

Mon, Feb 18, 4:21 PM · Frameworks, Dolphin
ngraham added a comment to D19083: Fix crash during shutdown.

LGTM now.
Please push to the Applications/18.12 branch.

I have cherry-picked this commit to the Applications/18.12 branch here D19112 - I don't know if that is the correct workflow?

Mon, Feb 18, 2:46 PM · Dolphin
broulik added a comment to D18883: Add PDF thumbnailer.

However, you will get a Dr Konqi each time it encounters that file as it will try to generate a thumbnail for it every time you open the folder.

Mon, Feb 18, 2:14 PM · Frameworks, Dolphin
hallas added a comment to D19083: Fix crash during shutdown.

LGTM now.
Please push to the Applications/18.12 branch.

Mon, Feb 18, 8:03 AM · Dolphin
hallas requested review of D19112: Fix crash during shutdown.
Mon, Feb 18, 8:02 AM · Dolphin
hallas closed D19083: Fix crash during shutdown.
Mon, Feb 18, 7:58 AM · Dolphin

Sun, Feb 17

kossebau added a comment to D18611: [appimage thumbnailer] Rely on imported cmake target libappimage.

Created https://github.com/AppImage/libappimage/pull/71 as one approach to get this solved on libappimage side.

Sun, Feb 17, 11:41 PM · Frameworks, Dolphin
aacid added a comment to D18769: Fix context for QDateTime::toString() translations.

Code looks good to me, do you want me to actually test it or are you confident enough that it works?

Sun, Feb 17, 10:38 PM · Dolphin
ngraham closed D18968: Word-wrap KMessageWidget text.
Sun, Feb 17, 9:07 PM · Dolphin
elvisangelaccio accepted D19105: Use new display string function from KFileMetaData.

The Applications 19.04 dependency freeze is on March 14th, while frameworks 5.56 gets released on March 9th. I don't see a problem if you want to push this now (apart from the KDE CI which will probably need a rebuild of the Dependency Build job).

Sun, Feb 17, 9:04 PM · Dolphin
elvisangelaccio updated the diff for D18769: Fix context for QDateTime::toString() translations.

Improved warnings

Sun, Feb 17, 8:47 PM · Dolphin
elvisangelaccio accepted D18968: Word-wrap KMessageWidget text.
Sun, Feb 17, 8:27 PM · Dolphin
astippich added a comment to D19105: Use new display string function from KFileMetaData.

This can of course only be merged when it is deemed okay to rely on KF 5.56

Sun, Feb 17, 8:10 PM · Dolphin
astippich requested review of D19105: Use new display string function from KFileMetaData.
Sun, Feb 17, 8:08 PM · Dolphin
ngraham added a comment to D18968: Word-wrap KMessageWidget text.

Yep, that works great. Did it in D19103: Middle-elide very long filenames in error strings.

Sun, Feb 17, 7:39 PM · Dolphin
aacid added inline comments to D18769: Fix context for QDateTime::toString() translations.
Sun, Feb 17, 6:01 PM · Dolphin
dfaure added a comment to D18883: Add PDF thumbnailer.

kio_thumbnail is a separate process (like all kioslaves) so a crash doesn't bring down the user-visible application.

Sun, Feb 17, 3:32 PM · Frameworks, Dolphin
elvisangelaccio updated the diff for D18769: Fix context for QDateTime::toString() translations.
  • Use KLocalizedString
Sun, Feb 17, 12:07 PM · Dolphin
elvisangelaccio accepted D19083: Fix crash during shutdown.

LGTM now.
Please push to the Applications/18.12 branch.

Sun, Feb 17, 11:21 AM · Dolphin
elvisangelaccio added a comment to D18769: Fix context for QDateTime::toString() translations.

I didn't realize you moved the text out of the i18n call.

If you do that gettext won't extract it and thus it'll be untranslatable.

I see that you did that so you can reuse it untranslated later.

Maybe this would work (haven't tried it)?

KLocalizedString s = ki18nc(context, text);
const QString translatedFormat = s.toString();
if (translatedFormat.count(QLatin1Char('\'')) == 2) { /* good */ }
else { qCWarning();      newGroupValue = s.toString({"en"}); }

i think that would mean "no" translation in the else since it is asking for an en translation.

Sun, Feb 17, 10:45 AM · Dolphin
elvisangelaccio added a comment to D18945: New tab should be placed after the current tab.

Please use FEATURE: instead of BUG: in the commit message.

Do you have commit access?

Sorry, I didn't see your comment to after I had landed the change :) Hope it is ok anyway.

Sun, Feb 17, 10:38 AM · Dolphin
elvisangelaccio added a comment to D18968: Word-wrap KMessageWidget text.

That could also work, yes. @ngraham wanna give it a try?

Sun, Feb 17, 10:34 AM · Dolphin

Sat, Feb 16

aacid added a comment to D18769: Fix context for QDateTime::toString() translations.

I didn't realize you moved the text out of the i18n call.

Sat, Feb 16, 10:38 PM · Dolphin
hallas added a comment to D18945: New tab should be placed after the current tab.

Please use FEATURE: instead of BUG: in the commit message.

Do you have commit access?

Sat, Feb 16, 6:30 PM · Dolphin
hallas added inline comments to D19083: Fix crash during shutdown.
Sat, Feb 16, 6:20 PM · Dolphin
hallas updated the diff for D19083: Fix crash during shutdown.

Add default constructor to AccessibleIdWrapper

Sat, Feb 16, 6:20 PM · Dolphin
cfeck added a comment to D18968: Word-wrap KMessageWidget text.

Dolphin could simply call KStringHandler::*squeeze(), maybe only on the actual filepath, if squeezing is preferred to wrapping.

Sat, Feb 16, 5:47 PM · Dolphin
elvisangelaccio added a comment to D19083: Fix crash during shutdown.

Fixes the crash for me, thanks!

Sat, Feb 16, 4:25 PM · Dolphin
hallas closed D18945: New tab should be placed after the current tab.
Sat, Feb 16, 3:51 PM · Dolphin
hallas requested review of D19083: Fix crash during shutdown.
Sat, Feb 16, 3:50 PM · Dolphin
elvisangelaccio accepted D18945: New tab should be placed after the current tab.

Please use FEATURE: instead of BUG: in the commit message.

Sat, Feb 16, 3:22 PM · Dolphin
elvisangelaccio closed D18040: Add option to choose which view to close.
Sat, Feb 16, 3:15 PM · Dolphin
elvisangelaccio accepted D18040: Add option to choose which view to close.

Looks good to me now, landing it.

Sat, Feb 16, 3:15 PM · Dolphin
elvisangelaccio added a comment to D18968: Word-wrap KMessageWidget text.

@cfeck What if we use a KSqueezedTextLabel in KMessageWidget instead? That would mostly fix also the 'aaaaaaaaaaaa' case without requiring new API in QLabel.

Sat, Feb 16, 2:37 PM · Dolphin
hallas added inline comments to D18945: New tab should be placed after the current tab.
Sat, Feb 16, 2:30 PM · Dolphin
hallas updated the diff for D18945: New tab should be placed after the current tab.

Change TabPlacement enum names.
Simplify the code that calculates the index of the new tab.

Sat, Feb 16, 2:30 PM · Dolphin
elvisangelaccio updated the diff for D18769: Fix context for QDateTime::toString() translations.
  • Added warnings
Sat, Feb 16, 2:13 PM · Dolphin
elvisangelaccio requested changes to D18945: New tab should be placed after the current tab.
Sat, Feb 16, 11:26 AM · Dolphin

Fri, Feb 15

aacid added a comment to D18883: Add PDF thumbnailer.

The code can't be much simpler than this, there's not much places it can go wrong, i guess the only other thing to mention is, poppler will crash with some bad data, so i don't know if this is on it's own process or not, but if it's not it may bring down whatever app uses it, though given the gs issues lately it's probably not worse?

Fri, Feb 15, 10:26 PM · Frameworks, Dolphin
rooty closed D19053: [kio-extras] Use "storage media" instead of "storages".
Fri, Feb 15, 9:16 PM · Frameworks, Dolphin
ngraham accepted D19053: [kio-extras] Use "storage media" instead of "storages".
Fri, Feb 15, 9:04 PM · Frameworks, Dolphin
rooty updated the diff for D19053: [kio-extras] Use "storage media" instead of "storages".

Fix my own error (ironic?)

Fri, Feb 15, 9:01 PM · Frameworks, Dolphin
rooty added a reviewer for D19053: [kio-extras] Use "storage media" instead of "storages": VDG.
Fri, Feb 15, 9:00 PM · Frameworks, Dolphin
rooty requested review of D19053: [kio-extras] Use "storage media" instead of "storages".
Fri, Feb 15, 8:59 PM · Frameworks, Dolphin