DolphinProject
ActivePublic

Recent Activity

Yesterday

ngraham added a comment to D12162: Add support for touch scrolling in Dolphin.

I'll be happy to do all the UI testing if you can do the code review!

Sun, Oct 14, 4:02 PM · Dolphin
feverfew added a comment to D15278: Close Dolphin if last tab closed.

Hmm, I don't know. If the tabbar is not visible, there is no "last tab". Why should the "close tab" action be enabled then?

Browsers are different because they always have the tabbar visible (even if there is only one tab).

I still think this should be addressed. Maybe we can change the text of the action from "Close Tab" to "Close Window" if there is only one tab ?

Sun, Oct 14, 1:10 PM · Dolphin
thsurrel closed D15929: Add a 'Properties' entry in the Places panel context menu.
Sun, Oct 14, 10:23 AM · Dolphin
elvisangelaccio accepted D15929: Add a 'Properties' entry in the Places panel context menu.
Sun, Oct 14, 10:17 AM · Dolphin
elvisangelaccio added a comment to D12162: Add support for touch scrolling in Dolphin.

I don't have a touch screen for actual testing, but I'll have a look asap anyway.

Sun, Oct 14, 10:13 AM · Dolphin
elvisangelaccio requested changes to D15980: Warn user before renaming the file/folder to start with a ' . '.
Sun, Oct 14, 10:10 AM · Dolphin
elvisangelaccio triaged T9858: PlacesItemModelTest needs working KDirWatch on the CI as Normal priority.
Sun, Oct 14, 8:27 AM · Dolphin

Sat, Oct 13

shubham updated the diff for D15980: Warn user before renaming the file/folder to start with a ' . '.

Made above requested changes by Elvis.

Sat, Oct 13, 12:18 PM · Dolphin
elvisangelaccio requested changes to D15980: Warn user before renaming the file/folder to start with a ' . '.
Sat, Oct 13, 10:27 AM · Dolphin
shubham added a comment to D15980: Warn user before renaming the file/folder to start with a ' . '.

@pino @elvisangelaccio are there any comments from you side?
If not, I will be landing this revison.

Sat, Oct 13, 6:35 AM · Dolphin

Fri, Oct 12

ngraham renamed T9226: Unify icon/folder views from Unifiy folder views to Unify icon/folder views.
Fri, Oct 12, 11:39 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma

Thu, Oct 11

thsurrel closed D15989: Disable unmount option for / or /home.
Thu, Oct 11, 9:34 PM · Dolphin
elvisangelaccio accepted D15989: Disable unmount option for / or /home.

Thanks!

Thu, Oct 11, 9:21 PM · Dolphin
thsurrel updated the diff for D15989: Disable unmount option for / or /home.

Fixes as per elvisangelaccio comments

Thu, Oct 11, 9:04 PM · Dolphin
elvisangelaccio requested changes to D15989: Disable unmount option for / or /home.
Thu, Oct 11, 8:17 PM · Dolphin
thsurrel updated the summary of D15989: Disable unmount option for / or /home.
Thu, Oct 11, 7:42 PM · Dolphin
ngraham added a comment to D15989: Disable unmount option for / or /home.

We just got a bug report for this: https://bugs.kde.org/show_bug.cgi?id=399659

Thu, Oct 11, 3:38 PM · Dolphin
svenmauch added a comment to D15278: Close Dolphin if last tab closed.

I still think this should be addressed. Maybe we can change the text of the action from "Close Tab" to "Close Window" if there is only one tab ?

Thu, Oct 11, 3:16 PM · Dolphin
thsurrel updated the diff for D15929: Add a 'Properties' entry in the Places panel context menu.

Rebase

Thu, Oct 11, 7:43 AM · Dolphin

Wed, Oct 10

thsurrel added a comment to D15278: Close Dolphin if last tab closed.

I have to say, I would love to see this behavior in Kate as well!

Wed, Oct 10, 9:25 PM · Dolphin
ngraham added a comment to D15278: Close Dolphin if last tab closed.

Maybe we can change the text of the action from "Close Tab" to "Close Window" if there is only one tab ?

Wed, Oct 10, 9:10 PM · Dolphin
thsurrel added a comment to D16115: Update hidden state correctly.

No problem

Wed, Oct 10, 8:57 PM · Dolphin
elvisangelaccio added a comment to D16115: Update hidden state correctly.

This is a bugfix, it should be pushed to the stable branch (Applications/18.08).

Wed, Oct 10, 8:56 PM · Dolphin
thsurrel closed D16115: Update hidden state correctly.
Wed, Oct 10, 8:49 PM · Dolphin
elvisangelaccio accepted D16115: Update hidden state correctly.

Thanks

Wed, Oct 10, 8:47 PM · Dolphin
thsurrel requested review of D16115: Update hidden state correctly.
Wed, Oct 10, 8:27 PM · Dolphin
elvisangelaccio added a comment to D15278: Close Dolphin if last tab closed.

Hmm, I don't know. If the tabbar is not visible, there is no "last tab". Why should the "close tab" action be enabled then?

Browsers are different because they always have the tabbar visible (even if there is only one tab).

Wed, Oct 10, 8:06 PM · Dolphin
broulik closed D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile.
Wed, Oct 10, 3:09 PM · Frameworks, Dolphin
broulik closed D15589: Add proper labels to Trash Emptied notification.
Wed, Oct 10, 2:26 PM · Dolphin
ngraham accepted D15589: Add proper labels to Trash Emptied notification.

All right, ship it! Let's improve the icon in https://bugs.kde.org/show_bug.cgi?id=399613

Wed, Oct 10, 2:25 PM · Dolphin
broulik updated the diff for D15589: Add proper labels to Trash Emptied notification.
  • Drop "Folder"
Wed, Oct 10, 2:10 PM · Dolphin
broulik abandoned D14770: Generate file thumbnails before folder thumbnails.
Wed, Oct 10, 2:04 PM · Dolphin
broulik closed D15741: Use correct MaximumSize.
Wed, Oct 10, 1:58 PM · Frameworks, Dolphin
broulik abandoned D15404: [KFileItemModelRolesUpdater] Avoid duplicate indexes to resolve.

Needs some more thorough investigation

Wed, Oct 10, 1:56 PM · Dolphin
svenmauch added a comment to D15278: Close Dolphin if last tab closed.

I tried some programs on different operating systems and observed that Strg + W generally closes the window if it's the last tab and even closes the window on some programs that don't support tabs to begin with. Konsole also does this so it wouldn't behave differently than every other KDE app.

Wed, Oct 10, 7:35 AM · Dolphin
abetts added a comment to D15278: Close Dolphin if last tab closed.

I am in favor of the patch. It helps understand that beyond the last tab there is no window to work with. This is sensible and other file managers do it. Seems pretty logical to me. I think we are mincing and dicing stuff that really doesn't happen. We can skip all those hypotheticals and go ahead with the patch.

Wed, Oct 10, 3:39 AM · Dolphin
ngraham added a reviewer for D15278: Close Dolphin if last tab closed: VDG.

If we don't want to do this, we should close the bug. If we don't want to do that, we should seriously evaluate whether or not to accept this patch.

Wed, Oct 10, 2:37 AM · Dolphin
shubham updated subscribers of D15980: Warn user before renaming the file/folder to start with a ' . '.
Wed, Oct 10, 1:55 AM · Dolphin
shubham added a comment to D15980: Warn user before renaming the file/folder to start with a ' . '.

Make sure all other reviewers have changed their statuses to "Accepted" before landing.

Wed, Oct 10, 1:54 AM · Dolphin

Tue, Oct 9

ngraham closed D16019: Added missing icons to panel places items.
Tue, Oct 9, 9:28 PM · Dolphin
ngraham closed D16050: Added missing QStringLiteral to Dolphin code.
Tue, Oct 9, 9:20 PM · Dolphin
ngraham closed D15609: Add "Create New" menu to "Control" button.
Tue, Oct 9, 9:12 PM · Dolphin
ngraham accepted D15980: Warn user before renaming the file/folder to start with a ' . '.

This now looks good to me in terms of both code, functionality, and presentation. Make sure all other reviewers have changed their statuses to "Accepted" before landing.

Tue, Oct 9, 8:58 PM · Dolphin
shubham updated the diff for D15980: Warn user before renaming the file/folder to start with a ' . '.

"Folder"

Tue, Oct 9, 4:45 PM · Dolphin
ngraham added a comment to D15980: Warn user before renaming the file/folder to start with a ' . '.

Thanks! One more thing: let's use "folder" instead of "directory" for the user-facing strings.

Tue, Oct 9, 4:43 PM · Dolphin
shubham retitled D15980: Warn user before renaming the file/folder to start with a ' . ' from Warn user before renaming the file/folder to start with a ' . ' to Warn user before renaming the file/directory to start with a ' . '.
Tue, Oct 9, 4:41 PM · Dolphin
shubham updated the diff for D15980: Warn user before renaming the file/folder to start with a ' . '.

Made above requested changes.

Tue, Oct 9, 4:40 PM · Dolphin
shubham added a comment to D15980: Warn user before renaming the file/folder to start with a ' . '.

@ngraham makes sense to me. Will submit those subsequent patches later.

Tue, Oct 9, 2:38 PM · Dolphin
ngraham added a comment to D15980: Warn user before renaming the file/folder to start with a ' . '.

Now that I think about it, we might want to tackle that in multiple patches:

Tue, Oct 9, 2:27 PM · Dolphin
broulik closed D15507: [MountPointObserverCache] Update mounts less frequently.
Tue, Oct 9, 11:37 AM · Dolphin