lbeltrame (Luca Beltrame)Administrator
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2015, 11:22 PM (153 w, 5 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

lbeltrame committed R105:ea7f39701c72: Merge remote-tracking branch 'origin/Plasma/5.12' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.12'
Mon, Jan 22, 6:32 AM

Yesterday

lbeltrame added inline comments to D9998: Actually quit threads nicely.
Sun, Jan 21, 10:51 AM · Plasma
lbeltrame committed R105:7a1ebd5dc8b2: Merge remote-tracking branch 'origin/Plasma/5.12' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.12'
Sun, Jan 21, 9:26 AM
lbeltrame added inline comments to D9998: Actually quit threads nicely.
Sun, Jan 21, 9:24 AM · Plasma

Sat, Jan 20

lbeltrame accepted D9959: baloosearch: Send summary to stderr.

LGTM.

Sat, Jan 20, 8:20 AM · Frameworks
lbeltrame accepted D9958: balooctl status: Produce parseable output.

Changes are trivial enough IMO. Perhaps wait one or two days to see if anyone objects, then you can land this.

Sat, Jan 20, 8:19 AM · Frameworks
lbeltrame added a reviewer for D9333: Make sure that old URLs do not appear duplicated in places model: Dolphin.
Sat, Jan 20, 8:09 AM
lbeltrame added a comment to D9985: Fix place item edit after creation.

+1, but someone else must approve.

Sat, Jan 20, 8:07 AM

Fri, Jan 19

lbeltrame added a reviewer for D9985: Fix place item edit after creation: Dolphin.
Fri, Jan 19, 6:03 PM
lbeltrame added a comment to D9347: Ignore baloo urls created from new KIO model.

I reverted this change in master: this doesn't solve all the problems (places aren't keeping edits now) but at least solves the crash, which is far more critical.

Fri, Jan 19, 12:32 PM
lbeltrame added a reverting commit for R318:9d3a019445d7: Ignore baloo urls created from new KIO model: R318:d55b0875ffac: Revert "Ignore baloo urls created from new KIO model".
Fri, Jan 19, 12:32 PM
lbeltrame committed R318:d55b0875ffac: Revert "Ignore baloo urls created from new KIO model" (authored by lbeltrame).
Revert "Ignore baloo urls created from new KIO model"
Fri, Jan 19, 12:32 PM
lbeltrame added a comment to D9347: Ignore baloo urls created from new KIO model.

Well, I didn't expect that master and Applications had differing behaviors... Anyway, is there a short-term solution short of undoing the merge (which is hard to do)?

Fri, Jan 19, 12:23 PM

Thu, Jan 18

lbeltrame added a comment to D9958: balooctl status: Produce parseable output.
Thu, Jan 18, 2:58 PM · Frameworks
lbeltrame added a comment to D9958: balooctl status: Produce parseable output.

+1. @broulik How does it look on your side wrt the QJsonDocument usage?

Thu, Jan 18, 1:35 PM · Frameworks
lbeltrame added a comment to D9958: balooctl status: Produce parseable output.

I'm not too fond of assembling JSON by hand, but I guess it was done to avoid dependencies for a tool that's supposed to be simple. I'll let others weigh in on this.
Did you test this change also with filenames with Unicode characters or non-Latin characters?

Thu, Jan 18, 11:34 AM · Frameworks
lbeltrame added a comment to D9958: balooctl status: Produce parseable output.

Examples of each output would be nice.

Thu, Jan 18, 10:17 AM · Frameworks
lbeltrame committed R318:1a6b3c0a2bab: Merge remote-tracking branch 'origin/Applications/17.12' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/17.12'
Thu, Jan 18, 8:11 AM
lbeltrame accepted D9712: balooctl status: translatable message.
Thu, Jan 18, 6:13 AM · Frameworks

Tue, Jan 16

lbeltrame added inline comments to D9712: balooctl status: translatable message.
Tue, Jan 16, 10:27 AM · Frameworks

Fri, Jan 12

lbeltrame committed R241:45fbe9d1cd7e: Fixup previous commit (authored by lbeltrame).
Fixup previous commit
Fri, Jan 12, 12:51 PM
lbeltrame committed R241:029da62886e0: Do not cache root password for the whole session (authored by lbeltrame).
Do not cache root password for the whole session
Fri, Jan 12, 12:41 PM

Tue, Jan 9

lbeltrame committed R733:6e1efd4d524b: Fixup new style invokeMethod() and fix email sending (authored by lbeltrame).
Fixup new style invokeMethod() and fix email sending
Tue, Jan 9, 8:53 PM
lbeltrame committed R733:3a07df62299a: Revert "Revert "Use new connect api"" (authored by lbeltrame).
Revert "Revert "Use new connect api""
Tue, Jan 9, 8:53 PM
lbeltrame added a reverting commit for R733:96e83e94eaa2: Revert "Use new connect api": R733:3a07df62299a: Revert "Revert "Use new connect api"".
Tue, Jan 9, 8:53 PM
lbeltrame committed R733:7e6e7e0d6e71: Revert "Use new connect api" (authored by lbeltrame).
Revert "Use new connect api"
Tue, Jan 9, 7:51 PM
lbeltrame added a reverting commit for R733:72c073488ec1: Use new connect api: R733:7e6e7e0d6e71: Revert "Use new connect api".
Tue, Jan 9, 7:51 PM
lbeltrame committed R733:96e83e94eaa2: Revert "Use new connect api" (authored by lbeltrame).
Revert "Use new connect api"
Tue, Jan 9, 7:19 PM
lbeltrame added a reverting commit for R733:94b979956b90: Use new connect api: R733:96e83e94eaa2: Revert "Use new connect api".
Tue, Jan 9, 7:19 PM

Sun, Dec 24

Restricted Application edited projects for D9495: Properly detect Gallium drivers with newer Mesa, added: KWin; removed Plasma.

I consider detecting for newer driver a feature.

Sun, Dec 24, 2:19 PM · Plasma

Dec 22 2017

lbeltrame committed R120:5398c98ffd88: Merge remote-tracking branch 'origin/Plasma/5.11' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.11'
Dec 22 2017, 2:52 PM
lbeltrame updated subscribers of D9476: Fix duplicate authentication.
Dec 22 2017, 10:59 AM · KDE PIM
lbeltrame added a project to D9476: Fix duplicate authentication: KDE PIM.
Dec 22 2017, 10:58 AM · KDE PIM

Dec 21 2017

lbeltrame added a comment to D9446: WIP: Allow to autogenerate and install categories file.

For those who wonder why this would be necessary, see https://mail.kde.org/pipermail/kde-frameworks-devel/2017-December/054139.html.

Dec 21 2017, 8:12 AM · Build System, Frameworks
lbeltrame added a reviewer for D9446: WIP: Allow to autogenerate and install categories file: fvogt.
Dec 21 2017, 8:07 AM · Build System, Frameworks

Dec 20 2017

lbeltrame committed R98:4757d48d7f97: Fixup install paths (authored by lbeltrame).
Fixup install paths
Dec 20 2017, 2:39 PM
lbeltrame committed R98:9fcbe3771211: Move the 3.0 directory to 3.18 to ensure builds will not fail (authored by lbeltrame).
Move the 3.0 directory to 3.18 to ensure builds will not fail
Dec 20 2017, 2:34 PM
lbeltrame committed R98:50c632cfa9b9: Revert "Revert "Remove gtk+-3 build dep, install versioned gtk.css dirs… (authored by lbeltrame).
Revert "Revert "Remove gtk+-3 build dep, install versioned gtk.css dirs…
Dec 20 2017, 2:34 PM
lbeltrame added a reverting commit for R98:89ebc0b7e167: Revert "Remove gtk+-3 build dep, install versioned gtk.css dirs…: R98:50c632cfa9b9: Revert "Revert "Remove gtk+-3 build dep, install versioned gtk.css dirs….
Dec 20 2017, 2:34 PM
lbeltrame added a reverting commit for R98:19ce244131cb: Reverse my previous revert, and eliminate the attempted installation of the…: R98:06c76141d7a5: Revert "Reverse my previous revert, and eliminate the attempted installation of….
Dec 20 2017, 2:34 PM
lbeltrame committed R98:06c76141d7a5: Revert "Reverse my previous revert, and eliminate the attempted installation of… (authored by lbeltrame).
Revert "Reverse my previous revert, and eliminate the attempted installation of…
Dec 20 2017, 2:34 PM

Nov 10 2017

lbeltrame accepted D8745: Import FindGLIB2 and FindPulseAudio from ECM.
Nov 10 2017, 9:40 PM
lbeltrame committed R345:c195e04252be: More fixes for changes in ECM (authored by lbeltrame).
More fixes for changes in ECM
Nov 10 2017, 5:56 AM

Nov 9 2017

lbeltrame committed R345:8f6a33567166: Fix linking with PulseAudio with newer ECM (authored by lbeltrame).
Fix linking with PulseAudio with newer ECM
Nov 9 2017, 8:39 AM
lbeltrame committed R119:5db70d0e6017: Fix build with extra-cmake-modules since commit… (authored by Johannes Hirte <johannes.hirte@datenkhaos.de>).
Fix build with extra-cmake-modules since commit…
Nov 9 2017, 6:45 AM

Nov 3 2017

lbeltrame committed R161:39aaa3359a01: Merge remote-tracking branch 'origin/Plasma/5.11' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.11'
Nov 3 2017, 10:32 PM

Oct 30 2017

lbeltrame added reviewers for D8546: Add Aztec code generator: Frameworks, svuorela.
Oct 30 2017, 9:39 AM · Frameworks

Oct 28 2017

lbeltrame added a comment to D8447: Add unit tests for Folder View.

It looks like it broke building with BUILD_TESTING=OFF:

Oct 28 2017, 7:23 AM · Plasma

Oct 21 2017

lbeltrame committed R857:b7af6a090312: Fix typo (authored by lbeltrame).
Fix typo
Oct 21 2017, 4:35 PM
lbeltrame committed R857:a09dccac7952: Actually change the repo (authored by lbeltrame).
Actually change the repo
Oct 21 2017, 4:34 PM
lbeltrame committed R857:23a316d45daa: Fix repository so that it doesn't load the Qt 5.10 beta (authored by lbeltrame).
Fix repository so that it doesn't load the Qt 5.10 beta
Oct 21 2017, 4:29 PM

Oct 19 2017

lbeltrame created T7227: kdelibs / kde-runtime: Add a way to avoid building translations / docs that are in conflict with the KF5 based applications.
Oct 19 2017, 3:32 PM · KDE Applications

Oct 13 2017

lbeltrame added a comment to T6561: Polkit support in KIO.

The commits have been reverted.

Oct 13 2017, 10:26 AM · Frameworks
lbeltrame added a reverting commit for R241:0c2a6811dc50: Add support for sharing file descriptor between file ioslave and it's KAuth…: R241:447b2e4a0e87: Revert "Add support for sharing file descriptor between file ioslave and it's….
Oct 13 2017, 10:10 AM
lbeltrame committed R241:447b2e4a0e87: Revert "Add support for sharing file descriptor between file ioslave and it's… (authored by lbeltrame).
Revert "Add support for sharing file descriptor between file ioslave and it's…
Oct 13 2017, 10:10 AM
lbeltrame committed R241:8645944653b1: Revert "Add kauth helper to file ioslave" (authored by lbeltrame).
Revert "Add kauth helper to file ioslave"
Oct 13 2017, 10:10 AM
lbeltrame committed R241:71c30040074b: Revert "Add ability to use the new kauth helper in file ioslave" (authored by lbeltrame).
Revert "Add ability to use the new kauth helper in file ioslave"
Oct 13 2017, 10:10 AM
lbeltrame added a reverting commit for R241:29a741982fe5: Add kauth helper to file ioslave: R241:8645944653b1: Revert "Add kauth helper to file ioslave".
Oct 13 2017, 10:10 AM
lbeltrame added a reverting commit for R241:c4726e843e42: Add ability to use the new kauth helper in file ioslave: R241:71c30040074b: Revert "Add ability to use the new kauth helper in file ioslave".
Oct 13 2017, 10:10 AM
lbeltrame updated subscribers of T6561: Polkit support in KIO.

The recent commit of some of the revisions caused breakage in KIO, possibly breaking BIC: when starting Dolphin I get.

Oct 13 2017, 9:33 AM · Frameworks

Sep 30 2017

lbeltrame accepted D8070: Fix build with Qt 5.10.

LGTM.

Sep 30 2017, 1:06 PM · Frameworks
lbeltrame accepted D8069: Fix build with Qt 5.10.

Trivial change, LGTM.

Sep 30 2017, 1:05 PM · Frameworks

Sep 27 2017

lbeltrame added a comment to D7305: Add FITS format support.

Doesn't build for me even with cftsio found and used (openSUSE Tumbleweed):

Sep 27 2017, 4:48 AM

Sep 21 2017

lbeltrame added a comment to D7929: [WIP] Add new Column View option to KDirOperator.

A screenshot before/after (or just after, since it is an addition) would be helpful in this case, since it is a visual change.

Sep 21 2017, 9:31 PM · Frameworks

Sep 18 2017

lbeltrame added a comment to D7862: Enhancement: Resource tomboynotes updates its content automatically.

@knauss Good point. I think it's not worth relicensing to GPL v3, not because it's a bad license, but due to the massive amount of historical code in KDE PIM. So, to prevent further headaches for distributions, -1 to the license change.

Sep 18 2017, 3:06 PM · KDE PIM
lbeltrame committed R296:af914577678b: Remove copy of the GPL (authored by lbeltrame).
Remove copy of the GPL
Sep 18 2017, 1:41 PM
lbeltrame committed R296:62b8e461f2e5: Relicense to LGPL2.1+ (part 2) (authored by lbeltrame).
Relicense to LGPL2.1+ (part 2)
Sep 18 2017, 1:41 PM
lbeltrame committed R296:db3bc8218141: Relicense some files to LGPL2.1+ (authored by lbeltrame).
Relicense some files to LGPL2.1+
Sep 18 2017, 1:41 PM
lbeltrame committed R165:a3783fd4aa33: Merge remote-tracking branch 'origin/Applications/17.08' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/17.08'
Sep 18 2017, 7:25 AM

Sep 8 2017

lbeltrame added a comment to D7736: Not-to-be-merged review of Python bindings generator.

A small number of reviews (this thing is huge). One question: would it be possible to have the bindings per-framework, rather than a single, long list? This is also what made PyKDE4 unwieldy. IOW, each Framework should ship their (optional) bindings.
We can put the tooling in ECM so that everything is in place for all the Frameworks. (This is how the current approach works):

Sep 8 2017, 2:29 PM · Build System, Frameworks

Sep 4 2017

lbeltrame added a comment to T6209: Add libDDCUtil to CI.

openSUSE package is being done. Progress tracked at https://build.opensuse.org/request/show/520615
Note that since it is a new package for the distribution, it will take a while (reviews) until it actually lands in the distro and then becomes part of the Docker image.

Sep 4 2017, 11:44 AM · build.kde.org

Aug 31 2017

lbeltrame committed R857:d9db386ea9ae: Add python3-devel for kdev-python (authored by lbeltrame).
Add python3-devel for kdev-python
Aug 31 2017, 2:01 PM
lbeltrame added reviewers for D7627: Make it possible to mark a folder explicitly as sender folder: dvratil, mlaurent.
Aug 31 2017, 12:58 PM · KDE PIM
lbeltrame committed R857:103bb653ec1a: Add required dependencies for KDevelop (authored by lbeltrame).
Add required dependencies for KDevelop
Aug 31 2017, 12:53 PM
lbeltrame committed R206:9a709251cf7c: Merge remote-tracking branch 'origin/Applications/17.08' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/17.08'
Aug 31 2017, 11:26 AM

Aug 13 2017

lbeltrame committed R871:4e53a9ea5aa0: Move LICENSE to the top level folder (authored by lbeltrame).
Move LICENSE to the top level folder
Aug 13 2017, 10:14 PM

Jul 19 2017

lbeltrame committed R44:816c5a61c01e: Merge remote-tracking branch 'origin/Applications/17.08' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/17.08'
Jul 19 2017, 12:01 PM

Jul 13 2017

lbeltrame added a comment to D6667: Set real KDevPlatform version on the libraries.

On second thought, and look (and discussion with people more knowledgeable than me), it shouldn't, instead (kdevplatform doesn't use symbol versioning).

Jul 13 2017, 1:33 PM
lbeltrame added a comment to D6667: Set real KDevPlatform version on the libraries.

Does the actual file name change? If so, I fear we might get some breakage.

Jul 13 2017, 1:31 PM
lbeltrame added a comment to D6634: Require C++14.

openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are available as well.

Jul 13 2017, 10:07 AM · KWin

Jul 12 2017

lbeltrame added a comment to D6517: Add helper for dealing with compliance modes.

FTR, Laurent fixed it with https://commits.kde.org/kleopatra/e192f09c1d076cbd54ce0a2fa68ce4aa95fd5ea7.

Jul 12 2017, 5:31 AM · KDE PIM
lbeltrame added a comment to D6517: Add helper for dealing with compliance modes.

According to my (limited) understanding, this needs https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=commitdiff;h=05fa2a9c7764b28fdac35eb72631439df948ca0e which is in an unreleased GPGME version. Would it be possible to conditionalize it, or, at worst, warn beforehand when these things occur?

Jul 12 2017, 5:10 AM · KDE PIM
lbeltrame added a comment to D6517: Add helper for dealing with compliance modes.

Since this landed, I'm unable to build kleopatra (I'm up to date with libkleo):

Jul 12 2017, 5:05 AM · KDE PIM

Jul 5 2017

lbeltrame added a reverting commit for R242:f8de13c67421: Don't list KF5::WindowSystem in public libraries: R242:cf79873de63e: Revert "Don't list KF5::WindowSystem in public libraries".
Jul 5 2017, 7:21 AM
lbeltrame committed R242:cf79873de63e: Revert "Don't list KF5::WindowSystem in public libraries" (authored by lbeltrame).
Revert "Don't list KF5::WindowSystem in public libraries"
Jul 5 2017, 7:21 AM

Jul 2 2017

lbeltrame committed R120:5f4333feb815: Remove Hidden=true from the .desktop file (authored by lbeltrame).
Remove Hidden=true from the .desktop file
Jul 2 2017, 8:15 PM

Jun 29 2017

lbeltrame committed R857:b22323d55657: Add libgirepository and typelib-1_0-Atspi_2_0 to the image (authored by lbeltrame).
Add libgirepository and typelib-1_0-Atspi_2_0 to the image
Jun 29 2017, 11:41 AM

Jun 14 2017

lbeltrame committed R263:1bc3a0b41c0c: Revert "When building menu hyerarchies, parent menus to their containers" (authored by lbeltrame).
Revert "When building menu hyerarchies, parent menus to their containers"
Jun 14 2017, 1:58 PM
lbeltrame added a reverting commit for R263:b5af0296cb2f: When building menu hyerarchies, parent menus to their containers: R263:1bc3a0b41c0c: Revert "When building menu hyerarchies, parent menus to their containers".
Jun 14 2017, 1:58 PM

Jun 13 2017

lbeltrame committed R857:71830729fd21: Explicitly add libasan3 to the image (authored by lbeltrame).
Explicitly add libasan3 to the image
Jun 13 2017, 6:47 PM

May 27 2017

lbeltrame accepted D5981: Fix compilation of Python bindings.
May 27 2017, 7:20 AM · Frameworks
lbeltrame added a reviewer for D5981: Fix compilation of Python bindings: lbeltrame.
May 27 2017, 6:38 AM · Frameworks
lbeltrame added a comment to D5981: Fix compilation of Python bindings.

I'll try to test and report back.

May 27 2017, 6:38 AM · Frameworks

May 22 2017

lbeltrame committed R318:95f9dc9de00e: Merge branch 'Applications/17.04' (authored by lbeltrame).
Merge branch 'Applications/17.04'
May 22 2017, 9:32 PM

May 19 2017

lbeltrame added a comment to D5012: Delay notifications until desktop session has loaded.

Months later, it turns out that notify-osd ships a org.freedesktop.Notifications.service already, so it conflicts with the one made by this patch.

May 19 2017, 3:50 PM · Plasma
lbeltrame committed R206:8f8f402e376d: Add missing helper_p include (authored by lbeltrame).
Add missing helper_p include
May 19 2017, 5:08 AM

May 17 2017

lbeltrame committed R90:5e0c2bc96ea5: Merge branch 'Applications/17.04' (authored by lbeltrame).
Merge branch 'Applications/17.04'
May 17 2017, 3:07 PM
lbeltrame committed R90:675ce908a33d: Fix compilation with GCC 7 (authored by fvogt).
Fix compilation with GCC 7
May 17 2017, 3:07 PM
lbeltrame accepted D5900: use transientparent directly.

Tested, works (neither kontact nor okular crash with this change).

May 17 2017, 11:42 AM · Frameworks
lbeltrame added a reviewer for D5900: use transientparent directly: lbeltrame.
May 17 2017, 11:33 AM · Frameworks