lbeltrame (Luca Beltrame)Administrator
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2015, 11:22 PM (209 w, 5 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

lbeltrame accepted D19108: [ExternalExtractor] Provide more helpful output when extractor fails.

LGTM!. Annoyed me for a long time (and made hard to debug some issues).

Mon, Feb 18, 6:14 AM · Baloo, Frameworks

Thu, Feb 14

lbeltrame added a reviewer for D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths: KTextEditor.
Thu, Feb 14, 2:32 PM · Frameworks, Kate
lbeltrame added reviewers for D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths: dhaumann, cullmann.
Thu, Feb 14, 2:31 PM · Frameworks, Kate
lbeltrame added a reviewer for D18845: authority: add support for passing details to polkit: Frameworks.
Thu, Feb 14, 2:30 PM
lbeltrame created T10480: KTextEditor KAuth helper + KAuth security review (by SUSE).
Thu, Feb 14, 2:23 PM · KTextEditor

Tue, Feb 12

lbeltrame added a reviewer for D18952: new find module for Canberra: cgiboudeaux.
Tue, Feb 12, 1:09 PM · Build System, Frameworks
lbeltrame added a reviewer for D18947: Bring FindUDev.cmake up to ECM standards: cgiboudeaux.
Tue, Feb 12, 11:10 AM · Frameworks
lbeltrame added a reviewer for D18941: Fix build with cmake 3.5: bruns.
Tue, Feb 12, 8:03 AM · Baloo, Frameworks
lbeltrame added reviewers for D18941: Fix build with cmake 3.5: Build System, cgiboudeaux.
Tue, Feb 12, 8:03 AM · Baloo, Frameworks

Sat, Feb 9

lbeltrame added a comment to D18867: Remove redundant DNS field.

Migrating sounds like a good idea. I don't think popups are necessary for this.

Sat, Feb 9, 8:29 AM · Plasma

Fri, Feb 8

lbeltrame accepted D18844: Fix opening toolbox button.

Works. No side effects.

Fri, Feb 8, 10:10 AM · Plasma

Wed, Feb 6

lbeltrame added a comment to D18781: Fix SQLite backend foreign key PRAGMAs.

If that's the case, just adjust the summary to use CCBUG: instead of BUG:.

Wed, Feb 6, 11:40 AM · KDE PIM

Mon, Jan 28

lbeltrame added a comment to D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf.

Can you expand a bit the description? I understand you are fixing problems, but why the problems are there and what you are doing exactly.

Mon, Jan 28, 9:10 AM · Frameworks

Sat, Jan 26

lbeltrame added a comment to T10397: Qt 5.12 for plasma master.

You can add the KDE:Qt:5.12 repository in the exact same fashion as before for the openSUSE images. It's been ready for a while.

Sat, Jan 26, 9:23 AM · build.kde.org

Fri, Jan 25

lbeltrame accepted D18527: List Android as officially supported.
Fri, Jan 25, 3:30 PM · Frameworks

Mon, Jan 21

lbeltrame added reviewers for D18424: Instantiate QApplication before KCrash/KCatalog: bruns, poboiko.
Mon, Jan 21, 7:33 AM · Baloo, Frameworks

Jan 18 2019

lbeltrame accepted D18345: Fix python binding generation for classes with deleted copy constructors.

As far as I understand the logic of the whole thing, it looks sane. At some point we ought to find a way to properly test that the generated code...

Jan 18 2019, 10:58 AM · Build System, Frameworks

Jan 14 2019

lbeltrame added a reviewer for D18244: Check for python-cairo: cgiboudeaux.
Jan 14 2019, 4:02 PM · Plasma
lbeltrame added a comment to D14147: Port from GConf to GSettings.

Ping! Is this still being looked at? As distributions may phase out pulseaudio-gconf, this is important.

Jan 14 2019, 1:51 PM · Plasma
lbeltrame added a comment to D17154: Go back to SCSS.

Are there any strong reasons?

Jan 14 2019, 11:18 AM · Plasma

Jan 11 2019

lbeltrame added a comment to D17154: Go back to SCSS.

https://invent.kde.org/sysadmin/ci-tooling/commit/d3443ccf5b0233f4fd0b19c93d8332046b616f58 adds the PyCairo dependency to the CI, although the build system must still check for it (as it doesn't now).

Jan 11 2019, 11:31 PM · Plasma
lbeltrame committed R857:d3443ccf5b02: Add PyCairo to the image (needed for breeze-gtk) (authored by lbeltrame).
Add PyCairo to the image (needed for breeze-gtk)
Jan 11 2019, 11:30 PM
lbeltrame committed R499:01e2cd79737c: Add the Breeze dependency on breeze-gtk (authored by lbeltrame).
Add the Breeze dependency on breeze-gtk
Jan 11 2019, 11:19 PM
lbeltrame added a comment to D17154: Go back to SCSS.
Jan 11 2019, 11:19 PM · Plasma
lbeltrame committed R98:92978bb2a243: Add the Breeze dependency, which is required to build the styles (authored by lbeltrame).
Add the Breeze dependency, which is required to build the styles
Jan 11 2019, 11:15 PM
lbeltrame added a comment to D17154: Go back to SCSS.
Jan 11 2019, 11:03 PM · Plasma
lbeltrame committed R98:cf5f675799a3: Attempt to fix one of the (many) problems that prevent building (authored by lbeltrame).
Attempt to fix one of the (many) problems that prevent building
Jan 11 2019, 11:01 PM
lbeltrame added a comment to D17154: Go back to SCSS.

There are several issues with this patch, which cause build failures:

Jan 11 2019, 10:59 PM · Plasma
lbeltrame committed R36:b4275e994b68: Merge branch 'Applications/18.12' (authored by lbeltrame).
Merge branch 'Applications/18.12'
Jan 11 2019, 10:38 PM

Jan 5 2019

lbeltrame added a comment to T10245: KWin tests requiring opengl are failing.

We can't roll back as far as I know. Please file a bug at bugzilla.opensuse.org against Mesa, adding all the relevant information.

Jan 5 2019, 9:08 PM · build.kde.org

Jan 3 2019

lbeltrame added a comment to D17947: Export the APIs needed to build Blogilo again.

Then please do this downstream. If it would benefit anything else than Blogilo I would be in principle OK, but it doesn't make sense for upstream. (In openSUSE we removed the package, IIRC).

Jan 3 2019, 9:57 PM · KDE PIM
lbeltrame added a comment to D17947: Export the APIs needed to build Blogilo again.

Blogilo is dead and no longer even offered as part of the Applications releases, and I doubt it does even work nowadays (at least not with WP since IIRC the XMLRPC interface is disabled by default or even removed). Exactly what are you trying to accomplish?

Jan 3 2019, 9:48 PM · KDE PIM

Jan 1 2019

lbeltrame closed T10246: Numlock settings and behaviour as Invalid.
Jan 1 2019, 11:05 PM · Plasma
lbeltrame added a comment to T10246: Numlock settings and behaviour.

Hello!
From what you posted here, it looks like a question and/or discussion, but unfortunately these Tasks on phabricator.kde.org are meant to be used by developers to organize their projects and not for these kind of discussions, or bug reports.

Jan 1 2019, 11:05 PM · Plasma
lbeltrame added a comment to T10247: Systemsettings applications launching as standalone application.

Hello!
From what you posted here, it looks like a question and/or discussion, but unfortunately these Tasks on phabricator.kde.org are meant to be used by developers to organize their projects and not for these kind of discussions, or bug reports.

Jan 1 2019, 11:02 PM · VDG, KDE Applications

Dec 30 2018

lbeltrame added a reviewer for D17863: Add ecm_check_linker_flags function: cgiboudeaux.
Dec 30 2018, 8:47 AM · Build System, Frameworks

Dec 27 2018

lbeltrame added a comment to R857:63d16727883e: Include a 'sass' compatible tool within the CI Images. While i'd prefer not to….

sassc is indeed available in openSUSE. I'd avoid using npm if it's possible.

Dec 27 2018, 9:10 PM

Dec 26 2018

lbeltrame committed R158:d02ccaf8af82: Adjust CMakeLists.txt to install the README.md file (authored by lbeltrame).
Adjust CMakeLists.txt to install the README.md file
Dec 26 2018, 9:03 PM

Dec 21 2018

lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

I would still suggest you get your stuff done with the binary factory and not on the OBS simply because then KDE as a whole can benefit from it. Not doing so will make sure that Windows and other platform-specific issues will never be found.

Dec 21 2018, 11:00 AM · Frameworks
lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.
Dec 21 2018, 8:37 AM · Frameworks

Dec 19 2018

lbeltrame accepted D17331: Extend PositionCodec unit tests, better code coverage.
Dec 19 2018, 8:07 PM · Baloo, Frameworks
lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

I think this is unrelated - this request is to fix an issue with an available package on a distribution, so can anyone accept this ?

I'd argue that the problem is with your distribution. Everybody still shipping qt4 is on its own anyway, seeing that it's not possible to

Dec 19 2018, 4:54 PM · Frameworks

Dec 18 2018

lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

On a recent opensuse Leap 42.3 or 15.x system there is

/usr/lib64/kde4/libexec/kioslave
/usr/lib64/libexec/kf5/kioslave

Dec 18 2018, 12:33 PM · Frameworks
lbeltrame added a reviewer for D17650: Install kioslave.exe as kioslave5.exe under Windows: vonreth.

That said, let's hear the opinion of someone else as well.

Dec 18 2018, 10:54 AM · Frameworks
lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

umbrello from binary factory is far from been production ready. Windows releases are made from the KDE4 branch. See for example https://phabricator.kde.org/T7659

Dec 18 2018, 10:38 AM · Frameworks
lbeltrame requested changes to D17650: Install kioslave.exe as kioslave5.exe under Windows.
Dec 18 2018, 10:28 AM · Frameworks
lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

At this point, I'd rather give my -1 to this. The 4.x kdelibs stack is *long* unmaintained, as well as Qt. What are real, compelling reasons to do this?

Dec 18 2018, 10:27 AM · Frameworks

Nov 27 2018

lbeltrame added a reviewer for D17140: Scrobbler: fix issue where if session key is not empty, a QNetworkAccessManager never gets created.: mpyne.
Nov 27 2018, 8:21 AM

Nov 25 2018

lbeltrame committed R425:4532d90a1c88: Merge branch 'Applications/18.12' (authored by lbeltrame).
Merge branch 'Applications/18.12'
Nov 25 2018, 10:21 PM
lbeltrame committed R425:987d646bead0: Add LICENSE (GPL-2.0) (authored by lbeltrame).
Add LICENSE (GPL-2.0)
Nov 25 2018, 10:20 PM

Nov 23 2018

lbeltrame requested changes to D17007: Do hash and hex name based output hashes.

As a packager: messing up with user configuration without a clear migration path is a no-no.

Nov 23 2018, 12:52 PM · Plasma

Nov 22 2018

lbeltrame accepted D17090: Use append instead of operator+= when appending to an QVector<int>.
Nov 22 2018, 6:38 AM · Baloo, Frameworks
lbeltrame accepted D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs.

LGTM; just a minor change needed.

Nov 22 2018, 6:38 AM · Baloo, Frameworks

Nov 14 2018

lbeltrame committed R242:17c8927748aa: Add back (accidentally?) deleted line in CMakeLists.txt (authored by lbeltrame).
Add back (accidentally?) deleted line in CMakeLists.txt
Nov 14 2018, 10:44 PM

Nov 5 2018

lbeltrame accepted D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP.
Nov 5 2018, 11:00 PM · Baloo, Frameworks

Nov 3 2018

lbeltrame committed R351:927988426d42: Fix version after merge (thanks pepo) (authored by lbeltrame).
Fix version after merge (thanks pepo)
Nov 3 2018, 9:23 PM
lbeltrame committed R351:71bd72923d8b: Fix build with FrameworkCompilerSettings (authored by lbeltrame).
Fix build with FrameworkCompilerSettings
Nov 3 2018, 11:40 AM
lbeltrame committed R351:21689d8f799b: Fix build (authored by lbeltrame).
Fix build
Nov 3 2018, 11:40 AM
lbeltrame committed R351:a9b3ee029426: Merge branch 'Applications/18.08' (authored by lbeltrame).
Merge branch 'Applications/18.08'
Nov 3 2018, 11:40 AM
lbeltrame committed R351:972f0828af39: Revert "Fix build (1 of 2)" (authored by lbeltrame).
Revert "Fix build (1 of 2)"
Nov 3 2018, 10:56 AM
lbeltrame committed R351:b7df5974a3fe: Revert "Fix build (2 of 2)" (authored by lbeltrame).
Revert "Fix build (2 of 2)"
Nov 3 2018, 10:56 AM
lbeltrame added a reverting change for R351:20de1a308617: Fix build (1 of 2): R351:972f0828af39: Revert "Fix build (1 of 2)".
Nov 3 2018, 10:56 AM
lbeltrame added a reverting change for R351:d1210c9efd4b: Fix build (2 of 2): R351:b7df5974a3fe: Revert "Fix build (2 of 2)".
Nov 3 2018, 10:56 AM
lbeltrame committed R351:d1210c9efd4b: Fix build (2 of 2) (authored by lbeltrame).
Fix build (2 of 2)
Nov 3 2018, 10:55 AM
lbeltrame committed R351:20de1a308617: Fix build (1 of 2) (authored by lbeltrame).
Fix build (1 of 2)
Nov 3 2018, 10:55 AM

Oct 31 2018

lbeltrame added a comment to D16305: Add a QIconEnginePlugin to allow QIcon deserialization.

+1.

Oct 31 2018, 8:36 AM · Frameworks

Oct 30 2018

lbeltrame accepted D16524: [Extractor] Use QDataStream serialization in place of cooked one.
Oct 30 2018, 6:08 AM · Baloo, Frameworks
lbeltrame added a comment to D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP.

In general (for my limited Baloo knowledge) this makes sense. You might want to add a few CCBUGs if you are aware of specific bugs this alleviates (@ngraham or someone from the bugsquad may help).

Oct 30 2018, 6:07 AM · Baloo, Frameworks

Oct 29 2018

lbeltrame accepted D16505: [KFileMetaData] Replace QDir::separator() with '/' in unit tests.
Oct 29 2018, 10:43 AM · Baloo, Frameworks
lbeltrame added a comment to D16490: [XmlExtractor] Add unittest for XML extractor.

Generally looks OK to me, one note on QDir::separator() usage.

Oct 29 2018, 8:46 AM · Baloo, Frameworks

Oct 26 2018

lbeltrame added a comment to D16393: Add the config to use the system color in Korganizer (see D16377).

Otherwise it seems ok for me. (Fix just public to private and commit after that)

Should I request developers access?

Oct 26 2018, 1:01 PM · KDE PIM

Oct 25 2018

lbeltrame accepted D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp.
Oct 25 2018, 3:30 PM · Baloo, Frameworks

Oct 24 2018

lbeltrame accepted D16265: [Scheduler] Use flag to track when a runner is going idle.

The changes look sane to me. Perhaps wait a couple more days until any other objection is raised, then if not, commit away.

Oct 24 2018, 7:12 AM · Baloo, Frameworks
lbeltrame added a comment to D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob.

+1, but I'd like to hear people more experienced than me.

Oct 24 2018, 7:06 AM · Frameworks

Oct 17 2018

lbeltrame added a comment to D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp.

+1, looks fine to me as far as I understand.

Oct 17 2018, 9:59 AM · Baloo, Frameworks

Oct 15 2018

lbeltrame accepted D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding.

Looks OK to me.

Oct 15 2018, 6:35 PM · Build System, Frameworks

Oct 12 2018

lbeltrame added a comment to D16051: Fix KOrg category color customization crash.

I tried to merge this to master but there the Akonadi DB scheme version is already higher (37), should it be bumped also there?

Oct 12 2018, 5:09 AM · KDE PIM
lbeltrame committed R76:613be9f34ef9: Merge branch 'Applications/18.08' (authored by lbeltrame).
Merge branch 'Applications/18.08'
Oct 12 2018, 5:07 AM
lbeltrame committed R110:fcd60ef13352: Rename kscreen.categories to libkscreen.categories (authored by lbeltrame).
Rename kscreen.categories to libkscreen.categories
Oct 12 2018, 5:01 AM

Oct 4 2018

lbeltrame committed R199:6effc8214bda: Merge remote-tracking branch 'origin/Applications/18.08' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/18.08'
Oct 4 2018, 12:22 PM

Oct 3 2018

lbeltrame added reviewers for D15916: Rewrite the painting part of agandaitem: mlaurent, dvratil.

As this is a visual change, please add screenshots (one for before, one for the after).

Oct 3 2018, 10:30 AM · KDE PIM: Junior Jobs, KDE PIM

Sep 15 2018

lbeltrame added a reviewer for D15426: Avoid QByteArray::remove in AccessManagerReply::readData: dfaure.
Sep 15 2018, 6:53 AM · Frameworks

Sep 14 2018

lbeltrame added a comment to D15237: [ViewProperties] Check part of home first before doing file system stuff.

+1, but someone else must approve.

Sep 14 2018, 12:56 PM · Dolphin
lbeltrame accepted D15068: Bindings: Correct handling of sources containing utf-8.

LGTM.

Sep 14 2018, 12:21 PM · Build System, Frameworks

Sep 6 2018

lbeltrame added a reviewer for D15310: Search for the Qt5Platform/ThemeSupport in the default includes first: cgiboudeaux.
Sep 6 2018, 8:23 AM · Plasma
lbeltrame added a reverting change for R135:693cf9d952b7: Search in default path before calling find_package: R135:e722319d870d: Revert "Search in default path before calling find_package".
Sep 6 2018, 8:00 AM
lbeltrame committed R135:e722319d870d: Revert "Search in default path before calling find_package" (authored by lbeltrame).
Revert "Search in default path before calling find_package"
Sep 6 2018, 8:00 AM
lbeltrame committed R135:46c8b2a2ac74: Revert "Using Qt5Core rather than Qt5Widget for the version check" (authored by lbeltrame).
Revert "Using Qt5Core rather than Qt5Widget for the version check"
Sep 6 2018, 7:52 AM
lbeltrame added a reverting change for R135:831db7ed507a: Using Qt5Core rather than Qt5Widget for the version check: R135:46c8b2a2ac74: Revert "Using Qt5Core rather than Qt5Widget for the version check".
Sep 6 2018, 7:52 AM
lbeltrame committed R108:ce2705d71fd3: Revert "Search in default path before calling pkg-config" (authored by lbeltrame).
Revert "Search in default path before calling pkg-config"
Sep 6 2018, 7:41 AM
lbeltrame added a reverting change for R108:4f4f3295f2a8: Search in default path before calling pkg-config: R108:ce2705d71fd3: Revert "Search in default path before calling pkg-config".
Sep 6 2018, 7:41 AM
lbeltrame committed R135:4392ad581658: Revert "Search in default path before calling pkg-config" (authored by lbeltrame).
Revert "Search in default path before calling pkg-config"
Sep 6 2018, 7:41 AM
lbeltrame added a reverting change for R135:d9578de8298f: Search in default path before calling pkg-config: R135:4392ad581658: Revert "Search in default path before calling pkg-config".
Sep 6 2018, 7:41 AM

Sep 3 2018

lbeltrame added a comment to D15237: [ViewProperties] Check part of home first before doing file system stuff.

I don't understand well the is part of home stuff, do you mean checking for things out of /home?

Sep 3 2018, 10:23 AM · Dolphin

Aug 31 2018

lbeltrame added a comment to T9390: Next Gen MTP.

I would suggest pushing this as a branch of the main kio-extras repository (is your clone just a clone of kio-extras with your changes on top?) to ensure it doesn't get "lost" (and would make merging easier). Eventually a Phabricator diff would also help for people reviewing the code.

Aug 31 2018, 7:30 AM · Frameworks
lbeltrame abandoned D15179: Fixup setting password.

@mlaurent fixed it already with 6656ae1449c8743243391d15dca41a912e2aecd3.

Aug 31 2018, 7:10 AM · KDE PIM
lbeltrame requested review of D15179: Fixup setting password.
Aug 31 2018, 7:09 AM · KDE PIM

Aug 29 2018

lbeltrame added a comment to D15142: Avoid crash by not checking free space for smb://.

+1

Aug 29 2018, 12:00 PM

Aug 28 2018

lbeltrame added a comment to D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1.

+1

Aug 28 2018, 7:41 AM

Aug 27 2018

lbeltrame added a comment to D15093: Add WireGuard capability..
Aug 27 2018, 5:05 AM · Plasma