lbeltrame (Luca Beltrame)Administrator
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2015, 11:22 PM (226 w, 4 d)
Roles
Administrator
Availability
Available

Recent Activity

Fri, Jun 14

lbeltrame committed R433:ae6def6072f5: Use the new logging category directory with ECM >= 5.59.0 (authored by lbeltrame).
Use the new logging category directory with ECM >= 5.59.0
Fri, Jun 14, 6:27 AM
lbeltrame committed R120:0f38bdced030: Use the new logging category directory with ECM >= 5.59.0 (authored by lbeltrame).
Use the new logging category directory with ECM >= 5.59.0
Fri, Jun 14, 5:21 AM
lbeltrame committed R226:19fd4eaa2bc7: Use the new logging category directory with ECM >= 5.59.0 (authored by lbeltrame).
Use the new logging category directory with ECM >= 5.59.0
Fri, Jun 14, 5:18 AM
lbeltrame committed R531:b0ee84bcff84: Use the new logging category directory with ECM >= 5.59.0 (authored by lbeltrame).
Use the new logging category directory with ECM >= 5.59.0
Fri, Jun 14, 5:14 AM
lbeltrame committed R456:ca377e8fc229: Use the new logging category directory with ECM >= 5.59.0 (authored by lbeltrame).
Use the new logging category directory with ECM >= 5.59.0
Fri, Jun 14, 5:12 AM
lbeltrame committed R434:fc43593a0278: Use the new logging category directory with ECM >= 5.59.0 (authored by lbeltrame).
Use the new logging category directory with ECM >= 5.59.0
Fri, Jun 14, 5:06 AM
lbeltrame committed R319:937029a73587: Use the new logging category directory with ECM >= 5.59.0 (authored by lbeltrame).
Use the new logging category directory with ECM >= 5.59.0
Fri, Jun 14, 5:04 AM

Thu, Jun 13

lbeltrame committed R459:1002e2c58bdc: Use the new logging categories directory with ECM >= 5.59.0 (authored by lbeltrame).
Use the new logging categories directory with ECM >= 5.59.0
Thu, Jun 13, 9:23 PM
lbeltrame committed R421:b6048932e4c6: Use the new logging categories directory with ECM >= 5.59.0 (authored by lbeltrame).
Use the new logging categories directory with ECM >= 5.59.0
Thu, Jun 13, 7:02 AM
lbeltrame committed R174:d0a20076b730: Use the new logging categories directory with ECM >= 5.59.0 (authored by lbeltrame).
Use the new logging categories directory with ECM >= 5.59.0
Thu, Jun 13, 4:57 AM

Mon, Jun 10

lbeltrame accepted D21004: [UserMetaData] Shortcut attribute queries for the common case.
Mon, Jun 10, 7:30 AM · Baloo
lbeltrame added a comment to D21002: Remove kde4 migration agent completely.

+1

Mon, Jun 10, 5:03 AM · Frameworks

Tue, May 21

lbeltrame added a reviewer for D21313: Create specific directory for Qt logging categories file: cgiboudeaux.
Tue, May 21, 5:51 AM · Build System, Frameworks
lbeltrame updated subscribers of D21313: Create specific directory for Qt logging categories file.
Tue, May 21, 5:50 AM · Build System, Frameworks

May 13 2019

lbeltrame accepted D21184: Take the screen geometry into account when positioning popup notifications.

It needs D21152 applied as well to work properly in my scenario.

May 13 2019, 12:15 PM · Plasma
lbeltrame accepted D21152: [Notifications] Fix oversight of not taking into account screen X when placing notifications on the right side of the screen.
May 13 2019, 12:15 PM · Plasma
lbeltrame added a comment to D21184: Take the screen geometry into account when positioning popup notifications.

Doesn't seem to work with screens that have a rotation.
Setup:

May 13 2019, 11:41 AM · Plasma
lbeltrame added a comment to D21184: Take the screen geometry into account when positioning popup notifications.

I'll test and report if it works in my case, too.

May 13 2019, 11:37 AM · Plasma

Apr 30 2019

lbeltrame added a comment to D20922: Messagelib - change default for DeleteInvitationEmailsAfterSendingReply.

Perhaps this should also go to stable?

Apr 30 2019, 4:05 PM · KDE PIM

Apr 19 2019

lbeltrame added a comment to T10812: KDE Applications.
Apr 19 2019, 5:14 AM

Apr 18 2019

lbeltrame added a comment to D20659: Copy container in Component::cleanUp before interating.

I confirm there are no more issues in valgrind after adding this patch.

Apr 18 2019, 12:53 PM · Frameworks
lbeltrame added a reviewer for D20659: Copy container in Component::cleanUp before interating: Frameworks.
Apr 18 2019, 12:37 PM · Frameworks

Apr 16 2019

lbeltrame accepted D20594: Fix MobileTextSelection namespacing.
Apr 16 2019, 9:17 AM · Frameworks

Apr 13 2019

lbeltrame added reviewers for D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix: apol, vkrause.
Apr 13 2019, 10:47 PM · Build System, Frameworks

Apr 11 2019

lbeltrame added a comment to D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog.

+1.

Apr 11 2019, 6:42 PM · Frameworks

Apr 3 2019

lbeltrame accepted D20159: Fix crash when applying collection ACL changes.

Works now, I can't reproduce the crash anymore.

Apr 3 2019, 8:34 AM · KDE PIM

Apr 1 2019

lbeltrame added a comment to D20159: Fix crash when applying collection ACL changes.

I can reproduce the crash reliably (Configure folder -> set mailing list properties -> OK -> crash). I'll test this patch and see what happens.

Apr 1 2019, 1:48 PM · KDE PIM

Mar 28 2019

lbeltrame committed R459:a75ee1954221: Merge remote-tracking branch 'origin/Applications/19.04' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/19.04'
Mar 28 2019, 10:07 PM

Mar 25 2019

lbeltrame committed R44:333bb45c6f9d: Merge remote-tracking branch 'origin/Applications/19.04' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/19.04'
Mar 25 2019, 1:06 PM

Mar 22 2019

lbeltrame committed R165:ce9337e66d00: Merge remote-tracking branch 'origin/Applications/19.04' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/19.04'
Mar 22 2019, 6:15 AM

Mar 18 2019

lbeltrame added a reviewer for D19830: Force build order to prevent build happening before ui .h file exists: cgiboudeaux.
Mar 18 2019, 6:04 AM · KDE PIM

Mar 17 2019

lbeltrame added a comment to D17760: astyle: support the system astyle library.

Then the best should be to file a bug on bugzilla.opensuse.org asking for that to be packaged.

Mar 17 2019, 1:05 PM · KDevelop
lbeltrame added a comment to D17760: astyle: support the system astyle library.

Is this part of the astyle tarball, or a separate project?

Mar 17 2019, 12:55 PM · KDevelop

Mar 12 2019

lbeltrame added reviewers for D19698: Remove crash in plasmashell: Frameworks, Plasma.
Mar 12 2019, 6:22 AM · Frameworks

Mar 11 2019

lbeltrame added a comment to D19656: Comparisson has a typo, === and not = ==..

This was already fixed by 0d5c93b7c5318600f53d214efca2a060c0f0eea7.

Mar 11 2019, 6:28 AM · Plasma

Feb 25 2019

lbeltrame added a comment to D19189: [KMail] Add an option to start in tray.

@matthieugras Do you have a commit access? Or do you need a developer to push this for you?

Feb 25 2019, 1:32 PM · KDE PIM

Feb 22 2019

lbeltrame committed R165:c3a7f32511d8: Merge remote-tracking branch 'origin/Applications/18.12' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/18.12'
Feb 22 2019, 10:19 AM

Feb 21 2019

lbeltrame added a reviewer for D19189: [KMail] Add an option to start in tray: mlaurent.
Feb 21 2019, 9:31 AM · KDE PIM

Feb 18 2019

lbeltrame accepted D19108: [ExternalExtractor] Provide more helpful output when extractor fails.

LGTM!. Annoyed me for a long time (and made hard to debug some issues).

Feb 18 2019, 6:14 AM · Baloo, Frameworks

Feb 14 2019

lbeltrame added a reviewer for D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths: KTextEditor.
Feb 14 2019, 2:32 PM · Frameworks, Kate
lbeltrame added reviewers for D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths: dhaumann, cullmann.
Feb 14 2019, 2:31 PM · Frameworks, Kate
lbeltrame added a reviewer for D18845: authority: add support for passing details to polkit: Frameworks.
Feb 14 2019, 2:30 PM
lbeltrame created T10480: KTextEditor KAuth helper + KAuth security review (by SUSE).
Feb 14 2019, 2:23 PM · KTextEditor

Feb 12 2019

lbeltrame added a reviewer for D18952: new find module for Canberra: cgiboudeaux.
Feb 12 2019, 1:09 PM · Build System, Frameworks
lbeltrame added a reviewer for D18947: Bring FindUDev.cmake up to ECM standards: cgiboudeaux.
Feb 12 2019, 11:10 AM · Frameworks
lbeltrame added a reviewer for D18941: Fix build with cmake 3.5: bruns.
Feb 12 2019, 8:03 AM · Frameworks, Baloo
lbeltrame added reviewers for D18941: Fix build with cmake 3.5: Build System, cgiboudeaux.
Feb 12 2019, 8:03 AM · Frameworks, Baloo

Feb 9 2019

lbeltrame added a comment to D18867: Remove redundant DNS field.

Migrating sounds like a good idea. I don't think popups are necessary for this.

Feb 9 2019, 8:29 AM · Plasma

Feb 8 2019

lbeltrame accepted D18844: Fix opening toolbox button.

Works. No side effects.

Feb 8 2019, 10:10 AM · Plasma

Feb 6 2019

lbeltrame added a comment to D18781: Fix SQLite backend foreign key PRAGMAs.

If that's the case, just adjust the summary to use CCBUG: instead of BUG:.

Feb 6 2019, 11:40 AM · KDE PIM

Jan 28 2019

lbeltrame added a comment to D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf.

Can you expand a bit the description? I understand you are fixing problems, but why the problems are there and what you are doing exactly.

Jan 28 2019, 9:10 AM · Frameworks

Jan 26 2019

lbeltrame added a comment to T10397: Qt 5.12 for plasma master.

You can add the KDE:Qt:5.12 repository in the exact same fashion as before for the openSUSE images. It's been ready for a while.

Jan 26 2019, 9:23 AM · build.kde.org

Jan 25 2019

lbeltrame accepted D18527: List Android as officially supported.
Jan 25 2019, 3:30 PM · Frameworks

Jan 21 2019

lbeltrame added reviewers for D18424: Instantiate QApplication before KCrash/KCatalog: bruns, poboiko.
Jan 21 2019, 7:33 AM · Baloo, Frameworks

Jan 18 2019

lbeltrame accepted D18345: Fix python binding generation for classes with deleted copy constructors.

As far as I understand the logic of the whole thing, it looks sane. At some point we ought to find a way to properly test that the generated code...

Jan 18 2019, 10:58 AM · Build System, Frameworks

Jan 14 2019

lbeltrame added a reviewer for D18244: Check for python-cairo: cgiboudeaux.
Jan 14 2019, 4:02 PM · Plasma
lbeltrame added a comment to D14147: Port from GConf to GSettings.

Ping! Is this still being looked at? As distributions may phase out pulseaudio-gconf, this is important.

Jan 14 2019, 1:51 PM · Plasma
lbeltrame added a comment to D17154: Go back to SCSS.

Are there any strong reasons?

Jan 14 2019, 11:18 AM · Plasma

Jan 11 2019

lbeltrame added a comment to D17154: Go back to SCSS.

https://invent.kde.org/sysadmin/ci-tooling/commit/d3443ccf5b0233f4fd0b19c93d8332046b616f58 adds the PyCairo dependency to the CI, although the build system must still check for it (as it doesn't now).

Jan 11 2019, 11:31 PM · Plasma
lbeltrame committed R857:d3443ccf5b02: Add PyCairo to the image (needed for breeze-gtk) (authored by lbeltrame).
Add PyCairo to the image (needed for breeze-gtk)
Jan 11 2019, 11:30 PM
lbeltrame committed R499:01e2cd79737c: Add the Breeze dependency on breeze-gtk (authored by lbeltrame).
Add the Breeze dependency on breeze-gtk
Jan 11 2019, 11:19 PM
lbeltrame added a comment to D17154: Go back to SCSS.
Jan 11 2019, 11:19 PM · Plasma
lbeltrame committed R98:92978bb2a243: Add the Breeze dependency, which is required to build the styles (authored by lbeltrame).
Add the Breeze dependency, which is required to build the styles
Jan 11 2019, 11:15 PM
lbeltrame added a comment to D17154: Go back to SCSS.
Jan 11 2019, 11:03 PM · Plasma
lbeltrame committed R98:cf5f675799a3: Attempt to fix one of the (many) problems that prevent building (authored by lbeltrame).
Attempt to fix one of the (many) problems that prevent building
Jan 11 2019, 11:01 PM
lbeltrame added a comment to D17154: Go back to SCSS.

There are several issues with this patch, which cause build failures:

Jan 11 2019, 10:59 PM · Plasma
lbeltrame committed R36:b4275e994b68: Merge branch 'Applications/18.12' (authored by lbeltrame).
Merge branch 'Applications/18.12'
Jan 11 2019, 10:38 PM

Jan 5 2019

lbeltrame added a comment to T10245: KWin tests requiring opengl are failing.

We can't roll back as far as I know. Please file a bug at bugzilla.opensuse.org against Mesa, adding all the relevant information.

Jan 5 2019, 9:08 PM · build.kde.org

Jan 3 2019

lbeltrame added a comment to D17947: Export the APIs needed to build Blogilo again.

Then please do this downstream. If it would benefit anything else than Blogilo I would be in principle OK, but it doesn't make sense for upstream. (In openSUSE we removed the package, IIRC).

Jan 3 2019, 9:57 PM · KDE PIM
lbeltrame added a comment to D17947: Export the APIs needed to build Blogilo again.

Blogilo is dead and no longer even offered as part of the Applications releases, and I doubt it does even work nowadays (at least not with WP since IIRC the XMLRPC interface is disabled by default or even removed). Exactly what are you trying to accomplish?

Jan 3 2019, 9:48 PM · KDE PIM

Jan 1 2019

lbeltrame closed T10246: Numlock settings and behaviour as Invalid.
Jan 1 2019, 11:05 PM · Plasma
lbeltrame added a comment to T10246: Numlock settings and behaviour.

Hello!
From what you posted here, it looks like a question and/or discussion, but unfortunately these Tasks on phabricator.kde.org are meant to be used by developers to organize their projects and not for these kind of discussions, or bug reports.

Jan 1 2019, 11:05 PM · Plasma
lbeltrame added a comment to T10247: Systemsettings applications launching as standalone application.

Hello!
From what you posted here, it looks like a question and/or discussion, but unfortunately these Tasks on phabricator.kde.org are meant to be used by developers to organize their projects and not for these kind of discussions, or bug reports.

Jan 1 2019, 11:02 PM · VDG, KDE Applications

Dec 30 2018

lbeltrame added a reviewer for D17863: Add ecm_check_linker_flags function: cgiboudeaux.
Dec 30 2018, 8:47 AM · Build System, Frameworks

Dec 27 2018

lbeltrame added a comment to R857:63d16727883e: Include a 'sass' compatible tool within the CI Images. While i'd prefer not to….

sassc is indeed available in openSUSE. I'd avoid using npm if it's possible.

Dec 27 2018, 9:10 PM

Dec 26 2018

lbeltrame committed R158:d02ccaf8af82: Adjust CMakeLists.txt to install the README.md file (authored by lbeltrame).
Adjust CMakeLists.txt to install the README.md file
Dec 26 2018, 9:03 PM

Dec 21 2018

lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

I would still suggest you get your stuff done with the binary factory and not on the OBS simply because then KDE as a whole can benefit from it. Not doing so will make sure that Windows and other platform-specific issues will never be found.

Dec 21 2018, 11:00 AM · Frameworks
lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.
Dec 21 2018, 8:37 AM · Frameworks

Dec 19 2018

lbeltrame accepted D17331: Extend PositionCodec unit tests, better code coverage.
Dec 19 2018, 8:07 PM · Baloo, Frameworks
lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

I think this is unrelated - this request is to fix an issue with an available package on a distribution, so can anyone accept this ?

I'd argue that the problem is with your distribution. Everybody still shipping qt4 is on its own anyway, seeing that it's not possible to

Dec 19 2018, 4:54 PM · Frameworks

Dec 18 2018

lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

On a recent opensuse Leap 42.3 or 15.x system there is

/usr/lib64/kde4/libexec/kioslave
/usr/lib64/libexec/kf5/kioslave

Dec 18 2018, 12:33 PM · Frameworks
lbeltrame added a reviewer for D17650: Install kioslave.exe as kioslave5.exe under Windows: vonreth.

That said, let's hear the opinion of someone else as well.

Dec 18 2018, 10:54 AM · Frameworks
lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

umbrello from binary factory is far from been production ready. Windows releases are made from the KDE4 branch. See for example https://phabricator.kde.org/T7659

Dec 18 2018, 10:38 AM · Frameworks
lbeltrame requested changes to D17650: Install kioslave.exe as kioslave5.exe under Windows.
Dec 18 2018, 10:28 AM · Frameworks
lbeltrame added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

At this point, I'd rather give my -1 to this. The 4.x kdelibs stack is *long* unmaintained, as well as Qt. What are real, compelling reasons to do this?

Dec 18 2018, 10:27 AM · Frameworks

Nov 27 2018

lbeltrame added a reviewer for D17140: Scrobbler: fix issue where if session key is not empty, a QNetworkAccessManager never gets created.: mpyne.
Nov 27 2018, 8:21 AM

Nov 25 2018

lbeltrame committed R425:4532d90a1c88: Merge branch 'Applications/18.12' (authored by lbeltrame).
Merge branch 'Applications/18.12'
Nov 25 2018, 10:21 PM
lbeltrame committed R425:987d646bead0: Add LICENSE (GPL-2.0) (authored by lbeltrame).
Add LICENSE (GPL-2.0)
Nov 25 2018, 10:20 PM

Nov 23 2018

lbeltrame requested changes to D17007: Do hash and hex name based output hashes.

As a packager: messing up with user configuration without a clear migration path is a no-no.

Nov 23 2018, 12:52 PM · Plasma

Nov 22 2018

lbeltrame accepted D17090: Use append instead of operator+= when appending to an QVector<int>.
Nov 22 2018, 6:38 AM · Baloo, Frameworks
lbeltrame accepted D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs.

LGTM; just a minor change needed.

Nov 22 2018, 6:38 AM · Baloo, Frameworks

Nov 14 2018

lbeltrame committed R242:17c8927748aa: Add back (accidentally?) deleted line in CMakeLists.txt (authored by lbeltrame).
Add back (accidentally?) deleted line in CMakeLists.txt
Nov 14 2018, 10:44 PM

Nov 5 2018

lbeltrame accepted D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP.
Nov 5 2018, 11:00 PM · Baloo, Frameworks

Nov 3 2018

lbeltrame committed R351:927988426d42: Fix version after merge (thanks pepo) (authored by lbeltrame).
Fix version after merge (thanks pepo)
Nov 3 2018, 9:23 PM
lbeltrame committed R351:71bd72923d8b: Fix build with FrameworkCompilerSettings (authored by lbeltrame).
Fix build with FrameworkCompilerSettings
Nov 3 2018, 11:40 AM
lbeltrame committed R351:21689d8f799b: Fix build (authored by lbeltrame).
Fix build
Nov 3 2018, 11:40 AM
lbeltrame committed R351:a9b3ee029426: Merge branch 'Applications/18.08' (authored by lbeltrame).
Merge branch 'Applications/18.08'
Nov 3 2018, 11:40 AM
lbeltrame committed R351:972f0828af39: Revert "Fix build (1 of 2)" (authored by lbeltrame).
Revert "Fix build (1 of 2)"
Nov 3 2018, 10:56 AM
lbeltrame committed R351:b7df5974a3fe: Revert "Fix build (2 of 2)" (authored by lbeltrame).
Revert "Fix build (2 of 2)"
Nov 3 2018, 10:56 AM
lbeltrame added a reverting change for R351:20de1a308617: Fix build (1 of 2): R351:972f0828af39: Revert "Fix build (1 of 2)".
Nov 3 2018, 10:56 AM