lbeltrame (Luca Beltrame)Administrator
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2015, 11:22 PM (199 w, 5 d)
Roles
Administrator
Availability
Available

Recent Activity

Tue, Nov 27

lbeltrame added a reviewer for D17140: Scrobbler: fix issue where if session key is not empty, a QNetworkAccessManager never gets created.: mpyne.
Tue, Nov 27, 8:21 AM

Sun, Nov 25

lbeltrame committed R425:4532d90a1c88: Merge branch 'Applications/18.12' (authored by lbeltrame).
Merge branch 'Applications/18.12'
Sun, Nov 25, 10:21 PM
lbeltrame committed R425:987d646bead0: Add LICENSE (GPL-2.0) (authored by lbeltrame).
Add LICENSE (GPL-2.0)
Sun, Nov 25, 10:20 PM

Fri, Nov 23

lbeltrame requested changes to D17007: Do hash and hex name based output hashes.

As a packager: messing up with user configuration without a clear migration path is a no-no.

Fri, Nov 23, 12:52 PM · Plasma

Thu, Nov 22

lbeltrame accepted D17090: Use append instead of operator+= when appending to an QVector<int>.
Thu, Nov 22, 6:38 AM · Baloo, Frameworks
lbeltrame accepted D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs.

LGTM; just a minor change needed.

Thu, Nov 22, 6:38 AM · Baloo, Frameworks

Wed, Nov 14

lbeltrame committed R242:17c8927748aa: Add back (accidentally?) deleted line in CMakeLists.txt (authored by lbeltrame).
Add back (accidentally?) deleted line in CMakeLists.txt
Wed, Nov 14, 10:44 PM

Nov 5 2018

lbeltrame accepted D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP.
Nov 5 2018, 11:00 PM · Baloo, Frameworks

Nov 3 2018

lbeltrame committed R351:927988426d42: Fix version after merge (thanks pepo) (authored by lbeltrame).
Fix version after merge (thanks pepo)
Nov 3 2018, 9:23 PM
lbeltrame committed R351:71bd72923d8b: Fix build with FrameworkCompilerSettings (authored by lbeltrame).
Fix build with FrameworkCompilerSettings
Nov 3 2018, 11:40 AM
lbeltrame committed R351:21689d8f799b: Fix build (authored by lbeltrame).
Fix build
Nov 3 2018, 11:40 AM
lbeltrame committed R351:a9b3ee029426: Merge branch 'Applications/18.08' (authored by lbeltrame).
Merge branch 'Applications/18.08'
Nov 3 2018, 11:40 AM
lbeltrame committed R351:972f0828af39: Revert "Fix build (1 of 2)" (authored by lbeltrame).
Revert "Fix build (1 of 2)"
Nov 3 2018, 10:56 AM
lbeltrame committed R351:b7df5974a3fe: Revert "Fix build (2 of 2)" (authored by lbeltrame).
Revert "Fix build (2 of 2)"
Nov 3 2018, 10:56 AM
lbeltrame added a reverting change for R351:20de1a308617: Fix build (1 of 2): R351:972f0828af39: Revert "Fix build (1 of 2)".
Nov 3 2018, 10:56 AM
lbeltrame added a reverting change for R351:d1210c9efd4b: Fix build (2 of 2): R351:b7df5974a3fe: Revert "Fix build (2 of 2)".
Nov 3 2018, 10:56 AM
lbeltrame committed R351:d1210c9efd4b: Fix build (2 of 2) (authored by lbeltrame).
Fix build (2 of 2)
Nov 3 2018, 10:55 AM
lbeltrame committed R351:20de1a308617: Fix build (1 of 2) (authored by lbeltrame).
Fix build (1 of 2)
Nov 3 2018, 10:55 AM

Oct 31 2018

lbeltrame added a comment to D16305: Add a QIconEnginePlugin to allow QIcon deserialization.

+1.

Oct 31 2018, 8:36 AM · Frameworks

Oct 30 2018

lbeltrame accepted D16524: [Extractor] Use QDataStream serialization in place of cooked one.
Oct 30 2018, 6:08 AM · Baloo, Frameworks
lbeltrame added a comment to D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP.

In general (for my limited Baloo knowledge) this makes sense. You might want to add a few CCBUGs if you are aware of specific bugs this alleviates (@ngraham or someone from the bugsquad may help).

Oct 30 2018, 6:07 AM · Baloo, Frameworks

Oct 29 2018

lbeltrame accepted D16505: [KFileMetaData] Replace QDir::separator() with '/' in unit tests.
Oct 29 2018, 10:43 AM · Baloo, Frameworks
lbeltrame added a comment to D16490: [XmlExtractor] Add unittest for XML extractor.

Generally looks OK to me, one note on QDir::separator() usage.

Oct 29 2018, 8:46 AM · Baloo, Frameworks

Oct 26 2018

lbeltrame added a comment to D16393: Add the config to use the system color in Korganizer (see D16377).

Otherwise it seems ok for me. (Fix just public to private and commit after that)

Should I request developers access?

Oct 26 2018, 1:01 PM · KDE PIM

Oct 25 2018

lbeltrame accepted D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp.
Oct 25 2018, 3:30 PM · Baloo, Frameworks

Oct 24 2018

lbeltrame accepted D16265: [Scheduler] Use flag to track when a runner is going idle.

The changes look sane to me. Perhaps wait a couple more days until any other objection is raised, then if not, commit away.

Oct 24 2018, 7:12 AM · Baloo, Frameworks
lbeltrame added a comment to D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob.

+1, but I'd like to hear people more experienced than me.

Oct 24 2018, 7:06 AM · Frameworks

Oct 17 2018

lbeltrame added a comment to D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp.

+1, looks fine to me as far as I understand.

Oct 17 2018, 9:59 AM · Baloo, Frameworks

Oct 15 2018

lbeltrame accepted D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding.

Looks OK to me.

Oct 15 2018, 6:35 PM · Build System, Frameworks

Oct 12 2018

lbeltrame added a comment to D16051: Fix KOrg category color customization crash.

I tried to merge this to master but there the Akonadi DB scheme version is already higher (37), should it be bumped also there?

Oct 12 2018, 5:09 AM · KDE PIM
lbeltrame committed R76:613be9f34ef9: Merge branch 'Applications/18.08' (authored by lbeltrame).
Merge branch 'Applications/18.08'
Oct 12 2018, 5:07 AM
lbeltrame committed R110:fcd60ef13352: Rename kscreen.categories to libkscreen.categories (authored by lbeltrame).
Rename kscreen.categories to libkscreen.categories
Oct 12 2018, 5:01 AM

Oct 4 2018

lbeltrame committed R199:6effc8214bda: Merge remote-tracking branch 'origin/Applications/18.08' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/18.08'
Oct 4 2018, 12:22 PM

Oct 3 2018

lbeltrame added reviewers for D15916: Rewrite the painting part of agandaitem: mlaurent, dvratil.

As this is a visual change, please add screenshots (one for before, one for the after).

Oct 3 2018, 10:30 AM · KDE PIM: Junior Jobs, KDE PIM

Sep 15 2018

lbeltrame added a reviewer for D15426: Avoid QByteArray::remove in AccessManagerReply::readData: dfaure.
Sep 15 2018, 6:53 AM · Frameworks

Sep 14 2018

lbeltrame added a comment to D15237: [ViewProperties] Check part of home first before doing file system stuff.

+1, but someone else must approve.

Sep 14 2018, 12:56 PM · Dolphin
lbeltrame accepted D15068: Bindings: Correct handling of sources containing utf-8.

LGTM.

Sep 14 2018, 12:21 PM · Build System, Frameworks

Sep 6 2018

lbeltrame added a reviewer for D15310: Search for the Qt5Platform/ThemeSupport in the default includes first: cgiboudeaux.
Sep 6 2018, 8:23 AM · Plasma
lbeltrame added a reverting change for R135:693cf9d952b7: Search in default path before calling find_package: R135:e722319d870d: Revert "Search in default path before calling find_package".
Sep 6 2018, 8:00 AM
lbeltrame committed R135:e722319d870d: Revert "Search in default path before calling find_package" (authored by lbeltrame).
Revert "Search in default path before calling find_package"
Sep 6 2018, 8:00 AM
lbeltrame committed R135:46c8b2a2ac74: Revert "Using Qt5Core rather than Qt5Widget for the version check" (authored by lbeltrame).
Revert "Using Qt5Core rather than Qt5Widget for the version check"
Sep 6 2018, 7:52 AM
lbeltrame added a reverting change for R135:831db7ed507a: Using Qt5Core rather than Qt5Widget for the version check: R135:46c8b2a2ac74: Revert "Using Qt5Core rather than Qt5Widget for the version check".
Sep 6 2018, 7:52 AM
lbeltrame committed R108:ce2705d71fd3: Revert "Search in default path before calling pkg-config" (authored by lbeltrame).
Revert "Search in default path before calling pkg-config"
Sep 6 2018, 7:41 AM
lbeltrame added a reverting change for R108:4f4f3295f2a8: Search in default path before calling pkg-config: R108:ce2705d71fd3: Revert "Search in default path before calling pkg-config".
Sep 6 2018, 7:41 AM
lbeltrame committed R135:4392ad581658: Revert "Search in default path before calling pkg-config" (authored by lbeltrame).
Revert "Search in default path before calling pkg-config"
Sep 6 2018, 7:41 AM
lbeltrame added a reverting change for R135:d9578de8298f: Search in default path before calling pkg-config: R135:4392ad581658: Revert "Search in default path before calling pkg-config".
Sep 6 2018, 7:41 AM

Sep 3 2018

lbeltrame added a comment to D15237: [ViewProperties] Check part of home first before doing file system stuff.

I don't understand well the is part of home stuff, do you mean checking for things out of /home?

Sep 3 2018, 10:23 AM · Dolphin

Aug 31 2018

lbeltrame added a comment to T9390: Next Gen MTP.

I would suggest pushing this as a branch of the main kio-extras repository (is your clone just a clone of kio-extras with your changes on top?) to ensure it doesn't get "lost" (and would make merging easier). Eventually a Phabricator diff would also help for people reviewing the code.

Aug 31 2018, 7:30 AM · Frameworks
lbeltrame abandoned D15179: Fixup setting password.

@mlaurent fixed it already with 6656ae1449c8743243391d15dca41a912e2aecd3.

Aug 31 2018, 7:10 AM · KDE PIM
lbeltrame requested review of D15179: Fixup setting password.
Aug 31 2018, 7:09 AM · KDE PIM

Aug 29 2018

lbeltrame added a comment to D15142: Avoid crash by not checking free space for smb://.

+1

Aug 29 2018, 12:00 PM

Aug 28 2018

lbeltrame added a comment to D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1.

+1

Aug 28 2018, 7:41 AM

Aug 27 2018

lbeltrame added a comment to D15093: Add WireGuard capability..
Aug 27 2018, 5:05 AM · Plasma
lbeltrame added a comment to D15093: Add WireGuard capability..

Some smallish nitpicks I noticed there. Also, does this mean that NM has WG support now?

Aug 27 2018, 4:36 AM · Plasma

Jul 26 2018

lbeltrame committed R260:1cab13f0970f: Attempt to fix build (authored by lbeltrame).
Attempt to fix build
Jul 26 2018, 8:32 PM
lbeltrame added a comment to D14395: [KSambaShare] Check file that's changed before reloading.

+1

Jul 26 2018, 7:54 AM · Frameworks

Jul 24 2018

lbeltrame added a comment to D14242: Significant performance increase for specific use conditions.

@steinalexander: Do you have commit access? Or do you need any of the developers to commit this for you?

Jul 24 2018, 4:44 AM · KDE PIM

Jul 10 2018

lbeltrame committed R115:97a75bde40e7: Merge remote-tracking branch 'origin/Plasma/5.13' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.13'
Jul 10 2018, 11:48 AM

Jun 27 2018

lbeltrame added inline comments to D13675: Fix sage backend for Sage 8.1 and 8.2.
Jun 27 2018, 9:13 PM · KDE Edu, Cantor
lbeltrame added inline comments to D13675: Fix sage backend for Sage 8.1 and 8.2.
Jun 27 2018, 3:40 PM · KDE Edu, Cantor
lbeltrame added a reviewer for D12233: Avoid manipulation of lists with quadratic complexity: mgallien.
Jun 27 2018, 1:30 PM · Baloo, Frameworks
lbeltrame added inline comments to D13675: Fix sage backend for Sage 8.1 and 8.2.
Jun 27 2018, 9:05 AM · KDE Edu, Cantor

Jun 22 2018

lbeltrame accepted D13641: [KCharSelect] Port generate-datafile.py to Python 3.

I did an accept to undo my earlier "Changes required" because Phab messed up the lines I commented on, and because I realized I wasn't commenting on your specific changes. Sorry about that.

Jun 22 2018, 4:50 AM · Frameworks
lbeltrame requested changes to D13641: [KCharSelect] Port generate-datafile.py to Python 3.
Jun 22 2018, 4:43 AM · Frameworks

Jun 21 2018

lbeltrame accepted D13641: [KCharSelect] Port generate-datafile.py to Python 3.
Jun 21 2018, 4:44 AM · Frameworks

Jun 14 2018

lbeltrame committed R320:90bf44cc150a: Merge branch 'Applications/18.04' (authored by lbeltrame).
Merge branch 'Applications/18.04'
Jun 14 2018, 9:56 AM
lbeltrame committed R320:bca40518682a: fix sftp links with new uds implementation (authored by jtamate).
fix sftp links with new uds implementation
Jun 14 2018, 9:56 AM
lbeltrame added a comment to D13475: fix sftp links with new uds implementation.

I'm backporting it. Before I push: will this work also with previous KIO versions?

Jun 14 2018, 8:57 AM
lbeltrame added reviewers for D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box: kfunk, mwolff.
Jun 14 2018, 7:42 AM · KDevelop

Jun 9 2018

lbeltrame added a comment to D12696: Use the new uds implementation.

I wonder if this is related to timeline:/ no longer working properly in the file dialog. (didn't investigate yet).

Jun 9 2018, 9:16 PM · Frameworks

May 31 2018

lbeltrame committed R434:753f10136eac: Merge branch 'Applications/18.04' (authored by lbeltrame).
Merge branch 'Applications/18.04'
May 31 2018, 12:11 PM
lbeltrame committed R434:824cca1ca3eb: Fix installation of notifyrc file (authored by lbeltrame).
Fix installation of notifyrc file
May 31 2018, 12:11 PM

May 29 2018

lbeltrame committed R44:019be5a11b41: Merge branch 'Applications/18.04' (authored by lbeltrame).
Merge branch 'Applications/18.04'
May 29 2018, 6:18 PM

May 28 2018

lbeltrame added a comment to D12990: update mouse kcm docbook to 5.13.

@ltoscano The question was asked due to a bad merge in plasma-desktop, which needed a force push. This commit was originally in the branch, but no longer due to this. Hence, the question: should it be added back?

May 28 2018, 1:22 PM · Documentation, Plasma

May 23 2018

lbeltrame added a comment to T8780: Implement editing of elements in the app.

I had a quick chat with notmart about this (without going into much detail) and this is the outcome:

May 23 2018, 6:54 PM · KDE Itinerary
lbeltrame added a comment to T8802: New dependency for kpat (required for CI).

Yes, that will need to get packaged. We'll keep you posted.

May 23 2018, 8:26 AM · build.kde.org

May 22 2018

lbeltrame committed R1007:149c043a91fe: Add autotest for adding reservations (authored by lbeltrame).
Add autotest for adding reservations
May 22 2018, 7:01 AM
lbeltrame closed D13029: Add autotest for adding reservations.
May 22 2018, 7:01 AM · KDE PIM
lbeltrame requested review of D13029: Add autotest for adding reservations.
May 22 2018, 5:14 AM · KDE PIM

May 21 2018

lbeltrame added a comment to D13001: Handle children of added nodes as well.

What's the easiest way to test this? I might just patch the package and see what happens.

May 21 2018, 12:57 PM · Plasma

May 19 2018

lbeltrame committed R1003:d90af9e6800a: Use the full namespace for the associated property (authored by lbeltrame).
Use the full namespace for the associated property
May 19 2018, 4:13 PM
lbeltrame committed R1007:4b701a109c98: [WIP] Initial support for adding reservations without files (authored by lbeltrame).
[WIP] Initial support for adding reservations without files
May 19 2018, 12:12 PM
lbeltrame closed D12834: [WIP] Initial support for adding reservations without files.
May 19 2018, 12:12 PM · KDE PIM
lbeltrame committed R1003:519dba663350: Register some more datatypes (authored by lbeltrame).
Register some more datatypes
May 19 2018, 10:59 AM

May 18 2018

lbeltrame updated the diff for D12834: [WIP] Initial support for adding reservations without files.

Use QVariant

May 18 2018, 10:36 PM · KDE PIM

May 12 2018

lbeltrame added a comment to D12834: [WIP] Initial support for adding reservations without files.

There's almost nothing done yet mainly because I want to gather feedback first on what the approach should be (to avoid doing work that won't be useful).

May 12 2018, 1:00 PM · KDE PIM
lbeltrame requested review of D12834: [WIP] Initial support for adding reservations without files.
May 12 2018, 12:58 PM · KDE PIM

May 10 2018

lbeltrame committed R261:e5198a902996: Fix build with Qt 5.11 (authored by lbeltrame).
Fix build with Qt 5.11
May 10 2018, 7:35 AM
lbeltrame committed R220:605484fd9fc8: Fix build with Qt 5.11 (authored by lbeltrame).
Fix build with Qt 5.11
May 10 2018, 7:29 AM
lbeltrame committed R53:ff046cc41cc1: Merge branch '5.2' (authored by lbeltrame).
Merge branch '5.2'
May 10 2018, 4:56 AM
lbeltrame committed R53:a4a3cfb04005: Fix build with Qt 5.11 (authored by lbeltrame).
Fix build with Qt 5.11
May 10 2018, 4:55 AM

May 5 2018

lbeltrame committed R883:1515099: Allow building with Qt 5.11.
Allow building with Qt 5.11
May 5 2018, 7:32 AM

Apr 28 2018

lbeltrame committed R1003:fb25e68bec81: Add serialization for TouristAttractionVisit (authored by lbeltrame).
Add serialization for TouristAttractionVisit
Apr 28 2018, 10:09 PM
lbeltrame closed D12572: Add serialization for TouristAttractionVisit.
Apr 28 2018, 10:09 PM · KDE PIM
lbeltrame added a comment to D11925: Add "SkipSwitcher" to API.

For now I reverted the commit in kwin to allow building. Once this review is merged, it can be re-instated.

Apr 28 2018, 7:31 AM · Frameworks
lbeltrame committed R108:5ef119044df1: Revert "Add "SkipSwitcher" to API" (authored by lbeltrame).
Revert "Add "SkipSwitcher" to API"
Apr 28 2018, 7:28 AM
lbeltrame added a reverting change for R108:8a2a00a4ca80: Add "SkipSwitcher" to API: R108:5ef119044df1: Revert "Add "SkipSwitcher" to API".
Apr 28 2018, 7:28 AM
lbeltrame requested review of D12572: Add serialization for TouristAttractionVisit.
Apr 28 2018, 7:20 AM · KDE PIM
lbeltrame added a comment to D11925: Add "SkipSwitcher" to API.

Observed this on the openSUSE OBS as well. Please fix the compilation issue or revert.

Apr 28 2018, 6:54 AM · Frameworks

Apr 24 2018

lbeltrame added a comment to T8075: Fix security issues with KAuth support in KIO.

The security review by the SUSE security team of an analogous change in ktexteditor highlighted some problems there. @chinmoyr, you may want to look the review up for reference:

Apr 24 2018, 12:20 PM · Frameworks