lbeltrame (Luca Beltrame)Administrator
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2015, 11:22 PM (286 w, 5 d)
Roles
Administrator
Availability
Available

Recent Activity

May 14 2020

lbeltrame added a comment to D29752: Prefix disk name on size labels.

I don't speak C that well, but it looks OK to me.

May 14 2020, 2:25 PM · Plasma

Apr 10 2020

lbeltrame added a comment to T8075: Fix security issues with KAuth support in KIO.

I have asked, however I don't know when they'll be able to look at it.

Apr 10 2020, 6:32 AM · Frameworks

Apr 3 2020

lbeltrame committed R293:74c17af6aea8: Fix build (authored by lbeltrame).
Fix build
Apr 3 2020, 7:27 AM

Mar 25 2020

lbeltrame committed R205:b5ec534af2dd: Another KIO build fix (authored by lbeltrame).
Another KIO build fix
Mar 25 2020, 11:59 PM
lbeltrame committed R75:1fdabce0aef0: Yet another KIO build fix (authored by lbeltrame).
Yet another KIO build fix
Mar 25 2020, 11:57 PM
lbeltrame committed R81:9f3978dbb6c5: Fix build against recent KIO (authored by lbeltrame).
Fix build against recent KIO
Mar 25 2020, 10:28 PM
lbeltrame committed R75:ce84fd694b99: Fix build against recent KIO (authored by lbeltrame).
Fix build against recent KIO
Mar 25 2020, 10:27 PM
lbeltrame committed R94:dc0353083352: Fix build against recent KIO (authored by lbeltrame).
Fix build against recent KIO
Mar 25 2020, 10:26 PM
lbeltrame committed R166:3b2d4285973e: Fix build against recent KIO (authored by lbeltrame).
Fix build against recent KIO
Mar 25 2020, 9:57 PM
lbeltrame committed R95:ac18f3b6d30e: Fix build against recent KIO (authored by lbeltrame).
Fix build against recent KIO
Mar 25 2020, 9:44 PM

Mar 10 2020

lbeltrame added a reverting change for R155:17ff746ba128: Drop FindAccountsFileDir.cmake: R155:a4ab91424a52: Revert "Drop FindAccountsFileDir.cmake".
Mar 10 2020, 7:55 AM
lbeltrame committed R155:a4ab91424a52: Revert "Drop FindAccountsFileDir.cmake" (authored by lbeltrame).
Revert "Drop FindAccountsFileDir.cmake"
Mar 10 2020, 7:55 AM
lbeltrame committed R155:011dd39f63ef: Revert "Fix .cmake file" (authored by lbeltrame).
Revert "Fix .cmake file"
Mar 10 2020, 7:54 AM
lbeltrame added a reverting change for R155:aba893df8732: Fix .cmake file: R155:011dd39f63ef: Revert "Fix .cmake file".
Mar 10 2020, 7:54 AM
lbeltrame requested changes to D27704: Drop FindAccountsFileDir.cmake.
Mar 10 2020, 7:51 AM
lbeltrame reopened D27704: Drop FindAccountsFileDir.cmake.

"No one using it" is not correct. Or at least, ACCOUNTS_SERVICES_DIR, set in that file, is used by the CMake macros, and it not existing will break builds (see KAccountsMacros.cmake). I'll revert the change (breaks building other projects), but probably it can be fixed if that variable is not used anywhere.

Mar 10 2020, 7:50 AM
lbeltrame committed R155:aba893df8732: Fix .cmake file (authored by lbeltrame).
Fix .cmake file
Mar 10 2020, 6:48 AM

Mar 2 2020

lbeltrame added inline comments to D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available.
Mar 2 2020, 9:19 AM · Plasma
lbeltrame added a comment to T8075: Fix security issues with KAuth support in KIO.

I'm going to re-request a look from the SUSE security team.

Mar 2 2020, 5:33 AM · Frameworks

Feb 28 2020

lbeltrame committed R156:8a35ebada302: Fix build (authored by lbeltrame).
Fix build
Feb 28 2020, 5:57 AM

Feb 27 2020

lbeltrame added a comment to D27633: Port to KPluginLoader.

This currently causes a compile error:

Feb 27 2020, 12:37 PM

Feb 24 2020

lbeltrame added a comment to D27614: build: fix the build where install prefix is not user-writable.

+1

Feb 24 2020, 6:18 AM · Frameworks

Feb 18 2020

lbeltrame committed R120:f6ac1f68e837: Revert "Move kcminit_startup and kded to plasma-session" (authored by lbeltrame).
Revert "Move kcminit_startup and kded to plasma-session"
Feb 18 2020, 8:39 AM
lbeltrame added a reverting change for R120:930e991b0e7e: Move kcminit_startup and kded to plasma-session: R120:f6ac1f68e837: Revert "Move kcminit_startup and kded to plasma-session".
Feb 18 2020, 8:39 AM
lbeltrame added a comment to D27457: Move kcminit_startup and kded to plasma-session.

This completely breaks startup in my system and in openQA:

Feb 18 2020, 6:41 AM · Plasma

Feb 11 2020

lbeltrame added a reviewer for D27319: Fix dragging windows from taskbar to activity pager applet to add to activity: Plasma.
Feb 11 2020, 12:38 PM · Plasma
lbeltrame committed R849:7d17d0f52e9f: Use KDE_INSTALL_LOGGINGCATEGORIESDIR with ECM >= 5.58 (authored by lbeltrame).
Use KDE_INSTALL_LOGGINGCATEGORIESDIR with ECM >= 5.58
Feb 11 2020, 8:38 AM
lbeltrame closed D27312: Use KDE_INSTALL_LOGGINGCATEGORIESDIR with ECM >= 5.58.
Feb 11 2020, 8:38 AM
lbeltrame requested review of D27312: Use KDE_INSTALL_LOGGINGCATEGORIESDIR with ECM >= 5.58.
Feb 11 2020, 8:36 AM

Feb 8 2020

lbeltrame committed R490:f90f9f80184a: Move ecm_generate_pri_file below the definition of the target (authored by lbeltrame).
Move ecm_generate_pri_file below the definition of the target
Feb 8 2020, 1:23 PM
lbeltrame committed R87:c887bc409ae3: Fix another typo causing errors with ECM (authored by lbeltrame).
Fix another typo causing errors with ECM
Feb 8 2020, 1:21 PM
lbeltrame committed R86:1f8d940edf61: Fix another fallout of a recent ECM change (authored by lbeltrame).
Fix another fallout of a recent ECM change
Feb 8 2020, 1:19 PM
lbeltrame added reviewers for D27232: Fix pri file generation: KDE PIM, mlaurent.
Feb 8 2020, 9:49 AM · KDE PIM
lbeltrame updated subscribers of D26394: ECMGeneratePriFile: Fix static configurations.

This breaks stuff in PIM:

Feb 8 2020, 8:38 AM · Build System, Frameworks

Feb 7 2020

lbeltrame accepted D27141: Drop Policykit backend.
Feb 7 2020, 6:24 AM · Frameworks

Feb 1 2020

lbeltrame added a comment to D27062: Handle 410 Gone errors during Calendar sync.

@gbs Do you have commit access? Or do you want someone to commit this change on your behalf?

Feb 1 2020, 9:15 AM · KDE PIM

Jan 31 2020

lbeltrame added a reviewer for D27062: Handle 410 Gone errors during Calendar sync: dvratil.
Jan 31 2020, 2:59 PM · KDE PIM

Jan 20 2020

lbeltrame accepted D9875: Extend parsing ssh prompt.

Just because the "accept" flag was cleared.

Jan 20 2020, 8:24 AM · Plasma

Jan 3 2020

lbeltrame added a reviewer for D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it: bruns.
Jan 3 2020, 6:07 PM · Baloo, Frameworks

Dec 31 2019

lbeltrame added a comment to D26306: Define more documentation search paths (also custom).

+1, would allow us to get rid of some downstream patches.

Dec 31 2019, 1:37 PM · Documentation, Frameworks

Dec 29 2019

lbeltrame committed R1003:8df7515c5edd: Add the Kintetsu files to the QRC (authored by lbeltrame).
Add the Kintetsu files to the QRC
Dec 29 2019, 3:32 PM

Dec 28 2019

lbeltrame committed R1003:8fe0e4298e4d: Add extractors for Kintetsu Railway Limited Express reservations (authored by lbeltrame).
Add extractors for Kintetsu Railway Limited Express reservations
Dec 28 2019, 3:36 PM
lbeltrame closed D26257: Add extractors for Kintetsu Railway Limited Express reservations.
Dec 28 2019, 3:36 PM · KDE PIM
lbeltrame updated the diff for D26257: Add extractors for Kintetsu Railway Limited Express reservations.
  • Merge branch 'master' into kintetsu-extractor
Dec 28 2019, 3:36 PM · KDE PIM
lbeltrame committed R1003:a06afded3e72: Fix extraction of Japanese booking.com reservations (authored by lbeltrame).
Fix extraction of Japanese booking.com reservations
Dec 28 2019, 3:35 PM
lbeltrame closed D26258: Fix extraction of Japanese booking.com reservations.
Dec 28 2019, 3:35 PM · KDE PIM
lbeltrame requested review of D26258: Fix extraction of Japanese booking.com reservations.
Dec 28 2019, 3:21 PM · KDE PIM
lbeltrame added a comment to D26257: Add extractors for Kintetsu Railway Limited Express reservations.

@vkrause I can provide you some anonymized data for your tests if need be.

Dec 28 2019, 3:15 PM · KDE PIM
lbeltrame requested review of D26257: Add extractors for Kintetsu Railway Limited Express reservations.
Dec 28 2019, 3:13 PM · KDE PIM

Nov 26 2019

lbeltrame added a comment to D25106: Also allow invoking session restoration logic when apps are manually launched.

Found also by openQA: two kontact windows get opened.

Nov 26 2019, 8:55 AM · Frameworks

Nov 18 2019

lbeltrame added a comment to D24798: Migrate QQC1 to QQC2.

Fixed in 47c76ebc83ee1f96c7a5fd9be23c6234a93143e8.

Nov 18 2019, 6:58 AM · Plasma
lbeltrame committed R120:47c76ebc83ee: Unbreak SDDM theme loading (authored by lbeltrame).
Unbreak SDDM theme loading
Nov 18 2019, 6:57 AM
lbeltrame added a comment to D24798: Migrate QQC1 to QQC2.

This change prevents the SDDM theme from loading. See https://bugs.kde.org/show_bug.cgi?id=414252. The change to QQC2 in the import in Main.qml causes it, it seems.

Nov 18 2019, 6:52 AM · Plasma

Nov 2 2019

lbeltrame committed R414:8318a15edf1a: Fix build (authored by lbeltrame).
Fix build
Nov 2 2019, 9:33 PM

Oct 27 2019

lbeltrame added a comment to D24865: [SystemTray] Support for AttentionIcon.

+1 to my untrained eye.

Oct 27 2019, 7:51 AM · Plasma

Oct 22 2019

lbeltrame added a comment to D24865: [SystemTray] Support for AttentionIcon.

Tested, works. +1.

Oct 22 2019, 1:01 PM · Plasma

Oct 6 2019

lbeltrame requested changes to D13881: oxygen-demo : add KMessage preview.
Oct 6 2019, 1:00 PM · Plasma
lbeltrame reopened D13881: oxygen-demo : add KMessage preview.

This breaks when building the Oxygen style for Qt4 (which is still a supported build option AFAIK):

Oct 6 2019, 12:59 PM · Plasma

Sep 27 2019

lbeltrame added a comment to T11675: Create Discourse Setup.

Did anyone test the mail interface yet? That would be very useful to reduce friction: in openSUSE, the - proprietary - forum used has a mail interface and this allows people to ask for and offer support according to their medium of choice.

Sep 27 2019, 10:30 AM · Goal: All About the Apps, Sysadmin
lbeltrame added inline comments to D24084: Migrate kwin animation speed to kdeglobals.
Sep 27 2019, 7:57 AM · KWin

Sep 17 2019

lbeltrame added a comment to D24020: Support NetworkManager 1.20 and do actually compile the NM backend.

+1

Sep 17 2019, 10:14 AM · Frameworks

Sep 16 2019

lbeltrame committed R120:8cb5263e76af: Merge remote-tracking branch 'origin/Plasma/5.8' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.8'
Sep 16 2019, 12:16 PM
lbeltrame committed R120:50f3e7004245: Merge remote-tracking branch 'origin/Plasma/5.8' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.8'
Sep 16 2019, 12:16 PM
lbeltrame committed R120:4777e661e8f6: Merge remote-tracking branch 'origin/Plasma/5.8' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.8'
Sep 16 2019, 12:16 PM

Sep 11 2019

lbeltrame committed R120:cf154a59148b: Fix compile (authored by lbeltrame).
Fix compile
Sep 11 2019, 5:09 AM
lbeltrame closed D23846: Fix build error of wrong function reference.
Sep 11 2019, 5:09 AM · Plasma

Sep 10 2019

lbeltrame accepted D23820: [KSieve] Fix messagebox about connection to server lost.

Looks ok to me.

Sep 10 2019, 9:29 AM · KDE PIM
lbeltrame accepted D23814: Make it clear that the error messages are about Sieve.
Sep 10 2019, 8:03 AM · KDE PIM
lbeltrame added a project to T11562: Fix remaining issues with KAuth support in KTexteditor: Kate.
Sep 10 2019, 5:24 AM · Kate
lbeltrame created T11562: Fix remaining issues with KAuth support in KTexteditor.
Sep 10 2019, 5:23 AM · Kate

Sep 4 2019

lbeltrame committed R318:d23fba320f62: Unbreak context menu showing when right clicking on an empty area (authored by lbeltrame).
Unbreak context menu showing when right clicking on an empty area
Sep 4 2019, 9:44 AM

Sep 3 2019

lbeltrame added a comment to D23694: Add support for sshfs to the fstab backend.

fuse.sshfs is used by kdeconnect as well, does that cause some kind of conflict?

Sep 3 2019, 11:56 AM · Frameworks
lbeltrame requested review of D23694: Add support for sshfs to the fstab backend.
Sep 3 2019, 11:44 AM · Frameworks

Aug 11 2019

lbeltrame committed R439:8128bd245d51: Rename the metainfo file (authored by lbeltrame).
Rename the metainfo file
Aug 11 2019, 9:10 PM
lbeltrame committed R130:16c6a2e4f5c5: Merge branch 'Plasma/5.16' (authored by lbeltrame).
Merge branch 'Plasma/5.16'
Aug 11 2019, 8:51 PM
lbeltrame committed R130:13d87f47920b: Fix build with recent frameworks and Qt 5.13 (authored by lbeltrame).
Fix build with recent frameworks and Qt 5.13
Aug 11 2019, 8:51 PM

Aug 10 2019

lbeltrame accepted D23059: Add missing QHash.
Aug 10 2019, 6:16 AM

Aug 9 2019

lbeltrame committed R437:1190610710f9: Merge branch 'Applications/19.08' (authored by lbeltrame).
Merge branch 'Applications/19.08'
Aug 9 2019, 1:59 PM
lbeltrame committed R437:69c492a54b62: Attempt to fix build (authored by lbeltrame).
Attempt to fix build
Aug 9 2019, 1:59 PM
lbeltrame committed R245:cd306b21f9ae: Fix build (authored by lbeltrame).
Fix build
Aug 9 2019, 1:46 PM
lbeltrame committed R350:dfd806c8b42f: Fix metainfo file (wrongly named) (authored by lbeltrame).
Fix metainfo file (wrongly named)
Aug 9 2019, 1:34 PM
lbeltrame committed R156:fd6b3ebfa737: Fix build with Qt 5.13 (authored by lbeltrame).
Fix build with Qt 5.13
Aug 9 2019, 1:30 PM
lbeltrame committed R156:28c996c325e1: Merge branch 'Applications/19.08' (authored by lbeltrame).
Merge branch 'Applications/19.08'
Aug 9 2019, 1:30 PM

Aug 5 2019

lbeltrame committed R487:226bdbdac9e8: Fix build with extra-cmake-modules since commit… (authored by jhirte).
Fix build with extra-cmake-modules since commit…
Aug 5 2019, 12:12 PM

Aug 1 2019

lbeltrame added a comment to T11304: Having a dedicated KDE server/service/location for public gpg keys of tarballers & Co..

Web Key Directory or Web Key Service would fit the bill for this, perhaps?

Aug 1 2019, 12:17 PM · Sysadmin

Jul 31 2019

lbeltrame committed R883:1548172: Remove -ansi compile option.
Remove -ansi compile option
Jul 31 2019, 3:08 PM
lbeltrame accepted D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Not the prettiest, but I've seen worse. ;)

Jul 31 2019, 7:59 AM · Documentation, Frameworks

Jul 26 2019

lbeltrame committed R158:ff9ec863beab: Merge branch 'Applications/19.08' (authored by lbeltrame).
Merge branch 'Applications/19.08'
Jul 26 2019, 6:19 AM
lbeltrame committed R158:68a717f5f759: Support the new logging category directory with KF 5.59+ (authored by lbeltrame).
Support the new logging category directory with KF 5.59+
Jul 26 2019, 6:19 AM
lbeltrame committed R443:931fc8ff674b: Support the new logging category directory in case of KF 5.59+ (authored by lbeltrame).
Support the new logging category directory in case of KF 5.59+
Jul 26 2019, 5:22 AM
lbeltrame committed R443:d6079cb4bdf4: Merge branch 'Applications/19.08' (authored by lbeltrame).
Merge branch 'Applications/19.08'
Jul 26 2019, 5:22 AM

Jul 25 2019

lbeltrame committed R186:546ede9ef712: One more build fix (authored by lbeltrame).
One more build fix
Jul 25 2019, 5:02 AM

Jul 21 2019

lbeltrame committed R470:43e6bbb4721a: Fix build with Qt 5.13 (authored by lbeltrame).
Fix build with Qt 5.13
Jul 21 2019, 7:21 AM
lbeltrame committed R469:79aeb3f4d3cc: Fix build with Qt 5.13 (authored by lbeltrame).
Fix build with Qt 5.13
Jul 21 2019, 7:19 AM
lbeltrame committed R7:035176cb4643: Merge branch '1.7' (authored by lbeltrame).
Merge branch '1.7'
Jul 21 2019, 7:15 AM
lbeltrame committed R7:4d0036617bec: Fix build with Qt 5.13 (authored by lbeltrame).
Fix build with Qt 5.13
Jul 21 2019, 7:15 AM
lbeltrame committed R261:e72565850d4b: Merge branch '5.0' (authored by lbeltrame).
Merge branch '5.0'
Jul 21 2019, 7:12 AM
lbeltrame committed R261:b48fc8588f1f: Fix build with Qt 5.13 (authored by lbeltrame).
Fix build with Qt 5.13
Jul 21 2019, 7:12 AM
lbeltrame committed R71:511d99b7745a: Fix build with Qt 5.13 (authored by lbeltrame).
Fix build with Qt 5.13
Jul 21 2019, 7:08 AM
lbeltrame committed R186:e13ab06f65a4: Add QMap include to fix building under Qt 5.13 (authored by lbeltrame).
Add QMap include to fix building under Qt 5.13
Jul 21 2019, 7:05 AM