- User Since
- Feb 10 2015, 11:22 PM (199 w, 5 d)
Tue, Nov 27
Sun, Nov 25
Fri, Nov 23
As a packager: messing up with user configuration without a clear migration path is a no-no.
Thu, Nov 22
LGTM; just a minor change needed.
Wed, Nov 14
Nov 5 2018
Nov 3 2018
Oct 31 2018
Oct 30 2018
In general (for my limited Baloo knowledge) this makes sense. You might want to add a few CCBUGs if you are aware of specific bugs this alleviates (@ngraham or someone from the bugsquad may help).
Oct 29 2018
Generally looks OK to me, one note on QDir::separator() usage.
Oct 26 2018
Oct 25 2018
Oct 24 2018
The changes look sane to me. Perhaps wait a couple more days until any other objection is raised, then if not, commit away.
+1, but I'd like to hear people more experienced than me.
Oct 17 2018
+1, looks fine to me as far as I understand.
Oct 15 2018
Looks OK to me.
Oct 12 2018
I tried to merge this to master but there the Akonadi DB scheme version is already higher (37), should it be bumped also there?
Oct 4 2018
Oct 3 2018
As this is a visual change, please add screenshots (one for before, one for the after).
Sep 15 2018
Sep 14 2018
+1, but someone else must approve.
Sep 6 2018
Sep 3 2018
I don't understand well the is part of home stuff, do you mean checking for things out of /home?
Aug 31 2018
I would suggest pushing this as a branch of the main kio-extras repository (is your clone just a clone of kio-extras with your changes on top?) to ensure it doesn't get "lost" (and would make merging easier). Eventually a Phabricator diff would also help for people reviewing the code.
Aug 29 2018
Aug 28 2018
Aug 27 2018
Some smallish nitpicks I noticed there. Also, does this mean that NM has WG support now?
Jul 26 2018
Jul 24 2018
@steinalexander: Do you have commit access? Or do you need any of the developers to commit this for you?
Jul 10 2018
Jun 27 2018
Jun 22 2018
I did an accept to undo my earlier "Changes required" because Phab messed up the lines I commented on, and because I realized I wasn't commenting on your specific changes. Sorry about that.
Jun 21 2018
Jun 14 2018
I'm backporting it. Before I push: will this work also with previous KIO versions?
Jun 9 2018
I wonder if this is related to timeline:/ no longer working properly in the file dialog. (didn't investigate yet).
May 31 2018
May 29 2018
May 28 2018
@ltoscano The question was asked due to a bad merge in plasma-desktop, which needed a force push. This commit was originally in the branch, but no longer due to this. Hence, the question: should it be added back?
May 23 2018
I had a quick chat with notmart about this (without going into much detail) and this is the outcome:
Yes, that will need to get packaged. We'll keep you posted.
May 22 2018
May 21 2018
What's the easiest way to test this? I might just patch the package and see what happens.
May 19 2018
May 18 2018
May 12 2018
There's almost nothing done yet mainly because I want to gather feedback first on what the approach should be (to avoid doing work that won't be useful).
May 10 2018
May 5 2018
Apr 28 2018
For now I reverted the commit in kwin to allow building. Once this review is merged, it can be re-instated.
Observed this on the openSUSE OBS as well. Please fix the compilation issue or revert.
Apr 24 2018
The security review by the SUSE security team of an analogous change in ktexteditor highlighted some problems there. @chinmoyr, you may want to look the review up for reference: