- User Since
- Feb 10 2015, 11:22 PM (153 w, 5 d)
Sat, Jan 20
Changes are trivial enough IMO. Perhaps wait one or two days to see if anyone objects, then you can land this.
+1, but someone else must approve.
Fri, Jan 19
I reverted this change in master: this doesn't solve all the problems (places aren't keeping edits now) but at least solves the crash, which is far more critical.
Well, I didn't expect that master and Applications had differing behaviors... Anyway, is there a short-term solution short of undoing the merge (which is hard to do)?
Thu, Jan 18
+1. @broulik How does it look on your side wrt the QJsonDocument usage?
I'm not too fond of assembling JSON by hand, but I guess it was done to avoid dependencies for a tool that's supposed to be simple. I'll let others weigh in on this.
Did you test this change also with filenames with Unicode characters or non-Latin characters?
Examples of each output would be nice.
Tue, Jan 16
Fri, Jan 12
Tue, Jan 9
Sun, Dec 24
I consider detecting for newer driver a feature.
Dec 22 2017
Dec 21 2017
For those who wonder why this would be necessary, see https://mail.kde.org/pipermail/kde-frameworks-devel/2017-December/054139.html.
Dec 20 2017
Nov 10 2017
Nov 9 2017
Nov 3 2017
Oct 30 2017
Oct 28 2017
It looks like it broke building with BUILD_TESTING=OFF:
Oct 21 2017
Oct 19 2017
Oct 13 2017
The commits have been reverted.
The recent commit of some of the revisions caused breakage in KIO, possibly breaking BIC: when starting Dolphin I get.
Sep 30 2017
Trivial change, LGTM.
Sep 27 2017
Doesn't build for me even with cftsio found and used (openSUSE Tumbleweed):
Sep 21 2017
A screenshot before/after (or just after, since it is an addition) would be helpful in this case, since it is a visual change.
Sep 18 2017
@knauss Good point. I think it's not worth relicensing to GPL v3, not because it's a bad license, but due to the massive amount of historical code in KDE PIM. So, to prevent further headaches for distributions, -1 to the license change.
Sep 8 2017
A small number of reviews (this thing is huge). One question: would it be possible to have the bindings per-framework, rather than a single, long list? This is also what made PyKDE4 unwieldy. IOW, each Framework should ship their (optional) bindings.
We can put the tooling in ECM so that everything is in place for all the Frameworks. (This is how the current approach works):
Sep 4 2017
openSUSE package is being done. Progress tracked at https://build.opensuse.org/request/show/520615
Note that since it is a new package for the distribution, it will take a while (reviews) until it actually lands in the distro and then becomes part of the Docker image.
Aug 31 2017
Aug 13 2017
Jul 19 2017
Jul 13 2017
On second thought, and look (and discussion with people more knowledgeable than me), it shouldn't, instead (kdevplatform doesn't use symbol versioning).
Does the actual file name change? If so, I fear we might get some breakage.
openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are available as well.
Jul 12 2017
FTR, Laurent fixed it with https://commits.kde.org/kleopatra/e192f09c1d076cbd54ce0a2fa68ce4aa95fd5ea7.
According to my (limited) understanding, this needs https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=commitdiff;h=05fa2a9c7764b28fdac35eb72631439df948ca0e which is in an unreleased GPGME version. Would it be possible to conditionalize it, or, at worst, warn beforehand when these things occur?
Since this landed, I'm unable to build kleopatra (I'm up to date with libkleo):
Jul 5 2017
Jul 2 2017
Jun 29 2017
Jun 14 2017
Jun 13 2017
May 27 2017
I'll try to test and report back.
May 22 2017
May 19 2017
Months later, it turns out that notify-osd ships a org.freedesktop.Notifications.service already, so it conflicts with the one made by this patch.
May 17 2017
Tested, works (neither kontact nor okular crash with this change).