User Details
- User Since
- Feb 10 2015, 11:22 PM (474 w, 6 d)
- Roles
- Administrator
- Availability
- Available
Oct 24 2020
Any objections? Or I'll merge on Sunday evening UTC+1.
Oct 15 2020
@elvisangelaccio Thanks, first of all. If that's the case, do you think it's better to touch KIO first before landing this?
Would this change be needed on this side or kdeconnect side? I don't mind landing this, but I need formal approval by someone. (I won't have any time to do additional changes elsewhere).
May 14 2020
I don't speak C that well, but it looks OK to me.
Apr 10 2020
I have asked, however I don't know when they'll be able to look at it.
Apr 3 2020
Mar 25 2020
Mar 10 2020
"No one using it" is not correct. Or at least, ACCOUNTS_SERVICES_DIR, set in that file, is used by the CMake macros, and it not existing will break builds (see KAccountsMacros.cmake). I'll revert the change (breaks building other projects), but probably it can be fixed if that variable is not used anywhere.
Mar 2 2020
I'm going to re-request a look from the SUSE security team.
Feb 28 2020
Feb 27 2020
This currently causes a compile error:
Feb 24 2020
+1
Feb 18 2020
This completely breaks startup in my system and in openQA:
Feb 11 2020
Feb 8 2020
This breaks stuff in PIM:
Feb 7 2020
Feb 1 2020
@gbs Do you have commit access? Or do you want someone to commit this change on your behalf?
Jan 31 2020
Jan 20 2020
Just because the "accept" flag was cleared.
Jan 3 2020
Dec 31 2019
+1, would allow us to get rid of some downstream patches.
Dec 29 2019
Dec 28 2019
- Merge branch 'master' into kintetsu-extractor
@vkrause I can provide you some anonymized data for your tests if need be.
Nov 26 2019
Found also by openQA: two kontact windows get opened.
Nov 18 2019
Fixed in 47c76ebc83ee1f96c7a5fd9be23c6234a93143e8.
This change prevents the SDDM theme from loading. See https://bugs.kde.org/show_bug.cgi?id=414252. The change to QQC2 in the import in Main.qml causes it, it seems.
Nov 2 2019
Oct 27 2019
+1 to my untrained eye.
Oct 22 2019
Tested, works. +1.
Oct 6 2019
This breaks when building the Oxygen style for Qt4 (which is still a supported build option AFAIK):
Sep 27 2019
Did anyone test the mail interface yet? That would be very useful to reduce friction: in openSUSE, the - proprietary - forum used has a mail interface and this allows people to ask for and offer support according to their medium of choice.
Sep 17 2019
+1
Sep 16 2019
Sep 11 2019
Sep 10 2019
Looks ok to me.
Sep 4 2019
Sep 3 2019
Aug 11 2019
Aug 10 2019
Aug 9 2019
Aug 5 2019
Aug 1 2019
Web Key Directory or Web Key Service would fit the bill for this, perhaps?
Jul 31 2019
Not the prettiest, but I've seen worse. ;)