[svn] Added basic svn commands logging output.
ClosedPublic

Authored by nikolaik on Fri, May 15, 10:10 PM.

Details

Summary


Added dialog for SVN Update, SVN Revert and SVN Commit actions.
This dialog is universal and prints everything from stdout and stderr (stderr prints in red).
Supports for "Cancel" action which sends terminate signal to a running process.

Test Plan
  1. Try "SVN Commit", "SVN Revert" and "SVN Update" actions from plugin popup menu.
  2. Try "SVN Revert" action from "SVN Commit" dialog.

Diff Detail

Repository
R449 Plugins for Dolphin
Branch
svn_update (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27072
Build 27090: arc lint + arc unit
nikolaik requested review of this revision.Fri, May 15, 10:10 PM
nikolaik created this revision.
nikolaik retitled this revision from Initial commit. to [svn] Added basic svn commands logging output..Fri, May 15, 10:24 PM
nikolaik edited the summary of this revision. (Show Details)
nikolaik edited the test plan for this revision. (Show Details)
meven added inline comments.Sat, May 16, 9:50 AM
svn/fileviewsvnplugin.cpp
349

naming : dialog or progressDialog but progress is not descriptive

458

Same

svn/svnprogressdialog.cpp
109

Not connected.

svn/svnprogressdialog.h
48

Not used yet, I guess you mean to kill the process.

meven added a comment.Sat, May 16, 9:51 AM

canceling svn process leaves a repository in inconsistent state: need to call 'svn cleanup' manually.

Make you plugin inform the user then ? Or automatically cleanup ? or Optionaly cleanup ?

meven added inline comments.Sat, May 16, 9:54 AM
svn/svnprogressdialog.cpp
112

Shouldn't it be Accept then ?

nikolaik updated this revision to Diff 83123.Fri, May 22, 6:18 PM
  • Update in response to review comments.
  • Added new svn commands to cleanup and find repository working copy by a file.
  • Added auto 'svn cleanup'.
  • Fixed names, added comments.
nikolaik edited the summary of this revision. (Show Details)Fri, May 22, 6:19 PM
nikolaik marked 5 inline comments as done.Fri, May 22, 6:23 PM
nikolaik added inline comments.
svn/svnprogressdialog.cpp
112

This is the reject() signal, we are here in case user closes window (with Alt+F4, for example). Even if dialog successed we should reject() it as it is default behavior isn't it?

nikolaik marked an inline comment as done.Fri, May 22, 6:25 PM

canceling svn process leaves a repository in inconsistent state: need to call 'svn cleanup' manually.

Make you plugin inform the user then ? Or automatically cleanup ? or Optionaly cleanup ?

Added auto cleanup.

meven added inline comments.Sat, May 23, 6:45 AM
svn/svncommands.h
158

removeUnversioned, removeIgnored, bool includeExternals, are never used, maybe hook them to a UI checkbox ? confirmation dialog ? A settings ?
Could the user be informed of what is going to be cleanup ?

nikolaik marked 2 inline comments as done.Sat, May 23, 8:30 AM
nikolaik added inline comments.
svn/svncommands.h
158

This parameters are about to be used in additional 'SVN Cleanup...' action.
For now it is necessary only to restore subversion state in case of termination, no need to remove any files.

meven accepted this revision.Sat, May 23, 9:07 AM

I think this can land, and you can move forward.

This revision is now accepted and ready to land.Sat, May 23, 9:07 AM
elvisangelaccio accepted this revision.Sat, May 23, 9:45 PM
elvisangelaccio added inline comments.
svn/svnprogressdialog.ui
32

Please use a more descriptive name, e.g. cancelButton

43

Please use a more descriptive name, e.g. okButton

nikolaik marked an inline comment as done.EditedSun, May 24, 8:37 AM

@elvisangelaccio Can I rename to buttonCancel/buttonOk instead of cancelButton/okButton? If variable name starts with UI element it's easier to use code completion.

@elvisangelaccio Can I rename to buttonCancel/buttonOk instead of cancelButton/okButton? If variable name starts with UI element it's easier to use code completion.

Sure.

nikolaik updated this revision to Diff 83145.Sun, May 24, 7:51 PM
  • Ui elements names changed.
nikolaik marked 3 inline comments as done.Sun, May 24, 7:52 PM
nikolaik closed this revision.Sun, May 24, 8:11 PM