Differential D19288

Respect default web browser system settings in address bar
AbandonedPublic
Actions

Authored by elvisangelaccio on Feb 24 2019, 9:21 PM.

Details

Reviewers
akozlovskiy
Group Reviewers
Dolphin
Summary

This patch makes it possible to use content-based application or .desktop file to open URL from the address bar.

Currently, "in an application based on the contents" setting in Default Application -> Web Browser uses hard-coded Konqueror and "in the following application" setting doesn't work at all.

Test Plan

Check, what application is used to open URL that was typed in address bar.

  • Test all settings in Default Application -> Web Browser
  • Test with Konqueror installed / uninstalled.

Diff Detail

Repository
R318 Dolphin
Branch
respect-default-browser-settings (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8812
Build 8830: arc lint + arc unit
akozlovskiy created this revision.Feb 24 2019, 9:21 PM
Restricted Application added a subscriber: kfm-devel. · View Herald TranscriptFeb 24 2019, 9:21 PM
akozlovskiy requested review of this revision.Feb 24 2019, 9:21 PM
akozlovskiy added a comment.EditedFeb 24 2019, 9:39 PM

"in an application based on the contents" option doesn't work for me with D18838 - "Protocol not supported by Dolphin" when typing "google.com".

akozlovskiy added a comment.Feb 24 2019, 10:22 PM
This comment was removed by akozlovskiy.
akozlovskiy updated this revision to Diff 52515.Feb 25 2019, 10:28 AM
This comment was removed by akozlovskiy.
elvisangelaccio commandeered this revision.Dec 28 2020, 4:50 PM
elvisangelaccio added a reviewer: akozlovskiy.

Closing since this is superseded now.

elvisangelaccio abandoned this revision.Dec 28 2020, 4:50 PM

Revision Contents
Changeset List

PathPackages
Msrc/dolphinviewcontainer.cpp (18 lines)

Diff 52515

View Options

src/dolphinviewcontainer.cpp

Loading...