We might need to use QTextCodec in ark to fix this bug: https://bugs.kde.org/show_bug.cgi?id=393901#c12
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Dec 3 2022
Nov 24 2022
Jun 9 2022
Jul 4 2021
What do we gain by removing it from KIO?
Dec 29 2020
Dec 28 2020
Sorry for the delay.
Patch looks good beside the inline comment. @alexmi Can you fix it?
Merged with b339ac1b5f22efb57619c738eb39268c3e00948d
Given that nothing happened in 3 years and that kio-stash (sadly) is still not very popular, I'm going to merge this patch.
Closing since this is superseded now.
Closing.
In D21937#497112, @meven wrote:In D21937#496989, @elvisangelaccio wrote:Sorry, I missed this one. I'd say let's postpone to 19.12...
No worries
Also we might want to discuss it a bit more, folder moving :
A limitation of the current patch is when a folder is moved, the settings are lost.
I can imagine two potential solution :
- a "bazooka" solution : use inotify and consort to have the settings follow the files.
- a simple solution : use inode id as path in destinationDir for local files. That way if a folder is moved its settings follow. Although it won't survive network moves.
A third solution would be to store the view settings in an extended attribute on the folder itself. That wouldn't survive copying to or from filesystems that don't support xattrs though.
In D25651#580566, @meven wrote:In D25651#570894, @ngraham wrote:This doesn't seem to work for me. When I click on the new menu item, the view refreshes but the item I told it to forget it still visible in the ioslave.
Unfortunately the
In D25651#570894, @ngraham wrote:This doesn't seem to work for me. When I click on the new menu item, the view refreshes but the item I told it to forget it still visible in the ioslave.
I may be due to the asynchronous nature of KActivities::Stats calling dbus and sqlite.
I will see what I can do to improve on the situation.
In D29115#663669, @harogaston wrote:In D29115#662313, @elvisangelaccio wrote:You said it yourself: every setting needs a good amount of clutter code, which makes the overall codebase harder to test and harder to maintain. That's why we try to avoid adding a new setting every time we add a new feature.
We can reconsider if enough people complain about this new behavior not being optional.
So is that a let's go with it? I'm sorry I'm kinda lost as per what you want to do exactly (if anything at all), I don't have much of a say here. My opinion I already gave.
Nov 11 2020
Nov 6 2020
Oct 23 2020
In D23694#676619, @elvisangelaccio wrote:In D23694#676610, @lbeltrame wrote:@elvisangelaccio Thanks, first of all. If that's the case, do you think it's better to touch KIO first before landing this?
Yeah this should probably wait for the KIO patch, which I just submitted: https://invent.kde.org/frameworks/kio/-/merge_requests/175
Oct 18 2020
In D23694#676610, @lbeltrame wrote:@elvisangelaccio Thanks, first of all. If that's the case, do you think it's better to touch KIO first before landing this?
Oct 17 2020
Just my 2 cents: we have telemetry now, so we can actually check whether people prefer single or double click.
Oct 15 2020
In D23694#676607, @lbeltrame wrote:Would this change be needed on this side or kdeconnect side? I don't mind landing this, but I need formal approval by someone. (I won't have any time to do additional changes elsewhere).
Oct 14 2020
Ping? Can we get this in?
Oct 11 2020
I see, so I guess it doesn't hurt to keep KProtocolManager::listing() around and the gain wouldn't be worth the effort.
Oct 8 2020
Yeah I could not find any usage of KProtocolManager::listing(), not even in KIO...
Oct 7 2020
Sep 13 2020
https://dolphin.kde.org/ would be nice but very low-priority. I know there is already plenty of work on the table for the websites people ;)
Sep 9 2020
Fixed by @ognarb after discussing it at today's Website BoF :)
Sep 7 2020
This has been done!
Sep 5 2020
Superseded by D11816
This caused issues so I reverted it for now.
Aug 25 2020
Aug 23 2020
Hi, can you please submit the patch on gitlab? https://invent.kde.org/utilities/ark
Aug 19 2020
As a starter, I'd add a global kill switch in the plasma KCM. KUserFeedback already supports the concept of kill switch AFAICS, we are just missing the UI for it.
Jul 26 2020
@hschaefer Please abandon this review. Thanks :)
Jul 18 2020
Here's a recap. I might accept the patch if:
I'm looking at the code. If I'm not wrong, the URLs are generated by parsing https://kde.org/applications/index.json
Jul 12 2020
Feel free to ship it.
You uploaded a wrong version of the patch. Please do a git rebase master and make sure you only have one commit on top of origin/master.
Jul 5 2020
In D21312#675714, @Zren wrote:I have created a Merge Request on GitLab with a a couple new commits.
https://invent.kde.org/system/dolphin/-/merge_requests/31
- It will only show on devices. It no longer show under mounted folders like Root in the user's favorite places.
- Adurol on Freenode pointed out that the KIO FilePicker now uses KIO::FileSystemFreeSpaceJob, so I've refactored the patch to use that API.
In D27710#627456, @elvisangelaccio wrote:What about 1a98206873d77310a161e2ff7f39afe1060484a0 ? Is it not needed anymore?
@feverfew Does it look good now for you?
Superseded by https://invent.kde.org/system/dolphin/-/merge_requests/7
Superseded by https://invent.kde.org/system/dolphin/-/merge_requests/7
Jun 21 2020
Please either copy the FindTaglib.cmake from ECM master or require KF5 >= 5.72 and don't copy FindTaglib.cmake here.
In D21695#675056, @elvisangelaccio wrote:
Jun 15 2020
Jun 11 2020
Jun 7 2020
@ngraham Does the UI look good? Can we ship this?
Closing as discussed.
Sorry for the delay :(
May 31 2020
May 29 2020
May 28 2020
May 24 2020
In D29788#673711, @nikolaik wrote:@elvisangelaccio Can I rename to buttonCancel/buttonOk instead of cancelButton/okButton? If variable name starts with UI element it's easier to use code completion.
May 23 2020
Not sure if this should go to release/20.04, but I guess it shouldn't hurt.
May 18 2020
May 17 2020
Ah right, sorry :P
@meven Yes please. The patch may be small, but it's not trivial. Smaller atomic changes are always easier to review.
That's because the source is still compressed and we can't get a preview out of it.
Would it make sense to initialize devicePixelRatio to QGuiApplication::devicePixelRatio() and add an API to change it (if desired) ?
Very nice. Please push to release/20.04. Thanks!
May 12 2020
May 11 2020
In D29213#669068, @ngraham wrote:Sounds to me like we should just hide the widget entirely when there's no size available, or a size calculation doesn't make sense given the context.
Use QVector instead of QQueue to avoid adding to the queue twice the same dir for subsequent scanning.
Add a priority queue for path that were not already present in cache.