Feed Advanced Search

Sun, Sep 15

elvisangelaccio committed R318:cb0f6f4d9bf5: Fix failing testWindowTitle() on the KDE CI (authored by elvisangelaccio).
Fix failing testWindowTitle() on the KDE CI
Sun, Sep 15, 7:00 PM
elvisangelaccio accepted D22116: [KStandardItemListWidget] Request the pixmap size we want and let the icon loader scale it.

Sorry for the delay.

Sun, Sep 15, 6:51 PM · Dolphin
elvisangelaccio accepted D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..

Feel free to push after fixing the last two nitpicks.

Sun, Sep 15, 6:48 PM · KIO GDrive
elvisangelaccio committed R241:bcf51ae68193: Add apidox to most of KFilePlacesModel (authored by elvisangelaccio).
Add apidox to most of KFilePlacesModel
Sun, Sep 15, 6:45 PM
elvisangelaccio closed D23961: Add apidox to most of KFilePlacesModel.
Sun, Sep 15, 6:45 PM · Frameworks
elvisangelaccio committed R294:797763d4b4d2: KBookmark: improve addBookmark apidox (authored by elvisangelaccio).
KBookmark: improve addBookmark apidox
Sun, Sep 15, 6:43 PM
elvisangelaccio closed D23955: KBookmark: improve addBookmark apidox.
Sun, Sep 15, 6:43 PM · Frameworks
elvisangelaccio committed R318:681d8bb6cd13: Fix wrong window titles (authored by nazark).
Fix wrong window titles
Sun, Sep 15, 6:40 PM
elvisangelaccio committed R318:79bbadb26319: Introduce test for window titles (authored by elvisangelaccio).
Introduce test for window titles
Sun, Sep 15, 6:40 PM
elvisangelaccio closed D23706: Fix wrong window titles.
Sun, Sep 15, 6:40 PM · Dolphin
elvisangelaccio accepted D23706: Fix wrong window titles.
Sun, Sep 15, 6:40 PM · Dolphin
elvisangelaccio added a comment to T11663: Move URL Navigator into toolbar.

It seems to me that making the URL navigator buttons more discoverable and moving the URL navigator to the toolbar are two orthogonal things.

Sun, Sep 15, 6:35 PM · VDG, Dolphin
elvisangelaccio added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

Needs one more rebase, sorry

Sun, Sep 15, 1:28 PM · Documentation, Dolphin
elvisangelaccio added a comment to D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..

Almost there!

Sun, Sep 15, 1:23 PM · KIO GDrive
elvisangelaccio updated the diff for D23961: Add apidox to most of KFilePlacesModel.

Mention that URLs will be stored in the QUrl::FullyEncoded string format.

Sun, Sep 15, 1:09 PM · Frameworks
elvisangelaccio updated the diff for D23961: Add apidox to most of KFilePlacesModel.
  • Fixed typo
Sun, Sep 15, 1:04 PM · Frameworks
elvisangelaccio requested review of D23961: Add apidox to most of KFilePlacesModel.
Sun, Sep 15, 1:01 PM · Frameworks
elvisangelaccio committed R241:90c5872c08de: KFilePlacesModel: fix @since tags (authored by elvisangelaccio).
KFilePlacesModel: fix @since tags
Sun, Sep 15, 10:54 AM
elvisangelaccio closed D23956: KFilePlacesModel: fix @since tags.
Sun, Sep 15, 10:54 AM · Frameworks
elvisangelaccio added a comment to D23956: KFilePlacesModel: fix @since tags.

Yeah, that's my next patch ;)

Sun, Sep 15, 10:50 AM · Frameworks
elvisangelaccio requested review of D23956: KFilePlacesModel: fix @since tags.
Sun, Sep 15, 10:46 AM · Frameworks
elvisangelaccio added a comment to D23955: KBookmark: improve addBookmark apidox.

OK (why does this matter to the user of the class, though?)

Sun, Sep 15, 10:27 AM · Frameworks
elvisangelaccio requested review of D23955: KBookmark: improve addBookmark apidox.
Sun, Sep 15, 10:16 AM · Frameworks
elvisangelaccio accepted D23757: Clean up hamburger menu and viewport and single-folder context menus.
Sun, Sep 15, 10:10 AM · Dolphin
elvisangelaccio added a comment to D23706: Fix wrong window titles.

Nice, this seems to do the trick :)

Sun, Sep 15, 9:57 AM · Dolphin
elvisangelaccio committed R318:b4188442d184: Bring back placesitemmodeltest (authored by meven).
Bring back placesitemmodeltest
Sun, Sep 15, 8:36 AM
elvisangelaccio added inline comments to D23557: Update dolphin tests following place changes D7446.
Sun, Sep 15, 8:33 AM · Dolphin
elvisangelaccio committed R318:32a4d1dd40f8: Bring back placesitemmodeltest (authored by meven).
Bring back placesitemmodeltest
Sun, Sep 15, 8:30 AM

Sat, Sep 14

elvisangelaccio added a comment to D23706: Fix wrong window titles.

Actually this introduces a regression, sorry about that. dolphin / will now show "Home" as window title...

Sat, Sep 14, 5:16 PM · Dolphin
elvisangelaccio added inline comments to D23757: Clean up hamburger menu and viewport and single-folder context menus.
Sat, Sep 14, 4:24 PM · Dolphin
elvisangelaccio requested changes to D23804: Add Shared Drives to GDriveUrl slave..
Sat, Sep 14, 4:12 PM · KIO GDrive
elvisangelaccio added inline comments to D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..
Sat, Sep 14, 3:53 PM · KIO GDrive
elvisangelaccio added inline comments to D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..
Sat, Sep 14, 3:32 PM · KIO GDrive
elvisangelaccio accepted D23945: Improve icons and text for some actions.

Thanks

Sat, Sep 14, 2:52 PM · Dolphin
elvisangelaccio requested changes to D19311: Add navigation history to forward/back buttons.

Haven't look at the whole diff yet, since the fix for the duplicates could be quite invasive

Sat, Sep 14, 2:49 PM · Dolphin
elvisangelaccio added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

Could you please move the renaming of labels (e.g. "Hidden Files" to "Show Hidden Files") and the addition of icons to different commits? That would make this patch much easier to review.

Sat, Sep 14, 2:23 PM · Dolphin
elvisangelaccio committed R318:67909d867f0e: Fix unused variable warning (authored by elvisangelaccio).
Fix unused variable warning
Sat, Sep 14, 2:10 PM
elvisangelaccio requested changes to D23757: Clean up hamburger menu and viewport and single-folder context menus.
Sat, Sep 14, 1:45 PM · Dolphin
elvisangelaccio committed R318:1a0066dc16f1: This is not unused (authored by iasensio).
This is not unused
Sat, Sep 14, 1:33 PM
elvisangelaccio added inline comments to D23538: [dolphin] Animate gifs on preview.
Sat, Sep 14, 1:30 PM · Dolphin
elvisangelaccio accepted D23557: Update dolphin tests following place changes D7446.
Sat, Sep 14, 12:54 PM · Dolphin
elvisangelaccio requested changes to D23706: Fix wrong window titles.

Please change line 459 to use the following code instead:

Sat, Sep 14, 12:47 PM · Dolphin
elvisangelaccio added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Sat, Sep 14, 12:21 PM · Documentation, Dolphin
elvisangelaccio committed R318:ef5732c89bc5: DolphinTabWidget: cleanup index-by-URL API usage (authored by elvisangelaccio).
DolphinTabWidget: cleanup index-by-URL API usage
Sat, Sep 14, 12:15 PM
elvisangelaccio closed D23860: DolphinTabWidget: cleanup index-by-URL API usage.
Sat, Sep 14, 12:15 PM · Dolphin

Fri, Sep 13

elvisangelaccio accepted D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.
Fri, Sep 13, 8:23 PM · Dolphin
elvisangelaccio added a comment to D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes.

If the on;y thing that EmptyTrashJob::slotFinished() does now is call SimpleJob::slotFinished(), do we even still need to override the base class's implementation of slotFinished()?

Fri, Sep 13, 8:22 PM · Frameworks
elvisangelaccio added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

Please rebase, thanks!

Fri, Sep 13, 8:10 PM · Dolphin
elvisangelaccio requested changes to D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..
Fri, Sep 13, 8:00 PM · KIO GDrive
elvisangelaccio added a comment to D21795: [KAuth] Add support for action details in Polkit1 backend..

polkit-qt-1-0.113.0 has been released, so I believe now we can move over with this patch.

Fri, Sep 13, 1:42 PM · Frameworks
elvisangelaccio added a comment to D7446: [Places panel] Revamp the Recently Saved section.

LGTM besides the inline nitpicks.

Fri, Sep 13, 12:54 PM · Frameworks, Dolphin
elvisangelaccio accepted D23557: Update dolphin tests following place changes D7446.
Fri, Sep 13, 9:57 AM · Dolphin
elvisangelaccio accepted D23693: With autodetect, extract single files archive in current dir.
Fri, Sep 13, 8:49 AM · Ark
elvisangelaccio accepted D23693: With autodetect, extract single files archive in current dir.
Fri, Sep 13, 8:39 AM · Ark

Thu, Sep 12

elvisangelaccio accepted D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds..

Everything looks good and the new test passes for me.

Thu, Sep 12, 11:11 PM · Frameworks
elvisangelaccio accepted D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds..

I don't have 5.14 around atm, so I trust you've tested this :)

Thu, Sep 12, 12:19 PM · Frameworks

Tue, Sep 10

elvisangelaccio requested review of D23860: DolphinTabWidget: cleanup index-by-URL API usage.
Tue, Sep 10, 11:15 PM · Dolphin
elvisangelaccio added a comment to D9775: Trash behaviour improvements: check for the amount of parentReference items on a fileId before processing the delete command in src/kio_gdrive.cpp.

@martijnschmidt Ping. What's the status of this patch?

Tue, Sep 10, 9:41 PM · KIO GDrive
elvisangelaccio added a comment to T9579: Publish Dolphin in the Microsoft Store.

We briefly talked about Dolphin on Windows at the Dolphin BoF today at Akademy. We agreed that Dolphin on Windows should get some more love, since there are users that are using it (from the binary factory). Getting it released "officially" is something we should be looking into.

Tue, Sep 10, 9:16 PM · Dolphin, Windows
elvisangelaccio updated the task description for T9579: Publish Dolphin in the Microsoft Store.
Tue, Sep 10, 9:14 PM · Dolphin, Windows
elvisangelaccio added a comment to T9226: Unify icon/folder views.

This task was briefly discussed at today's Dolphin BoF at Akademy. It was pointed out that the QGraphicsView dependency of the custom view-engine cannot go away, as that would not be worth the effort.

Tue, Sep 10, 9:12 PM · Consistency, Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
elvisangelaccio closed T9795: Use Places Panel code from KIO instead of private implementation as Wontfix.

This task was discussed at today's Dolphin Bof at Akademy. It was agreed that there are techical limitations (custom view-engine) and also possible licensing issues (from GPL to LGPL).

Tue, Sep 10, 9:08 PM · Consistency, Frameworks, Dolphin
elvisangelaccio triaged T11600: Cleanup ReviewBoard as Normal priority.
Tue, Sep 10, 8:44 PM · Dolphin
elvisangelaccio triaged T11599: KUserFeedback integration as High priority.
Tue, Sep 10, 8:40 PM · Dolphin
elvisangelaccio triaged T11598: Stop embedding the Trash KCM and use a button to open it instead as Normal priority.
Tue, Sep 10, 8:28 PM · Dolphin
elvisangelaccio updated subscribers of T5970: NaturalSorting option needs a place in system settings.

We discussed a bit this today at the systemsettings BoF at Akademy with @mart. It is still not clear where these randomly-related KIO config keys should end up, since we currently don't have a "global file management" KCM.

Tue, Sep 10, 8:20 PM · Dolphin, Frameworks
elvisangelaccio added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

While I agree that New Tab/New Window shouldn't be reachable only from the context menu, I'm a bit worried about the height of the control menu. With this patch applied, it is taking almost all the available height on my 1366x768 laptop screen.

Is there maybe some action that we could remove from the control menu? Maybe "Redisplay" ?

I agree with you and I'm all ears regarding things we could remove. Redisplay is definitely a prime candidate IMO.

I noticed recently in the ElementaryOS file manager that the refresh button is integrated into the URL navigator, on the right side. I wonder if we could do that too. That would make it still reachable (more so, in fact) despite not being in the default toolbar or the hamburger menu.

Tue, Sep 10, 10:18 AM · Dolphin
elvisangelaccio accepted D22444: Add Reset Zoom Level action inside View menu.
Tue, Sep 10, 10:05 AM · Documentation, Dolphin
elvisangelaccio added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

And btw D22444 is going to add yet another one action in the menu :D

Tue, Sep 10, 10:03 AM · Dolphin

Mon, Sep 9

elvisangelaccio added a comment to D23693: With autodetect, extract single files archive in current dir.

Hmm I don't know, this might break some workflows :/
Basically with "autodetect subfolder" you can always assume that a folder will be created and some poeple might rely on this.

Mon, Sep 9, 10:22 PM · Ark
elvisangelaccio added a comment to D23475: [baloo-widgets] Apply condensed date to file metadata properties.

Please wait for @elvisangelaccio review before merging, I am not the maintainer.

Mon, Sep 9, 10:15 PM · Dolphin, Baloo
elvisangelaccio requested changes to D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.
Mon, Sep 9, 9:57 PM · Dolphin
elvisangelaccio added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

While I agree that New Tab/New Window shouldn't be reachable only from the context menu, I'm a bit worried about the height of the control menu. With this patch applied, it is taking almost all the available height on my 1366x768 laptop screen.

Mon, Sep 9, 9:45 PM · Dolphin
elvisangelaccio created T11560: Create new set of keys to replace the PIM ones.
Mon, Sep 9, 9:34 PM · KIO GDrive
elvisangelaccio added inline comments to D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.
Mon, Sep 9, 9:23 AM · Dolphin
elvisangelaccio accepted D23412: Fix ascending/descending choosers getting unchecked when re-selecting the same sort order.
Mon, Sep 9, 9:05 AM · Dolphin
elvisangelaccio accepted D23599: Lower the log level for when the mimeFromContent differed from MimeFromExtension.
Mon, Sep 9, 8:57 AM · Ark

Mon, Sep 2

elvisangelaccio committed R318:3df68fb667a9: Merge branch 'Applications/19.08' (authored by elvisangelaccio).
Merge branch 'Applications/19.08'
Mon, Sep 2, 9:20 PM
elvisangelaccio committed R318:a6403716439a: Fixing bugs in new folders in tabs feature (authored by feverfew).
Fixing bugs in new folders in tabs feature
Mon, Sep 2, 9:18 PM
elvisangelaccio closed D23655: Fixing bugs in new folders in tabs feature.
Mon, Sep 2, 9:18 PM · Dolphin
elvisangelaccio committed R318:56b3059f774a: Making sure that DBus objects are all created before the service (authored by feverfew).
Making sure that DBus objects are all created before the service
Mon, Sep 2, 9:18 PM
elvisangelaccio closed D23672: Making sure that DBus objects are all created before the service.
Mon, Sep 2, 9:18 PM · Dolphin
elvisangelaccio added inline comments to D23655: Fixing bugs in new folders in tabs feature.
Mon, Sep 2, 9:16 PM · Dolphin
elvisangelaccio accepted D23655: Fixing bugs in new folders in tabs feature.
Mon, Sep 2, 9:14 PM · Dolphin
elvisangelaccio added inline comments to D23655: Fixing bugs in new folders in tabs feature.
Mon, Sep 2, 8:43 PM · Dolphin
elvisangelaccio accepted D23672: Making sure that DBus objects are all created before the service.

Go for it ;)

Mon, Sep 2, 8:23 PM · Dolphin
elvisangelaccio requested changes to D23655: Fixing bugs in new folders in tabs feature.
Mon, Sep 2, 8:00 PM · Dolphin
elvisangelaccio closed D23654: Fix places text when the URL has a trailing slash.
Mon, Sep 2, 7:32 PM · Dolphin
elvisangelaccio committed R318:c5a713763daf: Fix places text when the URL has a trailing slash (authored by elvisangelaccio).
Fix places text when the URL has a trailing slash
Mon, Sep 2, 7:32 PM
elvisangelaccio added inline comments to D23672: Making sure that DBus objects are all created before the service.
Mon, Sep 2, 6:35 PM · Dolphin

Sun, Sep 1

elvisangelaccio added a comment to D23557: Update dolphin tests following place changes D7446.

Why does the kio test check whether we have recentlyused:/ around, while this one doesn't?

Sun, Sep 1, 8:40 PM · Dolphin
elvisangelaccio accepted D22149: Add "Add to Places" action to file menu.

There seems to be another issue: if I run dolphin <some folder> from cmd line I always get Add 'file' to place, no matter what the folder is.

I traced this down to a pre-existing issue in DolphinViewContainer::url() returns a URL without the trailing slash stripped, and url().fileName() as called in DolphinViewContainer::placesText() returns an empty string if a trailing slash in the URL (this is a documented behavior in QUrl::fileName(): https://doc.qt.io/qt-5/qurl.html#fileName). When you navigate around Dolphin normally, the URL returned by url() has its trailing slash stripped already, but when you open Dolphin with a path, the trailing slash is not stripped, so the behavior is different and the text is wrong.

I think this should be fixed in another patch because it is a pre-existing issue. I would have submitted a patch to fix it already, but I wanted to discuss with you where you think the appropriate fix should be made. DolphinViewContainer::url() could always strip the trailing slash before returning the URL, or perhaps command-line input could have its trailing slash stripped before being passed around in Dolphin. Or both, for safety. What do you think?

Sun, Sep 1, 8:37 PM · Dolphin
elvisangelaccio requested review of D23654: Fix places text when the URL has a trailing slash.
Sun, Sep 1, 8:35 PM · Dolphin
elvisangelaccio abandoned D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

Superseded by D23232.

Sun, Sep 1, 8:12 PM · Dolphin
elvisangelaccio commandeered D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.
Sun, Sep 1, 8:12 PM · Dolphin
Restricted Application added a project to D10246: Toggle search and filter bar: Dolphin.

@mmustac We landed D23232 that supersedes this patch. Can you abandon it?

Sun, Sep 1, 8:12 PM · Dolphin
elvisangelaccio committed R318:3a7586907ed8: [dolphin] Add an action to toggle the searchbar (authored by iasensio).
[dolphin] Add an action to toggle the searchbar
Sun, Sep 1, 8:07 PM
elvisangelaccio closed T8473: Dolphin 'Find' button behavior as Resolved by committing R318:3a7586907ed8: [dolphin] Add an action to toggle the searchbar.
Sun, Sep 1, 8:07 PM · Dolphin
elvisangelaccio closed D23232: [dolphin] Add an action to toggle the searchbar.
Sun, Sep 1, 8:07 PM · Dolphin
elvisangelaccio accepted D23232: [dolphin] Add an action to toggle the searchbar.

Patch looks good, but please note that bug #344617 also asks to make the filter button a toggle.
So either we rename the bug report to only refer to the search button, or this commit should have CCBUG: rather than BUG:.

(I think we should rename the bug report and leave the filter button as-is).

Sun, Sep 1, 8:07 PM · Dolphin