nikolaik (Nikolai Krasheninnikov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 15 2019, 7:00 PM (24 w, 3 d)
Availability
Available

Recent Activity

Tue, May 26

nikolaik closed D29834: Fixes mountiso plugin build failure..
Tue, May 26, 1:44 PM
nikolaik committed R449:f6f1a4808a8f: Fixes mountiso plugin build failure. (authored by nikolaik).
Fixes mountiso plugin build failure.
Tue, May 26, 1:44 PM
nikolaik added reviewers for D29834: Fixes mountiso plugin build failure.: Dolphin, elvisangelaccio, meven, kchoi.
Tue, May 26, 10:30 AM
nikolaik requested review of D29834: Fixes mountiso plugin build failure..
Tue, May 26, 10:28 AM

Sun, May 24

nikolaik committed R449:37b909f57f92: [svn] Added basic svn commands logging output. (authored by nikolaik).
[svn] Added basic svn commands logging output.
Sun, May 24, 8:11 PM
nikolaik closed D29788: [svn] Added basic svn commands logging output..
Sun, May 24, 8:11 PM
nikolaik updated the diff for D29788: [svn] Added basic svn commands logging output..
  • Ui elements names changed.
Sun, May 24, 7:51 PM
nikolaik added a comment to D29788: [svn] Added basic svn commands logging output..

@elvisangelaccio Can I rename to buttonCancel/buttonOk instead of cancelButton/okButton? If variable name starts with UI element it's easier to use code completion.

Sun, May 24, 8:37 AM

Sat, May 23

nikolaik added inline comments to D29788: [svn] Added basic svn commands logging output..
Sat, May 23, 8:30 AM

Fri, May 22

nikolaik added a comment to D29788: [svn] Added basic svn commands logging output..

canceling svn process leaves a repository in inconsistent state: need to call 'svn cleanup' manually.

Make you plugin inform the user then ? Or automatically cleanup ? or Optionaly cleanup ?

Fri, May 22, 6:26 PM
nikolaik added inline comments to D29788: [svn] Added basic svn commands logging output..
Fri, May 22, 6:23 PM
nikolaik updated the summary of D29788: [svn] Added basic svn commands logging output..
Fri, May 22, 6:19 PM
nikolaik updated the diff for D29788: [svn] Added basic svn commands logging output..
  • Update in response to review comments.
  • Added new svn commands to cleanup and find repository working copy by a file.
  • Added auto 'svn cleanup'.
  • Fixed names, added comments.
Fri, May 22, 6:18 PM

Fri, May 15

nikolaik added reviewers for D29788: [svn] Added basic svn commands logging output.: Dolphin, VDG, elvisangelaccio, meven.
Fri, May 15, 10:24 PM
nikolaik requested review of D29788: [svn] Added basic svn commands logging output..
Fri, May 15, 10:10 PM
nikolaik committed R318:9b7fc506aa3a: Added VCS plugins signals connections for outOfVersionControl() actions. (authored by nikolaik).
Added VCS plugins signals connections for outOfVersionControl() actions.
Fri, May 15, 8:09 PM
nikolaik closed D29488: Added VCS plugins signals connections for outOfVersionControl() actions..
Fri, May 15, 8:09 PM · Dolphin
nikolaik added a comment to D29488: Added VCS plugins signals connections for outOfVersionControl() actions..

Commit message should be updated with latest changes.

Fri, May 15, 2:35 PM · Dolphin
nikolaik updated the summary of D29488: Added VCS plugins signals connections for outOfVersionControl() actions..
Fri, May 15, 2:34 PM · Dolphin
nikolaik updated the diff for D29488: Added VCS plugins signals connections for outOfVersionControl() actions..

Update in response to review.

Fri, May 15, 1:13 PM · Dolphin
nikolaik added inline comments to D29488: Added VCS plugins signals connections for outOfVersionControl() actions..
Fri, May 15, 12:36 PM · Dolphin
nikolaik updated the diff for D29488: Added VCS plugins signals connections for outOfVersionControl() actions..

Update in response to review comments.

Fri, May 15, 12:35 PM · Dolphin

Tue, May 12

nikolaik added inline comments to D29488: Added VCS plugins signals connections for outOfVersionControl() actions..
Tue, May 12, 6:45 AM · Dolphin
nikolaik updated the diff for D29488: Added VCS plugins signals connections for outOfVersionControl() actions..

Update in response to review.

Tue, May 12, 6:35 AM · Dolphin
nikolaik committed R449:2f917006dcc7: [svn] Added SVN Checkout dialog. (authored by nikolaik).
[svn] Added SVN Checkout dialog.
Tue, May 12, 6:18 AM
nikolaik closed D29489: [svn] Added SVN Checkout dialog..
Tue, May 12, 6:18 AM

Mon, May 11

nikolaik added a comment to D29488: Added VCS plugins signals connections for outOfVersionControl() actions..

ping

Mon, May 11, 6:42 PM · Dolphin
nikolaik added inline comments to D29489: [svn] Added SVN Checkout dialog..
Mon, May 11, 6:42 PM
nikolaik updated the diff for D29489: [svn] Added SVN Checkout dialog..

Moved from QObject::connect to connect.

Mon, May 11, 6:38 PM
nikolaik updated the diff for D29489: [svn] Added SVN Checkout dialog..

Update in response to review comments.

Mon, May 11, 8:38 AM

Thu, May 7

nikolaik updated the diff for D29489: [svn] Added SVN Checkout dialog..

Improved URL checks.

Thu, May 7, 6:46 PM
nikolaik updated the diff for D29489: [svn] Added SVN Checkout dialog..

More appropriate repo URL validation.

Thu, May 7, 5:18 PM
nikolaik added inline comments to D29489: [svn] Added SVN Checkout dialog..
Thu, May 7, 1:46 PM
nikolaik updated the diff for D29489: [svn] Added SVN Checkout dialog..

Update in response to review comments: added more reuse of 'stripped' variable.

Thu, May 7, 1:24 PM
nikolaik added inline comments to D29489: [svn] Added SVN Checkout dialog..
Thu, May 7, 1:22 PM
nikolaik updated the summary of D29489: [svn] Added SVN Checkout dialog..
Thu, May 7, 12:57 PM

Wed, May 6

nikolaik added inline comments to D29489: [svn] Added SVN Checkout dialog..
Wed, May 6, 6:36 PM
nikolaik added reviewers for D29489: [svn] Added SVN Checkout dialog.: VDG, Dolphin, meven, elvisangelaccio, ngraham.
Wed, May 6, 5:50 PM
nikolaik requested review of D29489: [svn] Added SVN Checkout dialog..
Wed, May 6, 5:45 PM
nikolaik added reviewers for D29488: Added VCS plugins signals connections for outOfVersionControl() actions.: Dolphin, meven, elvisangelaccio.
Wed, May 6, 5:38 PM · Dolphin
nikolaik requested review of D29488: Added VCS plugins signals connections for outOfVersionControl() actions..
Wed, May 6, 5:33 PM · Dolphin

May 4 2020

nikolaik committed R318:61ce7cea1d90: Merge branch 'release/20.04' (authored by nikolaik).
Merge branch 'release/20.04'
May 4 2020, 7:56 PM
nikolaik committed R318:2c72b18661f0: Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is… (authored by nikolaik).
Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is…
May 4 2020, 7:40 PM
nikolaik committed R318:a9e2f01add83: Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is… (authored by nikolaik).
Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is…
May 4 2020, 7:36 PM
nikolaik closed D29345: Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed..
May 4 2020, 7:36 PM · Dolphin
nikolaik added a comment to D29345: Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed..

I wonder is the issue is that F4 was available in the first place.

May 4 2020, 9:39 AM · Dolphin

May 3 2020

nikolaik updated the test plan for D29345: Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed..
May 3 2020, 7:03 PM · Dolphin
nikolaik updated the diff for D29345: Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed..

Removed unnecessary 'else' keyword.

May 3 2020, 7:00 PM · Dolphin

May 1 2020

nikolaik added reviewers for D29345: Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed.: Dolphin, meven, elvisangelaccio, ngraham.
May 1 2020, 5:57 PM · Dolphin
nikolaik requested review of D29345: Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed..
May 1 2020, 5:55 PM · Dolphin

Apr 30 2020

nikolaik committed R449:b0717f10702f: Updates in response to KVersionControlPlugin interface changes. (authored by nikolaik).
Updates in response to KVersionControlPlugin interface changes.
Apr 30 2020, 1:58 PM
nikolaik closed D29042: Updates in response to KVersionControlPlugin interface changes..
Apr 30 2020, 1:58 PM
nikolaik committed R318:67a5ec53ef5a: For VCS-plugin interface added pure virtual function outOfVersionControlActions… (authored by nikolaik).
For VCS-plugin interface added pure virtual function outOfVersionControlActions…
Apr 30 2020, 1:56 PM
nikolaik closed D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().
Apr 30 2020, 1:56 PM · Dolphin
nikolaik added a comment to D29042: Updates in response to KVersionControlPlugin interface changes..

ping
can i push this?

Apr 30 2020, 10:27 AM
nikolaik added a comment to D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().

ping
can i push this?

Apr 30 2020, 10:27 AM · Dolphin
nikolaik added a comment to D29043: Fix 'SVN Log...' crash while watching history in the unversioned directory. Added checks m_log variable contains anything..

@meven i pushed this myself as everyone accepted it but commit is missing at the github mirror https://github.com/KDE/dolphin-plugins
i did something wrong?

Apr 30 2020, 10:26 AM

Apr 27 2020

nikolaik closed D29043: Fix 'SVN Log...' crash while watching history in the unversioned directory. Added checks m_log variable contains anything..
Apr 27 2020, 5:59 AM
nikolaik committed R449:c64770b95b6b: Fix 'SVN Log...' crash while watching history in the unversioned directory. (authored by nikolaik).
Fix 'SVN Log...' crash while watching history in the unversioned directory.
Apr 27 2020, 5:59 AM
nikolaik updated the diff for D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().
  • Update variable names.
Apr 27 2020, 5:53 AM · Dolphin

Apr 26 2020

nikolaik updated the diff for D29042: Updates in response to KVersionControlPlugin interface changes..
  • Update in response to review comments.
Apr 26 2020, 8:00 PM
nikolaik updated the diff for D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().
  • Update in response to review comments.
Apr 26 2020, 7:54 PM · Dolphin

Apr 21 2020

nikolaik added a comment to D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().

All is nice.
Just naming is hard and I'd like to keep it the least confusing possible.
I hope this is not annoying for you.

Apr 21 2020, 5:00 PM · Dolphin
nikolaik updated the diff for D29042: Updates in response to KVersionControlPlugin interface changes..
  • Name change: versionedActions() -> versionControlActions()
Apr 21 2020, 4:47 PM
nikolaik updated the diff for D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().
  • Name change: versionedActions() -> versionControlActions()
  • Name change: isVersioned() -> isVersionControlled()
  • Added comment changes in response to review comments
Apr 21 2020, 4:45 PM · Dolphin
nikolaik updated the diff for D29042: Updates in response to KVersionControlPlugin interface changes..
  • Name changed: unversionedActions() -> outOfVersionControlActions().
Apr 21 2020, 2:39 PM
nikolaik updated the diff for D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().
  • Name changed: unversionedActions() -> outOfVersionControlActions().
Apr 21 2020, 2:38 PM · Dolphin
nikolaik updated the summary of D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().
Apr 21 2020, 1:53 PM · Dolphin
nikolaik updated the summary of D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().
Apr 21 2020, 12:34 PM · Dolphin
nikolaik updated the summary of D29042: Updates in response to KVersionControlPlugin interface changes..
Apr 21 2020, 12:31 PM
nikolaik added a comment to D29043: Fix 'SVN Log...' crash while watching history in the unversioned directory. Added checks m_log variable contains anything..

I would have updated static QSharedPointer< QVector<logEntry> > getLog(const QString& filePath, uint maxEntries = 255, ulong fromRevision = 0); to match its documentation instead

Can you please explain what do you mean? The documentation is also fixed and i think is correct now.

Returning an empty QVector instead of null in getLog would have sufficed and would be somewhat safer as the documentation suggested it did, but didn't.
Anyway that's not very important.

Apr 21 2020, 12:30 PM
nikolaik added a comment to D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().

@meven
I am agree this names might be confusing.
Let's figure out more appropriate names for functions: if we will accept revision this would be for long, lets make it clear.
What do you say about 'actions()' (as it was) and 'additionalActions()' (for any additional actions outside versioned directory, we will mark it in the documentation: the function name itself will be not very meaningful though)?

Apr 21 2020, 10:48 AM · Dolphin
nikolaik added a comment to D29043: Fix 'SVN Log...' crash while watching history in the unversioned directory. Added checks m_log variable contains anything..

I would have updated static QSharedPointer< QVector<logEntry> > getLog(const QString& filePath, uint maxEntries = 255, ulong fromRevision = 0); to match its documentation instead

Apr 21 2020, 10:29 AM
nikolaik updated the test plan for D29043: Fix 'SVN Log...' crash while watching history in the unversioned directory. Added checks m_log variable contains anything..
Apr 21 2020, 10:13 AM
nikolaik added reviewers for D29043: Fix 'SVN Log...' crash while watching history in the unversioned directory. Added checks m_log variable contains anything.: Dolphin, meven, elvisangelaccio.
Apr 21 2020, 10:13 AM
nikolaik requested review of D29043: Fix 'SVN Log...' crash while watching history in the unversioned directory. Added checks m_log variable contains anything..
Apr 21 2020, 10:12 AM
nikolaik updated the summary of D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().
Apr 21 2020, 9:26 AM · Dolphin
nikolaik added reviewers for D29042: Updates in response to KVersionControlPlugin interface changes.: Dolphin, meven, elvisangelaccio.
Apr 21 2020, 9:24 AM
nikolaik requested review of D29042: Updates in response to KVersionControlPlugin interface changes..
Apr 21 2020, 9:24 AM
nikolaik added reviewers for D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions(): Dolphin, meven, elvisangelaccio.
Apr 21 2020, 9:14 AM · Dolphin
nikolaik requested review of D29041: For VCS-plugin interface added pure virtual function outOfVersionControlActions().
Apr 21 2020, 9:12 AM · Dolphin

Apr 12 2020

nikolaik committed R449:4ea1d416415a: [svn] Fixed items status inside unversioned directory. (authored by nikolaik).
[svn] Fixed items status inside unversioned directory.
Apr 12 2020, 7:14 PM
nikolaik committed R449:f691f024aab9: [svn] Fixed items status inside unversioned directory. (authored by nikolaik).
[svn] Fixed items status inside unversioned directory.
Apr 12 2020, 7:12 PM
nikolaik closed D28681: [svn] Fixed items status inside unversioned directory..
Apr 12 2020, 7:12 PM
nikolaik set the repository for D28681: [svn] Fixed items status inside unversioned directory. to R449 Plugins for Dolphin.
Apr 12 2020, 6:52 PM
nikolaik updated the diff for D28681: [svn] Fixed items status inside unversioned directory..

Thanks for comments!
Update done.

Apr 12 2020, 11:54 AM
nikolaik set the repository for D28681: [svn] Fixed items status inside unversioned directory. to R449 Plugins for Dolphin.
Apr 12 2020, 11:31 AM
nikolaik updated the diff for D28681: [svn] Fixed items status inside unversioned directory..

Update in response to comments.

Apr 12 2020, 11:28 AM

Apr 11 2020

nikolaik updated the diff for D28681: [svn] Fixed items status inside unversioned directory..

Update in response to review comments.

Apr 11 2020, 4:52 PM

Apr 9 2020

nikolaik updated the test plan for D28681: [svn] Fixed items status inside unversioned directory..
Apr 9 2020, 10:36 AM
nikolaik updated the test plan for D28681: [svn] Fixed items status inside unversioned directory..
Apr 9 2020, 10:36 AM

Apr 8 2020

nikolaik updated the test plan for D28681: [svn] Fixed items status inside unversioned directory..
Apr 8 2020, 4:36 PM
nikolaik requested review of D28681: [svn] Fixed items status inside unversioned directory..
Apr 8 2020, 4:34 PM

Mar 24 2020

nikolaik added a watcher for Dolphin: nikolaik.
Mar 24 2020, 10:51 AM

Mar 20 2020

nikolaik requested review of D28170: Dolphin-SVN: code update.
Mar 20 2020, 8:17 PM

Mar 19 2020

nikolaik updated the diff for D28102: SVN: added SVN Log dialog.

Update in response to comments.

Mar 19 2020, 7:28 AM

Mar 18 2020

nikolaik updated the diff for D28102: SVN: added SVN Log dialog.

SVNCommands -> SvnCommands

Mar 18 2020, 10:31 AM
nikolaik added a comment to D28102: SVN: added SVN Log dialog.

From a quick look it seems there is a lot of refactored code, this could be done separately in another commit, right?

Mar 18 2020, 10:29 AM
nikolaik updated the diff for D28102: SVN: added SVN Log dialog.

Update in response to comments: fixed CMakeLists.txt and other code problems.

Mar 18 2020, 9:57 AM

Mar 17 2020

nikolaik added a comment to D28102: SVN: added SVN Log dialog.

Dialog looks and behaves similar to a TortoiseSVN one.

Don't make dialogs to looks like 3-th party software, we have log in git, you can make like that, also it pretty simple.

Mar 17 2020, 8:24 PM