User Details
- User Since
- Dec 15 2019, 7:00 PM (227 w, 3 d)
- Availability
- Available
May 26 2020
May 24 2020
- Ui elements names changed.
@elvisangelaccio Can I rename to buttonCancel/buttonOk instead of cancelButton/okButton? If variable name starts with UI element it's easier to use code completion.
May 23 2020
May 22 2020
- Update in response to review comments.
- Added new svn commands to cleanup and find repository working copy by a file.
- Added auto 'svn cleanup'.
- Fixed names, added comments.
May 15 2020
Update in response to review.
Update in response to review comments.
May 12 2020
Update in response to review.
May 11 2020
ping
Moved from QObject::connect to connect.
Update in response to review comments.
May 7 2020
Improved URL checks.
More appropriate repo URL validation.
Update in response to review comments: added more reuse of 'stripped' variable.
May 6 2020
May 4 2020
May 3 2020
Removed unnecessary 'else' keyword.
May 1 2020
Apr 30 2020
ping
can i push this?
ping
can i push this?
@meven i pushed this myself as everyone accepted it but commit is missing at the github mirror https://github.com/KDE/dolphin-plugins
i did something wrong?
Apr 27 2020
- Update variable names.
Apr 26 2020
- Update in response to review comments.
- Update in response to review comments.
Apr 21 2020
- Name change: versionedActions() -> versionControlActions()
- Name change: versionedActions() -> versionControlActions()
- Name change: isVersioned() -> isVersionControlled()
- Added comment changes in response to review comments
- Name changed: unversionedActions() -> outOfVersionControlActions().
- Name changed: unversionedActions() -> outOfVersionControlActions().
@meven
I am agree this names might be confusing.
Let's figure out more appropriate names for functions: if we will accept revision this would be for long, lets make it clear.
What do you say about 'actions()' (as it was) and 'additionalActions()' (for any additional actions outside versioned directory, we will mark it in the documentation: the function name itself will be not very meaningful though)?
Apr 12 2020
Thanks for comments!
Update done.
Update in response to comments.
Apr 11 2020
Update in response to review comments.
Apr 9 2020
Apr 8 2020
Mar 24 2020
Mar 20 2020
Mar 19 2020
Update in response to comments.
Mar 18 2020
SVNCommands -> SvnCommands
Update in response to comments: fixed CMakeLists.txt and other code problems.