Differential D7696

Add "Width" and "Height" separately to Additional Information -> Images
AbandonedPublic
Actions

Authored by elvisangelaccio on Sep 5 2017, 1:18 AM.

Details

Reviewers
emmanuelp
wael.ch
Group Reviewers
Dolphin
KDE Applications
Summary

Bug 374559

This patch permits to add separate Width and Height columns to Dolphin's Details view alongside Image Size.

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
wael.ch created this revision.Sep 5 2017, 1:18 AM
ngraham added a subscriber: ngraham.Sep 5 2017, 1:56 AM

Looks great! I've tested this diff and it works as one would expect it to. Can you reformat your Summary section to be as follows:

<short description of the change> (something like, "Added Individual Width and Height columns to Dolphin's Details view")

BUG: 374559

davidedmundson added a subscriber: davidedmundson.Sep 5 2017, 7:47 AM
davidedmundson added inline comments.
src/kitemviews/private/kbaloorolesprovider.cpp
147

You're setting an entry that ultimately gets stored in a QHash, and duplicating a key used previously.

Can you double check that you've not broken image size.

wael.ch edited the summary of this revision. (Show Details)Sep 5 2017, 11:02 PM
emmanuelp requested changes to this revision.Sep 11 2017, 2:05 PM
This revision now requires changes to proceed.Sep 11 2017, 2:05 PM
elvisangelaccio commandeered this revision.Sep 5 2020, 11:44 PM
elvisangelaccio added a reviewer: wael.ch.
Restricted Application added a subscriber: kfm-devel. · View Herald TranscriptSep 5 2020, 11:44 PM
elvisangelaccio abandoned this revision.Sep 5 2020, 11:44 PM

Revision Contents
Changeset List

Diff 19198

View Options

src/kitemviews/kfileitemmodel.h

Loading...
View Options

src/kitemviews/kfileitemmodel.cpp

Loading...
View Options

src/kitemviews/private/kbaloorolesprovider.cpp

Loading...