Differential D27976

WIP: UI for maximumFileSize showing correctly, but not working as expected
AbandonedPublic
Actions

Authored by elvisangelaccio on Mar 11 2020, 7:51 AM.

Details

Reviewers
meven
pingala
Group Reviewers
Dolphin
Summary

FEATURE: 331240
Made the UI for the maximum-file-limit for showing the thumbnail in the previews section of settings ,
but cant get it to work, files larger than the limit still showing their thumbnails.

previously

updated

Diff Detail

Repository
R318 Dolphin
Branch
ui_for_maxFileSize (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23535
Build 23553: arc lint + arc unit
pingala created this revision.Mar 11 2020, 7:51 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 11 2020, 7:51 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
pingala requested review of this revision.Mar 11 2020, 7:51 AM
pingala retitled this revision from FEATURE: 384936 to FEATURE: 331240.Mar 11 2020, 7:53 AM
meven requested changes to this revision.Mar 11 2020, 8:01 AM
meven added a subscriber: meven.

FEATURE: 331240 should be in the text of the review not as the title, and you can add FIXED-IN: 20.04 to the commit comment.
The title should describe what the diff does, not its objective and a be a phrase of some sort.
Ref: https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
And since the patch does not work you can add WIP as title prefix.

This revision now requires changes to proceed.Mar 11 2020, 8:01 AM
pingala retitled this revision from FEATURE: 331240 to WIP: UI for maximumFileSize showing correctly, but not working as expected.Mar 11 2020, 8:07 AM
pingala edited the summary of this revision. (Show Details)
pingala added a comment.Mar 11 2020, 8:12 AM
This comment was removed by pingala.
pingala requested review of this revision.Mar 11 2020, 8:14 AM

Sorry for the wrong format earlier and thanks, I really appreciate your guidance since I am a newbie.

In D27976#625633, @meven wrote:

FEATURE: 331240 should be in the text of the review not as the title, and you can add FIXED-IN: 20.04 to the commit comment.
The title should describe what the diff does, not its objective and a be a phrase of some sort.
Ref: https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
And since the patch does not work you can add WIP as title prefix.

broulik added a subscriber: broulik.Mar 11 2020, 8:57 AM

This setting was removed on purpose, why bring it back?

ngraham added a subscriber: ngraham.Mar 11 2020, 3:18 PM
In D27976#625661, @broulik wrote:

This setting was removed on purpose, why bring it back?

Can you comment on the history here regarding why it was removed? There are various people in https://bugs.kde.org/show_bug.cgi?id=331240 who it seems like would appreciate it being back.

ngraham added a comment.Apr 14 2020, 7:03 PM

Hmm, looks like someone else submitted a patch to do this: D28402. Perhaps we should proceed there instead?

elvisangelaccio added a subscriber: elvisangelaccio.Apr 26 2020, 9:41 PM
In D27976#648403, @ngraham wrote:

Hmm, looks like someone else submitted a patch to do this: D28402. Perhaps we should proceed there instead?

Yes please.

elvisangelaccio commandeered this revision.Jun 7 2020, 10:48 PM
elvisangelaccio abandoned this revision.
elvisangelaccio added a reviewer: pingala.

Closing as discussed.

Revision Contents
Changeset List

Diff 77387

View Options

src/settings/general/previewssettingspage.h

Loading...
View Options

src/settings/general/previewssettingspage.cpp

Loading...