FEATURE: 331240
Made the UI for the maximum-file-limit for showing the thumbnail in the previews section of settings ,
but cant get it to work, files larger than the limit still showing their thumbnails.
previously
updated
No Linters Available |
No Unit Test Coverage |
Buildable 23535 | |
Build 23553: arc lint + arc unit |
FEATURE: 331240 should be in the text of the review not as the title, and you can add FIXED-IN: 20.04 to the commit comment.
The title should describe what the diff does, not its objective and a be a phrase of some sort.
Ref: https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
And since the patch does not work you can add WIP as title prefix.
Sorry for the wrong format earlier and thanks, I really appreciate your guidance since I am a newbie.
Can you comment on the history here regarding why it was removed? There are various people in https://bugs.kde.org/show_bug.cgi?id=331240 who it seems like would appreciate it being back.
Hmm, looks like someone else submitted a patch to do this: D28402. Perhaps we should proceed there instead?