The "KDE Applications" bundle
Sun, Sep 17
@alexeymin Yep, definitely. Thanks for the reminder!
Is this resolved after https://mail.kde.org/pipermail/release-team/2017-September/010596.html ?
Sun, Sep 10
Sat, Sep 9
Wed, Sep 6
It's not right nor wrong, you have to decide if you think it makes sense :)
Can any of you accept this diff or explicitly say that this is incorrect so I can commit or abandon this and move on?
In order to not have it hanging here forever ...
Sun, Sep 3
- Use QStringLiteral around KRFB_VERSION_STRING
Sat, Sep 2
As Albert wrote, you can use whatever version you want: check the version number of the games, or many applications of the edu group.
I'm not sure what is KDE policy about versioning. My impression is that 5.x versions are ok for projects that are not released with KDE Applications (like KTorrent?), but krfb is released together with others that have version numbers like 17.04, 17.08, ...
What do you think?
Fri, Sep 1
Fri, Aug 25
I need to point out that from a security perspective this is a very dangerous change. With autoplay enabled a drive-by-download with a corrupted media file will be autoplayed when the user enters the Download order in dolphin. Chromium downloads files automatically without asking the user and stores them in ~/Downloads. This was an issue which recently hit tracker (baloo is affected in similar ways, just inside KDE nobody cared so far).
Remove all TODO's and just restart timer when selection is changed.
Aug 25 2017
Thanks for the contribution. Some comments after a quick test:
Aug 21 2017
What if we just make it a Nextcloud Notes client instead of reinventing the sync ehm the wheel? :)
Aug 8 2017
Aug 5 2017
Something very useful that we could add are checkbox lists, so you can create todo lists and mark things as done by ticking the checkboxes.
Aug 3 2017
Anyhow, it's good (maybe try to explain why the static is needed in the function).
Actually you don't really need this to be static, just capture it in the lamba as a copy, i.e [this, prevFramebufferPlugin]
Aug 2 2017
Looks good, i'll wait to see if you want to get an exception to commit it to Applications/17.08, otherwise i'll commit to master.
Aug 1 2017
Why this change?
Jul 31 2017
Does what i said make any sense?
Connect settingsChanged() to lambda instead of a slot function; narrow the scope of s_prevFramebufferPlugin to showConfiguration() function only.
Jul 30 2017
Code is prepared to expect "x11" as preferredFramebufferPlugin and automatically change this setting to "xcb".
Do not hardcode possible list of framebuffer plugins in combobox, but instead find actual available plugins at runtime.
If preferred plugin has changed in settings, inform user that krfb needs to be restarted to apply changes.
Fix code indentation issues in krfb/frambuffermanager.cpp and add const reference instead of object copying.
Jul 28 2017
Marking as needs fixes so that it doesn't appear on my "needs review" list while you work on the finishing touches
Jul 24 2017
So he commited it anyway.
Jul 23 2017
Jul 20 2017
I face the problem, when you start with session restore there is not windowhandle when call here -> https://phabricator.kde.org/source/akregator/browse/master/src/mainwindow.cpp;a03c9d7001bdc92059e8cf02eb6f00b4a8019ee6$123
in kxmlgui https://phabricator.kde.org/source/kxmlgui/browse/master/src/kmainwindow.cpp;af76e8add07ffca2104f4ecb82ded43059e6abfb$666 the window becaume parent of part widget and when it's delete it cause part to delete itself.
akregator --session ~/.config/session/<session-id>
Jul 16 2017
Jul 14 2017
This should be closed (by @vpilo presumably, Phabricator doesn't let me do it), because this has been committed back in May already. Changing or removing the shortcut again would potentially affect users, since this is shipping in various distributions since 17.04.2.