KDE ApplicationsRelease
ActivePublic

Details

Description

The "KDE Applications" bundle

Recent Activity

Sun, Sep 17

elvisangelaccio closed T5986: Auto-update bugzilla project versions as Resolved.

@alexeymin Yep, definitely. Thanks for the reminder!

Sun, Sep 17, 10:42 AM · KDE Applications
alexeymin added a comment to T5986: Auto-update bugzilla project versions.

Is this resolved after https://mail.kde.org/pipermail/release-team/2017-September/010596.html ?

Sun, Sep 17, 10:39 AM · KDE Applications

Sun, Sep 10

anthonyfieroni closed D6739: [akregator part] Make sure part is created before restore window by committing R201:d0a5f4159cdd: [akregator] Make sure part is created before main windows is restored.
Sun, Sep 10, 7:01 PM · KDE PIM, KDE Applications
alexeymin closed D7658: Change version to match KDE Applications (17.11.70) by committing R437:dab8b421ebb5: Change version to match KDE Applications (17.11.70).
Sun, Sep 10, 9:28 AM · KDE Applications

Sat, Sep 9

dfaure accepted D6739: [akregator part] Make sure part is created before restore window.
Sat, Sep 9, 12:55 PM · KDE PIM, KDE Applications
anthonyfieroni updated the diff for D6739: [akregator part] Make sure part is created before restore window.
Sat, Sep 9, 5:41 AM · KDE PIM, KDE Applications
anthonyfieroni retitled D6739: [akregator part] Make sure part is created before restore window from [akregator part] Protect part from auto delete to [akregator part] Make sure part is created before restore window.
Sat, Sep 9, 5:40 AM · KDE PIM, KDE Applications

Wed, Sep 6

aacid added a comment to D7658: Change version to match KDE Applications (17.11.70).

It's not right nor wrong, you have to decide if you think it makes sense :)

Wed, Sep 6, 5:31 PM · KDE Applications
alexeymin added a comment to D7658: Change version to match KDE Applications (17.11.70).

Bump
Can any of you accept this diff or explicitly say that this is incorrect so I can commit or abandon this and move on?
In order to not have it hanging here forever ...

Wed, Sep 6, 8:32 AM · KDE Applications
alexeymin added a member for KDE Applications: alexeymin.
Wed, Sep 6, 8:30 AM

Sun, Sep 3

alexeymin added a comment to D7658: Change version to match KDE Applications (17.11.70).
In D7658#142399, @aacid wrote:
Sun, Sep 3, 4:32 PM · KDE Applications
alexeymin updated the diff for D7658: Change version to match KDE Applications (17.11.70).
  • Use QStringLiteral around KRFB_VERSION_STRING
Sun, Sep 3, 4:06 PM · KDE Applications

Sat, Sep 2

ltoscano added a comment to D7658: Change version to match KDE Applications (17.11.70).

As Albert wrote, you can use whatever version you want: check the version number of the games, or many applications of the edu group.

Sat, Sep 2, 5:40 PM · KDE Applications
aacid added a comment to D7658: Change version to match KDE Applications (17.11.70).

Guideline is at https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning

Sat, Sep 2, 5:27 PM · KDE Applications
alexeymin added a comment to D7658: Change version to match KDE Applications (17.11.70).

I'm not sure what is KDE policy about versioning. My impression is that 5.x versions are ok for projects that are not released with KDE Applications (like KTorrent?), but krfb is released together with others that have version numbers like 17.04, 17.08, ...
What do you think?

Sat, Sep 2, 5:14 PM · KDE Applications
alexeymin updated the summary of D7658: Change version to match KDE Applications (17.11.70).
Sat, Sep 2, 5:02 PM · KDE Applications
alexeymin updated the summary of D7658: Change version to match KDE Applications (17.11.70).
Sat, Sep 2, 5:01 PM · KDE Applications

Fri, Sep 1

cfeck added inline comments to D7539: Dolphin - Add autoplay feature for media files.
Fri, Sep 1, 11:57 PM · KDE Applications, Dolphin

Fri, Aug 25

elvisangelaccio added a comment to D7539: Dolphin - Add autoplay feature for media files.

I need to point out that from a security perspective this is a very dangerous change. With autoplay enabled a drive-by-download with a corrupted media file will be autoplayed when the user enters the Download order in dolphin. Chromium downloads files automatically without asking the user and stores them in ~/Downloads. This was an issue which recently hit tracker (baloo is affected in similar ways, just inside KDE nobody cared so far).

Given that I would suggest to move the media playback into a sandbox (e.g. a seccomp enabled helper process which is not allowed to write to files and fork, etc.) and only enable autoplay if there is no risk that this can be used to take over the system by just navigating to a malicious website.

Fri, Aug 25, 9:13 PM · KDE Applications, Dolphin
graesslin added a comment to D7539: Dolphin - Add autoplay feature for media files.

I need to point out that from a security perspective this is a very dangerous change. With autoplay enabled a drive-by-download with a corrupted media file will be autoplayed when the user enters the Download order in dolphin. Chromium downloads files automatically without asking the user and stores them in ~/Downloads. This was an issue which recently hit tracker (baloo is affected in similar ways, just inside KDE nobody cared so far).

Fri, Aug 25, 7:28 PM · KDE Applications, Dolphin
anthonyfieroni added inline comments to D7539: Dolphin - Add autoplay feature for media files.
Fri, Aug 25, 5:42 PM · KDE Applications, Dolphin
anthonyfieroni added a comment to D7539: Dolphin - Add autoplay feature for media files.

Remove all TODO's and just restart timer when selection is changed.

Fri, Aug 25, 5:41 PM · KDE Applications, Dolphin

Aug 25 2017

elvisangelaccio added a comment to D7539: Dolphin - Add autoplay feature for media files.

Thanks for the contribution. Some comments after a quick test:

Aug 25 2017, 2:18 PM · KDE Applications, Dolphin
ltoscano updated subscribers of D7539: Dolphin - Add autoplay feature for media files.
Aug 25 2017, 1:20 PM · KDE Applications, Dolphin
pekkah updated subscribers of D7539: Dolphin - Add autoplay feature for media files.
Aug 25 2017, 1:15 PM · KDE Applications, Dolphin
pekkah edited reviewers for D7539: Dolphin - Add autoplay feature for media files, added: KDE Applications; removed: Plasma.
Aug 25 2017, 1:15 PM · KDE Applications, Dolphin

Aug 21 2017

alex-l added a comment to M105: Katie.

What if we just make it a Nextcloud Notes client instead of reinventing the sync ehm the wheel? :)

Aug 21 2017, 6:24 PM · KDE Connect, KDE Applications

Aug 8 2017

alexeymin closed D6319: krfb: add settings page allowing user to change framebuffer plugin by committing R437:69aa649d9c76: Add settings page allowing user to change framebuffer plugin.
Aug 8 2017, 1:58 AM · KDE Applications

Aug 5 2017

albertvaka added a comment to M105: Katie.

Something very useful that we could add are checkbox lists, so you can create todo lists and mark things as done by ticking the checkboxes.

Aug 5 2017, 10:38 AM · KDE Connect, KDE Applications

Aug 3 2017

aacid accepted D6319: krfb: add settings page allowing user to change framebuffer plugin.

Anyhow, it's good (maybe try to explain why the static is needed in the function).

Aug 3 2017, 9:10 PM · KDE Applications
aacid added a comment to D6319: krfb: add settings page allowing user to change framebuffer plugin.

Actually you don't really need this to be static, just capture it in the lamba as a copy, i.e [this, prevFramebufferPlugin]

No, I've tested that, and it works only for the first time config dialog is shown, the first time lambda is created. If don't make prevFramebufferPlugin static, and capture it by copy, lambda remembers only the initial value of prevFramebufferPlugin, at the moment when QObject connection to lambda is done, and does not see updates to its value. So, on the second dialog show it can behave incorrectly. To make lambda see the updates, we need to capture by reference, and so prevFramebufferPlugin has to be static, to prevent it going out of scope.

Aug 3 2017, 9:09 PM · KDE Applications
jensreuterberg updated the image names of M105: Katie.
Aug 3 2017, 2:39 PM · KDE Connect, KDE Applications
jensreuterberg created M105: Katie.
Aug 3 2017, 2:07 PM · KDE Connect, KDE Applications
alexeymin added a comment to D6319: krfb: add settings page allowing user to change framebuffer plugin.

Actually you don't really need this to be static, just capture it in the lamba as a copy, i.e [this, prevFramebufferPlugin]

Aug 3 2017, 6:44 AM · KDE Applications

Aug 2 2017

aacid added a comment to D6319: krfb: add settings page allowing user to change framebuffer plugin.

Looks good, i'll wait to see if you want to get an exception to commit it to Applications/17.08, otherwise i'll commit to master.

Aug 2 2017, 10:01 PM · KDE Applications

Aug 1 2017

alexeymin added a comment to D6319: krfb: add settings page allowing user to change framebuffer plugin.

Why this change?

Aug 1 2017, 4:03 AM · KDE Applications

Jul 31 2017

aacid added inline comments to D6319: krfb: add settings page allowing user to change framebuffer plugin.
Jul 31 2017, 8:31 PM · KDE Applications
alexeymin added a comment to D6319: krfb: add settings page allowing user to change framebuffer plugin.

Does what i said make any sense?

Jul 31 2017, 9:10 AM · KDE Applications
alexeymin updated the diff for D6319: krfb: add settings page allowing user to change framebuffer plugin.

Connect settingsChanged() to lambda instead of a slot function; narrow the scope of s_prevFramebufferPlugin to showConfiguration() function only.

Jul 31 2017, 9:05 AM · KDE Applications

Jul 30 2017

aacid added inline comments to D6319: krfb: add settings page allowing user to change framebuffer plugin.
Jul 30 2017, 10:16 PM · KDE Applications
alexeymin updated the diff for D6319: krfb: add settings page allowing user to change framebuffer plugin.

Code is prepared to expect "x11" as preferredFramebufferPlugin and automatically change this setting to "xcb".
Do not hardcode possible list of framebuffer plugins in combobox, but instead find actual available plugins at runtime.
If preferred plugin has changed in settings, inform user that krfb needs to be restarted to apply changes.
Fix code indentation issues in krfb/frambuffermanager.cpp and add const reference instead of object copying.

Jul 30 2017, 7:13 AM · KDE Applications

Jul 28 2017

aacid requested changes to D6319: krfb: add settings page allowing user to change framebuffer plugin.

Marking as needs fixes so that it doesn't appear on my "needs review" list while you work on the finishing touches

Jul 28 2017, 8:43 AM · KDE Applications

Jul 24 2017

aacid abandoned D6018: Add shortcut to the statusbar toggling menu entry.
Jul 24 2017, 2:46 PM · KDE Applications
aacid commandeered D6018: Add shortcut to the statusbar toggling menu entry.

So he commited it anyway.

Jul 24 2017, 2:46 PM · KDE Applications

Jul 23 2017

anthonyfieroni added inline comments to D6739: [akregator part] Make sure part is created before restore window.
Jul 23 2017, 10:51 AM · KDE PIM, KDE Applications
dvratil requested changes to D6739: [akregator part] Make sure part is created before restore window.
Jul 23 2017, 9:55 AM · KDE PIM, KDE Applications

Jul 20 2017

anthonyfieroni added a reviewer for D6739: [akregator part] Make sure part is created before restore window: dfaure.

I face the problem, when you start with session restore there is not windowhandle when call here -> https://phabricator.kde.org/source/akregator/browse/master/src/mainwindow.cpp;a03c9d7001bdc92059e8cf02eb6f00b4a8019ee6$123
in kxmlgui https://phabricator.kde.org/source/kxmlgui/browse/master/src/kmainwindow.cpp;af76e8add07ffca2104f4ecb82ded43059e6abfb$666 the window becaume parent of part widget and when it's delete it cause part to delete itself.
Test:
akregator --session ~/.config/session/<session-id>

Jul 20 2017, 4:41 AM · KDE PIM, KDE Applications

Jul 16 2017

anthonyfieroni created D6739: [akregator part] Make sure part is created before restore window.
Jul 16 2017, 5:33 PM · KDE PIM, KDE Applications

Jul 14 2017

rkflx added a comment to D6018: Add shortcut to the statusbar toggling menu entry.

This should be closed (by @vpilo presumably, Phabricator doesn't let me do it), because this has been committed back in May already. Changing or removing the shortcut again would potentially affect users, since this is shipping in various distributions since 17.04.2.

Jul 14 2017, 7:05 AM · KDE Applications
rkflx added 1 commit(s) for D6018: Add shortcut to the statusbar toggling menu entry: R260:567fd7deb6cc: Add keyboard shortcut for statusbar toggling option.
Jul 14 2017, 7:03 AM · KDE Applications