harogaston (Gaston Haro)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2018, 10:19 PM (97 w, 3 d)
Availability
Available

Recent Activity

Jun 15 2020

harogaston committed R319:9c98097cc746: Cursor thickness follows font size (authored by harogaston).
Cursor thickness follows font size
Jun 15 2020, 3:52 AM
harogaston committed R319:a63880664957: Fixes following review (authored by harogaston).
Fixes following review
Jun 15 2020, 3:51 AM
harogaston committed R319:bf47074408d4: Better accesibility to maximize view (authored by harogaston).
Better accesibility to maximize view
Jun 15 2020, 3:51 AM
harogaston committed R319:255502dfc73e: Fixes following review (authored by harogaston).
Fixes following review
Jun 15 2020, 3:51 AM
harogaston committed R319:90743d4d82f2: Cursor thickness follows font size (authored by harogaston).
Cursor thickness follows font size
Jun 15 2020, 3:51 AM
harogaston committed R319:224680a0dc66: Better accesibility to maximize view (authored by harogaston).
Better accesibility to maximize view
Jun 15 2020, 3:51 AM
harogaston committed R319:b06f8df1295b: Merge branch 'toggle-maximize-view-with-double-click' into 'master' (authored by harogaston).
Merge branch 'toggle-maximize-view-with-double-click' into 'master'
Jun 15 2020, 3:51 AM
harogaston committed R319:2e9d8573bc32: Merge branch 'cursor-thickness-follows-font-size' into 'master' (authored by harogaston).
Merge branch 'cursor-thickness-follows-font-size' into 'master'
Jun 15 2020, 3:51 AM

May 5 2020

harogaston added a comment to D29115: Add option to show hidden files and folders last.

You said it yourself: every setting needs a good amount of clutter code, which makes the overall codebase harder to test and harder to maintain. That's why we try to avoid adding a new setting every time we add a new feature.

We can reconsider if enough people complain about this new behavior not being optional.

Like https://bugs.kde.org/show_bug.cgi?id=404955 :(

May 5 2020, 1:22 AM · Dolphin
harogaston added a comment to D29115: Add option to show hidden files and folders last.

You said it yourself: every setting needs a good amount of clutter code, which makes the overall codebase harder to test and harder to maintain. That's why we try to avoid adding a new setting every time we add a new feature.

We can reconsider if enough people complain about this new behavior not being optional.

May 5 2020, 1:22 AM · Dolphin
harogaston added a comment to D28402: Provide ability to configure size cut-off for local file previews.

In fact they are not :
When 0 is set for remote file spinbox it means that only remote files a file smaller than 0 will get a preview (i.e never).
When 0 is set for local file spinbox it means that all local files file will get a preview because in that case we set IgnoreMaximumSize :

job->setIgnoreMaximumSize(itemSubSet.first().isLocalFile() && m_localFileSizePreviewLimit <= 0

This inverse the meaning of the value 0 basically. (The KPreviewJob use the max int value as default for MaximumSize, meaning all local files should have a preview).
If this line was not set, it would be true.

May 5 2020, 1:19 AM · Dolphin
harogaston updated the diff for D28402: Provide ability to configure size cut-off for local file previews.
  • Changed spin-box special value text
  • Update MaximumSize dynamically
May 5 2020, 1:16 AM · Dolphin

May 1 2020

harogaston added a comment to D28402: Provide ability to configure size cut-off for local file previews.

Please push your changes.
Another text would be "Preview Disabled", "Never Preview" but "No Preview" for remote files seems better to me.
And for local files "No Size limit" ?

May 1 2020, 9:11 PM · Dolphin
harogaston added a comment to D28402: Provide ability to configure size cut-off for local file previews.

If you remove the checkbox, then a good UI for letting a zero value turn off the feature would be to replace the text in the spinbox with "No maximum size" or something when it would otherwise display zero. Spectacle does this with its timer feature.

May 1 2020, 2:06 AM · Dolphin

Apr 30 2020

harogaston added a comment to D28402: Provide ability to configure size cut-off for local file previews.

If you remove the checkbox, then a good UI for letting a zero value turn off the feature would be to replace the text in the spinbox with "No maximum size" or something when it would otherwise display zero. Spectacle does this with its timer feature.

Apr 30 2020, 4:11 PM · Dolphin
harogaston added a comment to D29115: Add option to show hidden files and folders last.

About testing, you need to install the tool ctest then go to build dir and run the whole tests with ctest (it has many options to be more clever for instance ctest -R kfileitemmodeltest

Apr 30 2020, 12:52 AM · Dolphin
harogaston added inline comments to D28402: Provide ability to configure size cut-off for local file previews.
Apr 30 2020, 12:45 AM · Dolphin
harogaston updated the test plan for D28402: Provide ability to configure size cut-off for local file previews.
Apr 30 2020, 12:39 AM · Dolphin
harogaston updated the diff for D28402: Provide ability to configure size cut-off for local file previews.

Changes after requests

Apr 30 2020, 12:37 AM · Dolphin

Apr 29 2020

harogaston updated the summary of D28402: Provide ability to configure size cut-off for local file previews.
Apr 29 2020, 10:20 PM · Dolphin

Apr 26 2020

harogaston added a comment to D28402: Provide ability to configure size cut-off for local file previews.

@elvisangelaccio @meven I will address your comments next week (I couldn't find time yet).
Thank you for your feedback.

Apr 26 2020, 11:12 PM · Dolphin

Apr 23 2020

harogaston added a comment to D28402: Provide ability to configure size cut-off for local file previews.

Should we make the information panel follow those settings as well (currently the preview there has no limit, nor plugin limitations) ?
Same question about tooltips.

I think we should. Essentially copying to there code :

const KConfigGroup globalConfig(KSharedConfig::openConfig(), "PreviewSettings");
 m_enabledPlugins = globalConfig.readEntry("Plugins", KIO::PreviewJob::defaultPlugins());
 m_localFileSizeLimit = globalConfig.readEntry("LimitLocalFiles", false);
Apr 23 2020, 9:46 PM · Dolphin
harogaston added a comment to D29115: Add option to show hidden files and folders last.

Well for me it is pretty clear that this should be at least an option, if not the default. If you don't work with hidden files visible then this does nothing. But if you do, like myself, which view do you think is more useful/productive:

Apr 23 2020, 12:42 PM · Dolphin
harogaston updated the diff for D29115: Add option to show hidden files and folders last.

Ammend previous commit. Remove unrelated change

Apr 23 2020, 3:54 AM · Dolphin
harogaston added reviewers for D29115: Add option to show hidden files and folders last: Dolphin, ngraham.
Apr 23 2020, 3:51 AM · Dolphin
harogaston requested review of D29115: Add option to show hidden files and folders last.
Apr 23 2020, 3:50 AM · Dolphin
harogaston updated the diff for D28402: Provide ability to configure size cut-off for local file previews.

Fixed imports

Apr 23 2020, 3:23 AM · Dolphin

Apr 17 2020

harogaston updated the diff for D28402: Provide ability to configure size cut-off for local file previews.

Changes after review

Apr 17 2020, 9:53 PM · Dolphin
harogaston added inline comments to D28402: Provide ability to configure size cut-off for local file previews.
Apr 17 2020, 9:38 PM · Dolphin
harogaston added a comment to D28402: Provide ability to configure size cut-off for local file previews.

new look
New Look

Apr 17 2020, 12:14 AM · Dolphin
harogaston updated the diff for D28402: Provide ability to configure size cut-off for local file previews.

Removed spinner label as per comments

Apr 17 2020, 12:12 AM · Dolphin

Apr 16 2020

harogaston added inline comments to D28402: Provide ability to configure size cut-off for local file previews.
Apr 16 2020, 11:53 PM · Dolphin
harogaston added inline comments to D28402: Provide ability to configure size cut-off for local file previews.
Apr 16 2020, 12:43 AM · Dolphin

Apr 7 2020

harogaston added a comment to D28397: Replace Vokoscreen with VokoscreenNG.

Great patches, @harogaston! Keep 'em coming! :)

Apr 7 2020, 8:01 PM · Frameworks
harogaston updated the diff for D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported.

Removed unrelated changes

Apr 7 2020, 6:05 PM · Plasma

Apr 4 2020

harogaston added a reviewer for D28548: Fixes printer-manager error messages from exceeding window dimenssions: broulik.
Apr 4 2020, 3:04 AM
harogaston requested review of D28548: Fixes printer-manager error messages from exceeding window dimenssions.
Apr 4 2020, 3:01 AM
harogaston updated the summary of D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported.
Apr 4 2020, 2:56 AM · Plasma
harogaston added a comment to D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported.

Sorry @ngraham I couldn't find who to assign as reviewer. I mean not anything that seemed appropriate. If you know who it would be great. Cheers!

Apr 4 2020, 1:54 AM · Plasma
harogaston added a reviewer for D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported: ngraham.
Apr 4 2020, 1:53 AM · Plasma
harogaston requested review of D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported.
Apr 4 2020, 1:50 AM · Plasma

Apr 3 2020

harogaston added a comment to D28402: Provide ability to configure size cut-off for local file previews.

Any feedback/help on this?

Apr 3 2020, 3:08 AM · Dolphin
harogaston updated the diff for D28397: Replace Vokoscreen with VokoscreenNG.

Removed unnesessary changes to .desktop as indicated

Apr 3 2020, 3:07 AM · Frameworks

Mar 31 2020

harogaston added a comment to D28397: Replace Vokoscreen with VokoscreenNG.
In D28397#637602, @pino wrote:

please do not change translated keys (eg Name[lang]) in desktop-alike files when you change the English string: we have a system in place to handle translations

Mar 31 2020, 12:06 AM · Frameworks

Mar 29 2020

harogaston added reviewers for D28402: Provide ability to configure size cut-off for local file previews: ngraham, Dolphin.
Mar 29 2020, 11:41 AM · Dolphin
harogaston requested review of D28402: Provide ability to configure size cut-off for local file previews.
Mar 29 2020, 11:28 AM · Dolphin
harogaston added a comment to D28397: Replace Vokoscreen with VokoscreenNG.

It seems that of released distros, only Fedora has vokoscreenNG in repositories so far

Mar 29 2020, 7:50 AM · Frameworks
harogaston updated the summary of D28397: Replace Vokoscreen with VokoscreenNG.
Mar 29 2020, 7:07 AM · Frameworks
harogaston added reviewers for D28397: Replace Vokoscreen with VokoscreenNG: KNewStuff, ngraham.
Mar 29 2020, 7:05 AM · Frameworks
harogaston requested review of D28397: Replace Vokoscreen with VokoscreenNG.
Mar 29 2020, 7:02 AM · Frameworks

Jan 3 2020

harogaston added a comment to R318:ac14383e95f9: Use better-named visible and hidden icons.

And at last I found what broke my icon theme 😆

Jan 3 2020, 11:52 PM

Dec 6 2018

harogaston removed a member for Bugsquad: harogaston.
Dec 6 2018, 12:54 PM
harogaston declined E479: Bugsquad Bug Day - Kdenlive.
Dec 6 2018, 12:53 PM · Event: Bugsquad

Oct 2 2018

harogaston added a comment to T8707: Window borders.

@ngraham I could. I went scouting for examples of "the competition" trying to go borderless. Results vary, in form and execution. Some have rounder bottom corners and some don't, some have an outline and others have not. I went through the list of top window managers (taken from https://www.slant.co/topics/390/~best-window-managers-for-linux and https://wiki.archlinux.org/index.php/Window_manager) to find examples of borderless themes. Unsurprisingly I left out tiling window managers.

Oct 2 2018, 11:56 PM · VDG

Oct 1 2018

harogaston added a comment to T8707: Window borders.

I am surprised to see how much (almost all) of the discussion here goes around personal opinions and no effort or intention is seen in bringing in objective facts, research papers, articles, examples, trends etc. I found it irresponsible to decide upon a product used by millions of people this way.

Oct 1 2018, 11:40 PM · VDG
harogaston added a member for Bugsquad: harogaston.
Oct 1 2018, 10:23 PM
harogaston is attending E475: Bugsquad Bug Day - Konsole.
Oct 1 2018, 10:21 PM · Event: Bugsquad