- User Since
- Oct 1 2018, 10:19 PM (97 w, 3 d)
Jun 15 2020
May 5 2020
In fact they are not :
When 0 is set for remote file spinbox it means that only remote files a file smaller than 0 will get a preview (i.e never).
When 0 is set for local file spinbox it means that all local files file will get a preview because in that case we set IgnoreMaximumSize :job->setIgnoreMaximumSize(itemSubSet.first().isLocalFile() && m_localFileSizePreviewLimit <= 0
This inverse the meaning of the value 0 basically. (The KPreviewJob use the max int value as default for MaximumSize, meaning all local files should have a preview).
If this line was not set, it would be true.
- Changed spin-box special value text
- Update MaximumSize dynamically
May 1 2020
Please push your changes.
Another text would be "Preview Disabled", "Never Preview" but "No Preview" for remote files seems better to me.
And for local files "No Size limit" ?
Apr 30 2020
Changes after requests
Apr 29 2020
Apr 26 2020
Apr 23 2020
Well for me it is pretty clear that this should be at least an option, if not the default. If you don't work with hidden files visible then this does nothing. But if you do, like myself, which view do you think is more useful/productive:
Ammend previous commit. Remove unrelated change
Apr 17 2020
Changes after review
Removed spinner label as per comments
Apr 16 2020
Apr 7 2020
Removed unrelated changes
Apr 4 2020
Sorry @ngraham I couldn't find who to assign as reviewer. I mean not anything that seemed appropriate. If you know who it would be great. Cheers!
Apr 3 2020
Any feedback/help on this?
Removed unnesessary changes to .desktop as indicated
Mar 31 2020
Mar 29 2020
Jan 3 2020
And at last I found what broke my icon theme 😆
Dec 6 2018
Oct 2 2018
@ngraham I could. I went scouting for examples of "the competition" trying to go borderless. Results vary, in form and execution. Some have rounder bottom corners and some don't, some have an outline and others have not. I went through the list of top window managers (taken from https://www.slant.co/topics/390/~best-window-managers-for-linux and https://wiki.archlinux.org/index.php/Window_manager) to find examples of borderless themes. Unsurprisingly I left out tiling window managers.
Oct 1 2018
I am surprised to see how much (almost all) of the discussion here goes around personal opinions and no effort or intention is seen in bringing in objective facts, research papers, articles, examples, trends etc. I found it irresponsible to decide upon a product used by millions of people this way.