t/simplify-sending-data-through-socket
AbandonedPublic

Authored by jpalecek on Sun, May 17, 5:52 PM.

Details

Reviewers
None
Group Reviewers
Frameworks
Summary

Simplify sending data through socket, avoid using one large buffer

This makes sending data to kinit easier, but also relays the environment to the restarted process correctly (ie. id doesn't lose it altogether), in line with the functionality of startProcessInternal

Depends on D29810
Signed-off-by: Jiří Paleček <jpalecek@web.de>

Diff Detail

Repository
R285 KCrash
Branch
for-upstream
Lint
Lint OK
Unit
No Unit Test Coverage
jpalecek created this revision.Sun, May 17, 5:52 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, May 17, 5:52 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
jpalecek requested review of this revision.Sun, May 17, 5:52 PM
jpalecek added a dependent revision: D29812: t/handle-errors-from-socket.
jpalecek edited the summary of this revision. (Show Details)Sun, May 17, 6:21 PM
jpalecek added a reviewer: Frameworks.

Your base kcrash is quite out of date - I simplified this method considerably a month ago, which gets rid of the two paths.

Also can you check your commit messages, I don't know if it's phab being weird, but they all start with "t/" in the phab UI,

Your base kcrash is quite out of date - I simplified this method considerably a month ago, which gets rid of the two paths.

It is 5.69. Yeah, now I can see you got rid of it just after that. That is good! But I'm not quite ready for 5.70 yet, that would probably mean recompiling most of KDE (Debian has packages for 5.69 only). I will check out your change and see what remains.

Also can you check your commit messages, I don't know if it's phab being weird, but they all start with "t/" in the phab UI,

Sorry about that. I had all of the patches in topgit, but when I wanted to submit them arc didn't work (only on this particular repository, and the problem was something with curl ... I don't know). So I tried git-phab and it didn't give me chance to edit stuff like arc.

I noticed KDE is moving from phabricator to gitlab. To me at least, that sounds like great news!

But I'm not quite ready for 5.70 yet, that would probably mean recompiling most of KDE

That's not need. Check out master of KCrash, CMakeLists.txt lower kf5 version to match your, compile new patch and test. Then create patch without lower version changes.
That's not cheat since kf5 guarantee backward compatibility.

that would probably mean recompiling most of KDE (Debian has packages for 5.69 only). I will check out your change and see what remains.

This isn't a universal rule that always applies, but generally speaking you can just roll back the the frameworks version in the CMakeLists.txt and build this one framework.

jpalecek abandoned this revision.Sun, May 24, 1:29 AM