Differential D26350

Don't create pixmaps for loglevel icons
ClosedPublic
Actions

Authored by nicolasfella on Jan 1 2020, 7:06 PM.

Tags

None

Subscribers

anthonyfieroni, apol

Details

Reviewers

Group Reviewers

Maniphest Tasks

T12306: Port ksystemlog away from deprecated KIconLoader API

Commits

R351:505c43c52033: Don't create pixmaps for loglevel icons

Summary

We can pass QIcon in all places. Depends on D26347 to be able to see any icons

Test Plan

Still have icons on the left side of the log list

Diff Detail

Repository

R351 KSystemLog

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella requested review of this revision.Jan 1 2020, 7:06 PM

nicolasfella created this revision.

Harbormaster completed remote builds in B20499: Diff 72563.Jan 1 2020, 7:06 PM

Drop iconName method

Harbormaster completed remote builds in B20501: Diff 72565.Jan 1 2020, 7:11 PM

Drop unused iconName member

Harbormaster completed remote builds in B20502: Diff 72566.Jan 1 2020, 7:12 PM

nicolasfella added a task: T12306: Port ksystemlog away from deprecated KIconLoader API.Jan 1 2020, 7:13 PM

nicolasfella added a dependent revision: D26352: Fully port away from KIconThemes.Jan 1 2020, 7:29 PM

apol added a subscriber: apol.Jan 1 2020, 11:38 PM

apol added inline comments.

src/detailDialog.cpp
79	Isn't it weird that setPixmap takes a QString?
src/modes/xsession/xsessionItemBuilder.h
58	The QIcon() constructor isn't necessary.

Address comments

Harbormaster completed remote builds in B20514: Diff 72582.Jan 1 2020, 11:52 PM

nicolasfella marked 2 inline comments as done.Jan 1 2020, 11:53 PM

nicolasfella added inline comments.

src/detailDialog.cpp
79	Good catch, that would have been a regression

apol added inline comments.Jan 1 2020, 11:54 PM

src/modes/base/logLevelFileList.cpp
123	QIcon()

Comment

Harbormaster completed remote builds in B20515: Diff 72583.Jan 1 2020, 11:56 PM

nicolasfella marked an inline comment as done.Jan 1 2020, 11:56 PM

mart accepted this revision.Apr 20 2020, 11:18 AM

This revision is now accepted and ready to land.Apr 20 2020, 11:18 AM

anthonyfieroni added a subscriber: anthonyfieroni.Apr 20 2020, 11:38 AM

anthonyfieroni added inline comments.

src/loggerDialog.cpp
41	Why not QIcon here as well?

nicolasfella added inline comments.Apr 20 2020, 8:21 PM

src/loggerDialog.cpp
41	Good catch, I will investigate in a future patch

Closed by commit R351:505c43c52033: Don't create pixmaps for loglevel icons (authored by nicolasfella). · Explain WhyApr 20 2020, 8:21 PM

This revision was automatically updated to reflect the committed changes.

nicolasfella mentioned this in D29025: Remove unneeded pixmap usage.Apr 20 2020, 8:57 PM

nicolasfella mentioned this in R351:ada5f7d30eb8: Remove unneeded pixmap usage.May 5 2020, 8:17 PM

Revision Contents
Changeset List

			Path	Packages
M			src/detailDialog.cpp (2 lines)
M			src/lib/logLevel.h (4 lines)
M			src/lib/logLevel.cpp (16 lines)
M			src/lib/logModeItemBuilder.cpp (2 lines)
M			src/loggerDialog.cpp (16 lines)
M			src/modes/base/logLevelFileList.cpp (4 lines)
M			src/modes/xorg/xorgItemBuilder.h (2 lines)
M			src/modes/xsession/xsessionItemBuilder.h (2 lines)

Diff 80692

src/detailDialog.cpp

Loading...

src/lib/logLevel.h

Loading...

src/lib/logLevel.cpp

Loading...

src/lib/logModeItemBuilder.cpp

Loading...

src/loggerDialog.cpp

Loading...

src/modes/base/logLevelFileList.cpp

Loading...

src/modes/xorg/xorgItemBuilder.h

Loading...

src/modes/xsession/xsessionItemBuilder.h

Loading...