I am not sure we can just do this given the amount of modules kded loads. Can we be certain that all the modules don't do custom pixmap painting?

I don't know enough about kded to answer your question. I just know this fixes the issue and it works fine with other apps, which may or may not be relevant.

Is that KWin that set titlebar menus?

This patch also fixes buttons in kded dialogs like the wifi password dialog.

In D29815#672682, @anthonyfieroni wrote:

Is that KWin that set titlebar menus?

from #plasma irc

5:02:41 PM <d_ed> kded does not load kwin
5:03:15 PM <d_ed> I believe the appmenu version where it's shown in the title bar is run by kded
5:03:28 PM <d_ed> kwin just triggers a qmenu shown at an explicit x,y
5:04:42 PM <d_ed> motivation at the time was to keep kwin from having too much random code in it... a design philosophy that hasn't aged well!

So change should be fine, (https://phabricator.kde.org/source/plasma-workspace/browse/master/appmenu) since KDED loads only modules they don't know where and when qApp is instantiated.

@davidedmundson What do you think about this patch?

Do I need to change anything or is this acceptable?

Wait @davidedmundson to accept it.

@davidedmundson I hoped this could make it into 5.71 or is it too late now?

You might have more luck migrating this to https://invent.kde.org.

https://community.kde.org/Infrastructure/GitLab

Fair enough.