Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag
ClosedPublic

Authored by mthw on Mon, May 18, 2:01 PM.

Details

Summary

When using fractional scaling, icons in titlebar appmenu are blurred in all apps. This patch fixes the issue.

Test Plan

No side effects.

Diff Detail

Repository
R297 KDED
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27015
Build 27033: arc lint + arc unit
mthw created this revision.Mon, May 18, 2:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMon, May 18, 2:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mthw requested review of this revision.Mon, May 18, 2:01 PM

I am not sure we can just do this given the amount of modules kded loads. Can we be certain that all the modules don't do custom pixmap painting?

mthw added a comment.Mon, May 18, 2:32 PM

I don't know enough about kded to answer your question. I just know this fixes the issue and it works fine with other apps, which may or may not be relevant.

anthonyfieroni added a subscriber: anthonyfieroni.

Is that KWin that set titlebar menus?

mthw added a comment.Tue, May 19, 9:12 AM

This patch also fixes buttons in kded dialogs like the wifi password dialog.

zzag added a comment.Wed, May 20, 2:11 PM

Is that KWin that set titlebar menus?

from #plasma irc

5:02:41 PM <d_ed> kded does not load kwin
5:03:15 PM <d_ed> I believe the appmenu version where it's shown in the title bar is run by kded
5:03:28 PM <d_ed> kwin just triggers a qmenu shown at an explicit x,y
5:04:42 PM <d_ed> motivation at the time was to keep kwin from having too much random code in it... a design philosophy that hasn't aged well!

zzag removed a reviewer: zzag.Wed, May 20, 2:11 PM

So change should be fine, (https://phabricator.kde.org/source/plasma-workspace/browse/master/appmenu) since KDED loads only modules they don't know where and when qApp is instantiated.

mthw added a comment.Fri, May 22, 7:21 PM

@davidedmundson What do you think about this patch?

mthw added a comment.Mon, May 25, 2:31 PM

Do I need to change anything or is this acceptable?

mthw added a comment.Mon, Jun 1, 8:56 AM

@davidedmundson I hoped this could make it into 5.71 or is it too late now?

anthonyfieroni accepted this revision.Mon, Jun 1, 1:11 PM

@ngraham i don't think it's needed this for existing reviews, it's double work for nothing.
It has 2 weeks testing before 5.71 release just push it, it can be reverted if broke something.

This revision is now accepted and ready to land.Mon, Jun 1, 1:11 PM

Fair enough.

ngraham closed this revision.Mon, Jun 1, 1:13 PM