Cleanup dependencies
Changes PlannedPublic

Authored by broulik on Apr 17 2020, 8:22 AM.


Group Reviewers

That unused EditPage::openUrl pulled in KIOWidgets with all its dependencies.
This includes KCompletion which implicitly made that KComboBox work.
Remove this and clean up the dependencies.
NetworkManagerQt seems to pull in Qt::Network but doesn't automatically find it.

Test Plan
  • Still builds
  • Battery critical combo still works
  • Run script combo still works

Diff Detail

R122 Powerdevil
Lint Skipped
Unit Tests Skipped
broulik created this revision.Apr 17 2020, 8:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 17 2020, 8:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 17 2020, 8:22 AM
broulik updated this revision to Diff 80351.
broulik edited the test plan for this revision. (Show Details)
  • Drop all KComboBox uses
anthonyfieroni added inline comments.

That's not right at least. It should be optional when KF5NetworkManagerQt is found. It looks weird to present at all.

broulik added inline comments.May 22 2020, 8:33 AM

Yes, this looks wrong but I don't understand why I even have to add this manually... NetworkManager-Qt CMake looks for Qt5 Network and it also has it in its PUBLIC link interface.

broulik planned changes to this revision.May 29 2020, 6:56 AM

I've noticed I accidentally removed compiling a few things, that also depend on KIO, so maybe not as lean as I hoped